Re: [PATCH v5 2/3] usb: serial: xr_serial: Add gpiochip support
On Sun, Nov 22, 2020 at 10:38:21PM +0530, Manivannan Sadhasivam wrote:
> Add gpiochip support for Maxlinear/Exar USB to serial converter
> for controlling the available gpios.
>
> Inspired from cp210x usb to serial converter driver.
>
> Cc: Linus Walleij
> Cc: linux-g...@vger.kernel.org
> Signed-off-by: Manivannan Sadhasivam
> ---
> drivers/usb/serial/xr_serial.c | 267 -
> 1 file changed, 261 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/usb/serial/xr_serial.c b/drivers/usb/serial/xr_serial.c
> index e166916554d6..ca63527a5310 100644
> --- a/drivers/usb/serial/xr_serial.c
> +++ b/drivers/usb/serial/xr_serial.c
> @@ -9,6 +9,7 @@
> * Copyright (c) 2020 Manivannan Sadhasivam
> */
>
> +#include
> #include
> #include
> #include
> @@ -16,6 +17,28 @@
> #include
> #include
>
> +#ifdef CONFIG_GPIOLIB
> +enum gpio_pins {
> + GPIO_RI = 0,
> + GPIO_CD,
> + GPIO_DSR,
> + GPIO_DTR,
> + GPIO_CTS,
> + GPIO_RTS,
> + GPIO_MAX,
> +};
> +#endif
> +
> +struct xr_port_private {
> +#ifdef CONFIG_GPIOLIB
> + struct gpio_chip gc;
> + bool gpio_registered;
> + enum gpio_pins pin_status[GPIO_MAX];
This isn't an array of enum gpio_pins, rather you use the enum as an
index into the array which only stores a boolean value per pin.
Please rename the array and fix the type (e.g. bool) so that it is clear
how from the name how it is being used, for example, "gpio_requested" or
"gpio_in_use".
> +#endif
> + struct mutex gpio_lock; /* protects GPIO state */
> + bool port_open;
> +};
> +
> struct xr_txrx_clk_mask {
> u16 tx;
> u16 rx0;
> @@ -106,6 +129,8 @@ struct xr_txrx_clk_mask {
> #define XR21V141X_REG_GPIO_CLR 0x1e
> #define XR21V141X_REG_GPIO_STATUS0x1f
>
> +static int xr_cts_rts_check(struct xr_port_private *port_priv);
> +
> static int xr_set_reg(struct usb_serial_port *port, u8 block, u8 reg,
> u8 val)
> {
> @@ -309,6 +334,7 @@ static int xr_uart_disable(struct usb_serial_port *port)
> static void xr_set_flow_mode(struct tty_struct *tty,
>struct usb_serial_port *port)
> {
> + struct xr_port_private *port_priv = usb_get_serial_port_data(port);
> unsigned int cflag = tty->termios.c_cflag;
> int ret;
> u8 flow, gpio_mode;
> @@ -318,6 +344,17 @@ static void xr_set_flow_mode(struct tty_struct *tty,
> return;
>
> if (cflag & CRTSCTS) {
> + /*
> + * Check if the CTS/RTS pins are occupied by GPIOLIB. If yes,
GPIOLIB doesn't "occupy" anything. Use something like "claimed by"
instead.
> + * then use no flow control.
> + */
> + if (xr_cts_rts_check(port_priv)) {
> + dev_dbg(>dev,
> + "CTS/RTS pins are occupied, so disabling flow
> control\n");
Ditto.
And there's no need to ignore a request for sw flow control if the pins
are in use. Just move the check above the conditional and make the
first branch depend on it.
You also need to clear CRTSCTS in termios if it cannot be set.
> + flow = XR21V141X_UART_FLOW_MODE_NONE;
> + goto exit;
> + }
> +
> dev_dbg(>dev, "Enabling hardware flow ctrl\n");
>
> /*
> @@ -341,6 +378,7 @@ static void xr_set_flow_mode(struct tty_struct *tty,
> flow = XR21V141X_UART_FLOW_MODE_NONE;
> }
>
> +exit:
> /*
>* As per the datasheet, UART needs to be disabled while writing to
>* FLOW_CONTROL register.
> @@ -355,18 +393,22 @@ static void xr_set_flow_mode(struct tty_struct *tty,
> static int xr_tiocmset_port(struct usb_serial_port *port,
> unsigned int set, unsigned int clear)
> {
> + struct xr_port_private *port_priv = usb_get_serial_port_data(port);
> u8 gpio_set = 0;
> u8 gpio_clr = 0;
> int ret = 0;
>
> - /* Modem control pins are active low, so set & clr are swapped */
> - if (set & TIOCM_RTS)
> + /*
> + * Modem control pins are active low, so set & clr are swapped. And
> + * ignore the pins that are occupied by GPIOLIB.
> + */
> + if ((set & TIOCM_RTS) && !(port_priv->pin_status[GPIO_RTS]))
> gpio_clr |= XR21V141X_UART_MODE_RTS;
> - if (set & TIOCM_DTR)
> + if ((set & TIOCM_DTR) && !(port_priv->pin_status[GPIO_DTR]))
> gpio_clr |= XR21V141X_UART_MODE_DTR;
> - if (clear & TIOCM_RTS)
> + if ((clear & TIOCM_RTS) && !(port_priv->pin_status[GPIO_RTS]))
> gpio_set |= XR21V141X_UART_MODE_RTS;
> - if (clear & TIOCM_DTR)
> + if ((clear & TIOCM_DTR) && !(port_priv->pin_status[GPIO_DTR]))
> gpio_set |= XR21V141X_UART_MODE_DTR;
>
> /* Writing '0' to gpio_{set/clr} bits has no effect, so no need to do */
> @@ -464,6 +506,7 @@ static void xr_set_termios(struct tty_struct *tty,
>
Re: [PATCH v5 2/3] usb: serial: xr_serial: Add gpiochip support
On Mon, Dec 14, 2020 at 10:19:07AM +0100, Linus Walleij wrote: > On Mon, Dec 14, 2020 at 9:58 AM Johan Hovold wrote: > > On Sat, Dec 12, 2020 at 01:03:32AM +0100, Linus Walleij wrote: > > > > If I google for the phrase "Detected name collision for GPIO name" > > > I just find the code, our discussions and some USB serial devices > > > warning about this so far. > > > > > > Maybe we should just make a patch to disallow it? > > > > That would make it impossible to provide name lines on hotpluggable > > controllers, which would be nice to support. > > I merged a patch for this now, let's tighten this loose end up. > > Also: thanks for poking me about this, I should have looked into > this ages ago :/ focus you know... Yeah, tell me about it. :/ Johan
Re: [PATCH v5 2/3] usb: serial: xr_serial: Add gpiochip support
On Mon, Dec 14, 2020 at 9:58 AM Johan Hovold wrote: > On Sat, Dec 12, 2020 at 01:03:32AM +0100, Linus Walleij wrote: > > If I google for the phrase "Detected name collision for GPIO name" > > I just find the code, our discussions and some USB serial devices > > warning about this so far. > > > > Maybe we should just make a patch to disallow it? > > That would make it impossible to provide name lines on hotpluggable > controllers, which would be nice to support. I merged a patch for this now, let's tighten this loose end up. Also: thanks for poking me about this, I should have looked into this ages ago :/ focus you know... Yours, Linus Walleij
Re: [PATCH v5 2/3] usb: serial: xr_serial: Add gpiochip support
On Sat, Dec 12, 2020 at 01:03:32AM +0100, Linus Walleij wrote: > On Thu, Dec 10, 2020 at 9:53 AM Johan Hovold wrote: > > On Wed, Dec 09, 2020 at 05:25:32PM +0100, Linus Walleij wrote: > > > I just replied to that thread, but to summarize, you can't rely on > > having the sysfs code detect collisions since that will trigger a bunch > > of nasty warnings and backtraces. We also don't want the sysfs interface > > for a specific USB device to depend on probe order (only the first one > > plugged in gets to use the line names). And adding line names now could > > in fact be what breaks currently working scripts. > > Yes the sysfs ABI is very volatile and easy to break. > > As pointed out in the other reply, sysfs base GPIO number is all > wibbly-wobbly on anything hot-pluggable so in a way I feel it > is the right thing to disallow sysfs altogether on hotpluggable > devices. No, the gpio numbers will of course vary, but since gpiolib exports the base number for the chip, a scripts can easily determine the right gpio number as base + offset. Having probe order break that by sometimes exporting the line using it's name is what would be a problem. > > Just did a super quick check and it seems libgpiod still assumes a flat > > name space. For example, gpiod_chip_find_line() returns only the first > > line found that matches a name. Shouldn't be impossible to extend, but > > just want to make sure this flat namespace assumption hasn't been to > > heavily relied upon. > > The unique way to identify a GPIO is gpiochip instance (with > topology from sysfs) and then a line number on that chip. > This is done e.g. in the example tool > tools/gpio/gpio-hammer.c > > As you can see the tool doesn't use these line names. > > The line names are really like symbolic links or something. > But they are indeed in a flat namespace so we should try to > at least make them unique if it turns out people love to use > these. Not necessarily, they could be unique per chip as we're discussing here with respect to hotpluggable controllers. We just can't have it both ways. > As it is now system designers mostly use device tree to assign > line names and they try to make these unique because they don't > like the nasty warnings from gpiolib. > > If I google for the phrase "Detected name collision for GPIO name" > I just find the code, our discussions and some USB serial devices > warning about this so far. > > Maybe we should just make a patch to disallow it? That would make it impossible to provide name lines on hotpluggable controllers, which would be nice to support. Johan
Re: [PATCH v5 2/3] usb: serial: xr_serial: Add gpiochip support
On Thu, Dec 10, 2020 at 9:53 AM Johan Hovold wrote: > On Wed, Dec 09, 2020 at 05:25:32PM +0100, Linus Walleij wrote: > I just replied to that thread, but to summarize, you can't rely on > having the sysfs code detect collisions since that will trigger a bunch > of nasty warnings and backtraces. We also don't want the sysfs interface > for a specific USB device to depend on probe order (only the first one > plugged in gets to use the line names). And adding line names now could > in fact be what breaks currently working scripts. Yes the sysfs ABI is very volatile and easy to break. As pointed out in the other reply, sysfs base GPIO number is all wibbly-wobbly on anything hot-pluggable so in a way I feel it is the right thing to disallow sysfs altogether on hotpluggable devices. > > I am strongly encouraging any developer with a few spare cycles > > on their hands to go and implement the debugfs facility because > > we can make it so much better than the sysfs, easier and > > more convenient for testing etc. > > Don't you run the risk of having people enable debugfs in production > systems now just so they can use the old-style interface? That risk always exist of course. For this and many other reasons. I just have to trust developers to understand that debugfs is named debugfs for a reason. > Side note: if you skip the "export" part of the interface, how would you > indicate that a line is already in use or not available (e.g. > gpio-range-reserved)? The idea is that if you poke around there you know what you're doing or ready to face the consequences. I am thinking if people want to toggle LEDs and switches from debugfs for testing and hacking they'd be alright with corrupting the SPI interface if they make mistakes. The chardev ABI is the only thing which we really designed with some users, multiple users, compatibility and security in mind, yet we had to revamp it once from scratch... > Just did a super quick check and it seems libgpiod still assumes a flat > name space. For example, gpiod_chip_find_line() returns only the first > line found that matches a name. Shouldn't be impossible to extend, but > just want to make sure this flat namespace assumption hasn't been to > heavily relied upon. The unique way to identify a GPIO is gpiochip instance (with topology from sysfs) and then a line number on that chip. This is done e.g. in the example tool tools/gpio/gpio-hammer.c As you can see the tool doesn't use these line names. The line names are really like symbolic links or something. But they are indeed in a flat namespace so we should try to at least make them unique if it turns out people love to use these. As it is now system designers mostly use device tree to assign line names and they try to make these unique because they don't like the nasty warnings from gpiolib. If I google for the phrase "Detected name collision for GPIO name" I just find the code, our discussions and some USB serial devices warning about this so far. Maybe we should just make a patch to disallow it? Yours, Linus Walleij
Re: [PATCH v5 2/3] usb: serial: xr_serial: Add gpiochip support
On Thu, Dec 10, 2020 at 09:53:45AM +0100, Johan Hovold wrote: > On Wed, Dec 09, 2020 at 05:25:32PM +0100, Linus Walleij wrote: > > On Wed, Dec 9, 2020 at 4:24 PM Johan Hovold wrote: > > > So it sounds like there's nothing preventing per-chip-unique names in > > > the rest of gpiolib and the new chardev interface then? Are the > > > user-space libraries able to cope with it, etc? > > > > Yes the documentation refers to libgpiod a very well maintained > > library: > > https://www.kernel.org/doc/html/latest/driver-api/gpio/using-gpio.html > > https://git.kernel.org/pub/scm/libs/libgpiod/libgpiod.git/ > > Just did a super quick check and it seems libgpiod still assumes a flat > name space. For example, gpiod_chip_find_line() returns only the first > line found that matches a name. Shouldn't be impossible to extend, but > just want to make sure this flat namespace assumption hasn't been to > heavily relied upon. That should have been gpiod_line_find() (which in turn uses the above mentioned helper for per-chip lookups). Johan
Re: [PATCH v5 2/3] usb: serial: xr_serial: Add gpiochip support
On Wed, Dec 09, 2020 at 05:25:32PM +0100, Linus Walleij wrote: > On Wed, Dec 9, 2020 at 4:24 PM Johan Hovold wrote: > > On Tue, Dec 08, 2020 at 01:41:52PM +0100, Linus Walleij wrote: > > > > depends on !GPIO_SYSFS > > > > > > so it can't even be compiled in if someone is using the sysfs. > > > > > > That should solve the situation where people are (ab)using > > > the sysfs and getting name collisions as a result. > > > > Would it possible to set a flag to suppress just the sysfs entry > > renaming instead? > > Hm you mean that when a GPIO is "exported" in sysfs > it should not get a symbolic name from the names but instead > just the number? Right. > I bet someone has written their scripts to take advantage of > the symbolic names so I suspect the task becomes bigger > like suppress the sysfs entry renaming if and only if there is > a namespace collision. > > But I think we can do that, doesn't seem too hard? > > I just hacked up this: > https://lore.kernel.org/linux-gpio/20201209161821.92931-1-linus.wall...@linaro.org/T/#u I just replied to that thread, but to summarize, you can't rely on having the sysfs code detect collisions since that will trigger a bunch of nasty warnings and backtraces. We also don't want the sysfs interface for a specific USB device to depend on probe order (only the first one plugged in gets to use the line names). And adding line names now could in fact be what breaks currently working scripts. > > Despite its flaws the sysfs interface is still very convenient and I'd > > prefer not to disable it just because of the line names. > > Would these conveniences be identical to those listed > in my recent TODO entry? > https://lore.kernel.org/linux-gpio/20201204083533.65830-1-linus.wall...@linaro.org/ Indeed. > There are several other issues with the sysfs, so making it conflict > with other drivers is almost plus in the direction of discouragement > from the GPIO submaintainer point of view, but I do see that > people like it for the reasons in the TODO. :/ > > I am strongly encouraging any developer with a few spare cycles > on their hands to go and implement the debugfs facility because > we can make it so much better than the sysfs, easier and > more convenient for testing etc. Don't you run the risk of having people enable debugfs in production systems now just so they can use the old-style interface? Side note: if you skip the "export" part of the interface, how would you indicate that a line is already in use or not available (e.g. gpio-range-reserved)? > > > Then it should be fine for any driver to provide a names array > > > provided all the names are unique on that gpiochip. > > > > So it sounds like there's nothing preventing per-chip-unique names in > > the rest of gpiolib and the new chardev interface then? Are the > > user-space libraries able to cope with it, etc? > > Yes the documentation refers to libgpiod a very well maintained > library: > https://www.kernel.org/doc/html/latest/driver-api/gpio/using-gpio.html > https://git.kernel.org/pub/scm/libs/libgpiod/libgpiod.git/ Just did a super quick check and it seems libgpiod still assumes a flat name space. For example, gpiod_chip_find_line() returns only the first line found that matches a name. Shouldn't be impossible to extend, but just want to make sure this flat namespace assumption hasn't been to heavily relied upon. Johan
Re: [PATCH v5 2/3] usb: serial: xr_serial: Add gpiochip support
On Wed, Dec 9, 2020 at 4:24 PM Johan Hovold wrote: > On Tue, Dec 08, 2020 at 01:41:52PM +0100, Linus Walleij wrote: > > depends on !GPIO_SYSFS > > > > so it can't even be compiled in if someone is using the sysfs. > > > > That should solve the situation where people are (ab)using > > the sysfs and getting name collisions as a result. > > Would it possible to set a flag to suppress just the sysfs entry > renaming instead? Hm you mean that when a GPIO is "exported" in sysfs it should not get a symbolic name from the names but instead just the number? I bet someone has written their scripts to take advantage of the symbolic names so I suspect the task becomes bigger like suppress the sysfs entry renaming if and only if there is a namespace collision. But I think we can do that, doesn't seem too hard? I just hacked up this: https://lore.kernel.org/linux-gpio/20201209161821.92931-1-linus.wall...@linaro.org/T/#u > Despite its flaws the sysfs interface is still very convenient and I'd > prefer not to disable it just because of the line names. Would these conveniences be identical to those listed in my recent TODO entry? https://lore.kernel.org/linux-gpio/20201204083533.65830-1-linus.wall...@linaro.org/ There are several other issues with the sysfs, so making it conflict with other drivers is almost plus in the direction of discouragement from the GPIO submaintainer point of view, but I do see that people like it for the reasons in the TODO. :/ I am strongly encouraging any developer with a few spare cycles on their hands to go and implement the debugfs facility because we can make it so much better than the sysfs, easier and more convenient for testing etc. > > Then it should be fine for any driver to provide a names array > > provided all the names are unique on that gpiochip. > > So it sounds like there's nothing preventing per-chip-unique names in > the rest of gpiolib and the new chardev interface then? Are the > user-space libraries able to cope with it, etc? Yes the documentation refers to libgpiod a very well maintained library: https://www.kernel.org/doc/html/latest/driver-api/gpio/using-gpio.html https://git.kernel.org/pub/scm/libs/libgpiod/libgpiod.git/ Then there are the the example tools included with the kernel that provide a second implementation for the same interfaces using just the C standard library: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/tools/gpio I usually use the tools myself. Yours, Linus Walleij
Re: [PATCH v5 2/3] usb: serial: xr_serial: Add gpiochip support
On Tue, Dec 08, 2020 at 06:22:50PM +0530, Manivannan Sadhasivam wrote: > On Tue, Dec 08, 2020 at 01:41:52PM +0100, Linus Walleij wrote: > > On Tue, Dec 8, 2020 at 10:57 AM Johan Hovold wrote: > > I think if this driver already has unique line-names per-gpiochip > > we could actually make it depend on !GPIO_SYSFS and > > just add the names. > > Sure thing. > > Johan, if you are okay with this I can resubmit incorporating Linus's > suggestion. Let's wait a bit with adding the names. That can possibly be done as a follow-up too even if removing GPIO_SYSFS support later is not ideal in case that's the path chosen (we'd have a similar problem with the existing USB-serial GPIO implementations though). Johan
Re: [PATCH v5 2/3] usb: serial: xr_serial: Add gpiochip support
On Tue, Dec 08, 2020 at 01:41:52PM +0100, Linus Walleij wrote: > On Tue, Dec 8, 2020 at 10:57 AM Johan Hovold wrote: > > Well we started discussing this back when we only had the sysfs > > interface which suffered from the same problem. I thought the chardev > > interface was supposed to get rid of the assumption of a flat name > > space? Perhaps in v3 of the ABI. ;P > > It's "mostly true" that the line names are unique per-chip actually, > because people don't like the nasty warning message. I wonder > if anything would really break if I go in and make a patch to > enforce it, since all drivers passing ->names in the gpiochip > are in the kernel we can check them all. > > If the names are unique-per-chip, we can add a restriction like this > with the requirement: > > depends on !GPIO_SYSFS > > so it can't even be compiled in if someone is using the sysfs. > > That should solve the situation where people are (ab)using > the sysfs and getting name collisions as a result. Would it possible to set a flag to suppress just the sysfs entry renaming instead? Despite its flaws the sysfs interface is still very convenient and I'd prefer not to disable it just because of the line names. > Then it should be fine for any driver to provide a names array > provided all the names are unique on that gpiochip. So it sounds like there's nothing preventing per-chip-unique names in the rest of gpiolib and the new chardev interface then? Are the user-space libraries able to cope with it, etc? > I doubt it would break anything, but let's see what Geert says. > He has some special usecases in the gpio-aggregator driver > which will incidentally look for just linenames when > aggregating gpios, but I feel it is a bit thick for it to work > with multiple hot-pluggable GPIO chips as well, I don't think > that is its usecase. (We all want to be perfect but...) Ok. > > But what about any other non-pluggable > > IC, which provides a few named GPIO lines and of which there could be > > more than one in a system? > > I think if there are such, and the lines are unique per-chip > we should make the drivers depend on !GPIO_SYSFS. Or just suppress the sysfs-entry renaming if that's the only thing that's blocking this. Johan
Re: [PATCH v5 2/3] usb: serial: xr_serial: Add gpiochip support
On Tue, Dec 08, 2020 at 01:41:52PM +0100, Linus Walleij wrote: > On Tue, Dec 8, 2020 at 10:57 AM Johan Hovold wrote: > > [Me] > > > > A better approach might be to create an array of names > > > prepended with something device-unique like the USB > > > bus topology? Or do we need a helper to help naming the > > > GPIOs? What would be helpful here? > > > > > > name = kasprintf(GFP_KERNEL, "%s-NAME", topology_str); > > > > Well we started discussing this back when we only had the sysfs > > interface which suffered from the same problem. I thought the chardev > > interface was supposed to get rid of the assumption of a flat name > > space? Perhaps in v3 of the ABI. ;P > > It's "mostly true" that the line names are unique per-chip actually, > because people don't like the nasty warning message. I wonder > if anything would really break if I go in and make a patch to > enforce it, since all drivers passing ->names in the gpiochip > are in the kernel we can check them all. > > If the names are unique-per-chip, we can add a restriction like this > with the requirement: > > depends on !GPIO_SYSFS > This sounds reasonable to me. > so it can't even be compiled in if someone is using the sysfs. > > That should solve the situation where people are (ab)using > the sysfs and getting name collisions as a result. > > Then it should be fine for any driver to provide a names array > provided all the names are unique on that gpiochip. > > I doubt it would break anything, but let's see what Geert says. > He has some special usecases in the gpio-aggregator driver > which will incidentally look for just linenames when > aggregating gpios, but I feel it is a bit thick for it to work > with multiple hot-pluggable GPIO chips as well, I don't think > that is its usecase. (We all want to be perfect but...) > > > But what about any other non-pluggable > > IC, which provides a few named GPIO lines and of which there could be > > more than one in a system? > > I think if there are such, and the lines are unique per-chip > we should make the drivers depend on !GPIO_SYSFS. > > > The topology is already encoded in sysfs and it seems backwards to have > > each and every gpio driver reconstruct it. > > I agree. > > I think if this driver already has unique line-names per-gpiochip > we could actually make it depend on !GPIO_SYSFS and > just add the names. > Sure thing. Johan, if you are okay with this I can resubmit incorporating Linus's suggestion. Thanks, Mani > Yours, > Linus Walleij
Re: [PATCH v5 2/3] usb: serial: xr_serial: Add gpiochip support
On Tue, Dec 8, 2020 at 10:57 AM Johan Hovold wrote: > [Me] > > A better approach might be to create an array of names > > prepended with something device-unique like the USB > > bus topology? Or do we need a helper to help naming the > > GPIOs? What would be helpful here? > > > > name = kasprintf(GFP_KERNEL, "%s-NAME", topology_str); > > Well we started discussing this back when we only had the sysfs > interface which suffered from the same problem. I thought the chardev > interface was supposed to get rid of the assumption of a flat name > space? Perhaps in v3 of the ABI. ;P It's "mostly true" that the line names are unique per-chip actually, because people don't like the nasty warning message. I wonder if anything would really break if I go in and make a patch to enforce it, since all drivers passing ->names in the gpiochip are in the kernel we can check them all. If the names are unique-per-chip, we can add a restriction like this with the requirement: depends on !GPIO_SYSFS so it can't even be compiled in if someone is using the sysfs. That should solve the situation where people are (ab)using the sysfs and getting name collisions as a result. Then it should be fine for any driver to provide a names array provided all the names are unique on that gpiochip. I doubt it would break anything, but let's see what Geert says. He has some special usecases in the gpio-aggregator driver which will incidentally look for just linenames when aggregating gpios, but I feel it is a bit thick for it to work with multiple hot-pluggable GPIO chips as well, I don't think that is its usecase. (We all want to be perfect but...) > But what about any other non-pluggable > IC, which provides a few named GPIO lines and of which there could be > more than one in a system? I think if there are such, and the lines are unique per-chip we should make the drivers depend on !GPIO_SYSFS. > The topology is already encoded in sysfs and it seems backwards to have > each and every gpio driver reconstruct it. I agree. I think if this driver already has unique line-names per-gpiochip we could actually make it depend on !GPIO_SYSFS and just add the names. Yours, Linus Walleij
Re: [PATCH v5 2/3] usb: serial: xr_serial: Add gpiochip support
On Sat, Dec 05, 2020 at 11:21:09PM +0100, Linus Walleij wrote:
> On Tue, Dec 1, 2020 at 4:50 PM Johan Hovold wrote:
> > On Tue, Dec 01, 2020 at 03:37:38PM +0100, Linus Walleij wrote:
> > > On Sun, Nov 22, 2020 at 6:08 PM Manivannan Sadhasivam
> > > wrote:
>
> > > You know the names of the pins...
> > >
> > > > + port_priv->gc.ngpio = 6;
> > > > + port_priv->gc.label = "xr_gpios";
> > > > + port_priv->gc.request = xr_gpio_request;
> > > > + port_priv->gc.free = xr_gpio_free;
> > > > + port_priv->gc.get_direction = xr_gpio_direction_get;
> > > > + port_priv->gc.direction_input = xr_gpio_direction_input;
> > > > + port_priv->gc.direction_output = xr_gpio_direction_output;
> > > > + port_priv->gc.get = xr_gpio_get;
> > > > + port_priv->gc.set = xr_gpio_set;
> > > > + port_priv->gc.owner = THIS_MODULE;
> > > > + port_priv->gc.parent = >dev;
> > > > + port_priv->gc.base = -1;
> > > > + port_priv->gc.can_sleep = true;
> > >
> > > So assign port_priv->gc.names here as well with an array
> > > of strings with the names ("RI", "CD", ... etc).
> > > This makes it look really nice in userspace if you do
> > > e.g. "lsgpio".
> >
> > Last time we tried that gpiolib still used a flat namespace so that you
> > can't have have more than one device using the same names. Unless that
> > has changed this is a no-go. See
> >
> > https://lore.kernel.org/r/20180930122703.7115-1-jo...@kernel.org
> >
> > for our previous discussion about this.
>
> Hm hm yeah we actually put in a nasty warning there since:
>
> gpio = gpio_name_to_desc(gc->names[i]);
> if (gpio)
> dev_warn(>dev,
> "Detected name collision for GPIO name
> '%s'\n",
> gc->names[i]);
>
>
> A better approach might be to create an array of names
> prepended with something device-unique like the USB
> bus topology? Or do we need a helper to help naming the
> GPIOs? What would be helpful here?
>
> name = kasprintf(GFP_KERNEL, "%s-NAME", topology_str);
Well we started discussing this back when we only had the sysfs
interface which suffered from the same problem. I thought the chardev
interface was supposed to get rid of the assumption of a flat name
space? Perhaps in v3 of the ABI. ;P
If this is too built into the new chardev interface as well to be fixed
up, a unique prefix is the only way to go. Perhaps gpiolib can just
prefix it with the controller name?
gpiochip508-CBUS0
Based on a hotpluggable bus flag? But what about any other non-pluggable
IC, which provides a few named GPIO lines and of which there could be
more than one in a system?
The topology is already encoded in sysfs and it seems backwards to have
each and every gpio driver reconstruct it.
Johan
Re: [PATCH v5 2/3] usb: serial: xr_serial: Add gpiochip support
On Tue, Dec 1, 2020 at 4:50 PM Johan Hovold wrote:
> On Tue, Dec 01, 2020 at 03:37:38PM +0100, Linus Walleij wrote:
> > On Sun, Nov 22, 2020 at 6:08 PM Manivannan Sadhasivam
> > wrote:
> > You know the names of the pins...
> >
> > > + port_priv->gc.ngpio = 6;
> > > + port_priv->gc.label = "xr_gpios";
> > > + port_priv->gc.request = xr_gpio_request;
> > > + port_priv->gc.free = xr_gpio_free;
> > > + port_priv->gc.get_direction = xr_gpio_direction_get;
> > > + port_priv->gc.direction_input = xr_gpio_direction_input;
> > > + port_priv->gc.direction_output = xr_gpio_direction_output;
> > > + port_priv->gc.get = xr_gpio_get;
> > > + port_priv->gc.set = xr_gpio_set;
> > > + port_priv->gc.owner = THIS_MODULE;
> > > + port_priv->gc.parent = >dev;
> > > + port_priv->gc.base = -1;
> > > + port_priv->gc.can_sleep = true;
> >
> > So assign port_priv->gc.names here as well with an array
> > of strings with the names ("RI", "CD", ... etc).
> > This makes it look really nice in userspace if you do
> > e.g. "lsgpio".
>
> Last time we tried that gpiolib still used a flat namespace so that you
> can't have have more than one device using the same names. Unless that
> has changed this is a no-go. See
>
> https://lore.kernel.org/r/20180930122703.7115-1-jo...@kernel.org
>
> for our previous discussion about this.
Hm hm yeah we actually put in a nasty warning there since:
gpio = gpio_name_to_desc(gc->names[i]);
if (gpio)
dev_warn(>dev,
"Detected name collision for GPIO name '%s'\n",
gc->names[i]);
A better approach might be to create an array of names
prepended with something device-unique like the USB
bus topology? Or do we need a helper to help naming the
GPIOs? What would be helpful here?
name = kasprintf(GFP_KERNEL, "%s-NAME", topology_str);
Yours,
Linus Walleij
Re: [PATCH v5 2/3] usb: serial: xr_serial: Add gpiochip support
Hi Linus,
On Tue, Dec 01, 2020 at 03:37:38PM +0100, Linus Walleij wrote:
> On Sun, Nov 22, 2020 at 6:08 PM Manivannan Sadhasivam wrote:
>
> > Add gpiochip support for Maxlinear/Exar USB to serial converter
> > for controlling the available gpios.
> >
> > Inspired from cp210x usb to serial converter driver.
> >
> > Cc: Linus Walleij
> > Cc: linux-g...@vger.kernel.org
> > Signed-off-by: Manivannan Sadhasivam
>
> This looks good to me overall, provided that it plays well with the
> serial port.
>
> One minor notice:
>
> > +enum gpio_pins {
> > + GPIO_RI = 0,
> > + GPIO_CD,
> > + GPIO_DSR,
> > + GPIO_DTR,
> > + GPIO_CTS,
> > + GPIO_RTS,
> > + GPIO_MAX,
> > +};
>
> You know the names of the pins...
>
> > + port_priv->gc.ngpio = 6;
> > + port_priv->gc.label = "xr_gpios";
> > + port_priv->gc.request = xr_gpio_request;
> > + port_priv->gc.free = xr_gpio_free;
> > + port_priv->gc.get_direction = xr_gpio_direction_get;
> > + port_priv->gc.direction_input = xr_gpio_direction_input;
> > + port_priv->gc.direction_output = xr_gpio_direction_output;
> > + port_priv->gc.get = xr_gpio_get;
> > + port_priv->gc.set = xr_gpio_set;
> > + port_priv->gc.owner = THIS_MODULE;
> > + port_priv->gc.parent = >dev;
> > + port_priv->gc.base = -1;
> > + port_priv->gc.can_sleep = true;
>
> So assign port_priv->gc.names here as well with an array
> of strings with the names ("RI", "CD", ... etc).
> This makes it look really nice in userspace if you do
> e.g. "lsgpio".
>
As Johan stated, this doesn't work with multiple devices attached to the system.
That's the reason for not adding the line names.
This gives me the motivation to get my hands dirty with gpiolib (but I fear of
breaking the ABI)...
> With that:
> Reviewed-by: Linus Walleij
>
Thanks for the review!
Regards,
Mani
> Yours,
> Linus Walleij
Re: [PATCH v5 2/3] usb: serial: xr_serial: Add gpiochip support
On Tue, Dec 01, 2020 at 03:37:38PM +0100, Linus Walleij wrote:
> On Sun, Nov 22, 2020 at 6:08 PM Manivannan Sadhasivam wrote:
>
> > Add gpiochip support for Maxlinear/Exar USB to serial converter
> > for controlling the available gpios.
> One minor notice:
>
> > +enum gpio_pins {
> > + GPIO_RI = 0,
> > + GPIO_CD,
> > + GPIO_DSR,
> > + GPIO_DTR,
> > + GPIO_CTS,
> > + GPIO_RTS,
> > + GPIO_MAX,
> > +};
>
> You know the names of the pins...
>
> > + port_priv->gc.ngpio = 6;
> > + port_priv->gc.label = "xr_gpios";
> > + port_priv->gc.request = xr_gpio_request;
> > + port_priv->gc.free = xr_gpio_free;
> > + port_priv->gc.get_direction = xr_gpio_direction_get;
> > + port_priv->gc.direction_input = xr_gpio_direction_input;
> > + port_priv->gc.direction_output = xr_gpio_direction_output;
> > + port_priv->gc.get = xr_gpio_get;
> > + port_priv->gc.set = xr_gpio_set;
> > + port_priv->gc.owner = THIS_MODULE;
> > + port_priv->gc.parent = >dev;
> > + port_priv->gc.base = -1;
> > + port_priv->gc.can_sleep = true;
>
> So assign port_priv->gc.names here as well with an array
> of strings with the names ("RI", "CD", ... etc).
> This makes it look really nice in userspace if you do
> e.g. "lsgpio".
Last time we tried that gpiolib still used a flat namespace so that you
can't have have more than one device using the same names. Unless that
has changed this is a no-go. See
https://lore.kernel.org/r/20180930122703.7115-1-jo...@kernel.org
for our previous discussion about this.
Johan
Re: [PATCH v5 2/3] usb: serial: xr_serial: Add gpiochip support
On Sun, Nov 22, 2020 at 6:08 PM Manivannan Sadhasivam wrote:
> Add gpiochip support for Maxlinear/Exar USB to serial converter
> for controlling the available gpios.
>
> Inspired from cp210x usb to serial converter driver.
>
> Cc: Linus Walleij
> Cc: linux-g...@vger.kernel.org
> Signed-off-by: Manivannan Sadhasivam
This looks good to me overall, provided that it plays well with the
serial port.
One minor notice:
> +enum gpio_pins {
> + GPIO_RI = 0,
> + GPIO_CD,
> + GPIO_DSR,
> + GPIO_DTR,
> + GPIO_CTS,
> + GPIO_RTS,
> + GPIO_MAX,
> +};
You know the names of the pins...
> + port_priv->gc.ngpio = 6;
> + port_priv->gc.label = "xr_gpios";
> + port_priv->gc.request = xr_gpio_request;
> + port_priv->gc.free = xr_gpio_free;
> + port_priv->gc.get_direction = xr_gpio_direction_get;
> + port_priv->gc.direction_input = xr_gpio_direction_input;
> + port_priv->gc.direction_output = xr_gpio_direction_output;
> + port_priv->gc.get = xr_gpio_get;
> + port_priv->gc.set = xr_gpio_set;
> + port_priv->gc.owner = THIS_MODULE;
> + port_priv->gc.parent = >dev;
> + port_priv->gc.base = -1;
> + port_priv->gc.can_sleep = true;
So assign port_priv->gc.names here as well with an array
of strings with the names ("RI", "CD", ... etc).
This makes it look really nice in userspace if you do
e.g. "lsgpio".
With that:
Reviewed-by: Linus Walleij
Yours,
Linus Walleij
