Re: [PATCH v5 2/5] ARM: BCM: Clean up SMP support for Broadcom Kona

2015-12-05 Thread Kapil Hali
Hi Florian,

On 12/5/2015 4:37 AM, Florian Fainelli wrote:
> On 04/12/15 12:23, Kapil Hali wrote:
>> These changes cleans up SMP implementaion for Broadcom's
>> Kona SoC which are required for handling SMP for iProc
>> family of SoCs at a single place for BCM NSP and BCM Kona.
>>
>> Signed-off-by: Kapil Hali 
>> ---
>>  arch/arm/boot/dts/bcm11351.dtsi |  2 +-
>>  arch/arm/boot/dts/bcm21664.dtsi |  2 +-
>>  arch/arm/mach-bcm/kona_smp.c| 82 
>> +++--
>>  3 files changed, 56 insertions(+), 30 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/bcm11351.dtsi 
>> b/arch/arm/boot/dts/bcm11351.dtsi
>> index 2ddaa51..3dc7a8c 100644
>> --- a/arch/arm/boot/dts/bcm11351.dtsi
>> +++ b/arch/arm/boot/dts/bcm11351.dtsi
>> @@ -31,7 +31,6 @@
>>  #address-cells = <1>;
>>  #size-cells = <0>;
>>  enable-method = "brcm,bcm11351-cpu-method";
>> -secondary-boot-reg = <0x3500417c>;
> 
> I would expect the 'enable-method' to be moved as well to be consistent
> with what you are adding for NSP later on.
> 
Right, it is updated in the new patch set.
>>  
>>  cpu0: cpu@0 {
>>  device_type = "cpu";
>> @@ -42,6 +41,7 @@
>>  cpu1: cpu@1 {
>>  device_type = "cpu";
>>  compatible = "arm,cortex-a9";
>> +secondary-boot-reg = <0x3500417c>;
>>  reg = <1>;
>>  };
Thanks,
Kapil
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH v5 2/5] ARM: BCM: Clean up SMP support for Broadcom Kona

2015-12-05 Thread Kapil Hali
Hi Florian,

On 12/5/2015 4:37 AM, Florian Fainelli wrote:
> On 04/12/15 12:23, Kapil Hali wrote:
>> These changes cleans up SMP implementaion for Broadcom's
>> Kona SoC which are required for handling SMP for iProc
>> family of SoCs at a single place for BCM NSP and BCM Kona.
>>
>> Signed-off-by: Kapil Hali 
>> ---
>>  arch/arm/boot/dts/bcm11351.dtsi |  2 +-
>>  arch/arm/boot/dts/bcm21664.dtsi |  2 +-
>>  arch/arm/mach-bcm/kona_smp.c| 82 
>> +++--
>>  3 files changed, 56 insertions(+), 30 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/bcm11351.dtsi 
>> b/arch/arm/boot/dts/bcm11351.dtsi
>> index 2ddaa51..3dc7a8c 100644
>> --- a/arch/arm/boot/dts/bcm11351.dtsi
>> +++ b/arch/arm/boot/dts/bcm11351.dtsi
>> @@ -31,7 +31,6 @@
>>  #address-cells = <1>;
>>  #size-cells = <0>;
>>  enable-method = "brcm,bcm11351-cpu-method";
>> -secondary-boot-reg = <0x3500417c>;
> 
> I would expect the 'enable-method' to be moved as well to be consistent
> with what you are adding for NSP later on.
> 
Right, it is updated in the new patch set.
>>  
>>  cpu0: cpu@0 {
>>  device_type = "cpu";
>> @@ -42,6 +41,7 @@
>>  cpu1: cpu@1 {
>>  device_type = "cpu";
>>  compatible = "arm,cortex-a9";
>> +secondary-boot-reg = <0x3500417c>;
>>  reg = <1>;
>>  };
Thanks,
Kapil
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH v5 2/5] ARM: BCM: Clean up SMP support for Broadcom Kona

2015-12-04 Thread Florian Fainelli
On 04/12/15 12:23, Kapil Hali wrote:
> These changes cleans up SMP implementaion for Broadcom's
> Kona SoC which are required for handling SMP for iProc
> family of SoCs at a single place for BCM NSP and BCM Kona.
> 
> Signed-off-by: Kapil Hali 
> ---
>  arch/arm/boot/dts/bcm11351.dtsi |  2 +-
>  arch/arm/boot/dts/bcm21664.dtsi |  2 +-
>  arch/arm/mach-bcm/kona_smp.c| 82 
> +++--
>  3 files changed, 56 insertions(+), 30 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/bcm11351.dtsi b/arch/arm/boot/dts/bcm11351.dtsi
> index 2ddaa51..3dc7a8c 100644
> --- a/arch/arm/boot/dts/bcm11351.dtsi
> +++ b/arch/arm/boot/dts/bcm11351.dtsi
> @@ -31,7 +31,6 @@
>   #address-cells = <1>;
>   #size-cells = <0>;
>   enable-method = "brcm,bcm11351-cpu-method";
> - secondary-boot-reg = <0x3500417c>;

I would expect the 'enable-method' to be moved as well to be consistent
with what you are adding for NSP later on.

>  
>   cpu0: cpu@0 {
>   device_type = "cpu";
> @@ -42,6 +41,7 @@
>   cpu1: cpu@1 {
>   device_type = "cpu";
>   compatible = "arm,cortex-a9";
> + secondary-boot-reg = <0x3500417c>;
>   reg = <1>;
>   };
-- 
Florian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH v5 2/5] ARM: BCM: Clean up SMP support for Broadcom Kona

2015-12-04 Thread Florian Fainelli
On 04/12/15 12:23, Kapil Hali wrote:
> These changes cleans up SMP implementaion for Broadcom's
> Kona SoC which are required for handling SMP for iProc
> family of SoCs at a single place for BCM NSP and BCM Kona.
> 
> Signed-off-by: Kapil Hali 
> ---
>  arch/arm/boot/dts/bcm11351.dtsi |  2 +-
>  arch/arm/boot/dts/bcm21664.dtsi |  2 +-
>  arch/arm/mach-bcm/kona_smp.c| 82 
> +++--
>  3 files changed, 56 insertions(+), 30 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/bcm11351.dtsi b/arch/arm/boot/dts/bcm11351.dtsi
> index 2ddaa51..3dc7a8c 100644
> --- a/arch/arm/boot/dts/bcm11351.dtsi
> +++ b/arch/arm/boot/dts/bcm11351.dtsi
> @@ -31,7 +31,6 @@
>   #address-cells = <1>;
>   #size-cells = <0>;
>   enable-method = "brcm,bcm11351-cpu-method";
> - secondary-boot-reg = <0x3500417c>;

I would expect the 'enable-method' to be moved as well to be consistent
with what you are adding for NSP later on.

>  
>   cpu0: cpu@0 {
>   device_type = "cpu";
> @@ -42,6 +41,7 @@
>   cpu1: cpu@1 {
>   device_type = "cpu";
>   compatible = "arm,cortex-a9";
> + secondary-boot-reg = <0x3500417c>;
>   reg = <1>;
>   };
-- 
Florian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/