Re: [PATCH v6 1/1] acpi: apei: Enable APEI multiple GHES source to share a single external IRQ

2017-08-01 Thread Rafael J. Wysocki 
On Saturday, July 22, 2017 07:59:54 AM Borislav Petkov wrote:
> On Fri, Jul 21, 2017 at 11:24:37AM -0700, Loc Ho wrote:
> > X-Gene platforms describe multiple GHES error sources with the same hardware
> > error notification type (external interrupt) and interrupt number.
> > Change the GHES interrupt request to support sharing the same IRQ.
> > 
> > Co-authored-by: Tuan Phan 
> > Signed-off-by: Loc Ho 
> > ---
> >  drivers/acpi/apei/ghes.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c
> > index d661d45..eed09fc 100644
> > --- a/drivers/acpi/apei/ghes.c
> > +++ b/drivers/acpi/apei/ghes.c
> > @@ -1157,7 +1157,8 @@ static int ghes_probe(struct platform_device 
> > *ghes_dev)
> >generic->header.source_id);
> > goto err_edac_unreg;
> > }
> > -   rc = request_irq(ghes->irq, ghes_irq_func, 0, "GHES IRQ", ghes);
> > +   rc = request_irq(ghes->irq, ghes_irq_func, IRQF_SHARED,
> > +"GHES IRQ", ghes);
> > if (rc) {
> > pr_err(GHES_PFX "Failed to register IRQ for generic 
> > hardware error source: %d\n",
> >generic->header.source_id);
> 
> Acked-by: Borislav Petkov 

Applied, thanks!

Re: [PATCH v6 1/1] acpi: apei: Enable APEI multiple GHES source to share a single external IRQ

2017-08-01 Thread Rafael J. Wysocki 
On Saturday, July 22, 2017 07:59:54 AM Borislav Petkov wrote:
> On Fri, Jul 21, 2017 at 11:24:37AM -0700, Loc Ho wrote:
> > X-Gene platforms describe multiple GHES error sources with the same hardware
> > error notification type (external interrupt) and interrupt number.
> > Change the GHES interrupt request to support sharing the same IRQ.
> > 
> > Co-authored-by: Tuan Phan 
> > Signed-off-by: Loc Ho 
> > ---
> >  drivers/acpi/apei/ghes.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c
> > index d661d45..eed09fc 100644
> > --- a/drivers/acpi/apei/ghes.c
> > +++ b/drivers/acpi/apei/ghes.c
> > @@ -1157,7 +1157,8 @@ static int ghes_probe(struct platform_device 
> > *ghes_dev)
> >generic->header.source_id);
> > goto err_edac_unreg;
> > }
> > -   rc = request_irq(ghes->irq, ghes_irq_func, 0, "GHES IRQ", ghes);
> > +   rc = request_irq(ghes->irq, ghes_irq_func, IRQF_SHARED,
> > +"GHES IRQ", ghes);
> > if (rc) {
> > pr_err(GHES_PFX "Failed to register IRQ for generic 
> > hardware error source: %d\n",
> >generic->header.source_id);
> 
> Acked-by: Borislav Petkov 

Applied, thanks!

RE: [PATCH v6 1/1] acpi: apei: Enable APEI multiple GHES source to share a single external IRQ

2017-07-27 Thread Luck, Tony 
>> Provided Tony agrees though... I'd venture a guess and say that he
>> doesn't have a choice, woahahhahaha...
>>
>> :-)))
>
> Well, I guess send this officially with a CC:Tony and see what he says. :-)

That's definitely part of my day job ... so yes, please add me as a reviewer.

-Tony

RE: [PATCH v6 1/1] acpi: apei: Enable APEI multiple GHES source to share a single external IRQ

2017-07-27 Thread Luck, Tony 
>> Provided Tony agrees though... I'd venture a guess and say that he
>> doesn't have a choice, woahahhahaha...
>>
>> :-)))
>
> Well, I guess send this officially with a CC:Tony and see what he says. :-)

That's definitely part of my day job ... so yes, please add me as a reviewer.

-Tony

Re: [PATCH v6 1/1] acpi: apei: Enable APEI multiple GHES source to share a single external IRQ

2017-07-27 Thread Rafael J. Wysocki 
On Thu, Jul 27, 2017 at 4:49 PM, Borislav Petkov  wrote:
> On Thu, Jul 27, 2017 at 04:34:59PM +0200, Rafael J. Wysocki wrote:
>> I can collect it, no problem.
>>
>> So from now on I will pick up APEI things with ACKs from you or Tony.
>
> If you agree with that, that is. But we kinda do that already, more or
> less. :-)
>
> Then I guess we should add something like this so that get_maintainer
> finds us:
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index f66488dfdbc9..985413fb5d83 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -310,6 +310,14 @@ F: drivers/pci/*/*acpi*
>  F: drivers/pci/*/*/*acpi*
>  F: tools/power/acpi/
>
> +ACPI APEI
> +M: "Rafael J. Wysocki" 
> +M: Len Brown 
> +L: linux-a...@vger.kernel.org
> +R: Tony Luck 
> +R: Borislav Petkov 
> +F: drivers/acpi/apei/
> +
>  ACPI COMPONENT ARCHITECTURE (ACPICA)
>  M: Robert Moore 
>  M: Lv Zheng 
>
> ---
>
> Provided Tony agrees though... I'd venture a guess and say that he
> doesn't have a choice, woahahhahaha...
>
> :-)))

Well, I guess send this officially with a CC:Tony and see what he says. :-)

Re: [PATCH v6 1/1] acpi: apei: Enable APEI multiple GHES source to share a single external IRQ

2017-07-27 Thread Rafael J. Wysocki 
On Thu, Jul 27, 2017 at 4:49 PM, Borislav Petkov  wrote:
> On Thu, Jul 27, 2017 at 04:34:59PM +0200, Rafael J. Wysocki wrote:
>> I can collect it, no problem.
>>
>> So from now on I will pick up APEI things with ACKs from you or Tony.
>
> If you agree with that, that is. But we kinda do that already, more or
> less. :-)
>
> Then I guess we should add something like this so that get_maintainer
> finds us:
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index f66488dfdbc9..985413fb5d83 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -310,6 +310,14 @@ F: drivers/pci/*/*acpi*
>  F: drivers/pci/*/*/*acpi*
>  F: tools/power/acpi/
>
> +ACPI APEI
> +M: "Rafael J. Wysocki" 
> +M: Len Brown 
> +L: linux-a...@vger.kernel.org
> +R: Tony Luck 
> +R: Borislav Petkov 
> +F: drivers/acpi/apei/
> +
>  ACPI COMPONENT ARCHITECTURE (ACPICA)
>  M: Robert Moore 
>  M: Lv Zheng 
>
> ---
>
> Provided Tony agrees though... I'd venture a guess and say that he
> doesn't have a choice, woahahhahaha...
>
> :-)))

Well, I guess send this officially with a CC:Tony and see what he says. :-)

Re: [PATCH v6 1/1] acpi: apei: Enable APEI multiple GHES source to share a single external IRQ

2017-07-27 Thread Borislav Petkov 
On Thu, Jul 27, 2017 at 04:34:59PM +0200, Rafael J. Wysocki wrote:
> I can collect it, no problem.
> 
> So from now on I will pick up APEI things with ACKs from you or Tony.

If you agree with that, that is. But we kinda do that already, more or
less. :-)

Then I guess we should add something like this so that get_maintainer
finds us:

diff --git a/MAINTAINERS b/MAINTAINERS
index f66488dfdbc9..985413fb5d83 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -310,6 +310,14 @@ F: drivers/pci/*/*acpi*
 F: drivers/pci/*/*/*acpi*
 F: tools/power/acpi/
 
+ACPI APEI
+M: "Rafael J. Wysocki" 
+M: Len Brown 
+L: linux-a...@vger.kernel.org
+R: Tony Luck 
+R: Borislav Petkov 
+F: drivers/acpi/apei/
+
 ACPI COMPONENT ARCHITECTURE (ACPICA)
 M: Robert Moore 
 M: Lv Zheng 

---

Provided Tony agrees though... I'd venture a guess and say that he
doesn't have a choice, woahahhahaha...

:-)))

-- 
Regards/Gruss,
Boris.

SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 
(AG Nürnberg)
--

Re: [PATCH v6 1/1] acpi: apei: Enable APEI multiple GHES source to share a single external IRQ

2017-07-27 Thread Borislav Petkov 
On Thu, Jul 27, 2017 at 04:34:59PM +0200, Rafael J. Wysocki wrote:
> I can collect it, no problem.
> 
> So from now on I will pick up APEI things with ACKs from you or Tony.

If you agree with that, that is. But we kinda do that already, more or
less. :-)

Then I guess we should add something like this so that get_maintainer
finds us:

diff --git a/MAINTAINERS b/MAINTAINERS
index f66488dfdbc9..985413fb5d83 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -310,6 +310,14 @@ F: drivers/pci/*/*acpi*
 F: drivers/pci/*/*/*acpi*
 F: tools/power/acpi/
 
+ACPI APEI
+M: "Rafael J. Wysocki" 
+M: Len Brown 
+L: linux-a...@vger.kernel.org
+R: Tony Luck 
+R: Borislav Petkov 
+F: drivers/acpi/apei/
+
 ACPI COMPONENT ARCHITECTURE (ACPICA)
 M: Robert Moore 
 M: Lv Zheng 

---

Provided Tony agrees though... I'd venture a guess and say that he
doesn't have a choice, woahahhahaha...

:-)))

-- 
Regards/Gruss,
Boris.

SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 
(AG Nürnberg)
--

Re: [PATCH v6 1/1] acpi: apei: Enable APEI multiple GHES source to share a single external IRQ

2017-07-27 Thread Rafael J. Wysocki 
On Thu, Jul 27, 2017 at 7:58 AM, Borislav Petkov  wrote:
> On Wed, Jul 26, 2017 at 08:57:03PM +0200, Rafael J. Wysocki wrote:
>> > Should I apply this or will Tony do that?
>>
>> So am I suppsed to drop this?
>
> Well, as suggested in another mail, I think it'll be best if Tony and I
> put ourselves as reviewers for the APEI crap and you still collect it.
>
> Unless you want to give it to us and we can arrange some pull order to
> send it to you.
>
> What do you prefer?

I can collect it, no problem.

So from now on I will pick up APEI things with ACKs from you or Tony.

Thanks,
Rafael

Re: [PATCH v6 1/1] acpi: apei: Enable APEI multiple GHES source to share a single external IRQ

2017-07-27 Thread Rafael J. Wysocki 
On Thu, Jul 27, 2017 at 7:58 AM, Borislav Petkov  wrote:
> On Wed, Jul 26, 2017 at 08:57:03PM +0200, Rafael J. Wysocki wrote:
>> > Should I apply this or will Tony do that?
>>
>> So am I suppsed to drop this?
>
> Well, as suggested in another mail, I think it'll be best if Tony and I
> put ourselves as reviewers for the APEI crap and you still collect it.
>
> Unless you want to give it to us and we can arrange some pull order to
> send it to you.
>
> What do you prefer?

I can collect it, no problem.

So from now on I will pick up APEI things with ACKs from you or Tony.

Thanks,
Rafael

Re: [PATCH v6 1/1] acpi: apei: Enable APEI multiple GHES source to share a single external IRQ

2017-07-26 Thread Borislav Petkov 
On Wed, Jul 26, 2017 at 08:57:03PM +0200, Rafael J. Wysocki wrote:
> > Should I apply this or will Tony do that?
> 
> So am I suppsed to drop this?

Well, as suggested in another mail, I think it'll be best if Tony and I
put ourselves as reviewers for the APEI crap and you still collect it.

Unless you want to give it to us and we can arrange some pull order to
send it to you.

What do you prefer?

-- 
Regards/Gruss,
Boris.

SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 
(AG Nürnberg)
--

Re: [PATCH v6 1/1] acpi: apei: Enable APEI multiple GHES source to share a single external IRQ

2017-07-26 Thread Borislav Petkov 
On Wed, Jul 26, 2017 at 08:57:03PM +0200, Rafael J. Wysocki wrote:
> > Should I apply this or will Tony do that?
> 
> So am I suppsed to drop this?

Well, as suggested in another mail, I think it'll be best if Tony and I
put ourselves as reviewers for the APEI crap and you still collect it.

Unless you want to give it to us and we can arrange some pull order to
send it to you.

What do you prefer?

-- 
Regards/Gruss,
Boris.

SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 
(AG Nürnberg)
--

Re: [PATCH v6 1/1] acpi: apei: Enable APEI multiple GHES source to share a single external IRQ

2017-07-26 Thread Rafael J. Wysocki 
On Sunday, July 23, 2017 12:01:10 AM Rafael J. Wysocki wrote:
> On Saturday, July 22, 2017 07:59:54 AM Borislav Petkov wrote:
> > On Fri, Jul 21, 2017 at 11:24:37AM -0700, Loc Ho wrote:
> > > X-Gene platforms describe multiple GHES error sources with the same 
> > > hardware
> > > error notification type (external interrupt) and interrupt number.
> > > Change the GHES interrupt request to support sharing the same IRQ.
> > > 
> > > Co-authored-by: Tuan Phan 
> > > Signed-off-by: Loc Ho 
> > > ---
> > >  drivers/acpi/apei/ghes.c | 3 ++-
> > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c
> > > index d661d45..eed09fc 100644
> > > --- a/drivers/acpi/apei/ghes.c
> > > +++ b/drivers/acpi/apei/ghes.c
> > > @@ -1157,7 +1157,8 @@ static int ghes_probe(struct platform_device 
> > > *ghes_dev)
> > >  generic->header.source_id);
> > >   goto err_edac_unreg;
> > >   }
> > > - rc = request_irq(ghes->irq, ghes_irq_func, 0, "GHES IRQ", ghes);
> > > + rc = request_irq(ghes->irq, ghes_irq_func, IRQF_SHARED,
> > > +  "GHES IRQ", ghes);
> > >   if (rc) {
> > >   pr_err(GHES_PFX "Failed to register IRQ for generic 
> > > hardware error source: %d\n",
> > >  generic->header.source_id);
> > 
> > Acked-by: Borislav Petkov 
> 
> OK
> 
> Should I apply this or will Tony do that?

So am I suppsed to drop this?

Re: [PATCH v6 1/1] acpi: apei: Enable APEI multiple GHES source to share a single external IRQ

2017-07-26 Thread Rafael J. Wysocki 
On Sunday, July 23, 2017 12:01:10 AM Rafael J. Wysocki wrote:
> On Saturday, July 22, 2017 07:59:54 AM Borislav Petkov wrote:
> > On Fri, Jul 21, 2017 at 11:24:37AM -0700, Loc Ho wrote:
> > > X-Gene platforms describe multiple GHES error sources with the same 
> > > hardware
> > > error notification type (external interrupt) and interrupt number.
> > > Change the GHES interrupt request to support sharing the same IRQ.
> > > 
> > > Co-authored-by: Tuan Phan 
> > > Signed-off-by: Loc Ho 
> > > ---
> > >  drivers/acpi/apei/ghes.c | 3 ++-
> > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c
> > > index d661d45..eed09fc 100644
> > > --- a/drivers/acpi/apei/ghes.c
> > > +++ b/drivers/acpi/apei/ghes.c
> > > @@ -1157,7 +1157,8 @@ static int ghes_probe(struct platform_device 
> > > *ghes_dev)
> > >  generic->header.source_id);
> > >   goto err_edac_unreg;
> > >   }
> > > - rc = request_irq(ghes->irq, ghes_irq_func, 0, "GHES IRQ", ghes);
> > > + rc = request_irq(ghes->irq, ghes_irq_func, IRQF_SHARED,
> > > +  "GHES IRQ", ghes);
> > >   if (rc) {
> > >   pr_err(GHES_PFX "Failed to register IRQ for generic 
> > > hardware error source: %d\n",
> > >  generic->header.source_id);
> > 
> > Acked-by: Borislav Petkov 
> 
> OK
> 
> Should I apply this or will Tony do that?

So am I suppsed to drop this?

Re: [PATCH v6 1/1] acpi: apei: Enable APEI multiple GHES source to share a single external IRQ

2017-07-22 Thread Rafael J. Wysocki 
On Saturday, July 22, 2017 07:59:54 AM Borislav Petkov wrote:
> On Fri, Jul 21, 2017 at 11:24:37AM -0700, Loc Ho wrote:
> > X-Gene platforms describe multiple GHES error sources with the same hardware
> > error notification type (external interrupt) and interrupt number.
> > Change the GHES interrupt request to support sharing the same IRQ.
> > 
> > Co-authored-by: Tuan Phan 
> > Signed-off-by: Loc Ho 
> > ---
> >  drivers/acpi/apei/ghes.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c
> > index d661d45..eed09fc 100644
> > --- a/drivers/acpi/apei/ghes.c
> > +++ b/drivers/acpi/apei/ghes.c
> > @@ -1157,7 +1157,8 @@ static int ghes_probe(struct platform_device 
> > *ghes_dev)
> >generic->header.source_id);
> > goto err_edac_unreg;
> > }
> > -   rc = request_irq(ghes->irq, ghes_irq_func, 0, "GHES IRQ", ghes);
> > +   rc = request_irq(ghes->irq, ghes_irq_func, IRQF_SHARED,
> > +"GHES IRQ", ghes);
> > if (rc) {
> > pr_err(GHES_PFX "Failed to register IRQ for generic 
> > hardware error source: %d\n",
> >generic->header.source_id);
> 
> Acked-by: Borislav Petkov 

OK

Should I apply this or will Tony do that?

Re: [PATCH v6 1/1] acpi: apei: Enable APEI multiple GHES source to share a single external IRQ

2017-07-22 Thread Rafael J. Wysocki 
On Saturday, July 22, 2017 07:59:54 AM Borislav Petkov wrote:
> On Fri, Jul 21, 2017 at 11:24:37AM -0700, Loc Ho wrote:
> > X-Gene platforms describe multiple GHES error sources with the same hardware
> > error notification type (external interrupt) and interrupt number.
> > Change the GHES interrupt request to support sharing the same IRQ.
> > 
> > Co-authored-by: Tuan Phan 
> > Signed-off-by: Loc Ho 
> > ---
> >  drivers/acpi/apei/ghes.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c
> > index d661d45..eed09fc 100644
> > --- a/drivers/acpi/apei/ghes.c
> > +++ b/drivers/acpi/apei/ghes.c
> > @@ -1157,7 +1157,8 @@ static int ghes_probe(struct platform_device 
> > *ghes_dev)
> >generic->header.source_id);
> > goto err_edac_unreg;
> > }
> > -   rc = request_irq(ghes->irq, ghes_irq_func, 0, "GHES IRQ", ghes);
> > +   rc = request_irq(ghes->irq, ghes_irq_func, IRQF_SHARED,
> > +"GHES IRQ", ghes);
> > if (rc) {
> > pr_err(GHES_PFX "Failed to register IRQ for generic 
> > hardware error source: %d\n",
> >generic->header.source_id);
> 
> Acked-by: Borislav Petkov 

OK

Should I apply this or will Tony do that?

Re: [PATCH v6 1/1] acpi: apei: Enable APEI multiple GHES source to share a single external IRQ

2017-07-22 Thread Borislav Petkov 
On Fri, Jul 21, 2017 at 11:24:37AM -0700, Loc Ho wrote:
> X-Gene platforms describe multiple GHES error sources with the same hardware
> error notification type (external interrupt) and interrupt number.
> Change the GHES interrupt request to support sharing the same IRQ.
> 
> Co-authored-by: Tuan Phan 
> Signed-off-by: Loc Ho 
> ---
>  drivers/acpi/apei/ghes.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c
> index d661d45..eed09fc 100644
> --- a/drivers/acpi/apei/ghes.c
> +++ b/drivers/acpi/apei/ghes.c
> @@ -1157,7 +1157,8 @@ static int ghes_probe(struct platform_device *ghes_dev)
>  generic->header.source_id);
>   goto err_edac_unreg;
>   }
> - rc = request_irq(ghes->irq, ghes_irq_func, 0, "GHES IRQ", ghes);
> + rc = request_irq(ghes->irq, ghes_irq_func, IRQF_SHARED,
> +  "GHES IRQ", ghes);
>   if (rc) {
>   pr_err(GHES_PFX "Failed to register IRQ for generic 
> hardware error source: %d\n",
>  generic->header.source_id);
> -- 

Acked-by: Borislav Petkov 

-- 
Regards/Gruss,
Boris.

SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 
(AG Nürnberg)
--

Re: [PATCH v6 1/1] acpi: apei: Enable APEI multiple GHES source to share a single external IRQ

2017-07-22 Thread Borislav Petkov 
On Fri, Jul 21, 2017 at 11:24:37AM -0700, Loc Ho wrote:
> X-Gene platforms describe multiple GHES error sources with the same hardware
> error notification type (external interrupt) and interrupt number.
> Change the GHES interrupt request to support sharing the same IRQ.
> 
> Co-authored-by: Tuan Phan 
> Signed-off-by: Loc Ho 
> ---
>  drivers/acpi/apei/ghes.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c
> index d661d45..eed09fc 100644
> --- a/drivers/acpi/apei/ghes.c
> +++ b/drivers/acpi/apei/ghes.c
> @@ -1157,7 +1157,8 @@ static int ghes_probe(struct platform_device *ghes_dev)
>  generic->header.source_id);
>   goto err_edac_unreg;
>   }
> - rc = request_irq(ghes->irq, ghes_irq_func, 0, "GHES IRQ", ghes);
> + rc = request_irq(ghes->irq, ghes_irq_func, IRQF_SHARED,
> +  "GHES IRQ", ghes);
>   if (rc) {
>   pr_err(GHES_PFX "Failed to register IRQ for generic 
> hardware error source: %d\n",
>  generic->header.source_id);
> -- 

Acked-by: Borislav Petkov 

-- 
Regards/Gruss,
Boris.

SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 
(AG Nürnberg)
--