Re: [PATCH v6 5/5] regulator: RK808: remove redundant code
On Fri, Aug 29, 2014 at 06:13:10AM -0700, Doug Anderson wrote: > On Wed, Aug 27, 2014 at 2:01 AM, Mark Brown wrote: > > On Tue, Aug 26, 2014 at 10:18:57PM +0800, Chris Zhong wrote: > >> remove the redundant code, since pdata has been removed from stuct rk808 > > I've applied this but if there's further changes needed please wait > > until the MFD changes they depend on have been accepted before > > resending. This will be less work all round. > Can you clarify? As Chris makes the MFD changes that Lee and others > have requested then the regulator driver needs to change as well. > It's helpful for reviewers (and testers) of Chris's changes to see how > the regulator driver changes as the MFD interface changes. Should he > just take you off the CC list until he's ready? Yes, the frequent resends of MFD serieses are in general a problem and since these ones still don't seem to be getting threaded they're especially problematic. signature.asc Description: Digital signature
Re: [PATCH v6 5/5] regulator: RK808: remove redundant code
Mark, On Wed, Aug 27, 2014 at 2:01 AM, Mark Brown wrote: > On Tue, Aug 26, 2014 at 10:18:57PM +0800, Chris Zhong wrote: >> remove the redundant code, since pdata has been removed from stuct rk808 > > I've applied this but if there's further changes needed please wait > until the MFD changes they depend on have been accepted before > resending. This will be less work all round. Can you clarify? As Chris makes the MFD changes that Lee and others have requested then the regulator driver needs to change as well. It's helpful for reviewers (and testers) of Chris's changes to see how the regulator driver changes as the MFD interface changes. Should he just take you off the CC list until he's ready? I've asked Chris to please send out the next version of the series (including the regulator changes needed) since I'd like to see feedback addressed. If that doesn't match what you want him to do, please yell at me and not at him... Thanks! -Doug -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v6 5/5] regulator: RK808: remove redundant code
Mark, On Wed, Aug 27, 2014 at 2:01 AM, Mark Brown broo...@kernel.org wrote: On Tue, Aug 26, 2014 at 10:18:57PM +0800, Chris Zhong wrote: remove the redundant code, since pdata has been removed from stuct rk808 I've applied this but if there's further changes needed please wait until the MFD changes they depend on have been accepted before resending. This will be less work all round. Can you clarify? As Chris makes the MFD changes that Lee and others have requested then the regulator driver needs to change as well. It's helpful for reviewers (and testers) of Chris's changes to see how the regulator driver changes as the MFD interface changes. Should he just take you off the CC list until he's ready? I've asked Chris to please send out the next version of the series (including the regulator changes needed) since I'd like to see feedback addressed. If that doesn't match what you want him to do, please yell at me and not at him... Thanks! -Doug -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v6 5/5] regulator: RK808: remove redundant code
On Fri, Aug 29, 2014 at 06:13:10AM -0700, Doug Anderson wrote: On Wed, Aug 27, 2014 at 2:01 AM, Mark Brown broo...@kernel.org wrote: On Tue, Aug 26, 2014 at 10:18:57PM +0800, Chris Zhong wrote: remove the redundant code, since pdata has been removed from stuct rk808 I've applied this but if there's further changes needed please wait until the MFD changes they depend on have been accepted before resending. This will be less work all round. Can you clarify? As Chris makes the MFD changes that Lee and others have requested then the regulator driver needs to change as well. It's helpful for reviewers (and testers) of Chris's changes to see how the regulator driver changes as the MFD interface changes. Should he just take you off the CC list until he's ready? Yes, the frequent resends of MFD serieses are in general a problem and since these ones still don't seem to be getting threaded they're especially problematic. signature.asc Description: Digital signature
Re: [PATCH v6 5/5] regulator: RK808: remove redundant code
On Tue, Aug 26, 2014 at 10:18:57PM +0800, Chris Zhong wrote: > remove the redundant code, since pdata has been removed from stuct rk808 I've applied this but if there's further changes needed please wait until the MFD changes they depend on have been accepted before resending. This will be less work all round. signature.asc Description: Digital signature
Re: [PATCH v6 5/5] regulator: RK808: remove redundant code
On Tue, Aug 26, 2014 at 10:18:57PM +0800, Chris Zhong wrote: remove the redundant code, since pdata has been removed from stuct rk808 I've applied this but if there's further changes needed please wait until the MFD changes they depend on have been accepted before resending. This will be less work all round. signature.asc Description: Digital signature
Re: [PATCH v6 5/5] regulator: RK808: remove redundant code
Chris, On Tue, Aug 26, 2014 at 7:18 AM, Chris Zhong wrote: > remove the redundant code, since pdata has been removed from stuct rk808 > > Signed-off-by: Chris Zhong > > --- > > Changes in v6: > - remove the redundant code > > Changes in v5: > - re-edit base on Mark's branch > > Changes in v4: > - use >dev replace rk808->dev > > Changes in v3: None > Changes in v2: > Adviced by Mark Browm: > - change of_find_node_by_name to find_child_by_name > - use RK808_NUM_REGULATORS as the name of the constant > - create a pdata when missing platform data > - use the rk808_reg name to supply_regulator name > - replace regulator_register with devm_regulator_register > - some other problem with coding styl > > drivers/regulator/rk808-regulator.c | 17 - > 1 file changed, 4 insertions(+), 13 deletions(-) Probably shouldn't land until we've solved problems around the "platform data" in the MFD patch... -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v6 5/5] regulator: RK808: remove redundant code
Chris, On Tue, Aug 26, 2014 at 7:18 AM, Chris Zhong z...@rock-chips.com wrote: remove the redundant code, since pdata has been removed from stuct rk808 Signed-off-by: Chris Zhong z...@rock-chips.com --- Changes in v6: - remove the redundant code Changes in v5: - re-edit base on Mark's branch Changes in v4: - use client-dev replace rk808-dev Changes in v3: None Changes in v2: Adviced by Mark Browm: - change of_find_node_by_name to find_child_by_name - use RK808_NUM_REGULATORS as the name of the constant - create a pdata when missing platform data - use the rk808_reg name to supply_regulator name - replace regulator_register with devm_regulator_register - some other problem with coding styl drivers/regulator/rk808-regulator.c | 17 - 1 file changed, 4 insertions(+), 13 deletions(-) Probably shouldn't land until we've solved problems around the platform data in the MFD patch... -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
