Re: [PATCH v7] acpi: apei: remove the unused dead-code for SEA/NMI notification type

2017-10-22 Thread gengdongjiu 


On 2017/10/21 20:15, Borislav Petkov wrote:
>> Signed-off-by: Dongjiu Geng 
>> Tested-by: Tyler Baicar 
>> Signed-off-by: Borislav Petkov 
> I gave you Reviewed-by, not Signed-off-by.
> 
> Before you send more patches, read this:
> 
> Documentation/process/submitting-patches.rst
> 
> You can read the whole document but do especially concentrate on
> sections 11-13, in order to get an idea how the SOB chain and all that
> patch tagging works.

Borislav,
  Thanks a lot for your pointing out. sorry for that.
Just now I have read the "submitting-patches.rst". I will change it.

Re: [PATCH v7] acpi: apei: remove the unused dead-code for SEA/NMI notification type

2017-10-22 Thread gengdongjiu 


On 2017/10/21 20:15, Borislav Petkov wrote:
>> Signed-off-by: Dongjiu Geng 
>> Tested-by: Tyler Baicar 
>> Signed-off-by: Borislav Petkov 
> I gave you Reviewed-by, not Signed-off-by.
> 
> Before you send more patches, read this:
> 
> Documentation/process/submitting-patches.rst
> 
> You can read the whole document but do especially concentrate on
> sections 11-13, in order to get an idea how the SOB chain and all that
> patch tagging works.

Borislav,
  Thanks a lot for your pointing out. sorry for that.
Just now I have read the "submitting-patches.rst". I will change it.

Re: [PATCH v7] acpi: apei: remove the unused dead-code for SEA/NMI notification type

2017-10-21 Thread Borislav Petkov 
On Sat, Oct 21, 2017 at 06:35:03PM +0800, Dongjiu Geng wrote:
> For the SEA notification, the two functions ghes_sea_add() and
> ghes_sea_remove() are only called when CONFIG_ACPI_APEI_SEA
> is defined. If not, it will return errors in the ghes_probe()
> and not continue. If the probe is failed, the ghes_sea_remove()
> also has no chance to be called. Hence, remove the unnecessary
> handling when CONFIG_ACPI_APEI_SEA is not defined.
> 
> For the NMI notification, it has the same issue as SEA notification,
> so also remove the unused dead-code for it.
> 
> Cc: Tyler Baicar 
> Cc: James Morse 
> Signed-off-by: Dongjiu Geng 
> Tested-by: Tyler Baicar 
> Signed-off-by: Borislav Petkov 

I gave you Reviewed-by, not Signed-off-by.

Before you send more patches, read this:

Documentation/process/submitting-patches.rst

You can read the whole document but do especially concentrate on
sections 11-13, in order to get an idea how the SOB chain and all that
patch tagging works.

Thx.

-- 
Regards/Gruss,
Boris.

SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 
(AG Nürnberg)
--

Re: [PATCH v7] acpi: apei: remove the unused dead-code for SEA/NMI notification type

2017-10-21 Thread Borislav Petkov 
On Sat, Oct 21, 2017 at 06:35:03PM +0800, Dongjiu Geng wrote:
> For the SEA notification, the two functions ghes_sea_add() and
> ghes_sea_remove() are only called when CONFIG_ACPI_APEI_SEA
> is defined. If not, it will return errors in the ghes_probe()
> and not continue. If the probe is failed, the ghes_sea_remove()
> also has no chance to be called. Hence, remove the unnecessary
> handling when CONFIG_ACPI_APEI_SEA is not defined.
> 
> For the NMI notification, it has the same issue as SEA notification,
> so also remove the unused dead-code for it.
> 
> Cc: Tyler Baicar 
> Cc: James Morse 
> Signed-off-by: Dongjiu Geng 
> Tested-by: Tyler Baicar 
> Signed-off-by: Borislav Petkov 

I gave you Reviewed-by, not Signed-off-by.

Before you send more patches, read this:

Documentation/process/submitting-patches.rst

You can read the whole document but do especially concentrate on
sections 11-13, in order to get an idea how the SOB chain and all that
patch tagging works.

Thx.

-- 
Regards/Gruss,
Boris.

SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 
(AG Nürnberg)
--