Re: [PATCH v7 0/7] Syscall User Dispatch
On Thu, Nov 19, 2020 at 01:38:27PM +0100, Peter Zijlstra wrote: > On Tue, Nov 17, 2020 at 10:28:33PM -0500, Gabriel Krisman Bertazi wrote: > > Gabriel Krisman Bertazi (7): > > x86: vdso: Expose sigreturn address on vdso to the kernel > > signal: Expose SYS_USER_DISPATCH si_code type > > kernel: Implement selective syscall userspace redirection > > entry: Support Syscall User Dispatch on common syscall entry > > selftests: Add kselftest for syscall user dispatch > > selftests: Add benchmark for syscall user dispatch > > docs: Document Syscall User Dispatch > > Aside from the one little nit this looks good to me. > > Acked-by: Peter Zijlstra (Intel) Agreed, and thank you Gabriel for the SYSCALL_WORK series too. :) That's so nice to have! -- Kees Cook
Re: [PATCH v7 0/7] Syscall User Dispatch
On Tue, Nov 17, 2020 at 10:28:33PM -0500, Gabriel Krisman Bertazi wrote: > Gabriel Krisman Bertazi (7): > x86: vdso: Expose sigreturn address on vdso to the kernel > signal: Expose SYS_USER_DISPATCH si_code type > kernel: Implement selective syscall userspace redirection > entry: Support Syscall User Dispatch on common syscall entry > selftests: Add kselftest for syscall user dispatch > selftests: Add benchmark for syscall user dispatch > docs: Document Syscall User Dispatch Aside from the one little nit this looks good to me. Acked-by: Peter Zijlstra (Intel)
Re: [PATCH v7 0/7] Syscall User Dispatch
* Gabriel Krisman Bertazi: > The main use case is to intercept Windows system calls of an application > running over Wine. While Wine is using an unmodified glibc to execute > its own native Linux syscalls, the Windows libraries might be directly > issuing syscalls that we need to capture. So there is a mix. While this > mechanism is compatible with existing libc, we might have other > libraries executing a syscall instruction directly. Please raise this on libc-alpha, it's an unexpected compatibility constraint on glibc. Thanks.
Re: [PATCH v7 0/7] Syscall User Dispatch
Florian Weimer writes: > * Gabriel Krisman Bertazi: > >> This is the v7 of syscall user dispatch. This version is a bit >> different from v6 on the following points, after the modifications >> requested on that submission. > > Is this supposed to work with existing (Linux) libcs, or do you bring > your own low-level run-time libraries? Hi Florian, The main use case is to intercept Windows system calls of an application running over Wine. While Wine is using an unmodified glibc to execute its own native Linux syscalls, the Windows libraries might be directly issuing syscalls that we need to capture. So there is a mix. While this mechanism is compatible with existing libc, we might have other libraries executing a syscall instruction directly. -- Gabriel Krisman Bertazi
Re: [PATCH v7 0/7] Syscall User Dispatch
* Gabriel Krisman Bertazi: > This is the v7 of syscall user dispatch. This version is a bit > different from v6 on the following points, after the modifications > requested on that submission. Is this supposed to work with existing (Linux) libcs, or do you bring your own low-level run-time libraries?
