Re: [PATCH v8 4/8] devicetree: bindings: Document first ROHM BD70528 bindings
On Thu, Feb 07, 2019 at 07:42:29AM -0800, Guenter Roeck wrote: > On Thu, Feb 07, 2019 at 05:36:00PM +0200, Matti Vaittinen wrote: > > Hello Lee, > > > > Thanks for the reviews! > > > > On Thu, Feb 07, 2019 at 02:04:18PM +, Lee Jones wrote: > > > On Thu, 07 Feb 2019, Matti Vaittinen wrote: > > > > > > > Document bindings for regulators (3 bucks, 3 LDOs and 2 LED > > > > drivers) and 4 GPIO pins which can be configured for I/O or > > > > as interrupt sources withe configurable trigger levels. > > > > > > > > Signed-off-by: Matti Vaittinen > > > > Reviewed-by: Rob Herring > > > > Acked-by: Linus Walleij > > > > --- > > > > .../devicetree/bindings/mfd/rohm,bd70528-pmic.txt | 102 > > > > + > > > > 1 file changed, 102 insertions(+) > > > > create mode 100644 > > > > Documentation/devicetree/bindings/mfd/rohm,bd70528-pmic.txt > > > > > > > > diff --git > > > > a/Documentation/devicetree/bindings/mfd/rohm,bd70528-pmic.txt > > > > b/Documentation/devicetree/bindings/mfd/rohm,bd70528-pmic.txt > > > > new file mode 100644 > > > > index ..f80be7e40184 > > > > --- /dev/null > > > > +++ b/Documentation/devicetree/bindings/mfd/rohm,bd70528-pmic.txt > > > > @@ -0,0 +1,102 @@ > > > > +* ROHM BD70528 Power Management Integrated Circuit bindings > > > > + > > > > +BD70528MWV is an ultra-low Iq general purpose single-chip power > > > > management IC > > > > > > What's an Iq? > > > > http://www.ti.com/lit/an/slyt412/slyt412.pdf > > Iq is an abbreviation of quiescet current. Do you think it's worth > > writing the whole words instead of an abbreviation? > > > https://acronyms.thefreedictionary.com/IQ lists 23 definitions. > This one is not listed. Yes, I think it would be beneficial to use > the whole word. Allright. I'll change that too =) Br, Matti Vaittinen -- Matti Vaittinen, Linux device drivers ROHM Semiconductors, Finland SWDC Kiviharjunlenkki 1E 90220 OULU FINLAND ~~~ "I don't think so," said Rene Descartes. Just then, he vanished ~~~
Re: [PATCH v8 4/8] devicetree: bindings: Document first ROHM BD70528 bindings
On Thu, Feb 07, 2019 at 05:36:00PM +0200, Matti Vaittinen wrote: > Hello Lee, > > Thanks for the reviews! > > On Thu, Feb 07, 2019 at 02:04:18PM +, Lee Jones wrote: > > On Thu, 07 Feb 2019, Matti Vaittinen wrote: > > > > > Document bindings for regulators (3 bucks, 3 LDOs and 2 LED > > > drivers) and 4 GPIO pins which can be configured for I/O or > > > as interrupt sources withe configurable trigger levels. > > > > > > Signed-off-by: Matti Vaittinen > > > Reviewed-by: Rob Herring > > > Acked-by: Linus Walleij > > > --- > > > .../devicetree/bindings/mfd/rohm,bd70528-pmic.txt | 102 > > > + > > > 1 file changed, 102 insertions(+) > > > create mode 100644 > > > Documentation/devicetree/bindings/mfd/rohm,bd70528-pmic.txt > > > > > > diff --git a/Documentation/devicetree/bindings/mfd/rohm,bd70528-pmic.txt > > > b/Documentation/devicetree/bindings/mfd/rohm,bd70528-pmic.txt > > > new file mode 100644 > > > index ..f80be7e40184 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/mfd/rohm,bd70528-pmic.txt > > > @@ -0,0 +1,102 @@ > > > +* ROHM BD70528 Power Management Integrated Circuit bindings > > > + > > > +BD70528MWV is an ultra-low Iq general purpose single-chip power > > > management IC > > > > What's an Iq? > > http://www.ti.com/lit/an/slyt412/slyt412.pdf > Iq is an abbreviation of quiescet current. Do you think it's worth > writing the whole words instead of an abbreviation? > https://acronyms.thefreedictionary.com/IQ lists 23 definitions. This one is not listed. Yes, I think it would be beneficial to use the whole word. Guenter > Thanks for the rest of the corrections, I'll fix them in next version. > > Br, > Matti Vaittinen
Re: [PATCH v8 4/8] devicetree: bindings: Document first ROHM BD70528 bindings
Hello Lee, Thanks for the reviews! On Thu, Feb 07, 2019 at 02:04:18PM +, Lee Jones wrote: > On Thu, 07 Feb 2019, Matti Vaittinen wrote: > > > Document bindings for regulators (3 bucks, 3 LDOs and 2 LED > > drivers) and 4 GPIO pins which can be configured for I/O or > > as interrupt sources withe configurable trigger levels. > > > > Signed-off-by: Matti Vaittinen > > Reviewed-by: Rob Herring > > Acked-by: Linus Walleij > > --- > > .../devicetree/bindings/mfd/rohm,bd70528-pmic.txt | 102 > > + > > 1 file changed, 102 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/mfd/rohm,bd70528-pmic.txt > > > > diff --git a/Documentation/devicetree/bindings/mfd/rohm,bd70528-pmic.txt > > b/Documentation/devicetree/bindings/mfd/rohm,bd70528-pmic.txt > > new file mode 100644 > > index ..f80be7e40184 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/mfd/rohm,bd70528-pmic.txt > > @@ -0,0 +1,102 @@ > > +* ROHM BD70528 Power Management Integrated Circuit bindings > > + > > +BD70528MWV is an ultra-low Iq general purpose single-chip power management > > IC > > What's an Iq? http://www.ti.com/lit/an/slyt412/slyt412.pdf Iq is an abbreviation of quiescet current. Do you think it's worth writing the whole words instead of an abbreviation? Thanks for the rest of the corrections, I'll fix them in next version. Br, Matti Vaittinen
Re: [PATCH v8 4/8] devicetree: bindings: Document first ROHM BD70528 bindings
On Thu, 07 Feb 2019, Matti Vaittinen wrote:
> Document bindings for regulators (3 bucks, 3 LDOs and 2 LED
> drivers) and 4 GPIO pins which can be configured for I/O or
> as interrupt sources withe configurable trigger levels.
>
> Signed-off-by: Matti Vaittinen
> Reviewed-by: Rob Herring
> Acked-by: Linus Walleij
> ---
> .../devicetree/bindings/mfd/rohm,bd70528-pmic.txt | 102
> +
> 1 file changed, 102 insertions(+)
> create mode 100644
> Documentation/devicetree/bindings/mfd/rohm,bd70528-pmic.txt
>
> diff --git a/Documentation/devicetree/bindings/mfd/rohm,bd70528-pmic.txt
> b/Documentation/devicetree/bindings/mfd/rohm,bd70528-pmic.txt
> new file mode 100644
> index ..f80be7e40184
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/rohm,bd70528-pmic.txt
> @@ -0,0 +1,102 @@
> +* ROHM BD70528 Power Management Integrated Circuit bindings
> +
> +BD70528MWV is an ultra-low Iq general purpose single-chip power management IC
What's an Iq?
> +for battery-powered portable devices. The IC integrates 3 ultra-low current
> +consumption buck converters, 3 LDOs and 2 LED Drivers. Also included are 4
> +GPIOs, a real-time clock (RTC), a 32kHz clock gate, high-accuracy VREF
> +for use with an external ADC, flexible dual-input power path, 10 bits SAR ADC
"bit"
> +for battery temperature monitor and 1S battery charger with scalable charge
> +currents.
> +
> +Required properties:
> + - compatible: Should be "rohm,bd70528"
> + - reg : I2C slave address.
> + - interrupts: The interrupt line the device is connected to.
> + - interrupt-controller : To indicate bd70528 acts as an interrupt
> controller.
"BS70528"
> + - #interrupt-cells : Should be 2. usage is compliant to the 2 cells
"Usage"
> + variant of ../interrupt-controller/interrupts.txt
> + - gpio-controller : To indicate bd70528 acts as a gpio controller.
"BD*"
"GPIO"
> + - #gpio-cells : Should be 2. The first cell is the pin number
> and
> + the second cell is used to specify flags. See
> + ../gpio/gpio.txt for more information.
> + - #clock-cells : Should be 0.
> + - regulators: : List of child nodes that specify the
> regulators.
> + Please see ../regulator/rohm,bd70528-regulator.txt
> +
> +Optional properties:
> + - clock-output-names: Should contain name for output clock.
> +
> +Example:
> +/* external oscillator */
> +osc: oscillator {
> + compatible = "fixed-clock";
> + #clock-cells = <1>;
> + clock-frequency = <32768>;
> + clock-output-names = "osc";
> +};
> +
> +pmic: pmic@4b {
> + compatible = "rohm,bd70528";
> + reg = <0x4b>;
> + interrupt-parent = <>;
> + interrupts = <29 GPIO_ACTIVE_LOW>;
> + clocks = < 0>;
> + #clock-cells = <0>;
> + clock-output-names = "bd70528-32k-out";
> + #gpio-cells = <2>;
> + gpio-controller;
> + interrupt-controller;
> + #interrupt-cells = <2>;
> +
> + regulators {
> + buck1: BUCK1 {
> + regulator-name = "buck1";
> + regulator-min-microvolt = <120>;
> + regulator-max-microvolt = <340>;
> + regulator-boot-on;
> + regulator-ramp-delay = <125>;
> + };
> + buck2: BUCK2 {
> + regulator-name = "buck2";
> + regulator-min-microvolt = <120>;
> + regulator-max-microvolt = <330>;
> + regulator-boot-on;
> + regulator-ramp-delay = <125>;
> + };
> + buck3: BUCK3 {
> + regulator-name = "buck3";
> + regulator-min-microvolt = <80>;
> + regulator-max-microvolt = <180>;
> + regulator-boot-on;
> + regulator-ramp-delay = <250>;
> + };
> + ldo1: LDO1 {
> + regulator-name = "ldo1";
> + regulator-min-microvolt = <165>;
> + regulator-max-microvolt = <330>;
> + regulator-boot-on;
> + };
> + ldo2: LDO2 {
> + regulator-name = "ldo2";
> + regulator-min-microvolt = <165>;
> + regulator-max-microvolt = <330>;
> + regulator-boot-on;
> + };
> +
> + ldo3: LDO3 {
> + regulator-name = "ldo3";
> + regulator-min-microvolt = <165>;
> + regulator-max-microvolt = <330>;
> + };
> + led_ldo1: LED_LDO1 {
> + regulator-name = "led_ldo1";
> + regulator-min-microvolt = <20>;
> +
