Re: [PATCH v9 4/5] rtc: max77686: Remove unneded info log

2014-08-28 Thread Krzysztof Kozlowski 
On pon, 2014-08-18 at 10:34 +0200, Javier Martinez Canillas wrote:
> If devm_rtc_device_register() fails a dev_err() is already
> reported so there is no need to do an additional dev_info().
> 
> Signed-off-by: Javier Martinez Canillas 

Reviewed-by: Krzysztof Kozlowski 

Best regards,
Krzysztof

> ---
>  drivers/rtc/rtc-max77686.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/rtc/rtc-max77686.c b/drivers/rtc/rtc-max77686.c
> index 55396bb..b177ba1 100644
> --- a/drivers/rtc/rtc-max77686.c
> +++ b/drivers/rtc/rtc-max77686.c
> @@ -457,8 +457,6 @@ static int max77686_rtc_probe(struct platform_device 
> *pdev)
>   _rtc_ops, THIS_MODULE);
>  
>   if (IS_ERR(info->rtc_dev)) {
> - dev_info(>dev, "%s: fail\n", __func__);
> -
>   ret = PTR_ERR(info->rtc_dev);
>   dev_err(>dev, "Failed to register RTC device: %d\n", ret);
>   if (ret == 0)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v9 4/5] rtc: max77686: Remove unneded info log

2014-08-28 Thread Krzysztof Kozlowski 
On pon, 2014-08-18 at 10:34 +0200, Javier Martinez Canillas wrote:
 If devm_rtc_device_register() fails a dev_err() is already
 reported so there is no need to do an additional dev_info().
 
 Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk

Reviewed-by: Krzysztof Kozlowski k.kozlow...@samsung.com

Best regards,
Krzysztof

 ---
  drivers/rtc/rtc-max77686.c | 2 --
  1 file changed, 2 deletions(-)
 
 diff --git a/drivers/rtc/rtc-max77686.c b/drivers/rtc/rtc-max77686.c
 index 55396bb..b177ba1 100644
 --- a/drivers/rtc/rtc-max77686.c
 +++ b/drivers/rtc/rtc-max77686.c
 @@ -457,8 +457,6 @@ static int max77686_rtc_probe(struct platform_device 
 *pdev)
   max77686_rtc_ops, THIS_MODULE);
  
   if (IS_ERR(info-rtc_dev)) {
 - dev_info(pdev-dev, %s: fail\n, __func__);
 -
   ret = PTR_ERR(info-rtc_dev);
   dev_err(pdev-dev, Failed to register RTC device: %d\n, ret);
   if (ret == 0)

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/