Re: [RESEND PATCH 1/8] mfd: cros ec: Remove parent field
Hello Lee, On 05/05/2015 12:54 PM, Lee Jones wrote: > On Tue, 05 May 2015, Javier Martinez Canillas wrote: >> On 04/29/2015 12:37 PM, Lee Jones wrote: >> > On Thu, 23 Apr 2015, Gwendal Grignou wrote: >> > >> >> Be consistent, use cros_ec instead of "cros ec" or "cros-ec". >> > >> > What is this in reference to? >> > >> >> I think Gwendal meant that I should be consistent in general and was not >> referring to this patch particular. > > Better to quote one of the offending occurrences than to randomly > top-post helpful comments. > Just for clarification, on a second read I noticed that Gwendal was talking about the subject line since $subject uses "mfd: cros ec" as a prefix while most of the commits in the subsystem (and in the series) use "mfd: cros_ec". Also, there is another patch (5/8) that used "mfd: cros-ec" so he is right that I should had used cros_ec consistently. Sorry for missing that and I will fix when posting v2. Best regards, Javier -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [RESEND PATCH 1/8] mfd: cros ec: Remove parent field
Hello Lee, On 05/05/2015 12:54 PM, Lee Jones wrote: On Tue, 05 May 2015, Javier Martinez Canillas wrote: On 04/29/2015 12:37 PM, Lee Jones wrote: On Thu, 23 Apr 2015, Gwendal Grignou wrote: Be consistent, use cros_ec instead of cros ec or cros-ec. What is this in reference to? I think Gwendal meant that I should be consistent in general and was not referring to this patch particular. Better to quote one of the offending occurrences than to randomly top-post helpful comments. Just for clarification, on a second read I noticed that Gwendal was talking about the subject line since $subject uses mfd: cros ec as a prefix while most of the commits in the subsystem (and in the series) use mfd: cros_ec. Also, there is another patch (5/8) that used mfd: cros-ec so he is right that I should had used cros_ec consistently. Sorry for missing that and I will fix when posting v2. Best regards, Javier -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [RESEND PATCH 1/8] mfd: cros ec: Remove parent field
On Tue, 05 May 2015, Javier Martinez Canillas wrote: > On 04/29/2015 12:37 PM, Lee Jones wrote: > > On Thu, 23 Apr 2015, Gwendal Grignou wrote: > > > >> Be consistent, use cros_ec instead of "cros ec" or "cros-ec". > > > > What is this in reference to? > > > > I think Gwendal meant that I should be consistent in general and was not > referring to this patch particular. Better to quote one of the offending occurrences than to randomly top-post helpful comments. > >> Otherwise: > >> > >> Reviewed-by: Gwendal Grignou > >> Tested-by: Gwendal Grignou > >> > >> On Mon, Apr 6, 2015 at 9:14 AM, Javier Martinez Canillas > >> wrote: > >> > From: Gwendal Grignou > >> > > >> > parent and dev were pointing to the same device structure. > >> > parent is unused, removed. > >> > > >> > Signed-off-by: Gwendal Grignou > >> > Reviewed-by: Stephen Barber > >> > Tested-by: Stephen Barber > >> > Reviewed-by: Puthikorn Voravootivat > >> > Signed-off-by: Javier Martinez Canillas > >> > --- > >> > drivers/mfd/cros_ec_i2c.c | 1 - > >> > drivers/mfd/cros_ec_spi.c | 1 - > >> > drivers/platform/chrome/cros_ec_lpc.c | 1 - > >> > include/linux/mfd/cros_ec.h | 2 -- > >> > 4 files changed, 5 deletions(-) > > > > For when you re-submit: > > > > Acked-by: Lee Jones > > > > Thanks a lot for your ack. > > Best regards, > Javier -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [RESEND PATCH 1/8] mfd: cros ec: Remove parent field
Hello Lee, On 04/29/2015 12:37 PM, Lee Jones wrote: > On Thu, 23 Apr 2015, Gwendal Grignou wrote: > >> Be consistent, use cros_ec instead of "cros ec" or "cros-ec". > > What is this in reference to? > I think Gwendal meant that I should be consistent in general and was not referring to this patch particular. >> Otherwise: >> >> Reviewed-by: Gwendal Grignou >> Tested-by: Gwendal Grignou >> >> On Mon, Apr 6, 2015 at 9:14 AM, Javier Martinez Canillas >> wrote: >> > From: Gwendal Grignou >> > >> > parent and dev were pointing to the same device structure. >> > parent is unused, removed. >> > >> > Signed-off-by: Gwendal Grignou >> > Reviewed-by: Stephen Barber >> > Tested-by: Stephen Barber >> > Reviewed-by: Puthikorn Voravootivat >> > Signed-off-by: Javier Martinez Canillas >> > --- >> > drivers/mfd/cros_ec_i2c.c | 1 - >> > drivers/mfd/cros_ec_spi.c | 1 - >> > drivers/platform/chrome/cros_ec_lpc.c | 1 - >> > include/linux/mfd/cros_ec.h | 2 -- >> > 4 files changed, 5 deletions(-) > > For when you re-submit: > > Acked-by: Lee Jones > Thanks a lot for your ack. Best regards, Javier -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [RESEND PATCH 1/8] mfd: cros ec: Remove parent field
Hello Lee, On 04/29/2015 12:37 PM, Lee Jones wrote: On Thu, 23 Apr 2015, Gwendal Grignou wrote: Be consistent, use cros_ec instead of cros ec or cros-ec. What is this in reference to? I think Gwendal meant that I should be consistent in general and was not referring to this patch particular. Otherwise: Reviewed-by: Gwendal Grignou gwen...@chromium.org Tested-by: Gwendal Grignou gwen...@chromium.org On Mon, Apr 6, 2015 at 9:14 AM, Javier Martinez Canillas javier.marti...@collabora.co.uk wrote: From: Gwendal Grignou gwen...@chromium.org parent and dev were pointing to the same device structure. parent is unused, removed. Signed-off-by: Gwendal Grignou gwen...@chromium.org Reviewed-by: Stephen Barber smbar...@chromium.org Tested-by: Stephen Barber smbar...@chromium.org Reviewed-by: Puthikorn Voravootivat put...@chromium.org Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk --- drivers/mfd/cros_ec_i2c.c | 1 - drivers/mfd/cros_ec_spi.c | 1 - drivers/platform/chrome/cros_ec_lpc.c | 1 - include/linux/mfd/cros_ec.h | 2 -- 4 files changed, 5 deletions(-) For when you re-submit: Acked-by: Lee Jones lee.jo...@linaro.org Thanks a lot for your ack. Best regards, Javier -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [RESEND PATCH 1/8] mfd: cros ec: Remove parent field
On Tue, 05 May 2015, Javier Martinez Canillas wrote: On 04/29/2015 12:37 PM, Lee Jones wrote: On Thu, 23 Apr 2015, Gwendal Grignou wrote: Be consistent, use cros_ec instead of cros ec or cros-ec. What is this in reference to? I think Gwendal meant that I should be consistent in general and was not referring to this patch particular. Better to quote one of the offending occurrences than to randomly top-post helpful comments. Otherwise: Reviewed-by: Gwendal Grignou gwen...@chromium.org Tested-by: Gwendal Grignou gwen...@chromium.org On Mon, Apr 6, 2015 at 9:14 AM, Javier Martinez Canillas javier.marti...@collabora.co.uk wrote: From: Gwendal Grignou gwen...@chromium.org parent and dev were pointing to the same device structure. parent is unused, removed. Signed-off-by: Gwendal Grignou gwen...@chromium.org Reviewed-by: Stephen Barber smbar...@chromium.org Tested-by: Stephen Barber smbar...@chromium.org Reviewed-by: Puthikorn Voravootivat put...@chromium.org Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk --- drivers/mfd/cros_ec_i2c.c | 1 - drivers/mfd/cros_ec_spi.c | 1 - drivers/platform/chrome/cros_ec_lpc.c | 1 - include/linux/mfd/cros_ec.h | 2 -- 4 files changed, 5 deletions(-) For when you re-submit: Acked-by: Lee Jones lee.jo...@linaro.org Thanks a lot for your ack. Best regards, Javier -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [RESEND PATCH 1/8] mfd: cros ec: Remove parent field
On Thu, 23 Apr 2015, Gwendal Grignou wrote:
> Be consistent, use cros_ec instead of "cros ec" or "cros-ec".
What is this in reference to?
> Otherwise:
>
> Reviewed-by: Gwendal Grignou
> Tested-by: Gwendal Grignou
>
> On Mon, Apr 6, 2015 at 9:14 AM, Javier Martinez Canillas
> wrote:
> > From: Gwendal Grignou
> >
> > parent and dev were pointing to the same device structure.
> > parent is unused, removed.
> >
> > Signed-off-by: Gwendal Grignou
> > Reviewed-by: Stephen Barber
> > Tested-by: Stephen Barber
> > Reviewed-by: Puthikorn Voravootivat
> > Signed-off-by: Javier Martinez Canillas
> > ---
> > drivers/mfd/cros_ec_i2c.c | 1 -
> > drivers/mfd/cros_ec_spi.c | 1 -
> > drivers/platform/chrome/cros_ec_lpc.c | 1 -
> > include/linux/mfd/cros_ec.h | 2 --
> > 4 files changed, 5 deletions(-)
For when you re-submit:
Acked-by: Lee Jones
> > diff --git a/drivers/mfd/cros_ec_i2c.c b/drivers/mfd/cros_ec_i2c.c
> > index c0c30f4f946f..82b4d6148698 100644
> > --- a/drivers/mfd/cros_ec_i2c.c
> > +++ b/drivers/mfd/cros_ec_i2c.c
> > @@ -145,7 +145,6 @@ static int cros_ec_i2c_probe(struct i2c_client *client,
> > ec_dev->cmd_xfer = cros_ec_cmd_xfer_i2c;
> > ec_dev->ec_name = client->name;
> > ec_dev->phys_name = client->adapter->name;
> > - ec_dev->parent = >dev;
> >
> > err = cros_ec_register(ec_dev);
> > if (err) {
> > diff --git a/drivers/mfd/cros_ec_spi.c b/drivers/mfd/cros_ec_spi.c
> > index bf6e08e8013e..27bd52e5e8b7 100644
> > --- a/drivers/mfd/cros_ec_spi.c
> > +++ b/drivers/mfd/cros_ec_spi.c
> > @@ -363,7 +363,6 @@ static int cros_ec_spi_probe(struct spi_device *spi)
> > ec_dev->cmd_xfer = cros_ec_cmd_xfer_spi;
> > ec_dev->ec_name = ec_spi->spi->modalias;
> > ec_dev->phys_name = dev_name(_spi->spi->dev);
> > - ec_dev->parent = _spi->spi->dev;
> > ec_dev->din_size = EC_MSG_BYTES + EC_MSG_PREAMBLE_COUNT;
> > ec_dev->dout_size = EC_MSG_BYTES;
> >
> > diff --git a/drivers/platform/chrome/cros_ec_lpc.c
> > b/drivers/platform/chrome/cros_ec_lpc.c
> > index 8f9ac4d7bbd0..860310513cf0 100644
> > --- a/drivers/platform/chrome/cros_ec_lpc.c
> > +++ b/drivers/platform/chrome/cros_ec_lpc.c
> > @@ -214,7 +214,6 @@ static int cros_ec_lpc_probe(struct platform_device
> > *pdev)
> > ec_dev->dev = dev;
> > ec_dev->ec_name = pdev->name;
> > ec_dev->phys_name = dev_name(dev);
> > - ec_dev->parent = dev;
> > ec_dev->cmd_xfer = cros_ec_cmd_xfer_lpc;
> > ec_dev->cmd_readmem = cros_ec_lpc_readmem;
> >
> > diff --git a/include/linux/mfd/cros_ec.h b/include/linux/mfd/cros_ec.h
> > index 324a34683971..14cf522123dd 100644
> > --- a/include/linux/mfd/cros_ec.h
> > +++ b/include/linux/mfd/cros_ec.h
> > @@ -85,7 +85,6 @@ struct cros_ec_command {
> > * to using dword.
> > * @din_size: size of din buffer to allocate (zero to use static din)
> > * @dout_size: size of dout buffer to allocate (zero to use static dout)
> > - * @parent: pointer to parent device (e.g. i2c or spi device)
> > * @wake_enabled: true if this device can wake the system from sleep
> > * @cmd_xfer: send command to EC and get response
> > * Returns the number of bytes received if the communication
> > succeeded, but
> > @@ -113,7 +112,6 @@ struct cros_ec_device {
> > uint8_t *dout;
> > int din_size;
> > int dout_size;
> > - struct device *parent;
> > bool wake_enabled;
> > int (*cmd_xfer)(struct cros_ec_device *ec,
> > struct cros_ec_command *msg);
> >
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [RESEND PATCH 1/8] mfd: cros ec: Remove parent field
On Thu, 23 Apr 2015, Gwendal Grignou wrote:
Be consistent, use cros_ec instead of cros ec or cros-ec.
What is this in reference to?
Otherwise:
Reviewed-by: Gwendal Grignou gwen...@chromium.org
Tested-by: Gwendal Grignou gwen...@chromium.org
On Mon, Apr 6, 2015 at 9:14 AM, Javier Martinez Canillas
javier.marti...@collabora.co.uk wrote:
From: Gwendal Grignou gwen...@chromium.org
parent and dev were pointing to the same device structure.
parent is unused, removed.
Signed-off-by: Gwendal Grignou gwen...@chromium.org
Reviewed-by: Stephen Barber smbar...@chromium.org
Tested-by: Stephen Barber smbar...@chromium.org
Reviewed-by: Puthikorn Voravootivat put...@chromium.org
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
drivers/mfd/cros_ec_i2c.c | 1 -
drivers/mfd/cros_ec_spi.c | 1 -
drivers/platform/chrome/cros_ec_lpc.c | 1 -
include/linux/mfd/cros_ec.h | 2 --
4 files changed, 5 deletions(-)
For when you re-submit:
Acked-by: Lee Jones lee.jo...@linaro.org
diff --git a/drivers/mfd/cros_ec_i2c.c b/drivers/mfd/cros_ec_i2c.c
index c0c30f4f946f..82b4d6148698 100644
--- a/drivers/mfd/cros_ec_i2c.c
+++ b/drivers/mfd/cros_ec_i2c.c
@@ -145,7 +145,6 @@ static int cros_ec_i2c_probe(struct i2c_client *client,
ec_dev-cmd_xfer = cros_ec_cmd_xfer_i2c;
ec_dev-ec_name = client-name;
ec_dev-phys_name = client-adapter-name;
- ec_dev-parent = client-dev;
err = cros_ec_register(ec_dev);
if (err) {
diff --git a/drivers/mfd/cros_ec_spi.c b/drivers/mfd/cros_ec_spi.c
index bf6e08e8013e..27bd52e5e8b7 100644
--- a/drivers/mfd/cros_ec_spi.c
+++ b/drivers/mfd/cros_ec_spi.c
@@ -363,7 +363,6 @@ static int cros_ec_spi_probe(struct spi_device *spi)
ec_dev-cmd_xfer = cros_ec_cmd_xfer_spi;
ec_dev-ec_name = ec_spi-spi-modalias;
ec_dev-phys_name = dev_name(ec_spi-spi-dev);
- ec_dev-parent = ec_spi-spi-dev;
ec_dev-din_size = EC_MSG_BYTES + EC_MSG_PREAMBLE_COUNT;
ec_dev-dout_size = EC_MSG_BYTES;
diff --git a/drivers/platform/chrome/cros_ec_lpc.c
b/drivers/platform/chrome/cros_ec_lpc.c
index 8f9ac4d7bbd0..860310513cf0 100644
--- a/drivers/platform/chrome/cros_ec_lpc.c
+++ b/drivers/platform/chrome/cros_ec_lpc.c
@@ -214,7 +214,6 @@ static int cros_ec_lpc_probe(struct platform_device
*pdev)
ec_dev-dev = dev;
ec_dev-ec_name = pdev-name;
ec_dev-phys_name = dev_name(dev);
- ec_dev-parent = dev;
ec_dev-cmd_xfer = cros_ec_cmd_xfer_lpc;
ec_dev-cmd_readmem = cros_ec_lpc_readmem;
diff --git a/include/linux/mfd/cros_ec.h b/include/linux/mfd/cros_ec.h
index 324a34683971..14cf522123dd 100644
--- a/include/linux/mfd/cros_ec.h
+++ b/include/linux/mfd/cros_ec.h
@@ -85,7 +85,6 @@ struct cros_ec_command {
* to using dword.
* @din_size: size of din buffer to allocate (zero to use static din)
* @dout_size: size of dout buffer to allocate (zero to use static dout)
- * @parent: pointer to parent device (e.g. i2c or spi device)
* @wake_enabled: true if this device can wake the system from sleep
* @cmd_xfer: send command to EC and get response
* Returns the number of bytes received if the communication
succeeded, but
@@ -113,7 +112,6 @@ struct cros_ec_device {
uint8_t *dout;
int din_size;
int dout_size;
- struct device *parent;
bool wake_enabled;
int (*cmd_xfer)(struct cros_ec_device *ec,
struct cros_ec_command *msg);
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [RESEND PATCH 1/8] mfd: cros ec: Remove parent field
Be consistent, use cros_ec instead of "cros ec" or "cros-ec".
Otherwise:
Reviewed-by: Gwendal Grignou
Tested-by: Gwendal Grignou
On Mon, Apr 6, 2015 at 9:14 AM, Javier Martinez Canillas
wrote:
> From: Gwendal Grignou
>
> parent and dev were pointing to the same device structure.
> parent is unused, removed.
>
> Signed-off-by: Gwendal Grignou
> Reviewed-by: Stephen Barber
> Tested-by: Stephen Barber
> Reviewed-by: Puthikorn Voravootivat
> Signed-off-by: Javier Martinez Canillas
> ---
> drivers/mfd/cros_ec_i2c.c | 1 -
> drivers/mfd/cros_ec_spi.c | 1 -
> drivers/platform/chrome/cros_ec_lpc.c | 1 -
> include/linux/mfd/cros_ec.h | 2 --
> 4 files changed, 5 deletions(-)
>
> diff --git a/drivers/mfd/cros_ec_i2c.c b/drivers/mfd/cros_ec_i2c.c
> index c0c30f4f946f..82b4d6148698 100644
> --- a/drivers/mfd/cros_ec_i2c.c
> +++ b/drivers/mfd/cros_ec_i2c.c
> @@ -145,7 +145,6 @@ static int cros_ec_i2c_probe(struct i2c_client *client,
> ec_dev->cmd_xfer = cros_ec_cmd_xfer_i2c;
> ec_dev->ec_name = client->name;
> ec_dev->phys_name = client->adapter->name;
> - ec_dev->parent = >dev;
>
> err = cros_ec_register(ec_dev);
> if (err) {
> diff --git a/drivers/mfd/cros_ec_spi.c b/drivers/mfd/cros_ec_spi.c
> index bf6e08e8013e..27bd52e5e8b7 100644
> --- a/drivers/mfd/cros_ec_spi.c
> +++ b/drivers/mfd/cros_ec_spi.c
> @@ -363,7 +363,6 @@ static int cros_ec_spi_probe(struct spi_device *spi)
> ec_dev->cmd_xfer = cros_ec_cmd_xfer_spi;
> ec_dev->ec_name = ec_spi->spi->modalias;
> ec_dev->phys_name = dev_name(_spi->spi->dev);
> - ec_dev->parent = _spi->spi->dev;
> ec_dev->din_size = EC_MSG_BYTES + EC_MSG_PREAMBLE_COUNT;
> ec_dev->dout_size = EC_MSG_BYTES;
>
> diff --git a/drivers/platform/chrome/cros_ec_lpc.c
> b/drivers/platform/chrome/cros_ec_lpc.c
> index 8f9ac4d7bbd0..860310513cf0 100644
> --- a/drivers/platform/chrome/cros_ec_lpc.c
> +++ b/drivers/platform/chrome/cros_ec_lpc.c
> @@ -214,7 +214,6 @@ static int cros_ec_lpc_probe(struct platform_device *pdev)
> ec_dev->dev = dev;
> ec_dev->ec_name = pdev->name;
> ec_dev->phys_name = dev_name(dev);
> - ec_dev->parent = dev;
> ec_dev->cmd_xfer = cros_ec_cmd_xfer_lpc;
> ec_dev->cmd_readmem = cros_ec_lpc_readmem;
>
> diff --git a/include/linux/mfd/cros_ec.h b/include/linux/mfd/cros_ec.h
> index 324a34683971..14cf522123dd 100644
> --- a/include/linux/mfd/cros_ec.h
> +++ b/include/linux/mfd/cros_ec.h
> @@ -85,7 +85,6 @@ struct cros_ec_command {
> * to using dword.
> * @din_size: size of din buffer to allocate (zero to use static din)
> * @dout_size: size of dout buffer to allocate (zero to use static dout)
> - * @parent: pointer to parent device (e.g. i2c or spi device)
> * @wake_enabled: true if this device can wake the system from sleep
> * @cmd_xfer: send command to EC and get response
> * Returns the number of bytes received if the communication succeeded,
> but
> @@ -113,7 +112,6 @@ struct cros_ec_device {
> uint8_t *dout;
> int din_size;
> int dout_size;
> - struct device *parent;
> bool wake_enabled;
> int (*cmd_xfer)(struct cros_ec_device *ec,
> struct cros_ec_command *msg);
> --
> 2.1.4
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [RESEND PATCH 1/8] mfd: cros ec: Remove parent field
Be consistent, use cros_ec instead of cros ec or cros-ec.
Otherwise:
Reviewed-by: Gwendal Grignou gwen...@chromium.org
Tested-by: Gwendal Grignou gwen...@chromium.org
On Mon, Apr 6, 2015 at 9:14 AM, Javier Martinez Canillas
javier.marti...@collabora.co.uk wrote:
From: Gwendal Grignou gwen...@chromium.org
parent and dev were pointing to the same device structure.
parent is unused, removed.
Signed-off-by: Gwendal Grignou gwen...@chromium.org
Reviewed-by: Stephen Barber smbar...@chromium.org
Tested-by: Stephen Barber smbar...@chromium.org
Reviewed-by: Puthikorn Voravootivat put...@chromium.org
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
drivers/mfd/cros_ec_i2c.c | 1 -
drivers/mfd/cros_ec_spi.c | 1 -
drivers/platform/chrome/cros_ec_lpc.c | 1 -
include/linux/mfd/cros_ec.h | 2 --
4 files changed, 5 deletions(-)
diff --git a/drivers/mfd/cros_ec_i2c.c b/drivers/mfd/cros_ec_i2c.c
index c0c30f4f946f..82b4d6148698 100644
--- a/drivers/mfd/cros_ec_i2c.c
+++ b/drivers/mfd/cros_ec_i2c.c
@@ -145,7 +145,6 @@ static int cros_ec_i2c_probe(struct i2c_client *client,
ec_dev-cmd_xfer = cros_ec_cmd_xfer_i2c;
ec_dev-ec_name = client-name;
ec_dev-phys_name = client-adapter-name;
- ec_dev-parent = client-dev;
err = cros_ec_register(ec_dev);
if (err) {
diff --git a/drivers/mfd/cros_ec_spi.c b/drivers/mfd/cros_ec_spi.c
index bf6e08e8013e..27bd52e5e8b7 100644
--- a/drivers/mfd/cros_ec_spi.c
+++ b/drivers/mfd/cros_ec_spi.c
@@ -363,7 +363,6 @@ static int cros_ec_spi_probe(struct spi_device *spi)
ec_dev-cmd_xfer = cros_ec_cmd_xfer_spi;
ec_dev-ec_name = ec_spi-spi-modalias;
ec_dev-phys_name = dev_name(ec_spi-spi-dev);
- ec_dev-parent = ec_spi-spi-dev;
ec_dev-din_size = EC_MSG_BYTES + EC_MSG_PREAMBLE_COUNT;
ec_dev-dout_size = EC_MSG_BYTES;
diff --git a/drivers/platform/chrome/cros_ec_lpc.c
b/drivers/platform/chrome/cros_ec_lpc.c
index 8f9ac4d7bbd0..860310513cf0 100644
--- a/drivers/platform/chrome/cros_ec_lpc.c
+++ b/drivers/platform/chrome/cros_ec_lpc.c
@@ -214,7 +214,6 @@ static int cros_ec_lpc_probe(struct platform_device *pdev)
ec_dev-dev = dev;
ec_dev-ec_name = pdev-name;
ec_dev-phys_name = dev_name(dev);
- ec_dev-parent = dev;
ec_dev-cmd_xfer = cros_ec_cmd_xfer_lpc;
ec_dev-cmd_readmem = cros_ec_lpc_readmem;
diff --git a/include/linux/mfd/cros_ec.h b/include/linux/mfd/cros_ec.h
index 324a34683971..14cf522123dd 100644
--- a/include/linux/mfd/cros_ec.h
+++ b/include/linux/mfd/cros_ec.h
@@ -85,7 +85,6 @@ struct cros_ec_command {
* to using dword.
* @din_size: size of din buffer to allocate (zero to use static din)
* @dout_size: size of dout buffer to allocate (zero to use static dout)
- * @parent: pointer to parent device (e.g. i2c or spi device)
* @wake_enabled: true if this device can wake the system from sleep
* @cmd_xfer: send command to EC and get response
* Returns the number of bytes received if the communication succeeded,
but
@@ -113,7 +112,6 @@ struct cros_ec_device {
uint8_t *dout;
int din_size;
int dout_size;
- struct device *parent;
bool wake_enabled;
int (*cmd_xfer)(struct cros_ec_device *ec,
struct cros_ec_command *msg);
--
2.1.4
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
