Re: [RESUBMIT PATCH v6 7/8] regulator: sky81452: Add compatible string for device binding
On Mon, Nov 03, 2014 at 10:45:39PM +0100, Paul Bolle wrote: > On Fri, 2014-10-31 at 16:44 +, Mark Brown wrote: > > On Fri, Oct 31, 2014 at 04:08:41PM +0900, gyun...@gmail.com wrote: > > > From: Gyungoh Yoo > > > > > > Signed-off-by: Gyungoh Yoo > > > > This doesn't apply against current code and depends on the MFD symbol > > rename - can you please check what's going on here? > > > > It would make sense to split the Kconfig symbol rename into a separate > > patch to ease merging, > > The relicensing (from GPL to GPL v2, thus dropping the "or later" > provision) is odd too. The header still uses GPL v2 or later, doesn't > it? Anyhow, that could be a separate patch too. I will modify the licensing text and resubmit it. Thank you for your comment. > > > it doesn't seem obviously related to the driver > > change and should probably be in the same patch as the MFD symbol rename > > for bisetion. > > I don't think there will be bisection problems (in mainline). Currently > this driver depends on SKY81452. But that symbol doesn't exist. Only > after both 1/8 and this patch will this driver become buildable, for the > first time. So it's not that this driver was buildable, became > unbuildable in 1/8 and buildable again in this patch. > > (I don't think it's much of a problem that the regulator driver got > merged, in v3.18-rc1, before the mfd driver on which it depends. > Avoiding that temporarily problem appears to be more trouble than it's > worth.) > > > Paul Bolle > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [RESUBMIT PATCH v6 7/8] regulator: sky81452: Add compatible string for device binding
On Tue, Nov 04, 2014 at 11:41:20AM +, Mark Brown wrote: > On Tue, Nov 04, 2014 at 02:45:34PM +0900, Gyungoh Yoo wrote: > > On Tue, Nov 04, 2014 at 12:53:29AM +, Mark Brown wrote: > > > > I'm having a hard time understanding why it is difficult to split the > > > two changes - they are in completely separate files. > > > I am sorry for the hard time. > > > That was because the symbol changes had a dependency with 1/8. > > In this case, Should Kconfig symbol change back from MFD_SKY81452 > > to SKY81452 in this patch series? And then should I submit to change to > > MFD_SKY81452 > > with seperate patch? > > No, what I'm saying is that if you want to rename the Kconfig symbol you > should do that as part of a separate patch to changing the DT stuff. I see. I will split this patch. One is for DT stuff and the other is for Kconfig symbol rename. Thank you for your comment. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [RESUBMIT PATCH v6 7/8] regulator: sky81452: Add compatible string for device binding
On Tue, Nov 04, 2014 at 02:45:34PM +0900, Gyungoh Yoo wrote: > On Tue, Nov 04, 2014 at 12:53:29AM +, Mark Brown wrote: > > I'm having a hard time understanding why it is difficult to split the > > two changes - they are in completely separate files. > I am sorry for the hard time. > That was because the symbol changes had a dependency with 1/8. > In this case, Should Kconfig symbol change back from MFD_SKY81452 > to SKY81452 in this patch series? And then should I submit to change to > MFD_SKY81452 > with seperate patch? No, what I'm saying is that if you want to rename the Kconfig symbol you should do that as part of a separate patch to changing the DT stuff. signature.asc Description: Digital signature
Re: [RESUBMIT PATCH v6 7/8] regulator: sky81452: Add compatible string for device binding
On Tue, Nov 04, 2014 at 12:53:29AM +, Mark Brown wrote: > On Tue, Nov 04, 2014 at 09:43:34AM +0900, Gyungoh Yoo wrote: > > On Fri, Oct 31, 2014 at 04:44:18PM +, Mark Brown wrote: > > > > This doesn't apply against current code and depends on the MFD symbol > > > rename - can you please check what's going on here? > > > Are you talking about 'sky81452-regulator'? > > I am sorry I don't understand. Can you explain in more detail? > > No, I mean the Kconfig change. > > > > It would make sense to split the Kconfig symbol rename into a separate > > > patch to ease merging, it doesn't seem obviously related to the driver > > > change and should probably be in the same patch as the MFD symbol rename > > > for bisetion. > > > becuase the symbol in the modfied MFD does not match with the > > merged regulator driver, it was hard to split the patch. > > I'm having a hard time understanding why it is difficult to split the > two changes - they are in completely separate files. I am sorry for the hard time. That was because the symbol changes had a dependency with 1/8. In this case, Should Kconfig symbol change back from MFD_SKY81452 to SKY81452 in this patch series? And then should I submit to change to MFD_SKY81452 with seperate patch? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [RESUBMIT PATCH v6 7/8] regulator: sky81452: Add compatible string for device binding
On Mon, Nov 03, 2014 at 10:45:39PM +0100, Paul Bolle wrote: > On Fri, 2014-10-31 at 16:44 +, Mark Brown wrote: > > it doesn't seem obviously related to the driver > > change and should probably be in the same patch as the MFD symbol rename > > for bisetion. > I don't think there will be bisection problems (in mainline). Currently > this driver depends on SKY81452. But that symbol doesn't exist. Only > after both 1/8 and this patch will this driver become buildable, for the > first time. So it's not that this driver was buildable, became > unbuildable in 1/8 and buildable again in this patch. > (I don't think it's much of a problem that the regulator driver got > merged, in v3.18-rc1, before the mfd driver on which it depends. > Avoiding that temporarily problem appears to be more trouble than it's > worth.) The symbol rename should not be randomly shoved in with another patch, and if the MFD still hasn't been merged then it probably makes sense to do the rename as part of merging the MFD so it's clear what's going on. signature.asc Description: Digital signature
Re: [RESUBMIT PATCH v6 7/8] regulator: sky81452: Add compatible string for device binding
On Tue, Nov 04, 2014 at 09:43:34AM +0900, Gyungoh Yoo wrote: > On Fri, Oct 31, 2014 at 04:44:18PM +, Mark Brown wrote: > > This doesn't apply against current code and depends on the MFD symbol > > rename - can you please check what's going on here? > Are you talking about 'sky81452-regulator'? > I am sorry I don't understand. Can you explain in more detail? No, I mean the Kconfig change. > > It would make sense to split the Kconfig symbol rename into a separate > > patch to ease merging, it doesn't seem obviously related to the driver > > change and should probably be in the same patch as the MFD symbol rename > > for bisetion. > becuase the symbol in the modfied MFD does not match with the > merged regulator driver, it was hard to split the patch. I'm having a hard time understanding why it is difficult to split the two changes - they are in completely separate files. signature.asc Description: Digital signature
Re: [RESUBMIT PATCH v6 7/8] regulator: sky81452: Add compatible string for device binding
On Fri, Oct 31, 2014 at 04:44:18PM +, Mark Brown wrote: > On Fri, Oct 31, 2014 at 04:08:41PM +0900, gyun...@gmail.com wrote: > > From: Gyungoh Yoo > > > > Signed-off-by: Gyungoh Yoo > > This doesn't apply against current code and depends on the MFD symbol > rename - can you please check what's going on here? Are you talking about 'sky81452-regulator'? I am sorry I don't understand. Can you explain in more detail? > > It would make sense to split the Kconfig symbol rename into a separate > patch to ease merging, it doesn't seem obviously related to the driver > change and should probably be in the same patch as the MFD symbol rename > for bisetion. becuase the symbol in the modfied MFD does not match with the merged regulator driver, it was hard to split the patch. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [RESUBMIT PATCH v6 7/8] regulator: sky81452: Add compatible string for device binding
On Fri, 2014-10-31 at 16:44 +, Mark Brown wrote: > On Fri, Oct 31, 2014 at 04:08:41PM +0900, gyun...@gmail.com wrote: > > From: Gyungoh Yoo > > > > Signed-off-by: Gyungoh Yoo > > This doesn't apply against current code and depends on the MFD symbol > rename - can you please check what's going on here? > > It would make sense to split the Kconfig symbol rename into a separate > patch to ease merging, The relicensing (from GPL to GPL v2, thus dropping the "or later" provision) is odd too. The header still uses GPL v2 or later, doesn't it? Anyhow, that could be a separate patch too. > it doesn't seem obviously related to the driver > change and should probably be in the same patch as the MFD symbol rename > for bisetion. I don't think there will be bisection problems (in mainline). Currently this driver depends on SKY81452. But that symbol doesn't exist. Only after both 1/8 and this patch will this driver become buildable, for the first time. So it's not that this driver was buildable, became unbuildable in 1/8 and buildable again in this patch. (I don't think it's much of a problem that the regulator driver got merged, in v3.18-rc1, before the mfd driver on which it depends. Avoiding that temporarily problem appears to be more trouble than it's worth.) Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [RESUBMIT PATCH v6 7/8] regulator: sky81452: Add compatible string for device binding
On Fri, Oct 31, 2014 at 04:08:41PM +0900, gyun...@gmail.com wrote: > From: Gyungoh Yoo > > Signed-off-by: Gyungoh Yoo This doesn't apply against current code and depends on the MFD symbol rename - can you please check what's going on here? It would make sense to split the Kconfig symbol rename into a separate patch to ease merging, it doesn't seem obviously related to the driver change and should probably be in the same patch as the MFD symbol rename for bisetion. signature.asc Description: Digital signature
