Re: [RFC][PATCH 2/7] ACPI: Separate invocations of _GTS and _BFS from _PTS and _WAK
On Thursday, 3 of January 2008, Pavel Machek wrote: > On Thu 2007-12-27 19:15:16, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki <[EMAIL PROTECTED]> > > > > The execution of ACPI global control methods _GTS and _BFS is > > currently tied to the preparation to enter a sleep state and to the > > leaving of the sleep state, respectively. However, these functions > > are called before disabling the nonboot CPUs and after enabling > > them, respectively (in fact, on ACPI 1.0x systems the first of them > > ought to be called before suspending devices), while according to the > > ACPI specification, _GTS is to be executed right prior to entering > > the system sleep state and _BFS is to be executed right after the > > platfor firmware has returned control to the OS on wake up. > > > > Move the execution of _GTS and _BFS to the right places. > > > > Signed-off-by: Rafael J. Wysocki <[EMAIL PROTECTED]> > > Seems ok to me, but it is 2.6.25 material earliest, right? Sure, it is. [The patches are on top of 2.6.25 ones, btw. ;-)] Thanks, Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [RFC][PATCH 2/7] ACPI: Separate invocations of _GTS and _BFS from _PTS and _WAK
On Thu 2007-12-27 19:15:16, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki <[EMAIL PROTECTED]> > > The execution of ACPI global control methods _GTS and _BFS is > currently tied to the preparation to enter a sleep state and to the > leaving of the sleep state, respectively. However, these functions > are called before disabling the nonboot CPUs and after enabling > them, respectively (in fact, on ACPI 1.0x systems the first of them > ought to be called before suspending devices), while according to the > ACPI specification, _GTS is to be executed right prior to entering > the system sleep state and _BFS is to be executed right after the > platfor firmware has returned control to the OS on wake up. > > Move the execution of _GTS and _BFS to the right places. > > Signed-off-by: Rafael J. Wysocki <[EMAIL PROTECTED]> Seems ok to me, but it is 2.6.25 material earliest, right? -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [RFC][PATCH 2/7] ACPI: Separate invocations of _GTS and _BFS from _PTS and _WAK
On Thu 2007-12-27 19:15:16, Rafael J. Wysocki wrote: From: Rafael J. Wysocki [EMAIL PROTECTED] The execution of ACPI global control methods _GTS and _BFS is currently tied to the preparation to enter a sleep state and to the leaving of the sleep state, respectively. However, these functions are called before disabling the nonboot CPUs and after enabling them, respectively (in fact, on ACPI 1.0x systems the first of them ought to be called before suspending devices), while according to the ACPI specification, _GTS is to be executed right prior to entering the system sleep state and _BFS is to be executed right after the platfor firmware has returned control to the OS on wake up. Move the execution of _GTS and _BFS to the right places. Signed-off-by: Rafael J. Wysocki [EMAIL PROTECTED] Seems ok to me, but it is 2.6.25 material earliest, right? -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [RFC][PATCH 2/7] ACPI: Separate invocations of _GTS and _BFS from _PTS and _WAK
On Thursday, 3 of January 2008, Pavel Machek wrote: On Thu 2007-12-27 19:15:16, Rafael J. Wysocki wrote: From: Rafael J. Wysocki [EMAIL PROTECTED] The execution of ACPI global control methods _GTS and _BFS is currently tied to the preparation to enter a sleep state and to the leaving of the sleep state, respectively. However, these functions are called before disabling the nonboot CPUs and after enabling them, respectively (in fact, on ACPI 1.0x systems the first of them ought to be called before suspending devices), while according to the ACPI specification, _GTS is to be executed right prior to entering the system sleep state and _BFS is to be executed right after the platfor firmware has returned control to the OS on wake up. Move the execution of _GTS and _BFS to the right places. Signed-off-by: Rafael J. Wysocki [EMAIL PROTECTED] Seems ok to me, but it is 2.6.25 material earliest, right? Sure, it is. [The patches are on top of 2.6.25 ones, btw. ;-)] Thanks, Rafael -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
