Re: [RFC] Additional pad in struct stat(64)

2000-09-26 Thread Ralf Baechle

On Tue, Sep 26, 2000 at 09:37:30PM +0200, Christoph Hellwig wrote:

> I'd like to have st_flags added to struct stat64, so adding the actual
> feature in Linux 2.5 (if it has a chance to get in - that's why I'm
> interested in a comment by Linus on this) will not need a new version
> of struct stat (and a new  libc to use it), after just having introduced
> a new one in Linux 2.4.

MIPS already had this member of the struct, we recently removed it so no
piece of stupid software would autodetect this field that wasn't supported
in any way.  So restoring it back to live would be as simple as undoing
that patch.

  Ralf
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/



Re: [RFC] Additional pad in struct stat(64)

2000-09-26 Thread Ulrich Drepper

Christoph Hellwig <[EMAIL PROTECTED]> writes:

> I'd like to have st_flags added to struct stat64, so adding the actual
> feature in Linux 2.5 (if it has a chance to get in - that's why I'm
> interested in a comment by Linus on this) will not need a new version
> of struct stat (and a new  libc to use it),

It will need a new libc version anyway.

-- 
---.  ,-.   1325 Chesapeake Terrace
Ulrich Drepper  \,---'   \  Sunnyvale, CA 94089 USA
Red Hat  `--' drepper at redhat.com   `
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/



Re: [RFC] Additional pad in struct stat(64)

2000-09-26 Thread Christoph Hellwig

On Tue, Sep 26, 2000 at 12:15:49PM -0700, Ulrich Drepper wrote:
> Christoph Hellwig <[EMAIL PROTECTED]> writes:
> 
> > Hehe, that's why I'd like to introduce some additional pad with my
> > patch ;)
> 
> There is no reason to introduce now unnecessarily incompatibilities.
> If you want to look forward and add more padding do this when there is
> another change necessary.  Introducing breakage just to possibily
> avoid them in future is stupid.

Have you read the whole thread?
I'd like to have st_flags added to struct stat64, so adding the actual
feature in Linux 2.5 (if it has a chance to get in - that's why I'm
interested in a comment by Linus on this) will not need a new version
of struct stat (and a new  libc to use it), after just having introduced
a new one in Linux 2.4.
Adding some pad to have room for a few features (that will come ...)
makes sense IMHO.
I think planning a little bit in the future is not stupid.

Christoph

-- 
Always remember that you are unique.  Just like everyone else.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/



Re: [RFC] Additional pad in struct stat(64)

2000-09-26 Thread Ulrich Drepper

Christoph Hellwig <[EMAIL PROTECTED]> writes:

> Hehe, that's why I'd like to introduce some additional pad with my
> patch ;)

There is no reason to introduce now unnecessarily incompatibilities.
If you want to look forward and add more padding do this when there is
another change necessary.  Introducing breakage just to possibily
avoid them in future is stupid.

-- 
---.  ,-.   1325 Chesapeake Terrace
Ulrich Drepper  \,---'   \  Sunnyvale, CA 94089 USA
Red Hat  `--' drepper at redhat.com   `
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/



Re: [RFC] Additional pad in struct stat(64)

2000-09-26 Thread Ulrich Drepper

Christoph Hellwig [EMAIL PROTECTED] writes:

 Hehe, that's why I'd like to introduce some additional pad with my
 patch ;)

There is no reason to introduce now unnecessarily incompatibilities.
If you want to look forward and add more padding do this when there is
another change necessary.  Introducing breakage just to possibily
avoid them in future is stupid.

-- 
---.  ,-.   1325 Chesapeake Terrace
Ulrich Drepper  \,---'   \  Sunnyvale, CA 94089 USA
Red Hat  `--' drepper at redhat.com   `
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/



Re: [RFC] Additional pad in struct stat(64)

2000-09-26 Thread Ulrich Drepper

Christoph Hellwig [EMAIL PROTECTED] writes:

 I'd like to have st_flags added to struct stat64, so adding the actual
 feature in Linux 2.5 (if it has a chance to get in - that's why I'm
 interested in a comment by Linus on this) will not need a new version
 of struct stat (and a new  libc to use it),

It will need a new libc version anyway.

-- 
---.  ,-.   1325 Chesapeake Terrace
Ulrich Drepper  \,---'   \  Sunnyvale, CA 94089 USA
Red Hat  `--' drepper at redhat.com   `
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/



Re: [RFC] Additional pad in struct stat(64)

2000-09-26 Thread Ralf Baechle

On Tue, Sep 26, 2000 at 09:37:30PM +0200, Christoph Hellwig wrote:

 I'd like to have st_flags added to struct stat64, so adding the actual
 feature in Linux 2.5 (if it has a chance to get in - that's why I'm
 interested in a comment by Linus on this) will not need a new version
 of struct stat (and a new  libc to use it), after just having introduced
 a new one in Linux 2.4.

MIPS already had this member of the struct, we recently removed it so no
piece of stupid software would autodetect this field that wasn't supported
in any way.  So restoring it back to live would be as simple as undoing
that patch.

  Ralf
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/