Re: [RFC PATCH 1/5] dt-bindings: power: Add battery types
Hi Pavel, On Wed, Aug 2, 2017 at 1:43 PM, Pavel Machek wrote: > Hi! > >> Signed-off-by: Marek Belisko >> --- >> include/dt-bindings/power/power.h | 11 +++ >> 1 file changed, 11 insertions(+) >> create mode 100644 include/dt-bindings/power/power.h >> >> diff --git a/include/dt-bindings/power/power.h >> b/include/dt-bindings/power/power.h >> new file mode 100644 >> index 000..ea36d7f >> --- /dev/null >> +++ b/include/dt-bindings/power/power.h >> @@ -0,0 +1,11 @@ >> +#ifndef _DT_BINDINGS_POWER_H >> +#define _DT_BINDINGS_POWER_H >> + >> +#define POWER_SUPPLY_TECHNOLOGY_NiMH 1 >> +#define POWER_SUPPLY_TECHNOLOGY_LION 2 >> +#define POWER_SUPPLY_TECHNOLOGY_LIPO 3 >> +#define POWER_SUPPLY_TECHNOLOGY_LiFe 4 > > Actually I'd add comments here, such as "/* LiFePO4 */, because > otherwise it is a bit ambiguous. OK. > >> +#define POWER_SUPPLY_TECHNOLOGY_NiCd 5 >> +#define POWER_SUPPLY_TECHNOLOGY_LiMn 6 >> + >> +#endif /* _DT_BINDINGS_POWER_H */ > > The rest of series is ok, you can add > > Acked-by: Pavel Machek > > , but I guess someone would want a little more verbose changelogs. Yes I'll post final series with updated commit messages. Thanks. > > BTW what hardware are you working with? We have working it on gta04 board. Also after this will be merged we can drop custom battery driver for gta04 and use this generic (maybe also other drivers can reuse this one). > Pavel > -- > (english) http://www.livejournal.com/~pavelmachek > (cesky, pictures) > http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html BR, marek -- as simple and primitive as possible - Marek Belisko - OPEN-NANDRA Freelance Developer Ruska Nova Ves 219 | Presov, 08005 Slovak Republic Tel: +421 915 052 184 skype: marekwhite twitter: #opennandra web: http://open-nandra.com
Re: [RFC PATCH 1/5] dt-bindings: power: Add battery types
Hi! > Signed-off-by: Marek Belisko > --- > include/dt-bindings/power/power.h | 11 +++ > 1 file changed, 11 insertions(+) > create mode 100644 include/dt-bindings/power/power.h > > diff --git a/include/dt-bindings/power/power.h > b/include/dt-bindings/power/power.h > new file mode 100644 > index 000..ea36d7f > --- /dev/null > +++ b/include/dt-bindings/power/power.h > @@ -0,0 +1,11 @@ > +#ifndef _DT_BINDINGS_POWER_H > +#define _DT_BINDINGS_POWER_H > + > +#define POWER_SUPPLY_TECHNOLOGY_NiMH 1 > +#define POWER_SUPPLY_TECHNOLOGY_LION 2 > +#define POWER_SUPPLY_TECHNOLOGY_LIPO 3 > +#define POWER_SUPPLY_TECHNOLOGY_LiFe 4 Actually I'd add comments here, such as "/* LiFePO4 */, because otherwise it is a bit ambiguous. > +#define POWER_SUPPLY_TECHNOLOGY_NiCd 5 > +#define POWER_SUPPLY_TECHNOLOGY_LiMn 6 > + > +#endif /* _DT_BINDINGS_POWER_H */ The rest of series is ok, you can add Acked-by: Pavel Machek , but I guess someone would want a little more verbose changelogs. BTW what hardware are you working with? Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html signature.asc Description: Digital signature
Re: [RFC PATCH 1/5] dt-bindings: power: Add battery types
On Tue 2017-08-01 22:55:22, Marek Belisko wrote: > From: Marek Belisko > > Signed-off-by: Marek Belisko > --- > include/dt-bindings/power/power.h | 11 +++ > 1 file changed, 11 insertions(+) > create mode 100644 include/dt-bindings/power/power.h > > diff --git a/include/dt-bindings/power/power.h > b/include/dt-bindings/power/power.h > new file mode 100644 > index 000..ea36d7f > --- /dev/null > +++ b/include/dt-bindings/power/power.h > @@ -0,0 +1,11 @@ > +#ifndef _DT_BINDINGS_POWER_H > +#define _DT_BINDINGS_POWER_H > + > +#define POWER_SUPPLY_TECHNOLOGY_NiMH 1 > +#define POWER_SUPPLY_TECHNOLOGY_LION 2 Nice animal :-), but I guess this should be "LiION" or something. > +#define POWER_SUPPLY_TECHNOLOGY_LIPO 3 Make it "LiPo" for consistency. There's no differnce between Li-ion and Li-Po from the software side, AFAICT, but I guess we can keep both.. > +#define POWER_SUPPLY_TECHNOLOGY_LiFe 4 > +#define POWER_SUPPLY_TECHNOLOGY_NiCd 5 > +#define POWER_SUPPLY_TECHNOLOGY_LiMn 6 > + > +#endif /* _DT_BINDINGS_POWER_H */ Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html signature.asc Description: Digital signature
