Re: [Suspend-devel] [PATCH, 3rd try] make disable_console_suspend runtime configurable
On Thu, Jun 21, 2007 at 03:20:08PM +0200, Pavel Machek wrote: > Hi! > > No, i don't agree at all. > > > > In this case, "no config needed" == "not possible to debug suspend > > problems". > > No, sorry. > > My proposed solution is "figure out which console drivers can survive > being on while machines go down, and keep them on". > > So, "no config needed" == "kernel always does the right thing, keeping > console during suspend when possible" == "possible to debug suspend > problems without having to change CONFIG_ or /sys/*". Ok. Deal. Once you fixed all the console drivers, i'll gladly send a patch that reverts the patch we are discussing now. Note that this patch actually helps fixing those drivers, since you can test much easier if a given driver survives suspend ;-) -- Stefan Seyfried QA / R Team Mobile Devices| "Any ideas, John?" SUSE LINUX Products GmbH, Nürnberg | "Well, surrounding them's out." This footer brought to you by insane German lawmakers: SUSE Linux Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [Suspend-devel] [PATCH, 3rd try] make disable_console_suspend runtime configurable
Hi! > > > Sorry for not screaming when CONFIG_DISABLE_CONSOLE_SUSPEND went in, > > > but please lets solve this correctly > > > > Ouch and sorry for not screaming at "try 1" time. But it still does > > not make the patch right, and I believe that even patch authors agree > > that "no-config-needed" is superior solution. > > No, i don't agree at all. > > In this case, "no config needed" == "not possible to debug suspend > problems". No, sorry. My proposed solution is "figure out which console drivers can survive being on while machines go down, and keep them on". So, "no config needed" == "kernel always does the right thing, keeping console during suspend when possible" == "possible to debug suspend problems without having to change CONFIG_ or /sys/*". Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [Suspend-devel] [PATCH, 3rd try] make disable_console_suspend runtime configurable
Hi! Sorry for not screaming when CONFIG_DISABLE_CONSOLE_SUSPEND went in, but please lets solve this correctly Ouch and sorry for not screaming at try 1 time. But it still does not make the patch right, and I believe that even patch authors agree that no-config-needed is superior solution. No, i don't agree at all. In this case, no config needed == not possible to debug suspend problems. No, sorry. My proposed solution is figure out which console drivers can survive being on while machines go down, and keep them on. So, no config needed == kernel always does the right thing, keeping console during suspend when possible == possible to debug suspend problems without having to change CONFIG_ or /sys/*. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [Suspend-devel] [PATCH, 3rd try] make disable_console_suspend runtime configurable
On Thu, Jun 21, 2007 at 03:20:08PM +0200, Pavel Machek wrote: Hi! No, i don't agree at all. In this case, no config needed == not possible to debug suspend problems. No, sorry. My proposed solution is figure out which console drivers can survive being on while machines go down, and keep them on. So, no config needed == kernel always does the right thing, keeping console during suspend when possible == possible to debug suspend problems without having to change CONFIG_ or /sys/*. Ok. Deal. Once you fixed all the console drivers, i'll gladly send a patch that reverts the patch we are discussing now. Note that this patch actually helps fixing those drivers, since you can test much easier if a given driver survives suspend ;-) -- Stefan Seyfried QA / RD Team Mobile Devices| Any ideas, John? SUSE LINUX Products GmbH, Nürnberg | Well, surrounding them's out. This footer brought to you by insane German lawmakers: SUSE Linux Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [Suspend-devel] [PATCH, 3rd try] make disable_console_suspend runtime configurable
On Sun, Jun 17, 2007 at 11:49:40PM +0200, Pavel Machek wrote: > Hi! > > > > > I hate having to recompile the kernel, just to be able to debug suspend. > > > > Remove CONFIG_DISABLE_CONSOLE_SUSPEND, replace it by a tunable in > > > > /sys/power/disable_console_suspend. > > > > > > > > > > > > Signed-off-by: Stefan Seyfried <[EMAIL PROTECTED]> > > > > Signed-off-by: Frank Seidel <[EMAIL PROTECTED]> > > > > --- > > > > Third try, renamed sysfs interface to console_suspend > > > > reporting and expecting either "enabled" or "disabled" > > > > > > Thanks a lot for redoing it. > > > > > > I have no objections. Pavel? > > > > I still think that patch is bad. I should have screamed when > > CONFIG_DISABLE_CONSOLE_SUSPEND went into kernel. That beast should > > _not_ be configurable, it should just do the right thing. > > > > But I realized that too late. And this only makes it works, making > > that mistake part of user-kernel interface. > > > > Sorry for not screaming when CONFIG_DISABLE_CONSOLE_SUSPEND went in, > > but please lets solve this correctly > > Ouch and sorry for not screaming at "try 1" time. But it still does > not make the patch right, and I believe that even patch authors agree > that "no-config-needed" is superior solution. No, i don't agree at all. In this case, "no config needed" == "not possible to debug suspend problems". IMO this is the same as issue as with "sysrq-C". You can crash the machine by other means, but it sometimes is just handy to have a mechanism to do it. I do not understand what's the problem with this option. If you want to avoid that people use it for something else than debugging, i can add a patch that crashes the machine ten seconds after resume if this option is set. -- Stefan Seyfried QA / R Team Mobile Devices| "Any ideas, John?" SUSE LINUX Products GmbH, Nürnberg | "Well, surrounding them's out." This footer brought to you by insane German lawmakers: SUSE Linux Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [Suspend-devel] [PATCH, 3rd try] make disable_console_suspend runtime configurable
On Sun, Jun 17, 2007 at 11:49:40PM +0200, Pavel Machek wrote: Hi! I hate having to recompile the kernel, just to be able to debug suspend. Remove CONFIG_DISABLE_CONSOLE_SUSPEND, replace it by a tunable in /sys/power/disable_console_suspend. Signed-off-by: Stefan Seyfried [EMAIL PROTECTED] Signed-off-by: Frank Seidel [EMAIL PROTECTED] --- Third try, renamed sysfs interface to console_suspend reporting and expecting either enabled or disabled Thanks a lot for redoing it. I have no objections. Pavel? I still think that patch is bad. I should have screamed when CONFIG_DISABLE_CONSOLE_SUSPEND went into kernel. That beast should _not_ be configurable, it should just do the right thing. But I realized that too late. And this only makes it works, making that mistake part of user-kernel interface. Sorry for not screaming when CONFIG_DISABLE_CONSOLE_SUSPEND went in, but please lets solve this correctly Ouch and sorry for not screaming at try 1 time. But it still does not make the patch right, and I believe that even patch authors agree that no-config-needed is superior solution. No, i don't agree at all. In this case, no config needed == not possible to debug suspend problems. IMO this is the same as issue as with sysrq-C. You can crash the machine by other means, but it sometimes is just handy to have a mechanism to do it. I do not understand what's the problem with this option. If you want to avoid that people use it for something else than debugging, i can add a patch that crashes the machine ten seconds after resume if this option is set. -- Stefan Seyfried QA / RD Team Mobile Devices| Any ideas, John? SUSE LINUX Products GmbH, Nürnberg | Well, surrounding them's out. This footer brought to you by insane German lawmakers: SUSE Linux Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [Suspend-devel] [PATCH, 3rd try] make disable_console_suspend runtime configurable
Hi! > > > I hate having to recompile the kernel, just to be able to debug suspend. > > > Remove CONFIG_DISABLE_CONSOLE_SUSPEND, replace it by a tunable in > > > /sys/power/disable_console_suspend. > > > > > > > > > Signed-off-by: Stefan Seyfried <[EMAIL PROTECTED]> > > > Signed-off-by: Frank Seidel <[EMAIL PROTECTED]> > > > --- > > > Third try, renamed sysfs interface to console_suspend > > > reporting and expecting either "enabled" or "disabled" > > > > Thanks a lot for redoing it. > > > > I have no objections. Pavel? > > I still think that patch is bad. I should have screamed when > CONFIG_DISABLE_CONSOLE_SUSPEND went into kernel. That beast should > _not_ be configurable, it should just do the right thing. > > But I realized that too late. And this only makes it works, making > that mistake part of user-kernel interface. > > Sorry for not screaming when CONFIG_DISABLE_CONSOLE_SUSPEND went in, > but please lets solve this correctly Ouch and sorry for not screaming at "try 1" time. But it still does not make the patch right, and I believe that even patch authors agree that "no-config-needed" is superior solution. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [Suspend-devel] [PATCH, 3rd try] make disable_console_suspend runtime configurable
Hi! I hate having to recompile the kernel, just to be able to debug suspend. Remove CONFIG_DISABLE_CONSOLE_SUSPEND, replace it by a tunable in /sys/power/disable_console_suspend. Signed-off-by: Stefan Seyfried [EMAIL PROTECTED] Signed-off-by: Frank Seidel [EMAIL PROTECTED] --- Third try, renamed sysfs interface to console_suspend reporting and expecting either enabled or disabled Thanks a lot for redoing it. I have no objections. Pavel? I still think that patch is bad. I should have screamed when CONFIG_DISABLE_CONSOLE_SUSPEND went into kernel. That beast should _not_ be configurable, it should just do the right thing. But I realized that too late. And this only makes it works, making that mistake part of user-kernel interface. Sorry for not screaming when CONFIG_DISABLE_CONSOLE_SUSPEND went in, but please lets solve this correctly Ouch and sorry for not screaming at try 1 time. But it still does not make the patch right, and I believe that even patch authors agree that no-config-needed is superior solution. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
