RE: [char-misc-next 01/11] mei: bus: Initial MEI bus type implementation
> -Original Message-
> From: Samuel Ortiz [mailto:sa...@linux.intel.com]
> Sent: Friday, February 08, 2013 00:59
> To: Arnd Bergmann
> Cc: Winkler, Tomas; gre...@linuxfoundation.org; linux-
> ker...@vger.kernel.org
> Subject: Re: [char-misc-next 01/11] mei: bus: Initial MEI bus type
> implementation
>
> On Thu, Feb 07, 2013 at 10:41:06PM +, Arnd Bergmann wrote:
> > On Thursday 07 February 2013, Tomas Winkler wrote:
> > > +}
> > > +EXPORT_SYMBOL(mei_add_device);
> > > +
> > > +void mei_remove_device(struct mei_bus_client *client) {
> > > + device_unregister(>dev); }
> > > +EXPORT_SYMBOL(mei_remove_device);
> >
> > One more point: did you intentionally pick EXPORT_SYMBOL over
> > EXPORT_SYMBOL_GPL here?
> No, I didn't.
>
> > It is your decision as the copyright
> > holder, but the default is often EXPORT_SYMBOL_GPL these days, to make
> > it clear that you don't expect closed source drivers to plug in there.
> I'll fix that if Tomas is ok with it.
So far I'm happy with not forcing GPL, but I will check that issue.
Thanks
Tomas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [char-misc-next 01/11] mei: bus: Initial MEI bus type implementation
On Thu, Feb 07, 2013 at 10:41:06PM +, Arnd Bergmann wrote:
> On Thursday 07 February 2013, Tomas Winkler wrote:
> > +}
> > +EXPORT_SYMBOL(mei_add_device);
> > +
> > +void mei_remove_device(struct mei_bus_client *client)
> > +{
> > + device_unregister(>dev);
> > +}
> > +EXPORT_SYMBOL(mei_remove_device);
>
> One more point: did you intentionally pick EXPORT_SYMBOL over
> EXPORT_SYMBOL_GPL here?
No, I didn't.
> It is your decision as the copyright
> holder, but the default is often EXPORT_SYMBOL_GPL these
> days, to make it clear that you don't expect closed source
> drivers to plug in there.
I'll fix that if Tomas is ok with it.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [char-misc-next 01/11] mei: bus: Initial MEI bus type implementation
On Thursday 07 February 2013, Tomas Winkler wrote:
> +}
> +EXPORT_SYMBOL(mei_add_device);
> +
> +void mei_remove_device(struct mei_bus_client *client)
> +{
> + device_unregister(>dev);
> +}
> +EXPORT_SYMBOL(mei_remove_device);
One more point: did you intentionally pick EXPORT_SYMBOL over
EXPORT_SYMBOL_GPL here? It is your decision as the copyright
holder, but the default is often EXPORT_SYMBOL_GPL these
days, to make it clear that you don't expect closed source
drivers to plug in there.
Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [char-misc-next 01/11] mei: bus: Initial MEI bus type implementation
On Thursday 07 February 2013, Tomas Winkler wrote: > From: Samuel Ortiz > > mei bus will present some of the me clients > as devices for other standard subsystems > > Implement the probe, remove, match and the device addtion routines. > A mei-bus.txt document describing the rationale and the API usage > is also added. This looks really nice, but I also think you have reached the point where you are outgrowing the scope of drivers/misc. How about turning mei into a top-level subsystem along with this new bus_type? Another option would be moving it to drivers/bus/mei/ if you don't want to be quite at the top. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [char-misc-next 01/11] mei: bus: Initial MEI bus type implementation
On Thursday 07 February 2013, Tomas Winkler wrote: From: Samuel Ortiz sa...@linux.intel.com mei bus will present some of the me clients as devices for other standard subsystems Implement the probe, remove, match and the device addtion routines. A mei-bus.txt document describing the rationale and the API usage is also added. This looks really nice, but I also think you have reached the point where you are outgrowing the scope of drivers/misc. How about turning mei into a top-level subsystem along with this new bus_type? Another option would be moving it to drivers/bus/mei/ if you don't want to be quite at the top. Arnd -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [char-misc-next 01/11] mei: bus: Initial MEI bus type implementation
On Thursday 07 February 2013, Tomas Winkler wrote:
+}
+EXPORT_SYMBOL(mei_add_device);
+
+void mei_remove_device(struct mei_bus_client *client)
+{
+ device_unregister(client-dev);
+}
+EXPORT_SYMBOL(mei_remove_device);
One more point: did you intentionally pick EXPORT_SYMBOL over
EXPORT_SYMBOL_GPL here? It is your decision as the copyright
holder, but the default is often EXPORT_SYMBOL_GPL these
days, to make it clear that you don't expect closed source
drivers to plug in there.
Arnd
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [char-misc-next 01/11] mei: bus: Initial MEI bus type implementation
On Thu, Feb 07, 2013 at 10:41:06PM +, Arnd Bergmann wrote:
On Thursday 07 February 2013, Tomas Winkler wrote:
+}
+EXPORT_SYMBOL(mei_add_device);
+
+void mei_remove_device(struct mei_bus_client *client)
+{
+ device_unregister(client-dev);
+}
+EXPORT_SYMBOL(mei_remove_device);
One more point: did you intentionally pick EXPORT_SYMBOL over
EXPORT_SYMBOL_GPL here?
No, I didn't.
It is your decision as the copyright
holder, but the default is often EXPORT_SYMBOL_GPL these
days, to make it clear that you don't expect closed source
drivers to plug in there.
I'll fix that if Tomas is ok with it.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
RE: [char-misc-next 01/11] mei: bus: Initial MEI bus type implementation
-Original Message-
From: Samuel Ortiz [mailto:sa...@linux.intel.com]
Sent: Friday, February 08, 2013 00:59
To: Arnd Bergmann
Cc: Winkler, Tomas; gre...@linuxfoundation.org; linux-
ker...@vger.kernel.org
Subject: Re: [char-misc-next 01/11] mei: bus: Initial MEI bus type
implementation
On Thu, Feb 07, 2013 at 10:41:06PM +, Arnd Bergmann wrote:
On Thursday 07 February 2013, Tomas Winkler wrote:
+}
+EXPORT_SYMBOL(mei_add_device);
+
+void mei_remove_device(struct mei_bus_client *client) {
+ device_unregister(client-dev); }
+EXPORT_SYMBOL(mei_remove_device);
One more point: did you intentionally pick EXPORT_SYMBOL over
EXPORT_SYMBOL_GPL here?
No, I didn't.
It is your decision as the copyright
holder, but the default is often EXPORT_SYMBOL_GPL these days, to make
it clear that you don't expect closed source drivers to plug in there.
I'll fix that if Tomas is ok with it.
So far I'm happy with not forcing GPL, but I will check that issue.
Thanks
Tomas
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
