Re: Re: [patch 1/2] show being-loaded/being-unloaded indicator for modules

2008-01-07 Thread Valdis . Kletnieks
On Mon, 07 Jan 2008 11:09:23 +0100, [EMAIL PROTECTED] said:

> but i wonder if some mandatory "print a message on init/exit

With a 'printk(LOG_DEBUG,...' please.  Boot with initcall_debug sometime to
see why. ;)


pgp3sopHFUC1M.pgp
Description: PGP signature


Re: [patch 1/2] show being-loaded/being-unloaded indicator for modules

2008-01-07 Thread Rusty Russell
On Tuesday 08 January 2008 01:21:16 Arjan van de Ven wrote:
> On Mon, 07 Jan 2008 11:09:23 +0100
>
> [EMAIL PROTECTED] wrote:
> > this looks very useful!
> >
> > >Unfortunatly, it's not always easy to see directly
> > >which module is being loaded/unloaded from the oops itself.
> >
> > no wonder, as most modules seem to be very quiet on on load/unload.
> >
> >
> >
> >
> > but i wonder if some mandatory "print a message on init/exit"
> > wouldn`t give a benefit to admins or end-users, too. sure this would
> > additionally clutter up syslog, but it would add transparency.
>
> Regardless of the usefulness, really, if this would be mandatory for all
> modules, it should be done in the module loader itself
> But I'm not entirely convinced how useful that is to do always, although I
> can see the point of having it as debug option, similar to the initcall
> debug stuff...

We could overload initcall_debug for this if we wanted to be consistant.  But 
I'm just not sure it'd be clear when to turn it on...

Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [patch 1/2] show being-loaded/being-unloaded indicator for modules

2008-01-07 Thread Arjan van de Ven
On Mon, 07 Jan 2008 11:09:23 +0100
[EMAIL PROTECTED] wrote:

> this looks very useful!
> 
> >Unfortunatly, it's not always easy to see directly
> >which module is being loaded/unloaded from the oops itself.
> 
> no wonder, as most modules seem to be very quiet on on load/unload.
> 


> 
> but i wonder if some mandatory "print a message on init/exit"
> wouldn`t give a benefit to admins or end-users, too. sure this would
> additionally clutter up syslog, but it would add transparency.

Regardless of the usefulness, really, if this would be mandatory for all 
modules, it should
be done in the module loader itself 
But I'm not entirely convinced how useful that is to do always, although I can 
see the 
point of having it as debug option, similar to the initcall debug stuff...


-- 
If you want to reach me at my work email, use [EMAIL PROTECTED]
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [patch 1/2] show being-loaded/being-unloaded indicator for modules

2008-01-07 Thread Arjan van de Ven
On Mon, 07 Jan 2008 11:09:23 +0100
[EMAIL PROTECTED] wrote:

 this looks very useful!
 
 Unfortunatly, it's not always easy to see directly
 which module is being loaded/unloaded from the oops itself.
 
 no wonder, as most modules seem to be very quiet on on load/unload.
 


 
 but i wonder if some mandatory print a message on init/exit
 wouldn`t give a benefit to admins or end-users, too. sure this would
 additionally clutter up syslog, but it would add transparency.

Regardless of the usefulness, really, if this would be mandatory for all 
modules, it should
be done in the module loader itself 
But I'm not entirely convinced how useful that is to do always, although I can 
see the 
point of having it as debug option, similar to the initcall debug stuff...


-- 
If you want to reach me at my work email, use [EMAIL PROTECTED]
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [patch 1/2] show being-loaded/being-unloaded indicator for modules

2008-01-07 Thread Rusty Russell
On Tuesday 08 January 2008 01:21:16 Arjan van de Ven wrote:
 On Mon, 07 Jan 2008 11:09:23 +0100

 [EMAIL PROTECTED] wrote:
  this looks very useful!
 
  Unfortunatly, it's not always easy to see directly
  which module is being loaded/unloaded from the oops itself.
 
  no wonder, as most modules seem to be very quiet on on load/unload.
 
 
 
 
  but i wonder if some mandatory print a message on init/exit
  wouldn`t give a benefit to admins or end-users, too. sure this would
  additionally clutter up syslog, but it would add transparency.

 Regardless of the usefulness, really, if this would be mandatory for all
 modules, it should be done in the module loader itself
 But I'm not entirely convinced how useful that is to do always, although I
 can see the point of having it as debug option, similar to the initcall
 debug stuff...

We could overload initcall_debug for this if we wanted to be consistant.  But 
I'm just not sure it'd be clear when to turn it on...

Rusty.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: Re: [patch 1/2] show being-loaded/being-unloaded indicator for modules

2008-01-07 Thread Valdis . Kletnieks
On Mon, 07 Jan 2008 11:09:23 +0100, [EMAIL PROTECTED] said:

 but i wonder if some mandatory print a message on init/exit

With a 'printk(LOG_DEBUG,...' please.  Boot with initcall_debug sometime to
see why. ;)


pgp3sopHFUC1M.pgp
Description: PGP signature


Re: [patch 1/2] show being-loaded/being-unloaded indicator for modules in oopses

2008-01-06 Thread Rusty Russell
On Monday 07 January 2008 10:18:50 Arjan van de Ven wrote:
> Subject: show being-loaded/being-unloaded indicator for modules in oopses
> From: Arjan van de Ven <[EMAIL PROTECTED]>
> CC: [EMAIL PROTECTED]
> CC: [EMAIL PROTECTED]
> CC: [EMAIL PROTECTED]
>
> It's rather common that an oops/WARN_ON/BUG happens during the load or
> unload of a module. Unfortunatly, it's not always easy to see directly
> which module is being loaded/unloaded from the oops itself. Worse,
> it's not even always possible to ask the bug reporter, since there
> are so many components (udev etc) that auto-load modules that there's
> a good chance that even the reporter doesn't know which module this is.

Excellent, applied.

Thanks Arjan!
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [patch 1/2] show being-loaded/being-unloaded indicator for modules in oopses

2008-01-06 Thread Rusty Russell
On Monday 07 January 2008 10:18:50 Arjan van de Ven wrote:
 Subject: show being-loaded/being-unloaded indicator for modules in oopses
 From: Arjan van de Ven [EMAIL PROTECTED]
 CC: [EMAIL PROTECTED]
 CC: [EMAIL PROTECTED]
 CC: [EMAIL PROTECTED]

 It's rather common that an oops/WARN_ON/BUG happens during the load or
 unload of a module. Unfortunatly, it's not always easy to see directly
 which module is being loaded/unloaded from the oops itself. Worse,
 it's not even always possible to ask the bug reporter, since there
 are so many components (udev etc) that auto-load modules that there's
 a good chance that even the reporter doesn't know which module this is.

Excellent, applied.

Thanks Arjan!
Rusty.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/