Re: [patch 24/26] Xen-paravirt_ops: Add the Xenbus sysfs and virtual device hotplug driver.
On Fri, Mar 16, 2007 at 09:40:23AM -0700, Chris Wright wrote: > * Ingo Molnar ([EMAIL PROTECTED]) wrote: > > please indicate any such review feedback (and approval) via > > signed-off-by lines done by that person. > > Certainly, Greg didn't sign off, he simply gave review feedback. Yeah, I did that a while ago, but I don't want to give my acked-by or signed-off for this code. While I can not find anything specfically wrong with it, it seems a bit "odd", but that might just be because I really don't understand what they are doing here, or why. And no, I really don't want to understand it either at the moment due to being busy with other things :) thanks, greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [patch 24/26] Xen-paravirt_ops: Add the Xenbus sysfs and virtual device hotplug driver.
Ingo Molnar wrote: > * Jeremy Fitzhardinge <[EMAIL PROTECTED]> wrote: > > >> This communicates with the machine control software via a registry >> residing in a controlling virtual machine. This allows dynamic >> creation, destruction and modification of virtual device >> configurations (network devices, block devices and CPUS, to name some >> examples). >> > > should be reviewed by the driver-core folks too i guess? > > >> +//#include >> > > >> +//#include >> +//#include >> > > >> +//#include >> > > >> +// .shutdown = xenbus_dev_shutdown, >> > > hm? > Yeah, gunk. I'll clean that out. J - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [patch 24/26] Xen-paravirt_ops: Add the Xenbus sysfs and virtual device hotplug driver.
* Ingo Molnar ([EMAIL PROTECTED]) wrote: > please indicate any such review feedback (and approval) via > signed-off-by lines done by that person. Certainly, Greg didn't sign off, he simply gave review feedback. thanks, -chris - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [patch 24/26] Xen-paravirt_ops: Add the Xenbus sysfs and virtual device hotplug driver.
* Chris Wright <[EMAIL PROTECTED]> wrote: > * Ingo Molnar ([EMAIL PROTECTED]) wrote: > > > > * Jeremy Fitzhardinge <[EMAIL PROTECTED]> wrote: > > > > > This communicates with the machine control software via a registry > > > residing in a controlling virtual machine. This allows dynamic > > > creation, destruction and modification of virtual device > > > configurations (network devices, block devices and CPUS, to name some > > > examples). > > > > should be reviewed by the driver-core folks too i guess? > > Greg has gone through it a couple times. Any more feedback would be > useful. please indicate any such review feedback (and approval) via signed-off-by lines done by that person. Ingo - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [patch 24/26] Xen-paravirt_ops: Add the Xenbus sysfs and virtual device hotplug driver.
* Ingo Molnar ([EMAIL PROTECTED]) wrote: > > * Jeremy Fitzhardinge <[EMAIL PROTECTED]> wrote: > > > This communicates with the machine control software via a registry > > residing in a controlling virtual machine. This allows dynamic > > creation, destruction and modification of virtual device > > configurations (network devices, block devices and CPUS, to name some > > examples). > > should be reviewed by the driver-core folks too i guess? Greg has gone through it a couple times. Any more feedback would be useful. > > +//#include > > > +//#include > > +//#include > > > +//#include > > > +// .shutdown = xenbus_dev_shutdown, > > hm? fixing that up, not sure where that snuck in. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [patch 24/26] Xen-paravirt_ops: Add the Xenbus sysfs and virtual device hotplug driver.
* Jeremy Fitzhardinge <[EMAIL PROTECTED]> wrote: > This communicates with the machine control software via a registry > residing in a controlling virtual machine. This allows dynamic > creation, destruction and modification of virtual device > configurations (network devices, block devices and CPUS, to name some > examples). should be reviewed by the driver-core folks too i guess? > +//#include > +//#include > +//#include > +//#include > +// .shutdown = xenbus_dev_shutdown, hm? Ingo - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [patch 24/26] Xen-paravirt_ops: Add the Xenbus sysfs and virtual device hotplug driver.
* Jeremy Fitzhardinge [EMAIL PROTECTED] wrote: This communicates with the machine control software via a registry residing in a controlling virtual machine. This allows dynamic creation, destruction and modification of virtual device configurations (network devices, block devices and CPUS, to name some examples). should be reviewed by the driver-core folks too i guess? +//#include asm/maddr.h +//#include xen/xen_proc.h +//#include xen/evtchn.h +//#include xen/hvm.h +// .shutdown = xenbus_dev_shutdown, hm? Ingo - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [patch 24/26] Xen-paravirt_ops: Add the Xenbus sysfs and virtual device hotplug driver.
* Ingo Molnar ([EMAIL PROTECTED]) wrote: * Jeremy Fitzhardinge [EMAIL PROTECTED] wrote: This communicates with the machine control software via a registry residing in a controlling virtual machine. This allows dynamic creation, destruction and modification of virtual device configurations (network devices, block devices and CPUS, to name some examples). should be reviewed by the driver-core folks too i guess? Greg has gone through it a couple times. Any more feedback would be useful. +//#include asm/maddr.h +//#include xen/xen_proc.h +//#include xen/evtchn.h +//#include xen/hvm.h +// .shutdown = xenbus_dev_shutdown, hm? fixing that up, not sure where that snuck in. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [patch 24/26] Xen-paravirt_ops: Add the Xenbus sysfs and virtual device hotplug driver.
* Chris Wright [EMAIL PROTECTED] wrote: * Ingo Molnar ([EMAIL PROTECTED]) wrote: * Jeremy Fitzhardinge [EMAIL PROTECTED] wrote: This communicates with the machine control software via a registry residing in a controlling virtual machine. This allows dynamic creation, destruction and modification of virtual device configurations (network devices, block devices and CPUS, to name some examples). should be reviewed by the driver-core folks too i guess? Greg has gone through it a couple times. Any more feedback would be useful. please indicate any such review feedback (and approval) via signed-off-by lines done by that person. Ingo - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [patch 24/26] Xen-paravirt_ops: Add the Xenbus sysfs and virtual device hotplug driver.
* Ingo Molnar ([EMAIL PROTECTED]) wrote: please indicate any such review feedback (and approval) via signed-off-by lines done by that person. Certainly, Greg didn't sign off, he simply gave review feedback. thanks, -chris - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [patch 24/26] Xen-paravirt_ops: Add the Xenbus sysfs and virtual device hotplug driver.
Ingo Molnar wrote: * Jeremy Fitzhardinge [EMAIL PROTECTED] wrote: This communicates with the machine control software via a registry residing in a controlling virtual machine. This allows dynamic creation, destruction and modification of virtual device configurations (network devices, block devices and CPUS, to name some examples). should be reviewed by the driver-core folks too i guess? +//#include asm/maddr.h +//#include xen/xen_proc.h +//#include xen/evtchn.h +//#include xen/hvm.h +// .shutdown = xenbus_dev_shutdown, hm? Yeah, gunk. I'll clean that out. J - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [patch 24/26] Xen-paravirt_ops: Add the Xenbus sysfs and virtual device hotplug driver.
On Fri, Mar 16, 2007 at 09:40:23AM -0700, Chris Wright wrote: * Ingo Molnar ([EMAIL PROTECTED]) wrote: please indicate any such review feedback (and approval) via signed-off-by lines done by that person. Certainly, Greg didn't sign off, he simply gave review feedback. Yeah, I did that a while ago, but I don't want to give my acked-by or signed-off for this code. While I can not find anything specfically wrong with it, it seems a bit odd, but that might just be because I really don't understand what they are doing here, or why. And no, I really don't want to understand it either at the moment due to being busy with other things :) thanks, greg k-h - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
