Re: [tip:sched/core 23/23] kernel/sched/topology.c:17:2: error: 'sched_debug_verbose' undeclared; did you mean 'sched_debug_setup'?
On Sat, Apr 17, 2021 at 11:06:28AM +0200, Borislav Petkov wrote: > On Sat, Apr 17, 2021 at 02:47:46PM +0800, kernel test robot wrote: > >kernel/sched/topology.c: In function 'sched_debug_setup': > > >> kernel/sched/topology.c:17:2: error: 'sched_debug_verbose' undeclared > > >> (first use in this function); did you mean 'sched_debug_setup'? > > 17 | sched_debug_verbose = true; > > I guess it needs this: > > --- > diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h > index 55232db745ac..916bb96ff9a6 100644 > --- a/kernel/sched/sched.h > +++ b/kernel/sched/sched.h > @@ -2364,6 +2364,7 @@ extern struct sched_entity *__pick_last_entity(struct > cfs_rq *cfs_rq); > > #ifdef CONFIG_SCHED_DEBUG > extern bool sched_debug_enabled; > +extern bool sched_debug_verbose; > > extern void print_cfs_stats(struct seq_file *m, int cpu); > extern void print_rt_stats(struct seq_file *m, int cpu); > Right, sorry for messing that up. Pushed out that commit with this folded. If it gives any more trouble just kill the commit, it's the topmost commit anyway.
Re: [tip:sched/core 23/23] kernel/sched/topology.c:17:2: error: 'sched_debug_verbose' undeclared; did you mean 'sched_debug_setup'?
On Sat, Apr 17, 2021 at 02:47:46PM +0800, kernel test robot wrote: >kernel/sched/topology.c: In function 'sched_debug_setup': > >> kernel/sched/topology.c:17:2: error: 'sched_debug_verbose' undeclared > >> (first use in this function); did you mean 'sched_debug_setup'? > 17 | sched_debug_verbose = true; I guess it needs this: --- diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h index 55232db745ac..916bb96ff9a6 100644 --- a/kernel/sched/sched.h +++ b/kernel/sched/sched.h @@ -2364,6 +2364,7 @@ extern struct sched_entity *__pick_last_entity(struct cfs_rq *cfs_rq); #ifdef CONFIG_SCHED_DEBUG extern bool sched_debug_enabled; +extern bool sched_debug_verbose; extern void print_cfs_stats(struct seq_file *m, int cpu); extern void print_rt_stats(struct seq_file *m, int cpu); -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette