Re: `pci_apply_final_quirks()` taking half a second

2018-01-01 Thread Alan Stern 
On Mon, 1 Jan 2018, Paul Menzel wrote:

> > So they are OHCI controllers.  You could add some debugging statements
> > to quirk_usb_handoff_ohci() to try and locate the part that's taking so
> > long.
> 
> As you suggested debugging statements, I guess the Linux kernel doesn’t 
> offer other ways to instrument functions without modifying the source code.

It does.  Look into ftrace, for example.  However, ftrace only provides
tracing at the level of function calls (hence the name -- "ftrace" for
"function trace"), not for individual statements within a function.  
There are other facilities as well, but none of them are likely to help 
here.

> Is it possible to only rebuild the module somehow or is the early 
> handoff stuff not a module?

It is not a module.

> > It's also worth mentioning that the same source file contains lots of
> > special-case code for AMD and ASmedia hardware.  I don't know whether
> > any of it is involved in the long time delays you are seeing, however.
> 
> Thank you for already looking into this. I haven’t had to time to read 
> the commit messages, which might shed some light into the reasoning.

Good luck!

Alan Stern

Re: `pci_apply_final_quirks()` taking half a second

2018-01-01 Thread Paul Menzel 

Dear Alan,


First, please note, that your mailer (MUA) doesn’t set the references 
header, which breaks threading for people not having their own answers 
in the inbox.


Am 31.12.2017 um 22:16 schrieb Alan Stern:

On Sun, 31 Dec 2017, Paul Menzel wrote:


Am 29.12.2017 um 17:14 schrieb Alan Stern:

On Thu, 28 Dec 2017, Bjorn Helgaas wrote:


On Tue, Dec 26, 2017 at 04:55:20PM +0100, Paul Menzel wrote:

Am 08.04.2017 um 17:41 schrieb Bjorn Helgaas:

On Fri, Apr 07, 2017 at 11:07:15PM +0200, Paul Menzel wrote:



Measuring where time is spent during boot with `systemd-bootchart`
on an Asus A780FullHD, it turns out that half a second is spent in
`pci_apply_final_quirks()`.


I agree, that seems like a crazy amount of time.

Can you figure out how to turn on pr_debug() (via the dynamic debug
mess or whatever) and boot with "initcall_debug"?  That should tell us
how long each quirk took.


I am sorry for taking so long to reply. I finally added `dyndbg=file
quirks.c +p` to the command line of Linux 4.13.13. This is on
another AMD system (Asus F285M Pro).



Dez 26 16:21:46 asus-f2a85-pro kernel: pci fixup
quirk_usb_early_handoff+0x0/0x6b0 returned after 88643 usecs for
:00:12.0



Dez 26 16:21:46 asus-f2a85-pro kernel: pci fixup
quirk_usb_early_handoff+0x0/0x6b0 returned after 85770 usecs for
:00:13.0



So it’s `pci fixup quirk_usb_early_handoff` taking around 85 ms, and
that twice.


Wow.  That's pretty painful, but of course I don't know how to fix it.
  From looking at quirk_usb_early_handoff(), it may depend on BIOS
details.  Maybe the USB folks will have some ideas.


Can we see the output from lspci?  It would help to know what the 12.0
and 13.0 devices are.


Sorry, that was trimmed from the original message. Here is the output
from the ASRock A780FullD.


```
$ more /proc/version
Linux version 4.9.0-0.bpo.2-amd64 (debian-ker...@lists.debian.org)
(gcc version 4.9.2 (Debian 4.9.2-10) ) #1 SMP Debian 4.9.13-1~bpo8+1 
(2017-02-27)
$ lspci -nn



00:12.0 USB controller [0c03]: Advanced Micro Devices, Inc. [AMD/ATI] 
SB7x0/SB8x0/SB9x0 USB OHCI0 Controller [1002:4397]
00:12.1 USB controller [0c03]: Advanced Micro Devices, Inc. [AMD/ATI] SB7x0 USB 
OHCI1 Controller [1002:4398]
00:12.2 USB controller [0c03]: Advanced Micro Devices, Inc. [AMD/ATI] 
SB7x0/SB8x0/SB9x0 USB EHCI Controller [1002:4396]
00:13.0 USB controller [0c03]: Advanced Micro Devices, Inc. [AMD/ATI] 
SB7x0/SB8x0/SB9x0 USB OHCI0 Controller [1002:4397]
00:13.1 USB controller [0c03]: Advanced Micro Devices, Inc. [AMD/ATI] SB7x0 USB 
OHCI1 Controller [1002:4398]
00:13.2 USB controller [0c03]: Advanced Micro Devices, Inc. [AMD/ATI] 
SB7x0/SB8x0/SB9x0 USB EHCI Controller [1002:4396]



So far, this can be reproduce on all AMD systems I have (ASRock
A780FullHD, ASRock E350M1, Asus F2A85-M Pro).


So they are OHCI controllers.  You could add some debugging statements
to quirk_usb_handoff_ohci() to try and locate the part that's taking so
long.


As you suggested debugging statements, I guess the Linux kernel doesn’t 
offer other ways to instrument functions without modifying the source code.


Is it possible to only rebuild the module somehow or is the early 
handoff stuff not a module?



It's also worth mentioning that the same source file contains lots of
special-case code for AMD and ASmedia hardware.  I don't know whether
any of it is involved in the long time delays you are seeing, however.


Thank you for already looking into this. I haven’t had to time to read 
the commit messages, which might shed some light into the reasoning.



Kind regards,

Paul

Re: `pci_apply_final_quirks()` taking half a second

2017-12-31 Thread Alan Stern 
On Sun, 31 Dec 2017, Paul Menzel wrote:

> Am 29.12.2017 um 17:14 schrieb Alan Stern:
> > On Thu, 28 Dec 2017, Bjorn Helgaas wrote:
> > 
> >> On Tue, Dec 26, 2017 at 04:55:20PM +0100, Paul Menzel wrote:
> >>> Am 08.04.2017 um 17:41 schrieb Bjorn Helgaas:
>  On Fri, Apr 07, 2017 at 11:07:15PM +0200, Paul Menzel wrote:
> >>>
> > Measuring where time is spent during boot with `systemd-bootchart`
> > on an Asus A780FullHD, it turns out that half a second is spent in
> > `pci_apply_final_quirks()`.
> 
>  I agree, that seems like a crazy amount of time.
> 
>  Can you figure out how to turn on pr_debug() (via the dynamic debug
>  mess or whatever) and boot with "initcall_debug"?  That should tell us
>  how long each quirk took.
> >>>
> >>> I am sorry for taking so long to reply. I finally added `dyndbg=file
> >>> quirks.c +p` to the command line of Linux 4.13.13. This is on
> >>> another AMD system (Asus F285M Pro).

> >>> Dez 26 16:21:46 asus-f2a85-pro kernel: pci fixup
> >>> quirk_usb_early_handoff+0x0/0x6b0 returned after 88643 usecs for
> >>> :00:12.0

> >>> Dez 26 16:21:46 asus-f2a85-pro kernel: pci fixup
> >>> quirk_usb_early_handoff+0x0/0x6b0 returned after 85770 usecs for
> >>> :00:13.0

> >>> So it’s `pci fixup quirk_usb_early_handoff` taking around 85 ms, and
> >>> that twice.
> >>
> >> Wow.  That's pretty painful, but of course I don't know how to fix it.
> >>  From looking at quirk_usb_early_handoff(), it may depend on BIOS
> >> details.  Maybe the USB folks will have some ideas.
> > 
> > Can we see the output from lspci?  It would help to know what the 12.0
> > and 13.0 devices are.
> 
> Sorry, that was trimmed from the original message. Here is the output 
> from the ASRock A780FullD.
> 
> > ```
> > $ more /proc/version
> > Linux version 4.9.0-0.bpo.2-amd64 (debian-ker...@lists.debian.org)
> > (gcc version 4.9.2 (Debian 4.9.2-10) ) #1 SMP Debian 4.9.13-1~bpo8+1 
> > (2017-02-27)
> > $ lspci -nn

> > 00:12.0 USB controller [0c03]: Advanced Micro Devices, Inc. [AMD/ATI] 
> > SB7x0/SB8x0/SB9x0 USB OHCI0 Controller [1002:4397]
> > 00:12.1 USB controller [0c03]: Advanced Micro Devices, Inc. [AMD/ATI] SB7x0 
> > USB OHCI1 Controller [1002:4398]
> > 00:12.2 USB controller [0c03]: Advanced Micro Devices, Inc. [AMD/ATI] 
> > SB7x0/SB8x0/SB9x0 USB EHCI Controller [1002:4396]
> > 00:13.0 USB controller [0c03]: Advanced Micro Devices, Inc. [AMD/ATI] 
> > SB7x0/SB8x0/SB9x0 USB OHCI0 Controller [1002:4397]
> > 00:13.1 USB controller [0c03]: Advanced Micro Devices, Inc. [AMD/ATI] SB7x0 
> > USB OHCI1 Controller [1002:4398]
> > 00:13.2 USB controller [0c03]: Advanced Micro Devices, Inc. [AMD/ATI] 
> > SB7x0/SB8x0/SB9x0 USB EHCI Controller [1002:4396]

> So far, this can be reproduce on all AMD systems I have (ASRock 
> A780FullHD, ASRock E350M1, Asus F2A85-M Pro).

So they are OHCI controllers.  You could add some debugging statements 
to quirk_usb_handoff_ohci() to try and locate the part that's taking so 
long.

It's also worth mentioning that the same source file contains lots of 
special-case code for AMD and ASmedia hardware.  I don't know whether 
any of it is involved in the long time delays you are seeing, however.

Alan Stern

Re: `pci_apply_final_quirks()` taking half a second

2017-12-30 Thread Paul Menzel 



Am 29.12.2017 um 17:14 schrieb Alan Stern:

On Thu, 28 Dec 2017, Bjorn Helgaas wrote:


On Tue, Dec 26, 2017 at 04:55:20PM +0100, Paul Menzel wrote:

Am 08.04.2017 um 17:41 schrieb Bjorn Helgaas:

On Fri, Apr 07, 2017 at 11:07:15PM +0200, Paul Menzel wrote:



Measuring where time is spent during boot with `systemd-bootchart`
on an Asus A780FullHD, it turns out that half a second is spent in
`pci_apply_final_quirks()`.


I agree, that seems like a crazy amount of time.

Can you figure out how to turn on pr_debug() (via the dynamic debug
mess or whatever) and boot with "initcall_debug"?  That should tell us
how long each quirk took.


I am sorry for taking so long to reply. I finally added `dyndbg=file
quirks.c +p` to the command line of Linux 4.13.13. This is on
another AMD system (Asus F285M Pro).



Dez 26 16:21:46 asus-f2a85-pro kernel: pci fixup
quirk_usb_early_handoff+0x0/0x6b0 returned after 197 usecs for
:00:10.0
Dez 26 16:21:46 asus-f2a85-pro kernel: pci fixup
quirk_usb_early_handoff+0x0/0x6b0 returned after 127 usecs for
:00:10.1
Dez 26 16:21:46 asus-f2a85-pro kernel: pci fixup
quirk_usb_early_handoff+0x0/0x6b0 returned after 88643 usecs for
:00:12.0
Dez 26 16:21:46 asus-f2a85-pro kernel: pci fixup
quirk_usb_early_handoff+0x0/0x6b0 returned after 137 usecs for
:00:12.2
Dez 26 16:21:46 asus-f2a85-pro kernel: pci fixup
pci_fixup_amd_ehci_pme+0x0/0x30 returned after 1 usecs for
:00:12.2
Dez 26 16:21:46 asus-f2a85-pro kernel: pci fixup
quirk_usb_early_handoff+0x0/0x6b0 returned after 85770 usecs for
:00:13.0
Dez 26 16:21:46 asus-f2a85-pro kernel: pci fixup
quirk_usb_early_handoff+0x0/0x6b0 returned after 134 usecs for
:00:13.2
Dez 26 16:21:46 asus-f2a85-pro kernel: pci fixup
pci_fixup_amd_ehci_pme+0x0/0x30 returned after 1 usecs for
:00:13.2
Dez 26 16:21:46 asus-f2a85-pro kernel: pci fixup
quirk_usb_early_handoff+0x0/0x6b0 returned after 125 usecs for
:03:00.0[…]
```

So it’s `pci fixup quirk_usb_early_handoff` taking around 85 ms, and
that twice.


Wow.  That's pretty painful, but of course I don't know how to fix it.
 From looking at quirk_usb_early_handoff(), it may depend on BIOS
details.  Maybe the USB folks will have some ideas.


Can we see the output from lspci?  It would help to know what the 12.0
and 13.0 devices are.


Sorry, that was trimmed from the original message. Here is the output 
from the ASRock A780FullD.



```
$ more /proc/version
Linux version 4.9.0-0.bpo.2-amd64 (debian-ker...@lists.debian.org)
(gcc version 4.9.2 (Debian 4.9.2-10) ) #1 SMP Debian 4.9.13-1~bpo8+1 
(2017-02-27)
$ lspci -nn
00:00.0 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] RS780 Host 
Bridge [1022:9600]
00:01.0 PCI bridge [0604]: ASRock Incorporation Device [1849:9602]
00:09.0 PCI bridge [0604]: Advanced Micro Devices, Inc. [AMD] RS780/RS880 PCI 
to PCI bridge (PCIE port 4) [1022:9608]
00:0a.0 PCI bridge [0604]: Advanced Micro Devices, Inc. [AMD] RS780/RS880 PCI 
to PCI bridge (PCIE port 5) [1022:9609]
00:11.0 SATA controller [0106]: Advanced Micro Devices, Inc. [AMD/ATI] 
SB7x0/SB8x0/SB9x0 SATA Controller [AHCI mode] [1002:4391]
00:12.0 USB controller [0c03]: Advanced Micro Devices, Inc. [AMD/ATI] 
SB7x0/SB8x0/SB9x0 USB OHCI0 Controller [1002:4397]
00:12.1 USB controller [0c03]: Advanced Micro Devices, Inc. [AMD/ATI] SB7x0 USB 
OHCI1 Controller [1002:4398]
00:12.2 USB controller [0c03]: Advanced Micro Devices, Inc. [AMD/ATI] 
SB7x0/SB8x0/SB9x0 USB EHCI Controller [1002:4396]
00:13.0 USB controller [0c03]: Advanced Micro Devices, Inc. [AMD/ATI] 
SB7x0/SB8x0/SB9x0 USB OHCI0 Controller [1002:4397]
00:13.1 USB controller [0c03]: Advanced Micro Devices, Inc. [AMD/ATI] SB7x0 USB 
OHCI1 Controller [1002:4398]
00:13.2 USB controller [0c03]: Advanced Micro Devices, Inc. [AMD/ATI] 
SB7x0/SB8x0/SB9x0 USB EHCI Controller [1002:4396]
00:14.0 SMBus [0c05]: Advanced Micro Devices, Inc. [AMD/ATI] SBx00 SMBus 
Controller [1002:4385] (rev 3a)
00:14.1 IDE interface [0101]: Advanced Micro Devices, Inc. [AMD/ATI] 
SB7x0/SB8x0/SB9x0 IDE Controller [1002:439c]
00:14.2 Audio device [0403]: Advanced Micro Devices, Inc. [AMD/ATI] SBx00 
Azalia (Intel HDA) [1002:4383]
00:14.3 ISA bridge [0601]: Advanced Micro Devices, Inc. [AMD/ATI] 
SB7x0/SB8x0/SB9x0 LPC host controller [1002:439d]
00:14.4 PCI bridge [0604]: Advanced Micro Devices, Inc. [AMD/ATI] SBx00 PCI to 
PCI Bridge [1002:4384]
00:14.5 USB controller [0c03]: Advanced Micro Devices, Inc. [AMD/ATI] 
SB7x0/SB8x0/SB9x0 USB OHCI2 Controller [1002:4399]
00:18.0 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] K8 
[Athlon64/Opteron] HyperTransport Technology Configuration [1022:1100]
00:18.1 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] K8 
[Athlon64/Opteron] Address Map [1022:1101]
00:18.2 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] K8 
[Athlon64/Opteron] DRAM Controller [1022:1102]
00:18.3 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] K8 
[Athlon64/Opteron] Miscellaneous Control [1022:1103]
01:05.0 VGA

Re: `pci_apply_final_quirks()` taking half a second

2017-12-29 Thread Alan Stern 
On Thu, 28 Dec 2017, Bjorn Helgaas wrote:

> On Tue, Dec 26, 2017 at 04:55:20PM +0100, Paul Menzel wrote:
> > Am 08.04.2017 um 17:41 schrieb Bjorn Helgaas:
> > >On Fri, Apr 07, 2017 at 11:07:15PM +0200, Paul Menzel wrote:
> > 
> > >>Measuring where time is spent during boot with `systemd-bootchart`
> > >>on an Asus A780FullHD, it turns out that half a second is spent in
> > >>`pci_apply_final_quirks()`.
> > >
> > >I agree, that seems like a crazy amount of time.
> > >
> > >Can you figure out how to turn on pr_debug() (via the dynamic debug
> > >mess or whatever) and boot with "initcall_debug"?  That should tell us
> > >how long each quirk took.
> > 
> > I am sorry for taking so long to reply. I finally added `dyndbg=file
> > quirks.c +p` to the command line of Linux 4.13.13. This is on
> > another AMD system (Asus F285M Pro).

> > Dez 26 16:21:46 asus-f2a85-pro kernel: pci fixup
> > quirk_usb_early_handoff+0x0/0x6b0 returned after 197 usecs for
> > :00:10.0
> > Dez 26 16:21:46 asus-f2a85-pro kernel: pci fixup
> > quirk_usb_early_handoff+0x0/0x6b0 returned after 127 usecs for
> > :00:10.1
> > Dez 26 16:21:46 asus-f2a85-pro kernel: pci fixup
> > quirk_usb_early_handoff+0x0/0x6b0 returned after 88643 usecs for
> > :00:12.0
> > Dez 26 16:21:46 asus-f2a85-pro kernel: pci fixup
> > quirk_usb_early_handoff+0x0/0x6b0 returned after 137 usecs for
> > :00:12.2
> > Dez 26 16:21:46 asus-f2a85-pro kernel: pci fixup
> > pci_fixup_amd_ehci_pme+0x0/0x30 returned after 1 usecs for
> > :00:12.2
> > Dez 26 16:21:46 asus-f2a85-pro kernel: pci fixup
> > quirk_usb_early_handoff+0x0/0x6b0 returned after 85770 usecs for
> > :00:13.0
> > Dez 26 16:21:46 asus-f2a85-pro kernel: pci fixup
> > quirk_usb_early_handoff+0x0/0x6b0 returned after 134 usecs for
> > :00:13.2
> > Dez 26 16:21:46 asus-f2a85-pro kernel: pci fixup
> > pci_fixup_amd_ehci_pme+0x0/0x30 returned after 1 usecs for
> > :00:13.2
> > Dez 26 16:21:46 asus-f2a85-pro kernel: pci fixup
> > quirk_usb_early_handoff+0x0/0x6b0 returned after 125 usecs for
> > :03:00.0[…]
> > ```
> > 
> > So it’s `pci fixup quirk_usb_early_handoff` taking around 85 ms, and
> > that twice.
> 
> Wow.  That's pretty painful, but of course I don't know how to fix it.
> From looking at quirk_usb_early_handoff(), it may depend on BIOS
> details.  Maybe the USB folks will have some ideas.

Can we see the output from lspci?  It would help to know what the 12.0 
and 13.0 devices are.

Alan Stern

Re: `pci_apply_final_quirks()` taking half a second

2017-12-28 Thread Bjorn Helgaas 
On Tue, Dec 26, 2017 at 04:55:20PM +0100, Paul Menzel wrote:
> Am 08.04.2017 um 17:41 schrieb Bjorn Helgaas:
> >On Fri, Apr 07, 2017 at 11:07:15PM +0200, Paul Menzel wrote:
> 
> >>Measuring where time is spent during boot with `systemd-bootchart`
> >>on an Asus A780FullHD, it turns out that half a second is spent in
> >>`pci_apply_final_quirks()`.
> >
> >I agree, that seems like a crazy amount of time.
> >
> >Can you figure out how to turn on pr_debug() (via the dynamic debug
> >mess or whatever) and boot with "initcall_debug"?  That should tell us
> >how long each quirk took.
> 
> I am sorry for taking so long to reply. I finally added `dyndbg=file
> quirks.c +p` to the command line of Linux 4.13.13. This is on
> another AMD system (Asus F285M Pro).
> 
> ```
> […]
> Dez 26 16:21:46 asus-f2a85-pro kernel: pci fixup
> quirk_mmio_always_on+0x0/0x10 returned after 0 usecs for
> :00:00.0
> Dez 26 16:21:46 asus-f2a85-pro kernel: pci fixup
> quirk_no_pm_reset+0x0/0x20 returned after 0 usecs for :00:01.0
> Dez 26 16:21:46 asus-f2a85-pro kernel: pci fixup
> quirk_mmio_always_on+0x0/0x10 returned after 0 usecs for
> :00:18.0
> Dez 26 16:21:46 asus-f2a85-pro kernel: pci fixup
> quirk_mmio_always_on+0x0/0x10 returned after 0 usecs for
> :00:18.1
> Dez 26 16:21:46 asus-f2a85-pro kernel: pci fixup
> quirk_mmio_always_on+0x0/0x10 returned after 0 usecs for
> :00:18.2
> Dez 26 16:21:46 asus-f2a85-pro kernel: pci fixup
> quirk_mmio_always_on+0x0/0x10 returned after 0 usecs for
> :00:18.3
> Dez 26 16:21:46 asus-f2a85-pro kernel: pci fixup
> quirk_mmio_always_on+0x0/0x10 returned after 0 usecs for
> :00:18.4
> Dez 26 16:21:46 asus-f2a85-pro kernel: pci fixup
> quirk_mmio_always_on+0x0/0x10 returned after 0 usecs for
> :00:18.5
> Dez 26 16:21:46 asus-f2a85-pro kernel: pci fixup
> pci_fixup_video+0x0/0x110 returned after 4 usecs for :00:01.0
> Dez 26 16:21:46 asus-f2a85-pro kernel: pci fixup
> quirk_usb_early_handoff+0x0/0x6b0 returned after 197 usecs for
> :00:10.0
> Dez 26 16:21:46 asus-f2a85-pro kernel: pci fixup
> quirk_usb_early_handoff+0x0/0x6b0 returned after 127 usecs for
> :00:10.1
> Dez 26 16:21:46 asus-f2a85-pro kernel: pci fixup
> quirk_usb_early_handoff+0x0/0x6b0 returned after 88643 usecs for
> :00:12.0
> Dez 26 16:21:46 asus-f2a85-pro kernel: pci fixup
> quirk_usb_early_handoff+0x0/0x6b0 returned after 137 usecs for
> :00:12.2
> Dez 26 16:21:46 asus-f2a85-pro kernel: pci fixup
> pci_fixup_amd_ehci_pme+0x0/0x30 returned after 1 usecs for
> :00:12.2
> Dez 26 16:21:46 asus-f2a85-pro kernel: pci fixup
> quirk_usb_early_handoff+0x0/0x6b0 returned after 85770 usecs for
> :00:13.0
> Dez 26 16:21:46 asus-f2a85-pro kernel: pci fixup
> quirk_usb_early_handoff+0x0/0x6b0 returned after 134 usecs for
> :00:13.2
> Dez 26 16:21:46 asus-f2a85-pro kernel: pci fixup
> pci_fixup_amd_ehci_pme+0x0/0x30 returned after 1 usecs for
> :00:13.2
> Dez 26 16:21:46 asus-f2a85-pro kernel: pci fixup
> quirk_usb_early_handoff+0x0/0x6b0 returned after 125 usecs for
> :03:00.0[…]
> ```
> 
> So it’s `pci fixup quirk_usb_early_handoff` taking around 85 ms, and
> that twice.

Wow.  That's pretty painful, but of course I don't know how to fix it.
>From looking at quirk_usb_early_handoff(), it may depend on BIOS
details.  Maybe the USB folks will have some ideas.

>From the PCI perspective, we could do something like the following to
make slow quirks more noticeable and perhaps provide a little hint
that quirk performance is important.


commit a9eec698db04ccffa1fe43634752220a2fd2108d
Author: Bjorn Helgaas 
Date:   Thu Dec 28 13:23:03 2017 -0600

PCI: Report quirks that take more than 10ms

When the "initcall_debug" kernel parameter is used, we report the runtime
of each PCI quirk.  In addition, report the runtime of any quirk that takes
more than 10ms to execute.  The purpose is to make it easier to notice
quirks that slow down boot.

Signed-off-by: Bjorn Helgaas 

diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
index fd49b976973f..96008ff78a1a 100644
--- a/drivers/pci/quirks.c
+++ b/drivers/pci/quirks.c
@@ -3105,16 +3105,12 @@ DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, 0x0e0d, 
quirk_intel_ntb);
 static ktime_t fixup_debug_start(struct pci_dev *dev,
 void (*fn)(struct pci_dev *dev))
 {
-   ktime_t calltime = 0;
-
-   dev_dbg(&dev->dev, "calling %pF\n", fn);
if (initcall_debug) {
-   pr_debug("calling  %pF @ %i for %s\n",
-fn, task_pid_nr(current), dev_name(&dev->dev));
-   calltime = ktime_get();
+   dev_info(&dev->dev, "calling %pF @ %i\n",
+fn, task_pid_nr(current));
}
 
-   return calltime;
+   return ktime_get();
 }
 
 static void fixup_debug_report(struct pci_dev *dev, ktime_t calltime,
@@ -3123,12 +3119,11 @@ static void fixup_debug_report(struct pci_dev *dev, 
ktime_t calltime,

Re: `pci_apply_final_quirks()` taking half a second

2017-12-26 Thread Paul Menzel 

Dear Bjorn,


Am 08.04.2017 um 17:41 schrieb Bjorn Helgaas:

On Fri, Apr 07, 2017 at 11:07:15PM +0200, Paul Menzel wrote:



Measuring where time is spent during boot with `systemd-bootchart`
on an Asus A780FullHD, it turns out that half a second is spent in
`pci_apply_final_quirks()`.


I agree, that seems like a crazy amount of time.

Can you figure out how to turn on pr_debug() (via the dynamic debug
mess or whatever) and boot with "initcall_debug"?  That should tell us
how long each quirk took.


I am sorry for taking so long to reply. I finally added `dyndbg=file 
quirks.c +p` to the command line of Linux 4.13.13. This is on another 
AMD system (Asus F285M Pro).


```
[…]
Dez 26 16:21:46 asus-f2a85-pro kernel: pci fixup 
quirk_mmio_always_on+0x0/0x10 returned after 0 usecs for :00:00.0
Dez 26 16:21:46 asus-f2a85-pro kernel: pci fixup 
quirk_no_pm_reset+0x0/0x20 returned after 0 usecs for :00:01.0
Dez 26 16:21:46 asus-f2a85-pro kernel: pci fixup 
quirk_mmio_always_on+0x0/0x10 returned after 0 usecs for :00:18.0
Dez 26 16:21:46 asus-f2a85-pro kernel: pci fixup 
quirk_mmio_always_on+0x0/0x10 returned after 0 usecs for :00:18.1
Dez 26 16:21:46 asus-f2a85-pro kernel: pci fixup 
quirk_mmio_always_on+0x0/0x10 returned after 0 usecs for :00:18.2
Dez 26 16:21:46 asus-f2a85-pro kernel: pci fixup 
quirk_mmio_always_on+0x0/0x10 returned after 0 usecs for :00:18.3
Dez 26 16:21:46 asus-f2a85-pro kernel: pci fixup 
quirk_mmio_always_on+0x0/0x10 returned after 0 usecs for :00:18.4
Dez 26 16:21:46 asus-f2a85-pro kernel: pci fixup 
quirk_mmio_always_on+0x0/0x10 returned after 0 usecs for :00:18.5
Dez 26 16:21:46 asus-f2a85-pro kernel: pci fixup 
pci_fixup_video+0x0/0x110 returned after 4 usecs for :00:01.0
Dez 26 16:21:46 asus-f2a85-pro kernel: pci fixup 
quirk_usb_early_handoff+0x0/0x6b0 returned after 197 usecs for :00:10.0
Dez 26 16:21:46 asus-f2a85-pro kernel: pci fixup 
quirk_usb_early_handoff+0x0/0x6b0 returned after 127 usecs for :00:10.1
Dez 26 16:21:46 asus-f2a85-pro kernel: pci fixup 
quirk_usb_early_handoff+0x0/0x6b0 returned after 88643 usecs for 
:00:12.0
Dez 26 16:21:46 asus-f2a85-pro kernel: pci fixup 
quirk_usb_early_handoff+0x0/0x6b0 returned after 137 usecs for :00:12.2
Dez 26 16:21:46 asus-f2a85-pro kernel: pci fixup 
pci_fixup_amd_ehci_pme+0x0/0x30 returned after 1 usecs for :00:12.2
Dez 26 16:21:46 asus-f2a85-pro kernel: pci fixup 
quirk_usb_early_handoff+0x0/0x6b0 returned after 85770 usecs for 
:00:13.0
Dez 26 16:21:46 asus-f2a85-pro kernel: pci fixup 
quirk_usb_early_handoff+0x0/0x6b0 returned after 134 usecs for :00:13.2
Dez 26 16:21:46 asus-f2a85-pro kernel: pci fixup 
pci_fixup_amd_ehci_pme+0x0/0x30 returned after 1 usecs for :00:13.2
Dez 26 16:21:46 asus-f2a85-pro kernel: pci fixup 
quirk_usb_early_handoff+0x0/0x6b0 returned after 125 usecs for 
:03:00.0[…]

```

So it’s `pci fixup quirk_usb_early_handoff` taking around 85 ms, and 
that twice.



Here are the times copied from the SVG:

   init_ladder 0.012s
   init_menu 0.012s
   pm_sysrq_init 0.012s
   acpi_init 0.027s
   pci_subsys_init 0.008s
   hpet_late_init 0.004s
   tracer_init_tracefs 0.002s
   event_trace_init 0.008s
   pnpacpi_init 0.002s
   chr_dev_init 0.003s
   init_acpi_pm_clocksource 0.004s
   pci_apply_final_quirks 0.452s
   populate_rootfs 0.400s
   pci_iommu_init 0.003s
   rsa_init 0.058s
   serial8250_init 0.020s
   i8042_init 0.003s
   load_system_certificate_list 0.002s
   ata_init 0.007s
   ehci_pci_init 0.030s
   ohci_pci_init 0.312s
   ahci_pci_driver_init 0.342s
   atiixp_pci_driver_init 0.337s
   hid_init 0.004s
   init_sr 0.031s


[…]

It’d be great, if the times could be reduced, so that the time from
GRUB to entering the LUKS passphrase gets smaller.



Kind regards,

Paul

Re: `pci_apply_final_quirks()` taking half a second

2017-05-03 Thread Andy Shevchenko 
On Sat, Apr 8, 2017 at 10:06 PM, Bjorn Helgaas  wrote:
> On Sat, Apr 08, 2017 at 07:00:19PM +0200, David Woodhouse wrote:
>> ...
>> I note it's also reading PCI_CACHE_LINE_SIZE From config space for each
>> device in pci_apply_final_quirks(). How long does that take?
>
> I don't know, but it's pointless on modern PCIe systems where the
> Cache Line Size has no effect.  It'd be really nice if somebody
> cleaned that up and got rid of the read itself and the useless
> messages.

What I can think of is 10ms delay for PM. The laptop might be one of
Intel BayTrails where we have it.
But it's just a guess.

-- 
With Best Regards,
Andy Shevchenko

Re: `pci_apply_final_quirks()` taking half a second

2017-04-08 Thread Bjorn Helgaas 
On Sat, Apr 08, 2017 at 07:00:19PM +0200, David Woodhouse wrote:
> ...
> I note it's also reading PCI_CACHE_LINE_SIZE From config space for each
> device in pci_apply_final_quirks(). How long does that take?

I don't know, but it's pointless on modern PCIe systems where the
Cache Line Size has no effect.  It'd be really nice if somebody
cleaned that up and got rid of the read itself and the useless
messages.

Bjorn

Re: `pci_apply_final_quirks()` taking half a second

2017-04-08 Thread David Woodhouse 
On Sat, 2017-04-08 at 10:41 -0500, Bjorn Helgaas wrote:
> 
> > Measuring where time is spent during boot with `systemd-bootchart`
> > on an Asus A780FullHD, it turns out that half a second is spent in
> > `pci_apply_final_quirks()`.
> 
> I agree, that seems like a crazy amount of time.
> 
> Can you figure out how to turn on pr_debug() (via the dynamic debug
> mess or whatever) and boot with "initcall_debug"?  That should tell us
> how long each quirk took.

It could well be spending a fair amount of time just attempting to
match each device against the list. When I first implemented the table-
based quirks, back in the mists of time, there were relatively few. 

Now I wonder if it's worth sorting the list by vendor ID or something,
at least for the common case of the quirks which match on
vendor/device.

I note it's also reading PCI_CACHE_LINE_SIZE From config space for each
device in pci_apply_final_quirks(). How long does that take?

smime.p7s
Description: S/MIME cryptographic signature

Re: `pci_apply_final_quirks()` taking half a second

2017-04-08 Thread Bjorn Helgaas 
On Fri, Apr 07, 2017 at 11:07:15PM +0200, Paul Menzel wrote:
> Dear Linux folks,
> 
> 
> Measuring where time is spent during boot with `systemd-bootchart`
> on an Asus A780FullHD, it turns out that half a second is spent in
> `pci_apply_final_quirks()`.

I agree, that seems like a crazy amount of time.

Can you figure out how to turn on pr_debug() (via the dynamic debug
mess or whatever) and boot with "initcall_debug"?  That should tell us
how long each quirk took.

> Here are the times copied from the SVG:
> 
>   init_ladder 0.012s
>   init_menu 0.012s
>   pm_sysrq_init 0.012s
>   acpi_init 0.027s
>   pci_subsys_init 0.008s
>   hpet_late_init 0.004s
>   tracer_init_tracefs 0.002s
>   event_trace_init 0.008s
>   pnpacpi_init 0.002s
>   chr_dev_init 0.003s
>   init_acpi_pm_clocksource 0.004s
>   pci_apply_final_quirks 0.452s
>   populate_rootfs 0.400s
>   pci_iommu_init 0.003s
>   rsa_init 0.058s
>   serial8250_init 0.020s
>   i8042_init 0.003s
>   load_system_certificate_list 0.002s
>   ata_init 0.007s
>   ehci_pci_init 0.030s
>   ohci_pci_init 0.312s
>   ahci_pci_driver_init 0.342s
>   atiixp_pci_driver_init 0.337s
>   hid_init 0.004s
>   init_sr 0.031s
> 
> I don’t know what information you need, so I just include the Linux
> Kernel version, and the output of `lspci -nn`.
> 
> ```
> $ more /proc/version
> Linux version 4.9.0-0.bpo.2-amd64 (debian-ker...@lists.debian.org)
> (gcc version 4.9.2 (Debian 4.9.2-10) ) #1 SMP Debian 4.9.13-1~bpo8+1
> (201
> 7-02-27)
> $ lspci -nn
> 00:00.0 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] RS780
> Host Bridge [1022:9600]
> 00:01.0 PCI bridge [0604]: ASRock Incorporation Device [1849:9602]
> 00:09.0 PCI bridge [0604]: Advanced Micro Devices, Inc. [AMD]
> RS780/RS880 PCI to PCI bridge (PCIE port 4) [1022:9608]
> 00:0a.0 PCI bridge [0604]: Advanced Micro Devices, Inc. [AMD]
> RS780/RS880 PCI to PCI bridge (PCIE port 5) [1022:9609]
> 00:11.0 SATA controller [0106]: Advanced Micro Devices, Inc.
> [AMD/ATI] SB7x0/SB8x0/SB9x0 SATA Controller [AHCI mode] [1002:4391]
> 00:12.0 USB controller [0c03]: Advanced Micro Devices, Inc.
> [AMD/ATI] SB7x0/SB8x0/SB9x0 USB OHCI0 Controller [1002:4397]
> 00:12.1 USB controller [0c03]: Advanced Micro Devices, Inc.
> [AMD/ATI] SB7x0 USB OHCI1 Controller [1002:4398]
> 00:12.2 USB controller [0c03]: Advanced Micro Devices, Inc.
> [AMD/ATI] SB7x0/SB8x0/SB9x0 USB EHCI Controller [1002:4396]
> 00:13.0 USB controller [0c03]: Advanced Micro Devices, Inc.
> [AMD/ATI] SB7x0/SB8x0/SB9x0 USB OHCI0 Controller [1002:4397]
> 00:13.1 USB controller [0c03]: Advanced Micro Devices, Inc.
> [AMD/ATI] SB7x0 USB OHCI1 Controller [1002:4398]
> 00:13.2 USB controller [0c03]: Advanced Micro Devices, Inc.
> [AMD/ATI] SB7x0/SB8x0/SB9x0 USB EHCI Controller [1002:4396]
> 00:14.0 SMBus [0c05]: Advanced Micro Devices, Inc. [AMD/ATI] SBx00
> SMBus Controller [1002:4385] (rev 3a)
> 00:14.1 IDE interface [0101]: Advanced Micro Devices, Inc. [AMD/ATI]
> SB7x0/SB8x0/SB9x0 IDE Controller [1002:439c]
> 00:14.2 Audio device [0403]: Advanced Micro Devices, Inc. [AMD/ATI]
> SBx00 Azalia (Intel HDA) [1002:4383]
> 00:14.3 ISA bridge [0601]: Advanced Micro Devices, Inc. [AMD/ATI]
> SB7x0/SB8x0/SB9x0 LPC host controller [1002:439d]
> 00:14.4 PCI bridge [0604]: Advanced Micro Devices, Inc. [AMD/ATI]
> SBx00 PCI to PCI Bridge [1002:4384]
> 00:14.5 USB controller [0c03]: Advanced Micro Devices, Inc.
> [AMD/ATI] SB7x0/SB8x0/SB9x0 USB OHCI2 Controller [1002:4399]
> 00:18.0 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] K8
> [Athlon64/Opteron] HyperTransport Technology Configuration
> [1022:1100]
> 00:18.1 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] K8
> [Athlon64/Opteron] Address Map [1022:1101]
> 00:18.2 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] K8
> [Athlon64/Opteron] DRAM Controller [1022:1102]
> 00:18.3 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] K8
> [Athlon64/Opteron] Miscellaneous Control [1022:1103]
> 01:05.0 VGA compatible controller [0300]: Advanced Micro Devices,
> Inc. [AMD/ATI] RS780 [Radeon HD 3200] [1002:9610]
> 04:00.0 Ethernet controller [0200]: Realtek Semiconductor Co., Ltd.
> RTL8111/8168/8411 PCI Express Gigabit Ethernet Controller
> [10ec:8168] (rev 02)
> ```
> 
> It’d be great, if the times could be reduced, so that the time from
> GRUB to entering the LUKS passphrase gets smaller.
> 
> 
> Kind regards,
> 
> Paul