Re: 2.4.0-test9 ipv6 module refcount problem?
It is nothing new, and works as intended. On Thu, Oct 05, 2000 at 11:09:53AM +0200, Andi Kleen wrote: > On Thu, Oct 05, 2000 at 03:52:14AM -0500, Jeff Garzik wrote: > > That seems like a bug... If MOD_INC_USE_COUNT occurs, then unload (oops?) > > is possible. > > It isn't. Read the code ;) [ipv6 uses the can_unload hook in the modules > code] Which is there to please Linus so that he didn't want to rip out the entire modularity of IPv6. Somewhen along 2.5 I hope to have enough time to separate UDP, and TCP into their common modules, plus IPv4/IPv6 specific ones and have the entire shebang to do proper usage counting. (That is, have a IPv6 ONLY system built from modules -- unless someone beats me to that goal.) > -Andi /Matti Aarnio - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
Re: 2.4.0-test9 ipv6 module refcount problem?
On Thu, Oct 05, 2000 at 03:52:14AM -0500, Jeff Garzik wrote: > That seems like a bug... If MOD_INC_USE_COUNT occurs, then unload (oops?) > is possible. It isn't. Read the code ;) [ipv6 uses the can_unload hook in the modules code] -Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
Re: 2.4.0-test9 ipv6 module refcount problem?
On Thu, 5 Oct 2000, Harald Welte wrote: > On Wed, Oct 04, 2000 at 11:11:21PM -0400, Brendan Cully wrote: > > > ipv6 142240 -1 > > go and check out the mailinglist archive. This is one of the most frequently > asked questions. > > IPv6 currently has no clean code to remove itself from the network stack, > so it is setting the reference count to -1 to ensure it is _never_ unloaded. > > Your next question might be: Why is it a module at all? > > Because we want to keep the kernel footprint as small as possible. That seems like a bug... If MOD_INC_USE_COUNT occurs, then unload (oops?) is possible. The proper way to do this is to add an additional MOD_INC_USE_COUNT to init_module. This ensures the mod use count is never less than one. Jeff - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
Re: 2.4.0-test9 ipv6 module refcount problem?
On Wed, Oct 04, 2000 at 11:11:21PM -0400, Brendan Cully wrote: > ipv6 142240 -1 go and check out the mailinglist archive. This is one of the most frequently asked questions. IPv6 currently has no clean code to remove itself from the network stack, so it is setting the reference count to -1 to ensure it is _never_ unloaded. Your next question might be: Why is it a module at all? Because we want to keep the kernel footprint as small as possible. -- Live long and prosper - Harald Welte / [EMAIL PROTECTED]http://www.gnumonks.org GCS/E/IT d- s-: a-- C+++ UL$ P+++ L$ E--- W- N++ o? K- w--- O- M- V-- PS+ PE-- Y+ PGP++ t++ 5-- !X !R tv-- b+++ DI? !D G+ e* h+ r% y+(*) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
Re: 2.4.0-test9 ipv6 module refcount problem?
On Wed, Oct 04, 2000 at 11:11:21PM -0400, Brendan Cully wrote: ipv6 142240 -1 go and check out the mailinglist archive. This is one of the most frequently asked questions. IPv6 currently has no clean code to remove itself from the network stack, so it is setting the reference count to -1 to ensure it is _never_ unloaded. Your next question might be: Why is it a module at all? Because we want to keep the kernel footprint as small as possible. -- Live long and prosper - Harald Welte / [EMAIL PROTECTED]http://www.gnumonks.org GCS/E/IT d- s-: a-- C+++ UL$ P+++ L$ E--- W- N++ o? K- w--- O- M- V-- PS+ PE-- Y+ PGP++ t++ 5-- !X !R tv-- b+++ DI? !D G+ e* h+ r% y+(*) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
Re: 2.4.0-test9 ipv6 module refcount problem?
On Thu, 5 Oct 2000, Harald Welte wrote: On Wed, Oct 04, 2000 at 11:11:21PM -0400, Brendan Cully wrote: ipv6 142240 -1 go and check out the mailinglist archive. This is one of the most frequently asked questions. IPv6 currently has no clean code to remove itself from the network stack, so it is setting the reference count to -1 to ensure it is _never_ unloaded. Your next question might be: Why is it a module at all? Because we want to keep the kernel footprint as small as possible. That seems like a bug... If MOD_INC_USE_COUNT occurs, then unload (oops?) is possible. The proper way to do this is to add an additional MOD_INC_USE_COUNT to init_module. This ensures the mod use count is never less than one. Jeff - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
Re: 2.4.0-test9 ipv6 module refcount problem?
On Thu, Oct 05, 2000 at 03:52:14AM -0500, Jeff Garzik wrote: That seems like a bug... If MOD_INC_USE_COUNT occurs, then unload (oops?) is possible. It isn't. Read the code ;) [ipv6 uses the can_unload hook in the modules code] -Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
Re: 2.4.0-test9 ipv6 module refcount problem?
It is nothing new, and works as intended. On Thu, Oct 05, 2000 at 11:09:53AM +0200, Andi Kleen wrote: On Thu, Oct 05, 2000 at 03:52:14AM -0500, Jeff Garzik wrote: That seems like a bug... If MOD_INC_USE_COUNT occurs, then unload (oops?) is possible. It isn't. Read the code ;) [ipv6 uses the can_unload hook in the modules code] Which is there to please Linus so that he didn't want to rip out the entire modularity of IPv6. Somewhen along 2.5 I hope to have enough time to separate UDP, and TCP into their common modules, plus IPv4/IPv6 specific ones and have the entire shebang to do proper usage counting. (That is, have a IPv6 ONLY system built from modules -- unless someone beats me to that goal.) -Andi /Matti Aarnio - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
