Re: Fix apparent cut-n-paste mistake in Dell reboot workaround.
On Mon, Sep 30, 2013 at 01:15:02PM +1000, Dave Airlie wrote: > On Mon, Sep 30, 2013 at 1:06 PM, Matthew Garrett wrote: > > Likely indicates that our ACPI reboot handling still isn't bug > > compatible with Windows. We'd do better fixing that than adding more DMI > > entries. > > are these only with VTd enabled? I have some Dells that won't reboot > with VTd turned on, I remember you though it was an acpi bug we > couldn't do much with. Oh, that's true - the ACPI reboot vector on the Dell tables I have to hand appears to be via the keyboard controller, so there's probably some SMM involved. I don't know if the VTd thing is still a problem (David Woodhouse was looking into that at one point), but that would be a reasonable point to start from. -- Matthew Garrett | mj...@srcf.ucam.org -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Fix apparent cut-n-paste mistake in Dell reboot workaround.
On 09/29/2013 08:15 PM, Dave Airlie wrote: >> >> Likely indicates that our ACPI reboot handling still isn't bug >> compatible with Windows. We'd do better fixing that than adding more DMI >> entries. > > are these only with VTd enabled? I have some Dells that won't reboot > with VTd turned on, I remember you though it was an acpi bug we > couldn't do much with. > It would be very interesting to know what the heck the ACPI reset port is set to in these machines. -hpa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Fix apparent cut-n-paste mistake in Dell reboot workaround.
On Mon, Sep 30, 2013 at 1:06 PM, Matthew Garrett wrote: > On Sun, Sep 29, 2013 at 07:58:10PM -0700, H. Peter Anvin wrote: >> On 09/29/2013 07:57 PM, Matthew Garrett wrote: >> > On Fri, Sep 27, 2013 at 03:16:49PM -0500, H. Peter Anvin wrote: >> >> >> >> It really is starting to feel like *ALL* Dell machines need reboot=pci? >> > >> > Now that ACPI is default, I'd be surprised if any of them do. >> > >> >> Look at the stream of Dell machines we're still getting reboot bug >> reports for... > > Likely indicates that our ACPI reboot handling still isn't bug > compatible with Windows. We'd do better fixing that than adding more DMI > entries. are these only with VTd enabled? I have some Dells that won't reboot with VTd turned on, I remember you though it was an acpi bug we couldn't do much with. Dave. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Fix apparent cut-n-paste mistake in Dell reboot workaround.
On Sun, Sep 29, 2013 at 07:58:10PM -0700, H. Peter Anvin wrote: > On 09/29/2013 07:57 PM, Matthew Garrett wrote: > > On Fri, Sep 27, 2013 at 03:16:49PM -0500, H. Peter Anvin wrote: > >> > >> It really is starting to feel like *ALL* Dell machines need reboot=pci? > > > > Now that ACPI is default, I'd be surprised if any of them do. > > > > Look at the stream of Dell machines we're still getting reboot bug > reports for... Likely indicates that our ACPI reboot handling still isn't bug compatible with Windows. We'd do better fixing that than adding more DMI entries. -- Matthew Garrett | mj...@srcf.ucam.org -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Fix apparent cut-n-paste mistake in Dell reboot workaround.
On 09/29/2013 07:57 PM, Matthew Garrett wrote: > On Fri, Sep 27, 2013 at 03:16:49PM -0500, H. Peter Anvin wrote: >> >> It really is starting to feel like *ALL* Dell machines need reboot=pci? > > Now that ACPI is default, I'd be surprised if any of them do. > Look at the stream of Dell machines we're still getting reboot bug reports for... -hpa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Fix apparent cut-n-paste mistake in Dell reboot workaround.
On Fri, Sep 27, 2013 at 03:16:49PM -0500, H. Peter Anvin wrote: > > It really is starting to feel like *ALL* Dell machines need reboot=pci? Now that ACPI is default, I'd be surprised if any of them do. -- Matthew Garrett | mj...@srcf.ucam.org -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Fix apparent cut-n-paste mistake in Dell reboot workaround.
On Fri, Sep 27, 2013 at 03:16:49PM -0500, H. Peter Anvin wrote: It really is starting to feel like *ALL* Dell machines need reboot=pci? Now that ACPI is default, I'd be surprised if any of them do. -- Matthew Garrett | mj...@srcf.ucam.org -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Fix apparent cut-n-paste mistake in Dell reboot workaround.
On 09/29/2013 07:57 PM, Matthew Garrett wrote: On Fri, Sep 27, 2013 at 03:16:49PM -0500, H. Peter Anvin wrote: It really is starting to feel like *ALL* Dell machines need reboot=pci? Now that ACPI is default, I'd be surprised if any of them do. Look at the stream of Dell machines we're still getting reboot bug reports for... -hpa -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Fix apparent cut-n-paste mistake in Dell reboot workaround.
On Sun, Sep 29, 2013 at 07:58:10PM -0700, H. Peter Anvin wrote: On 09/29/2013 07:57 PM, Matthew Garrett wrote: On Fri, Sep 27, 2013 at 03:16:49PM -0500, H. Peter Anvin wrote: It really is starting to feel like *ALL* Dell machines need reboot=pci? Now that ACPI is default, I'd be surprised if any of them do. Look at the stream of Dell machines we're still getting reboot bug reports for... Likely indicates that our ACPI reboot handling still isn't bug compatible with Windows. We'd do better fixing that than adding more DMI entries. -- Matthew Garrett | mj...@srcf.ucam.org -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Fix apparent cut-n-paste mistake in Dell reboot workaround.
On Mon, Sep 30, 2013 at 1:06 PM, Matthew Garrett mj...@srcf.ucam.org wrote: On Sun, Sep 29, 2013 at 07:58:10PM -0700, H. Peter Anvin wrote: On 09/29/2013 07:57 PM, Matthew Garrett wrote: On Fri, Sep 27, 2013 at 03:16:49PM -0500, H. Peter Anvin wrote: It really is starting to feel like *ALL* Dell machines need reboot=pci? Now that ACPI is default, I'd be surprised if any of them do. Look at the stream of Dell machines we're still getting reboot bug reports for... Likely indicates that our ACPI reboot handling still isn't bug compatible with Windows. We'd do better fixing that than adding more DMI entries. are these only with VTd enabled? I have some Dells that won't reboot with VTd turned on, I remember you though it was an acpi bug we couldn't do much with. Dave. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Fix apparent cut-n-paste mistake in Dell reboot workaround.
On 09/29/2013 08:15 PM, Dave Airlie wrote: Likely indicates that our ACPI reboot handling still isn't bug compatible with Windows. We'd do better fixing that than adding more DMI entries. are these only with VTd enabled? I have some Dells that won't reboot with VTd turned on, I remember you though it was an acpi bug we couldn't do much with. It would be very interesting to know what the heck the ACPI reset port is set to in these machines. -hpa -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Fix apparent cut-n-paste mistake in Dell reboot workaround.
On Mon, Sep 30, 2013 at 01:15:02PM +1000, Dave Airlie wrote: On Mon, Sep 30, 2013 at 1:06 PM, Matthew Garrett mj...@srcf.ucam.org wrote: Likely indicates that our ACPI reboot handling still isn't bug compatible with Windows. We'd do better fixing that than adding more DMI entries. are these only with VTd enabled? I have some Dells that won't reboot with VTd turned on, I remember you though it was an acpi bug we couldn't do much with. Oh, that's true - the ACPI reboot vector on the Dell tables I have to hand appears to be via the keyboard controller, so there's probably some SMM involved. I don't know if the VTd thing is still a problem (David Woodhouse was looking into that at one point), but that would be a reasonable point to start from. -- Matthew Garrett | mj...@srcf.ucam.org -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Fix apparent cut-n-paste mistake in Dell reboot workaround.
On 09/27/2013 01:19 PM, Dave Jones wrote: > > Either that or 'bios'. The question I have is, of those marked 'bios', does > =pci > work too ? If we knew that was true, I'd probably say yes. > Who knows. reboot=bios used to only work on 32 bits until very recently. -hpa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Fix apparent cut-n-paste mistake in Dell reboot workaround.
On Fri, Sep 27, 2013 at 03:16:49PM -0500, H. Peter Anvin wrote: > On 09/24/2013 07:13 PM, Dave Jones wrote: > > This seems to have been copied from the Optiplex 990 entry above, but > > somoene > > forgot to change the ident text. > > > > Signed-off-by: Dave Jones > > > > diff --git a/arch/x86/kernel/reboot.c b/arch/x86/kernel/reboot.c > > index f6835d8..ea2aaca 100644 > > --- a/arch/x86/kernel/reboot.c > > +++ b/arch/x86/kernel/reboot.c > > @@ -360,7 +360,7 @@ static struct dmi_system_id __initdata > > reboot_dmi_table[] = { > >}, > >{ /* Handle problems with rebooting on the Precision M6600. */ > >.callback = set_pci_reboot, > > - .ident = "Dell OptiPlex 990", > > + .ident = "Dell Precision M6600", > >.matches = { > >DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), > >DMI_MATCH(DMI_PRODUCT_NAME, "Precision M6600"), > > > > It really is starting to feel like *ALL* Dell machines need reboot=pci? Either that or 'bios'. The question I have is, of those marked 'bios', does =pci work too ? If we knew that was true, I'd probably say yes. Dave -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Fix apparent cut-n-paste mistake in Dell reboot workaround.
On 09/24/2013 07:13 PM, Dave Jones wrote: > This seems to have been copied from the Optiplex 990 entry above, but somoene > forgot to change the ident text. > > Signed-off-by: Dave Jones > > diff --git a/arch/x86/kernel/reboot.c b/arch/x86/kernel/reboot.c > index f6835d8..ea2aaca 100644 > --- a/arch/x86/kernel/reboot.c > +++ b/arch/x86/kernel/reboot.c > @@ -360,7 +360,7 @@ static struct dmi_system_id __initdata reboot_dmi_table[] > = { > }, > { /* Handle problems with rebooting on the Precision M6600. */ > .callback = set_pci_reboot, > - .ident = "Dell OptiPlex 990", > + .ident = "Dell Precision M6600", > .matches = { > DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), > DMI_MATCH(DMI_PRODUCT_NAME, "Precision M6600"), > It really is starting to feel like *ALL* Dell machines need reboot=pci? -hpa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Fix apparent cut-n-paste mistake in Dell reboot workaround.
On 09/24/2013 07:13 PM, Dave Jones wrote: This seems to have been copied from the Optiplex 990 entry above, but somoene forgot to change the ident text. Signed-off-by: Dave Jones da...@fedoraproject.org diff --git a/arch/x86/kernel/reboot.c b/arch/x86/kernel/reboot.c index f6835d8..ea2aaca 100644 --- a/arch/x86/kernel/reboot.c +++ b/arch/x86/kernel/reboot.c @@ -360,7 +360,7 @@ static struct dmi_system_id __initdata reboot_dmi_table[] = { }, { /* Handle problems with rebooting on the Precision M6600. */ .callback = set_pci_reboot, - .ident = Dell OptiPlex 990, + .ident = Dell Precision M6600, .matches = { DMI_MATCH(DMI_SYS_VENDOR, Dell Inc.), DMI_MATCH(DMI_PRODUCT_NAME, Precision M6600), It really is starting to feel like *ALL* Dell machines need reboot=pci? -hpa -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Fix apparent cut-n-paste mistake in Dell reboot workaround.
On Fri, Sep 27, 2013 at 03:16:49PM -0500, H. Peter Anvin wrote: On 09/24/2013 07:13 PM, Dave Jones wrote: This seems to have been copied from the Optiplex 990 entry above, but somoene forgot to change the ident text. Signed-off-by: Dave Jones da...@fedoraproject.org diff --git a/arch/x86/kernel/reboot.c b/arch/x86/kernel/reboot.c index f6835d8..ea2aaca 100644 --- a/arch/x86/kernel/reboot.c +++ b/arch/x86/kernel/reboot.c @@ -360,7 +360,7 @@ static struct dmi_system_id __initdata reboot_dmi_table[] = { }, { /* Handle problems with rebooting on the Precision M6600. */ .callback = set_pci_reboot, - .ident = Dell OptiPlex 990, + .ident = Dell Precision M6600, .matches = { DMI_MATCH(DMI_SYS_VENDOR, Dell Inc.), DMI_MATCH(DMI_PRODUCT_NAME, Precision M6600), It really is starting to feel like *ALL* Dell machines need reboot=pci? Either that or 'bios'. The question I have is, of those marked 'bios', does =pci work too ? If we knew that was true, I'd probably say yes. Dave -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Fix apparent cut-n-paste mistake in Dell reboot workaround.
On 09/27/2013 01:19 PM, Dave Jones wrote: Either that or 'bios'. The question I have is, of those marked 'bios', does =pci work too ? If we knew that was true, I'd probably say yes. Who knows. reboot=bios used to only work on 32 bits until very recently. -hpa -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/