Re: Linux 2.6.23-rc9 and a heads-up for the 2.6.24 series..

2007-10-02 Thread Jeff Garzik

Andi Kleen wrote:

On Tuesday 02 October 2007 11:17:02 Thomas Gleixner wrote:
This is also a good time to warn about the fact that we're doing the x86 
merge very soon (as in the next day or two) after 2.6.23 is out, so if you 
have pending patches for the next series that touch arch/i386 or x86-64, 
you should get in touch with Thomas Gleixner and Ingo Molnar, who are the 
keepers of the merge scripts, and will help you prepare..



Yes I have ~100 patches for arch/x86_64, arch/i386

Should I just drop them?


Why don't you work with Thomas and Ingo to make sure everything is in 
sync and prepped for 2.6.24?


Jeff



-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: Linux 2.6.23-rc9 and a heads-up for the 2.6.24 series..

2007-10-02 Thread Andi Kleen
On Tuesday 02 October 2007 12:37:55 Jeff Garzik wrote:
 Andi Kleen wrote:
  On Tuesday 02 October 2007 11:17:02 Thomas Gleixner wrote:
  This is also a good time to warn about the fact that we're doing the x86 
  merge very soon (as in the next day or two) after 2.6.23 is out, so if 
  you 
  have pending patches for the next series that touch arch/i386 or x86-64, 
  you should get in touch with Thomas Gleixner and Ingo Molnar, who are the 
  keepers of the merge scripts, and will help you prepare..
  
  
  Yes I have ~100 patches for arch/x86_64, arch/i386
  
  Should I just drop them?
 
 Why don't you work with Thomas and Ingo to make sure everything is in 
 sync and prepped for 2.6.24?

The easiest way to do that would be to first merge all the queued and
collected patches from the last months. Once they are in people
can then create whatever mess they like.

The other way round  (adapting 100+ patches to a possibly completely
different tree) will be a huge amount of work which I am
frankly not very motivated to do because I think it's quite unnecessary. 

I would probably just push the work back to all the patch submitters -- that is 
what I meant with dropping the patches.

I assume mess up first would be also a minor catastrophe for Andrew --
in addition to my patches he also has a large number of patches
touching {x86_64,i386}

-Andi
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: Linux 2.6.23-rc9 and a heads-up for the 2.6.24 series..

2007-10-02 Thread Thomas Gleixner
On Tue, 2 Oct 2007, Andi Kleen wrote:
 On Tuesday 02 October 2007 12:37:55 Jeff Garzik wrote:
  Andi Kleen wrote:
   On Tuesday 02 October 2007 11:17:02 Thomas Gleixner wrote:
   This is also a good time to warn about the fact that we're doing the 
   x86 
   merge very soon (as in the next day or two) after 2.6.23 is out, so if 
   you 
   have pending patches for the next series that touch arch/i386 or 
   x86-64, 
   you should get in touch with Thomas Gleixner and Ingo Molnar, who are 
   the 
   keepers of the merge scripts, and will help you prepare..
   
   
   Yes I have ~100 patches for arch/x86_64, arch/i386
   
   Should I just drop them?
  
  Why don't you work with Thomas and Ingo to make sure everything is in 
  sync and prepped for 2.6.24?
 
 The easiest way to do that would be to first merge all the queued and
 collected patches from the last months. Once they are in people
 can then create whatever mess they like.
 
 The other way round  (adapting 100+ patches to a possibly completely
 different tree) will be a huge amount of work which I am
 frankly not very motivated to do because I think it's quite unnecessary. 
 
 I would probably just push the work back to all the patch submitters -- that 
 is 
 what I meant with dropping the patches.

I picked up your queue at

ftp://ftp.firstfloor.org/pub/ak/x86_64/quilt-current/current.tar.gz

and converted it with the fixup script to:

http://www.tglx.de/~tglx/patches-ak.tar.bz2

Hope that helps,

tglx
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: Linux 2.6.23-rc9 and a heads-up for the 2.6.24 series..

2007-10-02 Thread Mel Gorman
On Mon, 2007-10-01 at 20:41 -0700, Linus Torvalds wrote:
 I said I was hoping that -rc8 was the last -rc, and I hate doing this, but 
 we've had more changes since -rc8 than we had in -rc8. And while most of 
 them are pretty trivial, I really couldn't face doing a 2.6.23 release and 
 take the risk of some really stupid brown-paper-bag thing.
 

Dirt. Booting with profile=sleep,2 is broken in 2.6.23-rc9 and
2.6.23-rc8 but working in 2.6.22. I was checking it out as part of a
discussion in another thread and noticed it broken in -mm as well
(2.6.23-rc8-mm2). Bisect is in progress but suggestions as to the prime
candidates are welcome or preferably, pointing out that I'm an idiot
because I missed twiddling some config change.

2.6.22 output
gringo:~# readprofile | sort -rn
 69604 total  0.0309
 27287 m_start  243.6339
 16430 sync_page205.3750
 13161 sync_buffer  205.6406
  4035 sys_init_module0.6121
  2842 msleep88.8125
  2573 call_usermodehelper_keys  10.7208
  1554 ps2_sendbyte   6.0703
   803 log_wait_commit2.7882
   378 do_lookup  0.9844
   160 do_get_write_access0.
89 synchronize_rcu1.3906
76 ps2_command0.0792
66 ide_do_drive_cmd   0.2292
59 do_fork0.1085
54 congestion_wait0.3750
29 __rtnl_unlock  1.8125
 4 kthread0.0357
 2 *unknown*
 2 journal_stop   0.0038
 1 kthreadd   0.0035
 1 kthread_create 0.0063

latest git output
gringo:~# readprofile
 0 *unknown*
 0 total  0.

I checked the obvious stuff like DEBUG options being set,
CONFIG_PROFILING being set etc.

 So there's a final -rc out there, and right now my plan is to make this 
 series really short, and release 2.6.23 in a few days. So please do give 
 it a last good testing, and holler about any issues you find!
 
 This is also a good time to warn about the fact that we're doing the x86 
 merge very soon (as in the next day or two) after 2.6.23 is out, so if you 
 have pending patches for the next series that touch arch/i386 or x86-64, 
 you should get in touch with Thomas Gleixner and Ingo Molnar, who are the 
 keepers of the merge scripts, and will help you prepare..
 
 Doing it as early as possible in the 2.6.24-rc4 series (basically I'll do 
 it first thing) will mean that we'll have the maximum amount of time to 
 sort out any issues, and the thing is, Thomas and Ingo already have a tree 
 ready to go, so people can check their work against that, and don't need 
 to think that they have to do any fixups after it his *my* tree. It would 
 be much better if everybody was just ready for it, and not taken by 
 surprise.
 
 In other words, people who know they may be affected and would want to 
 prepare can look at (for example)
 
   git://git.kernel.org/pub/scm/linux/kernel/git/tglx/linux-2.6-x86.git x86
 
 and generally get ready for the switch-over. 
 
   Linus
 -
 To unsubscribe from this list: send the line unsubscribe linux-kernel in
 the body of a message to [EMAIL PROTECTED]
 More majordomo info at  http://vger.kernel.org/majordomo-info.html
 Please read the FAQ at  http://www.tux.org/lkml/

-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: Linux 2.6.23-rc9 and a heads-up for the 2.6.24 series..

2007-10-02 Thread Jiri Kosina
On Tue, 2 Oct 2007, Andi Kleen wrote:

 Yes I have ~100 patches for arch/x86_64, arch/i386 Should I just drop 
 them?

I asuume that Andrew is periodically pulling your queue into -mm, isn't 
he? If so, Thomas explicitly stated that -mm can be converted easily with 
just a few rejects, right?

-- 
Jiri Kosina
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: Linux 2.6.23-rc9 and a heads-up for the 2.6.24 series..

2007-10-02 Thread Ingo Molnar

* Mel Gorman [EMAIL PROTECTED] wrote:

 Dirt. Booting with profile=sleep,2 is broken in 2.6.23-rc9 and 
 2.6.23-rc8 but working in 2.6.22. I was checking it out as part of a 
 discussion in another thread and noticed it broken in -mm as well 
 (2.6.23-rc8-mm2). Bisect is in progress but suggestions as to the 
 prime candidates are welcome or preferably, pointing out that I'm an 
 idiot because I missed twiddling some config change.

Mel, does the patch below fix this bug for you? (Note: you will need to 
enable CONFIG_SCHEDSTATS=y too.)

if yes, then Linus please pull this single fix from:

  git://git.kernel.org/pub/scm/linux/kernel/git/mingo/linux-2.6-sched.git

  | Ingo Molnar (1):
  |  sched: fix profile=sleep
  |
  |  sched_fair.c |   10 ++
  |  1 file changed, 10 insertions(+)

risk is low: the new code only runs with CONFIG_SCHEDSTATS=y 
(default:off) and profile=sleep (default:off), so it ought to be fairly 
safe to add at this point. (and we had very similar code in v2.6.22 
anyway)

Ingo

-
Subject: sched: fix profile=sleep
From: Ingo Molnar [EMAIL PROTECTED]

fix sleep profiling - we lost this chunk in the CFS merge.

Found-by: Mel Gorman [EMAIL PROTECTED]
Signed-off-by: Ingo Molnar [EMAIL PROTECTED]
---
 kernel/sched_fair.c |   10 ++
 1 file changed, 10 insertions(+)

Index: linux/kernel/sched_fair.c
===
--- linux.orig/kernel/sched_fair.c
+++ linux/kernel/sched_fair.c
@@ -639,6 +639,16 @@ static void enqueue_sleeper(struct cfs_r
 
se-block_start = 0;
se-sum_sleep_runtime += delta;
+
+   /*
+* Blocking time is in units of nanosecs, so shift by 20 to
+* get a milliseconds-range estimation of the amount of
+* time that the task spent sleeping:
+*/
+   if (unlikely(prof_on == SLEEP_PROFILING)) {
+   profile_hits(SLEEP_PROFILING, (void *)get_wchan(tsk),
+delta  20);
+   }
}
 #endif
 }
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: Linux 2.6.23-rc9 and a heads-up for the 2.6.24 series..

2007-10-02 Thread Ingo Molnar

* Thomas Gleixner [EMAIL PROTECTED] wrote:

 On Tue, 2 Oct 2007, Andi Kleen wrote:
  On Tuesday 02 October 2007 12:37:55 Jeff Garzik wrote:
   Andi Kleen wrote:
On Tuesday 02 October 2007 11:17:02 Thomas Gleixner wrote:
This is also a good time to warn about the fact that we're doing the 
x86 
merge very soon (as in the next day or two) after 2.6.23 is out, so 
if you 
have pending patches for the next series that touch arch/i386 or 
x86-64, 
you should get in touch with Thomas Gleixner and Ingo Molnar, who are 
the 
keepers of the merge scripts, and will help you prepare..


Yes I have ~100 patches for arch/x86_64, arch/i386

Should I just drop them?
   
   Why don't you work with Thomas and Ingo to make sure everything is in 
   sync and prepped for 2.6.24?
  
  The easiest way to do that would be to first merge all the queued 
  and collected patches from the last months. Once they are in people 
  can then create whatever mess they like.
  
  The other way round (adapting 100+ patches to a possibly completely 
  different tree) will be a huge amount of work which I am frankly not 
  very motivated to do because I think it's quite unnecessary.
  
  I would probably just push the work back to all the patch submitters 
  -- that is what I meant with dropping the patches.
 
 I picked up your queue at
 
   ftp://ftp.firstfloor.org/pub/ak/x86_64/quilt-current/current.tar.gz
 
 and converted it with the fixup script to:
 
   http://www.tglx.de/~tglx/patches-ak.tar.bz2
 
 Hope that helps,

thanks Thomas - i have applied this queue ontop of the unified arch/x86 
tree (i skipped vdso-text-offset which change is already upstream) and 
it built and booted fine on a couple of x86 systems - 32-bit and 64-bit 
alike. So your script worked like a charm.

Andi, could you please send us the list of patches from the 
current.tar.gz queue above that you consider 2.6.24 candidates? (and 
please add to the list if there's anything else pending) Thanks,

Ingo
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: Linux 2.6.23-rc9 and a heads-up for the 2.6.24 series..

2007-10-02 Thread Andi Kleen

 Andi, could you please send us the list of patches from the 
 current.tar.gz queue above that you consider 2.6.24 candidates? 

Everything in principle except the patches marked with TBD.

 (and  
 please add to the list if there's anything else pending) 

I'm still merging/fixing etc. so the list is not final yet.

-Andi
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: Linux 2.6.23-rc9 and a heads-up for the 2.6.24 series..

2007-10-02 Thread Ingo Molnar

* Andi Kleen [EMAIL PROTECTED] wrote:

  Andi, could you please send us the list of patches from the 
  current.tar.gz queue above that you consider 2.6.24 candidates?
 
 Everything in principle except the patches marked with TBD.

ok, the ones marked TBD are:

 cflags-probe
 cpa-clflush
 sched-clock-share
 svm-disabled
 unwinder

  (and please add to the list if there's anything else pending)
 
 I'm still merging/fixing etc. so the list is not final yet.

please merge it ontop of the arch/x86 tree so that we can start 
reviewing and testing it based on the unified tree ASAP. (but sending us 
a queue to the old layout is fine too - whichever variant you can do 
fastest) Thanks,

Ingo
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: Linux 2.6.23-rc9 and a heads-up for the 2.6.24 series..

2007-10-02 Thread John Stoffel

Linus I said I was hoping that -rc8 was the last -rc, and I hate
Linus doing this, but we've had more changes since -rc8 than we had
Linus in -rc8. And while most of them are pretty trivial, I really
Linus couldn't face doing a 2.6.23 release and take the risk of some
Linus really stupid brown-paper-bag thing.

Linus So there's a final -rc out there, and right now my plan is to
Linus make this series really short, and release 2.6.23 in a few
Linus days. So please do give it a last good testing, and holler
Linus about any issues you find!

Just to let people know, I was running 2.6.23-rc for over 53 days
without any issues.  Mix of SCSI, Sata, tape drives, disks, MD, LVM,
SMP, etc.  I suspect we've got a pretty darn stable release coming out
soon.

John
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: Linux 2.6.23-rc9 and a heads-up for the 2.6.24 series..

2007-10-02 Thread Andi Kleen

 please merge it ontop of the arch/x86 tree so that we can start 
 reviewing and testing it based on the unified tree ASAP. (but sending us 
 a queue to the old layout is fine too - whichever variant you can do 
 fastest)

It will be uploaded to the usual location.

-Andi

-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: Linux 2.6.23-rc9 and a heads-up for the 2.6.24 series..

2007-10-02 Thread Sam Ravnborg
On Tue, Oct 02, 2007 at 04:31:15PM +0200, Ingo Molnar wrote:
 
 * Andi Kleen [EMAIL PROTECTED] wrote:
 
   Andi, could you please send us the list of patches from the 
   current.tar.gz queue above that you consider 2.6.24 candidates?
  
  Everything in principle except the patches marked with TBD.
 
 ok, the ones marked TBD are:
 
  cflags-probe
  cpa-clflush
  sched-clock-share
  svm-disabled
  unwinder
 
   (and please add to the list if there's anything else pending)
  
  I'm still merging/fixing etc. so the list is not final yet.
 
 please merge it ontop of the arch/x86 tree so that we can start 
 reviewing and testing it based on the unified tree ASAP. (but sending us 
 a queue to the old layout is fine too - whichever variant you can do 
 fastest) Thanks,

Hi Andi/Ingo.

I plan to integrate cflags-probe in kbuild.git if there is no objection.
And I will address any x86 issues when I do so.
On top of that I will most likely do the same change for i386.

Sam
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: Linux 2.6.23-rc9 and a heads-up for the 2.6.24 series..

2007-10-02 Thread Ingo Molnar

* John Stoffel [EMAIL PROTECTED] wrote:

 
 Linus I said I was hoping that -rc8 was the last -rc, and I hate
 Linus doing this, but we've had more changes since -rc8 than we had
 Linus in -rc8. And while most of them are pretty trivial, I really
 Linus couldn't face doing a 2.6.23 release and take the risk of some
 Linus really stupid brown-paper-bag thing.
 
 Linus So there's a final -rc out there, and right now my plan is to
 Linus make this series really short, and release 2.6.23 in a few
 Linus days. So please do give it a last good testing, and holler
 Linus about any issues you find!
 
 Just to let people know, I was running 2.6.23-rc for over 53 days 
 without any issues.  Mix of SCSI, Sata, tape drives, disks, MD, LVM, 
 SMP, etc.  I suspect we've got a pretty darn stable release coming out 
 soon.

that's pretty impressive! v2.6.23-rc2, right?

Ingo
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: Linux 2.6.23-rc9 and a heads-up for the 2.6.24 series..

2007-10-02 Thread Andi Kleen

 
 I plan to integrate cflags-probe in kbuild.git if there is no objection.

Fine for me. Please take what you want.

-Andi
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: Linux 2.6.23-rc9 and a heads-up for the 2.6.24 series..

2007-10-02 Thread Ingo Molnar

* Sam Ravnborg [EMAIL PROTECTED] wrote:

 On Tue, Oct 02, 2007 at 04:31:15PM +0200, Ingo Molnar wrote:
  
  * Andi Kleen [EMAIL PROTECTED] wrote:
  
Andi, could you please send us the list of patches from the 
current.tar.gz queue above that you consider 2.6.24 candidates?
   
   Everything in principle except the patches marked with TBD.
  
  ok, the ones marked TBD are:
  
   cflags-probe
   cpa-clflush
   sched-clock-share
   svm-disabled
   unwinder
  
(and please add to the list if there's anything else pending)
   
   I'm still merging/fixing etc. so the list is not final yet.
  
  please merge it ontop of the arch/x86 tree so that we can start 
  reviewing and testing it based on the unified tree ASAP. (but sending us 
  a queue to the old layout is fine too - whichever variant you can do 
  fastest) Thanks,
 
 Hi Andi/Ingo.
 
 I plan to integrate cflags-probe in kbuild.git if there is no 
 objection. And I will address any x86 issues when I do so. On top of 
 that I will most likely do the same change for i386.

great. I think that's the most straightforward merge path for such 
Makefile updates. Andi, Thomas, any objections?

Ingo
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: Linux 2.6.23-rc9 and a heads-up for the 2.6.24 series..

2007-10-02 Thread Thomas Gleixner
Sam,

On Tue, 2 Oct 2007, Sam Ravnborg wrote:
 Hi Andi/Ingo.
 
 I plan to integrate cflags-probe in kbuild.git if there is no objection.
 And I will address any x86 issues when I do so.
 On top of that I will most likely do the same change for i386.

Makes sense. While you are at it, can you please have an eye on the
Build system changes I did to make arch/x86 with the two stub
directories arch/i386 and arch/x86_64 work.

Thanks,

tglx

-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: Linux 2.6.23-rc9 and a heads-up for the 2.6.24 series..

2007-10-02 Thread Sam Ravnborg
On Tue, Oct 02, 2007 at 05:30:27PM +0200, Thomas Gleixner wrote:
 Sam,
 
 On Tue, 2 Oct 2007, Sam Ravnborg wrote:
  Hi Andi/Ingo.
  
  I plan to integrate cflags-probe in kbuild.git if there is no objection.
  And I will address any x86 issues when I do so.
  On top of that I will most likely do the same change for i386.

By the way - that patch depends on a few other patches in Andi's queue
but I will await until they are included.

 
 Makes sense. While you are at it, can you please have an eye on the
 Build system changes I did to make arch/x86 with the two stub
 directories arch/i386 and arch/x86_64 work.
Thats on my TODO list - but I do not think I will find time before the merge.

Sam
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: Linux 2.6.23-rc9 and a heads-up for the 2.6.24 series..

2007-10-02 Thread John Stoffel

Linus I said I was hoping that -rc8 was the last -rc, and I hate
Linus doing this, but we've had more changes since -rc8 than we had
Linus in -rc8. And while most of them are pretty trivial, I really
Linus couldn't face doing a 2.6.23 release and take the risk of some
Linus really stupid brown-paper-bag thing.

Linus So there's a final -rc out there, and right now my plan is to
Linus make this series really short, and release 2.6.23 in a few
Linus days. So please do give it a last good testing, and holler
Linus about any issues you find!

John Just to let people know, I was running 2.6.23-rc for over 53
John days without any issues.  Mix of SCSI, Sata, tape drives, disks,
John MD, LVM, SMP, etc.  I suspect we've got a pretty darn stable
John release coming out soon.

2.6.23-rc2 is what I meant.  Oops...
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: Linux 2.6.23-rc9 and a heads-up for the 2.6.24 series..

2007-10-02 Thread Mel Gorman
On (02/10/07 14:15), Ingo Molnar didst pronounce:
 
 * Mel Gorman [EMAIL PROTECTED] wrote:
 
  Dirt. Booting with profile=sleep,2 is broken in 2.6.23-rc9 and 
  2.6.23-rc8 but working in 2.6.22. I was checking it out as part of a 
  discussion in another thread and noticed it broken in -mm as well 
  (2.6.23-rc8-mm2). Bisect is in progress but suggestions as to the 
  prime candidates are welcome or preferably, pointing out that I'm an 
  idiot because I missed twiddling some config change.
 
 Mel, does the patch below fix this bug for you? (Note: you will need to 
 enable CONFIG_SCHEDSTATS=y too.)
 

Nice one Ingo - got it first try. The problem commit was
dd41f596cda0d7d6e4a8b139ffdfabcefdd46528 and it's clear that the code removed
in this commit is put back by this latest patch.  When applied, profile=sleep
works as long as CONFIG_SCHEDSTAT is set.

Thanks.

 if yes, then Linus please pull this single fix from:
 
   git://git.kernel.org/pub/scm/linux/kernel/git/mingo/linux-2.6-sched.git
 
   | Ingo Molnar (1):
   |  sched: fix profile=sleep
   |
   |  sched_fair.c |   10 ++
   |  1 file changed, 10 insertions(+)
 
 risk is low: the new code only runs with CONFIG_SCHEDSTATS=y 
 (default:off) and profile=sleep (default:off), so it ought to be fairly 
 safe to add at this point. (and we had very similar code in v2.6.22 
 anyway)
 
   Ingo
 
 -
 Subject: sched: fix profile=sleep
 From: Ingo Molnar [EMAIL PROTECTED]
 
 fix sleep profiling - we lost this chunk in the CFS merge.
 
 Found-by: Mel Gorman [EMAIL PROTECTED]
 Signed-off-by: Ingo Molnar [EMAIL PROTECTED]

Tested-by: Mel Gorman [EMAIL PROTECTED]

That said, I am not super-keen on this only working when SCHEDSTAT is set
without telling the user about it. It's not urgent enough to pick up as a
late-late fix but prehaps something like this?

=

profile=sleep only works if CONFIG_SCHEDSTATS is set. This patch notes the
limitation in Documentation/kernel-parameters.txt and prints a warning at
boot-time if profile=sleep is used without CONFIG_SCHEDSTAT.

Signed-off-by: Mel Gorman [EMAIL PROTECTED]
--- 
 Documentation/kernel-parameters.txt |3 ++-
 kernel/profile.c|5 +
 2 files changed, 7 insertions(+), 1 deletion(-)

diff -rup -X /usr/src/patchset-0.6/bin//dontdiff 
linux-2.6.23-rc9-005_ingo_profile_fix/Documentation/kernel-parameters.txt 
linux-2.6.23-rc9-010_document_profilesleep/Documentation/kernel-parameters.txt
--- linux-2.6.23-rc9-005_ingo_profile_fix/Documentation/kernel-parameters.txt   
2007-10-02 04:24:52.0 +0100
+++ 
linux-2.6.23-rc9-010_document_profilesleep/Documentation/kernel-parameters.txt  
2007-10-02 16:43:41.0 +0100
@@ -1395,7 +1395,8 @@ and is between 256 and 4096 characters. 
Param: schedule - profile schedule points.
Param: number - step/bucket size as a power of 2 for
statistical time based profiling.
-   Param: sleep - profile D-state sleeping (millisecs)
+   Param: sleep - profile D-state sleeping (millisecs).
+   Requires CONFIG_SCHEDSTATS to work
 
processor.max_cstate=   [HW,ACPI]
Limit processor to maximum C-state
diff -rup -X /usr/src/patchset-0.6/bin//dontdiff 
linux-2.6.23-rc9-005_ingo_profile_fix/kernel/profile.c 
linux-2.6.23-rc9-010_document_profilesleep/kernel/profile.c
--- linux-2.6.23-rc9-005_ingo_profile_fix/kernel/profile.c  2007-10-02 
04:24:52.0 +0100
+++ linux-2.6.23-rc9-010_document_profilesleep/kernel/profile.c 2007-10-02 
16:44:50.0 +0100
@@ -60,6 +60,7 @@ static int __init profile_setup(char * s
int par;
 
if (!strncmp(str, sleepstr, strlen(sleepstr))) {
+#ifdef CONFIG_SCHEDSTATS
prof_on = SLEEP_PROFILING;
if (str[strlen(sleepstr)] == ',')
str += strlen(sleepstr) + 1;
@@ -68,6 +69,10 @@ static int __init profile_setup(char * s
printk(KERN_INFO
kernel sleep profiling enabled (shift: %ld)\n,
prof_shift);
+#else
+   printk(KERN_WARNING
+   kernel sleep profiling requires CONFIG_SCHEDSTATS\n);
+#endif /* CONFIG_SCHEDSTATS */
} else if (!strncmp(str, schedstr, strlen(schedstr))) {
prof_on = SCHED_PROFILING;
if (str[strlen(schedstr)] == ',')
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: Linux 2.6.23-rc9 and a heads-up for the 2.6.24 series..

2007-10-02 Thread Rafael J. Wysocki
On Tuesday, 2 October 2007 11:17, Thomas Gleixner wrote:
 On Mon, 1 Oct 2007, Linus Torvalds wrote:
  This is also a good time to warn about the fact that we're doing the x86 
  merge very soon (as in the next day or two) after 2.6.23 is out, so if you 
  have pending patches for the next series that touch arch/i386 or x86-64, 
  you should get in touch with Thomas Gleixner and Ingo Molnar, who are the 
  keepers of the merge scripts, and will help you prepare..
  
  Doing it as early as possible in the 2.6.24-rc4 series (basically I'll do 
  it first thing) will mean that we'll have the maximum amount of time to 
  sort out any issues, and the thing is, Thomas and Ingo already have a tree 
  ready to go, so people can check their work against that, and don't need 
  to think that they have to do any fixups after it his *my* tree. It would 
  be much better if everybody was just ready for it, and not taken by 
  surprise.
  
  In other words, people who know they may be affected and would want to 
  prepare can look at (for example)
  
  git://git.kernel.org/pub/scm/linux/kernel/git/tglx/linux-2.6-x86.git x86
  
  and generally get ready for the switch-over. 
 
 I have uploaded an update of the arch/x86 tree based on -rc9 to
 
   git://git.kernel.org/pub/scm/linux/kernel/git/tglx/linux-2.6-x86.git x86
 
 For convenience there is a patch fixup script which helps you to
 convert pending patches against this tree.
 
   http://userweb.kernel.org/~tglx/x86/x86-fixup-patches.py
 
 It's generated from the merge script and fixes the namespace of
 patches. There will still be some rejects which can not be fixed up
 automatically, but this should be rare.
 
 I did a test with Andrews -mm series and only ~10 arch/x86 related
 patches had rejects, out of 230+ patches, so the 100%-painless
 conversion ratio is better than 95%. Those patches with rejects were
 trivial to fix.
 
 Usage: x86-fixup-patches.py sourcepatch destpatch
 
 source and dest can be the same.
 
 A helper script to convert complete quilt series is here:
   http://userweb.kernel.org/~tglx/x86/fixupseries.sh
 
 If there is anything we can help with the transition, please do not
 hesitate to ask.

Well, there are several arch-dependent power management patches in -mm queued
up for merging.  Do I need to take care of converting them myself, or will that
be done automatically, or ...?

Greetings,
Rafael
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: Linux 2.6.23-rc9 and a heads-up for the 2.6.24 series..

2007-10-02 Thread Andrew Morton
On Tue, 2 Oct 2007 22:12:13 +0200
Rafael J. Wysocki [EMAIL PROTECTED] wrote:

  Usage: x86-fixup-patches.py sourcepatch destpatch
  
  source and dest can be the same.
  
  A helper script to convert complete quilt series is here:
  http://userweb.kernel.org/~tglx/x86/fixupseries.sh
  
  If there is anything we can help with the transition, please do not
  hesitate to ask.
 
 Well, there are several arch-dependent power management patches in -mm queued
 up for merging.  Do I need to take care of converting them myself, or will 
 that
 be done automatically, or ...?

It should be OK.  I'll wait until this lot hits Linus's tree and then I'll
redo the whole -mm patch queue.

The one problem with this is that I will have trouble repulling and remerging
the 81 subsystem tree which are part of -mm until their owners have fixed
everything up - I'll either need to temporarily drop them or will need to
fix them up with Thomas's script each time I fetch them.

But whatever - I'll sort it out..
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: Linux 2.6.23-rc9 and a heads-up for the 2.6.24 series..

2007-10-02 Thread Rafael J. Wysocki
On Tuesday, 2 October 2007 22:11, Andrew Morton wrote:
 On Tue, 2 Oct 2007 22:12:13 +0200
 Rafael J. Wysocki [EMAIL PROTECTED] wrote:
 
   Usage: x86-fixup-patches.py sourcepatch destpatch
   
   source and dest can be the same.
   
   A helper script to convert complete quilt series is here:
 http://userweb.kernel.org/~tglx/x86/fixupseries.sh
   
   If there is anything we can help with the transition, please do not
   hesitate to ask.
  
  Well, there are several arch-dependent power management patches in -mm 
  queued
  up for merging.  Do I need to take care of converting them myself, or will 
  that
  be done automatically, or ...?
 
 It should be OK.  I'll wait until this lot hits Linus's tree and then I'll
 redo the whole -mm patch queue.
 
 The one problem with this is that I will have trouble repulling and remerging
 the 81 subsystem tree which are part of -mm until their owners have fixed
 everything up - I'll either need to temporarily drop them or will need to
 fix them up with Thomas's script each time I fetch them.
 
 But whatever - I'll sort it out..

Many thanks!
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: Linux 2.6.23-rc9 and a heads-up for the 2.6.24 series..

2007-10-02 Thread Roland Dreier
  The one problem with this is that I will have trouble repulling and remerging
  the 81 subsystem tree which are part of -mm until their owners have fixed
  everything up - I'll either need to temporarily drop them or will need to
  fix them up with Thomas's script each time I fetch them.

FWIW, I just pulled Thomas's x86 branch into my for-2.6.24 branch and
test-booted that on one of my systems with no obvious problems.  (Hey,
it compiled, ship it...)

 - R.
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: Linux 2.6.23-rc9 and a heads-up for the 2.6.24 series..

2007-10-02 Thread Bill Davidsen

Mel Gorman wrote:

On (02/10/07 14:15), Ingo Molnar didst pronounce:

* Mel Gorman [EMAIL PROTECTED] wrote:

Dirt. Booting with profile=sleep,2 is broken in 2.6.23-rc9 and 
2.6.23-rc8 but working in 2.6.22. I was checking it out as part of a 
discussion in another thread and noticed it broken in -mm as well 
(2.6.23-rc8-mm2). Bisect is in progress but suggestions as to the 
prime candidates are welcome or preferably, pointing out that I'm an 
idiot because I missed twiddling some config change.
Mel, does the patch below fix this bug for you? (Note: you will need to 
enable CONFIG_SCHEDSTATS=y too.)




Nice one Ingo - got it first try. The problem commit was
dd41f596cda0d7d6e4a8b139ffdfabcefdd46528 and it's clear that the code removed
in this commit is put back by this latest patch.  When applied, profile=sleep
works as long as CONFIG_SCHEDSTAT is set.

And if it isn't set? I can easily see building a new kernel with stats 
off and forgetting to change the boot options.


--
Bill Davidsen [EMAIL PROTECTED]
  We have more to fear from the bungling of the incompetent than from
the machinations of the wicked.  - from Slashdot
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: Linux 2.6.23-rc9 and a heads-up for the 2.6.24 series..

2007-10-02 Thread Bill Davidsen

John Stoffel wrote:

Linus I said I was hoping that -rc8 was the last -rc, and I hate
Linus doing this, but we've had more changes since -rc8 than we had
Linus in -rc8. And while most of them are pretty trivial, I really
Linus couldn't face doing a 2.6.23 release and take the risk of some
Linus really stupid brown-paper-bag thing.

Linus So there's a final -rc out there, and right now my plan is to
Linus make this series really short, and release 2.6.23 in a few
Linus days. So please do give it a last good testing, and holler
Linus about any issues you find!

Just to let people know, I was running 2.6.23-rc for over 53 days
without any issues.  Mix of SCSI, Sata, tape drives, disks, MD, LVM,
SMP, etc.  I suspect we've got a pretty darn stable release coming out
soon.

I've been running rc8-git3 since it came out, and while I've built git-5 
and will build rc9, I probably will continue testing until I find a bug 
or have to boot for some other reason. Running really well, even with a 
lot of kvm stuff going on, kernel builds for other machines, etc.


--
Bill Davidsen [EMAIL PROTECTED]
  We have more to fear from the bungling of the incompetent than from
the machinations of the wicked.  - from Slashdot
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: Linux 2.6.23-rc9 and a heads-up for the 2.6.24 series..

2007-10-02 Thread Willy Tarreau
On Mon, Oct 01, 2007 at 08:41:49PM -0700, Linus Torvalds wrote:
 
 I said I was hoping that -rc8 was the last -rc, and I hate doing this, but 
 we've had more changes since -rc8 than we had in -rc8. And while most of 
 them are pretty trivial, I really couldn't face doing a 2.6.23 release and 
 take the risk of some really stupid brown-paper-bag thing.
 
 So there's a final -rc out there, and right now my plan is to make this 
 series really short, and release 2.6.23 in a few days. So please do give 
 it a last good testing, and holler about any issues you find!

Looks pretty good at first glance. Dual-K7, adaptec 29160, NFS, e1000,
root on /dev/sda*. Not even one bad thing to report yet.

Cheers,
Willy

-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: Linux 2.6.23-rc9 and a heads-up for the 2.6.24 series..

2007-10-02 Thread Alistair John Strachan
On Tuesday 02 October 2007 04:41:49 Linus Torvalds wrote:
[snip]
 In other words, people who know they may be affected and would want to
 prepare can look at (for example)

   git://git.kernel.org/pub/scm/linux/kernel/git/tglx/linux-2.6-x86.git x86

 and generally get ready for the switch-over.

This is certainly a tool issue, but if I use Debian's kernel-image make-kpkg 
wrapper around the kernel build system, it fails with:

cp: cannot stat `arch/x86_64/boot/bzImage': No such file or directory

Obviously, this file has moved to arch/x86/boot, but it seems like possibly 
unnecessary breakage. I've been copying bzImage for years from 
arch/x86_64/boot, and I'm sure there's a handful of scripts (other than 
Debian's kernel-image) doing this too.

For now, I hacked the tool[1]. Maybe, if we care, a symlink could be set up 
between arch/x86/boot and arch/$ARCH/boot ? Or would papering over this be 
more trouble than it's worth?

[1] http://devzero.co.uk/~alistair/kernel-package-changes.diff

-- 
Cheers,
Alistair.

137/1 Warrender Park Road, Edinburgh, UK.

-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: Linux 2.6.23-rc9 and a heads-up for the 2.6.24 series..

2007-10-02 Thread Glauber de Oliveira Costa
On 10/2/07, Alistair John Strachan [EMAIL PROTECTED] wrote:
 This is certainly a tool issue, but if I use Debian's kernel-image make-kpkg
 wrapper around the kernel build system, it fails with:

 cp: cannot stat `arch/x86_64/boot/bzImage': No such file or directory

 Obviously, this file has moved to arch/x86/boot, but it seems like possibly
 unnecessary breakage. I've been copying bzImage for years from
 arch/x86_64/boot, and I'm sure there's a handful of scripts (other than
 Debian's kernel-image) doing this too.

I believe most sane tools would be using the output of uname -m, so a
possible way to fix this would be fixing the data passed to userspace
from uname. However, that might be the case that it creates a new set
of problems too, with tools relying on the output of uname -m to
determine wheter the machine is 32 or 64 bit, and so on.

-- 
Glauber de Oliveira Costa.
Free as in Freedom
http://glommer.net

The less confident you are, the more serious you have to act.
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: Linux 2.6.23-rc9 and a heads-up for the 2.6.24 series..

2007-10-02 Thread Diego Calleja
El Mon, 1 Oct 2007 20:41:49 -0700 (PDT), Linus Torvalds [EMAIL PROTECTED] 
escribió:

 So there's a final -rc out there, and right now my plan is to make this 
 series really short, and release 2.6.23 in a few days. So please do give 
 it a last good testing, and holler about any issues you find!

Also...if someone dislikes something in http://kernelnewbies.org/Linux_2_6_23 ,
or wants to fix my english, do it soon :)
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: Linux 2.6.23-rc9 and a heads-up for the 2.6.24 series..

2007-10-02 Thread Linus Torvalds


On Wed, 3 Oct 2007, Diego Calleja wrote:
 
 Also...if someone dislikes something in http://kernelnewbies.org/Linux_2_6_23 
 ,
 or wants to fix my english, do it soon :)

Heh. The remove sk98lin driver bullet is sadly wrong. We had to 
reinstate it because it supported some cards that the skge driver doesn't 
handle.

Linus
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: Linux 2.6.23-rc9 and a heads-up for the 2.6.24 series..

2007-10-02 Thread Mel Gorman
On Tue, 2007-10-02 at 18:09 -0400, Bill Davidsen wrote:
 Mel Gorman wrote:
  On (02/10/07 14:15), Ingo Molnar didst pronounce:
  * Mel Gorman [EMAIL PROTECTED] wrote:
 
  Dirt. Booting with profile=sleep,2 is broken in 2.6.23-rc9 and 
  2.6.23-rc8 but working in 2.6.22. I was checking it out as part of a 
  discussion in another thread and noticed it broken in -mm as well 
  (2.6.23-rc8-mm2). Bisect is in progress but suggestions as to the 
  prime candidates are welcome or preferably, pointing out that I'm an 
  idiot because I missed twiddling some config change.
  Mel, does the patch below fix this bug for you? (Note: you will need to 
  enable CONFIG_SCHEDSTATS=y too.)
 
  
  Nice one Ingo - got it first try. The problem commit was
  dd41f596cda0d7d6e4a8b139ffdfabcefdd46528 and it's clear that the code 
  removed
  in this commit is put back by this latest patch.  When applied, 
  profile=sleep
  works as long as CONFIG_SCHEDSTAT is set.
  
 And if it isn't set? I can easily see building a new kernel with stats 
 off and forgetting to change the boot options.
 

If CONFIG_SCHEDSTAT is off and profile=sleep is set, you see with Ingo's
patch and readprofile;

 0 *unknown*
 0 total  0.

That is a tad confusing hence my follow-up patch which would say
/proc/profile doesn't exist when readprofile is used and the warning
in dmesg.

-- 
Mel Gorman

-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: Linux 2.6.23-rc9 and a heads-up for the 2.6.24 series..

2007-10-02 Thread Eric St-Laurent

On Tue, 2007-10-02 at 11:17 +0200, Thomas Gleixner wrote:

[...]

 I have uploaded an update of the arch/x86 tree based on -rc9 to
 
   git://git.kernel.org/pub/scm/linux/kernel/git/tglx/linux-2.6-x86.git x86
 

[...]

 If there is anything we can help with the transition, please do not
 hesitate to ask.
 
 Thanks,
 
   Thomas, Ingo

Hi Thomas,

This latest x86 branch build and boot without problem with my usual
x86_64 config.

If you remember our conversation one month ago, I was unable to build
your tree.

I've upgraded my Ubuntu distribution from 7.04 to 7.10 beta this week,
maybe this fixed it.

But I still had to do some manual fixes to get the packaging steps
working:

mkdir arch/x86_64/boot/
ln -s ../../../arch/x86/boot/bzImage arch/x86_64/boot/bzImage


Best regards,

- Eric


-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


<    1   2