Re: REGRESSION: 8fc5b4d: Unable to compile x86_64 kernel with x86_32 userland

2014-08-20 Thread H. Peter Anvin
Yes, that is exactly right.  The lack of -m64 is a bug.

On August 20, 2014 10:48:18 AM CDT, Vivek Goyal  wrote:
>On Wed, Aug 20, 2014 at 10:07:01AM -0500, H. Peter Anvin wrote:
>> It says "32-bit mode" which means it is another issue: we are
>dropping -m64 at some point.
>
>Thanks hpa. I am not adding -m64 to kbuild flags at all. So 32bit tool
>chain must be assuming -m32 by default, and probably that's the issue.
>
>Thomas, 
>
>Can you please try attached single line patch and see if it fixes the
>issue for you.
>
>Thanks
>Vivek
>
>
>---
> arch/x86/purgatory/Makefile |1 +
> 1 file changed, 1 insertion(+)
>
>Index: linux-2.6/arch/x86/purgatory/Makefile
>===
>--- linux-2.6.orig/arch/x86/purgatory/Makefile 2014-08-20
>11:32:21.723559119 -0400
>+++ linux-2.6/arch/x86/purgatory/Makefile  2014-08-20 11:32:23.654570231
>-0400
>@@ -11,6 +11,7 @@ targets += purgatory.ro
> # sure how to relocate those. Like kexec-tools, use custom flags.
> 
>KBUILD_CFLAGS := -fno-strict-aliasing -Wall -Wstrict-prototypes
>-fno-zero-initialized-in-bss -fno-builtin -ffreestanding -c -MD -Os
>-mcmodel=large
>+KBUILD_CFLAGS += -m$(BITS)
> 
> $(obj)/purgatory.ro: $(PURGATORY_OBJS) FORCE
>   $(call if_changed,ld)

-- 
Sent from my mobile phone.  Please pardon brevity and lack of formatting.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: REGRESSION: 8fc5b4d: Unable to compile x86_64 kernel with x86_32 userland

2014-08-20 Thread Thomas Glanzmann
Hello Vivek,

* Vivek Goyal  [2014-08-20 17:48]:
> --- linux-2.6.orig/arch/x86/purgatory/Makefile2014-08-20 
> 11:32:21.723559119 -0400
> +++ linux-2.6/arch/x86/purgatory/Makefile 2014-08-20 11:32:23.654570231 
> -0400
> @@ -11,6 +11,7 @@ targets += purgatory.ro
>  # sure how to relocate those. Like kexec-tools, use custom flags.

>  KBUILD_CFLAGS := -fno-strict-aliasing -Wall -Wstrict-prototypes 
> -fno-zero-initialized-in-bss -fno-builtin -ffreestanding -c -MD -Os 
> -mcmodel=large
> +KBUILD_CFLAGS += -m$(BITS)

>  $(obj)/purgatory.ro: $(PURGATORY_OBJS) FORCE
>   $(call if_changed,ld)

> Can you please try attached single line patch and see if it fixes the
> issue for you.

I tested the same and it works.

Tested-by: Thomas Glanzmann 

...
  CC  arch/x86/purgatory/purgatory.o
  AS  arch/x86/purgatory/stack.o
  AS  arch/x86/purgatory/setup-x86_64.o
  CC  arch/x86/purgatory/sha256.o
  AS  arch/x86/purgatory/entry64.o
  CC  arch/x86/purgatory/string.o
  LD  arch/x86/purgatory/purgatory.ro
  BIN2C   arch/x86/purgatory/kexec-purgatory.c
...

I also made sure that I backed out the other patch _before_ I tried this one.

Cheers,
Thomas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: REGRESSION: 8fc5b4d: Unable to compile x86_64 kernel with x86_32 userland

2014-08-20 Thread Thomas Glanzmann
Hello Vivek,

* Vivek Goyal  [2014-08-20 15:53]:
> A patch is sitting in akpm's tree. That patch puts the new code under
> a new config option CONFIG_KEXEC_FILE. So as long as you don't enable
> CONFIG_KEXEC_FILE=y, you should be fine. This should not impact any of
> the existing functionality. Just that you will not get the benefit of
> new system call.

> http://ozlabs.org/~akpm/mmotm/broken-out/kexec-create-a-new-config-option-config_kexec_file-for-new-syscall.patch

> I hope this patch gets merged soon.

> In the mean time I am trying to figure out how can I move away from
> using -mcmodel=large for purgatory.

perfect. I tried the patch and with the patch the kernel compiles again.

Cheers,
Thomas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: REGRESSION: 8fc5b4d: Unable to compile x86_64 kernel with x86_32 userland

2014-08-20 Thread Vivek Goyal
On Wed, Aug 20, 2014 at 10:07:01AM -0500, H. Peter Anvin wrote:
> It says "32-bit mode" which means it is another issue: we are dropping -m64 
> at some point.

Thanks hpa. I am not adding -m64 to kbuild flags at all. So 32bit tool
chain must be assuming -m32 by default, and probably that's the issue.

Thomas, 

Can you please try attached single line patch and see if it fixes the
issue for you.

Thanks
Vivek


---
 arch/x86/purgatory/Makefile |1 +
 1 file changed, 1 insertion(+)

Index: linux-2.6/arch/x86/purgatory/Makefile
===
--- linux-2.6.orig/arch/x86/purgatory/Makefile  2014-08-20 11:32:21.723559119 
-0400
+++ linux-2.6/arch/x86/purgatory/Makefile   2014-08-20 11:32:23.654570231 
-0400
@@ -11,6 +11,7 @@ targets += purgatory.ro
 # sure how to relocate those. Like kexec-tools, use custom flags.
 
 KBUILD_CFLAGS := -fno-strict-aliasing -Wall -Wstrict-prototypes 
-fno-zero-initialized-in-bss -fno-builtin -ffreestanding -c -MD -Os 
-mcmodel=large
+KBUILD_CFLAGS += -m$(BITS)
 
 $(obj)/purgatory.ro: $(PURGATORY_OBJS) FORCE
$(call if_changed,ld)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: REGRESSION: 8fc5b4d: Unable to compile x86_64 kernel with x86_32 userland

2014-08-20 Thread H. Peter Anvin
It says "32-bit mode" which means it is another issue: we are dropping -m64 at 
some point.

On August 20, 2014 7:56:30 AM CDT, Vivek Goyal  wrote:
>On Wed, Aug 20, 2014 at 08:24:08AM +0200, Thomas Glanzmann wrote:
>> Hello Vivek,
>> commit 8fc5b4d introduces a regression that no longer allows to
>compile
>> x86_64 kernel under x86_32 userland. TJ on freenode/#kernel did
>analyze
>> it:
>> 
>> > (mini) [~/work/linux-2.6] make
>> > scripts/kconfig/conf --silentoldconfig Kconfig
>> >   CHK include/config/kernel.release
>> >   UPD include/config/kernel.release
>> >   CHK include/generated/uapi/linux/version.h
>> >   CHK include/generated/utsrelease.h
>> >   UPD include/generated/utsrelease.h
>> >   CC  arch/x86/purgatory/purgatory.o
>> > arch/x86/purgatory/purgatory.c:1:0: error: code model 'large' not
>supported in the 32 bit mode
>> > make[1]: *** [arch/x86/purgatory/purgatory.o] Error 1
>> > make: *** [archprepare] Error 2
>> 
>> 08:10 < TJ-> Glanzmann: The purgatory code from kexec is specifying
>".code64"
>> 08:11 < TJ-> Glanzmann: so when your local 32-bit linker tries to
>deal with that ... it errors
>> 08:14 < TJ-> Glanzmann: there's only one introducing the purgatory
>stuff
>> 08:14 < TJ-> 8fc5b4d Fri Aug 8 15:57:32 2014 -0700 Vivek Goyal
>purgatory: core purgatory functionality
>
>Hi Thomas,
>
>Thanks for the report. I think this is also happening because purgatory
>is
>right now being compiled with compiler option -mcmodel=large. There was
>another report where older version of gcc did not support
>-mcmodel=large.
>
>A patch is sitting in akpm's tree. That patch puts the new code under
>a new config option CONFIG_KEXEC_FILE. So as long as you don't enable
>CONFIG_KEXEC_FILE=y, you should be fine. This should not impact any of
>the existing functionality. Just that you will not get the benefit of
>new system call.
>
>http://ozlabs.org/~akpm/mmotm/broken-out/kexec-create-a-new-config-option-config_kexec_file-for-new-syscall.patch
>
>I hope this patch gets merged soon.
>
>In the mean time I am trying to figure out how can I move away from
>using -mcmodel=large for purgatory.
>
>Thanks
>Vivek

-- 
Sent from my mobile phone.  Please pardon brevity and lack of formatting.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: REGRESSION: 8fc5b4d: Unable to compile x86_64 kernel with x86_32 userland

2014-08-20 Thread Vivek Goyal
On Wed, Aug 20, 2014 at 08:24:08AM +0200, Thomas Glanzmann wrote:
> Hello Vivek,
> commit 8fc5b4d introduces a regression that no longer allows to compile
> x86_64 kernel under x86_32 userland. TJ on freenode/#kernel did analyze
> it:
> 
> > (mini) [~/work/linux-2.6] make
> > scripts/kconfig/conf --silentoldconfig Kconfig
> >   CHK include/config/kernel.release
> >   UPD include/config/kernel.release
> >   CHK include/generated/uapi/linux/version.h
> >   CHK include/generated/utsrelease.h
> >   UPD include/generated/utsrelease.h
> >   CC  arch/x86/purgatory/purgatory.o
> > arch/x86/purgatory/purgatory.c:1:0: error: code model 'large' not supported 
> > in the 32 bit mode
> > make[1]: *** [arch/x86/purgatory/purgatory.o] Error 1
> > make: *** [archprepare] Error 2
> 
> 08:10 < TJ-> Glanzmann: The purgatory code from kexec is specifying ".code64"
> 08:11 < TJ-> Glanzmann: so when your local 32-bit linker tries to deal with 
> that ... it errors
> 08:14 < TJ-> Glanzmann: there's only one introducing the purgatory stuff
> 08:14 < TJ-> 8fc5b4d Fri Aug 8 15:57:32 2014 -0700 Vivek Goyal purgatory: 
> core purgatory functionality

Hi Thomas,

Thanks for the report. I think this is also happening because purgatory is
right now being compiled with compiler option -mcmodel=large. There was
another report where older version of gcc did not support -mcmodel=large.

A patch is sitting in akpm's tree. That patch puts the new code under
a new config option CONFIG_KEXEC_FILE. So as long as you don't enable
CONFIG_KEXEC_FILE=y, you should be fine. This should not impact any of
the existing functionality. Just that you will not get the benefit of
new system call.

http://ozlabs.org/~akpm/mmotm/broken-out/kexec-create-a-new-config-option-config_kexec_file-for-new-syscall.patch

I hope this patch gets merged soon.

In the mean time I am trying to figure out how can I move away from
using -mcmodel=large for purgatory.

Thanks
Vivek
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: REGRESSION: 8fc5b4d: Unable to compile x86_64 kernel with x86_32 userland

2014-08-20 Thread Vivek Goyal
On Wed, Aug 20, 2014 at 08:24:08AM +0200, Thomas Glanzmann wrote:
 Hello Vivek,
 commit 8fc5b4d introduces a regression that no longer allows to compile
 x86_64 kernel under x86_32 userland. TJ on freenode/#kernel did analyze
 it:
 
  (mini) [~/work/linux-2.6] make
  scripts/kconfig/conf --silentoldconfig Kconfig
CHK include/config/kernel.release
UPD include/config/kernel.release
CHK include/generated/uapi/linux/version.h
CHK include/generated/utsrelease.h
UPD include/generated/utsrelease.h
CC  arch/x86/purgatory/purgatory.o
  arch/x86/purgatory/purgatory.c:1:0: error: code model 'large' not supported 
  in the 32 bit mode
  make[1]: *** [arch/x86/purgatory/purgatory.o] Error 1
  make: *** [archprepare] Error 2
 
 08:10  TJ- Glanzmann: The purgatory code from kexec is specifying .code64
 08:11  TJ- Glanzmann: so when your local 32-bit linker tries to deal with 
 that ... it errors
 08:14  TJ- Glanzmann: there's only one introducing the purgatory stuff
 08:14  TJ- 8fc5b4d Fri Aug 8 15:57:32 2014 -0700 Vivek Goyal purgatory: 
 core purgatory functionality

Hi Thomas,

Thanks for the report. I think this is also happening because purgatory is
right now being compiled with compiler option -mcmodel=large. There was
another report where older version of gcc did not support -mcmodel=large.

A patch is sitting in akpm's tree. That patch puts the new code under
a new config option CONFIG_KEXEC_FILE. So as long as you don't enable
CONFIG_KEXEC_FILE=y, you should be fine. This should not impact any of
the existing functionality. Just that you will not get the benefit of
new system call.

http://ozlabs.org/~akpm/mmotm/broken-out/kexec-create-a-new-config-option-config_kexec_file-for-new-syscall.patch

I hope this patch gets merged soon.

In the mean time I am trying to figure out how can I move away from
using -mcmodel=large for purgatory.

Thanks
Vivek
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: REGRESSION: 8fc5b4d: Unable to compile x86_64 kernel with x86_32 userland

2014-08-20 Thread H. Peter Anvin
It says 32-bit mode which means it is another issue: we are dropping -m64 at 
some point.

On August 20, 2014 7:56:30 AM CDT, Vivek Goyal vgo...@redhat.com wrote:
On Wed, Aug 20, 2014 at 08:24:08AM +0200, Thomas Glanzmann wrote:
 Hello Vivek,
 commit 8fc5b4d introduces a regression that no longer allows to
compile
 x86_64 kernel under x86_32 userland. TJ on freenode/#kernel did
analyze
 it:
 
  (mini) [~/work/linux-2.6] make
  scripts/kconfig/conf --silentoldconfig Kconfig
CHK include/config/kernel.release
UPD include/config/kernel.release
CHK include/generated/uapi/linux/version.h
CHK include/generated/utsrelease.h
UPD include/generated/utsrelease.h
CC  arch/x86/purgatory/purgatory.o
  arch/x86/purgatory/purgatory.c:1:0: error: code model 'large' not
supported in the 32 bit mode
  make[1]: *** [arch/x86/purgatory/purgatory.o] Error 1
  make: *** [archprepare] Error 2
 
 08:10  TJ- Glanzmann: The purgatory code from kexec is specifying
.code64
 08:11  TJ- Glanzmann: so when your local 32-bit linker tries to
deal with that ... it errors
 08:14  TJ- Glanzmann: there's only one introducing the purgatory
stuff
 08:14  TJ- 8fc5b4d Fri Aug 8 15:57:32 2014 -0700 Vivek Goyal
purgatory: core purgatory functionality

Hi Thomas,

Thanks for the report. I think this is also happening because purgatory
is
right now being compiled with compiler option -mcmodel=large. There was
another report where older version of gcc did not support
-mcmodel=large.

A patch is sitting in akpm's tree. That patch puts the new code under
a new config option CONFIG_KEXEC_FILE. So as long as you don't enable
CONFIG_KEXEC_FILE=y, you should be fine. This should not impact any of
the existing functionality. Just that you will not get the benefit of
new system call.

http://ozlabs.org/~akpm/mmotm/broken-out/kexec-create-a-new-config-option-config_kexec_file-for-new-syscall.patch

I hope this patch gets merged soon.

In the mean time I am trying to figure out how can I move away from
using -mcmodel=large for purgatory.

Thanks
Vivek

-- 
Sent from my mobile phone.  Please pardon brevity and lack of formatting.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: REGRESSION: 8fc5b4d: Unable to compile x86_64 kernel with x86_32 userland

2014-08-20 Thread Vivek Goyal
On Wed, Aug 20, 2014 at 10:07:01AM -0500, H. Peter Anvin wrote:
 It says 32-bit mode which means it is another issue: we are dropping -m64 
 at some point.

Thanks hpa. I am not adding -m64 to kbuild flags at all. So 32bit tool
chain must be assuming -m32 by default, and probably that's the issue.

Thomas, 

Can you please try attached single line patch and see if it fixes the
issue for you.

Thanks
Vivek


---
 arch/x86/purgatory/Makefile |1 +
 1 file changed, 1 insertion(+)

Index: linux-2.6/arch/x86/purgatory/Makefile
===
--- linux-2.6.orig/arch/x86/purgatory/Makefile  2014-08-20 11:32:21.723559119 
-0400
+++ linux-2.6/arch/x86/purgatory/Makefile   2014-08-20 11:32:23.654570231 
-0400
@@ -11,6 +11,7 @@ targets += purgatory.ro
 # sure how to relocate those. Like kexec-tools, use custom flags.
 
 KBUILD_CFLAGS := -fno-strict-aliasing -Wall -Wstrict-prototypes 
-fno-zero-initialized-in-bss -fno-builtin -ffreestanding -c -MD -Os 
-mcmodel=large
+KBUILD_CFLAGS += -m$(BITS)
 
 $(obj)/purgatory.ro: $(PURGATORY_OBJS) FORCE
$(call if_changed,ld)
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: REGRESSION: 8fc5b4d: Unable to compile x86_64 kernel with x86_32 userland

2014-08-20 Thread Thomas Glanzmann
Hello Vivek,

* Vivek Goyal vgo...@redhat.com [2014-08-20 15:53]:
 A patch is sitting in akpm's tree. That patch puts the new code under
 a new config option CONFIG_KEXEC_FILE. So as long as you don't enable
 CONFIG_KEXEC_FILE=y, you should be fine. This should not impact any of
 the existing functionality. Just that you will not get the benefit of
 new system call.

 http://ozlabs.org/~akpm/mmotm/broken-out/kexec-create-a-new-config-option-config_kexec_file-for-new-syscall.patch

 I hope this patch gets merged soon.

 In the mean time I am trying to figure out how can I move away from
 using -mcmodel=large for purgatory.

perfect. I tried the patch and with the patch the kernel compiles again.

Cheers,
Thomas
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: REGRESSION: 8fc5b4d: Unable to compile x86_64 kernel with x86_32 userland

2014-08-20 Thread Thomas Glanzmann
Hello Vivek,

* Vivek Goyal vgo...@redhat.com [2014-08-20 17:48]:
 --- linux-2.6.orig/arch/x86/purgatory/Makefile2014-08-20 
 11:32:21.723559119 -0400
 +++ linux-2.6/arch/x86/purgatory/Makefile 2014-08-20 11:32:23.654570231 
 -0400
 @@ -11,6 +11,7 @@ targets += purgatory.ro
  # sure how to relocate those. Like kexec-tools, use custom flags.

  KBUILD_CFLAGS := -fno-strict-aliasing -Wall -Wstrict-prototypes 
 -fno-zero-initialized-in-bss -fno-builtin -ffreestanding -c -MD -Os 
 -mcmodel=large
 +KBUILD_CFLAGS += -m$(BITS)

  $(obj)/purgatory.ro: $(PURGATORY_OBJS) FORCE
   $(call if_changed,ld)

 Can you please try attached single line patch and see if it fixes the
 issue for you.

I tested the same and it works.

Tested-by: Thomas Glanzmann tho...@glanzmann.de

...
  CC  arch/x86/purgatory/purgatory.o
  AS  arch/x86/purgatory/stack.o
  AS  arch/x86/purgatory/setup-x86_64.o
  CC  arch/x86/purgatory/sha256.o
  AS  arch/x86/purgatory/entry64.o
  CC  arch/x86/purgatory/string.o
  LD  arch/x86/purgatory/purgatory.ro
  BIN2C   arch/x86/purgatory/kexec-purgatory.c
...

I also made sure that I backed out the other patch _before_ I tried this one.

Cheers,
Thomas
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: REGRESSION: 8fc5b4d: Unable to compile x86_64 kernel with x86_32 userland

2014-08-20 Thread H. Peter Anvin
Yes, that is exactly right.  The lack of -m64 is a bug.

On August 20, 2014 10:48:18 AM CDT, Vivek Goyal vgo...@redhat.com wrote:
On Wed, Aug 20, 2014 at 10:07:01AM -0500, H. Peter Anvin wrote:
 It says 32-bit mode which means it is another issue: we are
dropping -m64 at some point.

Thanks hpa. I am not adding -m64 to kbuild flags at all. So 32bit tool
chain must be assuming -m32 by default, and probably that's the issue.

Thomas, 

Can you please try attached single line patch and see if it fixes the
issue for you.

Thanks
Vivek


---
 arch/x86/purgatory/Makefile |1 +
 1 file changed, 1 insertion(+)

Index: linux-2.6/arch/x86/purgatory/Makefile
===
--- linux-2.6.orig/arch/x86/purgatory/Makefile 2014-08-20
11:32:21.723559119 -0400
+++ linux-2.6/arch/x86/purgatory/Makefile  2014-08-20 11:32:23.654570231
-0400
@@ -11,6 +11,7 @@ targets += purgatory.ro
 # sure how to relocate those. Like kexec-tools, use custom flags.
 
KBUILD_CFLAGS := -fno-strict-aliasing -Wall -Wstrict-prototypes
-fno-zero-initialized-in-bss -fno-builtin -ffreestanding -c -MD -Os
-mcmodel=large
+KBUILD_CFLAGS += -m$(BITS)
 
 $(obj)/purgatory.ro: $(PURGATORY_OBJS) FORCE
   $(call if_changed,ld)

-- 
Sent from my mobile phone.  Please pardon brevity and lack of formatting.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/