Re: Re: [PATCH v8 3/5] mfd: hi655x: Add MFD driver for hi655x
On 19 April 2016 at 14:53, Lee Jones <lee.jo...@linaro.org> wrote: > > On Tue, 19 Apr 2016, Guodong Xu wrote: > > > On 13 April 2016 at 08:51, Chen Feng <puck.c...@hisilicon.com> wrote: > > > > > > > > > > > > -------- Forwarded Message ---- > > > Subject: Re: [PATCH v8 3/5] mfd: hi655x: Add MFD driver for hi655x > > > Date: Mon, 11 Apr 2016 11:41:06 +0100 > > > From: Lee Jones <lee.jo...@linaro.org> > > > To: Chen Feng <puck.c...@hisilicon.com> > > > CC: lgirdw...@gmail.com, broo...@kernel.org, > > > linux-kernel@vger.kernel.org, w...@huawei.com, > > > kong.kongxin...@hisilicon.com, haojian.zhu...@linaro.org, > > > suzhuangl...@hisilicon.com, dan.z...@hisilicon.com > > > > > > On Sun, 14 Feb 2016, Chen Feng wrote: > > > > > > > Add PMIC MFD driver to support hisilicon hi665x. > > > > > > > > Signed-off-by: Chen Feng <puck.c...@hisilicon.com> > > > > Signed-off-by: Fei Wang <w...@huawei.com> > > > > Signed-off-by: Xinwei Kong <kong.kongxin...@hisilicon.com> > > > > Reviewed-by: Haojian Zhuang <haojian.zhu...@linaro.org> > > > > Acked-by: Lee Jones <lee.jo...@linaro.org> > > > > --- > > > > drivers/mfd/Kconfig | 10 +++ > > > > drivers/mfd/Makefile| 1 + > > > > drivers/mfd/hi655x-pmic.c | 162 > > > > > > > > include/linux/mfd/hi655x-pmic.h | 55 ++ > > > > 4 files changed, 228 insertions(+) > > > > create mode 100644 drivers/mfd/hi655x-pmic.c > > > > create mode 100644 include/linux/mfd/hi655x-pmic.h > > > > > > Applied, thanks. > > > > Hi, Lee, Mark > > > > I still didn't see this patch in linux-next (next-20160418) since your > > replied "Applied". Are you expecting anything else? Dependencies? > > > > I didn't see any unsolved review comments actually. But if there is, > > please let us know, so I can send an updated version. > > When I applied your patch, I also added ~40 other patches. I haven't > yet got around to editing and pushing them all to -next. I will put > some time aside this morning in order to complete the push. Hi, Lee As of this morning, I still cannot see hi655x in your for-mfd-next branch and in linux-next (next-20160517) I saw this patch integrated on Apr/19: mfd: hi655x: Add document for hi665x PMIC But apparently missing this one: [PATCH v8 3/5] mfd: hi655x: Add MFD driver for hi655x Would you please have a check? Sorry if I'm asking something stupid. Look forward to seeing it in v4.7-rcs. Thank you. -Guodong > > > > > > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > > > > index 9ca66de..5b1c091 100644 > > > > --- a/drivers/mfd/Kconfig > > > > +++ b/drivers/mfd/Kconfig > > > > @@ -284,6 +284,16 @@ config MFD_HI6421_PMIC > > > > menus in order to enable them. > > > > We communicate with the Hi6421 via memory-mapped I/O. > > > > > > > > +config MFD_HI655X_PMIC > > > > + tristate "HiSilicon Hi655X series PMU/Codec IC" > > > > + depends on ARCH_HISI || COMPILE_TEST > > > > + depends on OF > > > > + select MFD_CORE > > > > + select REGMAP_MMIO > > > > + select REGMAP_IRQ > > > > + help > > > > + Select this option to enable Hisilicon hi655x series pmic > > > > driver. > > > > + > > > > config HTC_EGPIO > > > > bool "HTC EGPIO support" > > > > depends on GPIOLIB && ARM > > > > diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile > > > > index 0f230a6..1e166c1 100644 > > > > --- a/drivers/mfd/Makefile > > > > +++ b/drivers/mfd/Makefile > > > > @@ -190,6 +190,7 @@ obj-$(CONFIG_MFD_STW481X) += stw481x.o > > > > obj-$(CONFIG_MFD_IPAQ_MICRO) += ipaq-micro.o > > > > obj-$(CONFIG_MFD_MENF21BMC) += menf21bmc.o > > > > obj-$(CONFIG_MFD_HI6421_PMIC)+= hi6421-pmic-core.o > > > > +obj-$(CONFIG_MFD_HI655X_PMIC) += hi655x-pmic.o > > > > obj-$(CONFIG_MFD_DLN2) += dln2.o > > > > obj-$(CONFIG_MFD_RT5033) += rt5033.o > > > > obj-$(CONFIG_MFD_SKY81452) += sky81452.o > > > > diff --git a/drivers/mfd/hi655x-pmic.c b/drivers/mfd/hi655x-pmic.c > > >
Re: Re: [PATCH v8 3/5] mfd: hi655x: Add MFD driver for hi655x
On 19 April 2016 at 14:53, Lee Jones wrote: > > On Tue, 19 Apr 2016, Guodong Xu wrote: > > > On 13 April 2016 at 08:51, Chen Feng wrote: > > > > > > > > > > > > -------- Forwarded Message -------- > > > Subject: Re: [PATCH v8 3/5] mfd: hi655x: Add MFD driver for hi655x > > > Date: Mon, 11 Apr 2016 11:41:06 +0100 > > > From: Lee Jones > > > To: Chen Feng > > > CC: lgirdw...@gmail.com, broo...@kernel.org, > > > linux-kernel@vger.kernel.org, w...@huawei.com, > > > kong.kongxin...@hisilicon.com, haojian.zhu...@linaro.org, > > > suzhuangl...@hisilicon.com, dan.z...@hisilicon.com > > > > > > On Sun, 14 Feb 2016, Chen Feng wrote: > > > > > > > Add PMIC MFD driver to support hisilicon hi665x. > > > > > > > > Signed-off-by: Chen Feng > > > > Signed-off-by: Fei Wang > > > > Signed-off-by: Xinwei Kong > > > > Reviewed-by: Haojian Zhuang > > > > Acked-by: Lee Jones > > > > --- > > > > drivers/mfd/Kconfig | 10 +++ > > > > drivers/mfd/Makefile| 1 + > > > > drivers/mfd/hi655x-pmic.c | 162 > > > > > > > > include/linux/mfd/hi655x-pmic.h | 55 ++ > > > > 4 files changed, 228 insertions(+) > > > > create mode 100644 drivers/mfd/hi655x-pmic.c > > > > create mode 100644 include/linux/mfd/hi655x-pmic.h > > > > > > Applied, thanks. > > > > Hi, Lee, Mark > > > > I still didn't see this patch in linux-next (next-20160418) since your > > replied "Applied". Are you expecting anything else? Dependencies? > > > > I didn't see any unsolved review comments actually. But if there is, > > please let us know, so I can send an updated version. > > When I applied your patch, I also added ~40 other patches. I haven't > yet got around to editing and pushing them all to -next. I will put > some time aside this morning in order to complete the push. Hi, Lee As of this morning, I still cannot see hi655x in your for-mfd-next branch and in linux-next (next-20160517) I saw this patch integrated on Apr/19: mfd: hi655x: Add document for hi665x PMIC But apparently missing this one: [PATCH v8 3/5] mfd: hi655x: Add MFD driver for hi655x Would you please have a check? Sorry if I'm asking something stupid. Look forward to seeing it in v4.7-rcs. Thank you. -Guodong > > > > > > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > > > > index 9ca66de..5b1c091 100644 > > > > --- a/drivers/mfd/Kconfig > > > > +++ b/drivers/mfd/Kconfig > > > > @@ -284,6 +284,16 @@ config MFD_HI6421_PMIC > > > > menus in order to enable them. > > > > We communicate with the Hi6421 via memory-mapped I/O. > > > > > > > > +config MFD_HI655X_PMIC > > > > + tristate "HiSilicon Hi655X series PMU/Codec IC" > > > > + depends on ARCH_HISI || COMPILE_TEST > > > > + depends on OF > > > > + select MFD_CORE > > > > + select REGMAP_MMIO > > > > + select REGMAP_IRQ > > > > + help > > > > + Select this option to enable Hisilicon hi655x series pmic > > > > driver. > > > > + > > > > config HTC_EGPIO > > > > bool "HTC EGPIO support" > > > > depends on GPIOLIB && ARM > > > > diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile > > > > index 0f230a6..1e166c1 100644 > > > > --- a/drivers/mfd/Makefile > > > > +++ b/drivers/mfd/Makefile > > > > @@ -190,6 +190,7 @@ obj-$(CONFIG_MFD_STW481X) += stw481x.o > > > > obj-$(CONFIG_MFD_IPAQ_MICRO) += ipaq-micro.o > > > > obj-$(CONFIG_MFD_MENF21BMC) += menf21bmc.o > > > > obj-$(CONFIG_MFD_HI6421_PMIC)+= hi6421-pmic-core.o > > > > +obj-$(CONFIG_MFD_HI655X_PMIC) += hi655x-pmic.o > > > > obj-$(CONFIG_MFD_DLN2) += dln2.o > > > > obj-$(CONFIG_MFD_RT5033) += rt5033.o > > > > obj-$(CONFIG_MFD_SKY81452) += sky81452.o > > > > diff --git a/drivers/mfd/hi655x-pmic.c b/drivers/mfd/hi655x-pmic.c > > > > new file mode 100644 > > > > index 000..05ddc78 > > > > --- /dev/null > > > > +++ b/drivers/mfd/hi655x-pmic.c > > > > @@ -0,0 +1,162 @@ > > > > +/* > > > > + * Device driver for MFD hi655
Re: Re: [PATCH v8 3/5] mfd: hi655x: Add MFD driver for hi655x
On 19 April 2016 at 14:53, Lee Jones <lee.jo...@linaro.org> wrote: > On Tue, 19 Apr 2016, Guodong Xu wrote: > >> On 13 April 2016 at 08:51, Chen Feng <puck.c...@hisilicon.com> wrote: >> > >> > >> > >> > -------- Forwarded Message ---- >> > Subject: Re: [PATCH v8 3/5] mfd: hi655x: Add MFD driver for hi655x >> > Date: Mon, 11 Apr 2016 11:41:06 +0100 >> > From: Lee Jones <lee.jo...@linaro.org> >> > To: Chen Feng <puck.c...@hisilicon.com> >> > CC: lgirdw...@gmail.com, broo...@kernel.org, linux-kernel@vger.kernel.org, >> > w...@huawei.com, kong.kongxin...@hisilicon.com, haojian.zhu...@linaro.org, >> > suzhuangl...@hisilicon.com, dan.z...@hisilicon.com >> > >> > On Sun, 14 Feb 2016, Chen Feng wrote: >> > >> > > Add PMIC MFD driver to support hisilicon hi665x. >> > > >> > > Signed-off-by: Chen Feng <puck.c...@hisilicon.com> >> > > Signed-off-by: Fei Wang <w...@huawei.com> >> > > Signed-off-by: Xinwei Kong <kong.kongxin...@hisilicon.com> >> > > Reviewed-by: Haojian Zhuang <haojian.zhu...@linaro.org> >> > > Acked-by: Lee Jones <lee.jo...@linaro.org> >> > > --- >> > > drivers/mfd/Kconfig | 10 +++ >> > > drivers/mfd/Makefile| 1 + >> > > drivers/mfd/hi655x-pmic.c | 162 >> > > >> > > include/linux/mfd/hi655x-pmic.h | 55 ++ >> > > 4 files changed, 228 insertions(+) >> > > create mode 100644 drivers/mfd/hi655x-pmic.c >> > > create mode 100644 include/linux/mfd/hi655x-pmic.h >> > >> > Applied, thanks. >> >> Hi, Lee, Mark >> >> I still didn't see this patch in linux-next (next-20160418) since your >> replied "Applied". Are you expecting anything else? Dependencies? >> >> I didn't see any unsolved review comments actually. But if there is, >> please let us know, so I can send an updated version. > > When I applied your patch, I also added ~40 other patches. I haven't > yet got around to editing and pushing them all to -next. I will put > some time aside this morning in order to complete the push. Thanks, Lee. -Guodong > >> > > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig >> > > index 9ca66de..5b1c091 100644 >> > > --- a/drivers/mfd/Kconfig >> > > +++ b/drivers/mfd/Kconfig >> > > @@ -284,6 +284,16 @@ config MFD_HI6421_PMIC >> > > menus in order to enable them. >> > > We communicate with the Hi6421 via memory-mapped I/O. >> > > >> > > +config MFD_HI655X_PMIC >> > > + tristate "HiSilicon Hi655X series PMU/Codec IC" >> > > + depends on ARCH_HISI || COMPILE_TEST >> > > + depends on OF >> > > + select MFD_CORE >> > > + select REGMAP_MMIO >> > > + select REGMAP_IRQ >> > > + help >> > > + Select this option to enable Hisilicon hi655x series pmic driver. >> > > + >> > > config HTC_EGPIO >> > > bool "HTC EGPIO support" >> > > depends on GPIOLIB && ARM >> > > diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile >> > > index 0f230a6..1e166c1 100644 >> > > --- a/drivers/mfd/Makefile >> > > +++ b/drivers/mfd/Makefile >> > > @@ -190,6 +190,7 @@ obj-$(CONFIG_MFD_STW481X) += stw481x.o >> > > obj-$(CONFIG_MFD_IPAQ_MICRO) += ipaq-micro.o >> > > obj-$(CONFIG_MFD_MENF21BMC) += menf21bmc.o >> > > obj-$(CONFIG_MFD_HI6421_PMIC)+= hi6421-pmic-core.o >> > > +obj-$(CONFIG_MFD_HI655X_PMIC) += hi655x-pmic.o >> > > obj-$(CONFIG_MFD_DLN2) += dln2.o >> > > obj-$(CONFIG_MFD_RT5033) += rt5033.o >> > > obj-$(CONFIG_MFD_SKY81452) += sky81452.o >> > > diff --git a/drivers/mfd/hi655x-pmic.c b/drivers/mfd/hi655x-pmic.c >> > > new file mode 100644 >> > > index 000..05ddc78 >> > > --- /dev/null >> > > +++ b/drivers/mfd/hi655x-pmic.c >> > > @@ -0,0 +1,162 @@ >> > > +/* >> > > + * Device driver for MFD hi655x PMIC >> > > + * >> > > + * Copyright (c) 2016 Hisilicon. >> > > + * >> > > + * Authors: >> > > + * Chen Feng <puck.c...@hisilicon.com> >> > > + * Fei Wang <w...@huawei.com> &
Re: Re: [PATCH v8 3/5] mfd: hi655x: Add MFD driver for hi655x
On 19 April 2016 at 14:53, Lee Jones wrote: > On Tue, 19 Apr 2016, Guodong Xu wrote: > >> On 13 April 2016 at 08:51, Chen Feng wrote: >> > >> > >> > >> > -------- Forwarded Message ---- >> > Subject: Re: [PATCH v8 3/5] mfd: hi655x: Add MFD driver for hi655x >> > Date: Mon, 11 Apr 2016 11:41:06 +0100 >> > From: Lee Jones >> > To: Chen Feng >> > CC: lgirdw...@gmail.com, broo...@kernel.org, linux-kernel@vger.kernel.org, >> > w...@huawei.com, kong.kongxin...@hisilicon.com, haojian.zhu...@linaro.org, >> > suzhuangl...@hisilicon.com, dan.z...@hisilicon.com >> > >> > On Sun, 14 Feb 2016, Chen Feng wrote: >> > >> > > Add PMIC MFD driver to support hisilicon hi665x. >> > > >> > > Signed-off-by: Chen Feng >> > > Signed-off-by: Fei Wang >> > > Signed-off-by: Xinwei Kong >> > > Reviewed-by: Haojian Zhuang >> > > Acked-by: Lee Jones >> > > --- >> > > drivers/mfd/Kconfig | 10 +++ >> > > drivers/mfd/Makefile| 1 + >> > > drivers/mfd/hi655x-pmic.c | 162 >> > > >> > > include/linux/mfd/hi655x-pmic.h | 55 ++ >> > > 4 files changed, 228 insertions(+) >> > > create mode 100644 drivers/mfd/hi655x-pmic.c >> > > create mode 100644 include/linux/mfd/hi655x-pmic.h >> > >> > Applied, thanks. >> >> Hi, Lee, Mark >> >> I still didn't see this patch in linux-next (next-20160418) since your >> replied "Applied". Are you expecting anything else? Dependencies? >> >> I didn't see any unsolved review comments actually. But if there is, >> please let us know, so I can send an updated version. > > When I applied your patch, I also added ~40 other patches. I haven't > yet got around to editing and pushing them all to -next. I will put > some time aside this morning in order to complete the push. Thanks, Lee. -Guodong > >> > > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig >> > > index 9ca66de..5b1c091 100644 >> > > --- a/drivers/mfd/Kconfig >> > > +++ b/drivers/mfd/Kconfig >> > > @@ -284,6 +284,16 @@ config MFD_HI6421_PMIC >> > > menus in order to enable them. >> > > We communicate with the Hi6421 via memory-mapped I/O. >> > > >> > > +config MFD_HI655X_PMIC >> > > + tristate "HiSilicon Hi655X series PMU/Codec IC" >> > > + depends on ARCH_HISI || COMPILE_TEST >> > > + depends on OF >> > > + select MFD_CORE >> > > + select REGMAP_MMIO >> > > + select REGMAP_IRQ >> > > + help >> > > + Select this option to enable Hisilicon hi655x series pmic driver. >> > > + >> > > config HTC_EGPIO >> > > bool "HTC EGPIO support" >> > > depends on GPIOLIB && ARM >> > > diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile >> > > index 0f230a6..1e166c1 100644 >> > > --- a/drivers/mfd/Makefile >> > > +++ b/drivers/mfd/Makefile >> > > @@ -190,6 +190,7 @@ obj-$(CONFIG_MFD_STW481X) += stw481x.o >> > > obj-$(CONFIG_MFD_IPAQ_MICRO) += ipaq-micro.o >> > > obj-$(CONFIG_MFD_MENF21BMC) += menf21bmc.o >> > > obj-$(CONFIG_MFD_HI6421_PMIC)+= hi6421-pmic-core.o >> > > +obj-$(CONFIG_MFD_HI655X_PMIC) += hi655x-pmic.o >> > > obj-$(CONFIG_MFD_DLN2) += dln2.o >> > > obj-$(CONFIG_MFD_RT5033) += rt5033.o >> > > obj-$(CONFIG_MFD_SKY81452) += sky81452.o >> > > diff --git a/drivers/mfd/hi655x-pmic.c b/drivers/mfd/hi655x-pmic.c >> > > new file mode 100644 >> > > index 000..05ddc78 >> > > --- /dev/null >> > > +++ b/drivers/mfd/hi655x-pmic.c >> > > @@ -0,0 +1,162 @@ >> > > +/* >> > > + * Device driver for MFD hi655x PMIC >> > > + * >> > > + * Copyright (c) 2016 Hisilicon. >> > > + * >> > > + * Authors: >> > > + * Chen Feng >> > > + * Fei Wang >> > > + * >> > > + * This program is free software; you can redistribute it and/or modify >> > > + * it under the terms of the GNU General Public License version 2 as >> > > + * published by the Free Software Foundation. >> > > + */ >> > > +
Re: Re: [PATCH v8 3/5] mfd: hi655x: Add MFD driver for hi655x
On Tue, 19 Apr 2016, Guodong Xu wrote: > On 13 April 2016 at 08:51, Chen Feng <puck.c...@hisilicon.com> wrote: > > > > > > > > Forwarded Message -------- > > Subject: Re: [PATCH v8 3/5] mfd: hi655x: Add MFD driver for hi655x > > Date: Mon, 11 Apr 2016 11:41:06 +0100 > > From: Lee Jones <lee.jo...@linaro.org> > > To: Chen Feng <puck.c...@hisilicon.com> > > CC: lgirdw...@gmail.com, broo...@kernel.org, linux-kernel@vger.kernel.org, > > w...@huawei.com, kong.kongxin...@hisilicon.com, haojian.zhu...@linaro.org, > > suzhuangl...@hisilicon.com, dan.z...@hisilicon.com > > > > On Sun, 14 Feb 2016, Chen Feng wrote: > > > > > Add PMIC MFD driver to support hisilicon hi665x. > > > > > > Signed-off-by: Chen Feng <puck.c...@hisilicon.com> > > > Signed-off-by: Fei Wang <w...@huawei.com> > > > Signed-off-by: Xinwei Kong <kong.kongxin...@hisilicon.com> > > > Reviewed-by: Haojian Zhuang <haojian.zhu...@linaro.org> > > > Acked-by: Lee Jones <lee.jo...@linaro.org> > > > --- > > > drivers/mfd/Kconfig | 10 +++ > > > drivers/mfd/Makefile| 1 + > > > drivers/mfd/hi655x-pmic.c | 162 > > > > > > include/linux/mfd/hi655x-pmic.h | 55 ++ > > > 4 files changed, 228 insertions(+) > > > create mode 100644 drivers/mfd/hi655x-pmic.c > > > create mode 100644 include/linux/mfd/hi655x-pmic.h > > > > Applied, thanks. > > Hi, Lee, Mark > > I still didn't see this patch in linux-next (next-20160418) since your > replied "Applied". Are you expecting anything else? Dependencies? > > I didn't see any unsolved review comments actually. But if there is, > please let us know, so I can send an updated version. When I applied your patch, I also added ~40 other patches. I haven't yet got around to editing and pushing them all to -next. I will put some time aside this morning in order to complete the push. > > > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > > > index 9ca66de..5b1c091 100644 > > > --- a/drivers/mfd/Kconfig > > > +++ b/drivers/mfd/Kconfig > > > @@ -284,6 +284,16 @@ config MFD_HI6421_PMIC > > > menus in order to enable them. > > > We communicate with the Hi6421 via memory-mapped I/O. > > > > > > +config MFD_HI655X_PMIC > > > + tristate "HiSilicon Hi655X series PMU/Codec IC" > > > + depends on ARCH_HISI || COMPILE_TEST > > > + depends on OF > > > + select MFD_CORE > > > + select REGMAP_MMIO > > > + select REGMAP_IRQ > > > + help > > > + Select this option to enable Hisilicon hi655x series pmic driver. > > > + > > > config HTC_EGPIO > > > bool "HTC EGPIO support" > > > depends on GPIOLIB && ARM > > > diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile > > > index 0f230a6..1e166c1 100644 > > > --- a/drivers/mfd/Makefile > > > +++ b/drivers/mfd/Makefile > > > @@ -190,6 +190,7 @@ obj-$(CONFIG_MFD_STW481X) += stw481x.o > > > obj-$(CONFIG_MFD_IPAQ_MICRO) += ipaq-micro.o > > > obj-$(CONFIG_MFD_MENF21BMC) += menf21bmc.o > > > obj-$(CONFIG_MFD_HI6421_PMIC)+= hi6421-pmic-core.o > > > +obj-$(CONFIG_MFD_HI655X_PMIC) += hi655x-pmic.o > > > obj-$(CONFIG_MFD_DLN2) += dln2.o > > > obj-$(CONFIG_MFD_RT5033) += rt5033.o > > > obj-$(CONFIG_MFD_SKY81452) += sky81452.o > > > diff --git a/drivers/mfd/hi655x-pmic.c b/drivers/mfd/hi655x-pmic.c > > > new file mode 100644 > > > index 000..05ddc78 > > > --- /dev/null > > > +++ b/drivers/mfd/hi655x-pmic.c > > > @@ -0,0 +1,162 @@ > > > +/* > > > + * Device driver for MFD hi655x PMIC > > > + * > > > + * Copyright (c) 2016 Hisilicon. > > > + * > > > + * Authors: > > > + * Chen Feng <puck.c...@hisilicon.com> > > > + * Fei Wang <w...@huawei.com> > > > + * > > > + * This program is free software; you can redistribute it and/or modify > > > + * it under the terms of the GNU General Public License version 2 as > > > + * published by the Free Software Foundation. > > > + */ > > > + > > > +#include > > > +#include > > > +#include > > > +#include > > > +#include > > > +#include > > > +#include >
Re: Re: [PATCH v8 3/5] mfd: hi655x: Add MFD driver for hi655x
On Tue, 19 Apr 2016, Guodong Xu wrote:
> On 13 April 2016 at 08:51, Chen Feng wrote:
> >
> >
> >
> > Forwarded Message ----
> > Subject: Re: [PATCH v8 3/5] mfd: hi655x: Add MFD driver for hi655x
> > Date: Mon, 11 Apr 2016 11:41:06 +0100
> > From: Lee Jones
> > To: Chen Feng
> > CC: lgirdw...@gmail.com, broo...@kernel.org, linux-kernel@vger.kernel.org,
> > w...@huawei.com, kong.kongxin...@hisilicon.com, haojian.zhu...@linaro.org,
> > suzhuangl...@hisilicon.com, dan.z...@hisilicon.com
> >
> > On Sun, 14 Feb 2016, Chen Feng wrote:
> >
> > > Add PMIC MFD driver to support hisilicon hi665x.
> > >
> > > Signed-off-by: Chen Feng
> > > Signed-off-by: Fei Wang
> > > Signed-off-by: Xinwei Kong
> > > Reviewed-by: Haojian Zhuang
> > > Acked-by: Lee Jones
> > > ---
> > > drivers/mfd/Kconfig | 10 +++
> > > drivers/mfd/Makefile| 1 +
> > > drivers/mfd/hi655x-pmic.c | 162
> > >
> > > include/linux/mfd/hi655x-pmic.h | 55 ++
> > > 4 files changed, 228 insertions(+)
> > > create mode 100644 drivers/mfd/hi655x-pmic.c
> > > create mode 100644 include/linux/mfd/hi655x-pmic.h
> >
> > Applied, thanks.
>
> Hi, Lee, Mark
>
> I still didn't see this patch in linux-next (next-20160418) since your
> replied "Applied". Are you expecting anything else? Dependencies?
>
> I didn't see any unsolved review comments actually. But if there is,
> please let us know, so I can send an updated version.
When I applied your patch, I also added ~40 other patches. I haven't
yet got around to editing and pushing them all to -next. I will put
some time aside this morning in order to complete the push.
> > > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> > > index 9ca66de..5b1c091 100644
> > > --- a/drivers/mfd/Kconfig
> > > +++ b/drivers/mfd/Kconfig
> > > @@ -284,6 +284,16 @@ config MFD_HI6421_PMIC
> > > menus in order to enable them.
> > > We communicate with the Hi6421 via memory-mapped I/O.
> > >
> > > +config MFD_HI655X_PMIC
> > > + tristate "HiSilicon Hi655X series PMU/Codec IC"
> > > + depends on ARCH_HISI || COMPILE_TEST
> > > + depends on OF
> > > + select MFD_CORE
> > > + select REGMAP_MMIO
> > > + select REGMAP_IRQ
> > > + help
> > > + Select this option to enable Hisilicon hi655x series pmic driver.
> > > +
> > > config HTC_EGPIO
> > > bool "HTC EGPIO support"
> > > depends on GPIOLIB && ARM
> > > diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile
> > > index 0f230a6..1e166c1 100644
> > > --- a/drivers/mfd/Makefile
> > > +++ b/drivers/mfd/Makefile
> > > @@ -190,6 +190,7 @@ obj-$(CONFIG_MFD_STW481X) += stw481x.o
> > > obj-$(CONFIG_MFD_IPAQ_MICRO) += ipaq-micro.o
> > > obj-$(CONFIG_MFD_MENF21BMC) += menf21bmc.o
> > > obj-$(CONFIG_MFD_HI6421_PMIC)+= hi6421-pmic-core.o
> > > +obj-$(CONFIG_MFD_HI655X_PMIC) += hi655x-pmic.o
> > > obj-$(CONFIG_MFD_DLN2) += dln2.o
> > > obj-$(CONFIG_MFD_RT5033) += rt5033.o
> > > obj-$(CONFIG_MFD_SKY81452) += sky81452.o
> > > diff --git a/drivers/mfd/hi655x-pmic.c b/drivers/mfd/hi655x-pmic.c
> > > new file mode 100644
> > > index 000..05ddc78
> > > --- /dev/null
> > > +++ b/drivers/mfd/hi655x-pmic.c
> > > @@ -0,0 +1,162 @@
> > > +/*
> > > + * Device driver for MFD hi655x PMIC
> > > + *
> > > + * Copyright (c) 2016 Hisilicon.
> > > + *
> > > + * Authors:
> > > + * Chen Feng
> > > + * Fei Wang
> > > + *
> > > + * This program is free software; you can redistribute it and/or modify
> > > + * it under the terms of the GNU General Public License version 2 as
> > > + * published by the Free Software Foundation.
> > > + */
> > > +
> > > +#include
> > > +#include
> > > +#include
> > > +#include
> > > +#include
> > > +#include
> > > +#include
> > > +#include
> > > +#include
> > > +#include
> > > +#include
> > > +
> > > +static const struct mfd_cell hi655x_pmic_devs[] = {
> > > + { .name = "hi655x-regulator", },
> > > +};
> > > +
&g
Re: Re: [PATCH v8 3/5] mfd: hi655x: Add MFD driver for hi655x
On 13 April 2016 at 08:51, Chen Feng <puck.c...@hisilicon.com> wrote:
>
>
>
> Forwarded Message --------
> Subject: Re: [PATCH v8 3/5] mfd: hi655x: Add MFD driver for hi655x
> Date: Mon, 11 Apr 2016 11:41:06 +0100
> From: Lee Jones <lee.jo...@linaro.org>
> To: Chen Feng <puck.c...@hisilicon.com>
> CC: lgirdw...@gmail.com, broo...@kernel.org, linux-kernel@vger.kernel.org,
> w...@huawei.com, kong.kongxin...@hisilicon.com, haojian.zhu...@linaro.org,
> suzhuangl...@hisilicon.com, dan.z...@hisilicon.com
>
> On Sun, 14 Feb 2016, Chen Feng wrote:
>
> > Add PMIC MFD driver to support hisilicon hi665x.
> >
> > Signed-off-by: Chen Feng <puck.c...@hisilicon.com>
> > Signed-off-by: Fei Wang <w...@huawei.com>
> > Signed-off-by: Xinwei Kong <kong.kongxin...@hisilicon.com>
> > Reviewed-by: Haojian Zhuang <haojian.zhu...@linaro.org>
> > Acked-by: Lee Jones <lee.jo...@linaro.org>
> > ---
> > drivers/mfd/Kconfig | 10 +++
> > drivers/mfd/Makefile| 1 +
> > drivers/mfd/hi655x-pmic.c | 162
> >
> > include/linux/mfd/hi655x-pmic.h | 55 ++
> > 4 files changed, 228 insertions(+)
> > create mode 100644 drivers/mfd/hi655x-pmic.c
> > create mode 100644 include/linux/mfd/hi655x-pmic.h
>
> Applied, thanks.
Hi, Lee, Mark
I still didn't see this patch in linux-next (next-20160418) since your
replied "Applied". Are you expecting anything else? Dependencies?
I didn't see any unsolved review comments actually. But if there is,
please let us know, so I can send an updated version.
-Guodong
>
> > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> > index 9ca66de..5b1c091 100644
> > --- a/drivers/mfd/Kconfig
> > +++ b/drivers/mfd/Kconfig
> > @@ -284,6 +284,16 @@ config MFD_HI6421_PMIC
> > menus in order to enable them.
> > We communicate with the Hi6421 via memory-mapped I/O.
> >
> > +config MFD_HI655X_PMIC
> > + tristate "HiSilicon Hi655X series PMU/Codec IC"
> > + depends on ARCH_HISI || COMPILE_TEST
> > + depends on OF
> > + select MFD_CORE
> > + select REGMAP_MMIO
> > + select REGMAP_IRQ
> > + help
> > + Select this option to enable Hisilicon hi655x series pmic driver.
> > +
> > config HTC_EGPIO
> > bool "HTC EGPIO support"
> > depends on GPIOLIB && ARM
> > diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile
> > index 0f230a6..1e166c1 100644
> > --- a/drivers/mfd/Makefile
> > +++ b/drivers/mfd/Makefile
> > @@ -190,6 +190,7 @@ obj-$(CONFIG_MFD_STW481X) += stw481x.o
> > obj-$(CONFIG_MFD_IPAQ_MICRO) += ipaq-micro.o
> > obj-$(CONFIG_MFD_MENF21BMC) += menf21bmc.o
> > obj-$(CONFIG_MFD_HI6421_PMIC)+= hi6421-pmic-core.o
> > +obj-$(CONFIG_MFD_HI655X_PMIC) += hi655x-pmic.o
> > obj-$(CONFIG_MFD_DLN2) += dln2.o
> > obj-$(CONFIG_MFD_RT5033) += rt5033.o
> > obj-$(CONFIG_MFD_SKY81452) += sky81452.o
> > diff --git a/drivers/mfd/hi655x-pmic.c b/drivers/mfd/hi655x-pmic.c
> > new file mode 100644
> > index 000..05ddc78
> > --- /dev/null
> > +++ b/drivers/mfd/hi655x-pmic.c
> > @@ -0,0 +1,162 @@
> > +/*
> > + * Device driver for MFD hi655x PMIC
> > + *
> > + * Copyright (c) 2016 Hisilicon.
> > + *
> > + * Authors:
> > + * Chen Feng <puck.c...@hisilicon.com>
> > + * Fei Wang <w...@huawei.com>
> > + *
> > + * This program is free software; you can redistribute it and/or modify
> > + * it under the terms of the GNU General Public License version 2 as
> > + * published by the Free Software Foundation.
> > + */
> > +
> > +#include
> > +#include
> > +#include
> > +#include
> > +#include
> > +#include
> > +#include
> > +#include
> > +#include
> > +#include
> > +#include
> > +
> > +static const struct mfd_cell hi655x_pmic_devs[] = {
> > + { .name = "hi655x-regulator", },
> > +};
> > +
> > +static const struct regmap_irq hi655x_irqs[] = {
> > + { .reg_offset = 0, .mask = OTMP_D1R_INT },
> > + { .reg_offset = 0, .mask = VSYS_2P5_R_INT },
> > + { .reg_offset = 0, .mask = VSYS_UV_D3R_INT },
> > + { .reg_offset = 0, .mask = VSYS_6P0_D200UR_INT },
> > + { .reg_offset = 0, .mask = PWRON_D4SR_INT },
> > + { .reg_offset = 0, .mask = PWRON_D20F_INT },
> > + { .reg_offset = 0, .mask = PWRON_D20R_INT },
&g
Re: Re: [PATCH v8 3/5] mfd: hi655x: Add MFD driver for hi655x
On 13 April 2016 at 08:51, Chen Feng wrote:
>
>
>
> Forwarded Message
> Subject: Re: [PATCH v8 3/5] mfd: hi655x: Add MFD driver for hi655x
> Date: Mon, 11 Apr 2016 11:41:06 +0100
> From: Lee Jones
> To: Chen Feng
> CC: lgirdw...@gmail.com, broo...@kernel.org, linux-kernel@vger.kernel.org,
> w...@huawei.com, kong.kongxin...@hisilicon.com, haojian.zhu...@linaro.org,
> suzhuangl...@hisilicon.com, dan.z...@hisilicon.com
>
> On Sun, 14 Feb 2016, Chen Feng wrote:
>
> > Add PMIC MFD driver to support hisilicon hi665x.
> >
> > Signed-off-by: Chen Feng
> > Signed-off-by: Fei Wang
> > Signed-off-by: Xinwei Kong
> > Reviewed-by: Haojian Zhuang
> > Acked-by: Lee Jones
> > ---
> > drivers/mfd/Kconfig | 10 +++
> > drivers/mfd/Makefile| 1 +
> > drivers/mfd/hi655x-pmic.c | 162
> >
> > include/linux/mfd/hi655x-pmic.h | 55 ++
> > 4 files changed, 228 insertions(+)
> > create mode 100644 drivers/mfd/hi655x-pmic.c
> > create mode 100644 include/linux/mfd/hi655x-pmic.h
>
> Applied, thanks.
Hi, Lee, Mark
I still didn't see this patch in linux-next (next-20160418) since your
replied "Applied". Are you expecting anything else? Dependencies?
I didn't see any unsolved review comments actually. But if there is,
please let us know, so I can send an updated version.
-Guodong
>
> > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> > index 9ca66de..5b1c091 100644
> > --- a/drivers/mfd/Kconfig
> > +++ b/drivers/mfd/Kconfig
> > @@ -284,6 +284,16 @@ config MFD_HI6421_PMIC
> > menus in order to enable them.
> > We communicate with the Hi6421 via memory-mapped I/O.
> >
> > +config MFD_HI655X_PMIC
> > + tristate "HiSilicon Hi655X series PMU/Codec IC"
> > + depends on ARCH_HISI || COMPILE_TEST
> > + depends on OF
> > + select MFD_CORE
> > + select REGMAP_MMIO
> > + select REGMAP_IRQ
> > + help
> > + Select this option to enable Hisilicon hi655x series pmic driver.
> > +
> > config HTC_EGPIO
> > bool "HTC EGPIO support"
> > depends on GPIOLIB && ARM
> > diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile
> > index 0f230a6..1e166c1 100644
> > --- a/drivers/mfd/Makefile
> > +++ b/drivers/mfd/Makefile
> > @@ -190,6 +190,7 @@ obj-$(CONFIG_MFD_STW481X) += stw481x.o
> > obj-$(CONFIG_MFD_IPAQ_MICRO) += ipaq-micro.o
> > obj-$(CONFIG_MFD_MENF21BMC) += menf21bmc.o
> > obj-$(CONFIG_MFD_HI6421_PMIC)+= hi6421-pmic-core.o
> > +obj-$(CONFIG_MFD_HI655X_PMIC) += hi655x-pmic.o
> > obj-$(CONFIG_MFD_DLN2) += dln2.o
> > obj-$(CONFIG_MFD_RT5033) += rt5033.o
> > obj-$(CONFIG_MFD_SKY81452) += sky81452.o
> > diff --git a/drivers/mfd/hi655x-pmic.c b/drivers/mfd/hi655x-pmic.c
> > new file mode 100644
> > index 000..05ddc78
> > --- /dev/null
> > +++ b/drivers/mfd/hi655x-pmic.c
> > @@ -0,0 +1,162 @@
> > +/*
> > + * Device driver for MFD hi655x PMIC
> > + *
> > + * Copyright (c) 2016 Hisilicon.
> > + *
> > + * Authors:
> > + * Chen Feng
> > + * Fei Wang
> > + *
> > + * This program is free software; you can redistribute it and/or modify
> > + * it under the terms of the GNU General Public License version 2 as
> > + * published by the Free Software Foundation.
> > + */
> > +
> > +#include
> > +#include
> > +#include
> > +#include
> > +#include
> > +#include
> > +#include
> > +#include
> > +#include
> > +#include
> > +#include
> > +
> > +static const struct mfd_cell hi655x_pmic_devs[] = {
> > + { .name = "hi655x-regulator", },
> > +};
> > +
> > +static const struct regmap_irq hi655x_irqs[] = {
> > + { .reg_offset = 0, .mask = OTMP_D1R_INT },
> > + { .reg_offset = 0, .mask = VSYS_2P5_R_INT },
> > + { .reg_offset = 0, .mask = VSYS_UV_D3R_INT },
> > + { .reg_offset = 0, .mask = VSYS_6P0_D200UR_INT },
> > + { .reg_offset = 0, .mask = PWRON_D4SR_INT },
> > + { .reg_offset = 0, .mask = PWRON_D20F_INT },
> > + { .reg_offset = 0, .mask = PWRON_D20R_INT },
> > + { .reg_offset = 0, .mask = RESERVE_INT },
> > +};
> > +
> > +static const struct regmap_irq_chip hi655x_irq_chip = {
> > + .name = "hi655x-pmic",
> > + .irqs = hi655x_irqs,
> > + .num_regs = 1,
> > + .num_irqs = AR
