Re: decruft the early init / initrd / initramfs code v2
On Thu, Jul 16, 2020 at 05:57:12PM +0200, Guoqing Jiang wrote: > On 7/15/20 8:51 AM, Christoph Hellwig wrote: >> On Tue, Jul 14, 2020 at 12:34:45PM -0700, Linus Torvalds wrote: > I just cloned the tree, seems there is compile issue that you need to > resolve. Fixed and force pushed.
Re: decruft the early init / initrd / initramfs code v2
On 7/15/20 8:51 AM, Christoph Hellwig wrote: On Tue, Jul 14, 2020 at 12:34:45PM -0700, Linus Torvalds wrote: On Tue, Jul 14, 2020 at 12:06 PM Christoph Hellwig wrote: this series starts to move the early init code away from requiring KERNEL_DS to be implicitly set during early startup. It does so by first removing legacy unused cruft, and the switches away the code from struct file based APIs to our more usual in-kernel APIs. Looks good to me, with the added note on the utimes cruft too as a further cleanup (separate patch). So you can add my acked-by. I _would_ like the md parts to get a few more acks. I see the one from Song Liu, anybody else in md land willing to go through those patches? They were the bulk of it, and the least obvious to me because I don't know that code at all? Song is the maintainer. Neil is the only person I could think of that also knows the old md code pretty well. Guoqing has contributed a lot lately, but the code touched here is rather historic (and not used very much at all these days as people use modular md and initramfѕ based detection). Hi Christoph, I just cloned the tree, seems there is compile issue that you need to resolve. hch-misc$ make -j8 DESCEND objtool CALL scripts/atomic/check-atomics.sh CALL scripts/checksyscalls.sh CHK include/generated/compile.h CC drivers/md/md.o CC drivers/md/md-bitmap.o CC drivers/md/md-autodetect.o AR drivers/perf/built-in.a CC drivers/md/dm.o AR drivers/hwtracing/intel_th/built-in.a CC drivers/nvmem/core.o drivers/md/md.c:7809:45: error: static declaration of ‘md_fops’ follows non-static declaration static const struct block_device_operations md_fops = ^~~ drivers/md/md.c:329:38: note: previous declaration of ‘md_fops’ was here const struct block_device_operations md_fops; ^~~ scripts/Makefile.build:280: recipe for target 'drivers/md/md.o' failed make[2]: *** [drivers/md/md.o] Error 1 make[2]: *** Waiting for unfinished jobs And for the changes of md, feel free to add my Acked-by if it could help. Thanks, Guoqing
Re: decruft the early init / initrd / initramfs code v2
On Tue, Jul 14, 2020 at 12:34:45PM -0700, Linus Torvalds wrote: > On Tue, Jul 14, 2020 at 12:06 PM Christoph Hellwig wrote: > > > > this series starts to move the early init code away from requiring > > KERNEL_DS to be implicitly set during early startup. It does so by > > first removing legacy unused cruft, and the switches away the code > > from struct file based APIs to our more usual in-kernel APIs. > > Looks good to me, with the added note on the utimes cruft too as a > further cleanup (separate patch). > > So you can add my acked-by. > > I _would_ like the md parts to get a few more acks. I see the one from > Song Liu, anybody else in md land willing to go through those patches? > They were the bulk of it, and the least obvious to me because I don't > know that code at all? Song is the maintainer. Neil is the only person I could think of that also knows the old md code pretty well. Guoqing has contributed a lot lately, but the code touched here is rather historic (and not used very much at all these days as people use modular md and initramfѕ based detection).
Re: decruft the early init / initrd / initramfs code v2
On Tue, Jul 14, 2020 at 12:06 PM Christoph Hellwig wrote: > > this series starts to move the early init code away from requiring > KERNEL_DS to be implicitly set during early startup. It does so by > first removing legacy unused cruft, and the switches away the code > from struct file based APIs to our more usual in-kernel APIs. Looks good to me, with the added note on the utimes cruft too as a further cleanup (separate patch). So you can add my acked-by. I _would_ like the md parts to get a few more acks. I see the one from Song Liu, anybody else in md land willing to go through those patches? They were the bulk of it, and the least obvious to me because I don't know that code at all? Linus
Re: decruft the early init / initrd / initramfs code v2
On Mon, Jul 13, 2020 at 11:41 PM Christoph Hellwig wrote: > > On Thu, Jul 09, 2020 at 04:32:07PM -0700, h...@zytor.com wrote: > > On July 9, 2020 8:17:57 AM PDT, Christoph Hellwig wrote: > > >Hi all, > > > > > >this series starts to move the early init code away from requiring > > >KERNEL_DS to be implicitly set during early startup. It does so by > > >first removing legacy unused cruft, and the switches away the code > > >from struct file based APIs to our more usual in-kernel APIs. > > > > > >There is no really good tree for this, so if there are no objections > > >I'd like to set up a new one for linux-next. > > > > > > > > >Git tree: > > > > > >git://git.infradead.org/users/hch/misc.git init-user-pointers > > > > > >Gitweb: > > > > > >http://git.infradead.org/users/hch/misc.git/shortlog/refs/heads/init-user-pointers > > > > > > > > >Changes since v1: > > > - add a patch to deprecated "classic" initrd support > > > > > >Diffstat: > > > b/arch/arm/kernel/atags_parse.c |2 > > > b/arch/sh/kernel/setup.c|2 > > > b/arch/sparc/kernel/setup_32.c |2 > > > b/arch/sparc/kernel/setup_64.c |2 > > > b/arch/x86/kernel/setup.c |2 > > > b/drivers/md/Makefile |3 > > >b/drivers/md/md-autodetect.c| 239 > > >++-- > > > b/drivers/md/md.c | 34 + > > > b/drivers/md/md.h | 10 + > > > b/fs/file.c |7 - > > > b/fs/open.c | 18 +-- > > > b/fs/read_write.c |2 > > > b/fs/readdir.c | 11 - > > > b/include/linux/initrd.h|6 - > > > b/include/linux/raid/detect.h |8 + > > > b/include/linux/syscalls.h | 16 -- > > > b/init/Makefile |1 > > > b/init/do_mounts.c | 70 +-- > > > b/init/do_mounts.h | 21 --- > > > b/init/do_mounts_initrd.c | 13 -- > > > b/init/do_mounts_rd.c | 102 +++-- > > > b/init/initramfs.c | 103 + > > > b/init/main.c | 16 +- > > > include/linux/raid/md_u.h | 13 -- > > > 24 files changed, 251 insertions(+), 452 deletions(-) > > > > I guess I could say something here... ;) > > Like adding an ACK? :) For the md bits: Acked-by: Song Liu Thanks!
Re: decruft the early init / initrd / initramfs code v2
On Thu, Jul 09, 2020 at 04:32:07PM -0700, h...@zytor.com wrote: > On July 9, 2020 8:17:57 AM PDT, Christoph Hellwig wrote: > >Hi all, > > > >this series starts to move the early init code away from requiring > >KERNEL_DS to be implicitly set during early startup. It does so by > >first removing legacy unused cruft, and the switches away the code > >from struct file based APIs to our more usual in-kernel APIs. > > > >There is no really good tree for this, so if there are no objections > >I'd like to set up a new one for linux-next. > > > > > >Git tree: > > > >git://git.infradead.org/users/hch/misc.git init-user-pointers > > > >Gitweb: > > > >http://git.infradead.org/users/hch/misc.git/shortlog/refs/heads/init-user-pointers > > > > > >Changes since v1: > > - add a patch to deprecated "classic" initrd support > > > >Diffstat: > > b/arch/arm/kernel/atags_parse.c |2 > > b/arch/sh/kernel/setup.c|2 > > b/arch/sparc/kernel/setup_32.c |2 > > b/arch/sparc/kernel/setup_64.c |2 > > b/arch/x86/kernel/setup.c |2 > > b/drivers/md/Makefile |3 > >b/drivers/md/md-autodetect.c| 239 > >++-- > > b/drivers/md/md.c | 34 + > > b/drivers/md/md.h | 10 + > > b/fs/file.c |7 - > > b/fs/open.c | 18 +-- > > b/fs/read_write.c |2 > > b/fs/readdir.c | 11 - > > b/include/linux/initrd.h|6 - > > b/include/linux/raid/detect.h |8 + > > b/include/linux/syscalls.h | 16 -- > > b/init/Makefile |1 > > b/init/do_mounts.c | 70 +-- > > b/init/do_mounts.h | 21 --- > > b/init/do_mounts_initrd.c | 13 -- > > b/init/do_mounts_rd.c | 102 +++-- > > b/init/initramfs.c | 103 + > > b/init/main.c | 16 +- > > include/linux/raid/md_u.h | 13 -- > > 24 files changed, 251 insertions(+), 452 deletions(-) > > I guess I could say something here... ;) Like adding an ACK? :)
Re: decruft the early init / initrd / initramfs code v2
On July 9, 2020 8:17:57 AM PDT, Christoph Hellwig wrote: >Hi all, > >this series starts to move the early init code away from requiring >KERNEL_DS to be implicitly set during early startup. It does so by >first removing legacy unused cruft, and the switches away the code >from struct file based APIs to our more usual in-kernel APIs. > >There is no really good tree for this, so if there are no objections >I'd like to set up a new one for linux-next. > > >Git tree: > >git://git.infradead.org/users/hch/misc.git init-user-pointers > >Gitweb: > >http://git.infradead.org/users/hch/misc.git/shortlog/refs/heads/init-user-pointers > > >Changes since v1: > - add a patch to deprecated "classic" initrd support > >Diffstat: > b/arch/arm/kernel/atags_parse.c |2 > b/arch/sh/kernel/setup.c|2 > b/arch/sparc/kernel/setup_32.c |2 > b/arch/sparc/kernel/setup_64.c |2 > b/arch/x86/kernel/setup.c |2 > b/drivers/md/Makefile |3 >b/drivers/md/md-autodetect.c| 239 >++-- > b/drivers/md/md.c | 34 + > b/drivers/md/md.h | 10 + > b/fs/file.c |7 - > b/fs/open.c | 18 +-- > b/fs/read_write.c |2 > b/fs/readdir.c | 11 - > b/include/linux/initrd.h|6 - > b/include/linux/raid/detect.h |8 + > b/include/linux/syscalls.h | 16 -- > b/init/Makefile |1 > b/init/do_mounts.c | 70 +-- > b/init/do_mounts.h | 21 --- > b/init/do_mounts_initrd.c | 13 -- > b/init/do_mounts_rd.c | 102 +++-- > b/init/initramfs.c | 103 + > b/init/main.c | 16 +- > include/linux/raid/md_u.h | 13 -- > 24 files changed, 251 insertions(+), 452 deletions(-) I guess I could say something here... ;) -- Sent from my Android device with K-9 Mail. Please excuse my brevity.
Re: decruft the early init / initrd / initramfs code v2
On Thu, Jul 9, 2020 at 8:18 AM Christoph Hellwig wrote: > > There is no really good tree for this, so if there are no objections > I'd like to set up a new one for linux-next. All looks good to me. I had a wish-list change for one of the patches that I sent a reply out for, but even without that it's clearly an improvement. Of course, I just looked at the patches for sanity, rather than testing anything. Maybe there's something stupid in there. But it all looked straightforward. So Ack from me, with the hope that you'd do that "vfs_chown/chmod()" thing. Linus
