Re: gem csum breakage with 018c5bba (Handle CHECKSUM_COMPLETE more adequately ...)
From: Alexander Graf Date: Fri, 22 Nov 2013 19:08:16 +0100 > With current Linus' master tree my ibook started emitting a lot of > annoying csum calculation warnings. I've bisected it down to the > commit seen in the subject line, but I suppose the real problem lies > somewhere a lot deeper and only gets revealed thanks to the more > clever checksum logic applied now. > > Any ideas how to dig further into this? Ok, I'm going to revert this commit, for several reasons. In addition to the problem you are running into, it just occurred to me that if the __pskb_trim() call fails, we'll leave a corrupted checksum in the SKB. Thanks for your report. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: gem csum breakage with 018c5bba (Handle CHECKSUM_COMPLETE more adequately ...)
From: Alexander Graf ag...@suse.de Date: Fri, 22 Nov 2013 19:08:16 +0100 With current Linus' master tree my ibook started emitting a lot of annoying csum calculation warnings. I've bisected it down to the commit seen in the subject line, but I suppose the real problem lies somewhere a lot deeper and only gets revealed thanks to the more clever checksum logic applied now. Any ideas how to dig further into this? Ok, I'm going to revert this commit, for several reasons. In addition to the problem you are running into, it just occurred to me that if the __pskb_trim() call fails, we'll leave a corrupted checksum in the SKB. Thanks for your report. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: gem csum breakage with 018c5bba (Handle CHECKSUM_COMPLETE more adequately ...)
On Fri, Nov 22, 2013 at 07:08:16PM +0100, Alexander Graf wrote: > Hi, > > With current Linus' master tree my ibook started emitting a lot of annoying > csum calculation warnings. I've bisected it down to the commit seen in the > subject line, but I suppose the real problem lies somewhere a lot deeper and > only gets revealed thanks to the more clever checksum logic applied now. > > Any ideas how to dig further into this? Sorry, I don't have any docs on this device. Perhaps Dave has the docs which can tell us what RXDCTRL_TCPCSUM actually returns? I assume it returns the correct checksum ending at the IP packet boundary and only goes wrong when extra padding exists. Hmm, I suppose the question then is what exactly does it do if the packet isn't an IP packet? Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: gem csum breakage with 018c5bba (Handle CHECKSUM_COMPLETE more adequately ...)
On Fri, Nov 22, 2013 at 07:08:16PM +0100, Alexander Graf wrote: Hi, With current Linus' master tree my ibook started emitting a lot of annoying csum calculation warnings. I've bisected it down to the commit seen in the subject line, but I suppose the real problem lies somewhere a lot deeper and only gets revealed thanks to the more clever checksum logic applied now. Any ideas how to dig further into this? Sorry, I don't have any docs on this device. Perhaps Dave has the docs which can tell us what RXDCTRL_TCPCSUM actually returns? I assume it returns the correct checksum ending at the IP packet boundary and only goes wrong when extra padding exists. Hmm, I suppose the question then is what exactly does it do if the packet isn't an IP packet? Thanks, -- Email: Herbert Xu herb...@gondor.apana.org.au Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
