Re: linux-next: build failure after merge of the final tree (tty tree related)
Hi all, On Mon, 28 Oct 2013 09:33:33 -0700 Greg KH wrote: > > On Mon, Oct 28, 2013 at 09:05:37AM -0700, Sören Brinkmann wrote: > > On Tue, Oct 29, 2013 at 01:33:17AM +1100, Stephen Rothwell wrote: > > > > > > After merging the final tree, today's linux-next build (powerpc > > > allyesconfig) failed like this: > > > > > > drivers/tty/serial/xilinx_uartps.c: In function 'xuartps_clk_notifier_cb': > > > drivers/tty/serial/xilinx_uartps.c:436:7: error: 'PRE_RATE_CHANGE' > > > undeclared (first use in this function) > > > case PRE_RATE_CHANGE: > > >^ > > > drivers/tty/serial/xilinx_uartps.c:436:7: note: each undeclared > > > identifier is reported only once for each function it appears in > > > drivers/tty/serial/xilinx_uartps.c:446:36: error: dereferencing pointer > > > to incomplete type > > >if (!xuartps_calc_baud_divs(ndata->new_rate, xuartps->baud, > > > ^ > > > > > > Caused by commits in the tty tree. > > > > > > I have left this broken for today. > > > > I already sent a series to Greg which should fix the x86 build of the > > tty tree. I think he didn't apply those patches yet. > > Yes, I have them, sorry, been traveling, will get to them later today... As a temporary work around, I will disable xilinx_uartps in linux-next today. -- Cheers, Stephen Rothwells...@canb.auug.org.au pgpUUQgedT3UU.pgp Description: PGP signature
Re: linux-next: build failure after merge of the final tree (tty tree related)
Hi all, On Mon, 28 Oct 2013 09:33:33 -0700 Greg KH g...@kroah.com wrote: On Mon, Oct 28, 2013 at 09:05:37AM -0700, Sören Brinkmann wrote: On Tue, Oct 29, 2013 at 01:33:17AM +1100, Stephen Rothwell wrote: After merging the final tree, today's linux-next build (powerpc allyesconfig) failed like this: drivers/tty/serial/xilinx_uartps.c: In function 'xuartps_clk_notifier_cb': drivers/tty/serial/xilinx_uartps.c:436:7: error: 'PRE_RATE_CHANGE' undeclared (first use in this function) case PRE_RATE_CHANGE: ^ drivers/tty/serial/xilinx_uartps.c:436:7: note: each undeclared identifier is reported only once for each function it appears in drivers/tty/serial/xilinx_uartps.c:446:36: error: dereferencing pointer to incomplete type if (!xuartps_calc_baud_divs(ndata-new_rate, xuartps-baud, ^ Caused by commits in the tty tree. I have left this broken for today. I already sent a series to Greg which should fix the x86 build of the tty tree. I think he didn't apply those patches yet. Yes, I have them, sorry, been traveling, will get to them later today... As a temporary work around, I will disable xilinx_uartps in linux-next today. -- Cheers, Stephen Rothwells...@canb.auug.org.au pgpUUQgedT3UU.pgp Description: PGP signature
Re: linux-next: build failure after merge of the final tree (tty tree related)
On Mon, Oct 28, 2013 at 09:05:37AM -0700, Sören Brinkmann wrote: > On Tue, Oct 29, 2013 at 01:33:17AM +1100, Stephen Rothwell wrote: > > Hi all, > > > > After merging the final tree, today's linux-next build (powerpc > > allyesconfig) failed like this: > > > > drivers/tty/serial/xilinx_uartps.c: In function 'xuartps_clk_notifier_cb': > > drivers/tty/serial/xilinx_uartps.c:436:7: error: 'PRE_RATE_CHANGE' > > undeclared (first use in this function) > > case PRE_RATE_CHANGE: > >^ > > drivers/tty/serial/xilinx_uartps.c:436:7: note: each undeclared identifier > > is reported only once for each function it appears in > > drivers/tty/serial/xilinx_uartps.c:446:36: error: dereferencing pointer to > > incomplete type > >if (!xuartps_calc_baud_divs(ndata->new_rate, xuartps->baud, > > ^ > > drivers/tty/serial/xilinx_uartps.c:461:7: error: 'POST_RATE_CHANGE' > > undeclared (first use in this function) > > case POST_RATE_CHANGE: > >^ > > drivers/tty/serial/xilinx_uartps.c:470:24: error: dereferencing pointer to > > incomplete type > >port->uartclk = ndata->new_rate; > > ^ > > drivers/tty/serial/xilinx_uartps.c:475:7: error: 'ABORT_RATE_CHANGE' > > undeclared (first use in this function) > > case ABORT_RATE_CHANGE: > >^ > > drivers/tty/serial/xilinx_uartps.c: In function 'xuartps_probe': > > drivers/tty/serial/xilinx_uartps.c:1385:2: error: implicit declaration of > > function 'clk_notifier_register' [-Werror=implicit-function-declaration] > > if (clk_notifier_register(xuartps_data->refclk, > > ^ > > drivers/tty/serial/xilinx_uartps.c:1418:2: error: implicit declaration of > > function 'clk_notifier_unregister' [-Werror=implicit-function-declaration] > > clk_notifier_unregister(xuartps_data->refclk, > > ^ > > > > Caused by commits in the tty tree. > > > > I have left this broken for today. > > I already sent a series to Greg which should fix the x86 build of the > tty tree. I think he didn't apply those patches yet. Yes, I have them, sorry, been traveling, will get to them later today... thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the final tree (tty tree related)
On Tue, Oct 29, 2013 at 01:33:17AM +1100, Stephen Rothwell wrote: > Hi all, > > After merging the final tree, today's linux-next build (powerpc > allyesconfig) failed like this: > > drivers/tty/serial/xilinx_uartps.c: In function 'xuartps_clk_notifier_cb': > drivers/tty/serial/xilinx_uartps.c:436:7: error: 'PRE_RATE_CHANGE' undeclared > (first use in this function) > case PRE_RATE_CHANGE: >^ > drivers/tty/serial/xilinx_uartps.c:436:7: note: each undeclared identifier is > reported only once for each function it appears in > drivers/tty/serial/xilinx_uartps.c:446:36: error: dereferencing pointer to > incomplete type >if (!xuartps_calc_baud_divs(ndata->new_rate, xuartps->baud, > ^ > drivers/tty/serial/xilinx_uartps.c:461:7: error: 'POST_RATE_CHANGE' > undeclared (first use in this function) > case POST_RATE_CHANGE: >^ > drivers/tty/serial/xilinx_uartps.c:470:24: error: dereferencing pointer to > incomplete type >port->uartclk = ndata->new_rate; > ^ > drivers/tty/serial/xilinx_uartps.c:475:7: error: 'ABORT_RATE_CHANGE' > undeclared (first use in this function) > case ABORT_RATE_CHANGE: >^ > drivers/tty/serial/xilinx_uartps.c: In function 'xuartps_probe': > drivers/tty/serial/xilinx_uartps.c:1385:2: error: implicit declaration of > function 'clk_notifier_register' [-Werror=implicit-function-declaration] > if (clk_notifier_register(xuartps_data->refclk, > ^ > drivers/tty/serial/xilinx_uartps.c:1418:2: error: implicit declaration of > function 'clk_notifier_unregister' [-Werror=implicit-function-declaration] > clk_notifier_unregister(xuartps_data->refclk, > ^ > > Caused by commits in the tty tree. > > I have left this broken for today. I already sent a series to Greg which should fix the x86 build of the tty tree. I think he didn't apply those patches yet. Sören -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the final tree (tty tree related)
On 10/28/2013 03:33 PM, Stephen Rothwell wrote: > Hi all, > > After merging the final tree, today's linux-next build (powerpc > allyesconfig) failed like this: > > drivers/tty/serial/xilinx_uartps.c: In function 'xuartps_clk_notifier_cb': > drivers/tty/serial/xilinx_uartps.c:436:7: error: 'PRE_RATE_CHANGE' undeclared > (first use in this function) > case PRE_RATE_CHANGE: >^ > drivers/tty/serial/xilinx_uartps.c:436:7: note: each undeclared identifier is > reported only once for each function it appears in > drivers/tty/serial/xilinx_uartps.c:446:36: error: dereferencing pointer to > incomplete type >if (!xuartps_calc_baud_divs(ndata->new_rate, xuartps->baud, > ^ > drivers/tty/serial/xilinx_uartps.c:461:7: error: 'POST_RATE_CHANGE' > undeclared (first use in this function) > case POST_RATE_CHANGE: >^ > drivers/tty/serial/xilinx_uartps.c:470:24: error: dereferencing pointer to > incomplete type >port->uartclk = ndata->new_rate; > ^ > drivers/tty/serial/xilinx_uartps.c:475:7: error: 'ABORT_RATE_CHANGE' > undeclared (first use in this function) > case ABORT_RATE_CHANGE: >^ > drivers/tty/serial/xilinx_uartps.c: In function 'xuartps_probe': > drivers/tty/serial/xilinx_uartps.c:1385:2: error: implicit declaration of > function 'clk_notifier_register' [-Werror=implicit-function-declaration] > if (clk_notifier_register(xuartps_data->refclk, > ^ > drivers/tty/serial/xilinx_uartps.c:1418:2: error: implicit declaration of > function 'clk_notifier_unregister' [-Werror=implicit-function-declaration] > clk_notifier_unregister(xuartps_data->refclk, > ^ > > Caused by commits in the tty tree. > > I have left this broken for today. > Soren: Please correct me if I am wrong. But this should be fixed by: "[PATCH 3/3] tty: xuartps: Fix build error when COMMON_CLK is not set" Thanks, Michal -- Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/ Maintainer of Linux kernel - Xilinx Zynq ARM architecture Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform signature.asc Description: OpenPGP digital signature
Re: linux-next: build failure after merge of the final tree (tty tree related)
On 10/28/2013 03:33 PM, Stephen Rothwell wrote: Hi all, After merging the final tree, today's linux-next build (powerpc allyesconfig) failed like this: drivers/tty/serial/xilinx_uartps.c: In function 'xuartps_clk_notifier_cb': drivers/tty/serial/xilinx_uartps.c:436:7: error: 'PRE_RATE_CHANGE' undeclared (first use in this function) case PRE_RATE_CHANGE: ^ drivers/tty/serial/xilinx_uartps.c:436:7: note: each undeclared identifier is reported only once for each function it appears in drivers/tty/serial/xilinx_uartps.c:446:36: error: dereferencing pointer to incomplete type if (!xuartps_calc_baud_divs(ndata-new_rate, xuartps-baud, ^ drivers/tty/serial/xilinx_uartps.c:461:7: error: 'POST_RATE_CHANGE' undeclared (first use in this function) case POST_RATE_CHANGE: ^ drivers/tty/serial/xilinx_uartps.c:470:24: error: dereferencing pointer to incomplete type port-uartclk = ndata-new_rate; ^ drivers/tty/serial/xilinx_uartps.c:475:7: error: 'ABORT_RATE_CHANGE' undeclared (first use in this function) case ABORT_RATE_CHANGE: ^ drivers/tty/serial/xilinx_uartps.c: In function 'xuartps_probe': drivers/tty/serial/xilinx_uartps.c:1385:2: error: implicit declaration of function 'clk_notifier_register' [-Werror=implicit-function-declaration] if (clk_notifier_register(xuartps_data-refclk, ^ drivers/tty/serial/xilinx_uartps.c:1418:2: error: implicit declaration of function 'clk_notifier_unregister' [-Werror=implicit-function-declaration] clk_notifier_unregister(xuartps_data-refclk, ^ Caused by commits in the tty tree. I have left this broken for today. Soren: Please correct me if I am wrong. But this should be fixed by: [PATCH 3/3] tty: xuartps: Fix build error when COMMON_CLK is not set Thanks, Michal -- Michal Simek, Ing. (M.Eng), OpenPGP - KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/ Maintainer of Linux kernel - Xilinx Zynq ARM architecture Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform signature.asc Description: OpenPGP digital signature
Re: linux-next: build failure after merge of the final tree (tty tree related)
On Tue, Oct 29, 2013 at 01:33:17AM +1100, Stephen Rothwell wrote: Hi all, After merging the final tree, today's linux-next build (powerpc allyesconfig) failed like this: drivers/tty/serial/xilinx_uartps.c: In function 'xuartps_clk_notifier_cb': drivers/tty/serial/xilinx_uartps.c:436:7: error: 'PRE_RATE_CHANGE' undeclared (first use in this function) case PRE_RATE_CHANGE: ^ drivers/tty/serial/xilinx_uartps.c:436:7: note: each undeclared identifier is reported only once for each function it appears in drivers/tty/serial/xilinx_uartps.c:446:36: error: dereferencing pointer to incomplete type if (!xuartps_calc_baud_divs(ndata-new_rate, xuartps-baud, ^ drivers/tty/serial/xilinx_uartps.c:461:7: error: 'POST_RATE_CHANGE' undeclared (first use in this function) case POST_RATE_CHANGE: ^ drivers/tty/serial/xilinx_uartps.c:470:24: error: dereferencing pointer to incomplete type port-uartclk = ndata-new_rate; ^ drivers/tty/serial/xilinx_uartps.c:475:7: error: 'ABORT_RATE_CHANGE' undeclared (first use in this function) case ABORT_RATE_CHANGE: ^ drivers/tty/serial/xilinx_uartps.c: In function 'xuartps_probe': drivers/tty/serial/xilinx_uartps.c:1385:2: error: implicit declaration of function 'clk_notifier_register' [-Werror=implicit-function-declaration] if (clk_notifier_register(xuartps_data-refclk, ^ drivers/tty/serial/xilinx_uartps.c:1418:2: error: implicit declaration of function 'clk_notifier_unregister' [-Werror=implicit-function-declaration] clk_notifier_unregister(xuartps_data-refclk, ^ Caused by commits in the tty tree. I have left this broken for today. I already sent a series to Greg which should fix the x86 build of the tty tree. I think he didn't apply those patches yet. Sören -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the final tree (tty tree related)
On Mon, Oct 28, 2013 at 09:05:37AM -0700, Sören Brinkmann wrote: On Tue, Oct 29, 2013 at 01:33:17AM +1100, Stephen Rothwell wrote: Hi all, After merging the final tree, today's linux-next build (powerpc allyesconfig) failed like this: drivers/tty/serial/xilinx_uartps.c: In function 'xuartps_clk_notifier_cb': drivers/tty/serial/xilinx_uartps.c:436:7: error: 'PRE_RATE_CHANGE' undeclared (first use in this function) case PRE_RATE_CHANGE: ^ drivers/tty/serial/xilinx_uartps.c:436:7: note: each undeclared identifier is reported only once for each function it appears in drivers/tty/serial/xilinx_uartps.c:446:36: error: dereferencing pointer to incomplete type if (!xuartps_calc_baud_divs(ndata-new_rate, xuartps-baud, ^ drivers/tty/serial/xilinx_uartps.c:461:7: error: 'POST_RATE_CHANGE' undeclared (first use in this function) case POST_RATE_CHANGE: ^ drivers/tty/serial/xilinx_uartps.c:470:24: error: dereferencing pointer to incomplete type port-uartclk = ndata-new_rate; ^ drivers/tty/serial/xilinx_uartps.c:475:7: error: 'ABORT_RATE_CHANGE' undeclared (first use in this function) case ABORT_RATE_CHANGE: ^ drivers/tty/serial/xilinx_uartps.c: In function 'xuartps_probe': drivers/tty/serial/xilinx_uartps.c:1385:2: error: implicit declaration of function 'clk_notifier_register' [-Werror=implicit-function-declaration] if (clk_notifier_register(xuartps_data-refclk, ^ drivers/tty/serial/xilinx_uartps.c:1418:2: error: implicit declaration of function 'clk_notifier_unregister' [-Werror=implicit-function-declaration] clk_notifier_unregister(xuartps_data-refclk, ^ Caused by commits in the tty tree. I have left this broken for today. I already sent a series to Greg which should fix the x86 build of the tty tree. I think he didn't apply those patches yet. Yes, I have them, sorry, been traveling, will get to them later today... thanks, greg k-h -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the final tree (tty tree related)
On Fri, Sep 27, 2013 at 06:21:17PM +1000, Stephen Rothwell wrote:
> Hi all,
>
> After merging the final tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
>
> drivers/tty/serial/8250/8250_dw.c: In function 'dw8250_probe':
> drivers/tty/serial/8250/8250_dw.c:341:3: error: too many arguments to
> function 'dw8250_probe_acpi'
>err = dw8250_probe_acpi(, data);
>^
> drivers/tty/serial/8250/8250_dw.c:281:19: note: declared here
> static inline int dw8250_probe_acpi(struct uart_8250_port *up)
>^
>
> Caused by commit fe95855539fd ("serial: 8250_dw: don't limit DMA support
> to ACPI") from the tty tree.
>
> I have reverted that commit for today (and commit 7fb8c56c7fa0 ("serial:
> 8250_dw: provide a filter for DMA channel detection") that depends on it).
Should now be fixed, thanks.
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the final tree (tty tree related)
On Fri, Sep 27, 2013 at 06:21:17PM +1000, Stephen Rothwell wrote: Hi all, After merging the final tree, today's linux-next build (powerpc allyesconfig) failed like this: drivers/tty/serial/8250/8250_dw.c: In function 'dw8250_probe': drivers/tty/serial/8250/8250_dw.c:341:3: error: too many arguments to function 'dw8250_probe_acpi' err = dw8250_probe_acpi(uart, data); ^ drivers/tty/serial/8250/8250_dw.c:281:19: note: declared here static inline int dw8250_probe_acpi(struct uart_8250_port *up) ^ Caused by commit fe95855539fd (serial: 8250_dw: don't limit DMA support to ACPI) from the tty tree. I have reverted that commit for today (and commit 7fb8c56c7fa0 (serial: 8250_dw: provide a filter for DMA channel detection) that depends on it). Should now be fixed, thanks. greg k-h -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the final tree (tty tree related)
On Thu, 2012-12-13 at 15:38 -0800, Greg KH wrote: > Ugh, can someone send me a patch to forward to Linus to fix this please? > Steven, how about fixing the problem properly? Yeah, ugh, I should have sent the fix earlier :-( I've just been hammering at bugs for the people that pay me ;-) OK, I'll whip up a patch that should at least fix the issue for the time being. -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the final tree (tty tree related)
On Fri, Dec 14, 2012 at 10:32:56AM +1100, Stephen Rothwell wrote:
> Hi Steve, Greg,
>
> On Tue, 27 Nov 2012 10:05:30 +1100 Stephen Rothwell
> wrote:
> >
> > On Mon, 26 Nov 2012 09:35:12 -0500 Steven Rostedt
> > wrote:
> > >
> > > On Tue, 2012-11-27 at 00:49 +1100, Stephen Rothwell wrote:
> > > >
> > > > After merging the final tree, today's linux-next build (powerpc
> > > > allyesconfig) failed like this:
> > > >
> > > > In file included from drivers/staging/sb105x/sb_pci_mp.c:1:0:
> > > > drivers/staging/sb105x/sb_pci_mp.h:22:25: fatal error: asm/segment.h:
> > > > No such file or directory
> > >
> > > I haven't tested this with any other arch than x86. That said, what
> > > about this instead:
> > >
> > > > Caused by commit 68a81291ff66 ("staging: Add SystemBase Multi-2/PCI
> > > > driver").
> > > >
> > > > I have disabled this driver with this patch:
> > > >
> > > > From: Stephen Rothwell
> > > > Date: Tue, 27 Nov 2012 00:45:07 +1100
> > > > Subject: [PATCH] disable the SB105X driver
> > > >
> > > > Signed-off-by: Stephen Rothwell
> > > > ---
> > > > drivers/staging/sb105x/Kconfig |1 +
> > > > 1 file changed, 1 insertion(+)
> > > >
> > > > diff --git a/drivers/staging/sb105x/Kconfig
> > > > b/drivers/staging/sb105x/Kconfig
> > > > index ac87c5e..c957e32 100644
> > > > --- a/drivers/staging/sb105x/Kconfig
> > > > +++ b/drivers/staging/sb105x/Kconfig
> > > > @@ -2,6 +2,7 @@ config SB105X
> > > > tristate "SystemBase PCI Multiport UART"
> > > > select SERIAL_CORE
> > > > depends on PCI
> > > > + depends on BROKEN
> > >
> > > depends on X86
> > >
> > > You can add my SOB if you want. I don't care either way.
> >
> > Please just send a (tested) patch to Greg.
>
> This now breaks Linus' tree .
Ugh, can someone send me a patch to forward to Linus to fix this please?
Steven, how about fixing the problem properly?
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the final tree (tty tree related)
Hi Steve, Greg,
On Tue, 27 Nov 2012 10:05:30 +1100 Stephen Rothwell
wrote:
>
> On Mon, 26 Nov 2012 09:35:12 -0500 Steven Rostedt wrote:
> >
> > On Tue, 2012-11-27 at 00:49 +1100, Stephen Rothwell wrote:
> > >
> > > After merging the final tree, today's linux-next build (powerpc
> > > allyesconfig) failed like this:
> > >
> > > In file included from drivers/staging/sb105x/sb_pci_mp.c:1:0:
> > > drivers/staging/sb105x/sb_pci_mp.h:22:25: fatal error: asm/segment.h: No
> > > such file or directory
> >
> > I haven't tested this with any other arch than x86. That said, what
> > about this instead:
> >
> > > Caused by commit 68a81291ff66 ("staging: Add SystemBase Multi-2/PCI
> > > driver").
> > >
> > > I have disabled this driver with this patch:
> > >
> > > From: Stephen Rothwell
> > > Date: Tue, 27 Nov 2012 00:45:07 +1100
> > > Subject: [PATCH] disable the SB105X driver
> > >
> > > Signed-off-by: Stephen Rothwell
> > > ---
> > > drivers/staging/sb105x/Kconfig |1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/drivers/staging/sb105x/Kconfig
> > > b/drivers/staging/sb105x/Kconfig
> > > index ac87c5e..c957e32 100644
> > > --- a/drivers/staging/sb105x/Kconfig
> > > +++ b/drivers/staging/sb105x/Kconfig
> > > @@ -2,6 +2,7 @@ config SB105X
> > > tristate "SystemBase PCI Multiport UART"
> > > select SERIAL_CORE
> > > depends on PCI
> > > + depends on BROKEN
> >
> > depends on X86
> >
> > You can add my SOB if you want. I don't care either way.
>
> Please just send a (tested) patch to Greg.
This now breaks Linus' tree .
--
Cheers,
Stephen Rothwells...@canb.auug.org.au
pgpqGi7jZSvlc.pgp
Description: PGP signature
Re: linux-next: build failure after merge of the final tree (tty tree related)
Hi Steve, Greg, On Tue, 27 Nov 2012 10:05:30 +1100 Stephen Rothwell s...@canb.auug.org.au wrote: On Mon, 26 Nov 2012 09:35:12 -0500 Steven Rostedt srost...@redhat.com wrote: On Tue, 2012-11-27 at 00:49 +1100, Stephen Rothwell wrote: After merging the final tree, today's linux-next build (powerpc allyesconfig) failed like this: In file included from drivers/staging/sb105x/sb_pci_mp.c:1:0: drivers/staging/sb105x/sb_pci_mp.h:22:25: fatal error: asm/segment.h: No such file or directory I haven't tested this with any other arch than x86. That said, what about this instead: Caused by commit 68a81291ff66 (staging: Add SystemBase Multi-2/PCI driver). I have disabled this driver with this patch: From: Stephen Rothwell s...@canb.auug.org.au Date: Tue, 27 Nov 2012 00:45:07 +1100 Subject: [PATCH] disable the SB105X driver Signed-off-by: Stephen Rothwell s...@canb.auug.org.au --- drivers/staging/sb105x/Kconfig |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/sb105x/Kconfig b/drivers/staging/sb105x/Kconfig index ac87c5e..c957e32 100644 --- a/drivers/staging/sb105x/Kconfig +++ b/drivers/staging/sb105x/Kconfig @@ -2,6 +2,7 @@ config SB105X tristate SystemBase PCI Multiport UART select SERIAL_CORE depends on PCI + depends on BROKEN depends on X86 You can add my SOB if you want. I don't care either way. Please just send a (tested) patch to Greg. This now breaks Linus' tree . -- Cheers, Stephen Rothwells...@canb.auug.org.au pgpqGi7jZSvlc.pgp Description: PGP signature
Re: linux-next: build failure after merge of the final tree (tty tree related)
On Fri, Dec 14, 2012 at 10:32:56AM +1100, Stephen Rothwell wrote: Hi Steve, Greg, On Tue, 27 Nov 2012 10:05:30 +1100 Stephen Rothwell s...@canb.auug.org.au wrote: On Mon, 26 Nov 2012 09:35:12 -0500 Steven Rostedt srost...@redhat.com wrote: On Tue, 2012-11-27 at 00:49 +1100, Stephen Rothwell wrote: After merging the final tree, today's linux-next build (powerpc allyesconfig) failed like this: In file included from drivers/staging/sb105x/sb_pci_mp.c:1:0: drivers/staging/sb105x/sb_pci_mp.h:22:25: fatal error: asm/segment.h: No such file or directory I haven't tested this with any other arch than x86. That said, what about this instead: Caused by commit 68a81291ff66 (staging: Add SystemBase Multi-2/PCI driver). I have disabled this driver with this patch: From: Stephen Rothwell s...@canb.auug.org.au Date: Tue, 27 Nov 2012 00:45:07 +1100 Subject: [PATCH] disable the SB105X driver Signed-off-by: Stephen Rothwell s...@canb.auug.org.au --- drivers/staging/sb105x/Kconfig |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/sb105x/Kconfig b/drivers/staging/sb105x/Kconfig index ac87c5e..c957e32 100644 --- a/drivers/staging/sb105x/Kconfig +++ b/drivers/staging/sb105x/Kconfig @@ -2,6 +2,7 @@ config SB105X tristate SystemBase PCI Multiport UART select SERIAL_CORE depends on PCI + depends on BROKEN depends on X86 You can add my SOB if you want. I don't care either way. Please just send a (tested) patch to Greg. This now breaks Linus' tree . Ugh, can someone send me a patch to forward to Linus to fix this please? Steven, how about fixing the problem properly? thanks, greg k-h -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the final tree (tty tree related)
On Thu, 2012-12-13 at 15:38 -0800, Greg KH wrote: Ugh, can someone send me a patch to forward to Linus to fix this please? Steven, how about fixing the problem properly? Yeah, ugh, I should have sent the fix earlier :-( I've just been hammering at bugs for the people that pay me ;-) OK, I'll whip up a patch that should at least fix the issue for the time being. -- Steve -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the final tree (tty tree related)
Hi Steve,
On Mon, 26 Nov 2012 09:35:12 -0500 Steven Rostedt wrote:
>
> On Tue, 2012-11-27 at 00:49 +1100, Stephen Rothwell wrote:
> >
> > After merging the final tree, today's linux-next build (powerpc
> > allyesconfig) failed like this:
> >
> > In file included from drivers/staging/sb105x/sb_pci_mp.c:1:0:
> > drivers/staging/sb105x/sb_pci_mp.h:22:25: fatal error: asm/segment.h: No
> > such file or directory
>
> I haven't tested this with any other arch than x86. That said, what
> about this instead:
>
> > Caused by commit 68a81291ff66 ("staging: Add SystemBase Multi-2/PCI
> > driver").
> >
> > I have disabled this driver with this patch:
> >
> > From: Stephen Rothwell
> > Date: Tue, 27 Nov 2012 00:45:07 +1100
> > Subject: [PATCH] disable the SB105X driver
> >
> > Signed-off-by: Stephen Rothwell
> > ---
> > drivers/staging/sb105x/Kconfig |1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/staging/sb105x/Kconfig b/drivers/staging/sb105x/Kconfig
> > index ac87c5e..c957e32 100644
> > --- a/drivers/staging/sb105x/Kconfig
> > +++ b/drivers/staging/sb105x/Kconfig
> > @@ -2,6 +2,7 @@ config SB105X
> > tristate "SystemBase PCI Multiport UART"
> > select SERIAL_CORE
> > depends on PCI
> > + depends on BROKEN
>
> depends on X86
>
> You can add my SOB if you want. I don't care either way.
Please just send a (tested) patch to Greg.
--
Cheers,
Stephen Rothwells...@canb.auug.org.au
pgpVyKzQGgGLV.pgp
Description: PGP signature
Re: linux-next: build failure after merge of the final tree (tty tree related)
On Tue, 2012-11-27 at 00:49 +1100, Stephen Rothwell wrote:
> Hi all,
>
> After merging the final tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
>
> In file included from drivers/staging/sb105x/sb_pci_mp.c:1:0:
> drivers/staging/sb105x/sb_pci_mp.h:22:25: fatal error: asm/segment.h: No such
> file or directory
I haven't tested this with any other arch than x86. That said, what
about this instead:
>
> Caused by commit 68a81291ff66 ("staging: Add SystemBase Multi-2/PCI
> driver").
>
> I have disabled this driver with this patch:
>
> From: Stephen Rothwell
> Date: Tue, 27 Nov 2012 00:45:07 +1100
> Subject: [PATCH] disable the SB105X driver
>
> Signed-off-by: Stephen Rothwell
> ---
> drivers/staging/sb105x/Kconfig |1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/sb105x/Kconfig b/drivers/staging/sb105x/Kconfig
> index ac87c5e..c957e32 100644
> --- a/drivers/staging/sb105x/Kconfig
> +++ b/drivers/staging/sb105x/Kconfig
> @@ -2,6 +2,7 @@ config SB105X
> tristate "SystemBase PCI Multiport UART"
> select SERIAL_CORE
> depends on PCI
> + depends on BROKEN
depends on X86
You can add my SOB if you want. I don't care either way.
-- Steve
> help
> A driver for the SystemBase Multi-2/PCI serial card
>
> --
> 1.7.10.280.gaa39
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the final tree (tty tree related)
On Tue, 2012-11-27 at 00:49 +1100, Stephen Rothwell wrote: Hi all, After merging the final tree, today's linux-next build (powerpc allyesconfig) failed like this: In file included from drivers/staging/sb105x/sb_pci_mp.c:1:0: drivers/staging/sb105x/sb_pci_mp.h:22:25: fatal error: asm/segment.h: No such file or directory I haven't tested this with any other arch than x86. That said, what about this instead: Caused by commit 68a81291ff66 (staging: Add SystemBase Multi-2/PCI driver). I have disabled this driver with this patch: From: Stephen Rothwell s...@canb.auug.org.au Date: Tue, 27 Nov 2012 00:45:07 +1100 Subject: [PATCH] disable the SB105X driver Signed-off-by: Stephen Rothwell s...@canb.auug.org.au --- drivers/staging/sb105x/Kconfig |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/sb105x/Kconfig b/drivers/staging/sb105x/Kconfig index ac87c5e..c957e32 100644 --- a/drivers/staging/sb105x/Kconfig +++ b/drivers/staging/sb105x/Kconfig @@ -2,6 +2,7 @@ config SB105X tristate SystemBase PCI Multiport UART select SERIAL_CORE depends on PCI + depends on BROKEN depends on X86 You can add my SOB if you want. I don't care either way. -- Steve help A driver for the SystemBase Multi-2/PCI serial card -- 1.7.10.280.gaa39 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the final tree (tty tree related)
Hi Steve, On Mon, 26 Nov 2012 09:35:12 -0500 Steven Rostedt srost...@redhat.com wrote: On Tue, 2012-11-27 at 00:49 +1100, Stephen Rothwell wrote: After merging the final tree, today's linux-next build (powerpc allyesconfig) failed like this: In file included from drivers/staging/sb105x/sb_pci_mp.c:1:0: drivers/staging/sb105x/sb_pci_mp.h:22:25: fatal error: asm/segment.h: No such file or directory I haven't tested this with any other arch than x86. That said, what about this instead: Caused by commit 68a81291ff66 (staging: Add SystemBase Multi-2/PCI driver). I have disabled this driver with this patch: From: Stephen Rothwell s...@canb.auug.org.au Date: Tue, 27 Nov 2012 00:45:07 +1100 Subject: [PATCH] disable the SB105X driver Signed-off-by: Stephen Rothwell s...@canb.auug.org.au --- drivers/staging/sb105x/Kconfig |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/sb105x/Kconfig b/drivers/staging/sb105x/Kconfig index ac87c5e..c957e32 100644 --- a/drivers/staging/sb105x/Kconfig +++ b/drivers/staging/sb105x/Kconfig @@ -2,6 +2,7 @@ config SB105X tristate SystemBase PCI Multiport UART select SERIAL_CORE depends on PCI + depends on BROKEN depends on X86 You can add my SOB if you want. I don't care either way. Please just send a (tested) patch to Greg. -- Cheers, Stephen Rothwells...@canb.auug.org.au pgpVyKzQGgGLV.pgp Description: PGP signature
Re: linux-next: build failure after merge of the final tree (tty tree related)
On Tue, Sep 25, 2012 at 12:36:44AM +1000, Stephen Rothwell wrote:
> Hi all,
>
> After merging the final tree, today's linux-next build (sparc64 defconfig)
> failed like this:
>
> fs/compat_ioctl.c:868:1: error: 'TIOCSRS485' undeclared here (not in a
> function)
> fs/compat_ioctl.c:869:1: error: 'TIOCGRS485' undeclared here (not in a
> function)
>
> Caused by commit 84c3b8486044 ("compat_ioctl: Add RS-485 IOCTLs to the
> list") from the tty tree.
Thanks, Jaeden just sent me a fix for this, I'll go apply it.
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the final tree (tty tree related)
On Tue, Sep 25, 2012 at 12:36:44AM +1000, Stephen Rothwell wrote: Hi all, After merging the final tree, today's linux-next build (sparc64 defconfig) failed like this: fs/compat_ioctl.c:868:1: error: 'TIOCSRS485' undeclared here (not in a function) fs/compat_ioctl.c:869:1: error: 'TIOCGRS485' undeclared here (not in a function) Caused by commit 84c3b8486044 (compat_ioctl: Add RS-485 IOCTLs to the list) from the tty tree. Thanks, Jaeden just sent me a fix for this, I'll go apply it. greg k-h -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the final tree (tty tree related)
> > if (serial->type->set_termios) {
> > - tty->termios->c_cflag = cflag;
> > - tty_termios_encode_baud_rate(tty->termios,
> > baud, baud);
> > + tty->termios.c_cflag = cflag;
> > +
> > tty_termios_encode_baud_rate(>termios, baud, baud);
> > memset(, 0, sizeof(struct ktermios));
> > serial->type->set_termios(tty, port, );
>
> Alan, any objection to this?
The fix looks correct to me.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the final tree (tty tree related)
Hi Greg, Alan,
On Fri, 20 Jul 2012 15:02:37 +1000 Stephen Rothwell
wrote:
>
> After merging the final tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
>
> drivers/usb/serial/console.c: In function 'usb_console_setup':
> drivers/usb/serial/console.c:168:16: error: invalid type argument of '->'
> (have 'struct ktermios')
> drivers/usb/serial/console.c:169:4: error: incompatible type for argument 1
> of 'tty_termios_encode_baud_rate'
> include/linux/tty.h:449:13: note: expected 'struct ktermios *' but argument
> is of type 'struct ktermios'
>
> Caused by commit adc8d746caa6 ("tty: move the termios object into the
> tty"). Hopefully this is the last of them.
>
> I have added the following fix patch for today:
>
> From: Stephen Rothwell
> Date: Fri, 20 Jul 2012 14:58:31 +1000
> Subject: [PATCH] tty: fix up usb serial console for termios change.
>
> fixes these errors:
>
> drivers/usb/serial/console.c: In function 'usb_console_setup':
> drivers/usb/serial/console.c:168:16: error: invalid type argument of '->'
> (have 'struct ktermios')
> drivers/usb/serial/console.c:169:4: error: incompatible type for argument 1
> of 'tty_termios_encode_baud_rate'
> include/linux/tty.h:449:13: note: expected 'struct ktermios *' but argument
> is of type 'struct ktermios'
>
> Signed-off-by: Stephen Rothwell
> ---
> drivers/usb/serial/console.c |4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/serial/console.c b/drivers/usb/serial/console.c
> index b9cca6d..9a56428 100644
> --- a/drivers/usb/serial/console.c
> +++ b/drivers/usb/serial/console.c
> @@ -165,8 +165,8 @@ static int usb_console_setup(struct console *co, char
> *options)
> }
>
> if (serial->type->set_termios) {
> - tty->termios->c_cflag = cflag;
> - tty_termios_encode_baud_rate(tty->termios, baud, baud);
> + tty->termios.c_cflag = cflag;
> + tty_termios_encode_baud_rate(>termios, baud, baud);
> memset(, 0, sizeof(struct ktermios));
> serial->type->set_termios(tty, port, );
>
> --
> 1.7.10.280.gaa39
Ping?
--
Cheers,
Stephen Rothwells...@canb.auug.org.au
pgpwcAIEAu9Qx.pgp
Description: PGP signature
Re: linux-next: build failure after merge of the final tree (tty tree related)
On Fri, Jul 20, 2012 at 03:02:37PM +1000, Stephen Rothwell wrote:
> Hi all,
>
> After merging the final tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
>
> drivers/usb/serial/console.c: In function 'usb_console_setup':
> drivers/usb/serial/console.c:168:16: error: invalid type argument of '->'
> (have 'struct ktermios')
> drivers/usb/serial/console.c:169:4: error: incompatible type for argument 1
> of 'tty_termios_encode_baud_rate'
> include/linux/tty.h:449:13: note: expected 'struct ktermios *' but argument
> is of type 'struct ktermios'
>
> Caused by commit adc8d746caa6 ("tty: move the termios object into the
> tty"). Hopefully this is the last of them.
>
> I have added the following fix patch for today:
>
> From: Stephen Rothwell
> Date: Fri, 20 Jul 2012 14:58:31 +1000
> Subject: [PATCH] tty: fix up usb serial console for termios change.
>
> fixes these errors:
>
> drivers/usb/serial/console.c: In function 'usb_console_setup':
> drivers/usb/serial/console.c:168:16: error: invalid type argument of '->'
> (have 'struct ktermios')
> drivers/usb/serial/console.c:169:4: error: incompatible type for argument 1
> of 'tty_termios_encode_baud_rate'
> include/linux/tty.h:449:13: note: expected 'struct ktermios *' but argument
> is of type 'struct ktermios'
>
> Signed-off-by: Stephen Rothwell
> ---
> drivers/usb/serial/console.c |4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/serial/console.c b/drivers/usb/serial/console.c
> index b9cca6d..9a56428 100644
> --- a/drivers/usb/serial/console.c
> +++ b/drivers/usb/serial/console.c
> @@ -165,8 +165,8 @@ static int usb_console_setup(struct console *co, char
> *options)
> }
>
> if (serial->type->set_termios) {
> - tty->termios->c_cflag = cflag;
> - tty_termios_encode_baud_rate(tty->termios, baud, baud);
> + tty->termios.c_cflag = cflag;
> + tty_termios_encode_baud_rate(>termios, baud, baud);
> memset(, 0, sizeof(struct ktermios));
> serial->type->set_termios(tty, port, );
>
Alan, any objection to this?
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the final tree (tty tree related)
On Fri, Jul 20, 2012 at 03:02:37PM +1000, Stephen Rothwell wrote:
Hi all,
After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:
drivers/usb/serial/console.c: In function 'usb_console_setup':
drivers/usb/serial/console.c:168:16: error: invalid type argument of '-'
(have 'struct ktermios')
drivers/usb/serial/console.c:169:4: error: incompatible type for argument 1
of 'tty_termios_encode_baud_rate'
include/linux/tty.h:449:13: note: expected 'struct ktermios *' but argument
is of type 'struct ktermios'
Caused by commit adc8d746caa6 (tty: move the termios object into the
tty). Hopefully this is the last of them.
I have added the following fix patch for today:
From: Stephen Rothwell s...@canb.auug.org.au
Date: Fri, 20 Jul 2012 14:58:31 +1000
Subject: [PATCH] tty: fix up usb serial console for termios change.
fixes these errors:
drivers/usb/serial/console.c: In function 'usb_console_setup':
drivers/usb/serial/console.c:168:16: error: invalid type argument of '-'
(have 'struct ktermios')
drivers/usb/serial/console.c:169:4: error: incompatible type for argument 1
of 'tty_termios_encode_baud_rate'
include/linux/tty.h:449:13: note: expected 'struct ktermios *' but argument
is of type 'struct ktermios'
Signed-off-by: Stephen Rothwell s...@canb.auug.org.au
---
drivers/usb/serial/console.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/serial/console.c b/drivers/usb/serial/console.c
index b9cca6d..9a56428 100644
--- a/drivers/usb/serial/console.c
+++ b/drivers/usb/serial/console.c
@@ -165,8 +165,8 @@ static int usb_console_setup(struct console *co, char
*options)
}
if (serial-type-set_termios) {
- tty-termios-c_cflag = cflag;
- tty_termios_encode_baud_rate(tty-termios, baud, baud);
+ tty-termios.c_cflag = cflag;
+ tty_termios_encode_baud_rate(tty-termios, baud, baud);
memset(dummy, 0, sizeof(struct ktermios));
serial-type-set_termios(tty, port, dummy);
Alan, any objection to this?
greg k-h
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the final tree (tty tree related)
Hi Greg, Alan,
On Fri, 20 Jul 2012 15:02:37 +1000 Stephen Rothwell s...@canb.auug.org.au
wrote:
After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:
drivers/usb/serial/console.c: In function 'usb_console_setup':
drivers/usb/serial/console.c:168:16: error: invalid type argument of '-'
(have 'struct ktermios')
drivers/usb/serial/console.c:169:4: error: incompatible type for argument 1
of 'tty_termios_encode_baud_rate'
include/linux/tty.h:449:13: note: expected 'struct ktermios *' but argument
is of type 'struct ktermios'
Caused by commit adc8d746caa6 (tty: move the termios object into the
tty). Hopefully this is the last of them.
I have added the following fix patch for today:
From: Stephen Rothwell s...@canb.auug.org.au
Date: Fri, 20 Jul 2012 14:58:31 +1000
Subject: [PATCH] tty: fix up usb serial console for termios change.
fixes these errors:
drivers/usb/serial/console.c: In function 'usb_console_setup':
drivers/usb/serial/console.c:168:16: error: invalid type argument of '-'
(have 'struct ktermios')
drivers/usb/serial/console.c:169:4: error: incompatible type for argument 1
of 'tty_termios_encode_baud_rate'
include/linux/tty.h:449:13: note: expected 'struct ktermios *' but argument
is of type 'struct ktermios'
Signed-off-by: Stephen Rothwell s...@canb.auug.org.au
---
drivers/usb/serial/console.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/serial/console.c b/drivers/usb/serial/console.c
index b9cca6d..9a56428 100644
--- a/drivers/usb/serial/console.c
+++ b/drivers/usb/serial/console.c
@@ -165,8 +165,8 @@ static int usb_console_setup(struct console *co, char
*options)
}
if (serial-type-set_termios) {
- tty-termios-c_cflag = cflag;
- tty_termios_encode_baud_rate(tty-termios, baud, baud);
+ tty-termios.c_cflag = cflag;
+ tty_termios_encode_baud_rate(tty-termios, baud, baud);
memset(dummy, 0, sizeof(struct ktermios));
serial-type-set_termios(tty, port, dummy);
--
1.7.10.280.gaa39
Ping?
--
Cheers,
Stephen Rothwells...@canb.auug.org.au
pgpwcAIEAu9Qx.pgp
Description: PGP signature
Re: linux-next: build failure after merge of the final tree (tty tree related)
if (serial-type-set_termios) {
- tty-termios-c_cflag = cflag;
- tty_termios_encode_baud_rate(tty-termios,
baud, baud);
+ tty-termios.c_cflag = cflag;
+
tty_termios_encode_baud_rate(tty-termios, baud, baud);
memset(dummy, 0, sizeof(struct ktermios));
serial-type-set_termios(tty, port, dummy);
Alan, any objection to this?
The fix looks correct to me.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
