Re: WARNING in _chaoskey_fill/usb_submit_urb
Hello, syzbot has tested the proposed patch but the reproducer still triggered crash: INFO: task hung in chaoskey_disconnect INFO: task kworker/0:0:5 blocked for more than 143 seconds. Not tainted 5.3.0+ #0 "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message. kworker/0:0 D25832 5 2 0x80004000 Workqueue: usb_hub_wq hub_event Call Trace: schedule+0xca/0x250 kernel/sched/core.c:4123 schedule_timeout+0x682/0xb20 kernel/time/timer.c:1869 do_wait_for_common kernel/sched/completion.c:83 [inline] __wait_for_common kernel/sched/completion.c:104 [inline] wait_for_common kernel/sched/completion.c:115 [inline] wait_for_completion+0x26f/0x3c0 kernel/sched/completion.c:136 kthread_stop+0x10c/0x600 kernel/kthread.c:559 hwrng_unregister+0x190/0x210 drivers/char/hw_random/core.c:538 chaoskey_disconnect+0x1b2/0x200 drivers/usb/misc/chaoskey.c:231 usb_unbind_interface+0x1bd/0x8a0 drivers/usb/core/driver.c:423 __device_release_driver drivers/base/dd.c:1134 [inline] device_release_driver_internal+0x42f/0x500 drivers/base/dd.c:1165 bus_remove_device+0x2dc/0x4a0 drivers/base/bus.c:532 device_del+0x420/0xb10 drivers/base/core.c:2375 usb_disable_device+0x211/0x690 drivers/usb/core/message.c:1237 usb_disconnect+0x284/0x8d0 drivers/usb/core/hub.c:2199 hub_port_connect drivers/usb/core/hub.c:4949 [inline] hub_port_connect_change drivers/usb/core/hub.c:5213 [inline] port_event drivers/usb/core/hub.c:5359 [inline] hub_event+0x1454/0x3640 drivers/usb/core/hub.c:5441 process_one_work+0x92b/0x1530 kernel/workqueue.c:2269 worker_thread+0x96/0xe20 kernel/workqueue.c:2415 kthread+0x318/0x420 kernel/kthread.c:255 ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:352 INFO: task kworker/1:1:22 blocked for more than 143 seconds. Not tainted 5.3.0+ #0 "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message. kworker/1:1 D2609622 2 0x80004000 Workqueue: usb_hub_wq hub_event Call Trace: schedule+0xca/0x250 kernel/sched/core.c:4123 schedule_timeout+0x682/0xb20 kernel/time/timer.c:1869 do_wait_for_common kernel/sched/completion.c:83 [inline] __wait_for_common kernel/sched/completion.c:104 [inline] wait_for_common kernel/sched/completion.c:115 [inline] wait_for_completion+0x26f/0x3c0 kernel/sched/completion.c:136 kthread_stop+0x10c/0x600 kernel/kthread.c:559 hwrng_unregister+0x190/0x210 drivers/char/hw_random/core.c:538 chaoskey_disconnect+0x1b2/0x200 drivers/usb/misc/chaoskey.c:231 usb_unbind_interface+0x1bd/0x8a0 drivers/usb/core/driver.c:423 __device_release_driver drivers/base/dd.c:1134 [inline] device_release_driver_internal+0x42f/0x500 drivers/base/dd.c:1165 bus_remove_device+0x2dc/0x4a0 drivers/base/bus.c:532 device_del+0x420/0xb10 drivers/base/core.c:2375 usb_disable_device+0x211/0x690 drivers/usb/core/message.c:1237 usb_disconnect+0x284/0x8d0 drivers/usb/core/hub.c:2199 hub_port_connect drivers/usb/core/hub.c:4949 [inline] hub_port_connect_change drivers/usb/core/hub.c:5213 [inline] port_event drivers/usb/core/hub.c:5359 [inline] hub_event+0x1454/0x3640 drivers/usb/core/hub.c:5441 process_one_work+0x92b/0x1530 kernel/workqueue.c:2269 worker_thread+0x96/0xe20 kernel/workqueue.c:2415 kthread+0x318/0x420 kernel/kthread.c:255 ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:352 INFO: task kworker/0:3:2851 blocked for more than 143 seconds. Not tainted 5.3.0+ #0 "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message. kworker/0:3 D25960 2851 2 0x80004000 Workqueue: usb_hub_wq hub_event Call Trace: schedule+0xca/0x250 kernel/sched/core.c:4123 schedule_timeout+0x682/0xb20 kernel/time/timer.c:1869 do_wait_for_common kernel/sched/completion.c:83 [inline] __wait_for_common kernel/sched/completion.c:104 [inline] wait_for_common kernel/sched/completion.c:115 [inline] wait_for_completion+0x26f/0x3c0 kernel/sched/completion.c:136 kthread_stop+0x10c/0x600 kernel/kthread.c:559 hwrng_unregister+0x190/0x210 drivers/char/hw_random/core.c:538 chaoskey_disconnect+0x1b2/0x200 drivers/usb/misc/chaoskey.c:231 usb_unbind_interface+0x1bd/0x8a0 drivers/usb/core/driver.c:423 __device_release_driver drivers/base/dd.c:1134 [inline] device_release_driver_internal+0x42f/0x500 drivers/base/dd.c:1165 bus_remove_device+0x2dc/0x4a0 drivers/base/bus.c:532 device_del+0x420/0xb10 drivers/base/core.c:2375 usb_disable_device+0x211/0x690 drivers/usb/core/message.c:1237 usb_disconnect+0x284/0x8d0 drivers/usb/core/hub.c:2199 hub_port_connect drivers/usb/core/hub.c:4949 [inline] hub_port_connect_change drivers/usb/core/hub.c:5213 [inline] port_event drivers/usb/core/hub.c:5359 [inline] hub_event+0x1454/0x3640 drivers/usb/core/hub.c:5441 process_one_work+0x92b/0x1530 kernel/workqueue.c:2269 worker_thread+0x96/0xe20 kernel/workqueue.c:2415 kthread+0x318/0x420 kernel/kthread.c:255 ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:352 INFO: task kworker/1:3:2862 blocked for more than 144 seconds. Not
Re: WARNING in _chaoskey_fill/usb_submit_urb
Am Montag, den 23.09.2019, 07:31 -0700 schrieb syzbot:
> Hello,
>
> syzbot found the following crash on:
>
> HEAD commit:e0bd8d79 usb-fuzzer: main usb gadget fuzzer driver
> git tree: https://github.com/google/kasan.git usb-fuzzer
> console output: https://syzkaller.appspot.com/x/log.txt?x=1452c6a160
> kernel config: https://syzkaller.appspot.com/x/.config?x=8847e5384a16f66a
> dashboard link: https://syzkaller.appspot.com/bug?extid=f5349b421c6213d34ce2
> compiler: gcc (GCC) 9.0.0 20181231 (experimental)
> syz repro: https://syzkaller.appspot.com/x/repro.syz?x=16342d4560
> C reproducer: https://syzkaller.appspot.com/x/repro.c?x=166769b160
>
> IMPORTANT: if you fix the bug, please add the following tag to the commit:
> Reported-by: syzbot+f5349b421c6213d34...@syzkaller.appspotmail.com
#syz test: https://github.com/google/kasan.git e0bd8d79
From b80b39a2565a80f16ce007982babe753e225ea83 Mon Sep 17 00:00:00 2001
From: Oliver Neukum
Date: Mon, 30 Sep 2019 15:19:13 +0200
Subject: [PATCH] USB: chaoskey: fix error case of a timeout
In case of a timeout communication with the device needs to be ended
from the host side, lest we overwrite an active URB
Signed-off-by: Oliver Neukum
---
drivers/usb/misc/chaoskey.c | 17 ++---
1 file changed, 14 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/misc/chaoskey.c b/drivers/usb/misc/chaoskey.c
index cf5828ce927a..3cb7e1b7d454 100644
--- a/drivers/usb/misc/chaoskey.c
+++ b/drivers/usb/misc/chaoskey.c
@@ -383,13 +383,17 @@ static int _chaoskey_fill(struct chaoskey *dev)
!dev->reading,
(started ? NAK_TIMEOUT : ALEA_FIRST_TIMEOUT) );
- if (result < 0)
+ if (result < 0) {
+ usb_kill_urb(dev->urb);
goto out;
+ }
- if (result == 0)
+ if (result == 0) {
result = -ETIMEDOUT;
- else
+ usb_kill_urb(dev->urb);
+ } else {
result = dev->valid;
+ }
out:
/* Let the device go back to sleep eventually */
usb_autopm_put_interface(dev->interface);
@@ -525,7 +529,14 @@ static int chaoskey_suspend(struct usb_interface *interface,
static int chaoskey_resume(struct usb_interface *interface)
{
+ struct chaoskey *dev;
+ struct usb_device *udev = interface_to_usbdev(interface);
+
usb_dbg(interface, "resume");
+ dev = usb_get_intfdata(interface);
+ if (le16_to_cpu(udev->descriptor.idVendor) == ALEA_VENDOR_ID)
+ dev->reads_started = false;
+
return 0;
}
#else
--
2.16.4
Re: WARNING in _chaoskey_fill/usb_submit_urb
Hello,
syzbot has tested the proposed patch but the reproducer still triggered
crash:
INFO: task hung in chaoskey_disconnect
INFO: task kworker/0:0:5 blocked for more than 143 seconds.
Not tainted 5.3.0+ #0
"echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message.
kworker/0:0 D25976 5 2 0x80004000
Workqueue: usb_hub_wq hub_event
Call Trace:
schedule+0xca/0x250 kernel/sched/core.c:4123
schedule_timeout+0x682/0xb20 kernel/time/timer.c:1869
do_wait_for_common kernel/sched/completion.c:83 [inline]
__wait_for_common kernel/sched/completion.c:104 [inline]
wait_for_common kernel/sched/completion.c:115 [inline]
wait_for_completion+0x26f/0x3c0 kernel/sched/completion.c:136
kthread_stop+0x10c/0x600 kernel/kthread.c:559
hwrng_unregister+0x190/0x210 drivers/char/hw_random/core.c:538
chaoskey_disconnect+0x1b2/0x200 drivers/usb/misc/chaoskey.c:231
usb_unbind_interface+0x1bd/0x8a0 drivers/usb/core/driver.c:423
__device_release_driver drivers/base/dd.c:1134 [inline]
device_release_driver_internal+0x42f/0x500 drivers/base/dd.c:1165
bus_remove_device+0x2dc/0x4a0 drivers/base/bus.c:532
device_del+0x420/0xb10 drivers/base/core.c:2375
usb_disable_device+0x211/0x690 drivers/usb/core/message.c:1237
usb_disconnect+0x284/0x8d0 drivers/usb/core/hub.c:2199
hub_port_connect drivers/usb/core/hub.c:4949 [inline]
hub_port_connect_change drivers/usb/core/hub.c:5213 [inline]
port_event drivers/usb/core/hub.c:5359 [inline]
hub_event+0x1454/0x3640 drivers/usb/core/hub.c:5441
process_one_work+0x92b/0x1530 kernel/workqueue.c:2269
worker_thread+0x96/0xe20 kernel/workqueue.c:2415
kthread+0x318/0x420 kernel/kthread.c:255
ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:352
Showing all locks held in the system:
5 locks held by kworker/0:0/5:
#0: 8881d91c0b28 ((wq_completion)usb_hub_wq){+.+.}, at:
__write_once_size include/linux/compiler.h:226 [inline]
#0: 8881d91c0b28 ((wq_completion)usb_hub_wq){+.+.}, at:
arch_atomic64_set arch/x86/include/asm/atomic64_64.h:34 [inline]
#0: 8881d91c0b28 ((wq_completion)usb_hub_wq){+.+.}, at: atomic64_set
include/asm-generic/atomic-instrumented.h:855 [inline]
#0: 8881d91c0b28 ((wq_completion)usb_hub_wq){+.+.}, at:
atomic_long_set include/asm-generic/atomic-long.h:40 [inline]
#0: 8881d91c0b28 ((wq_completion)usb_hub_wq){+.+.}, at: set_work_data
kernel/workqueue.c:620 [inline]
#0: 8881d91c0b28 ((wq_completion)usb_hub_wq){+.+.}, at:
set_work_pool_and_clear_pending kernel/workqueue.c:647 [inline]
#0: 8881d91c0b28 ((wq_completion)usb_hub_wq){+.+.}, at:
process_one_work+0x827/0x1530 kernel/workqueue.c:2240
#1: 8881da1c7dd0 ((work_completion)(&hub->events)){+.+.}, at:
process_one_work+0x85b/0x1530 kernel/workqueue.c:2244
#2: 8881d5c97900 (&dev->mutex){}, at: device_lock
include/linux/device.h:1462 [inline]
#2: 8881d5c97900 (&dev->mutex){}, at: hub_event+0x17c/0x3640
drivers/usb/core/hub.c:5387
#3: 8881d9034600 (&dev->mutex){}, at: device_lock
include/linux/device.h:1462 [inline]
#3: 8881d9034600 (&dev->mutex){}, at: usb_disconnect+0x91/0x8d0
drivers/usb/core/hub.c:2190
#4: 8881d9037010 (&dev->mutex){}, at:
device_release_driver_internal+0x23/0x500 drivers/base/dd.c:1162
5 locks held by kworker/0:1/12:
#0: 8881d91c0b28 ((wq_completion)usb_hub_wq){+.+.}, at:
__write_once_size include/linux/compiler.h:226 [inline]
#0: 8881d91c0b28 ((wq_completion)usb_hub_wq){+.+.}, at:
arch_atomic64_set arch/x86/include/asm/atomic64_64.h:34 [inline]
#0: 8881d91c0b28 ((wq_completion)usb_hub_wq){+.+.}, at: atomic64_set
include/asm-generic/atomic-instrumented.h:855 [inline]
#0: 8881d91c0b28 ((wq_completion)usb_hub_wq){+.+.}, at:
atomic_long_set include/asm-generic/atomic-long.h:40 [inline]
#0: 8881d91c0b28 ((wq_completion)usb_hub_wq){+.+.}, at: set_work_data
kernel/workqueue.c:620 [inline]
#0: 8881d91c0b28 ((wq_completion)usb_hub_wq){+.+.}, at:
set_work_pool_and_clear_pending kernel/workqueue.c:647 [inline]
#0: 8881d91c0b28 ((wq_completion)usb_hub_wq){+.+.}, at:
process_one_work+0x827/0x1530 kernel/workqueue.c:2240
#1: 8881da20fdd0 ((work_completion)(&hub->events)){+.+.}, at:
process_one_work+0x85b/0x1530 kernel/workqueue.c:2244
#2: 8881d5d06800 (&dev->mutex){}, at: device_lock
include/linux/device.h:1462 [inline]
#2: 8881d5d06800 (&dev->mutex){}, at: hub_event+0x17c/0x3640
drivers/usb/core/hub.c:5387
#3: 8881c9c8b500 (&dev->mutex){}, at: device_lock
include/linux/device.h:1462 [inline]
#3: 8881c9c8b500 (&dev->mutex){}, at: usb_disconnect+0x91/0x8d0
drivers/usb/core/hub.c:2190
#4: 8881c9c8a390 (&dev->mutex){}, at:
device_release_driver_internal+0x23/0x500 drivers/base/dd.c:1162
5 locks held by kworker/1:1/21:
#0: 8881d91c0b28 ((wq_completion)usb_hub_wq){+.+.}, at:
__write_once_size include/linux/compiler.h:226 [inline]
#0: 8881d91c0b28 ((wq_compl
Re: WARNING in _chaoskey_fill/usb_submit_urb
Am Montag, den 23.09.2019, 07:31 -0700 schrieb syzbot: > Hello, > > syzbot found the following crash on: > > HEAD commit:e0bd8d79 usb-fuzzer: main usb gadget fuzzer driver > git tree: https://github.com/google/kasan.git usb-fuzzer > console output: https://syzkaller.appspot.com/x/log.txt?x=1452c6a160 > kernel config: https://syzkaller.appspot.com/x/.config?x=8847e5384a16f66a > dashboard link: https://syzkaller.appspot.com/bug?extid=f5349b421c6213d34ce2 > compiler: gcc (GCC) 9.0.0 20181231 (experimental) > syz repro: https://syzkaller.appspot.com/x/repro.syz?x=16342d4560 > C reproducer: https://syzkaller.appspot.com/x/repro.c?x=166769b160 > > IMPORTANT: if you fix the bug, please add the following tag to the commit: > Reported-by: syzbot+f5349b421c6213d34...@syzkaller.appspotmail.com #syz test: https://github.com/google/kasan.git e0bd8d79From 27b0085768b55f2ed8faf4f1254023a03dc3eb24 Mon Sep 17 00:00:00 2001 From: Oliver Neukum Date: Mon, 30 Sep 2019 15:19:13 +0200 Subject: [PATCH] USB: chaoskey: fix error case of a timeout In case of a timeout communication with the device needs to be ended from the host side, lest we overwrite an active URB Signed-off-by: Oliver Neukum --- drivers/usb/misc/chaoskey.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/misc/chaoskey.c b/drivers/usb/misc/chaoskey.c index cf5828ce927a..850f46cbace2 100644 --- a/drivers/usb/misc/chaoskey.c +++ b/drivers/usb/misc/chaoskey.c @@ -391,6 +391,8 @@ static int _chaoskey_fill(struct chaoskey *dev) else result = dev->valid; out: + /* in case of a timeout */ + usb_kill_urb(dev->urb); /* Let the device go back to sleep eventually */ usb_autopm_put_interface(dev->interface); -- 2.16.4
WARNING in _chaoskey_fill/usb_submit_urb
Hello, syzbot found the following crash on: HEAD commit:e0bd8d79 usb-fuzzer: main usb gadget fuzzer driver git tree: https://github.com/google/kasan.git usb-fuzzer console output: https://syzkaller.appspot.com/x/log.txt?x=1452c6a160 kernel config: https://syzkaller.appspot.com/x/.config?x=8847e5384a16f66a dashboard link: https://syzkaller.appspot.com/bug?extid=f5349b421c6213d34ce2 compiler: gcc (GCC) 9.0.0 20181231 (experimental) syz repro: https://syzkaller.appspot.com/x/repro.syz?x=16342d4560 C reproducer: https://syzkaller.appspot.com/x/repro.c?x=166769b160 IMPORTANT: if you fix the bug, please add the following tag to the commit: Reported-by: syzbot+f5349b421c6213d34...@syzkaller.appspotmail.com [ cut here ] URB 052bee21 submitted while active WARNING: CPU: 1 PID: 1794 at drivers/usb/core/urb.c:362 usb_submit_urb+0x10c1/0x13b0 drivers/usb/core/urb.c:362 Kernel panic - not syncing: panic_on_warn set ... CPU: 1 PID: 1794 Comm: syz-executor305 Not tainted 5.3.0+ #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 Call Trace: __dump_stack lib/dump_stack.c:77 [inline] dump_stack+0xca/0x13e lib/dump_stack.c:113 panic+0x2a3/0x6da kernel/panic.c:219 __warn.cold+0x20/0x4a kernel/panic.c:576 report_bug+0x262/0x2a0 lib/bug.c:186 fixup_bug arch/x86/kernel/traps.c:179 [inline] fixup_bug arch/x86/kernel/traps.c:174 [inline] do_error_trap+0x12b/0x1e0 arch/x86/kernel/traps.c:272 do_invalid_op+0x32/0x40 arch/x86/kernel/traps.c:291 invalid_op+0x23/0x30 arch/x86/entry/entry_64.S:1028 RIP: 0010:usb_submit_urb+0x10c1/0x13b0 drivers/usb/core/urb.c:362 Code: 89 de e8 92 5b ee fd 84 db 0f 85 42 f6 ff ff e8 55 5a ee fd 4c 89 fe 48 c7 c7 00 c2 18 86 c6 05 f3 cf 38 04 01 e8 f4 e5 c3 fd <0f> 0b e9 20 f6 ff ff c7 44 24 14 01 00 00 00 e9 d7 f6 ff ff 41 bd RSP: 0018:8881d0427b68 EFLAGS: 00010286 RAX: RBX: RCX: RDX: RSI: 8128d9ad RDI: ed103a084f5f RBP: 8881d070b180 R08: 8881d4934800 R09: ed103b663ee7 R10: ed103b663ee6 R11: 8881db31f737 R12: 8881d070b180 R13: fff0 R14: R15: 8881d5c22400 _chaoskey_fill.part.0+0xe0/0x470 drivers/usb/misc/chaoskey.c:367 _chaoskey_fill+0x1ad/0x230 drivers/usb/misc/chaoskey.c:361 chaoskey_read+0x2c2/0x4c0 drivers/usb/misc/chaoskey.c:434 __vfs_read+0x76/0x100 fs/read_write.c:425 vfs_read+0x1ea/0x430 fs/read_write.c:461 ksys_read+0x127/0x250 fs/read_write.c:587 do_syscall_64+0xb7/0x580 arch/x86/entry/common.c:290 entry_SYSCALL_64_after_hwframe+0x49/0xbe RIP: 0033:0x4419c9 Code: e8 8c e8 ff ff 48 83 c4 18 c3 0f 1f 80 00 00 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 0f 83 cb 08 fc ff c3 66 2e 0f 1f 84 00 00 00 00 RSP: 002b:7ffc317ed1f8 EFLAGS: 0246 ORIG_RAX: RAX: ffda RBX: RCX: 004419c9 RDX: 0009 RSI: 2040 RDI: 0004 RBP: e12e R08: 000f R09: 004002c8 R10: R11: 0246 R12: 00402720 R13: 004027b0 R14: R15: Kernel Offset: disabled Rebooting in 86400 seconds.. --- This bug is generated by a bot. It may contain errors. See https://goo.gl/tpsmEJ for more information about syzbot. syzbot engineers can be reached at syzkal...@googlegroups.com. syzbot will keep track of this bug report. See: https://goo.gl/tpsmEJ#status for how to communicate with syzbot. syzbot can test patches for this bug, for details see: https://goo.gl/tpsmEJ#testing-patches
