Re: WARNING in yurex_write/usb_submit_urb
On Mon, Dec 14, 2020 at 4:16 PM Johan Hovold wrote: > > On Mon, Dec 14, 2020 at 04:06:49PM +0100, Andrey Konovalov wrote: > > On Mon, Dec 14, 2020 at 4:02 PM Johan Hovold wrote: > > > > > > On Mon, Dec 14, 2020 at 06:48:03AM -0800, syzbot wrote: > > > > Hello, > > > > > > > > syzbot has tested the proposed patch but the reproducer is still > > > > triggering an issue: > > > > WARNING in yurex_write/usb_submit_urb > > > > > > It appears syzbot never tested the patch from the thread. Probably using > > > it's mail interface incorrectly, I don't know and I don't have time to > > > investigate. The patch itself is correct. > > > > Hi Johan, > > > > I wasn't CCed on the testing request, so I can't say what exactly was wrong. > > Here's the patch and the "syz test" command in a reply: > > https://lore.kernel.org/r/2020121410.28386-1-jo...@kernel.org > > Probably needs to go in the same mail, right? Yes, both the syz test command and the patch must be in the same email, which is sent as a response to the initial report. > How about including the command needed to test a patch in the syzbot > report mail to assist the casual user of its interfaces? I had to browse > the web page you link to and still got it wrong apparently. I think it's deliberately not included to not overload the report email with too many details. > > Could you send me the patch you were trying to test? > > Does this work better: > > #syz test: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git > usb-testing This worked :) Thanks!
Re: WARNING in yurex_write/usb_submit_urb
Hello, syzbot has tested the proposed patch and the reproducer did not trigger any issue: Reported-and-tested-by: syzbot+e87ebe0f7913f71f2...@syzkaller.appspotmail.com Tested on: commit: a256e240 usb: phy: convert comma to semicolon git tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing kernel config: https://syzkaller.appspot.com/x/.config?x=4536e7f93c2bc8e9 dashboard link: https://syzkaller.appspot.com/bug?extid=e87ebe0f7913f71f2ea5 compiler: gcc (GCC) 10.1.0-syz 20200507 patch: https://syzkaller.appspot.com/x/patch.diff?x=11a9f70350 Note: testing is done by a robot and is best-effort only.
Re: WARNING in yurex_write/usb_submit_urb
On Mon, Dec 14, 2020 at 04:06:49PM +0100, Andrey Konovalov wrote:
> On Mon, Dec 14, 2020 at 4:02 PM Johan Hovold wrote:
> >
> > On Mon, Dec 14, 2020 at 06:48:03AM -0800, syzbot wrote:
> > > Hello,
> > >
> > > syzbot has tested the proposed patch but the reproducer is still
> > > triggering an issue:
> > > WARNING in yurex_write/usb_submit_urb
> >
> > It appears syzbot never tested the patch from the thread. Probably using
> > it's mail interface incorrectly, I don't know and I don't have time to
> > investigate. The patch itself is correct.
>
> Hi Johan,
>
> I wasn't CCed on the testing request, so I can't say what exactly was wrong.
Here's the patch and the "syz test" command in a reply:
https://lore.kernel.org/r/2020121410.28386-1-jo...@kernel.org
Probably needs to go in the same mail, right?
How about including the command needed to test a patch in the syzbot
report mail to assist the casual user of its interfaces? I had to browse
the web page you link to and still got it wrong apparently.
> Could you send me the patch you were trying to test?
Does this work better:
#syz test: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
usb-testing
Johan
>From 3bb77b2ac604d70b06f45a850e326dda9c99c9cd Mon Sep 17 00:00:00 2001
From: Johan Hovold
Date: Mon, 14 Dec 2020 11:30:53 +0100
Subject: [PATCH] USB: yurex: fix control-URB timeout handling
Make sure to always cancel the control URB in write() so that it can be
reused after a timeout or spurious CMD_ACK.
Currently any further write requests after a timeout would fail after
triggering a WARN() in usb_submit_urb() when attempting to submit the
already active URB.
Reported-by: syzbot+e87ebe0f7913f71f2...@syzkaller.appspotmail.com
Fixes: 6bc235a2e24a ("USB: add driver for Meywa-Denki & Kayac YUREX")
Cc: stable # 2.6.37
Signed-off-by: Johan Hovold
---
drivers/usb/misc/yurex.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/usb/misc/yurex.c b/drivers/usb/misc/yurex.c
index 73ebfa6e9715..c640f98d20c5 100644
--- a/drivers/usb/misc/yurex.c
+++ b/drivers/usb/misc/yurex.c
@@ -496,6 +496,9 @@ static ssize_t yurex_write(struct file *file, const char
__user *user_buffer,
timeout = schedule_timeout(YUREX_WRITE_TIMEOUT);
finish_wait(>waitq, );
+ /* make sure URB is idle after timeout or (spurious) CMD_ACK */
+ usb_kill_urb(dev->cntl_urb);
+
mutex_unlock(>io_mutex);
if (retval < 0) {
--
2.26.2
Re: WARNING in yurex_write/usb_submit_urb
On Mon, Dec 14, 2020 at 4:02 PM Johan Hovold wrote: > > On Mon, Dec 14, 2020 at 06:48:03AM -0800, syzbot wrote: > > Hello, > > > > syzbot has tested the proposed patch but the reproducer is still triggering > > an issue: > > WARNING in yurex_write/usb_submit_urb > > It appears syzbot never tested the patch from the thread. Probably using > it's mail interface incorrectly, I don't know and I don't have time to > investigate. The patch itself is correct. Hi Johan, I wasn't CCed on the testing request, so I can't say what exactly was wrong. Could you send me the patch you were trying to test? Thanks!
Re: WARNING in yurex_write/usb_submit_urb
On Mon, Dec 14, 2020 at 06:48:03AM -0800, syzbot wrote: > Hello, > > syzbot has tested the proposed patch but the reproducer is still triggering > an issue: > WARNING in yurex_write/usb_submit_urb It appears syzbot never tested the patch from the thread. Probably using it's mail interface incorrectly, I don't know and I don't have time to investigate. The patch itself is correct. Johan
Re: WARNING in yurex_write/usb_submit_urb
Hello, syzbot has tested the proposed patch but the reproducer is still triggering an issue: WARNING in yurex_write/usb_submit_urb [ cut here ] URB d1c13d63 submitted while active WARNING: CPU: 1 PID: 12383 at drivers/usb/core/urb.c:378 usb_submit_urb+0x1228/0x14e0 drivers/usb/core/urb.c:378 Modules linked in: CPU: 1 PID: 12383 Comm: syz-executor.2 Not tainted 5.10.0-rc7-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 RIP: 0010:usb_submit_urb+0x1228/0x14e0 drivers/usb/core/urb.c:378 Code: 89 de e8 1b cd 3b fc 84 db 0f 85 da f4 ff ff e8 fe d4 3b fc 4c 89 fe 48 c7 c7 20 59 e1 89 c6 05 14 8c a4 07 01 e8 a4 b3 78 03 <0f> 0b e9 b8 f4 ff ff c7 44 24 14 01 00 00 00 e9 6f f5 ff ff 41 bd RSP: 0018:c90001c9fcb8 EFLAGS: 00010282 RAX: RBX: RCX: RDX: 888020788000 RSI: 8158c835 RDI: f52000393f89 RBP: 192000393fa9 R08: 0001 R09: 8880b9f30627 R10: R11: R12: 8880276ea400 R13: fff0 R14: 8880276ea4e8 R15: 888012dca100 FS: 7fad9e6f7700() GS:8880b9f0() knlGS: CS: 0010 DS: ES: CR0: 80050033 CR2: 5587bf0f4160 CR3: 252a1000 CR4: 001506e0 DR0: DR1: DR2: DR3: DR6: fffe0ff0 DR7: 0400 Call Trace: yurex_write+0x3f4/0x840 drivers/usb/misc/yurex.c:494 vfs_write+0x28e/0xa30 fs/read_write.c:603 ksys_write+0x12d/0x250 fs/read_write.c:658 do_syscall_64+0x2d/0x70 arch/x86/entry/common.c:46 entry_SYSCALL_64_after_hwframe+0x44/0xa9 RIP: 0033:0x45e159 Code: 0d b4 fb ff c3 66 2e 0f 1f 84 00 00 00 00 00 66 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 0f 83 db b3 fb ff c3 66 2e 0f 1f 84 00 00 00 00 RSP: 002b:7fad9e6f6c68 EFLAGS: 0246 ORIG_RAX: 0001 RAX: ffda RBX: 0003 RCX: 0045e159 RDX: 0001 RSI: 2740 RDI: 0004 RBP: 0119bfc0 R08: R09: R10: R11: 0246 R12: 0119bf8c R13: 7ffc9fc101ef R14: 7fad9e6f79c0 R15: 0119bf8c Tested on: commit: a256e240 usb: phy: convert comma to semicolon git tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing console output: https://syzkaller.appspot.com/x/log.txt?x=1735713750 kernel config: https://syzkaller.appspot.com/x/.config?x=4536e7f93c2bc8e9 dashboard link: https://syzkaller.appspot.com/bug?extid=e87ebe0f7913f71f2ea5 compiler: gcc (GCC) 10.1.0-syz 20200507
Re: WARNING in yurex_write/usb_submit_urb
syzbot has found a reproducer for the following issue on: HEAD commit:6bff9bb8 Merge tag 'scsi-fixes' of git://git.kernel.org/pu.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=10937c5b50 kernel config: https://syzkaller.appspot.com/x/.config?x=3416bb960d5c705d dashboard link: https://syzkaller.appspot.com/bug?extid=e87ebe0f7913f71f2ea5 compiler: gcc (GCC) 10.1.0-syz 20200507 syz repro: https://syzkaller.appspot.com/x/repro.syz?x=1583cf1750 C reproducer: https://syzkaller.appspot.com/x/repro.c?x=1182541350 IMPORTANT: if you fix the issue, please add the following tag to the commit: Reported-by: syzbot+e87ebe0f7913f71f2...@syzkaller.appspotmail.com [ cut here ] URB 91a49304 submitted while active WARNING: CPU: 0 PID: 8533 at drivers/usb/core/urb.c:378 usb_submit_urb+0x1228/0x14e0 drivers/usb/core/urb.c:378 Modules linked in: CPU: 0 PID: 8533 Comm: syz-executor014 Not tainted 5.10.0-rc7-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 RIP: 0010:usb_submit_urb+0x1228/0x14e0 drivers/usb/core/urb.c:378 Code: 89 de e8 eb c8 3b fc 84 db 0f 85 da f4 ff ff e8 ce d0 3b fc 4c 89 fe 48 c7 c7 40 58 e1 89 c6 05 62 6d a4 07 01 e8 74 4f 78 03 <0f> 0b e9 b8 f4 ff ff c7 44 24 14 01 00 00 00 e9 6f f5 ff ff 41 bd RSP: 0018:c9000187fcb8 EFLAGS: 00010282 RAX: RBX: RCX: RDX: 888015e73480 RSI: 8158c835 RDI: f5200030ff89 RBP: 19200030ffa9 R08: 0001 R09: 8880b9e30627 R10: R11: R12: 888017a40c00 R13: fff0 R14: 888017a40ce8 R15: 888011521a00 FS: 025f8880() GS:8880b9e0() knlGS: CS: 0010 DS: ES: CR0: 80050033 CR2: 7fe0726b3000 CR3: 1c29c000 CR4: 001506f0 DR0: DR1: DR2: DR3: DR6: fffe0ff0 DR7: 0400 Call Trace: yurex_write+0x3f4/0x840 drivers/usb/misc/yurex.c:493 vfs_write+0x28e/0xa30 fs/read_write.c:603 ksys_write+0x12d/0x250 fs/read_write.c:658 do_syscall_64+0x2d/0x70 arch/x86/entry/common.c:46 entry_SYSCALL_64_after_hwframe+0x44/0xa9 RIP: 0033:0x445809 Code: e8 8c e8 ff ff 48 83 c4 18 c3 0f 1f 80 00 00 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 0f 83 6b cc fb ff c3 66 2e 0f 1f 84 00 00 00 00 RSP: 002b:7ffe3d547598 EFLAGS: 0246 ORIG_RAX: 0001 RAX: ffda RBX: RCX: 00445809 RDX: 0001 RSI: 2740 RDI: 0004 RBP: edca R08: 000f R09: 004002e0 R10: R11: 0246 R12: 00402900 R13: 00402990 R14: R15:
Re: WARNING in yurex_write/usb_submit_urb
syzbot has found a reproducer for the following issue on: HEAD commit:a256e240 usb: phy: convert comma to semicolon git tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing console output: https://syzkaller.appspot.com/x/log.txt?x=147b6adf50 kernel config: https://syzkaller.appspot.com/x/.config?x=e267dbb5fea6c8b3 dashboard link: https://syzkaller.appspot.com/bug?extid=e87ebe0f7913f71f2ea5 compiler: gcc (GCC) 10.1.0-syz 20200507 syz repro: https://syzkaller.appspot.com/x/repro.syz?x=15edcf1750 IMPORTANT: if you fix the issue, please add the following tag to the commit: Reported-by: syzbot+e87ebe0f7913f71f2...@syzkaller.appspotmail.com [ cut here ] URB 0aabe4b9 submitted while active WARNING: CPU: 1 PID: 7771 at drivers/usb/core/urb.c:378 usb_submit_urb+0x1228/0x14e0 drivers/usb/core/urb.c:378 Modules linked in: CPU: 1 PID: 7771 Comm: syz-executor.4 Not tainted 5.10.0-rc7-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 RIP: 0010:usb_submit_urb+0x1228/0x14e0 drivers/usb/core/urb.c:378 Code: 89 de e8 8b 24 bd fd 84 db 0f 85 da f4 ff ff e8 2e 2c bd fd 4c 89 fe 48 c7 c7 c0 63 41 86 c6 05 33 ea b0 04 01 e8 63 2d f3 01 <0f> 0b e9 b8 f4 ff ff c7 44 24 14 01 00 00 00 e9 6f f5 ff ff 41 bd RSP: 0018:c90001a57cb8 EFLAGS: 00010282 RAX: RBX: RCX: RDX: 888122eee500 RSI: 8128f483 RDI: f5200034af89 RBP: 19200034afa9 R08: 0001 R09: 8881f6b2f5cf R10: R11: R12: 888109853400 R13: fff0 R14: 8881098534e8 R15: 888107dbfc00 FS: 7fee407c7700() GS:8881f6b0() knlGS: CS: 0010 DS: ES: CR0: 80050033 CR2: 7fb79c135ef0 CR3: 00010b8aa000 CR4: 001506e0 DR0: DR1: DR2: DR3: DR6: fffe0ff0 DR7: 0400 Call Trace: yurex_write+0x3f4/0x840 drivers/usb/misc/yurex.c:494 vfs_write+0x28e/0x9e0 fs/read_write.c:603 ksys_write+0x12d/0x250 fs/read_write.c:658 do_syscall_64+0x2d/0x40 arch/x86/entry/common.c:46 entry_SYSCALL_64_after_hwframe+0x44/0xa9 RIP: 0033:0x45e159 Code: 0d b4 fb ff c3 66 2e 0f 1f 84 00 00 00 00 00 66 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 0f 83 db b3 fb ff c3 66 2e 0f 1f 84 00 00 00 00 RSP: 002b:7fee407c6c68 EFLAGS: 0246 ORIG_RAX: 0001 RAX: ffda RBX: 0003 RCX: 0045e159 RDX: 0001 RSI: 2740 RDI: 0004 RBP: 0119bfc0 R08: R09: R10: R11: 0246 R12: 0119bf8c R13: 7fffcdbf5b7f R14: 7fee407c79c0 R15: 0119bf8c
WARNING in yurex_write/usb_submit_urb
Hello, syzbot found the following issue on: HEAD commit:a256e240 usb: phy: convert comma to semicolon git tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing console output: https://syzkaller.appspot.com/x/log.txt?x=14c2cef350 kernel config: https://syzkaller.appspot.com/x/.config?x=e267dbb5fea6c8b3 dashboard link: https://syzkaller.appspot.com/bug?extid=e87ebe0f7913f71f2ea5 compiler: gcc (GCC) 10.1.0-syz 20200507 Unfortunately, I don't have any reproducer for this issue yet. IMPORTANT: if you fix the issue, please add the following tag to the commit: Reported-by: syzbot+e87ebe0f7913f71f2...@syzkaller.appspotmail.com [ cut here ] URB dfe6f349 submitted while active WARNING: CPU: 1 PID: 25254 at drivers/usb/core/urb.c:378 usb_submit_urb+0x1228/0x14e0 drivers/usb/core/urb.c:378 Modules linked in: CPU: 1 PID: 25254 Comm: syz-executor.0 Not tainted 5.10.0-rc7-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 RIP: 0010:usb_submit_urb+0x1228/0x14e0 drivers/usb/core/urb.c:378 Code: 89 de e8 8b 24 bd fd 84 db 0f 85 da f4 ff ff e8 2e 2c bd fd 4c 89 fe 48 c7 c7 c0 63 41 86 c6 05 33 ea b0 04 01 e8 63 2d f3 01 <0f> 0b e9 b8 f4 ff ff c7 44 24 14 01 00 00 00 e9 6f f5 ff ff 41 bd RSP: 0018:c900129e7cb8 EFLAGS: 00010282 RAX: RBX: RCX: RDX: 0004 RSI: 8128f483 RDI: f5200253cf89 RBP: 19200253cfa9 R08: 0001 R09: 8881f6b1ff5b R10: R11: R12: 888101ccbc00 R13: fff0 R14: 888101ccbce8 R15: 8881050ce400 FS: 7f9fd94dd700() GS:8881f6b0() knlGS: CS: 0010 DS: ES: CR0: 80050033 CR2: 2740 CR3: 0001135b7000 CR4: 001506e0 DR0: DR1: DR2: DR3: DR6: fffe0ff0 DR7: 0400 Call Trace: yurex_write+0x3f4/0x840 drivers/usb/misc/yurex.c:494 vfs_write+0x28e/0x9e0 fs/read_write.c:603 ksys_write+0x12d/0x250 fs/read_write.c:658 do_syscall_64+0x2d/0x40 arch/x86/entry/common.c:46 entry_SYSCALL_64_after_hwframe+0x44/0xa9 RIP: 0033:0x45e159 Code: 0d b4 fb ff c3 66 2e 0f 1f 84 00 00 00 00 00 66 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 0f 83 db b3 fb ff c3 66 2e 0f 1f 84 00 00 00 00 RSP: 002b:7f9fd94dcc68 EFLAGS: 0246 ORIG_RAX: 0001 RAX: ffda RBX: 0003 RCX: 0045e159 RDX: 0001 RSI: 2740 RDI: 0003 RBP: 0119bfc0 R08: R09: R10: R11: 0246 R12: 0119bf8c R13: 7ffc06103bcf R14: 7f9fd94dd9c0 R15: 0119bf8c --- This report is generated by a bot. It may contain errors. See https://goo.gl/tpsmEJ for more information about syzbot. syzbot engineers can be reached at syzkal...@googlegroups.com. syzbot will keep track of this issue. See: https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
