c438cfd46e ("blk-mq: fix changelog"): BUG: unable to handle kernel NULL pointer dereference at 00000000

[kernel test robot]

Greetings,

0day kernel testing robot got the below dmesg and the first bad commit is

https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git 
debugfs_cleanup

commit c438cfd46e37a6dd9e370219a6f0d397cc3c1a36
Author: Greg Kroah-Hartman 
AuthorDate: Fri Jan 4 14:06:22 2019 +0100
Commit: Greg Kroah-Hartman 
CommitDate: Thu Jan 31 14:18:25 2019 +0100

blk-mq: fix changelog

ddd7d0ff2d  wireless: fix changelog
c438cfd46e  blk-mq: fix changelog
31b092d47f  lib: WIP, break up
+--++++
|  | ddd7d0ff2d | c438cfd46e | 
31b092d47f |
+--++++
| boot_successes   | 37 | 0  | 0
  |
| boot_failures| 0  | 26 | 26   
  |
| BUG:unable_to_handle_kernel  | 0  | 26 | 26   
  |
| Oops:#[##]   | 0  | 26 | 26   
  |
| EIP:debugfs_create_files | 0  | 26 | 26   
  |
| Kernel_panic-not_syncing:Fatal_exception | 0  | 26 | 26   
  |
+--++++

[7.740649] igt_debug 0x0a00-0x0e00: 1024: used
[7.741350] igt_debug 0x0e00-0x1000: 512: free
[7.742149] igt_debug total: 4096, used 2048 free 2048
[   42.726577] [drm] Initialized vgem 1.0.0 20120112 for vgem on minor 0
[   42.728241] Floppy drive(s): fd0 is 2.88M AMI BIOS
[   42.729334] BUG: unable to handle kernel NULL pointer dereference at 
[   42.729735] #PF error: [normal kernel read fault]
[   42.729735] *pde =  
[   42.729735] Oops:  [#1]
[   42.729735] CPU: 0 PID: 1 Comm: swapper Not tainted 5.0.0-rc2-00115-gc438cfd 
#113
[   42.729735] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 
1.10.2-1 04/01/2014
[   42.729735] EIP: debugfs_create_files+0x6b/0xa0
[   42.729735] Code: 00 00 00 00 0f 97 c0 31 c9 89 c7 0f b6 d0 b8 68 ab 7b 82 
e8 57 6d be ff 89 f8 84 c0 75 38 8b 46 30 8b 7d f0 89 b8 fc 01 00 00 <8b> 03 85 
c0 74 26 8d b4 26 00 00 00 00 0f b7 53 04 89 1c 24 89 f1
[   42.729735] EAX: 9efb5000 EBX:  ECX:  EDX: 
[   42.729735] ESI: 9efb3840 EDI: 9d6cf800 EBP: 80243e3c ESP: 80243e24
[   42.729735] DS: 007b ES: 007b FS:  GS:  SS: 0068 EFLAGS: 00210246
[   42.729735] CR0: 80050033 CR2:  CR3: 02924000 CR4: 001406d0
[   42.729735] Call Trace:
[   42.729735]  blk_mq_debugfs_register_sched_hctx+0x34/0x40
[   42.729735]  blk_mq_debugfs_register+0xb1/0xc0
[   42.729735]  blk_register_queue+0x108/0x230
[   42.729735]  __device_add_disk+0x44f/0x640
[   42.729735]  device_add_disk+0x17/0x20
[   42.729735]  loop_add+0x217/0x2c0
[   42.729735]  loop_init+0xf9/0x11a
[   42.729735]  ? floppy_async_init+0xd4c/0xd4c
[   42.729735]  do_one_initcall+0xdd/0x25d
[   42.729735]  kernel_init_freeable+0x25a/0x2d7
[   42.729735]  ? rest_init+0x140/0x140
[   42.729735]  kernel_init+0x10/0x100
[   42.729735]  ? schedule_tail_wrapper+0x9/0x10
[   42.729735]  ret_from_fork+0x19/0x30
[   42.729735] CR2: 
[   42.729735] _warn_unseeded_randomness: 35 callbacks suppressed
[   42.729735] random: get_random_bytes called from init_oops_id+0x3f/0x50 with 
crng_init=1
[   42.729735] ---[ end trace 25be250042fb0fd4 ]---
[   42.729735] EIP: debugfs_create_files+0x6b/0xa0

  # HH:MM RESULT GOOD 
BAD GOOD_BUT_DIRTY DIRTY_NOT_BAD
git bisect start 0e9ac1e5b38fa1032c8809b7f375c5f20aa8c2be 
f17b5f06cb92ef2250513a1e154c47b78df07d40 --
git bisect good f095dea55a4ac7fdb83f505523ad417274e54192  # 01:00  G 10 
00   0  Merge 'ulf.hansson-mmc/next' into devel-catchup-201901312352
git bisect good f1ac64a048ea54cd0bfa9d1d455056c135e3e597  # 01:08  G 11 
00   0  Merge 'alaahl/for-linust' into devel-catchup-201901312352
git bisect  bad 4f28883ea4af13b4d15f7ae2f7efb5fa81cc4f84  # 01:14  B  0 
9   34  11  Merge 'driver-core/debugfs_cleanup' into devel-catchup-201901312352
git bisect good 52c070b7c8809576d3065d4b6a4cf1154d7acde2  # 01:33  G 10 
00   0  cw1200: no need to check return value of debugfs_create functions
git bisect good 3000a51bc760ad362eeab65de07a92c47b2353eb  # 01:43  G 10 
00   0  f2fs: no need to check return value of debugfs_create functions
git bisect good 50b82e5dd6c2fad0af36a80baff41b37c18e091b  # 02:00  G 11 
00   0  xen-netback: fix changelog
git bisect  bad 6a37bbef02b8607940a432c864e3f635293cb1e3  # 02:04  B  0 
2   16   0  pstore: fix changelog
git bisect good c3cbe3160fcb8ea6dc6a6d2939af4f2bf05c11a2  # 02:29  G 11 
00   0  sunrpc: fix changelog
git bisect good ddd7d0ff2d7b4f80e2c4b54718f66c5601fd25c1  # 02:35  G 

1aba551c73 ("blk-mq: fix changelog"): BUG: unable to handle kernel NULL pointer dereference at 00000000

[kernel test robot]

Greetings,

0day kernel testing robot got the below dmesg and the first bad commit is

https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git 
debugfs_cleanup

commit 1aba551c73de605983515118d5ad527594440ccb
Author: Greg Kroah-Hartman 
AuthorDate: Fri Jan 4 14:06:22 2019 +0100
Commit: Greg Kroah-Hartman 
CommitDate: Sat Jan 5 18:42:10 2019 +0100

blk-mq: fix changelog

7d7009c53a  wireless: fix changelog
1aba551c73  blk-mq: fix changelog
6044acd966  lib: WIP, break up
+--++++
|  | 7d7009c53a | 1aba551c73 | 
6044acd966 |
+--++++
| boot_successes   | 32 | 0  | 0
  |
| boot_failures| 0  | 22 | 19   
  |
| BUG:unable_to_handle_kernel  | 0  | 22 | 19   
  |
| Oops:#[##]   | 0  | 22 | 19   
  |
| EIP:debugfs_create_files | 0  | 22 | 19   
  |
| Kernel_panic-not_syncing:Fatal_exception | 0  | 22 | 19   
  |
+--++++

[   19.240778] parport_pc 00:04: reported by Plug and Play ACPI
[   19.249983] parport0: PC-style at 0x378, irq 7 [PCSPP(,...)]
[   19.259854] lp0: using parport0 (interrupt-driven).
[   19.266789] lp0: console ready
[   19.294331] brd: module loaded
[   19.303672] BUG: unable to handle kernel NULL pointer dereference at 
[   19.311670] #PF error: [normal kernel read fault]
[   19.312646] *pdpt =  *pde = f000ff53f000ff53 
[   19.312646] Oops:  [#1] PTI
[   19.312646] CPU: 0 PID: 1 Comm: swapper Tainted: GT 
4.20.0-11094-g1aba551 #440
[   19.312646] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 
1.10.2-1 04/01/2014
[   19.312646] EIP: debugfs_create_files+0x20/0x60
[   19.312646] Code: 74 26 00 8d bc 27 00 00 00 00 55 89 e5 56 89 c6 53 83 ec 
08 85 c0 74 42 3d 00 f0 ff ff 77 3b 8b 40 10 89 cb 89 90 a4 00 00 00 <8b> 01 85 
c0 74 2a 8d 76 00 8d bc 27 00 00 00 00 0f b7 53 04 b9 00
[   19.312646] EAX: db0c1ae0 EBX:  ECX:  EDX: d9f41400
[   19.312646] ESI: db0aa500 EDI: d9f41400 EBP: db45be38 ESP: db45be28
[   19.312646] DS: 007b ES: 007b FS:  GS: 00e0 SS: 0068 EFLAGS: 00210287
[   19.312646] CR0: 80050033 CR2:  CR3: 028ca000 CR4: 001406f0
[   19.312646] Call Trace:
[   19.312646]  blk_mq_debugfs_register_sched_hctx+0x36/0x40
[   19.312646]  blk_mq_debugfs_register+0xb1/0xd0
[   19.312646]  blk_register_queue+0xa1/0x170
[   19.312646]  __device_add_disk+0x2af/0x4a0
[   19.312646]  device_add_disk+0x12/0x20
[   19.312646]  loop_add+0x1b9/0x240
[   19.312646]  loop_init+0xfd/0x12f
[   19.312646]  ? brd_init+0x15c/0x15c
[   19.312646]  do_one_initcall+0x68/0x134
[   19.312646]  ? loglevel+0x47/0x47
[   19.312646]  kernel_init_freeable+0xe1/0x15b
[   19.312646]  ? rest_init+0x90/0x90
[   19.312646]  kernel_init+0xb/0x100
[   19.312646]  ? schedule_tail_wrapper+0x9/0x10
[   19.312646]  ret_from_fork+0x19/0x30
[   19.312646] CR2: 
[   19.312646] ---[ end trace 3fa233f5a018a515 ]---
[   19.312646] EIP: debugfs_create_files+0x20/0x60

  # HH:MM RESULT GOOD 
BAD GOOD_BUT_DIRTY DIRTY_NOT_BAD
git bisect start 6044acd966af9b2abf150dde97c9092e174f5c32 
3fed6ae4b027f9c93be18520f87bd06bdffd196b --
git bisect good 9e34cf7c199ca0088d4704b5c246a915ed336419  # 03:36  G 11 
00   0  ti: wl1251: no need to check return value of debugfs_create 
functions
git bisect good 2b1612f9f11109c49b327401b9deb5e7f42ae9aa  # 03:48  G 11 
00   2  gcov: no need to check return value of debugfs_create functions
git bisect good ea485bd98e3c0b4a8ace4f43a6099b28ac37d62d  # 03:59  G 11 
00   0  l2tp: fix changelog
git bisect  bad 4f6a5da79aa189934d6ff9244efccb4e166d4648  # 04:11  B  0
10   31   7  gfs: no need to check return value of debugfs_create functions
git bisect good 7d7009c53a3be411a6a790ac2788677db27d7286  # 04:24  G 11 
00   0  wireless: fix changelog
git bisect  bad b73f975f76e48705feb505327cd888bb0ec9eb14  # 04:32  B  0 
1   15   0  btrfs: no need to check return value of debugfs_create functions
git bisect  bad 1aba551c73de605983515118d5ad527594440ccb  # 04:43  B  0
10   35  11  blk-mq: fix changelog
# first bad commit: [1aba551c73de605983515118d5ad527594440ccb] blk-mq: fix 
changelog
git bisect good 7d7009c53a3be411a6a790ac2788677db27d7286  # 04:48  G 30 
00   0  wireless: fix changelog
# extra tests with debug options
git bisect  bad 1aba551c73de605983515118d5ad527594440ccb  # 05:00  B  0
11   25   0  blk-mq: fix changelog
# extra tests on HEAD of drive

Re: 047fb56f7e ("blk-mq: fix changelog"): BUG: unable to handle kernel NULL pointer dereference at 00000030

[Greg Kroah-Hartman]

On Sun, Jan 06, 2019 at 01:18:42AM +0800, kernel test robot wrote:
> Greetings,
> 
> 0day kernel testing robot got the below dmesg and the first bad commit is
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git 
> debugfs_cleanup
> 
> commit 047fb56f7ecf53620d6e93fbcc8ca9166108d14c
> Author: Greg Kroah-Hartman 
> AuthorDate: Fri Jan 4 14:06:22 2019 +0100
> Commit: Greg Kroah-Hartman 
> CommitDate: Fri Jan 4 17:29:15 2019 +0100
> 
> blk-mq: fix changelog
> 
> 464573328e  wireless: fix changelog
> 047fb56f7e  blk-mq: fix changelog
> 24aeb03f70  lib: WIP, break up
> +--++++
> |  | 464573328e | 047fb56f7e | 
> 24aeb03f70 |
> +--++++
> | boot_successes   | 33 | 0  | 0  
> |
> | boot_failures| 0  | 13 | 19 
> |
> | BUG:unable_to_handle_kernel  | 0  | 13 | 19 
> |
> | Oops:#[##]   | 0  | 13 | 19 
> |
> | EIP:debugfs_create_files | 0  | 13 | 19 
> |
> | Kernel_panic-not_syncing:Fatal_exception | 0  | 13 | 19 
> |
> +--++++
> 
> [1.939685] toshiba: not a supported Toshiba laptop
> [1.940314] platform pc8736x_gpio.0: NatSemi pc8736x GPIO Driver 
> Initializing
> [1.941204] platform pc8736x_gpio.0: no device found
> [1.941848] nsc_gpio initializing
> [1.942249] Hangcheck: starting hangcheck timer 0.9.1 (tick is 180 
> seconds, margin is 60 seconds).
> [1.943923] BUG: unable to handle kernel NULL pointer dereference at 
> 0030
> [1.944889] #PF error: [normal kernel read fault]
> [1.945527] *pdpt =  *pde = f000ff53f000ff53 
> [1.946287] Oops:  [#1] SMP PTI
> [1.946760] CPU: 0 PID: 7 Comm: kworker/u4:0 Not tainted 
> 4.20.0-11088-g047fb56 #1
> [1.947149] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 
> 1.10.2-1 04/01/2014
> [1.947149] Workqueue: events_unbound async_run_entry_fn
> [1.947149] EIP: debugfs_create_files+0x9/0x50
> [1.947149] Code: 00 e8 db 11 52 00 8b 16 8b 4e 04 8d 83 c0 03 00 00 e8 4b 
> 24 da ff 5b 5e 5d c3 8d b4 26 00 00 00 00 55 89 e5 56 53 89 c6 89 cb <8b> 40 
> 30 89 90 14 02 00 00 8b 01 85 c0 74 26 90 8d b4 26 00 00 00
> [1.947149] EAX:  EBX:  ECX:  EDX: da18f800
> [1.947149] ESI:  EDI: da18f800 EBP: c005de24 ESP: c005de1c
> [1.947149] DS: 007b ES: 007b FS: 00d8 GS:  SS: 0068 EFLAGS: 00210246
> [1.947149] CR0: 80050033 CR2: 0030 CR3: 01da4000 CR4: 003406f0
> [1.947149] DR0:  DR1:  DR2:  DR3: 
> [1.947149] DR6: fffe0ff0 DR7: 0400
> [1.947149] Call Trace:
> [1.947149]  blk_mq_debugfs_register_sched_hctx+0x2f/0x40
> [1.947149]  blk_mq_init_sched+0x156/0x1c0
> [1.947149]  elevator_init_mq+0x4b/0x80
> [1.947149]  blk_mq_init_allocated_queue+0x409/0x460
> [1.947149]  blk_mq_init_queue+0x23/0x60
> [1.947149]  blk_mq_init_sq_queue+0x77/0x90
> [1.947149]  floppy_async_init+0xc0/0xd2c
> [1.947149]  ? __lock_acquire+0x35/0x860
> [1.947149]  async_run_entry_fn+0x2e/0xf0
> [1.947149]  process_one_work+0x195/0x3c0
> [1.947149]  ? process_one_work+0x176/0x3c0
> [1.947149]  worker_thread+0x39/0x3d0
> [1.947149]  kthread+0xda/0x110
> [1.947149]  ? process_one_work+0x3c0/0x3c0
> [1.947149]  ? kthread_park+0xa0/0xa0
> [1.947149]  ret_from_fork+0x19/0x30
> [1.947149] Modules linked in:
> [1.947149] CR2: 0030
> [1.947149] ---[ end trace 34fc82d8056f573a ]---
> [1.947150] BUG: unable to handle kernel NULL pointer dereference at 
> 0030

This is my fault, due to some debugfs patches I'm working on, it's not a
block-specific issue at the moment.

sorry for the noise.

greg k-h

[PATCH 048/124] staging: lustre: Flexible changelog format.

[James Simmons]

From: Henri Doreau <henri.dor...@cea.fr>

Added jobid fields to Changelog records (and extended records). The
CLF_JOBID flags allows to check if the field is present or not (old
format) when reading an entry. Jobids are expressed as 32 chars long,
zero-terminated strings. Updated test_205 in sanity.sh.

Signed-off-by: Henri Doreau <henri.dor...@cea.fr>
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-1996
Reviewed-on: http://review.whamcloud.com/4060
Reviewed-by: Andreas Dilger <andreas.dil...@intel.com>
Reviewed-by: Aurelien Degremont <aurelien.degrem...@cea.fr>
Signed-off-by: James Simmons <jsimm...@infradead.org>
---
 drivers/staging/lustre/lustre/include/cl_object.h  |2 +-
 .../lustre/lustre/include/lustre/lustre_idl.h  |   19 +--
 .../lustre/lustre/include/lustre/lustre_user.h |  165 +++-
 .../staging/lustre/lustre/llite/llite_internal.h   |2 +-
 drivers/staging/lustre/lustre/llite/vvp_req.c  |2 +-
 drivers/staging/lustre/lustre/mdc/mdc_request.c|   22 ++-
 drivers/staging/lustre/lustre/obdclass/class_obd.c |6 +-
 .../lustre/lustre/obdclass/linux/linux-module.c|2 +-
 drivers/staging/lustre/lustre/obdclass/llog.c  |4 +-
 drivers/staging/lustre/lustre/obdclass/llog_cat.c  |4 +-
 .../staging/lustre/lustre/obdclass/llog_internal.h |5 +
 drivers/staging/lustre/lustre/obdclass/llog_swab.c |   23 ++--
 .../staging/lustre/lustre/ptlrpc/pack_generic.c|2 +-
 drivers/staging/lustre/lustre/ptlrpc/wiretest.c|   54 +--
 14 files changed, 188 insertions(+), 124 deletions(-)

diff --git a/drivers/staging/lustre/lustre/include/cl_object.h 
b/drivers/staging/lustre/lustre/include/cl_object.h
index 5039643..5af1153 100644
--- a/drivers/staging/lustre/lustre/include/cl_object.h
+++ b/drivers/staging/lustre/lustre/include/cl_object.h
@@ -1899,7 +1899,7 @@ struct cl_req_attr {
/** Generic attributes for the server consumption. */
struct obdo *cra_oa;
/** Jobid */
-   char cra_jobid[JOBSTATS_JOBID_SIZE];
+   char cra_jobid[LUSTRE_JOBID_SIZE];
 };
 
 /**
diff --git a/drivers/staging/lustre/lustre/include/lustre/lustre_idl.h 
b/drivers/staging/lustre/lustre/include/lustre/lustre_idl.h
index 56b5129..2dc550a 100644
--- a/drivers/staging/lustre/lustre/include/lustre/lustre_idl.h
+++ b/drivers/staging/lustre/lustre/include/lustre/lustre_idl.h
@@ -1101,7 +1101,7 @@ struct lustre_msg_v2 {
 
 /* without gss, ptlrpc_body is put at the first buffer. */
 #define PTLRPC_NUM_VERSIONS 4
-#define JOBSTATS_JOBID_SIZE 32  /* 32 bytes string */
+
 struct ptlrpc_body_v3 {
struct lustre_handle pb_handle;
__u32 pb_type;
@@ -1123,7 +1123,7 @@ struct ptlrpc_body_v3 {
__u64 pb_pre_versions[PTLRPC_NUM_VERSIONS];
/* padding for future needs */
__u64 pb_padding[4];
-   char  pb_jobid[JOBSTATS_JOBID_SIZE];
+   char  pb_jobid[LUSTRE_JOBID_SIZE];
 };
 
 #define ptlrpc_body ptlrpc_body_v3
@@ -3088,15 +3088,9 @@ struct changelog_setinfo {
 
 /** changelog record */
 struct llog_changelog_rec {
-   struct llog_rec_hdr  cr_hdr;
-   struct changelog_rec cr;
-   struct llog_rec_tail cr_tail; /**< for_sizezof_only */
-} __packed;
-
-struct llog_changelog_ext_rec {
-   struct llog_rec_hdr  cr_hdr;
-   struct changelog_ext_rec cr;
-   struct llog_rec_tail cr_tail; /**< for_sizezof_only */
+   struct llog_rec_hdr cr_hdr;
+   struct changelog_reccr; /**< Variable length field */
+   struct llog_rec_tailcr_do_not_use;  /**< for_sizezof_only */
 } __packed;
 
 struct llog_changelog_user_rec {
@@ -3181,6 +3175,9 @@ enum llog_flag {
LLOG_F_ZAP_WHEN_EMPTY   = 0x1,
LLOG_F_IS_CAT   = 0x2,
LLOG_F_IS_PLAIN = 0x4,
+   LLOG_F_EXT_JOBID= BIT(3),
+
+   LLOG_F_EXT_MASK = LLOG_F_EXT_JOBID,
 };
 
 struct llog_log_hdr {
diff --git a/drivers/staging/lustre/lustre/include/lustre/lustre_user.h 
b/drivers/staging/lustre/lustre/include/lustre/lustre_user.h
index 79cd876..cc0a786 100644
--- a/drivers/staging/lustre/lustre/include/lustre/lustre_user.h
+++ b/drivers/staging/lustre/lustre/include/lustre/lustre_user.h
@@ -673,11 +673,16 @@ static inline const char *changelog_type2str(int type)
 }
 
 /* per-record flags */
-#define CLF_VERSION 0x1000
-#define CLF_EXT_VERSION 0x2000
 #define CLF_FLAGSHIFT   12
 #define CLF_FLAGMASK((1U << CLF_FLAGSHIFT) - 1)
 #define CLF_VERMASK (~CLF_FLAGMASK)
+enum changelog_rec_flags {
+   CLF_VERSION = 0x1000,
+   CLF_RENAME  = 0x2000,
+   CLF_JOBID   = 0x4000,
+   CLF_SUPPORTED   = CLF_VERSION | CLF_RENAME | CLF_JOBID
+};
+
 /* Anything under the flagmask may be per-type (if desired) */
 /* Flags for unlink */
 #define CLF_UNLINK_LAST   0x0001 /* Unlink of last hardlink */
@@ -761,12 +766,35 @@ static inline void hsm_set_cl_error

[PATCH 048/124] staging: lustre: Flexible changelog format.

[James Simmons]

From: Henri Doreau 

Added jobid fields to Changelog records (and extended records). The
CLF_JOBID flags allows to check if the field is present or not (old
format) when reading an entry. Jobids are expressed as 32 chars long,
zero-terminated strings. Updated test_205 in sanity.sh.

Signed-off-by: Henri Doreau 
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-1996
Reviewed-on: http://review.whamcloud.com/4060
Reviewed-by: Andreas Dilger 
Reviewed-by: Aurelien Degremont 
Signed-off-by: James Simmons 
---
 drivers/staging/lustre/lustre/include/cl_object.h  |2 +-
 .../lustre/lustre/include/lustre/lustre_idl.h  |   19 +--
 .../lustre/lustre/include/lustre/lustre_user.h |  165 +++-
 .../staging/lustre/lustre/llite/llite_internal.h   |2 +-
 drivers/staging/lustre/lustre/llite/vvp_req.c  |2 +-
 drivers/staging/lustre/lustre/mdc/mdc_request.c|   22 ++-
 drivers/staging/lustre/lustre/obdclass/class_obd.c |6 +-
 .../lustre/lustre/obdclass/linux/linux-module.c|2 +-
 drivers/staging/lustre/lustre/obdclass/llog.c  |4 +-
 drivers/staging/lustre/lustre/obdclass/llog_cat.c  |4 +-
 .../staging/lustre/lustre/obdclass/llog_internal.h |5 +
 drivers/staging/lustre/lustre/obdclass/llog_swab.c |   23 ++--
 .../staging/lustre/lustre/ptlrpc/pack_generic.c|2 +-
 drivers/staging/lustre/lustre/ptlrpc/wiretest.c|   54 +--
 14 files changed, 188 insertions(+), 124 deletions(-)

diff --git a/drivers/staging/lustre/lustre/include/cl_object.h 
b/drivers/staging/lustre/lustre/include/cl_object.h
index 5039643..5af1153 100644
--- a/drivers/staging/lustre/lustre/include/cl_object.h
+++ b/drivers/staging/lustre/lustre/include/cl_object.h
@@ -1899,7 +1899,7 @@ struct cl_req_attr {
/** Generic attributes for the server consumption. */
struct obdo *cra_oa;
/** Jobid */
-   char cra_jobid[JOBSTATS_JOBID_SIZE];
+   char cra_jobid[LUSTRE_JOBID_SIZE];
 };
 
 /**
diff --git a/drivers/staging/lustre/lustre/include/lustre/lustre_idl.h 
b/drivers/staging/lustre/lustre/include/lustre/lustre_idl.h
index 56b5129..2dc550a 100644
--- a/drivers/staging/lustre/lustre/include/lustre/lustre_idl.h
+++ b/drivers/staging/lustre/lustre/include/lustre/lustre_idl.h
@@ -1101,7 +1101,7 @@ struct lustre_msg_v2 {
 
 /* without gss, ptlrpc_body is put at the first buffer. */
 #define PTLRPC_NUM_VERSIONS 4
-#define JOBSTATS_JOBID_SIZE 32  /* 32 bytes string */
+
 struct ptlrpc_body_v3 {
struct lustre_handle pb_handle;
__u32 pb_type;
@@ -1123,7 +1123,7 @@ struct ptlrpc_body_v3 {
__u64 pb_pre_versions[PTLRPC_NUM_VERSIONS];
/* padding for future needs */
__u64 pb_padding[4];
-   char  pb_jobid[JOBSTATS_JOBID_SIZE];
+   char  pb_jobid[LUSTRE_JOBID_SIZE];
 };
 
 #define ptlrpc_body ptlrpc_body_v3
@@ -3088,15 +3088,9 @@ struct changelog_setinfo {
 
 /** changelog record */
 struct llog_changelog_rec {
-   struct llog_rec_hdr  cr_hdr;
-   struct changelog_rec cr;
-   struct llog_rec_tail cr_tail; /**< for_sizezof_only */
-} __packed;
-
-struct llog_changelog_ext_rec {
-   struct llog_rec_hdr  cr_hdr;
-   struct changelog_ext_rec cr;
-   struct llog_rec_tail cr_tail; /**< for_sizezof_only */
+   struct llog_rec_hdr cr_hdr;
+   struct changelog_reccr; /**< Variable length field */
+   struct llog_rec_tailcr_do_not_use;  /**< for_sizezof_only */
 } __packed;
 
 struct llog_changelog_user_rec {
@@ -3181,6 +3175,9 @@ enum llog_flag {
LLOG_F_ZAP_WHEN_EMPTY   = 0x1,
LLOG_F_IS_CAT   = 0x2,
LLOG_F_IS_PLAIN = 0x4,
+   LLOG_F_EXT_JOBID= BIT(3),
+
+   LLOG_F_EXT_MASK = LLOG_F_EXT_JOBID,
 };
 
 struct llog_log_hdr {
diff --git a/drivers/staging/lustre/lustre/include/lustre/lustre_user.h 
b/drivers/staging/lustre/lustre/include/lustre/lustre_user.h
index 79cd876..cc0a786 100644
--- a/drivers/staging/lustre/lustre/include/lustre/lustre_user.h
+++ b/drivers/staging/lustre/lustre/include/lustre/lustre_user.h
@@ -673,11 +673,16 @@ static inline const char *changelog_type2str(int type)
 }
 
 /* per-record flags */
-#define CLF_VERSION 0x1000
-#define CLF_EXT_VERSION 0x2000
 #define CLF_FLAGSHIFT   12
 #define CLF_FLAGMASK((1U << CLF_FLAGSHIFT) - 1)
 #define CLF_VERMASK (~CLF_FLAGMASK)
+enum changelog_rec_flags {
+   CLF_VERSION = 0x1000,
+   CLF_RENAME  = 0x2000,
+   CLF_JOBID   = 0x4000,
+   CLF_SUPPORTED   = CLF_VERSION | CLF_RENAME | CLF_JOBID
+};
+
 /* Anything under the flagmask may be per-type (if desired) */
 /* Flags for unlink */
 #define CLF_UNLINK_LAST   0x0001 /* Unlink of last hardlink */
@@ -761,12 +766,35 @@ static inline void hsm_set_cl_error(int *flags, int error)
*flags |= (error << CLF_HSM_ERR_L);
 }
 
-#define CR_MAXSIZE cfs_size_round(2 * NAME_MAX + 1 + \
-   

[PATCH 067/124] staging: lustre: changelog: fix comparison between signed and unsigned

[James Simmons]

From: Dmitry Eremin 

Change type of changelog_*{namelen,size}() to size_t.
Fixed string specifier for unsigned types.

Signed-off-by: Dmitry Eremin 
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-5577
Reviewed-on: http://review.whamcloud.com/12474
Reviewed-by: James Simmons 
Reviewed-by: Andreas Dilger 
Reviewed-by: James Nunez 
Signed-off-by: James Simmons 
---
 .../lustre/lustre/include/lustre/lustre_user.h |   10 +-
 drivers/staging/lustre/lustre/llite/file.c |4 ++--
 2 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/staging/lustre/lustre/include/lustre/lustre_user.h 
b/drivers/staging/lustre/lustre/include/lustre/lustre_user.h
index de52339..e8f81a5 100644
--- a/drivers/staging/lustre/lustre/include/lustre/lustre_user.h
+++ b/drivers/staging/lustre/lustre/include/lustre/lustre_user.h
@@ -819,9 +819,9 @@ struct changelog_ext_jobid {
charcr_jobid[LUSTRE_JOBID_SIZE];/**< zero-terminated string. */
 };
 
-static inline unsigned int changelog_rec_offset(enum changelog_rec_flags crf)
+static inline size_t changelog_rec_offset(enum changelog_rec_flags crf)
 {
-   unsigned int size = sizeof(struct changelog_rec);
+   size_t size = sizeof(struct changelog_rec);
 
if (crf & CLF_RENAME)
size += sizeof(struct changelog_ext_rename);
@@ -832,12 +832,12 @@ static inline unsigned int changelog_rec_offset(enum 
changelog_rec_flags crf)
return size;
 }
 
-static inline int changelog_rec_size(struct changelog_rec *rec)
+static inline size_t changelog_rec_size(struct changelog_rec *rec)
 {
return changelog_rec_offset(rec->cr_flags);
 }
 
-static inline unsigned int changelog_rec_varsize(struct changelog_rec *rec)
+static inline size_t changelog_rec_varsize(struct changelog_rec *rec)
 {
return changelog_rec_size(rec) - sizeof(*rec) + rec->cr_namelen;
 }
@@ -869,7 +869,7 @@ static inline char *changelog_rec_name(struct changelog_rec 
*rec)
  CLF_SUPPORTED);
 }
 
-static inline int changelog_rec_snamelen(struct changelog_rec *rec)
+static inline size_t changelog_rec_snamelen(struct changelog_rec *rec)
 {
return rec->cr_namelen - strlen(changelog_rec_name(rec)) - 1;
 }
diff --git a/drivers/staging/lustre/lustre/llite/file.c 
b/drivers/staging/lustre/lustre/llite/file.c
index 4b10260..a562b11 100644
--- a/drivers/staging/lustre/lustre/llite/file.c
+++ b/drivers/staging/lustre/lustre/llite/file.c
@@ -1129,7 +1129,7 @@ ll_file_io_generic(const struct lu_env *env, struct 
vvp_io_args *args,
struct cl_io *io;
ssize_tresult;
 
-   CDEBUG(D_VFSTRACE, "file: %s, type: %d ppos: %llu, count: %zd\n",
+   CDEBUG(D_VFSTRACE, "file: %s, type: %d ppos: %llu, count: %zu\n",
   file->f_path.dentry->d_name.name, iot, *ppos, count);
 
 restart:
@@ -1207,7 +1207,7 @@ out:
 * short read/write instead of restart io.
 */
if ((result == 0 || result == -ENODATA) && io->ci_need_restart) {
-   CDEBUG(D_VFSTRACE, "Restart %s on %pD from %lld, count:%zd\n",
+   CDEBUG(D_VFSTRACE, "Restart %s on %pD from %lld, count:%zu\n",
   iot == CIT_READ ? "read" : "write",
   file, *ppos, count);
LASSERTF(io->ci_nob == 0, "%zd\n", io->ci_nob);
-- 
1.7.1

[PATCH 067/124] staging: lustre: changelog: fix comparison between signed and unsigned

[James Simmons]

From: Dmitry Eremin 

Change type of changelog_*{namelen,size}() to size_t.
Fixed string specifier for unsigned types.

Signed-off-by: Dmitry Eremin 
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-5577
Reviewed-on: http://review.whamcloud.com/12474
Reviewed-by: James Simmons 
Reviewed-by: Andreas Dilger 
Reviewed-by: James Nunez 
Signed-off-by: James Simmons 
---
 .../lustre/lustre/include/lustre/lustre_user.h |   10 +-
 drivers/staging/lustre/lustre/llite/file.c |4 ++--
 2 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/staging/lustre/lustre/include/lustre/lustre_user.h 
b/drivers/staging/lustre/lustre/include/lustre/lustre_user.h
index de52339..e8f81a5 100644
--- a/drivers/staging/lustre/lustre/include/lustre/lustre_user.h
+++ b/drivers/staging/lustre/lustre/include/lustre/lustre_user.h
@@ -819,9 +819,9 @@ struct changelog_ext_jobid {
charcr_jobid[LUSTRE_JOBID_SIZE];/**< zero-terminated string. */
 };
 
-static inline unsigned int changelog_rec_offset(enum changelog_rec_flags crf)
+static inline size_t changelog_rec_offset(enum changelog_rec_flags crf)
 {
-   unsigned int size = sizeof(struct changelog_rec);
+   size_t size = sizeof(struct changelog_rec);
 
if (crf & CLF_RENAME)
size += sizeof(struct changelog_ext_rename);
@@ -832,12 +832,12 @@ static inline unsigned int changelog_rec_offset(enum 
changelog_rec_flags crf)
return size;
 }
 
-static inline int changelog_rec_size(struct changelog_rec *rec)
+static inline size_t changelog_rec_size(struct changelog_rec *rec)
 {
return changelog_rec_offset(rec->cr_flags);
 }
 
-static inline unsigned int changelog_rec_varsize(struct changelog_rec *rec)
+static inline size_t changelog_rec_varsize(struct changelog_rec *rec)
 {
return changelog_rec_size(rec) - sizeof(*rec) + rec->cr_namelen;
 }
@@ -869,7 +869,7 @@ static inline char *changelog_rec_name(struct changelog_rec 
*rec)
  CLF_SUPPORTED);
 }
 
-static inline int changelog_rec_snamelen(struct changelog_rec *rec)
+static inline size_t changelog_rec_snamelen(struct changelog_rec *rec)
 {
return rec->cr_namelen - strlen(changelog_rec_name(rec)) - 1;
 }
diff --git a/drivers/staging/lustre/lustre/llite/file.c 
b/drivers/staging/lustre/lustre/llite/file.c
index 4b10260..a562b11 100644
--- a/drivers/staging/lustre/lustre/llite/file.c
+++ b/drivers/staging/lustre/lustre/llite/file.c
@@ -1129,7 +1129,7 @@ ll_file_io_generic(const struct lu_env *env, struct 
vvp_io_args *args,
struct cl_io *io;
ssize_tresult;
 
-   CDEBUG(D_VFSTRACE, "file: %s, type: %d ppos: %llu, count: %zd\n",
+   CDEBUG(D_VFSTRACE, "file: %s, type: %d ppos: %llu, count: %zu\n",
   file->f_path.dentry->d_name.name, iot, *ppos, count);
 
 restart:
@@ -1207,7 +1207,7 @@ out:
 * short read/write instead of restart io.
 */
if ((result == 0 || result == -ENODATA) && io->ci_need_restart) {
-   CDEBUG(D_VFSTRACE, "Restart %s on %pD from %lld, count:%zd\n",
+   CDEBUG(D_VFSTRACE, "Restart %s on %pD from %lld, count:%zu\n",
   iot == CIT_READ ? "read" : "write",
   file, *ppos, count);
LASSERTF(io->ci_nob == 0, "%zd\n", io->ci_nob);
-- 
1.7.1

[PATCH 074/124] staging: lustre: changelog: Proper record remapping

[James Simmons]

From: Henri Doreau 

Fixed changelog_remap_rec() to correctly remap records emitted
with jobid_var=disabled, i.e. delivered by new servers but with
no jobid field.

Signed-off-by: Henri Doreau 
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-5862
Reviewed-on: http://review.whamcloud.com/12574
Reviewed-by: Andreas Dilger 
Reviewed-by: Robert Read 
Signed-off-by: James Simmons 
---
 .../lustre/lustre/include/lustre/lustre_user.h |   66 +---
 1 files changed, 44 insertions(+), 22 deletions(-)

diff --git a/drivers/staging/lustre/lustre/include/lustre/lustre_user.h 
b/drivers/staging/lustre/lustre/include/lustre/lustre_user.h
index e8f81a5..ba679ad 100644
--- a/drivers/staging/lustre/lustre/include/lustre/lustre_user.h
+++ b/drivers/staging/lustre/lustre/include/lustre/lustre_user.h
@@ -881,41 +881,63 @@ static inline char *changelog_rec_sname(struct 
changelog_rec *rec)
return cr_name + strlen(cr_name) + 1;
 }
 
-/*
+/**
  * Remap a record to the desired format as specified by the crf flags.
  * The record must be big enough to contain the final remapped version.
+ * Superfluous extension fields are removed and missing ones are added
+ * and zeroed. The flags of the record are updated accordingly.
+ *
+ * The jobid and rename extensions can be added to a record, to match the
+ * format an application expects, typically. In this case, the newly added
+ * fields will be zeroed.
+ * The Jobid field can be removed, to guarantee compatibility with older
+ * clients that don't expect this field in the records they process.
+ *
+ * The following assumptions are being made:
+ * - CLF_RENAME will not be removed
+ * - CLF_JOBID will not be added without CLF_RENAME being added too
+ *
+ * @param[in,out]  rec The record to remap.
+ * @param[in] crf_wanted   Flags describing the desired extensions.
  */
 static inline void changelog_remap_rec(struct changelog_rec *rec,
-  enum changelog_rec_flags crf)
+  enum changelog_rec_flags crf_wanted)
 {
-   size_t var_size;
-   char *var_part;
+   char *jid_mov, *rnm_mov;
 
-   crf &= CLF_SUPPORTED;
+   crf_wanted &= CLF_SUPPORTED;
 
-   if ((rec->cr_flags & CLF_SUPPORTED) == crf)
+   if ((rec->cr_flags & CLF_SUPPORTED) == crf_wanted)
return;
 
-   if ((crf & CLF_JOBID) && rec->cr_flags & CLF_JOBID) {
-   var_part = (char *)changelog_rec_jobid(rec);
-   var_size = rec->cr_namelen + sizeof(struct changelog_ext_jobid);
-   } else {
-   var_part = changelog_rec_name(rec);
-   var_size = rec->cr_namelen;
-   }
+   /* First move the variable-length name field */
+   memmove((char *)rec + changelog_rec_offset(crf_wanted),
+   changelog_rec_name(rec), rec->cr_namelen);
+
+   /* Locations of jobid and rename extensions in the remapped record */
+   jid_mov = (char *)rec +
+ changelog_rec_offset(crf_wanted & ~CLF_JOBID);
+   rnm_mov = (char *)rec +
+ changelog_rec_offset(crf_wanted & ~(CLF_JOBID | CLF_RENAME));
+
+   /* Move the extension fields to the desired positions */
+   if ((crf_wanted & CLF_JOBID) && (rec->cr_flags & CLF_JOBID))
+   memmove(jid_mov, changelog_rec_jobid(rec),
+   sizeof(struct changelog_ext_jobid));
 
-   memmove((char *)rec + changelog_rec_offset(crf & ~CLF_JOBID), var_part,
-   var_size);
+   if ((crf_wanted & CLF_RENAME) && (rec->cr_flags & CLF_RENAME))
+   memmove(rnm_mov, changelog_rec_rename(rec),
+   sizeof(struct changelog_ext_rename));
 
-   if ((crf & CLF_RENAME) && !(rec->cr_flags & CLF_RENAME))
-   memset(changelog_rec_rename(rec), 0,
-  sizeof(struct changelog_ext_rename));
+   /* Clear newly added fields */
+   if ((crf_wanted & CLF_JOBID) && !(rec->cr_flags & CLF_JOBID))
+   memset(jid_mov, 0, sizeof(struct changelog_ext_jobid));
 
-   if ((crf & CLF_JOBID) && !(rec->cr_flags & CLF_JOBID))
-   memset(changelog_rec_jobid(rec), 0,
-  sizeof(struct changelog_ext_jobid));
+   if ((crf_wanted & CLF_RENAME) && !(rec->cr_flags & CLF_RENAME))
+   memset(rnm_mov, 0, sizeof(struct changelog_ext_rename));
 
-   rec->cr_flags = (rec->cr_flags & CLF_FLAGMASK) | crf;
+   /* Update the record's flags accordingly */
+   rec->cr_flags = (rec->cr_flags & CLF_FLAGMASK) | crf_wanted;
 }
 
 struct ioc_changelog {
-- 
1.7.1

[PATCH 074/124] staging: lustre: changelog: Proper record remapping

[James Simmons]

From: Henri Doreau 

Fixed changelog_remap_rec() to correctly remap records emitted
with jobid_var=disabled, i.e. delivered by new servers but with
no jobid field.

Signed-off-by: Henri Doreau 
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-5862
Reviewed-on: http://review.whamcloud.com/12574
Reviewed-by: Andreas Dilger 
Reviewed-by: Robert Read 
Signed-off-by: James Simmons 
---
 .../lustre/lustre/include/lustre/lustre_user.h |   66 +---
 1 files changed, 44 insertions(+), 22 deletions(-)

diff --git a/drivers/staging/lustre/lustre/include/lustre/lustre_user.h 
b/drivers/staging/lustre/lustre/include/lustre/lustre_user.h
index e8f81a5..ba679ad 100644
--- a/drivers/staging/lustre/lustre/include/lustre/lustre_user.h
+++ b/drivers/staging/lustre/lustre/include/lustre/lustre_user.h
@@ -881,41 +881,63 @@ static inline char *changelog_rec_sname(struct 
changelog_rec *rec)
return cr_name + strlen(cr_name) + 1;
 }
 
-/*
+/**
  * Remap a record to the desired format as specified by the crf flags.
  * The record must be big enough to contain the final remapped version.
+ * Superfluous extension fields are removed and missing ones are added
+ * and zeroed. The flags of the record are updated accordingly.
+ *
+ * The jobid and rename extensions can be added to a record, to match the
+ * format an application expects, typically. In this case, the newly added
+ * fields will be zeroed.
+ * The Jobid field can be removed, to guarantee compatibility with older
+ * clients that don't expect this field in the records they process.
+ *
+ * The following assumptions are being made:
+ * - CLF_RENAME will not be removed
+ * - CLF_JOBID will not be added without CLF_RENAME being added too
+ *
+ * @param[in,out]  rec The record to remap.
+ * @param[in] crf_wanted   Flags describing the desired extensions.
  */
 static inline void changelog_remap_rec(struct changelog_rec *rec,
-  enum changelog_rec_flags crf)
+  enum changelog_rec_flags crf_wanted)
 {
-   size_t var_size;
-   char *var_part;
+   char *jid_mov, *rnm_mov;
 
-   crf &= CLF_SUPPORTED;
+   crf_wanted &= CLF_SUPPORTED;
 
-   if ((rec->cr_flags & CLF_SUPPORTED) == crf)
+   if ((rec->cr_flags & CLF_SUPPORTED) == crf_wanted)
return;
 
-   if ((crf & CLF_JOBID) && rec->cr_flags & CLF_JOBID) {
-   var_part = (char *)changelog_rec_jobid(rec);
-   var_size = rec->cr_namelen + sizeof(struct changelog_ext_jobid);
-   } else {
-   var_part = changelog_rec_name(rec);
-   var_size = rec->cr_namelen;
-   }
+   /* First move the variable-length name field */
+   memmove((char *)rec + changelog_rec_offset(crf_wanted),
+   changelog_rec_name(rec), rec->cr_namelen);
+
+   /* Locations of jobid and rename extensions in the remapped record */
+   jid_mov = (char *)rec +
+ changelog_rec_offset(crf_wanted & ~CLF_JOBID);
+   rnm_mov = (char *)rec +
+ changelog_rec_offset(crf_wanted & ~(CLF_JOBID | CLF_RENAME));
+
+   /* Move the extension fields to the desired positions */
+   if ((crf_wanted & CLF_JOBID) && (rec->cr_flags & CLF_JOBID))
+   memmove(jid_mov, changelog_rec_jobid(rec),
+   sizeof(struct changelog_ext_jobid));
 
-   memmove((char *)rec + changelog_rec_offset(crf & ~CLF_JOBID), var_part,
-   var_size);
+   if ((crf_wanted & CLF_RENAME) && (rec->cr_flags & CLF_RENAME))
+   memmove(rnm_mov, changelog_rec_rename(rec),
+   sizeof(struct changelog_ext_rename));
 
-   if ((crf & CLF_RENAME) && !(rec->cr_flags & CLF_RENAME))
-   memset(changelog_rec_rename(rec), 0,
-  sizeof(struct changelog_ext_rename));
+   /* Clear newly added fields */
+   if ((crf_wanted & CLF_JOBID) && !(rec->cr_flags & CLF_JOBID))
+   memset(jid_mov, 0, sizeof(struct changelog_ext_jobid));
 
-   if ((crf & CLF_JOBID) && !(rec->cr_flags & CLF_JOBID))
-   memset(changelog_rec_jobid(rec), 0,
-  sizeof(struct changelog_ext_jobid));
+   if ((crf_wanted & CLF_RENAME) && !(rec->cr_flags & CLF_RENAME))
+   memset(rnm_mov, 0, sizeof(struct changelog_ext_rename));
 
-   rec->cr_flags = (rec->cr_flags & CLF_FLAGMASK) | crf;
+   /* Update the record's flags accordingly */
+   rec->cr_flags = (rec->cr_flags & CLF_FLAGMASK) | crf_wanted;
 }
 
 struct ioc_changelog {
-- 
1.7.1

[PATCH v2 26/84] staging/lustre: Remove server-side changelog defines

[green]

From: Oleg Drokin <gr...@linuxhacker.ru>

CHANGELOG_MAGIC, CHANGELOG_MINMASK, CHANGELOG_ALLMASK,
CHANGELOG_DEFMASK and CHANGELOG_USER_PREFIX are all unused
on the client.

Signed-off-by: Oleg Drokin <gr...@linuxhacker.ru>
---
 drivers/staging/lustre/lustre/include/lustre/lustre_idl.h | 11 ---
 1 file changed, 11 deletions(-)

diff --git a/drivers/staging/lustre/lustre/include/lustre/lustre_idl.h 
b/drivers/staging/lustre/lustre/include/lustre/lustre_idl.h
index 90ff181..d2f05e3 100644
--- a/drivers/staging/lustre/lustre/include/lustre/lustre_idl.h
+++ b/drivers/staging/lustre/lustre/include/lustre/lustre_idl.h
@@ -3039,15 +3039,6 @@ struct llog_size_change_rec {
struct llog_rec_taillsc_tail;
 } __packed;
 
-#define CHANGELOG_MAGIC 0xca103000
-
-/** \a changelog_rec_type's that can't be masked */
-#define CHANGELOG_MINMASK (1 << CL_MARK)
-/** bits covering all \a changelog_rec_type's */
-#define CHANGELOG_ALLMASK 0X
-/** default \a changelog_rec_type mask */
-#define CHANGELOG_DEFMASK CHANGELOG_ALLMASK & ~(1 << CL_ATIME | 1 << CL_CLOSE)
-
 /* changelog llog name, needed by client replicators */
 #define CHANGELOG_CATALOG "changelog_catalog"
 
@@ -3069,8 +3060,6 @@ struct llog_changelog_ext_rec {
struct llog_rec_tail cr_tail; /**< for_sizezof_only */
 } __packed;
 
-#define CHANGELOG_USER_PREFIX "cl"
-
 struct llog_changelog_user_rec {
struct llog_rec_hdr   cur_hdr;
__u32cur_id;
-- 
2.1.0

[PATCH v2 26/84] staging/lustre: Remove server-side changelog defines

[green]

From: Oleg Drokin 

CHANGELOG_MAGIC, CHANGELOG_MINMASK, CHANGELOG_ALLMASK,
CHANGELOG_DEFMASK and CHANGELOG_USER_PREFIX are all unused
on the client.

Signed-off-by: Oleg Drokin 
---
 drivers/staging/lustre/lustre/include/lustre/lustre_idl.h | 11 ---
 1 file changed, 11 deletions(-)

diff --git a/drivers/staging/lustre/lustre/include/lustre/lustre_idl.h 
b/drivers/staging/lustre/lustre/include/lustre/lustre_idl.h
index 90ff181..d2f05e3 100644
--- a/drivers/staging/lustre/lustre/include/lustre/lustre_idl.h
+++ b/drivers/staging/lustre/lustre/include/lustre/lustre_idl.h
@@ -3039,15 +3039,6 @@ struct llog_size_change_rec {
struct llog_rec_taillsc_tail;
 } __packed;
 
-#define CHANGELOG_MAGIC 0xca103000
-
-/** \a changelog_rec_type's that can't be masked */
-#define CHANGELOG_MINMASK (1 << CL_MARK)
-/** bits covering all \a changelog_rec_type's */
-#define CHANGELOG_ALLMASK 0X
-/** default \a changelog_rec_type mask */
-#define CHANGELOG_DEFMASK CHANGELOG_ALLMASK & ~(1 << CL_ATIME | 1 << CL_CLOSE)
-
 /* changelog llog name, needed by client replicators */
 #define CHANGELOG_CATALOG "changelog_catalog"
 
@@ -3069,8 +3060,6 @@ struct llog_changelog_ext_rec {
struct llog_rec_tail cr_tail; /**< for_sizezof_only */
 } __packed;
 
-#define CHANGELOG_USER_PREFIX "cl"
-
 struct llog_changelog_user_rec {
struct llog_rec_hdr   cur_hdr;
__u32cur_id;
-- 
2.1.0

[PATCH 26/56] staging/lustre: Remove server-side changelog defines

[green]

From: Oleg Drokin <gr...@linuxhacker.ru>

CHANGELOG_MAGIC, CHANGELOG_MINMASK, CHANGELOG_ALLMASK,
CHANGELOG_DEFMASK and CHANGELOG_USER_PREFIX are all unused
on the client.

Signed-off-by: Oleg Drokin <gr...@linuxhacker.ru>
---
 drivers/staging/lustre/lustre/include/lustre/lustre_idl.h | 11 ---
 1 file changed, 11 deletions(-)

diff --git a/drivers/staging/lustre/lustre/include/lustre/lustre_idl.h 
b/drivers/staging/lustre/lustre/include/lustre/lustre_idl.h
index 90ff181..d2f05e3 100644
--- a/drivers/staging/lustre/lustre/include/lustre/lustre_idl.h
+++ b/drivers/staging/lustre/lustre/include/lustre/lustre_idl.h
@@ -3039,15 +3039,6 @@ struct llog_size_change_rec {
struct llog_rec_taillsc_tail;
 } __packed;
 
-#define CHANGELOG_MAGIC 0xca103000
-
-/** \a changelog_rec_type's that can't be masked */
-#define CHANGELOG_MINMASK (1 << CL_MARK)
-/** bits covering all \a changelog_rec_type's */
-#define CHANGELOG_ALLMASK 0X
-/** default \a changelog_rec_type mask */
-#define CHANGELOG_DEFMASK CHANGELOG_ALLMASK & ~(1 << CL_ATIME | 1 << CL_CLOSE)
-
 /* changelog llog name, needed by client replicators */
 #define CHANGELOG_CATALOG "changelog_catalog"
 
@@ -3069,8 +3060,6 @@ struct llog_changelog_ext_rec {
struct llog_rec_tail cr_tail; /**< for_sizezof_only */
 } __packed;
 
-#define CHANGELOG_USER_PREFIX "cl"
-
 struct llog_changelog_user_rec {
struct llog_rec_hdr   cur_hdr;
__u32cur_id;
-- 
2.1.0

[PATCH 26/56] staging/lustre: Remove server-side changelog defines

[green]

From: Oleg Drokin 

CHANGELOG_MAGIC, CHANGELOG_MINMASK, CHANGELOG_ALLMASK,
CHANGELOG_DEFMASK and CHANGELOG_USER_PREFIX are all unused
on the client.

Signed-off-by: Oleg Drokin 
---
 drivers/staging/lustre/lustre/include/lustre/lustre_idl.h | 11 ---
 1 file changed, 11 deletions(-)

diff --git a/drivers/staging/lustre/lustre/include/lustre/lustre_idl.h 
b/drivers/staging/lustre/lustre/include/lustre/lustre_idl.h
index 90ff181..d2f05e3 100644
--- a/drivers/staging/lustre/lustre/include/lustre/lustre_idl.h
+++ b/drivers/staging/lustre/lustre/include/lustre/lustre_idl.h
@@ -3039,15 +3039,6 @@ struct llog_size_change_rec {
struct llog_rec_taillsc_tail;
 } __packed;
 
-#define CHANGELOG_MAGIC 0xca103000
-
-/** \a changelog_rec_type's that can't be masked */
-#define CHANGELOG_MINMASK (1 << CL_MARK)
-/** bits covering all \a changelog_rec_type's */
-#define CHANGELOG_ALLMASK 0X
-/** default \a changelog_rec_type mask */
-#define CHANGELOG_DEFMASK CHANGELOG_ALLMASK & ~(1 << CL_ATIME | 1 << CL_CLOSE)
-
 /* changelog llog name, needed by client replicators */
 #define CHANGELOG_CATALOG "changelog_catalog"
 
@@ -3069,8 +3060,6 @@ struct llog_changelog_ext_rec {
struct llog_rec_tail cr_tail; /**< for_sizezof_only */
 } __packed;
 
-#define CHANGELOG_USER_PREFIX "cl"
-
 struct llog_changelog_user_rec {
struct llog_rec_hdr   cur_hdr;
__u32cur_id;
-- 
2.1.0

[PATCH V2 2/3] EDAC, amd64_edac: Update copyright and remove changelog

[Aravind Gopalakrishnan]

Git provides us all the changelogs anyway. So trimming
the comments section here.

Updated the copyrights info while at it.

Signed-off-by: Aravind Gopalakrishnan 
---
 drivers/edac/amd64_edac.h | 56 +--
 1 file changed, 1 insertion(+), 55 deletions(-)

diff --git a/drivers/edac/amd64_edac.h b/drivers/edac/amd64_edac.h
index 971dc12..c0f248f 100644
--- a/drivers/edac/amd64_edac.h
+++ b/drivers/edac/amd64_edac.h
@@ -2,64 +2,10 @@
  * AMD64 class Memory Controller kernel module
  *
  * Copyright (c) 2009 SoftwareBitMaker.
- * Copyright (c) 2009 Advanced Micro Devices, Inc.
+ * Copyright (c) 2009-15 Advanced Micro Devices, Inc.
  *
  * This file may be distributed under the terms of the
  * GNU General Public License.
- *
- * Originally Written by Thayne Harbaugh
- *
- *  Changes by Douglas "norsk" Thompson  :
- * - K8 CPU Revision D and greater support
- *
- *  Changes by Dave Peterson  :
- * - Module largely rewritten, with new (and hopefully correct)
- * code for dealing with node and chip select interleaving,
- * various code cleanup, and bug fixes
- * - Added support for memory hoisting using DRAM hole address
- * register
- *
- * Changes by Douglas "norsk" Thompson :
- * -K8 Rev (1207) revision support added, required Revision
- * specific mini-driver code to support Rev F as well as
- * prior revisions
- *
- * Changes by Douglas "norsk" Thompson :
- * -Family 10h revision support added. New PCI Device IDs,
- * indicating new changes. Actual registers modified
- * were slight, less than the Rev E to Rev F transition
- * but changing the PCI Device ID was the proper thing to
- * do, as it provides for almost automactic family
- * detection. The mods to Rev F required more family
- * information detection.
- *
- * Changes/Fixes by Borislav Petkov :
- * - misc fixes and code cleanups
- *
- * This module is based on the following documents
- * (available from http://www.amd.com/):
- *
- * Title:  BIOS and Kernel Developer's Guide for AMD Athlon 64 and AMD
- * Opteron Processors
- * AMD publication #: 26094
- *`Revision: 3.26
- *
- * Title:  BIOS and Kernel Developer's Guide for AMD NPT Family 0Fh
- * Processors
- * AMD publication #: 32559
- * Revision: 3.00
- * Issue Date: May 2006
- *
- * Title:  BIOS and Kernel Developer's Guide (BKDG) For AMD Family 10h
- * Processors
- * AMD publication #: 31116
- * Revision: 3.00
- * Issue Date: September 07, 2007
- *
- * Sections in the first 2 documents are no longer in sync with each other.
- * The Family 10h BKDG was totally re-written from scratch with a new
- * presentation model.
- * Therefore, comments that refer to a Document section might be off.
  */
 
 #include 
-- 
2.4.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH V2 2/3] EDAC, amd64_edac: Update copyright and remove changelog

[Aravind Gopalakrishnan]

Git provides us all the changelogs anyway. So trimming
the comments section here.

Updated the copyrights info while at it.

Signed-off-by: Aravind Gopalakrishnan 
---
 drivers/edac/amd64_edac.h | 56 +--
 1 file changed, 1 insertion(+), 55 deletions(-)

diff --git a/drivers/edac/amd64_edac.h b/drivers/edac/amd64_edac.h
index 971dc12..c0f248f 100644
--- a/drivers/edac/amd64_edac.h
+++ b/drivers/edac/amd64_edac.h
@@ -2,64 +2,10 @@
  * AMD64 class Memory Controller kernel module
  *
  * Copyright (c) 2009 SoftwareBitMaker.
- * Copyright (c) 2009 Advanced Micro Devices, Inc.
+ * Copyright (c) 2009-15 Advanced Micro Devices, Inc.
  *
  * This file may be distributed under the terms of the
  * GNU General Public License.
- *
- * Originally Written by Thayne Harbaugh
- *
- *  Changes by Douglas "norsk" Thompson  :
- * - K8 CPU Revision D and greater support
- *
- *  Changes by Dave Peterson  :
- * - Module largely rewritten, with new (and hopefully correct)
- * code for dealing with node and chip select interleaving,
- * various code cleanup, and bug fixes
- * - Added support for memory hoisting using DRAM hole address
- * register
- *
- * Changes by Douglas "norsk" Thompson :
- * -K8 Rev (1207) revision support added, required Revision
- * specific mini-driver code to support Rev F as well as
- * prior revisions
- *
- * Changes by Douglas "norsk" Thompson :
- * -Family 10h revision support added. New PCI Device IDs,
- * indicating new changes. Actual registers modified
- * were slight, less than the Rev E to Rev F transition
- * but changing the PCI Device ID was the proper thing to
- * do, as it provides for almost automactic family
- * detection. The mods to Rev F required more family
- * information detection.
- *
- * Changes/Fixes by Borislav Petkov :
- * - misc fixes and code cleanups
- *
- * This module is based on the following documents
- * (available from http://www.amd.com/):
- *
- * Title:  BIOS and Kernel Developer's Guide for AMD Athlon 64 and AMD
- * Opteron Processors
- * AMD publication #: 26094
- *`Revision: 3.26
- *
- * Title:  BIOS and Kernel Developer's Guide for AMD NPT Family 0Fh
- * Processors
- * AMD publication #: 32559
- * Revision: 3.00
- * Issue Date: May 2006
- *
- * Title:  BIOS and Kernel Developer's Guide (BKDG) For AMD Family 10h
- * Processors
- * AMD publication #: 31116
- * Revision: 3.00
- * Issue Date: September 07, 2007
- *
- * Sections in the first 2 documents are no longer in sync with each other.
- * The Family 10h BKDG was totally re-written from scratch with a new
- * presentation model.
- * Therefore, comments that refer to a Document section might be off.
  */
 
 #include 
-- 
2.4.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v2 0/2] changelog

[Thomas Gleixner]

On Fri, 18 Sep 2015, Oleksij Rempel wrote:

'changelog' is not really a descriptive subject line for a cover
letter.

Thanks,

tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v2 0/2] changelog

[Marc Zyngier]

On Fri, 18 Sep 2015 11:18:40 +0200
Oleksij Rempel  wrote:

Hi Oleksij,

> v2:
> - move some parts from patch 2 to 1
> - make separate irq_chip for ICOLL and ASM9260 
> 
> Oleksij Rempel (2):
>   ARM: irqchip: mxs: prepare driver for HW with different offsets
>   ARM: irqchip: mxs: add Alpascale ASM9260 support
> 
>  drivers/irqchip/Kconfig|   5 +
>  drivers/irqchip/Makefile   |   2 +-
>  drivers/irqchip/alphascale_asm9260-icoll.h | 109 +
>  drivers/irqchip/irq-mxs.c  | 188 
> ++---
>  4 files changed, 286 insertions(+), 18 deletions(-)
>  create mode 100644 drivers/irqchip/alphascale_asm9260-icoll.h
> 

Next time, please add a sensible title to your cover letter. Something
like "Add support for ASM9260 interrupt controller". "changelog" is
hardly a useful subject when you're dealing with a few dozen of patches
at the same time.

Thanks,

M.
-- 
Jazz is not dead. It just smells funny.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH v2 0/2] changelog

[Oleksij Rempel]

v2:
- move some parts from patch 2 to 1
- make separate irq_chip for ICOLL and ASM9260 

Oleksij Rempel (2):
  ARM: irqchip: mxs: prepare driver for HW with different offsets
  ARM: irqchip: mxs: add Alpascale ASM9260 support

 drivers/irqchip/Kconfig|   5 +
 drivers/irqchip/Makefile   |   2 +-
 drivers/irqchip/alphascale_asm9260-icoll.h | 109 +
 drivers/irqchip/irq-mxs.c  | 188 ++---
 4 files changed, 286 insertions(+), 18 deletions(-)
 create mode 100644 drivers/irqchip/alphascale_asm9260-icoll.h

-- 
2.5.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v2 0/2] changelog

[Marc Zyngier]

On Fri, 18 Sep 2015 11:18:40 +0200
Oleksij Rempel <li...@rempel-privat.de> wrote:

Hi Oleksij,

> v2:
> - move some parts from patch 2 to 1
> - make separate irq_chip for ICOLL and ASM9260 
> 
> Oleksij Rempel (2):
>   ARM: irqchip: mxs: prepare driver for HW with different offsets
>   ARM: irqchip: mxs: add Alpascale ASM9260 support
> 
>  drivers/irqchip/Kconfig|   5 +
>  drivers/irqchip/Makefile   |   2 +-
>  drivers/irqchip/alphascale_asm9260-icoll.h | 109 +
>  drivers/irqchip/irq-mxs.c  | 188 
> ++---
>  4 files changed, 286 insertions(+), 18 deletions(-)
>  create mode 100644 drivers/irqchip/alphascale_asm9260-icoll.h
> 

Next time, please add a sensible title to your cover letter. Something
like "Add support for ASM9260 interrupt controller". "changelog" is
hardly a useful subject when you're dealing with a few dozen of patches
at the same time.

Thanks,

M.
-- 
Jazz is not dead. It just smells funny.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v2 0/2] changelog

[Thomas Gleixner]

On Fri, 18 Sep 2015, Oleksij Rempel wrote:

'changelog' is not really a descriptive subject line for a cover
letter.

Thanks,

tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH v2 0/2] changelog

[Oleksij Rempel]

v2:
- move some parts from patch 2 to 1
- make separate irq_chip for ICOLL and ASM9260 

Oleksij Rempel (2):
  ARM: irqchip: mxs: prepare driver for HW with different offsets
  ARM: irqchip: mxs: add Alpascale ASM9260 support

 drivers/irqchip/Kconfig|   5 +
 drivers/irqchip/Makefile   |   2 +-
 drivers/irqchip/alphascale_asm9260-icoll.h | 109 +
 drivers/irqchip/irq-mxs.c  | 188 ++---
 4 files changed, 286 insertions(+), 18 deletions(-)
 create mode 100644 drivers/irqchip/alphascale_asm9260-icoll.h

-- 
2.5.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 07/19] staging/lustre/llite: deny non-root user for changelog operations

[green]

From: Niu Yawei 

To avoid potential security problems, non-privileged users should
have no permission to run 'lfs changelog' & 'lfs changelog_clear'.

Signed-off-by: Niu Yawei 
Reviewed-on: http://review.whamcloud.com/14280
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6415
Reviewed-by: Lai Siyao 
Reviewed-by: Jinshan Xiong 
Signed-off-by: Oleg Drokin 
---
 drivers/staging/lustre/lustre/llite/dir.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/staging/lustre/lustre/llite/dir.c 
b/drivers/staging/lustre/lustre/llite/dir.c
index d407fcc..cc6f0f5 100644
--- a/drivers/staging/lustre/lustre/llite/dir.c
+++ b/drivers/staging/lustre/lustre/llite/dir.c
@@ -1734,6 +1734,9 @@ out_quotactl:
}
case OBD_IOC_CHANGELOG_SEND:
case OBD_IOC_CHANGELOG_CLEAR:
+   if (!capable(CFS_CAP_SYS_ADMIN))
+   return -EPERM;
+
rc = copy_and_ioctl(cmd, sbi->ll_md_exp, (void *)arg,
sizeof(struct ioc_changelog));
return rc;
-- 
2.1.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 07/19] staging/lustre/llite: deny non-root user for changelog operations

[green]

From: Niu Yawei <yawei@intel.com>

To avoid potential security problems, non-privileged users should
have no permission to run 'lfs changelog' & 'lfs changelog_clear'.

Signed-off-by: Niu Yawei <yawei@intel.com>
Reviewed-on: http://review.whamcloud.com/14280
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6415
Reviewed-by: Lai Siyao <lai.si...@intel.com>
Reviewed-by: Jinshan Xiong <jinshan.xi...@intel.com>
Signed-off-by: Oleg Drokin <oleg.dro...@intel.com>
---
 drivers/staging/lustre/lustre/llite/dir.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/staging/lustre/lustre/llite/dir.c 
b/drivers/staging/lustre/lustre/llite/dir.c
index d407fcc..cc6f0f5 100644
--- a/drivers/staging/lustre/lustre/llite/dir.c
+++ b/drivers/staging/lustre/lustre/llite/dir.c
@@ -1734,6 +1734,9 @@ out_quotactl:
}
case OBD_IOC_CHANGELOG_SEND:
case OBD_IOC_CHANGELOG_CLEAR:
+   if (!capable(CFS_CAP_SYS_ADMIN))
+   return -EPERM;
+
rc = copy_and_ioctl(cmd, sbi->ll_md_exp, (void *)arg,
sizeof(struct ioc_changelog));
return rc;
-- 
2.1.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] checkpatch: Emit an error when there's a diff in a changelog

[Joe Perches]

People often put diff snippets in changelogs.  This causes problems
when one tries to apply a file containing both the changelog and the
diff because patch(1) tries to apply the diff which it found in the
changelog.

Warn once when what seems to be a diff snippet in the changelog exists.

Suggested-by: Andrew Morton 
Signed-off-by: Joe Perches 
---
 scripts/checkpatch.pl | 15 ++-
 1 file changed, 14 insertions(+), 1 deletion(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 69c4716..86e4fb1 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -1954,6 +1954,7 @@ sub process {
my $in_header_lines = $file ? 0 : 1;
my $in_commit_log = 0;  #Scanning lines before patch
my $commit_log_long_line = 0;
+   my $commit_log_has_diff = 0;
my $reported_maintainer_file = 0;
my $non_utf8_charset = 0;
 
@@ -2087,7 +2088,8 @@ sub process {
my $rawline = $rawlines[$linenr - 1];
 
 #extract the line range in the file after the patch is applied
-   if ($line=~/^\@\@ -\d+(?:,\d+)? \+(\d+)(,(\d+))? \@\@/) {
+   if (!$in_commit_log &&
+   $line =~ /^\@\@ -\d+(?:,\d+)? \+(\d+)(,(\d+))? \@\@/) {
$is_patch = 1;
$first_line = $linenr + 1;
$realline=$1-1;
@@ -2181,6 +2183,17 @@ sub process {
 
$cnt_lines++ if ($realcnt != 0);
 
+# Check if the commit log has what seems like a diff which can confuse patch
+   if ($in_commit_log && !$commit_log_has_diff &&
+   (($line =~ m@^\s+diff\b.*a/[\w/]+@ &&
+ $line =~ m@^\s+diff\b.*a/([\w/]+)\s+b/$1\b@) ||
+$line =~ m@^\s*(?:\-\-\-\s+a/|\+\+\+\s+b/)@ ||
+$line =~ m/^\s*\@\@ \-\d+,\d+ \+\d+,\d+ \@\@/)) {
+   ERROR("DIFF_IN_COMMIT_MSG",
+ "Avoid using diff content in the commit message - 
patch(1) might not work\n" . $herecurr);
+   $commit_log_has_diff = 1;
+   }
+
 # Check for incorrect file permissions
if ($line =~ /^new (file )?mode.*[7531]\d{0,2}$/) {
my $permhere = $here . "FILE: $realfile\n";


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] checkpatch: Emit an error when there's a diff in a changelog

[Joe Perches]

People often put diff snippets in changelogs.  This causes problems
when one tries to apply a file containing both the changelog and the
diff because patch(1) tries to apply the diff which it found in the
changelog.

Warn once when what seems to be a diff snippet in the changelog exists.

Suggested-by: Andrew Morton a...@linux-foundation.org
Signed-off-by: Joe Perches j...@perches.com
---
 scripts/checkpatch.pl | 15 ++-
 1 file changed, 14 insertions(+), 1 deletion(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 69c4716..86e4fb1 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -1954,6 +1954,7 @@ sub process {
my $in_header_lines = $file ? 0 : 1;
my $in_commit_log = 0;  #Scanning lines before patch
my $commit_log_long_line = 0;
+   my $commit_log_has_diff = 0;
my $reported_maintainer_file = 0;
my $non_utf8_charset = 0;
 
@@ -2087,7 +2088,8 @@ sub process {
my $rawline = $rawlines[$linenr - 1];
 
 #extract the line range in the file after the patch is applied
-   if ($line=~/^\@\@ -\d+(?:,\d+)? \+(\d+)(,(\d+))? \@\@/) {
+   if (!$in_commit_log 
+   $line =~ /^\@\@ -\d+(?:,\d+)? \+(\d+)(,(\d+))? \@\@/) {
$is_patch = 1;
$first_line = $linenr + 1;
$realline=$1-1;
@@ -2181,6 +2183,17 @@ sub process {
 
$cnt_lines++ if ($realcnt != 0);
 
+# Check if the commit log has what seems like a diff which can confuse patch
+   if ($in_commit_log  !$commit_log_has_diff 
+   (($line =~ m@^\s+diff\b.*a/[\w/]+@ 
+ $line =~ m@^\s+diff\b.*a/([\w/]+)\s+b/$1\b@) ||
+$line =~ m@^\s*(?:\-\-\-\s+a/|\+\+\+\s+b/)@ ||
+$line =~ m/^\s*\@\@ \-\d+,\d+ \+\d+,\d+ \@\@/)) {
+   ERROR(DIFF_IN_COMMIT_MSG,
+ Avoid using diff content in the commit message - 
patch(1) might not work\n . $herecurr);
+   $commit_log_has_diff = 1;
+   }
+
 # Check for incorrect file permissions
if ($line =~ /^new (file )?mode.*[7531]\d{0,2}$/) {
my $permhere = $here . FILE: $realfile\n;


--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

changelog v2

[Marcus Folkesson]

Changes since v2:
Change commit message to be more descriptive (thanks to Julia for input)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

changelog v2

[Marcus Folkesson]

Changes since v2:
Change commit message to be more descriptive (thanks to Julia for input)

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[tip:x86/microcode] x86/cpu/microcode: Zap changelog

[tip-bot for Borislav Petkov]

Commit-ID:  6b44e72a1c45d1a4e903af75611235a2d6ea25e3
Gitweb: http://git.kernel.org/tip/6b44e72a1c45d1a4e903af75611235a2d6ea25e3
Author: Borislav Petkov 
AuthorDate: Mon, 11 May 2015 10:15:47 +0200
Committer:  Ingo Molnar 
CommitDate: Mon, 11 May 2015 10:27:09 +0200

x86/cpu/microcode: Zap changelog

It is useless at best and git history has it all detailed
anyway. Update copyright while at it.

Signed-off-by: Borislav Petkov 
Cc: Andy Lutomirski 
Cc: Borislav Petkov 
Cc: Brian Gerst 
Cc: Denys Vlasenko 
Cc: H. Peter Anvin 
Cc: Linus Torvalds 
Cc: Peter Zijlstra 
Cc: Thomas Gleixner 
Link: http://lkml.kernel.org/r/1431332153-18566-3-git-send-email...@alien8.de
Signed-off-by: Ingo Molnar 
---
 arch/x86/kernel/cpu/microcode/core.c  | 76 +--
 arch/x86/kernel/cpu/microcode/intel.c | 75 --
 2 files changed, 16 insertions(+), 135 deletions(-)

diff --git a/arch/x86/kernel/cpu/microcode/core.c 
b/arch/x86/kernel/cpu/microcode/core.c
index 36a8361..6236a54 100644
--- a/arch/x86/kernel/cpu/microcode/core.c
+++ b/arch/x86/kernel/cpu/microcode/core.c
@@ -1,74 +1,16 @@
 /*
- * Intel CPU Microcode Update Driver for Linux
+ * CPU Microcode Update Driver for Linux
  *
- * Copyright (C) 2000-2006 Tigran Aivazian 
- *   2006  Shaohua Li 
+ * Copyright (C) 2000-2006 Tigran Aivazian 
+ *   2006  Shaohua Li 
+ *   2013-2015 Borislav Petkov 
  *
- * This driver allows to upgrade microcode on Intel processors
- * belonging to IA-32 family - PentiumPro, Pentium II,
- * Pentium III, Xeon, Pentium 4, etc.
+ * This driver allows to upgrade microcode on x86 processors.
  *
- * Reference: Section 8.11 of Volume 3a, IA-32 Intel? Architecture
- * Software Developer's Manual
- * Order Number 253668 or free download from:
- *
- * http://developer.intel.com/Assets/PDF/manual/253668.pdf 
- *
- * For more information, go to http://www.urbanmyth.org/microcode
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License
- * as published by the Free Software Foundation; either version
- * 2 of the License, or (at your option) any later version.
- *
- * 1.0 16 Feb 2000, Tigran Aivazian 
- * Initial release.
- * 1.0118 Feb 2000, Tigran Aivazian 
- * Added read() support + cleanups.
- * 1.0221 Feb 2000, Tigran Aivazian 
- * Added 'device trimming' support. open(O_WRONLY) zeroes
- * and frees the saved copy of applied microcode.
- * 1.0329 Feb 2000, Tigran Aivazian 
- * Made to use devfs (/dev/cpu/microcode) + cleanups.
- * 1.0406 Jun 2000, Simon Trimmer 
- * Added misc device support (now uses both devfs and misc).
- * Added MICROCODE_IOCFREE ioctl to clear memory.
- * 1.0509 Jun 2000, Simon Trimmer 
- * Messages for error cases (non Intel & no suitable microcode).
- * 1.0603 Aug 2000, Tigran Aivazian 
- * Removed ->release(). Removed exclusive open and status bitmap.
- * Added microcode_rwsem to serialize read()/write()/ioctl().
- * Removed global kernel lock usage.
- * 1.0707 Sep 2000, Tigran Aivazian 
- * Write 0 to 0x8B msr and then cpuid before reading revision,
- * so that it works even if there were no update done by the
- * BIOS. Otherwise, reading from 0x8B gives junk (which happened
- * to be 0 on my machine which is why it worked even when I
- * disabled update by the BIOS)
- * Thanks to Eric W. Biederman  for the fix.
- * 1.0811 Dec 2000, Richard Schaal  and
- *  Tigran Aivazian 
- * Intel Pentium 4 processor support and bugfixes.
- * 1.0930 Oct 2001, Tigran Aivazian 
- * Bugfix for HT (Hyper-Threading) enabled processors
- * whereby processor resources are shared by all logical processors
- * in a single CPU package.
- * 1.1028 Feb 2002 Asit K Mallick  and
- * Tigran Aivazian ,
- * Serialize updates as required on HT processors due to
- * speculative nature of implementation.
- * 1.1122 Mar 2002 Tigran Aivazian 
- * Fix the panic when writing zero-length microcode chunk.
- * 1.1229 Sep 2003 Nitin Kamble ,
- * Jun Nakajima 
- * Support for the microcode updates in the new format.
- * 1.1310 Oct 2003 Tigran Aivazian 
- * Removed ->read() method and obsoleted MICROCODE_IOCFREE ioctl
- * because we no longer hold a copy of applied microcode
- * in kernel memory.
- * 1.1425 Jun 2004 Tigran Aivazian 
- * Fix sigmatch() macro to handle old CPUs with pf == 0.
- * Thanks to Stu

[PATCH] x86/cpu/microcode: Zap changelog

[Borislav Petkov]

From: Borislav Petkov 

It is useless at best and git history has it all detailed anyway. Update
copyright while at it.

Signed-off-by: Borislav Petkov 
---
 arch/x86/kernel/cpu/microcode/core.c  | 76 +--
 arch/x86/kernel/cpu/microcode/intel.c | 75 --
 2 files changed, 16 insertions(+), 135 deletions(-)

diff --git a/arch/x86/kernel/cpu/microcode/core.c 
b/arch/x86/kernel/cpu/microcode/core.c
index 36a83617eb21..6236a54a63f4 100644
--- a/arch/x86/kernel/cpu/microcode/core.c
+++ b/arch/x86/kernel/cpu/microcode/core.c
@@ -1,74 +1,16 @@
 /*
- * Intel CPU Microcode Update Driver for Linux
+ * CPU Microcode Update Driver for Linux
  *
- * Copyright (C) 2000-2006 Tigran Aivazian 
- *   2006  Shaohua Li 
+ * Copyright (C) 2000-2006 Tigran Aivazian 
+ *   2006  Shaohua Li 
+ *   2013-2015 Borislav Petkov 
  *
- * This driver allows to upgrade microcode on Intel processors
- * belonging to IA-32 family - PentiumPro, Pentium II,
- * Pentium III, Xeon, Pentium 4, etc.
+ * This driver allows to upgrade microcode on x86 processors.
  *
- * Reference: Section 8.11 of Volume 3a, IA-32 Intel? Architecture
- * Software Developer's Manual
- * Order Number 253668 or free download from:
- *
- * http://developer.intel.com/Assets/PDF/manual/253668.pdf 
- *
- * For more information, go to http://www.urbanmyth.org/microcode
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License
- * as published by the Free Software Foundation; either version
- * 2 of the License, or (at your option) any later version.
- *
- * 1.0 16 Feb 2000, Tigran Aivazian 
- * Initial release.
- * 1.0118 Feb 2000, Tigran Aivazian 
- * Added read() support + cleanups.
- * 1.0221 Feb 2000, Tigran Aivazian 
- * Added 'device trimming' support. open(O_WRONLY) zeroes
- * and frees the saved copy of applied microcode.
- * 1.0329 Feb 2000, Tigran Aivazian 
- * Made to use devfs (/dev/cpu/microcode) + cleanups.
- * 1.0406 Jun 2000, Simon Trimmer 
- * Added misc device support (now uses both devfs and misc).
- * Added MICROCODE_IOCFREE ioctl to clear memory.
- * 1.0509 Jun 2000, Simon Trimmer 
- * Messages for error cases (non Intel & no suitable microcode).
- * 1.0603 Aug 2000, Tigran Aivazian 
- * Removed ->release(). Removed exclusive open and status bitmap.
- * Added microcode_rwsem to serialize read()/write()/ioctl().
- * Removed global kernel lock usage.
- * 1.0707 Sep 2000, Tigran Aivazian 
- * Write 0 to 0x8B msr and then cpuid before reading revision,
- * so that it works even if there were no update done by the
- * BIOS. Otherwise, reading from 0x8B gives junk (which happened
- * to be 0 on my machine which is why it worked even when I
- * disabled update by the BIOS)
- * Thanks to Eric W. Biederman  for the fix.
- * 1.0811 Dec 2000, Richard Schaal  and
- *  Tigran Aivazian 
- * Intel Pentium 4 processor support and bugfixes.
- * 1.0930 Oct 2001, Tigran Aivazian 
- * Bugfix for HT (Hyper-Threading) enabled processors
- * whereby processor resources are shared by all logical processors
- * in a single CPU package.
- * 1.1028 Feb 2002 Asit K Mallick  and
- * Tigran Aivazian ,
- * Serialize updates as required on HT processors due to
- * speculative nature of implementation.
- * 1.1122 Mar 2002 Tigran Aivazian 
- * Fix the panic when writing zero-length microcode chunk.
- * 1.1229 Sep 2003 Nitin Kamble ,
- * Jun Nakajima 
- * Support for the microcode updates in the new format.
- * 1.1310 Oct 2003 Tigran Aivazian 
- * Removed ->read() method and obsoleted MICROCODE_IOCFREE ioctl
- * because we no longer hold a copy of applied microcode
- * in kernel memory.
- * 1.1425 Jun 2004 Tigran Aivazian 
- * Fix sigmatch() macro to handle old CPUs with pf == 0.
- * Thanks to Stuart Swales for pointing out this bug.
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License
+ * as published by the Free Software Foundation; either version
+ * 2 of the License, or (at your option) any later version.
  */
 
 #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
diff --git a/arch/x86/kernel/cpu/microcode/intel.c 
b/arch/x86/kernel/cpu/microcode/intel.c
index a41beadb3db9..e20d4e58cd89 100644
--- a/arch/x86/kernel/cpu/microcode/intel.c
+++ 

[PATCH] x86/cpu/microcode: Zap changelog

[Borislav Petkov]

From: Borislav Petkov b...@suse.de

It is useless at best and git history has it all detailed anyway. Update
copyright while at it.

Signed-off-by: Borislav Petkov b...@suse.de
---
 arch/x86/kernel/cpu/microcode/core.c  | 76 +--
 arch/x86/kernel/cpu/microcode/intel.c | 75 --
 2 files changed, 16 insertions(+), 135 deletions(-)

diff --git a/arch/x86/kernel/cpu/microcode/core.c 
b/arch/x86/kernel/cpu/microcode/core.c
index 36a83617eb21..6236a54a63f4 100644
--- a/arch/x86/kernel/cpu/microcode/core.c
+++ b/arch/x86/kernel/cpu/microcode/core.c
@@ -1,74 +1,16 @@
 /*
- * Intel CPU Microcode Update Driver for Linux
+ * CPU Microcode Update Driver for Linux
  *
- * Copyright (C) 2000-2006 Tigran Aivazian tig...@aivazian.fsnet.co.uk
- *   2006  Shaohua Li shaohua...@intel.com
+ * Copyright (C) 2000-2006 Tigran Aivazian tig...@aivazian.fsnet.co.uk
+ *   2006  Shaohua Li shaohua...@intel.com
+ *   2013-2015 Borislav Petkov b...@alien8.de
  *
- * This driver allows to upgrade microcode on Intel processors
- * belonging to IA-32 family - PentiumPro, Pentium II,
- * Pentium III, Xeon, Pentium 4, etc.
+ * This driver allows to upgrade microcode on x86 processors.
  *
- * Reference: Section 8.11 of Volume 3a, IA-32 Intel? Architecture
- * Software Developer's Manual
- * Order Number 253668 or free download from:
- *
- * http://developer.intel.com/Assets/PDF/manual/253668.pdf 
- *
- * For more information, go to http://www.urbanmyth.org/microcode
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License
- * as published by the Free Software Foundation; either version
- * 2 of the License, or (at your option) any later version.
- *
- * 1.0 16 Feb 2000, Tigran Aivazian tig...@sco.com
- * Initial release.
- * 1.0118 Feb 2000, Tigran Aivazian tig...@sco.com
- * Added read() support + cleanups.
- * 1.0221 Feb 2000, Tigran Aivazian tig...@sco.com
- * Added 'device trimming' support. open(O_WRONLY) zeroes
- * and frees the saved copy of applied microcode.
- * 1.0329 Feb 2000, Tigran Aivazian tig...@sco.com
- * Made to use devfs (/dev/cpu/microcode) + cleanups.
- * 1.0406 Jun 2000, Simon Trimmer si...@veritas.com
- * Added misc device support (now uses both devfs and misc).
- * Added MICROCODE_IOCFREE ioctl to clear memory.
- * 1.0509 Jun 2000, Simon Trimmer si...@veritas.com
- * Messages for error cases (non Intel  no suitable microcode).
- * 1.0603 Aug 2000, Tigran Aivazian tig...@veritas.com
- * Removed -release(). Removed exclusive open and status bitmap.
- * Added microcode_rwsem to serialize read()/write()/ioctl().
- * Removed global kernel lock usage.
- * 1.0707 Sep 2000, Tigran Aivazian tig...@veritas.com
- * Write 0 to 0x8B msr and then cpuid before reading revision,
- * so that it works even if there were no update done by the
- * BIOS. Otherwise, reading from 0x8B gives junk (which happened
- * to be 0 on my machine which is why it worked even when I
- * disabled update by the BIOS)
- * Thanks to Eric W. Biederman ebieder...@lnxi.com for the fix.
- * 1.0811 Dec 2000, Richard Schaal richard.sch...@intel.com and
- *  Tigran Aivazian tig...@veritas.com
- * Intel Pentium 4 processor support and bugfixes.
- * 1.0930 Oct 2001, Tigran Aivazian tig...@veritas.com
- * Bugfix for HT (Hyper-Threading) enabled processors
- * whereby processor resources are shared by all logical processors
- * in a single CPU package.
- * 1.1028 Feb 2002 Asit K Mallick asit.k.mall...@intel.com and
- * Tigran Aivazian tig...@veritas.com,
- * Serialize updates as required on HT processors due to
- * speculative nature of implementation.
- * 1.1122 Mar 2002 Tigran Aivazian tig...@veritas.com
- * Fix the panic when writing zero-length microcode chunk.
- * 1.1229 Sep 2003 Nitin Kamble nitin.a.kam...@intel.com,
- * Jun Nakajima jun.nakaj...@intel.com
- * Support for the microcode updates in the new format.
- * 1.1310 Oct 2003 Tigran Aivazian tig...@veritas.com
- * Removed -read() method and obsoleted MICROCODE_IOCFREE ioctl
- * because we no longer hold a copy of applied microcode
- * in kernel memory.
- * 1.1425 Jun 2004 Tigran Aivazian tig...@veritas.com
- * Fix sigmatch() macro to handle old CPUs with pf == 0.
- * Thanks to Stuart Swales for pointing out this bug.
+ * This program is free software; you 

[tip:x86/microcode] x86/cpu/microcode: Zap changelog

[tip-bot for Borislav Petkov]

Commit-ID:  6b44e72a1c45d1a4e903af75611235a2d6ea25e3
Gitweb: http://git.kernel.org/tip/6b44e72a1c45d1a4e903af75611235a2d6ea25e3
Author: Borislav Petkov b...@suse.de
AuthorDate: Mon, 11 May 2015 10:15:47 +0200
Committer:  Ingo Molnar mi...@kernel.org
CommitDate: Mon, 11 May 2015 10:27:09 +0200

x86/cpu/microcode: Zap changelog

It is useless at best and git history has it all detailed
anyway. Update copyright while at it.

Signed-off-by: Borislav Petkov b...@suse.de
Cc: Andy Lutomirski l...@amacapital.net
Cc: Borislav Petkov b...@alien8.de
Cc: Brian Gerst brge...@gmail.com
Cc: Denys Vlasenko dvlas...@redhat.com
Cc: H. Peter Anvin h...@zytor.com
Cc: Linus Torvalds torva...@linux-foundation.org
Cc: Peter Zijlstra pet...@infradead.org
Cc: Thomas Gleixner t...@linutronix.de
Link: http://lkml.kernel.org/r/1431332153-18566-3-git-send-email...@alien8.de
Signed-off-by: Ingo Molnar mi...@kernel.org
---
 arch/x86/kernel/cpu/microcode/core.c  | 76 +--
 arch/x86/kernel/cpu/microcode/intel.c | 75 --
 2 files changed, 16 insertions(+), 135 deletions(-)

diff --git a/arch/x86/kernel/cpu/microcode/core.c 
b/arch/x86/kernel/cpu/microcode/core.c
index 36a8361..6236a54 100644
--- a/arch/x86/kernel/cpu/microcode/core.c
+++ b/arch/x86/kernel/cpu/microcode/core.c
@@ -1,74 +1,16 @@
 /*
- * Intel CPU Microcode Update Driver for Linux
+ * CPU Microcode Update Driver for Linux
  *
- * Copyright (C) 2000-2006 Tigran Aivazian tig...@aivazian.fsnet.co.uk
- *   2006  Shaohua Li shaohua...@intel.com
+ * Copyright (C) 2000-2006 Tigran Aivazian tig...@aivazian.fsnet.co.uk
+ *   2006  Shaohua Li shaohua...@intel.com
+ *   2013-2015 Borislav Petkov b...@alien8.de
  *
- * This driver allows to upgrade microcode on Intel processors
- * belonging to IA-32 family - PentiumPro, Pentium II,
- * Pentium III, Xeon, Pentium 4, etc.
+ * This driver allows to upgrade microcode on x86 processors.
  *
- * Reference: Section 8.11 of Volume 3a, IA-32 Intel? Architecture
- * Software Developer's Manual
- * Order Number 253668 or free download from:
- *
- * http://developer.intel.com/Assets/PDF/manual/253668.pdf 
- *
- * For more information, go to http://www.urbanmyth.org/microcode
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License
- * as published by the Free Software Foundation; either version
- * 2 of the License, or (at your option) any later version.
- *
- * 1.0 16 Feb 2000, Tigran Aivazian tig...@sco.com
- * Initial release.
- * 1.0118 Feb 2000, Tigran Aivazian tig...@sco.com
- * Added read() support + cleanups.
- * 1.0221 Feb 2000, Tigran Aivazian tig...@sco.com
- * Added 'device trimming' support. open(O_WRONLY) zeroes
- * and frees the saved copy of applied microcode.
- * 1.0329 Feb 2000, Tigran Aivazian tig...@sco.com
- * Made to use devfs (/dev/cpu/microcode) + cleanups.
- * 1.0406 Jun 2000, Simon Trimmer si...@veritas.com
- * Added misc device support (now uses both devfs and misc).
- * Added MICROCODE_IOCFREE ioctl to clear memory.
- * 1.0509 Jun 2000, Simon Trimmer si...@veritas.com
- * Messages for error cases (non Intel  no suitable microcode).
- * 1.0603 Aug 2000, Tigran Aivazian tig...@veritas.com
- * Removed -release(). Removed exclusive open and status bitmap.
- * Added microcode_rwsem to serialize read()/write()/ioctl().
- * Removed global kernel lock usage.
- * 1.0707 Sep 2000, Tigran Aivazian tig...@veritas.com
- * Write 0 to 0x8B msr and then cpuid before reading revision,
- * so that it works even if there were no update done by the
- * BIOS. Otherwise, reading from 0x8B gives junk (which happened
- * to be 0 on my machine which is why it worked even when I
- * disabled update by the BIOS)
- * Thanks to Eric W. Biederman ebieder...@lnxi.com for the fix.
- * 1.0811 Dec 2000, Richard Schaal richard.sch...@intel.com and
- *  Tigran Aivazian tig...@veritas.com
- * Intel Pentium 4 processor support and bugfixes.
- * 1.0930 Oct 2001, Tigran Aivazian tig...@veritas.com
- * Bugfix for HT (Hyper-Threading) enabled processors
- * whereby processor resources are shared by all logical processors
- * in a single CPU package.
- * 1.1028 Feb 2002 Asit K Mallick asit.k.mall...@intel.com and
- * Tigran Aivazian tig...@veritas.com,
- * Serialize updates as required on HT processors due to
- * speculative nature of implementation.
- * 1.1122 Mar 2002 Tigran Aivazian tig...@veritas.com
- * Fix

[PATCH 3/3] x86/cpu/microcode: Zap changelog

[Borislav Petkov]

From: Borislav Petkov 

It is useless at best and git history has it all detailed anyway. Update
copyright while at it.

Signed-off-by: Borislav Petkov 
---
 arch/x86/kernel/cpu/microcode/core.c  | 76 +--
 arch/x86/kernel/cpu/microcode/intel.c | 75 --
 2 files changed, 16 insertions(+), 135 deletions(-)

diff --git a/arch/x86/kernel/cpu/microcode/core.c 
b/arch/x86/kernel/cpu/microcode/core.c
index 36a83617eb21..6236a54a63f4 100644
--- a/arch/x86/kernel/cpu/microcode/core.c
+++ b/arch/x86/kernel/cpu/microcode/core.c
@@ -1,74 +1,16 @@
 /*
- * Intel CPU Microcode Update Driver for Linux
+ * CPU Microcode Update Driver for Linux
  *
- * Copyright (C) 2000-2006 Tigran Aivazian 
- *   2006  Shaohua Li 
+ * Copyright (C) 2000-2006 Tigran Aivazian 
+ *   2006  Shaohua Li 
+ *   2013-2015 Borislav Petkov 
  *
- * This driver allows to upgrade microcode on Intel processors
- * belonging to IA-32 family - PentiumPro, Pentium II,
- * Pentium III, Xeon, Pentium 4, etc.
+ * This driver allows to upgrade microcode on x86 processors.
  *
- * Reference: Section 8.11 of Volume 3a, IA-32 Intel? Architecture
- * Software Developer's Manual
- * Order Number 253668 or free download from:
- *
- * http://developer.intel.com/Assets/PDF/manual/253668.pdf 
- *
- * For more information, go to http://www.urbanmyth.org/microcode
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License
- * as published by the Free Software Foundation; either version
- * 2 of the License, or (at your option) any later version.
- *
- * 1.0 16 Feb 2000, Tigran Aivazian 
- * Initial release.
- * 1.0118 Feb 2000, Tigran Aivazian 
- * Added read() support + cleanups.
- * 1.0221 Feb 2000, Tigran Aivazian 
- * Added 'device trimming' support. open(O_WRONLY) zeroes
- * and frees the saved copy of applied microcode.
- * 1.0329 Feb 2000, Tigran Aivazian 
- * Made to use devfs (/dev/cpu/microcode) + cleanups.
- * 1.0406 Jun 2000, Simon Trimmer 
- * Added misc device support (now uses both devfs and misc).
- * Added MICROCODE_IOCFREE ioctl to clear memory.
- * 1.0509 Jun 2000, Simon Trimmer 
- * Messages for error cases (non Intel & no suitable microcode).
- * 1.0603 Aug 2000, Tigran Aivazian 
- * Removed ->release(). Removed exclusive open and status bitmap.
- * Added microcode_rwsem to serialize read()/write()/ioctl().
- * Removed global kernel lock usage.
- * 1.0707 Sep 2000, Tigran Aivazian 
- * Write 0 to 0x8B msr and then cpuid before reading revision,
- * so that it works even if there were no update done by the
- * BIOS. Otherwise, reading from 0x8B gives junk (which happened
- * to be 0 on my machine which is why it worked even when I
- * disabled update by the BIOS)
- * Thanks to Eric W. Biederman  for the fix.
- * 1.0811 Dec 2000, Richard Schaal  and
- *  Tigran Aivazian 
- * Intel Pentium 4 processor support and bugfixes.
- * 1.0930 Oct 2001, Tigran Aivazian 
- * Bugfix for HT (Hyper-Threading) enabled processors
- * whereby processor resources are shared by all logical processors
- * in a single CPU package.
- * 1.1028 Feb 2002 Asit K Mallick  and
- * Tigran Aivazian ,
- * Serialize updates as required on HT processors due to
- * speculative nature of implementation.
- * 1.1122 Mar 2002 Tigran Aivazian 
- * Fix the panic when writing zero-length microcode chunk.
- * 1.1229 Sep 2003 Nitin Kamble ,
- * Jun Nakajima 
- * Support for the microcode updates in the new format.
- * 1.1310 Oct 2003 Tigran Aivazian 
- * Removed ->read() method and obsoleted MICROCODE_IOCFREE ioctl
- * because we no longer hold a copy of applied microcode
- * in kernel memory.
- * 1.1425 Jun 2004 Tigran Aivazian 
- * Fix sigmatch() macro to handle old CPUs with pf == 0.
- * Thanks to Stuart Swales for pointing out this bug.
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License
+ * as published by the Free Software Foundation; either version
+ * 2 of the License, or (at your option) any later version.
  */
 
 #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
diff --git a/arch/x86/kernel/cpu/microcode/intel.c 
b/arch/x86/kernel/cpu/microcode/intel.c
index a41beadb3db9..e20d4e58cd89 100644
--- a/arch/x86/kernel/cpu/microcode/intel.c
+++ 

[PATCH 2/3] x86/mce/amd: Zap changelog

[Borislav Petkov]

From: Borislav Petkov 

It is useless and git history has it all detailed anyway. Update
copyright while at it.

Signed-off-by: Borislav Petkov 
Cc: Aravind Gopalakrishnan 
---
 arch/x86/kernel/cpu/mcheck/mce_amd.c | 12 ++--
 1 file changed, 2 insertions(+), 10 deletions(-)

diff --git a/arch/x86/kernel/cpu/mcheck/mce_amd.c 
b/arch/x86/kernel/cpu/mcheck/mce_amd.c
index 70e1bf6f784d..e99b15077e94 100644
--- a/arch/x86/kernel/cpu/mcheck/mce_amd.c
+++ b/arch/x86/kernel/cpu/mcheck/mce_amd.c
@@ -1,21 +1,13 @@
 /*
- *  (c) 2005-2012 Advanced Micro Devices, Inc.
+ *  (c) 2005-2015 Advanced Micro Devices, Inc.
  *  Your use of this code is subject to the terms and conditions of the
  *  GNU general public license version 2. See "COPYING" or
  *  http://www.gnu.org/licenses/gpl.html
  *
  *  Written by Jacob Shin - AMD, Inc.
- *
  *  Maintained by: Borislav Petkov 
  *
- *  April 2006
- * - added support for AMD Family 0x10 processors
- *  May 2012
- * - major scrubbing
- *  May 2015
- * - add support for deferred error interrupts (Aravind Gopalakrishnan)
- *
- *  All MC4_MISCi registers are shared between multi-cores
+ *  All MC4_MISCi registers are shared between cores on a node.
  */
 #include 
 #include 
-- 
2.3.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 3/3] x86/cpu/microcode: Zap changelog

[Borislav Petkov]

From: Borislav Petkov b...@suse.de

It is useless at best and git history has it all detailed anyway. Update
copyright while at it.

Signed-off-by: Borislav Petkov b...@suse.de
---
 arch/x86/kernel/cpu/microcode/core.c  | 76 +--
 arch/x86/kernel/cpu/microcode/intel.c | 75 --
 2 files changed, 16 insertions(+), 135 deletions(-)

diff --git a/arch/x86/kernel/cpu/microcode/core.c 
b/arch/x86/kernel/cpu/microcode/core.c
index 36a83617eb21..6236a54a63f4 100644
--- a/arch/x86/kernel/cpu/microcode/core.c
+++ b/arch/x86/kernel/cpu/microcode/core.c
@@ -1,74 +1,16 @@
 /*
- * Intel CPU Microcode Update Driver for Linux
+ * CPU Microcode Update Driver for Linux
  *
- * Copyright (C) 2000-2006 Tigran Aivazian tig...@aivazian.fsnet.co.uk
- *   2006  Shaohua Li shaohua...@intel.com
+ * Copyright (C) 2000-2006 Tigran Aivazian tig...@aivazian.fsnet.co.uk
+ *   2006  Shaohua Li shaohua...@intel.com
+ *   2013-2015 Borislav Petkov b...@alien8.de
  *
- * This driver allows to upgrade microcode on Intel processors
- * belonging to IA-32 family - PentiumPro, Pentium II,
- * Pentium III, Xeon, Pentium 4, etc.
+ * This driver allows to upgrade microcode on x86 processors.
  *
- * Reference: Section 8.11 of Volume 3a, IA-32 Intel? Architecture
- * Software Developer's Manual
- * Order Number 253668 or free download from:
- *
- * http://developer.intel.com/Assets/PDF/manual/253668.pdf 
- *
- * For more information, go to http://www.urbanmyth.org/microcode
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License
- * as published by the Free Software Foundation; either version
- * 2 of the License, or (at your option) any later version.
- *
- * 1.0 16 Feb 2000, Tigran Aivazian tig...@sco.com
- * Initial release.
- * 1.0118 Feb 2000, Tigran Aivazian tig...@sco.com
- * Added read() support + cleanups.
- * 1.0221 Feb 2000, Tigran Aivazian tig...@sco.com
- * Added 'device trimming' support. open(O_WRONLY) zeroes
- * and frees the saved copy of applied microcode.
- * 1.0329 Feb 2000, Tigran Aivazian tig...@sco.com
- * Made to use devfs (/dev/cpu/microcode) + cleanups.
- * 1.0406 Jun 2000, Simon Trimmer si...@veritas.com
- * Added misc device support (now uses both devfs and misc).
- * Added MICROCODE_IOCFREE ioctl to clear memory.
- * 1.0509 Jun 2000, Simon Trimmer si...@veritas.com
- * Messages for error cases (non Intel  no suitable microcode).
- * 1.0603 Aug 2000, Tigran Aivazian tig...@veritas.com
- * Removed -release(). Removed exclusive open and status bitmap.
- * Added microcode_rwsem to serialize read()/write()/ioctl().
- * Removed global kernel lock usage.
- * 1.0707 Sep 2000, Tigran Aivazian tig...@veritas.com
- * Write 0 to 0x8B msr and then cpuid before reading revision,
- * so that it works even if there were no update done by the
- * BIOS. Otherwise, reading from 0x8B gives junk (which happened
- * to be 0 on my machine which is why it worked even when I
- * disabled update by the BIOS)
- * Thanks to Eric W. Biederman ebieder...@lnxi.com for the fix.
- * 1.0811 Dec 2000, Richard Schaal richard.sch...@intel.com and
- *  Tigran Aivazian tig...@veritas.com
- * Intel Pentium 4 processor support and bugfixes.
- * 1.0930 Oct 2001, Tigran Aivazian tig...@veritas.com
- * Bugfix for HT (Hyper-Threading) enabled processors
- * whereby processor resources are shared by all logical processors
- * in a single CPU package.
- * 1.1028 Feb 2002 Asit K Mallick asit.k.mall...@intel.com and
- * Tigran Aivazian tig...@veritas.com,
- * Serialize updates as required on HT processors due to
- * speculative nature of implementation.
- * 1.1122 Mar 2002 Tigran Aivazian tig...@veritas.com
- * Fix the panic when writing zero-length microcode chunk.
- * 1.1229 Sep 2003 Nitin Kamble nitin.a.kam...@intel.com,
- * Jun Nakajima jun.nakaj...@intel.com
- * Support for the microcode updates in the new format.
- * 1.1310 Oct 2003 Tigran Aivazian tig...@veritas.com
- * Removed -read() method and obsoleted MICROCODE_IOCFREE ioctl
- * because we no longer hold a copy of applied microcode
- * in kernel memory.
- * 1.1425 Jun 2004 Tigran Aivazian tig...@veritas.com
- * Fix sigmatch() macro to handle old CPUs with pf == 0.
- * Thanks to Stuart Swales for pointing out this bug.
+ * This program is free software; you 

[PATCH 2/3] x86/mce/amd: Zap changelog

[Borislav Petkov]

From: Borislav Petkov b...@suse.de

It is useless and git history has it all detailed anyway. Update
copyright while at it.

Signed-off-by: Borislav Petkov b...@suse.de
Cc: Aravind Gopalakrishnan aravind.gopalakrish...@amd.com
---
 arch/x86/kernel/cpu/mcheck/mce_amd.c | 12 ++--
 1 file changed, 2 insertions(+), 10 deletions(-)

diff --git a/arch/x86/kernel/cpu/mcheck/mce_amd.c 
b/arch/x86/kernel/cpu/mcheck/mce_amd.c
index 70e1bf6f784d..e99b15077e94 100644
--- a/arch/x86/kernel/cpu/mcheck/mce_amd.c
+++ b/arch/x86/kernel/cpu/mcheck/mce_amd.c
@@ -1,21 +1,13 @@
 /*
- *  (c) 2005-2012 Advanced Micro Devices, Inc.
+ *  (c) 2005-2015 Advanced Micro Devices, Inc.
  *  Your use of this code is subject to the terms and conditions of the
  *  GNU general public license version 2. See COPYING or
  *  http://www.gnu.org/licenses/gpl.html
  *
  *  Written by Jacob Shin - AMD, Inc.
- *
  *  Maintained by: Borislav Petkov b...@alien8.de
  *
- *  April 2006
- * - added support for AMD Family 0x10 processors
- *  May 2012
- * - major scrubbing
- *  May 2015
- * - add support for deferred error interrupts (Aravind Gopalakrishnan)
- *
- *  All MC4_MISCi registers are shared between multi-cores
+ *  All MC4_MISCi registers are shared between cores on a node.
  */
 #include linux/interrupt.h
 #include linux/notifier.h
-- 
2.3.5

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [patch] Documentation: SubmittingPatches: overhaul changelog howto

[Randy Dunlap]

On 07/30/14 14:11, Johannes Weiner wrote:
> Maintainers often repeat the same feedback on poorly written
> changelogs - describe the problem, justify your changes, quantify
> optimizations, describe user-visible changes - but our documentation
> on writing changelogs doesn't include these things.  Fix that.
> 
> Signed-off-by: Johannes Weiner 

Applied with acks.

Thanks.

> ---
>  Documentation/SubmittingPatches | 38 +++---
>  1 file changed, 31 insertions(+), 7 deletions(-)
> 
> diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
> index dcadffcab2dc..0a523c9a5ff4 100644
> --- a/Documentation/SubmittingPatches
> +++ b/Documentation/SubmittingPatches
> @@ -84,18 +84,42 @@ is another popular alternative.
>  
>  2) Describe your changes.
>  
> -Describe the technical detail of the change(s) your patch includes.
> -
> -Be as specific as possible.  The WORST descriptions possible include
> -things like "update driver X", "bug fix for driver X", or "this patch
> -includes updates for subsystem X.  Please apply."
> +Describe your problem.  Whether your patch is a one-line bug fix or
> +5000 lines of a new feature, there must be an underlying problem that
> +motivated you to do this work.  Convince the reviewer that there is a
> +problem worth fixing and that it makes sense for them to read past the
> +first paragraph.
> +
> +Describe user-visible impact.  Straight up crashes and lockups are
> +pretty convincing, but not all bugs are that blatant.  Even if the
> +problem was spotted during code review, describe the impact you think
> +it can have on users.  Keep in mind that the majority of Linux
> +installations run kernels from secondary stable trees or
> +vendor/product-specific trees that cherry-pick only specific patches
> +from upstream, so include anything that could help route your change
> +downstream: provoking circumstances, excerpts from dmesg, crash
> +descriptions, performance regressions, latency spikes, lockups, etc.
> +
> +Quantify optimizations and trade-offs.  If you claim improvements in
> +performance, memory consumption, stack footprint, or binary size,
> +include numbers that back them up.  But also describe non-obvious
> +costs.  Optimizations usually aren't free but trade-offs between CPU,
> +memory, and readability; or, when it comes to heuristics, between
> +different workloads.  Describe the expected downsides of your
> +optimization so that the reviewer can weigh costs against benefits.
> +
> +Once the problem is established, describe what you are actually doing
> +about it in technical detail.  It's important to describe the change
> +in plain English for the reviewer to verify that the code is behaving
> +as you intend it to.
>  
>  The maintainer will thank you if you write your patch description in a
>  form which can be easily pulled into Linux's source code management
>  system, git, as a "commit log".  See #15, below.
>  
> -If your description starts to get long, that's a sign that you probably
> -need to split up your patch.  See #3, next.
> +Solve only one problem per patch.  If your description starts to get
> +long, that's a sign that you probably need to split up your patch.
> +See #3, next.
>  
>  When you submit or resubmit a patch or patch series, include the
>  complete patch description and justification for it.  Don't just
> 


-- 
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [patch] Documentation: SubmittingPatches: overhaul changelog howto

[Ingo Molnar]

* Johannes Weiner  wrote:

> Maintainers often repeat the same feedback on poorly written
> changelogs - describe the problem, justify your changes, quantify
> optimizations, describe user-visible changes - but our documentation
> on writing changelogs doesn't include these things.  Fix that.
> 
> Signed-off-by: Johannes Weiner 
> ---
>  Documentation/SubmittingPatches | 38 +++---
>  1 file changed, 31 insertions(+), 7 deletions(-)
> 
> diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
> index dcadffcab2dc..0a523c9a5ff4 100644
> --- a/Documentation/SubmittingPatches
> +++ b/Documentation/SubmittingPatches
> @@ -84,18 +84,42 @@ is another popular alternative.
>  
>  2) Describe your changes.
>  
> -Describe the technical detail of the change(s) your patch includes.
> -
> -Be as specific as possible.  The WORST descriptions possible include
> -things like "update driver X", "bug fix for driver X", or "this patch
> -includes updates for subsystem X.  Please apply."
> +Describe your problem.  Whether your patch is a one-line bug fix or
> +5000 lines of a new feature, there must be an underlying problem that
> +motivated you to do this work.  Convince the reviewer that there is a
> +problem worth fixing and that it makes sense for them to read past the
> +first paragraph.
> +
> +Describe user-visible impact.  Straight up crashes and lockups are
> +pretty convincing, but not all bugs are that blatant.  Even if the
> +problem was spotted during code review, describe the impact you think
> +it can have on users.  Keep in mind that the majority of Linux
> +installations run kernels from secondary stable trees or
> +vendor/product-specific trees that cherry-pick only specific patches
> +from upstream, so include anything that could help route your change
> +downstream: provoking circumstances, excerpts from dmesg, crash
> +descriptions, performance regressions, latency spikes, lockups, etc.
> +
> +Quantify optimizations and trade-offs.  If you claim improvements in
> +performance, memory consumption, stack footprint, or binary size,
> +include numbers that back them up.  But also describe non-obvious
> +costs.  Optimizations usually aren't free but trade-offs between CPU,
> +memory, and readability; or, when it comes to heuristics, between
> +different workloads.  Describe the expected downsides of your
> +optimization so that the reviewer can weigh costs against benefits.
> +
> +Once the problem is established, describe what you are actually doing
> +about it in technical detail.  It's important to describe the change
> +in plain English for the reviewer to verify that the code is behaving
> +as you intend it to.
>  
>  The maintainer will thank you if you write your patch description in a
>  form which can be easily pulled into Linux's source code management
>  system, git, as a "commit log".  See #15, below.
>  
> -If your description starts to get long, that's a sign that you probably
> -need to split up your patch.  See #3, next.
> +Solve only one problem per patch.  If your description starts to get
> +long, that's a sign that you probably need to split up your patch.
> +See #3, next.
>  
>  When you submit or resubmit a patch or patch series, include the
>  complete patch description and justification for it.  Don't just

Acked-by: Ingo Molnar 

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [patch] Documentation: SubmittingPatches: overhaul changelog howto

[Ingo Molnar]

* Johannes Weiner han...@cmpxchg.org wrote:

 Maintainers often repeat the same feedback on poorly written
 changelogs - describe the problem, justify your changes, quantify
 optimizations, describe user-visible changes - but our documentation
 on writing changelogs doesn't include these things.  Fix that.
 
 Signed-off-by: Johannes Weiner han...@cmpxchg.org
 ---
  Documentation/SubmittingPatches | 38 +++---
  1 file changed, 31 insertions(+), 7 deletions(-)
 
 diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
 index dcadffcab2dc..0a523c9a5ff4 100644
 --- a/Documentation/SubmittingPatches
 +++ b/Documentation/SubmittingPatches
 @@ -84,18 +84,42 @@ is another popular alternative.
  
  2) Describe your changes.
  
 -Describe the technical detail of the change(s) your patch includes.
 -
 -Be as specific as possible.  The WORST descriptions possible include
 -things like update driver X, bug fix for driver X, or this patch
 -includes updates for subsystem X.  Please apply.
 +Describe your problem.  Whether your patch is a one-line bug fix or
 +5000 lines of a new feature, there must be an underlying problem that
 +motivated you to do this work.  Convince the reviewer that there is a
 +problem worth fixing and that it makes sense for them to read past the
 +first paragraph.
 +
 +Describe user-visible impact.  Straight up crashes and lockups are
 +pretty convincing, but not all bugs are that blatant.  Even if the
 +problem was spotted during code review, describe the impact you think
 +it can have on users.  Keep in mind that the majority of Linux
 +installations run kernels from secondary stable trees or
 +vendor/product-specific trees that cherry-pick only specific patches
 +from upstream, so include anything that could help route your change
 +downstream: provoking circumstances, excerpts from dmesg, crash
 +descriptions, performance regressions, latency spikes, lockups, etc.
 +
 +Quantify optimizations and trade-offs.  If you claim improvements in
 +performance, memory consumption, stack footprint, or binary size,
 +include numbers that back them up.  But also describe non-obvious
 +costs.  Optimizations usually aren't free but trade-offs between CPU,
 +memory, and readability; or, when it comes to heuristics, between
 +different workloads.  Describe the expected downsides of your
 +optimization so that the reviewer can weigh costs against benefits.
 +
 +Once the problem is established, describe what you are actually doing
 +about it in technical detail.  It's important to describe the change
 +in plain English for the reviewer to verify that the code is behaving
 +as you intend it to.
  
  The maintainer will thank you if you write your patch description in a
  form which can be easily pulled into Linux's source code management
  system, git, as a commit log.  See #15, below.
  
 -If your description starts to get long, that's a sign that you probably
 -need to split up your patch.  See #3, next.
 +Solve only one problem per patch.  If your description starts to get
 +long, that's a sign that you probably need to split up your patch.
 +See #3, next.
  
  When you submit or resubmit a patch or patch series, include the
  complete patch description and justification for it.  Don't just

Acked-by: Ingo Molnar mi...@kernel.org

Thanks,

Ingo
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [patch] Documentation: SubmittingPatches: overhaul changelog howto

[Randy Dunlap]

On 07/30/14 14:11, Johannes Weiner wrote:
 Maintainers often repeat the same feedback on poorly written
 changelogs - describe the problem, justify your changes, quantify
 optimizations, describe user-visible changes - but our documentation
 on writing changelogs doesn't include these things.  Fix that.
 
 Signed-off-by: Johannes Weiner han...@cmpxchg.org

Applied with acks.

Thanks.

 ---
  Documentation/SubmittingPatches | 38 +++---
  1 file changed, 31 insertions(+), 7 deletions(-)
 
 diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
 index dcadffcab2dc..0a523c9a5ff4 100644
 --- a/Documentation/SubmittingPatches
 +++ b/Documentation/SubmittingPatches
 @@ -84,18 +84,42 @@ is another popular alternative.
  
  2) Describe your changes.
  
 -Describe the technical detail of the change(s) your patch includes.
 -
 -Be as specific as possible.  The WORST descriptions possible include
 -things like update driver X, bug fix for driver X, or this patch
 -includes updates for subsystem X.  Please apply.
 +Describe your problem.  Whether your patch is a one-line bug fix or
 +5000 lines of a new feature, there must be an underlying problem that
 +motivated you to do this work.  Convince the reviewer that there is a
 +problem worth fixing and that it makes sense for them to read past the
 +first paragraph.
 +
 +Describe user-visible impact.  Straight up crashes and lockups are
 +pretty convincing, but not all bugs are that blatant.  Even if the
 +problem was spotted during code review, describe the impact you think
 +it can have on users.  Keep in mind that the majority of Linux
 +installations run kernels from secondary stable trees or
 +vendor/product-specific trees that cherry-pick only specific patches
 +from upstream, so include anything that could help route your change
 +downstream: provoking circumstances, excerpts from dmesg, crash
 +descriptions, performance regressions, latency spikes, lockups, etc.
 +
 +Quantify optimizations and trade-offs.  If you claim improvements in
 +performance, memory consumption, stack footprint, or binary size,
 +include numbers that back them up.  But also describe non-obvious
 +costs.  Optimizations usually aren't free but trade-offs between CPU,
 +memory, and readability; or, when it comes to heuristics, between
 +different workloads.  Describe the expected downsides of your
 +optimization so that the reviewer can weigh costs against benefits.
 +
 +Once the problem is established, describe what you are actually doing
 +about it in technical detail.  It's important to describe the change
 +in plain English for the reviewer to verify that the code is behaving
 +as you intend it to.
  
  The maintainer will thank you if you write your patch description in a
  form which can be easily pulled into Linux's source code management
  system, git, as a commit log.  See #15, below.
  
 -If your description starts to get long, that's a sign that you probably
 -need to split up your patch.  See #3, next.
 +Solve only one problem per patch.  If your description starts to get
 +long, that's a sign that you probably need to split up your patch.
 +See #3, next.
  
  When you submit or resubmit a patch or patch series, include the
  complete patch description and justification for it.  Don't just
 


-- 
~Randy
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [patch] Documentation: SubmittingPatches: overhaul changelog howto

[Greg Kroah-Hartman]

On Wed, Jul 30, 2014 at 05:11:01PM -0400, Johannes Weiner wrote:
> Maintainers often repeat the same feedback on poorly written
> changelogs - describe the problem, justify your changes, quantify
> optimizations, describe user-visible changes - but our documentation
> on writing changelogs doesn't include these things.  Fix that.
> 
> Signed-off-by: Johannes Weiner 

Acked-by: Greg Kroah-Hartman 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [patch] Documentation: SubmittingPatches: overhaul changelog howto

[David Miller]

From: Johannes Weiner 
Date: Wed, 30 Jul 2014 17:11:01 -0400

> Maintainers often repeat the same feedback on poorly written
> changelogs - describe the problem, justify your changes, quantify
> optimizations, describe user-visible changes - but our documentation
> on writing changelogs doesn't include these things.  Fix that.
> 
> Signed-off-by: Johannes Weiner 

Acked-by: David S. Miller 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [patch] Documentation: SubmittingPatches: overhaul changelog howto

[Davidlohr Bueso]

On Wed, 2014-07-30 at 17:11 -0400, Johannes Weiner wrote:
> Maintainers often repeat the same feedback on poorly written
> changelogs - describe the problem, justify your changes, quantify
> optimizations, describe user-visible changes - but our documentation
> on writing changelogs doesn't include these things.  Fix that.

Agreed. Maybe other software projects can use this as well...


> Signed-off-by: Johannes Weiner 
> ---
>  Documentation/SubmittingPatches | 38 +++---
>  1 file changed, 31 insertions(+), 7 deletions(-)
> 
> diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
> index dcadffcab2dc..0a523c9a5ff4 100644
> --- a/Documentation/SubmittingPatches
> +++ b/Documentation/SubmittingPatches
> @@ -84,18 +84,42 @@ is another popular alternative.
>  
>  2) Describe your changes.
>  
> -Describe the technical detail of the change(s) your patch includes.
> -
> -Be as specific as possible.  The WORST descriptions possible include
> -things like "update driver X", "bug fix for driver X", or "this patch
> -includes updates for subsystem X.  Please apply."
> +Describe your problem.  Whether your patch is a one-line bug fix or
> +5000 lines of a new feature, there must be an underlying problem that
> +motivated you to do this work.  Convince the reviewer that there is a
> +problem worth fixing and that it makes sense for them to read past the
> +first paragraph.
> +
> +Describe user-visible impact.  Straight up crashes and lockups are
> +pretty convincing, but not all bugs are that blatant.  Even if the
> +problem was spotted during code review, describe the impact you think
> +it can have on users.  Keep in mind that the majority of Linux
> +installations run kernels from secondary stable trees or
> +vendor/product-specific trees that cherry-pick only specific patches
> +from upstream, so include anything that could help route your change
> +downstream: provoking circumstances, excerpts from dmesg, crash
> +descriptions, performance regressions, latency spikes, lockups, etc.
> +
> +Quantify optimizations and trade-offs.  If you claim improvements in
> +performance, memory consumption, stack footprint, or binary size,
> +include numbers that back them up.  But also describe non-obvious
> +costs.  Optimizations usually aren't free but trade-offs between CPU,
> +memory, and readability; or, when it comes to heuristics, between
> +different workloads.  Describe the expected downsides of your
> +optimization so that the reviewer can weigh costs against benefits.
> +
> +Once the problem is established, describe what you are actually doing
> +about it in technical detail.  It's important to describe the change
> +in plain English for the reviewer to verify that the code is behaving
> +as you intend it to.

Very nicely put. I would also add that past patches or attempts to solve
a related (or even the same) issue. What's different in my approach?
What are the past issues that cause original approaches not to get
merged? etc.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[patch] Documentation: SubmittingPatches: overhaul changelog howto

[Johannes Weiner]

Maintainers often repeat the same feedback on poorly written
changelogs - describe the problem, justify your changes, quantify
optimizations, describe user-visible changes - but our documentation
on writing changelogs doesn't include these things.  Fix that.

Signed-off-by: Johannes Weiner 
---
 Documentation/SubmittingPatches | 38 +++---
 1 file changed, 31 insertions(+), 7 deletions(-)

diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
index dcadffcab2dc..0a523c9a5ff4 100644
--- a/Documentation/SubmittingPatches
+++ b/Documentation/SubmittingPatches
@@ -84,18 +84,42 @@ is another popular alternative.
 
 2) Describe your changes.
 
-Describe the technical detail of the change(s) your patch includes.
-
-Be as specific as possible.  The WORST descriptions possible include
-things like "update driver X", "bug fix for driver X", or "this patch
-includes updates for subsystem X.  Please apply."
+Describe your problem.  Whether your patch is a one-line bug fix or
+5000 lines of a new feature, there must be an underlying problem that
+motivated you to do this work.  Convince the reviewer that there is a
+problem worth fixing and that it makes sense for them to read past the
+first paragraph.
+
+Describe user-visible impact.  Straight up crashes and lockups are
+pretty convincing, but not all bugs are that blatant.  Even if the
+problem was spotted during code review, describe the impact you think
+it can have on users.  Keep in mind that the majority of Linux
+installations run kernels from secondary stable trees or
+vendor/product-specific trees that cherry-pick only specific patches
+from upstream, so include anything that could help route your change
+downstream: provoking circumstances, excerpts from dmesg, crash
+descriptions, performance regressions, latency spikes, lockups, etc.
+
+Quantify optimizations and trade-offs.  If you claim improvements in
+performance, memory consumption, stack footprint, or binary size,
+include numbers that back them up.  But also describe non-obvious
+costs.  Optimizations usually aren't free but trade-offs between CPU,
+memory, and readability; or, when it comes to heuristics, between
+different workloads.  Describe the expected downsides of your
+optimization so that the reviewer can weigh costs against benefits.
+
+Once the problem is established, describe what you are actually doing
+about it in technical detail.  It's important to describe the change
+in plain English for the reviewer to verify that the code is behaving
+as you intend it to.
 
 The maintainer will thank you if you write your patch description in a
 form which can be easily pulled into Linux's source code management
 system, git, as a "commit log".  See #15, below.
 
-If your description starts to get long, that's a sign that you probably
-need to split up your patch.  See #3, next.
+Solve only one problem per patch.  If your description starts to get
+long, that's a sign that you probably need to split up your patch.
+See #3, next.
 
 When you submit or resubmit a patch or patch series, include the
 complete patch description and justification for it.  Don't just
-- 
2.0.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[patch] Documentation: SubmittingPatches: overhaul changelog howto

[Johannes Weiner]

Maintainers often repeat the same feedback on poorly written
changelogs - describe the problem, justify your changes, quantify
optimizations, describe user-visible changes - but our documentation
on writing changelogs doesn't include these things.  Fix that.

Signed-off-by: Johannes Weiner han...@cmpxchg.org
---
 Documentation/SubmittingPatches | 38 +++---
 1 file changed, 31 insertions(+), 7 deletions(-)

diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
index dcadffcab2dc..0a523c9a5ff4 100644
--- a/Documentation/SubmittingPatches
+++ b/Documentation/SubmittingPatches
@@ -84,18 +84,42 @@ is another popular alternative.
 
 2) Describe your changes.
 
-Describe the technical detail of the change(s) your patch includes.
-
-Be as specific as possible.  The WORST descriptions possible include
-things like update driver X, bug fix for driver X, or this patch
-includes updates for subsystem X.  Please apply.
+Describe your problem.  Whether your patch is a one-line bug fix or
+5000 lines of a new feature, there must be an underlying problem that
+motivated you to do this work.  Convince the reviewer that there is a
+problem worth fixing and that it makes sense for them to read past the
+first paragraph.
+
+Describe user-visible impact.  Straight up crashes and lockups are
+pretty convincing, but not all bugs are that blatant.  Even if the
+problem was spotted during code review, describe the impact you think
+it can have on users.  Keep in mind that the majority of Linux
+installations run kernels from secondary stable trees or
+vendor/product-specific trees that cherry-pick only specific patches
+from upstream, so include anything that could help route your change
+downstream: provoking circumstances, excerpts from dmesg, crash
+descriptions, performance regressions, latency spikes, lockups, etc.
+
+Quantify optimizations and trade-offs.  If you claim improvements in
+performance, memory consumption, stack footprint, or binary size,
+include numbers that back them up.  But also describe non-obvious
+costs.  Optimizations usually aren't free but trade-offs between CPU,
+memory, and readability; or, when it comes to heuristics, between
+different workloads.  Describe the expected downsides of your
+optimization so that the reviewer can weigh costs against benefits.
+
+Once the problem is established, describe what you are actually doing
+about it in technical detail.  It's important to describe the change
+in plain English for the reviewer to verify that the code is behaving
+as you intend it to.
 
 The maintainer will thank you if you write your patch description in a
 form which can be easily pulled into Linux's source code management
 system, git, as a commit log.  See #15, below.
 
-If your description starts to get long, that's a sign that you probably
-need to split up your patch.  See #3, next.
+Solve only one problem per patch.  If your description starts to get
+long, that's a sign that you probably need to split up your patch.
+See #3, next.
 
 When you submit or resubmit a patch or patch series, include the
 complete patch description and justification for it.  Don't just
-- 
2.0.3

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [patch] Documentation: SubmittingPatches: overhaul changelog howto

[Davidlohr Bueso]

On Wed, 2014-07-30 at 17:11 -0400, Johannes Weiner wrote:
 Maintainers often repeat the same feedback on poorly written
 changelogs - describe the problem, justify your changes, quantify
 optimizations, describe user-visible changes - but our documentation
 on writing changelogs doesn't include these things.  Fix that.

Agreed. Maybe other software projects can use this as well...


 Signed-off-by: Johannes Weiner han...@cmpxchg.org
 ---
  Documentation/SubmittingPatches | 38 +++---
  1 file changed, 31 insertions(+), 7 deletions(-)
 
 diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
 index dcadffcab2dc..0a523c9a5ff4 100644
 --- a/Documentation/SubmittingPatches
 +++ b/Documentation/SubmittingPatches
 @@ -84,18 +84,42 @@ is another popular alternative.
  
  2) Describe your changes.
  
 -Describe the technical detail of the change(s) your patch includes.
 -
 -Be as specific as possible.  The WORST descriptions possible include
 -things like update driver X, bug fix for driver X, or this patch
 -includes updates for subsystem X.  Please apply.
 +Describe your problem.  Whether your patch is a one-line bug fix or
 +5000 lines of a new feature, there must be an underlying problem that
 +motivated you to do this work.  Convince the reviewer that there is a
 +problem worth fixing and that it makes sense for them to read past the
 +first paragraph.
 +
 +Describe user-visible impact.  Straight up crashes and lockups are
 +pretty convincing, but not all bugs are that blatant.  Even if the
 +problem was spotted during code review, describe the impact you think
 +it can have on users.  Keep in mind that the majority of Linux
 +installations run kernels from secondary stable trees or
 +vendor/product-specific trees that cherry-pick only specific patches
 +from upstream, so include anything that could help route your change
 +downstream: provoking circumstances, excerpts from dmesg, crash
 +descriptions, performance regressions, latency spikes, lockups, etc.
 +
 +Quantify optimizations and trade-offs.  If you claim improvements in
 +performance, memory consumption, stack footprint, or binary size,
 +include numbers that back them up.  But also describe non-obvious
 +costs.  Optimizations usually aren't free but trade-offs between CPU,
 +memory, and readability; or, when it comes to heuristics, between
 +different workloads.  Describe the expected downsides of your
 +optimization so that the reviewer can weigh costs against benefits.
 +
 +Once the problem is established, describe what you are actually doing
 +about it in technical detail.  It's important to describe the change
 +in plain English for the reviewer to verify that the code is behaving
 +as you intend it to.

Very nicely put. I would also add that past patches or attempts to solve
a related (or even the same) issue. What's different in my approach?
What are the past issues that cause original approaches not to get
merged? etc.

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [patch] Documentation: SubmittingPatches: overhaul changelog howto

[David Miller]

From: Johannes Weiner han...@cmpxchg.org
Date: Wed, 30 Jul 2014 17:11:01 -0400

 Maintainers often repeat the same feedback on poorly written
 changelogs - describe the problem, justify your changes, quantify
 optimizations, describe user-visible changes - but our documentation
 on writing changelogs doesn't include these things.  Fix that.
 
 Signed-off-by: Johannes Weiner han...@cmpxchg.org

Acked-by: David S. Miller da...@davemloft.net
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [patch] Documentation: SubmittingPatches: overhaul changelog howto

[Greg Kroah-Hartman]

On Wed, Jul 30, 2014 at 05:11:01PM -0400, Johannes Weiner wrote:
 Maintainers often repeat the same feedback on poorly written
 changelogs - describe the problem, justify your changes, quantify
 optimizations, describe user-visible changes - but our documentation
 on writing changelogs doesn't include these things.  Fix that.
 
 Signed-off-by: Johannes Weiner han...@cmpxchg.org

Acked-by: Greg Kroah-Hartman gre...@linuxfoundation.org
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v3 0/4] line wrapping of changelog

[Dan Carpenter]

Great.  Thanks!

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH v3 0/4] line wrapping of changelog

[sanjeev sharma]

line wrap the changelog as per Dan

sanjeev sharma (4):
  staging: rtl8192u: Remove useless return statements.
  staging: rtl8192u: Removed unnecessary whitespace & tab warning.
  staging: rtl8192u: Fixed switch and case indentation error.
  staging: rtl8192u: Fixed too long lines

 drivers/staging/rtl8192u/r819xU_phy.c | 58 +++
 1 file changed, 25 insertions(+), 33 deletions(-)

-- 
1.7.11.7

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH v3 0/4] line wrapping of changelog

[sanjeev sharma]

line wrap the changelog as per Dan

sanjeev sharma (4):
  staging: rtl8192u: Remove useless return statements.
  staging: rtl8192u: Removed unnecessary whitespace  tab warning.
  staging: rtl8192u: Fixed switch and case indentation error.
  staging: rtl8192u: Fixed too long lines

 drivers/staging/rtl8192u/r819xU_phy.c | 58 +++
 1 file changed, 25 insertions(+), 33 deletions(-)

-- 
1.7.11.7

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v3 0/4] line wrapping of changelog

[Dan Carpenter]

Great.  Thanks!

regards,
dan carpenter

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 30/33] README, COPYING, Changelog

[Janani Venkataraman]

Adding the README, COPYING and ChangeLog for the package.

Signed-off-by: Janani Venkataraman 
---
 COPYING|   24 
 COPYING.LIBGENCORE |   24 
 Changelog  |7 +++
 README |  108 
 4 files changed, 163 insertions(+)
 create mode 100644 COPYING
 create mode 100644 COPYING.LIBGENCORE
 create mode 100644 Changelog
 create mode 100644 README

diff --git a/COPYING b/COPYING
new file mode 100644
index 000..a4163ed
--- /dev/null
+++ b/COPYING
@@ -0,0 +1,24 @@
+---
+GENCORE
+---
+
+Gencore produces a coredump of a process non-disruptively
+
+Copyright (C) IBM Corporation, 2013 
+
+Authors:
+   Janani Venkataraman 
+
+This package is free software: you can redistribute it and/or modify
+it under the terms of the GNU General Public License as published by
+the Free Software Foundation, either version 3 of the License, or
+(at your option) any later version.
+
+This package is distributed in the hope that it will be useful,
+but WITHOUT ANY WARRANTY; without even the implied warranty of
+MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+GNU General Public License for more details.
+
+You should have received a copy of the GNU General Public License
+along with this program; if not, write to the Free Software Foundation,
+Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
diff --git a/COPYING.LIBGENCORE b/COPYING.LIBGENCORE
new file mode 100644
index 000..e1a7bf6
--- /dev/null
+++ b/COPYING.LIBGENCORE
@@ -0,0 +1,24 @@
+--
+LIBGENCORE
+--
+
+Libencore sets up the interface for requesting a selfdump.
+
+Copyright (C) IBM Corporation, 2013 
+
+Authors:
+   Janani Venkataraman 
+
+This package is free software: you can redistribute it and/or modify
+it under the terms of the GNU Lesser General Public License as published by
+the Free Software Foundation, either version 3 of the License, or
+(at your option) any later version.
+
+This package is distributed in the hope that it will be useful,
+but WITHOUT ANY WARRANTY; without even the implied warranty of
+MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+GNU Lesser General Public License for more details.
+
+You should have received a copy of the GNU Lesser General Public License
+along with this program; if not, write to the Free Software Foundation,
+Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
diff --git a/Changelog b/Changelog
new file mode 100644
index 000..0c780ca
--- /dev/null
+++ b/Changelog
@@ -0,0 +1,7 @@
+-
+Changelog
+-
+
+* Thursday Dec 19 2013 Janani Venkataraman  1.0
+
+- Initial Version
diff --git a/README b/README
new file mode 100644
index 000..2935ddb
--- /dev/null
+++ b/README
@@ -0,0 +1,108 @@
+---
+How to build and install the package -- src.rpm
+---
+
+a) Download the gencore-0.1-0.src.rpm
+b) Rebuild the src.rpm using the following command:
+   rpmbuild --rebuild gencore-0.1-0.src.rpm
+c) In the rpmbuild folder created install the RPMs in RPMS folder
+   through the following command:
+   rpm -ivh gencore-0.1-0.x86_64.rpm gencore-debuginfo-0.1-0.x86_64.rpm 
libgencore-0.1-0.x86_64.rpm libgencore-devel-0.1-0.x86_64.rpm
+c) The library and executables will be installed in /usr/bin
+   and /usr/lib64 and the daemon will be started automatically.
+
+--
+How to build and install the package -- tar.gz
+--
+
+a) Untar it firstly
+b) ./autoreconf --force --install
+c) ./configure --prefix="path"
+d) make
+e) make install
+
+The executable the the client libraries are installed in the path specified by
+the user.
+
+
+Command Line Arguments - gencore
+
+
+We can call the gencore command in two ways.
+a) gencore pid [output-file-name]
+b) gencore --daemon 
+   -- Creates a daemon, for aiding selfdumps.
+c) gencore --socket
+   -- Post installation, systemd will create the socket and listen for 
connections.
+  Once a process requests a selfdump, the service will be spawned to handle
+  the request. For this we need to have the correct version of systemd 
which
+  has this socket option enabled.
+
+In the first case, gencore performs a third party dump and we can specify the
+PID of the process to be dumped. The output-filename is optional. If not 
+specified, by default the core filename is core.pid and it is created in the 
CWD.
+
+In the second case, we start a daemon and we wait for requests from processes
+which requires a self dump. This daemon keeping waiting for such requests.
+It can handle multiple requests for the dump. This method was adapted from the
+CRIU self dump application.
+
+A process which wants a dump, uses the libgencore library and calls the

[PATCH 30/33] README, COPYING, Changelog

[Janani Venkataraman]

Adding the README, COPYING and ChangeLog for the package.

Signed-off-by: Janani Venkataraman janan...@linux.vnet.ibm.com
---
 COPYING|   24 
 COPYING.LIBGENCORE |   24 
 Changelog  |7 +++
 README |  108 
 4 files changed, 163 insertions(+)
 create mode 100644 COPYING
 create mode 100644 COPYING.LIBGENCORE
 create mode 100644 Changelog
 create mode 100644 README

diff --git a/COPYING b/COPYING
new file mode 100644
index 000..a4163ed
--- /dev/null
+++ b/COPYING
@@ -0,0 +1,24 @@
+---
+GENCORE
+---
+
+Gencore produces a coredump of a process non-disruptively
+
+Copyright (C) IBM Corporation, 2013 
+
+Authors:
+   Janani Venkataraman janan...@in.ibm.com
+
+This package is free software: you can redistribute it and/or modify
+it under the terms of the GNU General Public License as published by
+the Free Software Foundation, either version 3 of the License, or
+(at your option) any later version.
+
+This package is distributed in the hope that it will be useful,
+but WITHOUT ANY WARRANTY; without even the implied warranty of
+MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+GNU General Public License for more details.
+
+You should have received a copy of the GNU General Public License
+along with this program; if not, write to the Free Software Foundation,
+Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
diff --git a/COPYING.LIBGENCORE b/COPYING.LIBGENCORE
new file mode 100644
index 000..e1a7bf6
--- /dev/null
+++ b/COPYING.LIBGENCORE
@@ -0,0 +1,24 @@
+--
+LIBGENCORE
+--
+
+Libencore sets up the interface for requesting a selfdump.
+
+Copyright (C) IBM Corporation, 2013 
+
+Authors:
+   Janani Venkataraman janan...@in.ibm.com
+
+This package is free software: you can redistribute it and/or modify
+it under the terms of the GNU Lesser General Public License as published by
+the Free Software Foundation, either version 3 of the License, or
+(at your option) any later version.
+
+This package is distributed in the hope that it will be useful,
+but WITHOUT ANY WARRANTY; without even the implied warranty of
+MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+GNU Lesser General Public License for more details.
+
+You should have received a copy of the GNU Lesser General Public License
+along with this program; if not, write to the Free Software Foundation,
+Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
diff --git a/Changelog b/Changelog
new file mode 100644
index 000..0c780ca
--- /dev/null
+++ b/Changelog
@@ -0,0 +1,7 @@
+-
+Changelog
+-
+
+* Thursday Dec 19 2013 Janani Venkataraman janan...@linux.vnet.ibm.com 1.0
+
+- Initial Version
diff --git a/README b/README
new file mode 100644
index 000..2935ddb
--- /dev/null
+++ b/README
@@ -0,0 +1,108 @@
+---
+How to build and install the package -- src.rpm
+---
+
+a) Download the gencore-0.1-0.src.rpm
+b) Rebuild the src.rpm using the following command:
+   rpmbuild --rebuild gencore-0.1-0.src.rpm
+c) In the rpmbuild folder created install the RPMs in RPMS folder
+   through the following command:
+   rpm -ivh gencore-0.1-0.x86_64.rpm gencore-debuginfo-0.1-0.x86_64.rpm 
libgencore-0.1-0.x86_64.rpm libgencore-devel-0.1-0.x86_64.rpm
+c) The library and executables will be installed in /usr/bin
+   and /usr/lib64 and the daemon will be started automatically.
+
+--
+How to build and install the package -- tar.gz
+--
+
+a) Untar it firstly
+b) ./autoreconf --force --install
+c) ./configure --prefix=path
+d) make
+e) make install
+
+The executable the the client libraries are installed in the path specified by
+the user.
+
+
+Command Line Arguments - gencore
+
+
+We can call the gencore command in two ways.
+a) gencore pid [output-file-name]
+b) gencore --daemon 
+   -- Creates a daemon, for aiding selfdumps.
+c) gencore --socket
+   -- Post installation, systemd will create the socket and listen for 
connections.
+  Once a process requests a selfdump, the service will be spawned to handle
+  the request. For this we need to have the correct version of systemd 
which
+  has this socket option enabled.
+
+In the first case, gencore performs a third party dump and we can specify the
+PID of the process to be dumped. The output-filename is optional. If not 
+specified, by default the core filename is core.pid and it is created in the 
CWD.
+
+In the second case, we start a daemon and we wait for requests from processes
+which requires a self dump. This daemon keeping waiting for such requests.
+It can handle multiple requests for the dump. This method was adapted from the
+CRIU self dump

Re: [PATCH 1/1] Documentation/filesystems/ntfs.txt: Remove changelog reference

[Anton Altaparmakov]

Looks good, thanks.

Andrew, if you haven't already, can you please take that one for integration 
via your mm series?  Thanks!

Best regards,

Anton

On 27 Feb 2014, at 11:43, Fabian Frederick  wrote:

> File was removed in the following commit :
> 7c821a179f91c3ad52588400ce52a7fb48b9868c ("Remove fs/ntfs/ChangeLog")
> 
> Signed-off-by: Fabian Frederick 
> ---
> Documentation/filesystems/ntfs.txt | 2 --
> 1 file changed, 2 deletions(-)
> 
> diff --git a/Documentation/filesystems/ntfs.txt 
> b/Documentation/filesystems/ntfs.txt
> index 791af8d..61947fa 100644
> --- a/Documentation/filesystems/ntfs.txt
> +++ b/Documentation/filesystems/ntfs.txt
> @@ -455,8 +455,6 @@ not have this problem with odd numbers of sectors.
> ChangeLog
> =
> 
> -Note, a technical ChangeLog aimed at kernel hackers is in fs/ntfs/ChangeLog.
> -
> 2.1.30:
>   - Fix writev() (it kept writing the first segment over and over again
> instead of moving onto subsequent segments).
> -- 
> 1.8.1.4

-- 
Anton Altaparmakov  (replace at with @)
Unix Support, Computing Service, University of Cambridge
J.J. Thomson Avenue, Cambridge, CB3 0RB, UK

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 1/1] Documentation/filesystems/ntfs.txt: Remove changelog reference

[Anton Altaparmakov]

Looks good, thanks.

Andrew, if you haven't already, can you please take that one for integration 
via your mm series?  Thanks!

Best regards,

Anton

On 27 Feb 2014, at 11:43, Fabian Frederick f...@skynet.be wrote:

 File was removed in the following commit :
 7c821a179f91c3ad52588400ce52a7fb48b9868c (Remove fs/ntfs/ChangeLog)
 
 Signed-off-by: Fabian Frederick f...@skynet.be
 ---
 Documentation/filesystems/ntfs.txt | 2 --
 1 file changed, 2 deletions(-)
 
 diff --git a/Documentation/filesystems/ntfs.txt 
 b/Documentation/filesystems/ntfs.txt
 index 791af8d..61947fa 100644
 --- a/Documentation/filesystems/ntfs.txt
 +++ b/Documentation/filesystems/ntfs.txt
 @@ -455,8 +455,6 @@ not have this problem with odd numbers of sectors.
 ChangeLog
 =
 
 -Note, a technical ChangeLog aimed at kernel hackers is in fs/ntfs/ChangeLog.
 -
 2.1.30:
   - Fix writev() (it kept writing the first segment over and over again
 instead of moving onto subsequent segments).
 -- 
 1.8.1.4

-- 
Anton Altaparmakov aia21 at cam.ac.uk (replace at with @)
Unix Support, Computing Service, University of Cambridge
J.J. Thomson Avenue, Cambridge, CB3 0RB, UK

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 1/1] Documentation/filesystems/ntfs.txt: Remove changelog reference

[Fabian Frederick]

File was removed in the following commit :
7c821a179f91c3ad52588400ce52a7fb48b9868c ("Remove fs/ntfs/ChangeLog")

Signed-off-by: Fabian Frederick 
---
 Documentation/filesystems/ntfs.txt | 2 --
 1 file changed, 2 deletions(-)

diff --git a/Documentation/filesystems/ntfs.txt 
b/Documentation/filesystems/ntfs.txt
index 791af8d..61947fa 100644
--- a/Documentation/filesystems/ntfs.txt
+++ b/Documentation/filesystems/ntfs.txt
@@ -455,8 +455,6 @@ not have this problem with odd numbers of sectors.
 ChangeLog
 =
 
-Note, a technical ChangeLog aimed at kernel hackers is in fs/ntfs/ChangeLog.
-
 2.1.30:
- Fix writev() (it kept writing the first segment over and over again
  instead of moving onto subsequent segments).
-- 
1.8.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 1/1] Documentation/filesystems/ntfs.txt: Remove changelog reference

[Fabian Frederick]

File was removed in the following commit :
7c821a179f91c3ad52588400ce52a7fb48b9868c (Remove fs/ntfs/ChangeLog)

Signed-off-by: Fabian Frederick f...@skynet.be
---
 Documentation/filesystems/ntfs.txt | 2 --
 1 file changed, 2 deletions(-)

diff --git a/Documentation/filesystems/ntfs.txt 
b/Documentation/filesystems/ntfs.txt
index 791af8d..61947fa 100644
--- a/Documentation/filesystems/ntfs.txt
+++ b/Documentation/filesystems/ntfs.txt
@@ -455,8 +455,6 @@ not have this problem with odd numbers of sectors.
 ChangeLog
 =
 
-Note, a technical ChangeLog aimed at kernel hackers is in fs/ntfs/ChangeLog.
-
 2.1.30:
- Fix writev() (it kept writing the first segment over and over again
  instead of moving onto subsequent segments).
-- 
1.8.1.4

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 4/5] lustre: Correct KUC code max changelog msg size

[Oleg Drokin]

The kernel to userspace communication routines (KUC) allocate
and limit the maximum cs_buf size to CR_MAXSIZE.  However this
fails to account for the fact that the buffer is assumed to begin
with a struct kuc_hdr.  To allocate and account for that space,
we introduce a new define, KUC_CHANGELOG_MSG_MAXSIZE.

Signed-off-by: Christopher J. Morrone 
Reviewed-on: http://review.whamcloud.com/7406
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3587
Reviewed-by: Andreas Dilger 
Reviewed-by: jacques-Charles Lafoucriere 
Reviewed-by: Oleg Drokin 
Signed-off-by: Oleg Drokin 
---
 drivers/staging/lustre/include/linux/libcfs/libcfs_kernelcomm.h | 2 ++
 drivers/staging/lustre/lustre/mdc/mdc_request.c | 6 +++---
 2 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/lustre/include/linux/libcfs/libcfs_kernelcomm.h 
b/drivers/staging/lustre/include/linux/libcfs/libcfs_kernelcomm.h
index 596a15f..037ae8a 100644
--- a/drivers/staging/lustre/include/linux/libcfs/libcfs_kernelcomm.h
+++ b/drivers/staging/lustre/include/linux/libcfs/libcfs_kernelcomm.h
@@ -61,6 +61,8 @@ struct kuc_hdr {
__u16 kuc_msglen; /* Including header */
 } __attribute__((aligned(sizeof(__u64;
 
+#define KUC_CHANGELOG_MSG_MAXSIZE (sizeof(struct kuc_hdr)+CR_MAXSIZE)
+
 #define KUC_MAGIC  0x191C /*Lustre9etLinC */
 #define KUC_FL_BLOCK 0x01   /* Wait for send */
 
diff --git a/drivers/staging/lustre/lustre/mdc/mdc_request.c 
b/drivers/staging/lustre/lustre/mdc/mdc_request.c
index d1ad91c3..8301392 100644
--- a/drivers/staging/lustre/lustre/mdc/mdc_request.c
+++ b/drivers/staging/lustre/lustre/mdc/mdc_request.c
@@ -1430,7 +1430,7 @@ static struct kuc_hdr *changelog_kuc_hdr(char *buf, int 
len, int flags)
 {
struct kuc_hdr *lh = (struct kuc_hdr *)buf;
 
-   LASSERT(len <= CR_MAXSIZE);
+   LASSERT(len <= KUC_CHANGELOG_MSG_MAXSIZE);
 
lh->kuc_magic = KUC_MAGIC;
lh->kuc_transport = KUC_TRANSPORT_CHANGELOG;
@@ -1503,7 +1503,7 @@ static int mdc_changelog_send_thread(void *csdata)
CDEBUG(D_CHANGELOG, "changelog to fp=%p start "LPU64"\n",
   cs->cs_fp, cs->cs_startrec);
 
-   OBD_ALLOC(cs->cs_buf, CR_MAXSIZE);
+   OBD_ALLOC(cs->cs_buf, KUC_CHANGELOG_MSG_MAXSIZE);
if (cs->cs_buf == NULL)
GOTO(out, rc = -ENOMEM);
 
@@ -1540,7 +1540,7 @@ out:
if (ctxt)
llog_ctxt_put(ctxt);
if (cs->cs_buf)
-   OBD_FREE(cs->cs_buf, CR_MAXSIZE);
+   OBD_FREE(cs->cs_buf, KUC_CHANGELOG_MSG_MAXSIZE);
OBD_FREE_PTR(cs);
return rc;
 }
-- 
1.8.5.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 4/5] lustre: Correct KUC code max changelog msg size

[Oleg Drokin]

The kernel to userspace communication routines (KUC) allocate
and limit the maximum cs_buf size to CR_MAXSIZE.  However this
fails to account for the fact that the buffer is assumed to begin
with a struct kuc_hdr.  To allocate and account for that space,
we introduce a new define, KUC_CHANGELOG_MSG_MAXSIZE.

Signed-off-by: Christopher J. Morrone morro...@llnl.gov
Reviewed-on: http://review.whamcloud.com/7406
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3587
Reviewed-by: Andreas Dilger andreas.dil...@intel.com
Reviewed-by: jacques-Charles Lafoucriere jacques-charles.lafoucri...@cea.fr
Reviewed-by: Oleg Drokin oleg.dro...@intel.com
Signed-off-by: Oleg Drokin oleg.dro...@intel.com
---
 drivers/staging/lustre/include/linux/libcfs/libcfs_kernelcomm.h | 2 ++
 drivers/staging/lustre/lustre/mdc/mdc_request.c | 6 +++---
 2 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/lustre/include/linux/libcfs/libcfs_kernelcomm.h 
b/drivers/staging/lustre/include/linux/libcfs/libcfs_kernelcomm.h
index 596a15f..037ae8a 100644
--- a/drivers/staging/lustre/include/linux/libcfs/libcfs_kernelcomm.h
+++ b/drivers/staging/lustre/include/linux/libcfs/libcfs_kernelcomm.h
@@ -61,6 +61,8 @@ struct kuc_hdr {
__u16 kuc_msglen; /* Including header */
 } __attribute__((aligned(sizeof(__u64;
 
+#define KUC_CHANGELOG_MSG_MAXSIZE (sizeof(struct kuc_hdr)+CR_MAXSIZE)
+
 #define KUC_MAGIC  0x191C /*Lustre9etLinC */
 #define KUC_FL_BLOCK 0x01   /* Wait for send */
 
diff --git a/drivers/staging/lustre/lustre/mdc/mdc_request.c 
b/drivers/staging/lustre/lustre/mdc/mdc_request.c
index d1ad91c3..8301392 100644
--- a/drivers/staging/lustre/lustre/mdc/mdc_request.c
+++ b/drivers/staging/lustre/lustre/mdc/mdc_request.c
@@ -1430,7 +1430,7 @@ static struct kuc_hdr *changelog_kuc_hdr(char *buf, int 
len, int flags)
 {
struct kuc_hdr *lh = (struct kuc_hdr *)buf;
 
-   LASSERT(len = CR_MAXSIZE);
+   LASSERT(len = KUC_CHANGELOG_MSG_MAXSIZE);
 
lh-kuc_magic = KUC_MAGIC;
lh-kuc_transport = KUC_TRANSPORT_CHANGELOG;
@@ -1503,7 +1503,7 @@ static int mdc_changelog_send_thread(void *csdata)
CDEBUG(D_CHANGELOG, changelog to fp=%p start LPU64\n,
   cs-cs_fp, cs-cs_startrec);
 
-   OBD_ALLOC(cs-cs_buf, CR_MAXSIZE);
+   OBD_ALLOC(cs-cs_buf, KUC_CHANGELOG_MSG_MAXSIZE);
if (cs-cs_buf == NULL)
GOTO(out, rc = -ENOMEM);
 
@@ -1540,7 +1540,7 @@ out:
if (ctxt)
llog_ctxt_put(ctxt);
if (cs-cs_buf)
-   OBD_FREE(cs-cs_buf, CR_MAXSIZE);
+   OBD_FREE(cs-cs_buf, KUC_CHANGELOG_MSG_MAXSIZE);
OBD_FREE_PTR(cs);
return rc;
 }
-- 
1.8.5.3

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 17/26] staging/lustre/changelogs: Correct KUC code max changelog msg size

[Peng Tao]

From: "Christopher J. Morrone" 

The kernel to userspace communication routines (KUC) allocate
and limit the maximum cs_buf size to CR_MAXSIZE.  However this
fails to account for the fact that the buffer is assumed to begin
with a struct kuc_hdr.  To allocate and account for that space,
we introduce a new define, KUC_CHANGELOG_MSG_MAXSIZE.

Lustre-change: http://review.whamcloud.com/7406
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3587
Signed-off-by: Christopher J. Morrone 
Reviewed-by: Andreas Dilger 
Reviewed-by: jacques-Charles Lafoucriere 
Reviewed-by: Oleg Drokin 
Signed-off-by: Peng Tao 
Signed-off-by: Andreas Dilger 
---
 .../include/linux/libcfs/libcfs_kernelcomm.h   |2 ++
 drivers/staging/lustre/lustre/mdc/mdc_request.c|6 +++---
 2 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/lustre/include/linux/libcfs/libcfs_kernelcomm.h 
b/drivers/staging/lustre/include/linux/libcfs/libcfs_kernelcomm.h
index 4e12ffc..e7469ac 100644
--- a/drivers/staging/lustre/include/linux/libcfs/libcfs_kernelcomm.h
+++ b/drivers/staging/lustre/include/linux/libcfs/libcfs_kernelcomm.h
@@ -61,6 +61,8 @@ struct kuc_hdr {
__u16 kuc_msglen; /* Including header */
 } __attribute__((aligned(sizeof(__u64;
 
+#define KUC_CHANGELOG_MSG_MAXSIZE (sizeof(struct kuc_hdr)+CR_MAXSIZE)
+
 #define KUC_MAGIC  0x191C /*Lustre9etLinC */
 #define KUC_FL_BLOCK 0x01   /* Wait for send */
 
diff --git a/drivers/staging/lustre/lustre/mdc/mdc_request.c 
b/drivers/staging/lustre/lustre/mdc/mdc_request.c
index 651fcb1..eeac9b4 100644
--- a/drivers/staging/lustre/lustre/mdc/mdc_request.c
+++ b/drivers/staging/lustre/lustre/mdc/mdc_request.c
@@ -1452,7 +1452,7 @@ static struct kuc_hdr *changelog_kuc_hdr(char *buf, int 
len, int flags)
 {
struct kuc_hdr *lh = (struct kuc_hdr *)buf;
 
-   LASSERT(len <= CR_MAXSIZE);
+   LASSERT(len <= KUC_CHANGELOG_MSG_MAXSIZE);
 
lh->kuc_magic = KUC_MAGIC;
lh->kuc_transport = KUC_TRANSPORT_CHANGELOG;
@@ -1525,7 +1525,7 @@ static int mdc_changelog_send_thread(void *csdata)
    CDEBUG(D_CHANGELOG, "changelog to fp=%p start "LPU64"\n",
   cs->cs_fp, cs->cs_startrec);
 
-   OBD_ALLOC(cs->cs_buf, CR_MAXSIZE);
+   OBD_ALLOC(cs->cs_buf, KUC_CHANGELOG_MSG_MAXSIZE);
if (cs->cs_buf == NULL)
GOTO(out, rc = -ENOMEM);
 
@@ -1562,7 +1562,7 @@ out:
if (ctxt)
llog_ctxt_put(ctxt);
if (cs->cs_buf)
-   OBD_FREE(cs->cs_buf, CR_MAXSIZE);
+   OBD_FREE(cs->cs_buf, KUC_CHANGELOG_MSG_MAXSIZE);
OBD_FREE_PTR(cs);
return rc;
 }
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 17/26] staging/lustre/changelogs: Correct KUC code max changelog msg size

[Peng Tao]

From: Christopher J. Morrone morro...@llnl.gov

The kernel to userspace communication routines (KUC) allocate
and limit the maximum cs_buf size to CR_MAXSIZE.  However this
fails to account for the fact that the buffer is assumed to begin
with a struct kuc_hdr.  To allocate and account for that space,
we introduce a new define, KUC_CHANGELOG_MSG_MAXSIZE.

Lustre-change: http://review.whamcloud.com/7406
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3587
Signed-off-by: Christopher J. Morrone morro...@llnl.gov
Reviewed-by: Andreas Dilger andreas.dil...@intel.com
Reviewed-by: jacques-Charles Lafoucriere jacques-charles.lafoucri...@cea.fr
Reviewed-by: Oleg Drokin oleg.dro...@intel.com
Signed-off-by: Peng Tao bergw...@gmail.com
Signed-off-by: Andreas Dilger andreas.dil...@intel.com
---
 .../include/linux/libcfs/libcfs_kernelcomm.h   |2 ++
 drivers/staging/lustre/lustre/mdc/mdc_request.c|6 +++---
 2 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/lustre/include/linux/libcfs/libcfs_kernelcomm.h 
b/drivers/staging/lustre/include/linux/libcfs/libcfs_kernelcomm.h
index 4e12ffc..e7469ac 100644
--- a/drivers/staging/lustre/include/linux/libcfs/libcfs_kernelcomm.h
+++ b/drivers/staging/lustre/include/linux/libcfs/libcfs_kernelcomm.h
@@ -61,6 +61,8 @@ struct kuc_hdr {
__u16 kuc_msglen; /* Including header */
 } __attribute__((aligned(sizeof(__u64;
 
+#define KUC_CHANGELOG_MSG_MAXSIZE (sizeof(struct kuc_hdr)+CR_MAXSIZE)
+
 #define KUC_MAGIC  0x191C /*Lustre9etLinC */
 #define KUC_FL_BLOCK 0x01   /* Wait for send */
 
diff --git a/drivers/staging/lustre/lustre/mdc/mdc_request.c 
b/drivers/staging/lustre/lustre/mdc/mdc_request.c
index 651fcb1..eeac9b4 100644
--- a/drivers/staging/lustre/lustre/mdc/mdc_request.c
+++ b/drivers/staging/lustre/lustre/mdc/mdc_request.c
@@ -1452,7 +1452,7 @@ static struct kuc_hdr *changelog_kuc_hdr(char *buf, int 
len, int flags)
 {
struct kuc_hdr *lh = (struct kuc_hdr *)buf;
 
-   LASSERT(len = CR_MAXSIZE);
+   LASSERT(len = KUC_CHANGELOG_MSG_MAXSIZE);
 
lh-kuc_magic = KUC_MAGIC;
lh-kuc_transport = KUC_TRANSPORT_CHANGELOG;
@@ -1525,7 +1525,7 @@ static int mdc_changelog_send_thread(void *csdata)
CDEBUG(D_CHANGELOG, changelog to fp=%p start LPU64\n,
   cs-cs_fp, cs-cs_startrec);
 
-   OBD_ALLOC(cs-cs_buf, CR_MAXSIZE);
+   OBD_ALLOC(cs-cs_buf, KUC_CHANGELOG_MSG_MAXSIZE);
if (cs-cs_buf == NULL)
GOTO(out, rc = -ENOMEM);
 
@@ -1562,7 +1562,7 @@ out:
if (ctxt)
llog_ctxt_put(ctxt);
if (cs-cs_buf)
-   OBD_FREE(cs-cs_buf, CR_MAXSIZE);
+   OBD_FREE(cs-cs_buf, KUC_CHANGELOG_MSG_MAXSIZE);
OBD_FREE_PTR(cs);
return rc;
 }
-- 
1.7.9.5

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] [Scripts] kallsyms: Nuke all ChangeLog, this should be logged by git

[Bryan Wu]

>From 2375c7eaa43d4474fb5b403dba9b3175e683484a Mon Sep 17 00:00:00 2001
From: Bryan Wu <[EMAIL PROTECTED]>
Date: Thu, 31 Jan 2008 01:30:09 +0800
Subject: [PATCH] [Scripts] kallsyms: Nuke all ChangeLog, this should be logged 
by git

(25/Aug/2004) Paulo Marques <[EMAIL PROTECTED]>
Changed the compression method from stem compression
to "table lookup" compression

Signed-off-by: Bryan Wu <[EMAIL PROTECTED]>
---
 scripts/kallsyms.c |6 --
 1 files changed, 0 insertions(+), 6 deletions(-)

diff --git a/scripts/kallsyms.c b/scripts/kallsyms.c
index 5271db7..1dab50e 100644
--- a/scripts/kallsyms.c
+++ b/scripts/kallsyms.c
@@ -7,12 +7,6 @@
  *
  * Usage: nm -n vmlinux | scripts/kallsyms [--all-symbols] > symbols.S
  *
- * ChangeLog:
- *
- * (25/Aug/2004) Paulo Marques <[EMAIL PROTECTED]>
- *  Changed the compression method from stem compression to "table lookup"
- *  compression
- *
  *  Table compression uses all the unused char codes on the symbols and
  *  maps these to the most used substrings (tokens). For instance, it might
  *  map char code 0xF7 to represent "write_" and then in every symbol where
-- 
1.5.3.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] [Scripts] kallsyms: Nuke all ChangeLog, this should be logged by git

[Bryan Wu]

From 2375c7eaa43d4474fb5b403dba9b3175e683484a Mon Sep 17 00:00:00 2001
From: Bryan Wu [EMAIL PROTECTED]
Date: Thu, 31 Jan 2008 01:30:09 +0800
Subject: [PATCH] [Scripts] kallsyms: Nuke all ChangeLog, this should be logged 
by git

(25/Aug/2004) Paulo Marques [EMAIL PROTECTED]
Changed the compression method from stem compression
to table lookup compression

Signed-off-by: Bryan Wu [EMAIL PROTECTED]
---
 scripts/kallsyms.c |6 --
 1 files changed, 0 insertions(+), 6 deletions(-)

diff --git a/scripts/kallsyms.c b/scripts/kallsyms.c
index 5271db7..1dab50e 100644
--- a/scripts/kallsyms.c
+++ b/scripts/kallsyms.c
@@ -7,12 +7,6 @@
  *
  * Usage: nm -n vmlinux | scripts/kallsyms [--all-symbols]  symbols.S
  *
- * ChangeLog:
- *
- * (25/Aug/2004) Paulo Marques [EMAIL PROTECTED]
- *  Changed the compression method from stem compression to table lookup
- *  compression
- *
  *  Table compression uses all the unused char codes on the symbols and
  *  maps these to the most used substrings (tokens). For instance, it might
  *  map char code 0xF7 to represent write_ and then in every symbol where
-- 
1.5.3.4

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 1/32] ide-tape: move historical changelog to Documentation/ide/ChangeLog.ide-tape.1995-2002

[Bartlomiej Zolnierkiewicz]

On Sunday 27 January 2008, Borislav Petkov wrote:
> Also, cleanup whitespace and update comments.
> 
> Signed-off-by: Borislav Petkov <[EMAIL PROTECTED]>

applied with some changes

> ---
>  Documentation/ide/ChangeLog.ide-tape.1995-2002 |  405 +++
>  drivers/ide/ide-tape.c |  414 
> +---
>  2 files changed, 409 insertions(+), 410 deletions(-)
> 
> diff --git a/Documentation/ide/ChangeLog.ide-tape.1995-2002 
> b/Documentation/ide/ChangeLog.ide-tape.1995-2002
> new file mode 100644
> index 000..e406762
> --- /dev/null
> +++ b/Documentation/ide/ChangeLog.ide-tape.1995-2002
> @@ -0,0 +1,405 @@
> +/*
> + * IDE ATAPI streaming tape driver.
> + *
> + * This driver is a part of the Linux ide driver and works in co-operation
> + * with drivers/block/ide.c.

I removed incorrect reference to drivers/block/ide.c

> + * The driver, in co-operation with ide.c, basically traverses the
> + * request-list for the block device interface. The character device
> + * interface, on the other hand, creates new requests, adds them
> + * to the request-list of the block device, and waits for their completion.
> + *
> + * Pipelined operation mode is now supported on both reads and writes.
> + *
> + * The block device major and minor numbers are determined from the
> + * tape's relative position in the ide interfaces, as explained in ide.c.
> + *
> + * The character device interface consists of the following devices:
> + *
> + * ht0   major 37, minor 0   first  IDE tape, rewind on 
> close.
> + * ht1   major 37, minor 1   second IDE tape, rewind on 
> close.
> + * ...
> + * nht0  major 37, minor 128 first  IDE tape, no rewind on 
> close.
> + * nht1  major 37, minor 129 second IDE tape, no rewind on 
> close.
> + * ...
> + *
> + * The general magnetic tape commands compatible interface, as defined by
> + * include/linux/mtio.h, is accessible through the character device.
> + *
> + * General ide driver configuration options, such as the interrupt-unmask
> + * flag, can be configured by issuing an ioctl to the block device interface,
> + * as any other ide device.
> + *
> + * Our own ide-tape ioctl's can be issued to either the block device or
> + * the character device interface.
> + *
> + * Maximal throughput with minimal bus load will usually be achieved in the
> + * following scenario:
> + *
> + *   1.  ide-tape is operating in the pipelined operation mode.
> + *   2.  No buffering is performed by the user backup program.

the above is not the part of the changelog

[...]

> + * Here are some words from the first releases of hd.c, which are quoted
> + * in ide.c and apply here as well:
> + *
> + * | Special care is recommended.  Have Fun!

[...]

ditto

> + * An overview of the pipelined operation mode.
> + *
> + * In the pipelined write mode, we will usually just add requests to our
> + * pipeline and return immediately, before we even start to service them. The
> + * user program will then have enough time to prepare the next request while
> + * we are still busy servicing previous requests. In the pipelined read mode,
> + * the situation is similar - we add read-ahead requests into the pipeline,
> + * before the user even requested them.
> + *
> + * The pipeline can be viewed as a "safety net" which will be activated when
> + * the system load is high and prevents the user backup program from keeping 
> up
> + * with the current tape speed. At this point, the pipeline will get
> + * shorter and shorter but the tape will still be streaming at the same 
> speed.
> + * Assuming we have enough pipeline stages, the system load will hopefully
> + * decrease before the pipeline is completely empty, and the backup program
> + * will be able to "catch up" and refill the pipeline again.
> + *
> + * When using the pipelined mode, it would be best to disable any type of
> + * buffering done by the user program, as ide-tape already provides all the
> + * benefits in the kernel, where it can be done in a more efficient way.
> + * As we will usually not block the user program on a request, the most
> + * efficient user code will then be a simple read-write-read-... cycle.
> + * Any additional logic will usually just slow down the backup process.
> + *
> + * Using the pipelined mode, I get a constant over 400 KBps throughput,
> + * which seems to be the maximum throughput supported by my tape.
> + *
> + * However, there are some downfalls:
> + *
> + *   1.  We use memory (for data buffers) in proportional to the number
> + *   of pipeline stages (each stage is about 26 KB with my tape

[PATCH 1/32] ide-tape: move historical changelog to Documentation/ide/ChangeLog.ide-tape.1995-2002

[Borislav Petkov]

Also, cleanup whitespace and update comments.

Signed-off-by: Borislav Petkov <[EMAIL PROTECTED]>
---
 Documentation/ide/ChangeLog.ide-tape.1995-2002 |  405 +++
 drivers/ide/ide-tape.c |  414 +---
 2 files changed, 409 insertions(+), 410 deletions(-)

diff --git a/Documentation/ide/ChangeLog.ide-tape.1995-2002 
b/Documentation/ide/ChangeLog.ide-tape.1995-2002
new file mode 100644
index 000..e406762
--- /dev/null
+++ b/Documentation/ide/ChangeLog.ide-tape.1995-2002
@@ -0,0 +1,405 @@
+/*
+ * IDE ATAPI streaming tape driver.
+ *
+ * This driver is a part of the Linux ide driver and works in co-operation
+ * with drivers/block/ide.c.
+ *
+ * The driver, in co-operation with ide.c, basically traverses the
+ * request-list for the block device interface. The character device
+ * interface, on the other hand, creates new requests, adds them
+ * to the request-list of the block device, and waits for their completion.
+ *
+ * Pipelined operation mode is now supported on both reads and writes.
+ *
+ * The block device major and minor numbers are determined from the
+ * tape's relative position in the ide interfaces, as explained in ide.c.
+ *
+ * The character device interface consists of the following devices:
+ *
+ * ht0 major 37, minor 0   first  IDE tape, rewind on close.
+ * ht1 major 37, minor 1   second IDE tape, rewind on close.
+ * ...
+ * nht0major 37, minor 128 first  IDE tape, no rewind on 
close.
+ * nht1major 37, minor 129 second IDE tape, no rewind on 
close.
+ * ...
+ *
+ * The general magnetic tape commands compatible interface, as defined by
+ * include/linux/mtio.h, is accessible through the character device.
+ *
+ * General ide driver configuration options, such as the interrupt-unmask
+ * flag, can be configured by issuing an ioctl to the block device interface,
+ * as any other ide device.
+ *
+ * Our own ide-tape ioctl's can be issued to either the block device or
+ * the character device interface.
+ *
+ * Maximal throughput with minimal bus load will usually be achieved in the
+ * following scenario:
+ *
+ * 1.  ide-tape is operating in the pipelined operation mode.
+ * 2.  No buffering is performed by the user backup program.
+ *
+ * Testing was done with a 2 GB CONNER CTMA 4000 IDE ATAPI Streaming Tape 
Drive.
+ *
+ * Ver 0.1   Nov  1 95   Pre-working code :-)
+ * Ver 0.2   Nov 23 95   A short backup (few megabytes) and restore procedure
+ *was successful ! (Using tar cvf ... on the block
+ *device interface).
+ *   A longer backup resulted in major swapping, bad
+ *overall Linux performance and eventually failed as
+ *we received non serial read-ahead requests from the
+ *buffer cache.
+ * Ver 0.3   Nov 28 95   Long backups are now possible, thanks to the
+ *character device interface. Linux's responsiveness
+ *and performance doesn't seem to be much affected
+ *from the background backup procedure.
+ *   Some general mtio.h magnetic tape operations are
+ *now supported by our character device. As a result,
+ *popular tape utilities are starting to work with
+ *ide tapes :-)
+ *   The following configurations were tested:
+ *   1. An IDE ATAPI TAPE shares the same interface
+ *and irq with an IDE ATAPI CDROM.
+ *   2. An IDE ATAPI TAPE shares the same interface
+ *and irq with a normal IDE disk.
+ *Both configurations seemed to work just fine !
+ *However, to be on the safe side, it is meanwhile
+ *recommended to give the IDE TAPE its own interface
+ *and irq.
+ *   The one thing which needs to be done here is to
+ *add a "request postpone" feature to ide.c,
+ *so that we won't have to wait for the tape to finish
+ *performing a long media access (DSC) request (such
+ *as a rewind) before we can access the other device
+ *on the same interface. This effect doesn't disturb
+ *normal operation most of the time because read/write
+ *requests are relatively fast, and once we are
+ *performing one tape r/w request, a lot of requests
+ *from the other device can be queued and ide.c will
+ *   service all of them after this single tape request.
+ * Ver 1.0   Dec 11 95   Integrated into Linux 1.3.46 

[PATCH 1/32] ide-tape: move historical changelog to Documentation/ide/ChangeLog.ide-tape.1995-2002

[Borislav Petkov]

Also, cleanup whitespace and update comments.

Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
 Documentation/ide/ChangeLog.ide-tape.1995-2002 |  405 +++
 drivers/ide/ide-tape.c |  414 +---
 2 files changed, 409 insertions(+), 410 deletions(-)

diff --git a/Documentation/ide/ChangeLog.ide-tape.1995-2002 
b/Documentation/ide/ChangeLog.ide-tape.1995-2002
new file mode 100644
index 000..e406762
--- /dev/null
+++ b/Documentation/ide/ChangeLog.ide-tape.1995-2002
@@ -0,0 +1,405 @@
+/*
+ * IDE ATAPI streaming tape driver.
+ *
+ * This driver is a part of the Linux ide driver and works in co-operation
+ * with drivers/block/ide.c.
+ *
+ * The driver, in co-operation with ide.c, basically traverses the
+ * request-list for the block device interface. The character device
+ * interface, on the other hand, creates new requests, adds them
+ * to the request-list of the block device, and waits for their completion.
+ *
+ * Pipelined operation mode is now supported on both reads and writes.
+ *
+ * The block device major and minor numbers are determined from the
+ * tape's relative position in the ide interfaces, as explained in ide.c.
+ *
+ * The character device interface consists of the following devices:
+ *
+ * ht0 major 37, minor 0   first  IDE tape, rewind on close.
+ * ht1 major 37, minor 1   second IDE tape, rewind on close.
+ * ...
+ * nht0major 37, minor 128 first  IDE tape, no rewind on 
close.
+ * nht1major 37, minor 129 second IDE tape, no rewind on 
close.
+ * ...
+ *
+ * The general magnetic tape commands compatible interface, as defined by
+ * include/linux/mtio.h, is accessible through the character device.
+ *
+ * General ide driver configuration options, such as the interrupt-unmask
+ * flag, can be configured by issuing an ioctl to the block device interface,
+ * as any other ide device.
+ *
+ * Our own ide-tape ioctl's can be issued to either the block device or
+ * the character device interface.
+ *
+ * Maximal throughput with minimal bus load will usually be achieved in the
+ * following scenario:
+ *
+ * 1.  ide-tape is operating in the pipelined operation mode.
+ * 2.  No buffering is performed by the user backup program.
+ *
+ * Testing was done with a 2 GB CONNER CTMA 4000 IDE ATAPI Streaming Tape 
Drive.
+ *
+ * Ver 0.1   Nov  1 95   Pre-working code :-)
+ * Ver 0.2   Nov 23 95   A short backup (few megabytes) and restore procedure
+ *was successful ! (Using tar cvf ... on the block
+ *device interface).
+ *   A longer backup resulted in major swapping, bad
+ *overall Linux performance and eventually failed as
+ *we received non serial read-ahead requests from the
+ *buffer cache.
+ * Ver 0.3   Nov 28 95   Long backups are now possible, thanks to the
+ *character device interface. Linux's responsiveness
+ *and performance doesn't seem to be much affected
+ *from the background backup procedure.
+ *   Some general mtio.h magnetic tape operations are
+ *now supported by our character device. As a result,
+ *popular tape utilities are starting to work with
+ *ide tapes :-)
+ *   The following configurations were tested:
+ *   1. An IDE ATAPI TAPE shares the same interface
+ *and irq with an IDE ATAPI CDROM.
+ *   2. An IDE ATAPI TAPE shares the same interface
+ *and irq with a normal IDE disk.
+ *Both configurations seemed to work just fine !
+ *However, to be on the safe side, it is meanwhile
+ *recommended to give the IDE TAPE its own interface
+ *and irq.
+ *   The one thing which needs to be done here is to
+ *add a request postpone feature to ide.c,
+ *so that we won't have to wait for the tape to finish
+ *performing a long media access (DSC) request (such
+ *as a rewind) before we can access the other device
+ *on the same interface. This effect doesn't disturb
+ *normal operation most of the time because read/write
+ *requests are relatively fast, and once we are
+ *performing one tape r/w request, a lot of requests
+ *from the other device can be queued and ide.c will
+ *   service all of them after this single tape request.
+ * Ver 1.0   Dec 11 95   Integrated into Linux 1.3.46 

Re: [PATCH 1/32] ide-tape: move historical changelog to Documentation/ide/ChangeLog.ide-tape.1995-2002

[Bartlomiej Zolnierkiewicz]

On Sunday 27 January 2008, Borislav Petkov wrote:
 Also, cleanup whitespace and update comments.
 
 Signed-off-by: Borislav Petkov [EMAIL PROTECTED]

applied with some changes

 ---
  Documentation/ide/ChangeLog.ide-tape.1995-2002 |  405 +++
  drivers/ide/ide-tape.c |  414 
 +---
  2 files changed, 409 insertions(+), 410 deletions(-)
 
 diff --git a/Documentation/ide/ChangeLog.ide-tape.1995-2002 
 b/Documentation/ide/ChangeLog.ide-tape.1995-2002
 new file mode 100644
 index 000..e406762
 --- /dev/null
 +++ b/Documentation/ide/ChangeLog.ide-tape.1995-2002
 @@ -0,0 +1,405 @@
 +/*
 + * IDE ATAPI streaming tape driver.
 + *
 + * This driver is a part of the Linux ide driver and works in co-operation
 + * with drivers/block/ide.c.

I removed incorrect reference to drivers/block/ide.c

 + * The driver, in co-operation with ide.c, basically traverses the
 + * request-list for the block device interface. The character device
 + * interface, on the other hand, creates new requests, adds them
 + * to the request-list of the block device, and waits for their completion.
 + *
 + * Pipelined operation mode is now supported on both reads and writes.
 + *
 + * The block device major and minor numbers are determined from the
 + * tape's relative position in the ide interfaces, as explained in ide.c.
 + *
 + * The character device interface consists of the following devices:
 + *
 + * ht0   major 37, minor 0   first  IDE tape, rewind on 
 close.
 + * ht1   major 37, minor 1   second IDE tape, rewind on 
 close.
 + * ...
 + * nht0  major 37, minor 128 first  IDE tape, no rewind on 
 close.
 + * nht1  major 37, minor 129 second IDE tape, no rewind on 
 close.
 + * ...
 + *
 + * The general magnetic tape commands compatible interface, as defined by
 + * include/linux/mtio.h, is accessible through the character device.
 + *
 + * General ide driver configuration options, such as the interrupt-unmask
 + * flag, can be configured by issuing an ioctl to the block device interface,
 + * as any other ide device.
 + *
 + * Our own ide-tape ioctl's can be issued to either the block device or
 + * the character device interface.
 + *
 + * Maximal throughput with minimal bus load will usually be achieved in the
 + * following scenario:
 + *
 + *   1.  ide-tape is operating in the pipelined operation mode.
 + *   2.  No buffering is performed by the user backup program.

the above is not the part of the changelog

[...]

 + * Here are some words from the first releases of hd.c, which are quoted
 + * in ide.c and apply here as well:
 + *
 + * | Special care is recommended.  Have Fun!

[...]

ditto

 + * An overview of the pipelined operation mode.
 + *
 + * In the pipelined write mode, we will usually just add requests to our
 + * pipeline and return immediately, before we even start to service them. The
 + * user program will then have enough time to prepare the next request while
 + * we are still busy servicing previous requests. In the pipelined read mode,
 + * the situation is similar - we add read-ahead requests into the pipeline,
 + * before the user even requested them.
 + *
 + * The pipeline can be viewed as a safety net which will be activated when
 + * the system load is high and prevents the user backup program from keeping 
 up
 + * with the current tape speed. At this point, the pipeline will get
 + * shorter and shorter but the tape will still be streaming at the same 
 speed.
 + * Assuming we have enough pipeline stages, the system load will hopefully
 + * decrease before the pipeline is completely empty, and the backup program
 + * will be able to catch up and refill the pipeline again.
 + *
 + * When using the pipelined mode, it would be best to disable any type of
 + * buffering done by the user program, as ide-tape already provides all the
 + * benefits in the kernel, where it can be done in a more efficient way.
 + * As we will usually not block the user program on a request, the most
 + * efficient user code will then be a simple read-write-read-... cycle.
 + * Any additional logic will usually just slow down the backup process.
 + *
 + * Using the pipelined mode, I get a constant over 400 KBps throughput,
 + * which seems to be the maximum throughput supported by my tape.
 + *
 + * However, there are some downfalls:
 + *
 + *   1.  We use memory (for data buffers) in proportional to the number
 + *   of pipeline stages (each stage is about 26 KB with my tape).
 + *   2.  In the pipelined write mode, we cheat and postpone error codes
 + *   to the user task. In read mode, the actual tape position
 + *   will be a bit further than the last requested block.
 + *
 + * Concerning (1):
 + *
 + *   1.  We allocate stages dynamically only when we need them. When
 + *   we don't need them, we don't consume additional memory

Re: [RESEND PATCH 01/10] move ide-floppy historical changelog to Documentation/ide/ChangeLog.ide-floppy.1996-2002;

[Bartlomiej Zolnierkiewicz]

On Thursday 03 January 2008, Borislav Petkov wrote:
> Signed-off-by: Borislav Petkov <[EMAIL PROTECTED]>

applied with two minor fixes (and sorry for being such a pedant ;):

* Summary line moved to patch description and "ide-floppy: cleanup header"
  used instead.  Please try to keep summary line within 80-columns limit,
  otherwise it makes git-log output etc ugly.

* I don't know why scripts/checkpatch.pl doesn't complain but quilt did:

  Warning: trailing whitespace in lines 44,46,61,62 of 
Documentation/ide/ChangeLog.ide-floppy.1996-2002

  so I fixed it manually.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[RESEND PATCH 01/10] move ide-floppy historical changelog to Documentation/ide/ChangeLog.ide-floppy.1996-2002;

[Borislav Petkov]

1999 Gadi Oxman <[EMAIL PROTECTED]>
  * Copyright (C) 2000 - 2002 Paul Bristow <[EMAIL PROTECTED]>
- */
-
-/*
- * IDE ATAPI floppy driver.
  *
  * The driver currently doesn't have any fancy features, just the bare
  * minimum read/write support.
@@ -17,67 +13,8 @@
  * Iomega Zip 100/250
  * Iomega PC Card Clik!/PocketZip
  *
- * Many thanks to Lode Leroy <[EMAIL PROTECTED]>, who tested so many
- * ALPHA patches to this driver on an EASYSTOR LS-120 ATAPI floppy drive.
- *
- * Ver 0.1   Oct 17 96   Initial test version, mostly based on ide-tape.c.
- * Ver 0.2   Oct 31 96   Minor changes.
- * Ver 0.3   Dec  2 96   Fixed error recovery bug.
- * Ver 0.4   Jan 26 97   Add support for the HDIO_GETGEO ioctl.
- * Ver 0.5   Feb 21 97   Add partitions support.
- *   Use the minimum of the LBA and CHS capacities.
- *   Avoid hwgroup->rq == NULL on the last irq.
- *   Fix potential null dereferencing with DEBUG_LOG.
- * Ver 0.8   Dec  7 97   Increase irq timeout from 10 to 50 seconds.
- *   Add media write-protect detection.
- *   Issue START command only if TEST UNIT READY fails.
- *   Add work-around for IOMEGA ZIP revision 21.D.
- *   Remove idefloppy_get_capabilities().
- * Ver 0.9   Jul  4 99   Fix a bug which might have caused the number of
- *bytes requested on each interrupt to be zero.
- *Thanks to <[EMAIL PROTECTED]> for pointing this out.
- * Ver 0.9.sv Jan 6 01   Sam Varshavchik <[EMAIL PROTECTED]>
- *   Implement low level formatting.  Reimplemented
- *   IDEFLOPPY_CAPABILITIES_PAGE, since we need the srfp
- *   bit.  My LS-120 drive barfs on
- *   IDEFLOPPY_CAPABILITIES_PAGE, but maybe it's just me.
- *   Compromise by not reporting a failure to get this
- *   mode page.  Implemented four IOCTLs in order to
- *   implement formatting.  IOCTls begin with 0x4600,
- *   0x46 is 'F' as in Format.
- *Jan 9 01   Userland option to select format verify.
- *   Added PC_SUPPRESS_ERROR flag - some idefloppy drives
- *   do not implement IDEFLOPPY_CAPABILITIES_PAGE, and
- *   return a sense error.  Suppress error reporting in
- *   this particular case in order to avoid spurious
- *   errors in syslog.  The culprit is
- *   idefloppy_get_capability_page(), so move it to
- *   idefloppy_begin_format() so that it's not used
- *   unless absolutely necessary.
- *   If drive does not support format progress indication
- *   monitor the dsc bit in the status register.
- *   Also, O_NDELAY on open will allow the device to be
- *   opened without a disk available.  This can be used to
- *   open an unformatted disk, or get the device capacity.
- * Ver 0.91  Dec 11 99   Added IOMEGA Clik! drive support by 
- *<[EMAIL PROTECTED]>
- * Ver 0.92  Oct 22 00   Paul Bristow became official maintainer for this 
- *driver.  Included Powerbook internal zip kludge.
- * Ver 0.93  Oct 24 00   Fixed bugs for Clik! drive
- *no disk on insert and disk change now works
- * Ver 0.94  Oct 27 00   Tidied up to remove strstr(Clik) everywhere
- * Ver 0.95  Nov  7 00   Brought across to kernel 2.4
- * Ver 0.96  Jan  7 01   Actually in line with release version of 2.4.0
- *   including set_bit patch from Rusty Russell
- * Ver 0.97  Jul 22 01   Merge 0.91-0.96 onto 0.9.sv for ac series
- * Ver 0.97.sv Aug 3 01  Backported from 2.4.7-ac3
- * Ver 0.98  Oct 26 01   Split idefloppy_transfer_pc into two pieces to
- *fix a lost interrupt problem. It appears the busy
- *bit was being deasserted by my IOMEGA ATAPI ZIP 100
- *drive before the drive was actually ready.
- * Ver 0.98a Oct 29 01   Expose delay value so we can play.
- * Ver 0.99  Feb 24 02   Remove duplicate code, modify clik! detection code 
- *    to support new PocketZip drives 
+ * For a historical changelog see
+ * Documentation/ide/ChangeLog.ide-floppy.1996-2002
  */
 
 #define IDEFLOPPY_VERSION "0.99.newide"
-- 
1.5.3.7

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[RESEND PATCH 01/10] move ide-floppy historical changelog to Documentation/ide/ChangeLog.ide-floppy.1996-2002;

[Borislav Petkov]

 (C) 2000 - 2002 Paul Bristow [EMAIL PROTECTED]
- */
-
-/*
- * IDE ATAPI floppy driver.
  *
  * The driver currently doesn't have any fancy features, just the bare
  * minimum read/write support.
@@ -17,67 +13,8 @@
  * Iomega Zip 100/250
  * Iomega PC Card Clik!/PocketZip
  *
- * Many thanks to Lode Leroy [EMAIL PROTECTED], who tested so many
- * ALPHA patches to this driver on an EASYSTOR LS-120 ATAPI floppy drive.
- *
- * Ver 0.1   Oct 17 96   Initial test version, mostly based on ide-tape.c.
- * Ver 0.2   Oct 31 96   Minor changes.
- * Ver 0.3   Dec  2 96   Fixed error recovery bug.
- * Ver 0.4   Jan 26 97   Add support for the HDIO_GETGEO ioctl.
- * Ver 0.5   Feb 21 97   Add partitions support.
- *   Use the minimum of the LBA and CHS capacities.
- *   Avoid hwgroup-rq == NULL on the last irq.
- *   Fix potential null dereferencing with DEBUG_LOG.
- * Ver 0.8   Dec  7 97   Increase irq timeout from 10 to 50 seconds.
- *   Add media write-protect detection.
- *   Issue START command only if TEST UNIT READY fails.
- *   Add work-around for IOMEGA ZIP revision 21.D.
- *   Remove idefloppy_get_capabilities().
- * Ver 0.9   Jul  4 99   Fix a bug which might have caused the number of
- *bytes requested on each interrupt to be zero.
- *Thanks to [EMAIL PROTECTED] for pointing this out.
- * Ver 0.9.sv Jan 6 01   Sam Varshavchik [EMAIL PROTECTED]
- *   Implement low level formatting.  Reimplemented
- *   IDEFLOPPY_CAPABILITIES_PAGE, since we need the srfp
- *   bit.  My LS-120 drive barfs on
- *   IDEFLOPPY_CAPABILITIES_PAGE, but maybe it's just me.
- *   Compromise by not reporting a failure to get this
- *   mode page.  Implemented four IOCTLs in order to
- *   implement formatting.  IOCTls begin with 0x4600,
- *   0x46 is 'F' as in Format.
- *Jan 9 01   Userland option to select format verify.
- *   Added PC_SUPPRESS_ERROR flag - some idefloppy drives
- *   do not implement IDEFLOPPY_CAPABILITIES_PAGE, and
- *   return a sense error.  Suppress error reporting in
- *   this particular case in order to avoid spurious
- *   errors in syslog.  The culprit is
- *   idefloppy_get_capability_page(), so move it to
- *   idefloppy_begin_format() so that it's not used
- *   unless absolutely necessary.
- *   If drive does not support format progress indication
- *   monitor the dsc bit in the status register.
- *   Also, O_NDELAY on open will allow the device to be
- *   opened without a disk available.  This can be used to
- *   open an unformatted disk, or get the device capacity.
- * Ver 0.91  Dec 11 99   Added IOMEGA Clik! drive support by 
- *[EMAIL PROTECTED]
- * Ver 0.92  Oct 22 00   Paul Bristow became official maintainer for this 
- *driver.  Included Powerbook internal zip kludge.
- * Ver 0.93  Oct 24 00   Fixed bugs for Clik! drive
- *no disk on insert and disk change now works
- * Ver 0.94  Oct 27 00   Tidied up to remove strstr(Clik) everywhere
- * Ver 0.95  Nov  7 00   Brought across to kernel 2.4
- * Ver 0.96  Jan  7 01   Actually in line with release version of 2.4.0
- *   including set_bit patch from Rusty Russell
- * Ver 0.97  Jul 22 01   Merge 0.91-0.96 onto 0.9.sv for ac series
- * Ver 0.97.sv Aug 3 01  Backported from 2.4.7-ac3
- * Ver 0.98  Oct 26 01   Split idefloppy_transfer_pc into two pieces to
- *fix a lost interrupt problem. It appears the busy
- *bit was being deasserted by my IOMEGA ATAPI ZIP 100
- *drive before the drive was actually ready.
- * Ver 0.98a Oct 29 01   Expose delay value so we can play.
- * Ver 0.99  Feb 24 02   Remove duplicate code, modify clik! detection code 
- *to support new PocketZip drives 
+ * For a historical changelog see
+ * Documentation/ide/ChangeLog.ide-floppy.1996-2002
  */
 
 #define IDEFLOPPY_VERSION 0.99.newide
-- 
1.5.3.7

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 14/63] ide-cd: fix trailing whitespaces in changelog

[Sergei Shtylyov]

Bartlomiej Zolnierkiewicz wrote:


Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>


Acked-by: Sergei Shtylyov <[EMAIL PROTECTED]>

MBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 14/63] ide-cd: fix trailing whitespaces in changelog

[Sergei Shtylyov]

Bartlomiej Zolnierkiewicz wrote:


Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]


Acked-by: Sergei Shtylyov [EMAIL PROTECTED]

MBR, Sergei
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 15/63] ide-cd: move historical changelog to Documentation/ide/ChangeLog.ide-cd.1994-2004

[Bartlomiej Zolnierkiewicz]

ille Hallik" <[EMAIL PROTECTED]>.
- *  - other minor stuff.
- *
- * 4.52  Jan 19, 1999  -- Jens Axboe <[EMAIL PROTECTED]>
- *  - Detect DVD-ROM/RAM drives
- *
- * 4.53  Feb 22, 1999   - Include other model Samsung and one Goldstar
- * drive in transfer size limit.
- *  - Fix the I/O error when doing eject without a medium
- * loaded on some drives.
- *  - CDROMREADMODE2 is now implemented through
- * CDROMREADRAW, since many drives don't support
- * MODE2 (even though ATAPI 2.6 says they must).
- *  - Added ignore parameter to ide-cd (as a module), eg
- * insmod ide-cd ignore='hda hdb'
- * Useful when using ide-cd in conjunction with
- * ide-scsi. TODO: non-modular way of doing the
- * same.
- *
- * 4.54  Aug 5, 1999   - Support for MMC2 class commands through the generic
- *   packet interface to cdrom.c.
- * - Unified audio ioctl support, most of it.
- * - cleaned up various deprecated verify_area().
- * - Added ide_cdrom_packet() as the interface for
- *   the Uniform generic_packet().
- * - bunch of other stuff, will fill in logs later.
- * - report 1 slot for non-changers, like the other
- *   cd-rom drivers. don't report select disc for
- *   non-changers as well.
- * - mask out audio playing, if the device can't do it.
- *
- * 4.55  Sep 1, 1999   - Eliminated the rest of the audio ioctls, except
- *   for CDROMREADTOC[ENTRY|HEADER]. Some of the drivers
- *   use this independently of the actual audio handling.
- *   They will disappear later when I get the time to
- *   do it cleanly.
- * - Minimize the TOC reading - only do it when we
- *   know a media change has occurred.
- * - Moved all the CDROMREADx ioctls to the Uniform layer.
- * - Heiko Eißfeldt <[EMAIL PROTECTED]> supplied
- *   some fixes for CDI.
- * - CD-ROM leaving door locked fix from Andries
- *   Brouwer <[EMAIL PROTECTED]>
- * - Erik Andersen <[EMAIL PROTECTED]> unified
- *   commands across the various drivers and how
- *   sense errors are handled.
- *
- * 4.56  Sep 12, 1999  - Removed changer support - it is now in the
- *   Uniform layer.
- * - Added partition based multisession handling.
- * - Mode sense and mode select moved to the
- *   Uniform layer.
- * - Fixed a problem with WPI CDS-32X drive - it
- *   failed the capabilities
- *
- * 4.57  Apr 7, 2000   - Fixed sense reporting.
- * - Fixed possible oops in ide_cdrom_get_last_session()
- * - Fix locking mania and make ide_cdrom_reset relock
- * - Stop spewing errors to log when magicdev polls with
- *   TEST_UNIT_READY on some drives.
- * - Various fixes from Tobias Ringstrom:
- *   tray if it was locked prior to the reset.
- *   - cdrom_read_capacity returns one frame too little.
- *   - Fix real capacity reporting.
- *
- * 4.58  May 1, 2000   - Clean up ACER50 stuff.
- * - Fix small problem with ide_cdrom_capacity
- *
- * 4.59  Aug 11, 2000  - Fix changer problem in cdrom_read_toc, we weren't
- *   correctly sensing a disc change.
- * - Rearranged some code
- * - Use extended sense on drives that support it for
- *   correctly reporting tray status -- from
- *   Michael D Johnson <[EMAIL PROTECTED]>
- * 4.60  Dec 17, 2003  - Add mt rainier support
- * - Bump timeout for packet commands, matches sr
- * - Odd stuff
- * 4.61  Jan 22, 2004  - support hardware sector sizes other than 2kB,
- *   Pascal Schmidt <[EMAIL PROTECTED]>
- *
- */
- 
+ * For historical changelog please see:
+ * Documentation/ide/ChangeLog.ide-cd.1994-2004
+ */
+
 #define IDECD_VERSION "4.61"
 
 #include 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 14/63] ide-cd: fix trailing whitespaces in changelog

[Bartlomiej Zolnierkiewicz]

Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
---
 drivers/ide/ide-cd.c |   23 +++
 1 file changed, 11 insertions(+), 12 deletions(-)

Index: b/drivers/ide/ide-cd.c
===
--- a/drivers/ide/ide-cd.c
+++ b/drivers/ide/ide-cd.c
@@ -129,16 +129,15 @@
  * 3.14  May 29, 1996 -- Add work-around for Vertos 600.
  *(From Hennus Bergman <[EMAIL PROTECTED]>.)
  * 3.15  July 2, 1996 -- Added support for Sanyo 3 CD changers
- *from Ben Galliart <[EMAIL PROTECTED]> with 
- *special help from Jeff Lightfoot 
+ *from Ben Galliart <[EMAIL PROTECTED]> with
+ *special help from Jeff Lightfoot
  *<[EMAIL PROTECTED]>
  * 3.15a July 9, 1996 -- Improved Sanyo 3 CD changer identification
  * 3.16  Jul 28, 1996 -- Fix from Gadi to reduce kernel stack usage for ioctl.
  * 3.17  Sep 17, 1996 -- Tweak audio reads for some drives.
  *   Start changing CDROMLOADFROMSLOT to CDROM_SELECT_DISC.
  * 3.18  Oct 31, 1996 -- Added module and DMA support.
- *   
- *   
+ *
  * 4.00  Nov 5, 1996   -- New ide-cd maintainer,
  * Erik B. Andersen <[EMAIL PROTECTED]>
  * -- Newer Creative drives don't always set the error
@@ -153,8 +152,8 @@
  * -- Add some probes of drive capability during setup.
  *
  * 4.01  Nov 11, 1996  -- Split into ide-cd.c and ide-cd.h
- * -- Removed CDROMMECHANISMSTATUS and CDROMSLOTTABLE 
- *  ioctls in favor of a generalized approach 
+ * -- Removed CDROMMECHANISMSTATUS and CDROMSLOTTABLE
+ *  ioctls in favor of a generalized approach
  *  using the generic cdrom driver.
  * -- Fully integrated with the 2.1.X kernel.
  * -- Other stuff that I forgot (lots of changes)
@@ -163,7 +162,7 @@
  *  to fix the drive door locking problems.
  *
  * 4.03  Dec 04, 1996  -- Added DSC overlap support.
- * 4.04  Dec 29, 1996  -- Added CDROMREADRAW ioclt based on patch 
+ * 4.04  Dec 29, 1996  -- Added CDROMREADRAW ioclt based on patch
  *  by Ales Makarov ([EMAIL PROTECTED])
  *
  * 4.05  Nov 20, 1997  -- Modified to print more drive info on init
@@ -186,7 +185,7 @@
  * -- Cleaned up the global namespace a bit by making more
  * functions static that should already have been.
  * 4.11  Mar 12, 1998  -- Added support for the CDROM_SELECT_SPEED ioctl
- * based on a patch for 2.0.33 by Jelle Foks 
+ * based on a patch for 2.0.33 by Jelle Foks
  * <[EMAIL PROTECTED]>, a patch for 2.0.33
  * by Toni Giorgino <[EMAIL PROTECTED]>, the SCSI
  * version, and my own efforts.  -erik
@@ -194,8 +193,8 @@
  * inform me of where "Illegal mode for this track"
  * was never returned due to a comparison on data
  * types of limited range.
- * 4.12  Mar 29, 1998  -- Fixed bug in CDROM_SELECT_SPEED so write speed is 
- * now set ionly for CD-R and CD-RW drives.  I had 
+ * 4.12  Mar 29, 1998  -- Fixed bug in CDROM_SELECT_SPEED so write speed is
+ * now set ionly for CD-R and CD-RW drives.  I had
  * removed this support because it produced errors.
  * It produced errors _only_ for non-writers. duh.
  * 4.13  May 05, 1998  -- Suppress useless "in progress of becoming ready"
@@ -206,7 +205,7 @@
  * since the .pdf version doesn't seem to work...
  * -- Updated the TODO list to something more current.
  *
- * 4.15  Aug 25, 1998  -- Updated ide-cd.h to respect mechine endianess, 
+ * 4.15  Aug 25, 1998  -- Updated ide-cd.h to respect mechine endianess,
  * patch thanks to "Eddie C. Dost" <[EMAIL PROTECTED]>
  *
  * 4.50  Oct 19, 1998  -- New maintainers!
@@ -270,7 +269,7 @@
  * - Mode sense and mode select moved to the
  *   Uniform layer.
  * - Fixed a problem with WPI CDS-32X drive - it
- *   failed the capabilities 
+ *   failed the capabilities
  *
  * 4.57  Apr 7, 2000   - Fixed sense reporting.
  * - Fixed possible oops in ide_cdrom_get_last_session()
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  

[PATCH 14/63] ide-cd: fix trailing whitespaces in changelog

[Bartlomiej Zolnierkiewicz]

Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
---
 drivers/ide/ide-cd.c |   23 +++
 1 file changed, 11 insertions(+), 12 deletions(-)

Index: b/drivers/ide/ide-cd.c
===
--- a/drivers/ide/ide-cd.c
+++ b/drivers/ide/ide-cd.c
@@ -129,16 +129,15 @@
  * 3.14  May 29, 1996 -- Add work-around for Vertos 600.
  *(From Hennus Bergman [EMAIL PROTECTED].)
  * 3.15  July 2, 1996 -- Added support for Sanyo 3 CD changers
- *from Ben Galliart [EMAIL PROTECTED] with 
- *special help from Jeff Lightfoot 
+ *from Ben Galliart [EMAIL PROTECTED] with
+ *special help from Jeff Lightfoot
  *[EMAIL PROTECTED]
  * 3.15a July 9, 1996 -- Improved Sanyo 3 CD changer identification
  * 3.16  Jul 28, 1996 -- Fix from Gadi to reduce kernel stack usage for ioctl.
  * 3.17  Sep 17, 1996 -- Tweak audio reads for some drives.
  *   Start changing CDROMLOADFROMSLOT to CDROM_SELECT_DISC.
  * 3.18  Oct 31, 1996 -- Added module and DMA support.
- *   
- *   
+ *
  * 4.00  Nov 5, 1996   -- New ide-cd maintainer,
  * Erik B. Andersen [EMAIL PROTECTED]
  * -- Newer Creative drives don't always set the error
@@ -153,8 +152,8 @@
  * -- Add some probes of drive capability during setup.
  *
  * 4.01  Nov 11, 1996  -- Split into ide-cd.c and ide-cd.h
- * -- Removed CDROMMECHANISMSTATUS and CDROMSLOTTABLE 
- *  ioctls in favor of a generalized approach 
+ * -- Removed CDROMMECHANISMSTATUS and CDROMSLOTTABLE
+ *  ioctls in favor of a generalized approach
  *  using the generic cdrom driver.
  * -- Fully integrated with the 2.1.X kernel.
  * -- Other stuff that I forgot (lots of changes)
@@ -163,7 +162,7 @@
  *  to fix the drive door locking problems.
  *
  * 4.03  Dec 04, 1996  -- Added DSC overlap support.
- * 4.04  Dec 29, 1996  -- Added CDROMREADRAW ioclt based on patch 
+ * 4.04  Dec 29, 1996  -- Added CDROMREADRAW ioclt based on patch
  *  by Ales Makarov ([EMAIL PROTECTED])
  *
  * 4.05  Nov 20, 1997  -- Modified to print more drive info on init
@@ -186,7 +185,7 @@
  * -- Cleaned up the global namespace a bit by making more
  * functions static that should already have been.
  * 4.11  Mar 12, 1998  -- Added support for the CDROM_SELECT_SPEED ioctl
- * based on a patch for 2.0.33 by Jelle Foks 
+ * based on a patch for 2.0.33 by Jelle Foks
  * [EMAIL PROTECTED], a patch for 2.0.33
  * by Toni Giorgino [EMAIL PROTECTED], the SCSI
  * version, and my own efforts.  -erik
@@ -194,8 +193,8 @@
  * inform me of where Illegal mode for this track
  * was never returned due to a comparison on data
  * types of limited range.
- * 4.12  Mar 29, 1998  -- Fixed bug in CDROM_SELECT_SPEED so write speed is 
- * now set ionly for CD-R and CD-RW drives.  I had 
+ * 4.12  Mar 29, 1998  -- Fixed bug in CDROM_SELECT_SPEED so write speed is
+ * now set ionly for CD-R and CD-RW drives.  I had
  * removed this support because it produced errors.
  * It produced errors _only_ for non-writers. duh.
  * 4.13  May 05, 1998  -- Suppress useless in progress of becoming ready
@@ -206,7 +205,7 @@
  * since the .pdf version doesn't seem to work...
  * -- Updated the TODO list to something more current.
  *
- * 4.15  Aug 25, 1998  -- Updated ide-cd.h to respect mechine endianess, 
+ * 4.15  Aug 25, 1998  -- Updated ide-cd.h to respect mechine endianess,
  * patch thanks to Eddie C. Dost [EMAIL PROTECTED]
  *
  * 4.50  Oct 19, 1998  -- New maintainers!
@@ -270,7 +269,7 @@
  * - Mode sense and mode select moved to the
  *   Uniform layer.
  * - Fixed a problem with WPI CDS-32X drive - it
- *   failed the capabilities 
+ *   failed the capabilities
  *
  * 4.57  Apr 7, 2000   - Fixed sense reporting.
  * - Fixed possible oops in ide_cdrom_get_last_session()
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 15/63] ide-cd: move historical changelog to Documentation/ide/ChangeLog.ide-cd.1994-2004

[Bartlomiej Zolnierkiewicz]

- * MODE2 (even though ATAPI 2.6 says they must).
- *  - Added ignore parameter to ide-cd (as a module), eg
- * insmod ide-cd ignore='hda hdb'
- * Useful when using ide-cd in conjunction with
- * ide-scsi. TODO: non-modular way of doing the
- * same.
- *
- * 4.54  Aug 5, 1999   - Support for MMC2 class commands through the generic
- *   packet interface to cdrom.c.
- * - Unified audio ioctl support, most of it.
- * - cleaned up various deprecated verify_area().
- * - Added ide_cdrom_packet() as the interface for
- *   the Uniform generic_packet().
- * - bunch of other stuff, will fill in logs later.
- * - report 1 slot for non-changers, like the other
- *   cd-rom drivers. don't report select disc for
- *   non-changers as well.
- * - mask out audio playing, if the device can't do it.
- *
- * 4.55  Sep 1, 1999   - Eliminated the rest of the audio ioctls, except
- *   for CDROMREADTOC[ENTRY|HEADER]. Some of the drivers
- *   use this independently of the actual audio handling.
- *   They will disappear later when I get the time to
- *   do it cleanly.
- * - Minimize the TOC reading - only do it when we
- *   know a media change has occurred.
- * - Moved all the CDROMREADx ioctls to the Uniform layer.
- * - Heiko Eißfeldt [EMAIL PROTECTED] supplied
- *   some fixes for CDI.
- * - CD-ROM leaving door locked fix from Andries
- *   Brouwer [EMAIL PROTECTED]
- * - Erik Andersen [EMAIL PROTECTED] unified
- *   commands across the various drivers and how
- *   sense errors are handled.
- *
- * 4.56  Sep 12, 1999  - Removed changer support - it is now in the
- *   Uniform layer.
- * - Added partition based multisession handling.
- * - Mode sense and mode select moved to the
- *   Uniform layer.
- * - Fixed a problem with WPI CDS-32X drive - it
- *   failed the capabilities
- *
- * 4.57  Apr 7, 2000   - Fixed sense reporting.
- * - Fixed possible oops in ide_cdrom_get_last_session()
- * - Fix locking mania and make ide_cdrom_reset relock
- * - Stop spewing errors to log when magicdev polls with
- *   TEST_UNIT_READY on some drives.
- * - Various fixes from Tobias Ringstrom:
- *   tray if it was locked prior to the reset.
- *   - cdrom_read_capacity returns one frame too little.
- *   - Fix real capacity reporting.
- *
- * 4.58  May 1, 2000   - Clean up ACER50 stuff.
- * - Fix small problem with ide_cdrom_capacity
- *
- * 4.59  Aug 11, 2000  - Fix changer problem in cdrom_read_toc, we weren't
- *   correctly sensing a disc change.
- * - Rearranged some code
- * - Use extended sense on drives that support it for
- *   correctly reporting tray status -- from
- *   Michael D Johnson [EMAIL PROTECTED]
- * 4.60  Dec 17, 2003  - Add mt rainier support
- * - Bump timeout for packet commands, matches sr
- * - Odd stuff
- * 4.61  Jan 22, 2004  - support hardware sector sizes other than 2kB,
- *   Pascal Schmidt [EMAIL PROTECTED]
- *
- */
- 
+ * For historical changelog please see:
+ * Documentation/ide/ChangeLog.ide-cd.1994-2004
+ */
+
 #define IDECD_VERSION 4.61
 
 #include linux/module.h
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

git changelog / shortlog function on www.eu.kernel.org still refers to www.kernel.org server

[Matthew]

Hi everybody on the linux-kernel mailing list,

I discovered that the changelog-function of www.eu.kernel.org still
links / refers to www.kernel.org

e.g. if I click on:

The latest stable version of the Linux kernel is:   2.6.23.1
2007-10-12 16:47 UTCF   V   C   Changelog <== 
on the 'C'

it refers to 
http://git.kernel.org/?p=linux%2Fkernel%2Fgit%2Fstable%2Flinux-2.6.23.y.git;a=summary

shouldn't the link better refer on each 'C' to
http://git.eu.kernel.org/?p=linux%2Fkernel%2Fgit%2Fstable%2Flinux-2.6.23.y.git;a=summary
(http://git.eu.kernel.org)

that should put less load on the general / US-servers  ...

... or am I wrong and it is handled via round-robin ?

hope everyone understands what I mean ;)

Cheers

Mat
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

git changelog / shortlog function on www.eu.kernel.org still refers to www.kernel.org server

[Matthew]

Hi everybody on the linux-kernel mailing list,

I discovered that the changelog-function of www.eu.kernel.org still
links / refers to www.kernel.org

e.g. if I click on:

The latest stable version of the Linux kernel is:   2.6.23.1
2007-10-12 16:47 UTCF   V   C   Changelog == 
on the 'C'

it refers to 
http://git.kernel.org/?p=linux%2Fkernel%2Fgit%2Fstable%2Flinux-2.6.23.y.git;a=summary

shouldn't the link better refer on each 'C' to
http://git.eu.kernel.org/?p=linux%2Fkernel%2Fgit%2Fstable%2Flinux-2.6.23.y.git;a=summary
(http://git.eu.kernel.org)

that should put less load on the general / US-servers  ...

... or am I wrong and it is handled via round-robin ?

hope everyone understands what I mean ;)

Cheers

Mat
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

PATCH 6/6] scsi: megaraid_sas - Update version and changelog

[bo yang]

Update version and changelog

Signed-off-by: Bo Yang <[EMAIL PROTECTED]>

---
 Documentation/scsi/ChangeLog.megaraid_sas |  155 
 drivers/scsi/megaraid/megaraid_sas.c  |   10 -
 drivers/scsi/megaraid/megaraid_sas.h  |8 -
 3 files changed, 164 insertions(+), 9 deletions(-)

diff -rupN linux-2.6.22_orig/Documentation/scsi/ChangeLog.megaraid_sas 
linux-2.6.22_new/Documentation/scsi/ChangeLog.megaraid_sas
--- linux-2.6.22_orig/Documentation/scsi/ChangeLog.megaraid_sas 2007-11-07 
02:42:15.908757968 -0500
+++ linux-2.6.22_new/Documentation/scsi/ChangeLog.megaraid_sas  2007-11-07 
02:51:31.273329720 -0500
@@ -1,3 +1,158 @@
+1 Release Date: Thur. Nov. 07 16:30:43 PST 2007 -
+   (emaild-id:[EMAIL PROTECTED])
+   Sumant Patro
+   Bo Yang 
+
+2 Current Version : 00.00.03.16
+3 Older Version   : 00.00.03.15
+
+1. Increased MFI_POLL_TIMEOUT_SECS to 60 seconds from 10. FW may take a max of 
60 seconds to 
+   respond to the INIT cmd.
+
+1 Release Date: Fri. Sep. 07 16:30:43 PST 2007 -
+   (emaild-id:[EMAIL PROTECTED])
+   Sumant Patro
+   Bo Yang 
+
+2 Current Version : 00.00.03.15
+3 Older Version   : 00.00.03.14
+
+1. Added module parameter "poll_mode_io" to support for "polling" (reduced 
interrupt operation).
+   In this mode, IO completion interrupts are delayed. At the end of 
initiating IOs,
+   the driver schedules for cmd completion if there are pending cmds to be 
completed.
+   A timer-based interrupt has also been added to prevent IO completion 
processing from
+   being delayed indefinitely in the case that no new IOs are initiated.
+
+1 Release Date: Fri. Sep. 07 16:30:43 PST 2007 -
+   (emaild-id:[EMAIL PROTECTED])
+   Sumant Patro
+   Bo Yang 
+
+2 Current Version : 00.00.03.14
+3 Older Version   : 00.00.03.13
+
+1. Setting the max_sectors_per_req based on max SGL supported by the FW. Prior 
versions calculated 
+   this value from controller info (max_sectors_1, max_sectors_2). For 
certain controllers/FW,
+   this was resulting in a value greater than max SGL supported by the FW. 
Issue was first
+   reported by users running LUKS+XFS with megaraid_sas.
+   Thanks to RB for providing the logs and duplication steps that helped 
to get to the root 
+   cause of the issue.
+2. Increased MFI_POLL_TIMEOUT_SECS to 60 seconds from 10. FW may take a max of 
60 seconds to 
+   respond to the INIT cmd.
+
+1 Release Date: Fri. June. 15 16:30:43 PST 2007 -
+   (emaild-id:[EMAIL PROTECTED])
+   Sumant Patro
+   Bo Yang 
+
+2 Current Version : 00.00.03.13
+3 Older Version   : 00.00.03.12
+
+1. Added the megasas_reset_timer routine to intercept cmd timeout and throttle 
io.
+
+On Fri, 2007-03-16 at 16:44 -0600, James Bottomley wrote:
+It looks like megaraid_sas at least needs this to throttle its commands
+> as they begin to time out.  The code keeps the existing transport
+> template use of eh_timed_out (and allows the transport to override the
+> host if they both have this callback).
+> 
+> James
+
+1 Release Date: Sat May. 12 16:30:43 PST 2007 -
+   (emaild-id:[EMAIL PROTECTED])
+   Sumant Patro
+   Bo Yang 
+
+2 Current Version : 00.00.03.12
+3 Older Version   : 00.00.03.11
+
+1.  When MegaSAS driver receives reset call from OS, driver waits in reset
+routine for max 3 minutes for all pending command completion. Now driver will
+call completion routine every 5 seconds from the reset routine instead of
+waiting for depending on cmd completion from isr path.
+
+1 Release Date: Mon Apr. 30 10:25:52 PST 2007 -
+   (emaild-id:[EMAIL PROTECTED])
+   Sumant Patro
+   Bo Yang 
+
+2 Current Version : 00.00.03.11
+3 Older Version   : 00.00.03.09
+
+   1. Memory Manager for IOCTL removed for 2.6 kernels.
+  pci_alloc_consistent replaced by dma_alloc_coherent. With this 
+  change there is no need of memory manager in the driver code
+
+   On Wed, 2007-02-07 at 13:30 -0800, Andrew Morton wrote:
+   > I suspect all this horror is due to stupidity in the DMA API.
+   >
+   > pci_alloc_consistent() just goes and assumes GFP_ATOMIC, whereas
+   > the caller (megasas_mgmt_fw_ioctl) would have been perfectly happy
+   > to use GFP_KERNEL.
+   >
+   > I bet this fixes it
+
+   It does, but the DMA API was expanded to cope with this exact case, so
+   use dma_alloc_coherent() directly in the megaraid code instead.  The dev
+   is just _dev->dev.
+
+   James <[EMAIL PROTECTED]>
+
+   3. SYNCHRONIZE_CACHE is not supported by FW and

PATCH 6/6] scsi: megaraid_sas - Update version and changelog

[bo yang]

Update version and changelog

Signed-off-by: Bo Yang [EMAIL PROTECTED]

---
 Documentation/scsi/ChangeLog.megaraid_sas |  155 
 drivers/scsi/megaraid/megaraid_sas.c  |   10 -
 drivers/scsi/megaraid/megaraid_sas.h  |8 -
 3 files changed, 164 insertions(+), 9 deletions(-)

diff -rupN linux-2.6.22_orig/Documentation/scsi/ChangeLog.megaraid_sas 
linux-2.6.22_new/Documentation/scsi/ChangeLog.megaraid_sas
--- linux-2.6.22_orig/Documentation/scsi/ChangeLog.megaraid_sas 2007-11-07 
02:42:15.908757968 -0500
+++ linux-2.6.22_new/Documentation/scsi/ChangeLog.megaraid_sas  2007-11-07 
02:51:31.273329720 -0500
@@ -1,3 +1,158 @@
+1 Release Date: Thur. Nov. 07 16:30:43 PST 2007 -
+   (emaild-id:[EMAIL PROTECTED])
+   Sumant Patro
+   Bo Yang 
+
+2 Current Version : 00.00.03.16
+3 Older Version   : 00.00.03.15
+
+1. Increased MFI_POLL_TIMEOUT_SECS to 60 seconds from 10. FW may take a max of 
60 seconds to 
+   respond to the INIT cmd.
+
+1 Release Date: Fri. Sep. 07 16:30:43 PST 2007 -
+   (emaild-id:[EMAIL PROTECTED])
+   Sumant Patro
+   Bo Yang 
+
+2 Current Version : 00.00.03.15
+3 Older Version   : 00.00.03.14
+
+1. Added module parameter poll_mode_io to support for polling (reduced 
interrupt operation).
+   In this mode, IO completion interrupts are delayed. At the end of 
initiating IOs,
+   the driver schedules for cmd completion if there are pending cmds to be 
completed.
+   A timer-based interrupt has also been added to prevent IO completion 
processing from
+   being delayed indefinitely in the case that no new IOs are initiated.
+
+1 Release Date: Fri. Sep. 07 16:30:43 PST 2007 -
+   (emaild-id:[EMAIL PROTECTED])
+   Sumant Patro
+   Bo Yang 
+
+2 Current Version : 00.00.03.14
+3 Older Version   : 00.00.03.13
+
+1. Setting the max_sectors_per_req based on max SGL supported by the FW. Prior 
versions calculated 
+   this value from controller info (max_sectors_1, max_sectors_2). For 
certain controllers/FW,
+   this was resulting in a value greater than max SGL supported by the FW. 
Issue was first
+   reported by users running LUKS+XFS with megaraid_sas.
+   Thanks to RB for providing the logs and duplication steps that helped 
to get to the root 
+   cause of the issue.
+2. Increased MFI_POLL_TIMEOUT_SECS to 60 seconds from 10. FW may take a max of 
60 seconds to 
+   respond to the INIT cmd.
+
+1 Release Date: Fri. June. 15 16:30:43 PST 2007 -
+   (emaild-id:[EMAIL PROTECTED])
+   Sumant Patro
+   Bo Yang 
+
+2 Current Version : 00.00.03.13
+3 Older Version   : 00.00.03.12
+
+1. Added the megasas_reset_timer routine to intercept cmd timeout and throttle 
io.
+
+On Fri, 2007-03-16 at 16:44 -0600, James Bottomley wrote:
+It looks like megaraid_sas at least needs this to throttle its commands
+ as they begin to time out.  The code keeps the existing transport
+ template use of eh_timed_out (and allows the transport to override the
+ host if they both have this callback).
+ 
+ James
+
+1 Release Date: Sat May. 12 16:30:43 PST 2007 -
+   (emaild-id:[EMAIL PROTECTED])
+   Sumant Patro
+   Bo Yang 
+
+2 Current Version : 00.00.03.12
+3 Older Version   : 00.00.03.11
+
+1.  When MegaSAS driver receives reset call from OS, driver waits in reset
+routine for max 3 minutes for all pending command completion. Now driver will
+call completion routine every 5 seconds from the reset routine instead of
+waiting for depending on cmd completion from isr path.
+
+1 Release Date: Mon Apr. 30 10:25:52 PST 2007 -
+   (emaild-id:[EMAIL PROTECTED])
+   Sumant Patro
+   Bo Yang 
+
+2 Current Version : 00.00.03.11
+3 Older Version   : 00.00.03.09
+
+   1. Memory Manager for IOCTL removed for 2.6 kernels.
+  pci_alloc_consistent replaced by dma_alloc_coherent. With this 
+  change there is no need of memory manager in the driver code
+
+   On Wed, 2007-02-07 at 13:30 -0800, Andrew Morton wrote:
+I suspect all this horror is due to stupidity in the DMA API.
+   
+pci_alloc_consistent() just goes and assumes GFP_ATOMIC, whereas
+the caller (megasas_mgmt_fw_ioctl) would have been perfectly happy
+to use GFP_KERNEL.
+   
+I bet this fixes it
+
+   It does, but the DMA API was expanded to cope with this exact case, so
+   use dma_alloc_coherent() directly in the megaraid code instead.  The dev
+   is just pci_dev-dev.
+
+   James [EMAIL PROTECTED]
+
+   3. SYNCHRONIZE_CACHE is not supported by FW and thus blocked by driver.
+   4. Hibernation support added
+   5. Performing diskdump while

Re: arcmsr changelog differs from diffs

[Jeff Garzik]

Björn Steinbrink wrote:

Hi Hans,

On 2007.10.17 12:41:11 +0200, Hans-Peter Jansen wrote:

Dear Björn,

Am Mittwoch, 17. Oktober 2007 02:53 schrieb Björn Steinbrink:

And then, if I may guess, James probably just noticed that there were
changes left and commited them (while they were now down to just the
whitespace change), without checking what changes were actually left (no
offense intended). At least I think that git wouldn't cripple the diff
if the changes that James checked in were not already whitespace-only at
the time he commited them, and the git history of his tree seems to
agree.
(*) Thanks for the clarification, Björn. What made me stumbling was the 
different orginators, while Jeff isn't known with catching attention by 
assimilating other peoples contributions. 


I'm just guessing here, and certainly don't want to blame anyone, but
Jeff's original patch was from July, while the only date I can find for
Nick's commit is September 13th. So it was probably Nick who integrated
Jeff's changes into his commit 


Correct.

It's also quite normal for the maintainer to grab a patch off the list, 
integrate/massage/change it, and then apply it himself.


Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: arcmsr changelog differs from diffs

[Björn Steinbrink]

Hi Hans,

On 2007.10.17 12:41:11 +0200, Hans-Peter Jansen wrote:
> Dear Björn,
> 
> Am Mittwoch, 17. Oktober 2007 02:53 schrieb Björn Steinbrink:
> > And then, if I may guess, James probably just noticed that there were
> > changes left and commited them (while they were now down to just the
> > whitespace change), without checking what changes were actually left (no
> > offense intended). At least I think that git wouldn't cripple the diff
> > if the changes that James checked in were not already whitespace-only at
> > the time he commited them, and the git history of his tree seems to
> > agree.
> 
> (*) Thanks for the clarification, Björn. What made me stumbling was the 
> different orginators, while Jeff isn't known with catching attention by 
> assimilating other peoples contributions. 

I'm just guessing here, and certainly don't want to blame anyone, but
Jeff's original patch was from July, while the only date I can find for
Nick's commit is September 13th. So it was probably Nick who integrated
Jeff's changes into his commit (maybe thinking that Jeff's patch got
lost), not Jeff assimilating a subset of Nick's changes.

Björn
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: arcmsr changelog differs from diffs

[Hans-Peter Jansen]

Dear Björn,

Am Mittwoch, 17. Oktober 2007 02:53 schrieb Björn Steinbrink:
> On 2007.10.17 00:07:19 +0200, Hans-Peter Jansen wrote:
> > Hi Jeff,
> >
> > while browsing through Linus' current check ins, I stumbled upon:
> >
> > [SCSI] arcmsr: irq handler fixes, cleanups, micro-opts:
> >
> > --8<--
> > 488a5c8a9a3b67ae117784cd0d73bef53a73d57d
> >  drivers/scsi/arcmsr/arcmsr_hba.c |2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/scsi/arcmsr/arcmsr_hba.c
> > b/drivers/scsi/arcmsr/arcmsr_hba.c
> > index 7832a10..f4d2d52 100644
> > --- a/drivers/scsi/arcmsr/arcmsr_hba.c
> > +++ b/drivers/scsi/arcmsr/arcmsr_hba.c
> > @@ -422,7 +422,7 @@ static int arcmsr_probe(struct pci_dev *pdev,
> > goto out_release_regions;
> >
> > error = request_irq(pdev->irq, arcmsr_do_interrupt,
> > -   IRQF_SHARED, "arcmsr", acb);
> > +   IRQF_SHARED, "arcmsr", acb);
> > if (error)
> > goto out_free_ccb_pool;
> >
> > -->8--
> >
> > and: [SCSI] arcmsr: Fix hardware wait loops
> >
> > --8<--
> > 24430458bb924e371ff894e26bfa9f73707f53fb
> >  drivers/scsi/arcmsr/arcmsr_hba.c |2 ++
> >  1 files changed, 2 insertions(+), 0 deletions(-)
> >
> > diff --git a/drivers/scsi/arcmsr/arcmsr_hba.c
> > b/drivers/scsi/arcmsr/arcmsr_hba.c
> > index 50e1310..7832a10 100644
> > --- a/drivers/scsi/arcmsr/arcmsr_hba.c
> > +++ b/drivers/scsi/arcmsr/arcmsr_hba.c
> > @@ -2092,8 +2092,10 @@ static void arcmsr_iop_reset(struct
> > AdapterControlBlock *acb)
> > if (atomic_read(>ccboutstandingcount) != 0) {
> > /* talk to iop 331 outstanding command aborted */
> > arcmsr_abort_allcmd(acb);
> > +
> > /* wait for 3 sec for all command aborted*/
> > ssleep(3);
> > +
> > /* disable all outbound interrupt */
> > intmask_org = arcmsr_disable_outbound_ints(acb);
> > /* clear all outbound posted Q */
> > -->8--
> >
> > where both changelogs differ significantly from the actual diffs, which
> > both are simple WS fixups and nothing else. Does qgit fools me here, or
> > is anything else wrong on my side?
>
> Nothing wrong on your side. I took a look at the second one, and
> everything but the whitespace changes already found its way into Linus'
> tree via 1a4f550a09f89e3a15eff1971bc9db977571b9f6. One hunk of the
> original patch[1] was actually made redundant because the code was
> removed in that commit, so that's probably what James fixed (see full
> commit message).

Yup, I found the patch you mentioned also, but that time orginating from 
Nick Cheng (*).

That diff is unfortunately way too big for me to be able to decide, if it's 
worth it to replace a former instance of arcmsr-1.20.0.13 for a 2.6.18.8 
kernel, which I use and essentially depend on here.

Thus I decided now to bluntly cc Nick and ask directly this way:
Nick, does 1.20.0.15 provide any essential changes over 1.20.0.13 for a 
ARC-1130 with FW 1.41 (2006-05-24), which advise updating?

> And then, if I may guess, James probably just noticed that there were
> changes left and commited them (while they were now down to just the
> whitespace change), without checking what changes were actually left (no
> offense intended). At least I think that git wouldn't cripple the diff
> if the changes that James checked in were not already whitespace-only at
> the time he commited them, and the git history of his tree seems to
> agree.

(*) Thanks for the clarification, Björn. What made me stumbling was the 
different orginators, while Jeff isn't known with catching attention by 
assimilating other peoples contributions. 

> Probably the other commit is similar.
>
> Björn
>
> [1] http://linux.derkeiler.com/Mailing-Lists/Kernel/2007-07/msg11957.html

Pete
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: arcmsr changelog differs from diffs

[Jeff Garzik]

Björn Steinbrink wrote:

Hi Hans,

On 2007.10.17 12:41:11 +0200, Hans-Peter Jansen wrote:

Dear Björn,

Am Mittwoch, 17. Oktober 2007 02:53 schrieb Björn Steinbrink:

And then, if I may guess, James probably just noticed that there were
changes left and commited them (while they were now down to just the
whitespace change), without checking what changes were actually left (no
offense intended). At least I think that git wouldn't cripple the diff
if the changes that James checked in were not already whitespace-only at
the time he commited them, and the git history of his tree seems to
agree.
(*) Thanks for the clarification, Björn. What made me stumbling was the 
different orginators, while Jeff isn't known with catching attention by 
assimilating other peoples contributions. 


I'm just guessing here, and certainly don't want to blame anyone, but
Jeff's original patch was from July, while the only date I can find for
Nick's commit is September 13th. So it was probably Nick who integrated
Jeff's changes into his commit 


Correct.

It's also quite normal for the maintainer to grab a patch off the list, 
integrate/massage/change it, and then apply it himself.


Jeff


-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: arcmsr changelog differs from diffs

[Hans-Peter Jansen]

Dear Björn,

Am Mittwoch, 17. Oktober 2007 02:53 schrieb Björn Steinbrink:
 On 2007.10.17 00:07:19 +0200, Hans-Peter Jansen wrote:
  Hi Jeff,
 
  while browsing through Linus' current check ins, I stumbled upon:
 
  [SCSI] arcmsr: irq handler fixes, cleanups, micro-opts:
 
  --8--
  488a5c8a9a3b67ae117784cd0d73bef53a73d57d
   drivers/scsi/arcmsr/arcmsr_hba.c |2 +-
   1 files changed, 1 insertions(+), 1 deletions(-)
 
  diff --git a/drivers/scsi/arcmsr/arcmsr_hba.c
  b/drivers/scsi/arcmsr/arcmsr_hba.c
  index 7832a10..f4d2d52 100644
  --- a/drivers/scsi/arcmsr/arcmsr_hba.c
  +++ b/drivers/scsi/arcmsr/arcmsr_hba.c
  @@ -422,7 +422,7 @@ static int arcmsr_probe(struct pci_dev *pdev,
  goto out_release_regions;
 
  error = request_irq(pdev-irq, arcmsr_do_interrupt,
  -   IRQF_SHARED, arcmsr, acb);
  +   IRQF_SHARED, arcmsr, acb);
  if (error)
  goto out_free_ccb_pool;
 
  --8--
 
  and: [SCSI] arcmsr: Fix hardware wait loops
 
  --8--
  24430458bb924e371ff894e26bfa9f73707f53fb
   drivers/scsi/arcmsr/arcmsr_hba.c |2 ++
   1 files changed, 2 insertions(+), 0 deletions(-)
 
  diff --git a/drivers/scsi/arcmsr/arcmsr_hba.c
  b/drivers/scsi/arcmsr/arcmsr_hba.c
  index 50e1310..7832a10 100644
  --- a/drivers/scsi/arcmsr/arcmsr_hba.c
  +++ b/drivers/scsi/arcmsr/arcmsr_hba.c
  @@ -2092,8 +2092,10 @@ static void arcmsr_iop_reset(struct
  AdapterControlBlock *acb)
  if (atomic_read(acb-ccboutstandingcount) != 0) {
  /* talk to iop 331 outstanding command aborted */
  arcmsr_abort_allcmd(acb);
  +
  /* wait for 3 sec for all command aborted*/
  ssleep(3);
  +
  /* disable all outbound interrupt */
  intmask_org = arcmsr_disable_outbound_ints(acb);
  /* clear all outbound posted Q */
  --8--
 
  where both changelogs differ significantly from the actual diffs, which
  both are simple WS fixups and nothing else. Does qgit fools me here, or
  is anything else wrong on my side?

 Nothing wrong on your side. I took a look at the second one, and
 everything but the whitespace changes already found its way into Linus'
 tree via 1a4f550a09f89e3a15eff1971bc9db977571b9f6. One hunk of the
 original patch[1] was actually made redundant because the code was
 removed in that commit, so that's probably what James fixed (see full
 commit message).

Yup, I found the patch you mentioned also, but that time orginating from 
Nick Cheng (*).

That diff is unfortunately way too big for me to be able to decide, if it's 
worth it to replace a former instance of arcmsr-1.20.0.13 for a 2.6.18.8 
kernel, which I use and essentially depend on here.

Thus I decided now to bluntly cc Nick and ask directly this way:
Nick, does 1.20.0.15 provide any essential changes over 1.20.0.13 for a 
ARC-1130 with FW 1.41 (2006-05-24), which advise updating?

 And then, if I may guess, James probably just noticed that there were
 changes left and commited them (while they were now down to just the
 whitespace change), without checking what changes were actually left (no
 offense intended). At least I think that git wouldn't cripple the diff
 if the changes that James checked in were not already whitespace-only at
 the time he commited them, and the git history of his tree seems to
 agree.

(*) Thanks for the clarification, Björn. What made me stumbling was the 
different orginators, while Jeff isn't known with catching attention by 
assimilating other peoples contributions. 

 Probably the other commit is similar.

 Björn

 [1] http://linux.derkeiler.com/Mailing-Lists/Kernel/2007-07/msg11957.html

Pete
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: arcmsr changelog differs from diffs

[Björn Steinbrink]

Hi Hans,

On 2007.10.17 12:41:11 +0200, Hans-Peter Jansen wrote:
 Dear Björn,
 
 Am Mittwoch, 17. Oktober 2007 02:53 schrieb Björn Steinbrink:
  And then, if I may guess, James probably just noticed that there were
  changes left and commited them (while they were now down to just the
  whitespace change), without checking what changes were actually left (no
  offense intended). At least I think that git wouldn't cripple the diff
  if the changes that James checked in were not already whitespace-only at
  the time he commited them, and the git history of his tree seems to
  agree.
 
 (*) Thanks for the clarification, Björn. What made me stumbling was the 
 different orginators, while Jeff isn't known with catching attention by 
 assimilating other peoples contributions. 

I'm just guessing here, and certainly don't want to blame anyone, but
Jeff's original patch was from July, while the only date I can find for
Nick's commit is September 13th. So it was probably Nick who integrated
Jeff's changes into his commit (maybe thinking that Jeff's patch got
lost), not Jeff assimilating a subset of Nick's changes.

Björn
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 1/6] forcedeth: internal simplifications; changelog removal

[Jeff Garzik]

commit 0aeb1f867bc76029f599f73ac757a50f7641ccc5
Author: Jeff Garzik <[EMAIL PROTECTED]>
Date:   Tue Oct 16 01:40:30 2007 -0400

[netdrvr] forcedeth: internal simplifications; changelog removal

* remove changelog from source; its kept in git repository

* consolidate descriptor version tests using nv_optimized()

* consolidate NIC DMA start, stop and drain into
  nv_start_txrx(), nv_stop_txrx(), nv_drain_txrx()

Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]>

 drivers/net/forcedeth.c |  234 +++-
 1 file changed, 74 insertions(+), 160 deletions(-)

0aeb1f867bc76029f599f73ac757a50f7641ccc5
diff --git a/drivers/net/forcedeth.c b/drivers/net/forcedeth.c
index cfbb7aa..2d518fc 100644
--- a/drivers/net/forcedeth.c
+++ b/drivers/net/forcedeth.c
@@ -29,90 +29,6 @@
  * along with this program; if not, write to the Free Software
  * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
  *
- * Changelog:
- * 0.01: 05 Oct 2003: First release that compiles without warnings.
- * 0.02: 05 Oct 2003: Fix bug for nv_drain_tx: do not try to free NULL 
skbs.
- *Check all PCI BARs for the register window.
- *udelay added to mii_rw.
- * 0.03: 06 Oct 2003: Initialize dev->irq.
- * 0.04: 07 Oct 2003: Initialize np->lock, reduce handled irqs, add 
printks.
- * 0.05: 09 Oct 2003: printk removed again, irq status print tx_timeout.
- * 0.06: 10 Oct 2003: MAC Address read updated, pff flag generation 
updated,
- *irq mask updated
- * 0.07: 14 Oct 2003: Further irq mask updates.
- * 0.08: 20 Oct 2003: rx_desc.Length initialization added, nv_alloc_rx 
refill
- *added into irq handler, NULL check for drain_ring.
- * 0.09: 20 Oct 2003: Basic link speed irq implementation. Only handle the
- *requested interrupt sources.
- * 0.10: 20 Oct 2003: First cleanup for release.
- * 0.11: 21 Oct 2003: hexdump for tx added, rx buffer sizes increased.
- *MAC Address init fix, set_multicast cleanup.
- * 0.12: 23 Oct 2003: Cleanups for release.
- * 0.13: 25 Oct 2003: Limit for concurrent tx packets increased to 10.
- *Set link speed correctly. start rx before starting
- *tx (nv_start_rx sets the link speed).
- * 0.14: 25 Oct 2003: Nic dependant irq mask.
- * 0.15: 08 Nov 2003: fix smp deadlock with set_multicast_list during
- *open.
- * 0.16: 15 Nov 2003: include file cleanup for ppc64, rx buffer size
- *increased to 1628 bytes.
- * 0.17: 16 Nov 2003: undo rx buffer size increase. Substract 1 from
- *the tx length.
- * 0.18: 17 Nov 2003: fix oops due to late initialization of dev_stats
- * 0.19: 29 Nov 2003: Handle RxNoBuf, detect & handle invalid mac
- *addresses, really stop rx if already running
- *in nv_start_rx, clean up a bit.
- * 0.20: 07 Dec 2003: alloc fixes
- * 0.21: 12 Jan 2004: additional alloc fix, nic polling fix.
- * 0.22: 19 Jan 2004: reprogram timer to a sane rate, avoid lockup
- *on close.
- * 0.23: 26 Jan 2004: various small cleanups
- * 0.24: 27 Feb 2004: make driver even less anonymous in backtraces
- * 0.25: 09 Mar 2004: wol support
- * 0.26: 03 Jun 2004: netdriver specific annotation, sparse-related fixes
- * 0.27: 19 Jun 2004: Gigabit support, new descriptor rings,
- *added CK804/MCP04 device IDs, code fixes
- *for registers, link status and other minor fixes.
- * 0.28: 21 Jun 2004: Big cleanup, making driver mostly endian safe
- * 0.29: 31 Aug 2004: Add backup timer for link change notification.
- * 0.30: 25 Sep 2004: rx checksum support for nf 250 Gb. Add rx reset
- *into nv_close, otherwise reenabling for wol can
- *cause DMA to kfree'd memory.
- * 0.31: 14 Nov 2004: ethtool support for getting/setting link
- *capabilities.
- * 0.32: 16 Apr 2005: RX_ERROR4 handling added.
- * 0.33: 16 May 2005: Support for MCP51 added.
- * 0.34: 18 Jun 2005: Add DEV_NEED_LINKTIMER to all nForce nics.
- * 0.35: 26 Jun 2005: Support for MCP55 added.
- * 0.36: 28 Jun 2005: Add jumbo frame support.
- * 0.37: 10 Jul 2005: Additional ethtool support, cleanup of pci id list
- * 0.38: 16 Jul 2005: tx irq rewrite: Use global flags instead of
- *per-packet flags.
- * 0.39: 18 Jul 2005: Add 64bit descriptor support.
- * 0.40: 19 Jul 2005: Add support for mac address change.
- * 0.41: 30 Jul 2005: Write back original MAC in nv_close instead
- *of nv_remove
- * 0.42:

Re: arcmsr changelog differs from diffs

[Björn Steinbrink]

On 2007.10.17 00:07:19 +0200, Hans-Peter Jansen wrote:
> Hi Jeff,
> 
> while browsing through Linus' current check ins, I stumbled upon:
> 
> [SCSI] arcmsr: irq handler fixes, cleanups, micro-opts:
> 
> --8<--
> 488a5c8a9a3b67ae117784cd0d73bef53a73d57d
>  drivers/scsi/arcmsr/arcmsr_hba.c |2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/scsi/arcmsr/arcmsr_hba.c 
> b/drivers/scsi/arcmsr/arcmsr_hba.c
> index 7832a10..f4d2d52 100644
> --- a/drivers/scsi/arcmsr/arcmsr_hba.c
> +++ b/drivers/scsi/arcmsr/arcmsr_hba.c
> @@ -422,7 +422,7 @@ static int arcmsr_probe(struct pci_dev *pdev,
>   goto out_release_regions;
>  
>   error = request_irq(pdev->irq, arcmsr_do_interrupt,
> - IRQF_SHARED, "arcmsr", acb);
> + IRQF_SHARED, "arcmsr", acb);
>   if (error)
>   goto out_free_ccb_pool;
>  
> -->8--
> 
> and: [SCSI] arcmsr: Fix hardware wait loops
> 
> --8<--
> 24430458bb924e371ff894e26bfa9f73707f53fb
>  drivers/scsi/arcmsr/arcmsr_hba.c |2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/scsi/arcmsr/arcmsr_hba.c 
> b/drivers/scsi/arcmsr/arcmsr_hba.c
> index 50e1310..7832a10 100644
> --- a/drivers/scsi/arcmsr/arcmsr_hba.c
> +++ b/drivers/scsi/arcmsr/arcmsr_hba.c
> @@ -2092,8 +2092,10 @@ static void arcmsr_iop_reset(struct 
> AdapterControlBlock *acb)
>   if (atomic_read(>ccboutstandingcount) != 0) {
>   /* talk to iop 331 outstanding command aborted */
>   arcmsr_abort_allcmd(acb);
> +
>   /* wait for 3 sec for all command aborted*/
>   ssleep(3);
> +
>   /* disable all outbound interrupt */
>   intmask_org = arcmsr_disable_outbound_ints(acb);
>   /* clear all outbound posted Q */
> -->8--
> 
> where both changelogs differ significantly from the actual diffs, which both 
> are simple WS fixups and nothing else. Does qgit fools me here, or is 
> anything else wrong on my side?

Nothing wrong on your side. I took a look at the second one, and
everything but the whitespace changes already found its way into Linus'
tree via 1a4f550a09f89e3a15eff1971bc9db977571b9f6. One hunk of the
original patch[1] was actually made redundant because the code was
removed in that commit, so that's probably what James fixed (see full
commit message).

And then, if I may guess, James probably just noticed that there were
changes left and commited them (while they were now down to just the
whitespace change), without checking what changes were actually left (no
offense intended). At least I think that git wouldn't cripple the diff
if the changes that James checked in were not already whitespace-only at
the time he commited them, and the git history of his tree seems to
agree.

Probably the other commit is similar.

Björn

[1] http://linux.derkeiler.com/Mailing-Lists/Kernel/2007-07/msg11957.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

arcmsr changelog differs from diffs

[Hans-Peter Jansen]

Hi Jeff,

while browsing through Linus' current check ins, I stumbled upon:

[SCSI] arcmsr: irq handler fixes, cleanups, micro-opts:

--8<--
488a5c8a9a3b67ae117784cd0d73bef53a73d57d
 drivers/scsi/arcmsr/arcmsr_hba.c |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/scsi/arcmsr/arcmsr_hba.c 
b/drivers/scsi/arcmsr/arcmsr_hba.c
index 7832a10..f4d2d52 100644
--- a/drivers/scsi/arcmsr/arcmsr_hba.c
+++ b/drivers/scsi/arcmsr/arcmsr_hba.c
@@ -422,7 +422,7 @@ static int arcmsr_probe(struct pci_dev *pdev,
goto out_release_regions;
 
error = request_irq(pdev->irq, arcmsr_do_interrupt,
-   IRQF_SHARED, "arcmsr", acb);
+   IRQF_SHARED, "arcmsr", acb);
if (error)
goto out_free_ccb_pool;
 
-->8--

and: [SCSI] arcmsr: Fix hardware wait loops

--8<--
24430458bb924e371ff894e26bfa9f73707f53fb
 drivers/scsi/arcmsr/arcmsr_hba.c |2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/scsi/arcmsr/arcmsr_hba.c 
b/drivers/scsi/arcmsr/arcmsr_hba.c
index 50e1310..7832a10 100644
--- a/drivers/scsi/arcmsr/arcmsr_hba.c
+++ b/drivers/scsi/arcmsr/arcmsr_hba.c
@@ -2092,8 +2092,10 @@ static void arcmsr_iop_reset(struct 
AdapterControlBlock *acb)
if (atomic_read(>ccboutstandingcount) != 0) {
/* talk to iop 331 outstanding command aborted */
arcmsr_abort_allcmd(acb);
+
/* wait for 3 sec for all command aborted*/
ssleep(3);
+
/* disable all outbound interrupt */
intmask_org = arcmsr_disable_outbound_ints(acb);
/* clear all outbound posted Q */
-->8--

where both changelogs differ significantly from the actual diffs, which both 
are simple WS fixups and nothing else. Does qgit fools me here, or is 
anything else wrong on my side?

Pete
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

arcmsr changelog differs from diffs

[Hans-Peter Jansen]

Hi Jeff,

while browsing through Linus' current check ins, I stumbled upon:

[SCSI] arcmsr: irq handler fixes, cleanups, micro-opts:

--8--
488a5c8a9a3b67ae117784cd0d73bef53a73d57d
 drivers/scsi/arcmsr/arcmsr_hba.c |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/scsi/arcmsr/arcmsr_hba.c 
b/drivers/scsi/arcmsr/arcmsr_hba.c
index 7832a10..f4d2d52 100644
--- a/drivers/scsi/arcmsr/arcmsr_hba.c
+++ b/drivers/scsi/arcmsr/arcmsr_hba.c
@@ -422,7 +422,7 @@ static int arcmsr_probe(struct pci_dev *pdev,
goto out_release_regions;
 
error = request_irq(pdev-irq, arcmsr_do_interrupt,
-   IRQF_SHARED, arcmsr, acb);
+   IRQF_SHARED, arcmsr, acb);
if (error)
goto out_free_ccb_pool;
 
--8--

and: [SCSI] arcmsr: Fix hardware wait loops

--8--
24430458bb924e371ff894e26bfa9f73707f53fb
 drivers/scsi/arcmsr/arcmsr_hba.c |2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/scsi/arcmsr/arcmsr_hba.c 
b/drivers/scsi/arcmsr/arcmsr_hba.c
index 50e1310..7832a10 100644
--- a/drivers/scsi/arcmsr/arcmsr_hba.c
+++ b/drivers/scsi/arcmsr/arcmsr_hba.c
@@ -2092,8 +2092,10 @@ static void arcmsr_iop_reset(struct 
AdapterControlBlock *acb)
if (atomic_read(acb-ccboutstandingcount) != 0) {
/* talk to iop 331 outstanding command aborted */
arcmsr_abort_allcmd(acb);
+
/* wait for 3 sec for all command aborted*/
ssleep(3);
+
/* disable all outbound interrupt */
intmask_org = arcmsr_disable_outbound_ints(acb);
/* clear all outbound posted Q */
--8--

where both changelogs differ significantly from the actual diffs, which both 
are simple WS fixups and nothing else. Does qgit fools me here, or is 
anything else wrong on my side?

Pete
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: arcmsr changelog differs from diffs

[Björn Steinbrink]

On 2007.10.17 00:07:19 +0200, Hans-Peter Jansen wrote:
 Hi Jeff,
 
 while browsing through Linus' current check ins, I stumbled upon:
 
 [SCSI] arcmsr: irq handler fixes, cleanups, micro-opts:
 
 --8--
 488a5c8a9a3b67ae117784cd0d73bef53a73d57d
  drivers/scsi/arcmsr/arcmsr_hba.c |2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)
 
 diff --git a/drivers/scsi/arcmsr/arcmsr_hba.c 
 b/drivers/scsi/arcmsr/arcmsr_hba.c
 index 7832a10..f4d2d52 100644
 --- a/drivers/scsi/arcmsr/arcmsr_hba.c
 +++ b/drivers/scsi/arcmsr/arcmsr_hba.c
 @@ -422,7 +422,7 @@ static int arcmsr_probe(struct pci_dev *pdev,
   goto out_release_regions;
  
   error = request_irq(pdev-irq, arcmsr_do_interrupt,
 - IRQF_SHARED, arcmsr, acb);
 + IRQF_SHARED, arcmsr, acb);
   if (error)
   goto out_free_ccb_pool;
  
 --8--
 
 and: [SCSI] arcmsr: Fix hardware wait loops
 
 --8--
 24430458bb924e371ff894e26bfa9f73707f53fb
  drivers/scsi/arcmsr/arcmsr_hba.c |2 ++
  1 files changed, 2 insertions(+), 0 deletions(-)
 
 diff --git a/drivers/scsi/arcmsr/arcmsr_hba.c 
 b/drivers/scsi/arcmsr/arcmsr_hba.c
 index 50e1310..7832a10 100644
 --- a/drivers/scsi/arcmsr/arcmsr_hba.c
 +++ b/drivers/scsi/arcmsr/arcmsr_hba.c
 @@ -2092,8 +2092,10 @@ static void arcmsr_iop_reset(struct 
 AdapterControlBlock *acb)
   if (atomic_read(acb-ccboutstandingcount) != 0) {
   /* talk to iop 331 outstanding command aborted */
   arcmsr_abort_allcmd(acb);
 +
   /* wait for 3 sec for all command aborted*/
   ssleep(3);
 +
   /* disable all outbound interrupt */
   intmask_org = arcmsr_disable_outbound_ints(acb);
   /* clear all outbound posted Q */
 --8--
 
 where both changelogs differ significantly from the actual diffs, which both 
 are simple WS fixups and nothing else. Does qgit fools me here, or is 
 anything else wrong on my side?

Nothing wrong on your side. I took a look at the second one, and
everything but the whitespace changes already found its way into Linus'
tree via 1a4f550a09f89e3a15eff1971bc9db977571b9f6. One hunk of the
original patch[1] was actually made redundant because the code was
removed in that commit, so that's probably what James fixed (see full
commit message).

And then, if I may guess, James probably just noticed that there were
changes left and commited them (while they were now down to just the
whitespace change), without checking what changes were actually left (no
offense intended). At least I think that git wouldn't cripple the diff
if the changes that James checked in were not already whitespace-only at
the time he commited them, and the git history of his tree seems to
agree.

Probably the other commit is similar.

Björn

[1] http://linux.derkeiler.com/Mailing-Lists/Kernel/2007-07/msg11957.html
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 1/6] forcedeth: internal simplifications; changelog removal

[Jeff Garzik]

commit 0aeb1f867bc76029f599f73ac757a50f7641ccc5
Author: Jeff Garzik [EMAIL PROTECTED]
Date:   Tue Oct 16 01:40:30 2007 -0400

[netdrvr] forcedeth: internal simplifications; changelog removal

* remove changelog from source; its kept in git repository

* consolidate descriptor version tests using nv_optimized()

* consolidate NIC DMA start, stop and drain into
  nv_start_txrx(), nv_stop_txrx(), nv_drain_txrx()

Signed-off-by: Jeff Garzik [EMAIL PROTECTED]

 drivers/net/forcedeth.c |  234 +++-
 1 file changed, 74 insertions(+), 160 deletions(-)

0aeb1f867bc76029f599f73ac757a50f7641ccc5
diff --git a/drivers/net/forcedeth.c b/drivers/net/forcedeth.c
index cfbb7aa..2d518fc 100644
--- a/drivers/net/forcedeth.c
+++ b/drivers/net/forcedeth.c
@@ -29,90 +29,6 @@
  * along with this program; if not, write to the Free Software
  * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
  *
- * Changelog:
- * 0.01: 05 Oct 2003: First release that compiles without warnings.
- * 0.02: 05 Oct 2003: Fix bug for nv_drain_tx: do not try to free NULL 
skbs.
- *Check all PCI BARs for the register window.
- *udelay added to mii_rw.
- * 0.03: 06 Oct 2003: Initialize dev-irq.
- * 0.04: 07 Oct 2003: Initialize np-lock, reduce handled irqs, add 
printks.
- * 0.05: 09 Oct 2003: printk removed again, irq status print tx_timeout.
- * 0.06: 10 Oct 2003: MAC Address read updated, pff flag generation 
updated,
- *irq mask updated
- * 0.07: 14 Oct 2003: Further irq mask updates.
- * 0.08: 20 Oct 2003: rx_desc.Length initialization added, nv_alloc_rx 
refill
- *added into irq handler, NULL check for drain_ring.
- * 0.09: 20 Oct 2003: Basic link speed irq implementation. Only handle the
- *requested interrupt sources.
- * 0.10: 20 Oct 2003: First cleanup for release.
- * 0.11: 21 Oct 2003: hexdump for tx added, rx buffer sizes increased.
- *MAC Address init fix, set_multicast cleanup.
- * 0.12: 23 Oct 2003: Cleanups for release.
- * 0.13: 25 Oct 2003: Limit for concurrent tx packets increased to 10.
- *Set link speed correctly. start rx before starting
- *tx (nv_start_rx sets the link speed).
- * 0.14: 25 Oct 2003: Nic dependant irq mask.
- * 0.15: 08 Nov 2003: fix smp deadlock with set_multicast_list during
- *open.
- * 0.16: 15 Nov 2003: include file cleanup for ppc64, rx buffer size
- *increased to 1628 bytes.
- * 0.17: 16 Nov 2003: undo rx buffer size increase. Substract 1 from
- *the tx length.
- * 0.18: 17 Nov 2003: fix oops due to late initialization of dev_stats
- * 0.19: 29 Nov 2003: Handle RxNoBuf, detect  handle invalid mac
- *addresses, really stop rx if already running
- *in nv_start_rx, clean up a bit.
- * 0.20: 07 Dec 2003: alloc fixes
- * 0.21: 12 Jan 2004: additional alloc fix, nic polling fix.
- * 0.22: 19 Jan 2004: reprogram timer to a sane rate, avoid lockup
- *on close.
- * 0.23: 26 Jan 2004: various small cleanups
- * 0.24: 27 Feb 2004: make driver even less anonymous in backtraces
- * 0.25: 09 Mar 2004: wol support
- * 0.26: 03 Jun 2004: netdriver specific annotation, sparse-related fixes
- * 0.27: 19 Jun 2004: Gigabit support, new descriptor rings,
- *added CK804/MCP04 device IDs, code fixes
- *for registers, link status and other minor fixes.
- * 0.28: 21 Jun 2004: Big cleanup, making driver mostly endian safe
- * 0.29: 31 Aug 2004: Add backup timer for link change notification.
- * 0.30: 25 Sep 2004: rx checksum support for nf 250 Gb. Add rx reset
- *into nv_close, otherwise reenabling for wol can
- *cause DMA to kfree'd memory.
- * 0.31: 14 Nov 2004: ethtool support for getting/setting link
- *capabilities.
- * 0.32: 16 Apr 2005: RX_ERROR4 handling added.
- * 0.33: 16 May 2005: Support for MCP51 added.
- * 0.34: 18 Jun 2005: Add DEV_NEED_LINKTIMER to all nForce nics.
- * 0.35: 26 Jun 2005: Support for MCP55 added.
- * 0.36: 28 Jun 2005: Add jumbo frame support.
- * 0.37: 10 Jul 2005: Additional ethtool support, cleanup of pci id list
- * 0.38: 16 Jul 2005: tx irq rewrite: Use global flags instead of
- *per-packet flags.
- * 0.39: 18 Jul 2005: Add 64bit descriptor support.
- * 0.40: 19 Jul 2005: Add support for mac address change.
- * 0.41: 30 Jul 2005: Write back original MAC in nv_close instead
- *of nv_remove
- * 0.42: 06 Aug 2005: Fix lack of link

[PATCH 8/8] scsi: megaraid_sas - Update version and changelog

[bo yang]

Update version and changelog. 
Updated "LSI Logic" to new name "LSI"

Signed-off-by: Bo Yang <[EMAIL PROTECTED]>

---
 Documentation/scsi/ChangeLog.megaraid_sas |  160 
 drivers/scsi/megaraid/megaraid_sas.c  |   10 -
 drivers/scsi/megaraid/megaraid_sas.h  |8 -
 3 files changed, 169 insertions(+), 9 deletions(-)

diff -uprN linux-2.6.22_orig/Documentation/scsi/ChangeLog.megaraid_sas 
linux-2.6.22_new/Documentation/scsi/ChangeLog.megaraid_sas
--- linux-2.6.22_orig/Documentation/scsi/ChangeLog.megaraid_sas 2007-10-01 
00:03:59.0 -0700
+++ linux-2.6.22_new/Documentation/scsi/ChangeLog.megaraid_sas  2007-10-01 
00:03:59.0 -0700
@@ -1,3 +1,163 @@
+1 Release Date: Thur. Sep. 27 10:09:32 PDT 2007 -
+   (emaild-id:[EMAIL PROTECTED])
+   Sumant Patro
+   Bo Yang 
+
+2 Current Version : 00.00.03.16-rc1
+3 Older Version   : 00.00.03.15
+
+1. Increased MFI_POLL_TIMEOUT_SECS to 60 seconds from 10. FW may take a max of 
60 seconds to 
+   respond to the INIT cmd.
+
+1 Release Date: Fri. Sep. 07 16:30:43 PST 2007 -
+   (emaild-id:[EMAIL PROTECTED])
+   Sumant Patro
+   Bo Yang 
+
+2 Current Version : 00.00.03.15
+3 Older Version   : 00.00.03.14
+
+1. Added module parameter "poll_mode_io" to support for "polling" (reduced 
interrupt operation).
+   In this mode, IO completion interrupts are delayed. At the end of 
initiating IOs,
+   the driver schedules for cmd completion if there are pending cmds to be 
completed.
+   A timer-based interrupt has also been added to prevent IO completion 
processing from
+   being delayed indefinitely in the case that no new IOs are initiated.
+
+1 Release Date: Fri. Sep. 07 16:30:43 PST 2007 -
+   (emaild-id:[EMAIL PROTECTED])
+   Sumant Patro
+   Bo Yang 
+
+2 Current Version : 00.00.03.14
+3 Older Version   : 00.00.03.13
+
+1. Setting the max_sectors_per_req based on max SGL supported by the FW. Prior 
versions calculated 
+   this value from controller info (max_sectors_1, max_sectors_2). For 
certain controllers/FW,
+   this was resulting in a value greater than max SGL supported by the FW. 
Issue was first
+   reported by users running LUKS+XFS with megaraid_sas.
+   Thanks to RB for providing the logs and duplication steps that helped 
to get to the root 
+   cause of the issue.
+2. Increased MFI_POLL_TIMEOUT_SECS to 60 seconds from 10. FW may take a max of 
60 seconds to 
+   respond to the INIT cmd.
+
+1 Release Date: Fri. June. 15 16:30:43 PST 2007 -
+   (emaild-id:[EMAIL PROTECTED])
+   Sumant Patro
+   Bo Yang 
+
+2 Current Version : 00.00.03.13
+3 Older Version   : 00.00.03.12
+
+1. Added the megasas_reset_timer routine to intercept cmd timeout and throttle 
io.
+
+On Fri, 2007-03-16 at 16:44 -0600, James Bottomley wrote:
+It looks like megaraid_sas at least needs this to throttle its commands
+> as they begin to time out.  The code keeps the existing transport
+> template use of eh_timed_out (and allows the transport to override the
+> host if they both have this callback).
+> 
+> James
+
+1 Release Date: Sat May. 12 16:30:43 PST 2007 -
+   (emaild-id:[EMAIL PROTECTED])
+   Sumant Patro
+   Bo Yang 
+
+2 Current Version : 00.00.03.12
+3 Older Version   : 00.00.03.11
+
+1.  When MegaSAS driver receives reset call from OS, driver waits in reset
+routine for max 3 minutes for all pending command completion. Now driver will
+call completion routine every 5 seconds from the reset routine instead of
+waiting for depending on cmd completion from isr path.
+
+1 Release Date: Mon Apr. 30 10:25:52 PST 2007 -
+   (emaild-id:[EMAIL PROTECTED])
+   Sumant Patro
+   Bo Yang 
+
+2 Current Version : 00.00.03.11
+3 Older Version   : 00.00.03.09
+
+   1. Following module parameters added -
+   fast_load: Faster loading of the driver, skips physical devices 
scanning thereby
+   reducing the time to load driver.
+   cmd_per_lun: Maximum number of commands per logical unit
+   max_sectors: Maximum number of sectors per IO command
+   2. Memory Manager for IOCTL removed for 2.6 kernels.
+  pci_alloc_consistent replaced by dma_alloc_coherent. With this 
+  change there is no need of memory manager in the driver code
+
+   On Wed, 2007-02-07 at 13:30 -0800, Andrew Morton wrote:
+   > I suspect all this horror is due to stupidity in the DMA API.
+   >
+   > pci_alloc_consistent() just goes and assumes GFP_ATOMIC, whereas
+   > the caller (megasas_m

[PATCH 8/8] scsi: megaraid_sas - Update version and changelog

[bo yang]

Update version and changelog. 
Updated LSI Logic to new name LSI

Signed-off-by: Bo Yang [EMAIL PROTECTED]

---
 Documentation/scsi/ChangeLog.megaraid_sas |  160 
 drivers/scsi/megaraid/megaraid_sas.c  |   10 -
 drivers/scsi/megaraid/megaraid_sas.h  |8 -
 3 files changed, 169 insertions(+), 9 deletions(-)

diff -uprN linux-2.6.22_orig/Documentation/scsi/ChangeLog.megaraid_sas 
linux-2.6.22_new/Documentation/scsi/ChangeLog.megaraid_sas
--- linux-2.6.22_orig/Documentation/scsi/ChangeLog.megaraid_sas 2007-10-01 
00:03:59.0 -0700
+++ linux-2.6.22_new/Documentation/scsi/ChangeLog.megaraid_sas  2007-10-01 
00:03:59.0 -0700
@@ -1,3 +1,163 @@
+1 Release Date: Thur. Sep. 27 10:09:32 PDT 2007 -
+   (emaild-id:[EMAIL PROTECTED])
+   Sumant Patro
+   Bo Yang 
+
+2 Current Version : 00.00.03.16-rc1
+3 Older Version   : 00.00.03.15
+
+1. Increased MFI_POLL_TIMEOUT_SECS to 60 seconds from 10. FW may take a max of 
60 seconds to 
+   respond to the INIT cmd.
+
+1 Release Date: Fri. Sep. 07 16:30:43 PST 2007 -
+   (emaild-id:[EMAIL PROTECTED])
+   Sumant Patro
+   Bo Yang 
+
+2 Current Version : 00.00.03.15
+3 Older Version   : 00.00.03.14
+
+1. Added module parameter poll_mode_io to support for polling (reduced 
interrupt operation).
+   In this mode, IO completion interrupts are delayed. At the end of 
initiating IOs,
+   the driver schedules for cmd completion if there are pending cmds to be 
completed.
+   A timer-based interrupt has also been added to prevent IO completion 
processing from
+   being delayed indefinitely in the case that no new IOs are initiated.
+
+1 Release Date: Fri. Sep. 07 16:30:43 PST 2007 -
+   (emaild-id:[EMAIL PROTECTED])
+   Sumant Patro
+   Bo Yang 
+
+2 Current Version : 00.00.03.14
+3 Older Version   : 00.00.03.13
+
+1. Setting the max_sectors_per_req based on max SGL supported by the FW. Prior 
versions calculated 
+   this value from controller info (max_sectors_1, max_sectors_2). For 
certain controllers/FW,
+   this was resulting in a value greater than max SGL supported by the FW. 
Issue was first
+   reported by users running LUKS+XFS with megaraid_sas.
+   Thanks to RB for providing the logs and duplication steps that helped 
to get to the root 
+   cause of the issue.
+2. Increased MFI_POLL_TIMEOUT_SECS to 60 seconds from 10. FW may take a max of 
60 seconds to 
+   respond to the INIT cmd.
+
+1 Release Date: Fri. June. 15 16:30:43 PST 2007 -
+   (emaild-id:[EMAIL PROTECTED])
+   Sumant Patro
+   Bo Yang 
+
+2 Current Version : 00.00.03.13
+3 Older Version   : 00.00.03.12
+
+1. Added the megasas_reset_timer routine to intercept cmd timeout and throttle 
io.
+
+On Fri, 2007-03-16 at 16:44 -0600, James Bottomley wrote:
+It looks like megaraid_sas at least needs this to throttle its commands
+ as they begin to time out.  The code keeps the existing transport
+ template use of eh_timed_out (and allows the transport to override the
+ host if they both have this callback).
+ 
+ James
+
+1 Release Date: Sat May. 12 16:30:43 PST 2007 -
+   (emaild-id:[EMAIL PROTECTED])
+   Sumant Patro
+   Bo Yang 
+
+2 Current Version : 00.00.03.12
+3 Older Version   : 00.00.03.11
+
+1.  When MegaSAS driver receives reset call from OS, driver waits in reset
+routine for max 3 minutes for all pending command completion. Now driver will
+call completion routine every 5 seconds from the reset routine instead of
+waiting for depending on cmd completion from isr path.
+
+1 Release Date: Mon Apr. 30 10:25:52 PST 2007 -
+   (emaild-id:[EMAIL PROTECTED])
+   Sumant Patro
+   Bo Yang 
+
+2 Current Version : 00.00.03.11
+3 Older Version   : 00.00.03.09
+
+   1. Following module parameters added -
+   fast_load: Faster loading of the driver, skips physical devices 
scanning thereby
+   reducing the time to load driver.
+   cmd_per_lun: Maximum number of commands per logical unit
+   max_sectors: Maximum number of sectors per IO command
+   2. Memory Manager for IOCTL removed for 2.6 kernels.
+  pci_alloc_consistent replaced by dma_alloc_coherent. With this 
+  change there is no need of memory manager in the driver code
+
+   On Wed, 2007-02-07 at 13:30 -0800, Andrew Morton wrote:
+I suspect all this horror is due to stupidity in the DMA API.
+   
+pci_alloc_consistent() just goes and assumes GFP_ATOMIC, whereas
+the caller (megasas_mgmt_fw_ioctl) would have been perfectly happy
+to use GFP_KERNEL.
+   
+I bet

[PATCH 8/8] scsi: megaraid_sas - Update version and changelog

[bo yang]

Update version and changelog

Signed-off-by: Bo Yang <[EMAIL PROTECTED]>

---
 Documentation/scsi/ChangeLog.megaraid_sas |  160 
 drivers/scsi/megaraid/megaraid_sas.c  |2
 drivers/scsi/megaraid/megaraid_sas.h  |7
 3 files changed, 165 insertions(+), 4 deletions(-)

diff -uprN linux-2.6.22_orig/Documentation/scsi/ChangeLog.megaraid_sas 
linux-2.6.22_new/Documentation/scsi/ChangeLog.megaraid_sas
--- linux-2.6.22_orig/Documentation/scsi/ChangeLog.megaraid_sas 2007-09-26 
15:58:40.0 -0700
+++ linux-2.6.22_new/Documentation/scsi/ChangeLog.megaraid_sas  2007-09-27 
06:19:46.0 -0700
@@ -1,3 +1,163 @@
+1 Release Date: Thur. Sep. 27 10:09:32 PDT 2007 -
+   (emaild-id:[EMAIL PROTECTED])
+   Sumant Patro
+   Bo Yang 
+
+2 Current Version : 00.00.03.16-rc1
+3 Older Version   : 00.00.03.15
+
+1. Increased MFI_POLL_TIMEOUT_SECS to 60 seconds from 10. FW may take a max of 
60 seconds to 
+   respond to the INIT cmd.
+
+1 Release Date: Fri. Sep. 07 16:30:43 PST 2007 -
+   (emaild-id:[EMAIL PROTECTED])
+   Sumant Patro
+   Bo Yang 
+
+2 Current Version : 00.00.03.15
+3 Older Version   : 00.00.03.14
+
+1. Added module parameter "poll_mode_io" to support for "polling" (reduced 
interrupt operation).
+   In this mode, IO completion interrupts are delayed. At the end of 
initiating IOs,
+   the driver schedules for cmd completion if there are pending cmds to be 
completed.
+   A timer-based interrupt has also been added to prevent IO completion 
processing from
+   being delayed indefinitely in the case that no new IOs are initiated.
+
+1 Release Date: Fri. Sep. 07 16:30:43 PST 2007 -
+   (emaild-id:[EMAIL PROTECTED])
+   Sumant Patro
+   Bo Yang 
+
+2 Current Version : 00.00.03.14
+3 Older Version   : 00.00.03.13
+
+1. Setting the max_sectors_per_req based on max SGL supported by the FW. Prior 
versions calculated 
+   this value from controller info (max_sectors_1, max_sectors_2). For 
certain controllers/FW,
+   this was resulting in a value greater than max SGL supported by the FW. 
Issue was first
+   reported by users running LUKS+XFS with megaraid_sas.
+   Thanks to RB for providing the logs and duplication steps that helped 
to get to the root 
+   cause of the issue.
+2. Increased MFI_POLL_TIMEOUT_SECS to 60 seconds from 10. FW may take a max of 
60 seconds to 
+   respond to the INIT cmd.
+
+1 Release Date: Fri. June. 15 16:30:43 PST 2007 -
+   (emaild-id:[EMAIL PROTECTED])
+   Sumant Patro
+   Bo Yang 
+
+2 Current Version : 00.00.03.13
+3 Older Version   : 00.00.03.12
+
+1. Added the megasas_reset_timer routine to intercept cmd timeout and throttle 
io.
+
+On Fri, 2007-03-16 at 16:44 -0600, James Bottomley wrote:
+It looks like megaraid_sas at least needs this to throttle its commands
+> as they begin to time out.  The code keeps the existing transport
+> template use of eh_timed_out (and allows the transport to override the
+> host if they both have this callback).
+> 
+> James
+
+1 Release Date: Sat May. 12 16:30:43 PST 2007 -
+   (emaild-id:[EMAIL PROTECTED])
+   Sumant Patro
+   Bo Yang 
+
+2 Current Version : 00.00.03.12
+3 Older Version   : 00.00.03.11
+
+1.  When MegaSAS driver receives reset call from OS, driver waits in reset
+routine for max 3 minutes for all pending command completion. Now driver will
+call completion routine every 5 seconds from the reset routine instead of
+waiting for depending on cmd completion from isr path.
+
+1 Release Date: Mon Apr. 30 10:25:52 PST 2007 -
+   (emaild-id:[EMAIL PROTECTED])
+   Sumant Patro
+   Bo Yang 
+
+2 Current Version : 00.00.03.11
+3 Older Version   : 00.00.03.09
+
+   1. Following module parameters added -
+   fast_load: Faster loading of the driver, skips physical devices 
scanning thereby
+   reducing the time to load driver.
+   cmd_per_lun: Maximum number of commands per logical unit
+   max_sectors: Maximum number of sectors per IO command
+   2. Memory Manager for IOCTL removed for 2.6 kernels.
+  pci_alloc_consistent replaced by dma_alloc_coherent. With this 
+  change there is no need of memory manager in the driver code
+
+   On Wed, 2007-02-07 at 13:30 -0800, Andrew Morton wrote:
+   > I suspect all this horror is due to stupidity in the DMA API.
+   >
+   > pci_alloc_consistent() just goes and assumes GFP_ATOMIC, whereas
+   > the caller (megasas_mgmt_fw_ioctl) would have been perfectly happy
+   >

[PATCH 8/8] scsi: megaraid_sas - Update version and changelog

[bo yang]

Update version and changelog

Signed-off-by: Bo Yang [EMAIL PROTECTED]

---
 Documentation/scsi/ChangeLog.megaraid_sas |  160 
 drivers/scsi/megaraid/megaraid_sas.c  |2
 drivers/scsi/megaraid/megaraid_sas.h  |7
 3 files changed, 165 insertions(+), 4 deletions(-)

diff -uprN linux-2.6.22_orig/Documentation/scsi/ChangeLog.megaraid_sas 
linux-2.6.22_new/Documentation/scsi/ChangeLog.megaraid_sas
--- linux-2.6.22_orig/Documentation/scsi/ChangeLog.megaraid_sas 2007-09-26 
15:58:40.0 -0700
+++ linux-2.6.22_new/Documentation/scsi/ChangeLog.megaraid_sas  2007-09-27 
06:19:46.0 -0700
@@ -1,3 +1,163 @@
+1 Release Date: Thur. Sep. 27 10:09:32 PDT 2007 -
+   (emaild-id:[EMAIL PROTECTED])
+   Sumant Patro
+   Bo Yang 
+
+2 Current Version : 00.00.03.16-rc1
+3 Older Version   : 00.00.03.15
+
+1. Increased MFI_POLL_TIMEOUT_SECS to 60 seconds from 10. FW may take a max of 
60 seconds to 
+   respond to the INIT cmd.
+
+1 Release Date: Fri. Sep. 07 16:30:43 PST 2007 -
+   (emaild-id:[EMAIL PROTECTED])
+   Sumant Patro
+   Bo Yang 
+
+2 Current Version : 00.00.03.15
+3 Older Version   : 00.00.03.14
+
+1. Added module parameter poll_mode_io to support for polling (reduced 
interrupt operation).
+   In this mode, IO completion interrupts are delayed. At the end of 
initiating IOs,
+   the driver schedules for cmd completion if there are pending cmds to be 
completed.
+   A timer-based interrupt has also been added to prevent IO completion 
processing from
+   being delayed indefinitely in the case that no new IOs are initiated.
+
+1 Release Date: Fri. Sep. 07 16:30:43 PST 2007 -
+   (emaild-id:[EMAIL PROTECTED])
+   Sumant Patro
+   Bo Yang 
+
+2 Current Version : 00.00.03.14
+3 Older Version   : 00.00.03.13
+
+1. Setting the max_sectors_per_req based on max SGL supported by the FW. Prior 
versions calculated 
+   this value from controller info (max_sectors_1, max_sectors_2). For 
certain controllers/FW,
+   this was resulting in a value greater than max SGL supported by the FW. 
Issue was first
+   reported by users running LUKS+XFS with megaraid_sas.
+   Thanks to RB for providing the logs and duplication steps that helped 
to get to the root 
+   cause of the issue.
+2. Increased MFI_POLL_TIMEOUT_SECS to 60 seconds from 10. FW may take a max of 
60 seconds to 
+   respond to the INIT cmd.
+
+1 Release Date: Fri. June. 15 16:30:43 PST 2007 -
+   (emaild-id:[EMAIL PROTECTED])
+   Sumant Patro
+   Bo Yang 
+
+2 Current Version : 00.00.03.13
+3 Older Version   : 00.00.03.12
+
+1. Added the megasas_reset_timer routine to intercept cmd timeout and throttle 
io.
+
+On Fri, 2007-03-16 at 16:44 -0600, James Bottomley wrote:
+It looks like megaraid_sas at least needs this to throttle its commands
+ as they begin to time out.  The code keeps the existing transport
+ template use of eh_timed_out (and allows the transport to override the
+ host if they both have this callback).
+ 
+ James
+
+1 Release Date: Sat May. 12 16:30:43 PST 2007 -
+   (emaild-id:[EMAIL PROTECTED])
+   Sumant Patro
+   Bo Yang 
+
+2 Current Version : 00.00.03.12
+3 Older Version   : 00.00.03.11
+
+1.  When MegaSAS driver receives reset call from OS, driver waits in reset
+routine for max 3 minutes for all pending command completion. Now driver will
+call completion routine every 5 seconds from the reset routine instead of
+waiting for depending on cmd completion from isr path.
+
+1 Release Date: Mon Apr. 30 10:25:52 PST 2007 -
+   (emaild-id:[EMAIL PROTECTED])
+   Sumant Patro
+   Bo Yang 
+
+2 Current Version : 00.00.03.11
+3 Older Version   : 00.00.03.09
+
+   1. Following module parameters added -
+   fast_load: Faster loading of the driver, skips physical devices 
scanning thereby
+   reducing the time to load driver.
+   cmd_per_lun: Maximum number of commands per logical unit
+   max_sectors: Maximum number of sectors per IO command
+   2. Memory Manager for IOCTL removed for 2.6 kernels.
+  pci_alloc_consistent replaced by dma_alloc_coherent. With this 
+  change there is no need of memory manager in the driver code
+
+   On Wed, 2007-02-07 at 13:30 -0800, Andrew Morton wrote:
+I suspect all this horror is due to stupidity in the DMA API.
+   
+pci_alloc_consistent() just goes and assumes GFP_ATOMIC, whereas
+the caller (megasas_mgmt_fw_ioctl) would have been perfectly happy
+to use GFP_KERNEL.
+   
+I bet this fixes it
+
+   It does, but the DMA API

[PATCH 3/8] gdth: Remove 2.4.x support, in-kernel changelog

[Jeff Garzik]

* Remove in-source changelog.  It's archived permanently in git and
  various kernel archives, and changelogs should exist purely in git.

* Remove 2.4.x kernel support.  It is an active obstacle to
  modernizing this driver, at this point.  This includes killing
  gdth_kcompat.h which is 100% redundant in modern kernels.

Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]>
---

diff --git a/drivers/scsi/gdth.c b/drivers/scsi/gdth.c
index 840bdf6..a6b5717 100644
--- a/drivers/scsi/gdth.c
+++ b/drivers/scsi/gdth.c
@@ -27,280 +27,8 @@
  * along with this kernel; if not, write to the Free Software   *
  * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.*
  *  *
- * Linux kernel 2.4.x, 2.6.x supported  *
+ * Linux kernel 2.6.x supported
*
  *  *
- * $Log: gdth.c,v $
- * Revision 1.74  2006/04/10 13:44:47  achim
- * Community changes for 2.6.x
- * Kernel 2.2.x no longer supported
- * scsi_request interface removed, thanks to Christoph Hellwig
- *
- * Revision 1.73  2004/03/31 13:33:03  achim
- * Special command 0xfd implemented to detect 64-bit DMA support
- *
- * Revision 1.72  2004/03/17 08:56:04  achim
- * 64-bit DMA only enabled if FW >= x.43
- *
- * Revision 1.71  2004/03/05 15:51:29  achim
- * Screen service: separate message buffer, bugfixes
- *
- * Revision 1.70  2004/02/27 12:19:07  achim
- * Bugfix: Reset bit in config (0xfe) call removed
- *
- * Revision 1.69  2004/02/20 09:50:24  achim
- * Compatibility changes for kernels < 2.4.20
- * Bugfix screen service command size
- * pci_set_dma_mask() error handling added
- *
- * Revision 1.68  2004/02/19 15:46:54  achim
- * 64-bit DMA bugfixes
- * Drive size bugfix for drives > 1TB
- *
- * Revision 1.67  2004/01/14 13:11:57  achim
- * Tool access over /proc no longer supported
- * Bugfixes IOCTLs
- *
- * Revision 1.66  2003/12/19 15:04:06  achim
- * Bugfixes support for drives > 2TB
- *
- * Revision 1.65  2003/12/15 11:21:56  achim
- * 64-bit DMA support added
- * Support for drives > 2 TB implemented
- * Kernels 2.2.x, 2.4.x, 2.6.x supported
- *
- * Revision 1.64  2003/09/17 08:30:26  achim
- * EISA/ISA controller scan disabled
- * Command line switch probe_eisa_isa added
- *
- * Revision 1.63  2003/07/12 14:01:00  Daniele Bellucci <[EMAIL PROTECTED]>
- * Minor cleanups in gdth_ioctl.
- *
- * Revision 1.62  2003/02/27 15:01:59  achim
- * Dynamic DMA mapping implemented
- * New (character device) IOCTL interface added
- * Other controller related changes made
- *
- * Revision 1.61  2002/11/08 13:09:52  boji
- * Added support for XSCALE based RAID Controllers
- * Fixed SCREENSERVICE initialization in SMP cases
- * Added checks for gdth_polling before GDTH_HA_LOCK
- *
- * Revision 1.60  2002/02/05 09:35:22  achim
- * MODULE_LICENSE only if kernel >= 2.4.11
- *
- * Revision 1.59  2002/01/30 09:46:33  achim
- * Small changes
- *
- * Revision 1.58  2002/01/29 15:30:02  achim
- * Set default value of shared_access to Y
- * New status S_CACHE_RESERV for clustering added
- *
- * Revision 1.57  2001/08/21 11:16:35  achim
- * Bugfix free_irq()
- *
- * Revision 1.56  2001/08/09 11:19:39  achim
- * Scsi_Host_Template changes
- *
- * Revision 1.55  2001/08/09 10:11:28  achim
- * Command HOST_UNFREEZE_IO before cache service init.
- *
- * Revision 1.54  2001/07/20 13:48:12  achim
- * Expand: gdth_analyse_hdrive() removed
- *
- * Revision 1.53  2001/07/17 09:52:49  achim
- * Small OEM related change
- *
- * Revision 1.52  2001/06/19 15:06:20  achim
- * New host command GDT_UNFREEZE_IO added
- *
- * Revision 1.51  2001/05/22 06:42:37  achim
- * PCI: Subdevice ID added
- *
- * Revision 1.50  2001/05/17 13:42:16  achim
- * Support for Intel Storage RAID Controllers added
- *
- * Revision 1.50  2001/05/17 12:12:34  achim
- * Support for Intel Storage RAID Controllers added
- *
- * Revision 1.49  2001/03/15 15:07:17  achim
- * New __setup interface for boot command line options added
- *
- * Revision 1.48  2001/02/06 12:36:28  achim
- * Bugfix Cluster protocol
- *
- * Revision 1.47  2001/01/10 14:42:06  achim
- * New switch shared_access added
- *
- * Revision 1.46  2001/01/09 08:11:35  achim
- * gdth_command() removed
- * meaning of Scsi_Pointer members changed
- *
- * Revision 1.45  2000/11/16 12:02:24  achim
- * Changes for kernel 2.4
- *
- * Revision 1.44  2000/10/11 08:44:10  achim
- * Clustering changes: New flag media_changed added
- *
- * Revision 1.43  2000/09/20 12:59:01  achim
- * DPMEM remap functions for all PCI controller types implemented
- * Small changes for ia64 platform
- *
- * Revision 1.42  2000/07/20 09:04:50  achim
- * Small changes for kernel 2.4
- *
- * Revision 1.41  2000/07/04 14:11:11  achim
- * gdth_analyse_hdrive() added to rescan drives after online expansion
- *
- * Revision 1.

[PATCH 3/8] gdth: Remove 2.4.x support, in-kernel changelog

[Jeff Garzik]

* Remove in-source changelog.  It's archived permanently in git and
  various kernel archives, and changelogs should exist purely in git.

* Remove 2.4.x kernel support.  It is an active obstacle to
  modernizing this driver, at this point.  This includes killing
  gdth_kcompat.h which is 100% redundant in modern kernels.

Signed-off-by: Jeff Garzik [EMAIL PROTECTED]
---

diff --git a/drivers/scsi/gdth.c b/drivers/scsi/gdth.c
index 840bdf6..a6b5717 100644
--- a/drivers/scsi/gdth.c
+++ b/drivers/scsi/gdth.c
@@ -27,280 +27,8 @@
  * along with this kernel; if not, write to the Free Software   *
  * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.*
  *  *
- * Linux kernel 2.4.x, 2.6.x supported  *
+ * Linux kernel 2.6.x supported
*
  *  *
- * $Log: gdth.c,v $
- * Revision 1.74  2006/04/10 13:44:47  achim
- * Community changes for 2.6.x
- * Kernel 2.2.x no longer supported
- * scsi_request interface removed, thanks to Christoph Hellwig
- *
- * Revision 1.73  2004/03/31 13:33:03  achim
- * Special command 0xfd implemented to detect 64-bit DMA support
- *
- * Revision 1.72  2004/03/17 08:56:04  achim
- * 64-bit DMA only enabled if FW = x.43
- *
- * Revision 1.71  2004/03/05 15:51:29  achim
- * Screen service: separate message buffer, bugfixes
- *
- * Revision 1.70  2004/02/27 12:19:07  achim
- * Bugfix: Reset bit in config (0xfe) call removed
- *
- * Revision 1.69  2004/02/20 09:50:24  achim
- * Compatibility changes for kernels  2.4.20
- * Bugfix screen service command size
- * pci_set_dma_mask() error handling added
- *
- * Revision 1.68  2004/02/19 15:46:54  achim
- * 64-bit DMA bugfixes
- * Drive size bugfix for drives  1TB
- *
- * Revision 1.67  2004/01/14 13:11:57  achim
- * Tool access over /proc no longer supported
- * Bugfixes IOCTLs
- *
- * Revision 1.66  2003/12/19 15:04:06  achim
- * Bugfixes support for drives  2TB
- *
- * Revision 1.65  2003/12/15 11:21:56  achim
- * 64-bit DMA support added
- * Support for drives  2 TB implemented
- * Kernels 2.2.x, 2.4.x, 2.6.x supported
- *
- * Revision 1.64  2003/09/17 08:30:26  achim
- * EISA/ISA controller scan disabled
- * Command line switch probe_eisa_isa added
- *
- * Revision 1.63  2003/07/12 14:01:00  Daniele Bellucci [EMAIL PROTECTED]
- * Minor cleanups in gdth_ioctl.
- *
- * Revision 1.62  2003/02/27 15:01:59  achim
- * Dynamic DMA mapping implemented
- * New (character device) IOCTL interface added
- * Other controller related changes made
- *
- * Revision 1.61  2002/11/08 13:09:52  boji
- * Added support for XSCALE based RAID Controllers
- * Fixed SCREENSERVICE initialization in SMP cases
- * Added checks for gdth_polling before GDTH_HA_LOCK
- *
- * Revision 1.60  2002/02/05 09:35:22  achim
- * MODULE_LICENSE only if kernel = 2.4.11
- *
- * Revision 1.59  2002/01/30 09:46:33  achim
- * Small changes
- *
- * Revision 1.58  2002/01/29 15:30:02  achim
- * Set default value of shared_access to Y
- * New status S_CACHE_RESERV for clustering added
- *
- * Revision 1.57  2001/08/21 11:16:35  achim
- * Bugfix free_irq()
- *
- * Revision 1.56  2001/08/09 11:19:39  achim
- * Scsi_Host_Template changes
- *
- * Revision 1.55  2001/08/09 10:11:28  achim
- * Command HOST_UNFREEZE_IO before cache service init.
- *
- * Revision 1.54  2001/07/20 13:48:12  achim
- * Expand: gdth_analyse_hdrive() removed
- *
- * Revision 1.53  2001/07/17 09:52:49  achim
- * Small OEM related change
- *
- * Revision 1.52  2001/06/19 15:06:20  achim
- * New host command GDT_UNFREEZE_IO added
- *
- * Revision 1.51  2001/05/22 06:42:37  achim
- * PCI: Subdevice ID added
- *
- * Revision 1.50  2001/05/17 13:42:16  achim
- * Support for Intel Storage RAID Controllers added
- *
- * Revision 1.50  2001/05/17 12:12:34  achim
- * Support for Intel Storage RAID Controllers added
- *
- * Revision 1.49  2001/03/15 15:07:17  achim
- * New __setup interface for boot command line options added
- *
- * Revision 1.48  2001/02/06 12:36:28  achim
- * Bugfix Cluster protocol
- *
- * Revision 1.47  2001/01/10 14:42:06  achim
- * New switch shared_access added
- *
- * Revision 1.46  2001/01/09 08:11:35  achim
- * gdth_command() removed
- * meaning of Scsi_Pointer members changed
- *
- * Revision 1.45  2000/11/16 12:02:24  achim
- * Changes for kernel 2.4
- *
- * Revision 1.44  2000/10/11 08:44:10  achim
- * Clustering changes: New flag media_changed added
- *
- * Revision 1.43  2000/09/20 12:59:01  achim
- * DPMEM remap functions for all PCI controller types implemented
- * Small changes for ia64 platform
- *
- * Revision 1.42  2000/07/20 09:04:50  achim
- * Small changes for kernel 2.4
- *
- * Revision 1.41  2000/07/04 14:11:11  achim
- * gdth_analyse_hdrive() added to rescan drives after online expansion
- *
- * Revision 1.40  2000/06/27 11:24:16  achim

[PATCH 4/4] scsi: megaraid_sas - update version and Changelog

[linux-box]

Update version and Changelog

Signed-off-by: Bo Yang <[EMAIL PROTECTED]>

---
Re-submitting

 Documentation/scsi/ChangeLog.megaraid_sas |  211 
 drivers/scsi/megaraid/megaraid_sas.c  |2
 drivers/scsi/megaraid/megaraid_sas.h  |6
 3 files changed, 215 insertions(+), 4 deletions(-)

diff -rupN linux-2.6.22_orig/Documentation/scsi/ChangeLog.megaraid_sas 
linux-2.6.22_new/Documentation/scsi/ChangeLog.megaraid_sas
--- linux-2.6.22_orig/Documentation/scsi/ChangeLog.megaraid_sas 2007-07-02 
21:37:20.0 -0400
+++ linux-2.6.22_new/Documentation/scsi/ChangeLog.megaraid_sas  2007-08-14 
19:22:25.061854656 -0400
@@ -1,3 +1,239 @@
+1 Release Date: Tue. Aug. 14 10:09:32 PDT 2007 -
+   (emaild-id:[EMAIL PROTECTED])
+
+2 Current Version : 00.00.03.14-RC2
+3 Older Version   : 00.00.03.13
+
+1. convert to use the data buffer accessors
+
+>From: James Bottomley [mailto:[EMAIL PROTECTED]
+>Sent: Thursday, May 31, 2007 3:40 PM
+>To: FUJITA Tomonori; Patro, Sumant; James Bottomley
+>Subject: Patch added to scsi-misc-2.6: [SCSI] megaraid_sas: convert to use 
the data buffer accessors  
+- remove the unnecessary map_single path.
+- convert to use the new accessors for the sg lists and the
+parameters.
+   
+2. Clean up the codes and take off the compile warning.
+
+1 Release Date: Thu. May. 31 11:25:21 PDT 2007 -
+   (emaild-id:[EMAIL PROTECTED])
+
+2 Current Version : 00.00.03.13
+3 Older Version   : 00.00.03.12
+
+1. Added the megasas_reset_timer routine to intercept cmd timeout 
+   and throttle io.
+
+On Fri, 2007-03-16 at 16:44 -0600, James Bottomley wrote:
+It looks like megaraid_sas at least needs this to throttle its commands
+> as they begin to time out.  The code keeps the existing transport
+> template use of eh_timed_out (and allows the transport to override the
+> host if they both have this callback).
+> 
+> James
+
+1 Release Date: Sat. May. 14 16:30:43 PST 2007 -
+   (emaild-id:[EMAIL PROTECTED])
+   Sumant Patro
+   Bo Yang 
+
+2 Current Version : 00.00.03.12
+3 Older Version   : 00.00.03.11
+
+1.  When MegaSAS driver receives reset call from OS, driver waits in reset
+routine for max 3 minutes for all pending command completion. Now driver will
+call completion routine every 5 seconds from the reset routine instead of
+waiting for cmd completion from isr path.
+
+1 Release Date: Mon Apr. 30 10:25:52 PST 2007 -
+   (emaild-id:[EMAIL PROTECTED])
+   Sumant Patro
+   Bo Yang 
+
+2 Current Version : 00.00.03.11
+3 Older Version   : 00.00.03.10
+
+   1. Following module parameters added -
+   fast_load: Faster loading of the driver, skips physical devices
+   cmd_per_lun: Maximum number of commands per logical unit
+   max_sectors: Maximum number of sectors per IO command
+   2. Hibernation support added
+   3. Performing diskdump while running IO in RHEL 4 was failing. Fixed.
+   
+1 Release Date: Wed Mar. 28 10:25:52 PST 2007
+2 Current Version : 00.00.03.10
+3 Older Version   : 00.00.03.09
+
+i. Replaced pci_alloc_consistent with dma_alloc_coherent in ioctl path
+ii.eh_timed_out call back (megasas_reset_timer) is now used to throttle io 
to the
+   adapter when it is called the first time for a scmd.
+   The MEGASAS_FW_BUSY flag is set and can_queue reduced to 16. The 
can_queue is
+   restored from completion routine in following two conditions :
+   5 seconds has elapsed and the # of outstanding cmds in FW is < 17.
+   This implementation replaces the throttling mechanism of 3.08 ver.
+
+On Thu, 2007-02-15 at 19:53 -0700, Patro, Sumant wrote:
+> Hello James,
+>
+>   I re-submitted the patch yesterday with the "space" issue fixed
+> (adhering to coding guideline).
+>
+>   I will check for alternative to calculate the time driver have
+> been sending host busy to OS. Will check with time_before() as you have
+> suggested.
+>
+>   Throttling from megasas_generic_reset() handler did not help.
+> megaraid does not have feature to abort cmds. So, in the generic reset
+> routine, the driver just waits for cmd completion by FW. These timed-out
+> cmds gets retried by mid-layer with "retries" incremented by 1.
+> Eventually we see retries equals max_allowed followed by SCSI error with
+> "DRIVER_TIMEOUT".
+
+That's rather what worries me.  When the error handler activates (which
+it will on the first timeout), it waits for all commands to complete or
+time out before running.  Your reset handler does nothing other than
+wait for the firmware to complete the commands (now uselessly), so we
+now wait for the entire firmware command queue to drain, then you tell
+the mid layer 

[PATCH 4/4] scsi: megaraid_sas - update version and Changelog

[linux-box]

Update version and Changelog

Signed-off-by: Bo Yang [EMAIL PROTECTED]

---
Re-submitting

 Documentation/scsi/ChangeLog.megaraid_sas |  211 
 drivers/scsi/megaraid/megaraid_sas.c  |2
 drivers/scsi/megaraid/megaraid_sas.h  |6
 3 files changed, 215 insertions(+), 4 deletions(-)

diff -rupN linux-2.6.22_orig/Documentation/scsi/ChangeLog.megaraid_sas 
linux-2.6.22_new/Documentation/scsi/ChangeLog.megaraid_sas
--- linux-2.6.22_orig/Documentation/scsi/ChangeLog.megaraid_sas 2007-07-02 
21:37:20.0 -0400
+++ linux-2.6.22_new/Documentation/scsi/ChangeLog.megaraid_sas  2007-08-14 
19:22:25.061854656 -0400
@@ -1,3 +1,239 @@
+1 Release Date: Tue. Aug. 14 10:09:32 PDT 2007 -
+   (emaild-id:[EMAIL PROTECTED])
+
+2 Current Version : 00.00.03.14-RC2
+3 Older Version   : 00.00.03.13
+
+1. convert to use the data buffer accessors
+
+From: James Bottomley [mailto:[EMAIL PROTECTED]
+Sent: Thursday, May 31, 2007 3:40 PM
+To: FUJITA Tomonori; Patro, Sumant; James Bottomley
+Subject: Patch added to scsi-misc-2.6: [SCSI] megaraid_sas: convert to use 
the data buffer accessors  
+- remove the unnecessary map_single path.
+- convert to use the new accessors for the sg lists and the
+parameters.
+   
+2. Clean up the codes and take off the compile warning.
+
+1 Release Date: Thu. May. 31 11:25:21 PDT 2007 -
+   (emaild-id:[EMAIL PROTECTED])
+
+2 Current Version : 00.00.03.13
+3 Older Version   : 00.00.03.12
+
+1. Added the megasas_reset_timer routine to intercept cmd timeout 
+   and throttle io.
+
+On Fri, 2007-03-16 at 16:44 -0600, James Bottomley wrote:
+It looks like megaraid_sas at least needs this to throttle its commands
+ as they begin to time out.  The code keeps the existing transport
+ template use of eh_timed_out (and allows the transport to override the
+ host if they both have this callback).
+ 
+ James
+
+1 Release Date: Sat. May. 14 16:30:43 PST 2007 -
+   (emaild-id:[EMAIL PROTECTED])
+   Sumant Patro
+   Bo Yang 
+
+2 Current Version : 00.00.03.12
+3 Older Version   : 00.00.03.11
+
+1.  When MegaSAS driver receives reset call from OS, driver waits in reset
+routine for max 3 minutes for all pending command completion. Now driver will
+call completion routine every 5 seconds from the reset routine instead of
+waiting for cmd completion from isr path.
+
+1 Release Date: Mon Apr. 30 10:25:52 PST 2007 -
+   (emaild-id:[EMAIL PROTECTED])
+   Sumant Patro
+   Bo Yang 
+
+2 Current Version : 00.00.03.11
+3 Older Version   : 00.00.03.10
+
+   1. Following module parameters added -
+   fast_load: Faster loading of the driver, skips physical devices
+   cmd_per_lun: Maximum number of commands per logical unit
+   max_sectors: Maximum number of sectors per IO command
+   2. Hibernation support added
+   3. Performing diskdump while running IO in RHEL 4 was failing. Fixed.
+   
+1 Release Date: Wed Mar. 28 10:25:52 PST 2007
+2 Current Version : 00.00.03.10
+3 Older Version   : 00.00.03.09
+
+i. Replaced pci_alloc_consistent with dma_alloc_coherent in ioctl path
+ii.eh_timed_out call back (megasas_reset_timer) is now used to throttle io 
to the
+   adapter when it is called the first time for a scmd.
+   The MEGASAS_FW_BUSY flag is set and can_queue reduced to 16. The 
can_queue is
+   restored from completion routine in following two conditions :
+   5 seconds has elapsed and the # of outstanding cmds in FW is  17.
+   This implementation replaces the throttling mechanism of 3.08 ver.
+
+On Thu, 2007-02-15 at 19:53 -0700, Patro, Sumant wrote:
+ Hello James,
+
+   I re-submitted the patch yesterday with the space issue fixed
+ (adhering to coding guideline).
+
+   I will check for alternative to calculate the time driver have
+ been sending host busy to OS. Will check with time_before() as you have
+ suggested.
+
+   Throttling from megasas_generic_reset() handler did not help.
+ megaraid does not have feature to abort cmds. So, in the generic reset
+ routine, the driver just waits for cmd completion by FW. These timed-out
+ cmds gets retried by mid-layer with retries incremented by 1.
+ Eventually we see retries equals max_allowed followed by SCSI error with
+ DRIVER_TIMEOUT.
+
+That's rather what worries me.  When the error handler activates (which
+it will on the first timeout), it waits for all commands to complete or
+time out before running.  Your reset handler does nothing other than
+wait for the firmware to complete the commands (now uselessly), so we
+now wait for the entire firmware command queue to drain, then you tell
+the mid layer everything is OK, so it loads you up again with all the
+commands plus a few test unit readies for good measure, then you
+throttle.
+
+You