[PATCH] cpufreq: Default governor initialisation before use
Ensure that the selected default cpufreq governor is initialised before
used by the cpufreq driver on boot by using fs_initcall() instead of
module_init().
Signed-off-by: Johannes Weiner <[EMAIL PROTECTED]>
---
On boot, speedstep_init() calls into cpufreq_gov_dbs(). The driver has
not yet been initialised by cpufreq_gov_dbs_init() and kondemand_wq is
still NULL when it is dereferenced.
Changing the drivers module_init() to fs_initcall() fixed it. The same
is already done in the performance and userspace governor drivers.
The patch migrates all governors to use fs_initcall() when being the
default governor.
drivers/cpufreq/cpufreq_conservative.c |4
drivers/cpufreq/cpufreq_ondemand.c |5 -
drivers/cpufreq/cpufreq_performance.c |4
drivers/cpufreq/cpufreq_userspace.c|4
4 files changed, 16 insertions(+), 1 deletions(-)
diff --git a/drivers/cpufreq/cpufreq_conservative.c
b/drivers/cpufreq/cpufreq_conservative.c
index 1bba997..5d3a04b 100644
--- a/drivers/cpufreq/cpufreq_conservative.c
+++ b/drivers/cpufreq/cpufreq_conservative.c
@@ -603,5 +603,9 @@ MODULE_DESCRIPTION ("'cpufreq_conservative' - A dynamic
cpufreq governor for "
"optimised for use in a battery environment");
MODULE_LICENSE ("GPL");
+#ifdef CONFIG_CPU_FREQ_DEFAULT_GOV_CONSERVATIVE
+fs_initcall(cpufreq_gov_dbs_init);
+#else
module_init(cpufreq_gov_dbs_init);
+#endif
module_exit(cpufreq_gov_dbs_exit);
diff --git a/drivers/cpufreq/cpufreq_ondemand.c
b/drivers/cpufreq/cpufreq_ondemand.c
index 369f445..d2af20d 100644
--- a/drivers/cpufreq/cpufreq_ondemand.c
+++ b/drivers/cpufreq/cpufreq_ondemand.c
@@ -610,6 +610,9 @@ MODULE_DESCRIPTION("'cpufreq_ondemand' - A dynamic cpufreq
governor for "
"Low Latency Frequency Transition capable processors");
MODULE_LICENSE("GPL");
+#ifdef CONFIG_CPU_FREQ_DEFAULT_GOV_ONDEMAND
+fs_initcall(cpufreq_gov_dbs_init);
+#else
module_init(cpufreq_gov_dbs_init);
+#endif
module_exit(cpufreq_gov_dbs_exit);
-
diff --git a/drivers/cpufreq/cpufreq_performance.c
b/drivers/cpufreq/cpufreq_performance.c
index e8e1451..df5fca3 100644
--- a/drivers/cpufreq/cpufreq_performance.c
+++ b/drivers/cpufreq/cpufreq_performance.c
@@ -60,5 +60,9 @@ MODULE_AUTHOR("Dominik Brodowski <[EMAIL PROTECTED]>");
MODULE_DESCRIPTION("CPUfreq policy governor 'performance'");
MODULE_LICENSE("GPL");
+#ifdef CONFIG_CPU_FREQ_DEFAULT_GOV_PERFORMANCE
fs_initcall(cpufreq_gov_performance_init);
+#else
+module_init(cpufreq_gov_performance_init);
+#endif
module_exit(cpufreq_gov_performance_exit);
diff --git a/drivers/cpufreq/cpufreq_userspace.c
b/drivers/cpufreq/cpufreq_userspace.c
index 51bedab..f8cdde4 100644
--- a/drivers/cpufreq/cpufreq_userspace.c
+++ b/drivers/cpufreq/cpufreq_userspace.c
@@ -231,5 +231,9 @@ MODULE_AUTHOR ("Dominik Brodowski <[EMAIL PROTECTED]>,
Russell King <[EMAIL PROTECTED]
MODULE_DESCRIPTION ("CPUfreq policy governor 'userspace'");
MODULE_LICENSE ("GPL");
+#ifdef CONFIG_CPU_FREQ_DEFAULT_GOV_USERSPACE
fs_initcall(cpufreq_gov_userspace_init);
+#else
+module_init(cpufreq_gov_userspace_init);
+#endif
module_exit(cpufreq_gov_userspace_exit);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH] cpufreq: Default governor initialisation before use
Ensure that the selected default cpufreq governor is initialised before
used by the cpufreq driver on boot by using fs_initcall() instead of
module_init().
Signed-off-by: Johannes Weiner [EMAIL PROTECTED]
---
On boot, speedstep_init() calls into cpufreq_gov_dbs(). The driver has
not yet been initialised by cpufreq_gov_dbs_init() and kondemand_wq is
still NULL when it is dereferenced.
Changing the drivers module_init() to fs_initcall() fixed it. The same
is already done in the performance and userspace governor drivers.
The patch migrates all governors to use fs_initcall() when being the
default governor.
drivers/cpufreq/cpufreq_conservative.c |4
drivers/cpufreq/cpufreq_ondemand.c |5 -
drivers/cpufreq/cpufreq_performance.c |4
drivers/cpufreq/cpufreq_userspace.c|4
4 files changed, 16 insertions(+), 1 deletions(-)
diff --git a/drivers/cpufreq/cpufreq_conservative.c
b/drivers/cpufreq/cpufreq_conservative.c
index 1bba997..5d3a04b 100644
--- a/drivers/cpufreq/cpufreq_conservative.c
+++ b/drivers/cpufreq/cpufreq_conservative.c
@@ -603,5 +603,9 @@ MODULE_DESCRIPTION ('cpufreq_conservative' - A dynamic
cpufreq governor for
optimised for use in a battery environment);
MODULE_LICENSE (GPL);
+#ifdef CONFIG_CPU_FREQ_DEFAULT_GOV_CONSERVATIVE
+fs_initcall(cpufreq_gov_dbs_init);
+#else
module_init(cpufreq_gov_dbs_init);
+#endif
module_exit(cpufreq_gov_dbs_exit);
diff --git a/drivers/cpufreq/cpufreq_ondemand.c
b/drivers/cpufreq/cpufreq_ondemand.c
index 369f445..d2af20d 100644
--- a/drivers/cpufreq/cpufreq_ondemand.c
+++ b/drivers/cpufreq/cpufreq_ondemand.c
@@ -610,6 +610,9 @@ MODULE_DESCRIPTION('cpufreq_ondemand' - A dynamic cpufreq
governor for
Low Latency Frequency Transition capable processors);
MODULE_LICENSE(GPL);
+#ifdef CONFIG_CPU_FREQ_DEFAULT_GOV_ONDEMAND
+fs_initcall(cpufreq_gov_dbs_init);
+#else
module_init(cpufreq_gov_dbs_init);
+#endif
module_exit(cpufreq_gov_dbs_exit);
-
diff --git a/drivers/cpufreq/cpufreq_performance.c
b/drivers/cpufreq/cpufreq_performance.c
index e8e1451..df5fca3 100644
--- a/drivers/cpufreq/cpufreq_performance.c
+++ b/drivers/cpufreq/cpufreq_performance.c
@@ -60,5 +60,9 @@ MODULE_AUTHOR(Dominik Brodowski [EMAIL PROTECTED]);
MODULE_DESCRIPTION(CPUfreq policy governor 'performance');
MODULE_LICENSE(GPL);
+#ifdef CONFIG_CPU_FREQ_DEFAULT_GOV_PERFORMANCE
fs_initcall(cpufreq_gov_performance_init);
+#else
+module_init(cpufreq_gov_performance_init);
+#endif
module_exit(cpufreq_gov_performance_exit);
diff --git a/drivers/cpufreq/cpufreq_userspace.c
b/drivers/cpufreq/cpufreq_userspace.c
index 51bedab..f8cdde4 100644
--- a/drivers/cpufreq/cpufreq_userspace.c
+++ b/drivers/cpufreq/cpufreq_userspace.c
@@ -231,5 +231,9 @@ MODULE_AUTHOR (Dominik Brodowski [EMAIL PROTECTED],
Russell King [EMAIL PROTECTED]
MODULE_DESCRIPTION (CPUfreq policy governor 'userspace');
MODULE_LICENSE (GPL);
+#ifdef CONFIG_CPU_FREQ_DEFAULT_GOV_USERSPACE
fs_initcall(cpufreq_gov_userspace_init);
+#else
+module_init(cpufreq_gov_userspace_init);
+#endif
module_exit(cpufreq_gov_userspace_exit);
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: cpufreq default governor
On 4/24/07, William Heimbigner <[EMAIL PROTECTED]> wrote: Is it actually "not working" though, even at the hardware level? To my knowledge those noises are normal, and aren't even signs of a harware problem. I believe it is the natural result of changing frequencies at any time. If you change frequencies, especially in the low end of available frequencies, you should hear a very brief noise. A governor such as ondemand, which is rapidly switching the frequency from say, 333 MHz to 2.66 GHz, is likely to make this much more noticable. It's only normal if your vendor used cheap noisy components. This would be a fatal flaw for a system that was intended for audio production for example. Lee - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: cpufreq default governor
On 4/24/07, William Heimbigner [EMAIL PROTECTED] wrote: Is it actually not working though, even at the hardware level? To my knowledge those noises are normal, and aren't even signs of a harware problem. I believe it is the natural result of changing frequencies at any time. If you change frequencies, especially in the low end of available frequencies, you should hear a very brief noise. A governor such as ondemand, which is rapidly switching the frequency from say, 333 MHz to 2.66 GHz, is likely to make this much more noticable. It's only normal if your vendor used cheap noisy components. This would be a fatal flaw for a system that was intended for audio production for example. Lee - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: cpufreq default governor
On 24/04/07, William Heimbigner <[EMAIL PROTECTED]> wrote: On Tue, 24 Apr 2007, Michal Piotrowski wrote: > On 24/04/07, William Heimbigner <[EMAIL PROTECTED]> wrote: >> On Tue, 24 Apr 2007, Michal Piotrowski wrote: >> >> > On 24/04/07, William Heimbigner <[EMAIL PROTECTED]> wrote: >> > > On Tue, 24 Apr 2007, Michal Piotrowski wrote: >> > > >> > > > Hi William, >> > > > >> > > > On 24/04/07, William Heimbigner <[EMAIL PROTECTED]> wrote: >> > > > >Question: is there some reason that kconfig does not allow for >> > > > >default >> > > > >governors of conservative/ondemand/powersave? >> > > > >> > > > Performance? >> > > > >> > > > >I'm not aware of any reason why one of those governors could not >> > > > >be >> > > > >used >> > > > >as default. >> > > > >> > > > My hardware doesn't work properly with ondemand governor. I hear >> > > > strange noises when frequency is changed. >> > > > >> > > >> > > That doesn't mean it isn't working, though. >> > >> > I didn't say that cpufreq ondemand is broken. It's a hardware problem. >> > >> > > I here weird noises if the cpu >> > > is clocked anywhere from 333MHz to 1GHz (sounds like an RD-D2 beeping >> > > noises in ultra high pitch?) >> > >> > Yes, something like that. >> >> Is it actually "not working" though, even at the hardware level? > > It works, but for me this sounds are very weird ;) > >> To my >> knowledge those noises are normal, and aren't even signs of a harware >> problem. I believe it is the natural result of changing frequencies at any >> time. If you change frequencies, especially in the low end of available >> frequencies, you should hear a very brief noise. A governor such as >> ondemand, which is rapidly switching the frequency from say, 333 MHz to >> 2.66 GHz, is likely to make this much more noticable. > > Ok, it might be normal behavior. I might be wrong, but IMO users > prefer speed and no strange sounds as default setting. I agree! My suggestion, however, is that if they do want a different scheduler as the default, they can choose one. There are some cases in which this could be very useful. A couple examples would be the processor with poor cooling that overheats easily, or a laptop with a poor battery. However, on second thought with regards to Kconfig, would it be feasible to have performance always be the default, unless a "cpufreqgov=conservative" arguement was specified on the command line? This would be less susceptible to users complaining that their cpu is chirping all of a sudden. I'm all for the ability to set the default to whatever governor the user wants. I _always_ run my laptops with the ondemand governor, my Pentium M-based PVR runs with ondemand too, and only my old P4 box doesn't because it's pointless. If you're running servers that _aren't_ going to be idle most of the time, then by all means set your default to performance, or just don't enable cpufreq at all, but give the rest of us the option. Particularily with laptops, I've always wanted the kernel to boot and immediately slow the CPU down, even if all I do is boot into single user mode, or even bypass init altogether. This will give best battery life and coolest operation out of the box without having to rely on userland whatsoever. I had an old laptop a while back that _would_ overheat and shutdown within a couple of minutes, even though idle, if booted to single user mode because the cpu freq wasn't slowed down. -- Ian Morgan - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: cpufreq default governor
On Tue, 24 Apr 2007, Michal Piotrowski wrote: On 24/04/07, William Heimbigner <[EMAIL PROTECTED]> wrote: On Tue, 24 Apr 2007, Michal Piotrowski wrote: > On 24/04/07, William Heimbigner <[EMAIL PROTECTED]> wrote: > > On Tue, 24 Apr 2007, Michal Piotrowski wrote: > > > > > Hi William, > > > > > > On 24/04/07, William Heimbigner <[EMAIL PROTECTED]> wrote: > > > >Question: is there some reason that kconfig does not allow for > > > >default > > > >governors of conservative/ondemand/powersave? > > > > > > Performance? > > > > > > >I'm not aware of any reason why one of those governors could not > > > >be > > > >used > > > >as default. > > > > > > My hardware doesn't work properly with ondemand governor. I hear > > > strange noises when frequency is changed. > > > > > > > That doesn't mean it isn't working, though. > > I didn't say that cpufreq ondemand is broken. It's a hardware problem. > > > I here weird noises if the cpu > > is clocked anywhere from 333MHz to 1GHz (sounds like an RD-D2 beeping > > noises in ultra high pitch?) > > Yes, something like that. Is it actually "not working" though, even at the hardware level? It works, but for me this sounds are very weird ;) To my knowledge those noises are normal, and aren't even signs of a harware problem. I believe it is the natural result of changing frequencies at any time. If you change frequencies, especially in the low end of available frequencies, you should hear a very brief noise. A governor such as ondemand, which is rapidly switching the frequency from say, 333 MHz to 2.66 GHz, is likely to make this much more noticable. Ok, it might be normal behavior. I might be wrong, but IMO users prefer speed and no strange sounds as default setting. I agree! My suggestion, however, is that if they do want a different scheduler as the default, they can choose one. There are some cases in which this could be very useful. A couple examples would be the processor with poor cooling that overheats easily, or a laptop with a poor battery. However, on second thought with regards to Kconfig, would it be feasible to have performance always be the default, unless a "cpufreqgov=conservative" arguement was specified on the command line? This would be less susceptible to users complaining that their cpu is chirping all of a sudden. William Heimbigner [EMAIL PROTECTED] - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: cpufreq default governor
On 24/04/07, William Heimbigner <[EMAIL PROTECTED]> wrote: On Tue, 24 Apr 2007, Michal Piotrowski wrote: > On 24/04/07, William Heimbigner <[EMAIL PROTECTED]> wrote: >> On Tue, 24 Apr 2007, Michal Piotrowski wrote: >> >> > Hi William, >> > >> > On 24/04/07, William Heimbigner <[EMAIL PROTECTED]> wrote: >> > > Question: is there some reason that kconfig does not allow for >> > > default >> > > governors of conservative/ondemand/powersave? >> > >> > Performance? >> > >> > > I'm not aware of any reason why one of those governors could not be >> > > used >> > > as default. >> > >> > My hardware doesn't work properly with ondemand governor. I hear >> > strange noises when frequency is changed. >> > >> >> That doesn't mean it isn't working, though. > > I didn't say that cpufreq ondemand is broken. It's a hardware problem. > >> I here weird noises if the cpu >> is clocked anywhere from 333MHz to 1GHz (sounds like an RD-D2 beeping >> noises in ultra high pitch?) > > Yes, something like that. Is it actually "not working" though, even at the hardware level? It works, but for me this sounds are very weird ;) To my knowledge those noises are normal, and aren't even signs of a harware problem. I believe it is the natural result of changing frequencies at any time. If you change frequencies, especially in the low end of available frequencies, you should hear a very brief noise. A governor such as ondemand, which is rapidly switching the frequency from say, 333 MHz to 2.66 GHz, is likely to make this much more noticable. Ok, it might be normal behavior. I might be wrong, but IMO users prefer speed and no strange sounds as default setting. William Heimbigner [EMAIL PROTECTED] Regards, Michal -- Michal K. K. Piotrowski LTG - Linux Testers Group (PL) (http://www.stardust.webpages.pl/ltg/) LTG - Linux Testers Group (EN) (http://www.stardust.webpages.pl/linux_testers_group_en/) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: cpufreq default governor
On Tue, 24 Apr 2007, Michal Piotrowski wrote: On 24/04/07, William Heimbigner <[EMAIL PROTECTED]> wrote: On Tue, 24 Apr 2007, Michal Piotrowski wrote: > Hi William, > > On 24/04/07, William Heimbigner <[EMAIL PROTECTED]> wrote: > > Question: is there some reason that kconfig does not allow for > > default > > governors of conservative/ondemand/powersave? > > Performance? > > > I'm not aware of any reason why one of those governors could not be > > used > > as default. > > My hardware doesn't work properly with ondemand governor. I hear > strange noises when frequency is changed. > That doesn't mean it isn't working, though. I didn't say that cpufreq ondemand is broken. It's a hardware problem. I here weird noises if the cpu is clocked anywhere from 333MHz to 1GHz (sounds like an RD-D2 beeping noises in ultra high pitch?) Yes, something like that. Is it actually "not working" though, even at the hardware level? To my knowledge those noises are normal, and aren't even signs of a harware problem. I believe it is the natural result of changing frequencies at any time. If you change frequencies, especially in the low end of available frequencies, you should hear a very brief noise. A governor such as ondemand, which is rapidly switching the frequency from say, 333 MHz to 2.66 GHz, is likely to make this much more noticable. William Heimbigner [EMAIL PROTECTED] - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: cpufreq default governor
On 24/04/07, William Heimbigner <[EMAIL PROTECTED]> wrote: On Tue, 24 Apr 2007, Michal Piotrowski wrote: > Hi William, > > On 24/04/07, William Heimbigner <[EMAIL PROTECTED]> wrote: >> Question: is there some reason that kconfig does not allow for default >> governors of conservative/ondemand/powersave? > > Performance? > >> I'm not aware of any reason why one of those governors could not be used >> as default. > > My hardware doesn't work properly with ondemand governor. I hear > strange noises when frequency is changed. > That doesn't mean it isn't working, though. I didn't say that cpufreq ondemand is broken. It's a hardware problem. I here weird noises if the cpu is clocked anywhere from 333MHz to 1GHz (sounds like an RD-D2 beeping noises in ultra high pitch?) Yes, something like that. William Heimbigner [EMAIL PROTECTED] Regards, Michal -- Michal K. K. Piotrowski LTG - Linux Testers Group (PL) (http://www.stardust.webpages.pl/ltg/) LTG - Linux Testers Group (EN) (http://www.stardust.webpages.pl/linux_testers_group_en/) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: cpufreq default governor
On Tue, 24 Apr 2007, Michal Piotrowski wrote: Hi William, On 24/04/07, William Heimbigner <[EMAIL PROTECTED]> wrote: Question: is there some reason that kconfig does not allow for default governors of conservative/ondemand/powersave? Performance? I'm not aware of any reason why one of those governors could not be used as default. My hardware doesn't work properly with ondemand governor. I hear strange noises when frequency is changed. That doesn't mean it isn't working, though. I here weird noises if the cpu is clocked anywhere from 333MHz to 1GHz (sounds like an RD-D2 beeping noises in ultra high pitch?) William Heimbigner [EMAIL PROTECTED] - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: cpufreq default governor
Hi William, On 24/04/07, William Heimbigner <[EMAIL PROTECTED]> wrote: Question: is there some reason that kconfig does not allow for default governors of conservative/ondemand/powersave? Performance? I'm not aware of any reason why one of those governors could not be used as default. My hardware doesn't work properly with ondemand governor. I hear strange noises when frequency is changed. William Heimbigner [EMAIL PROTECTED] Regards, Michal -- Michal K. K. Piotrowski LTG - Linux Testers Group (PL) (http://www.stardust.webpages.pl/ltg/) LTG - Linux Testers Group (EN) (http://www.stardust.webpages.pl/linux_testers_group_en/) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
cpufreq default governor
Question: is there some reason that kconfig does not allow for default governors of conservative/ondemand/powersave? I'm not aware of any reason why one of those governors could not be used as default. William Heimbigner [EMAIL PROTECTED] - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
cpufreq default governor
Question: is there some reason that kconfig does not allow for default governors of conservative/ondemand/powersave? I'm not aware of any reason why one of those governors could not be used as default. William Heimbigner [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: cpufreq default governor
Hi William, On 24/04/07, William Heimbigner [EMAIL PROTECTED] wrote: Question: is there some reason that kconfig does not allow for default governors of conservative/ondemand/powersave? Performance? I'm not aware of any reason why one of those governors could not be used as default. My hardware doesn't work properly with ondemand governor. I hear strange noises when frequency is changed. William Heimbigner [EMAIL PROTECTED] Regards, Michal -- Michal K. K. Piotrowski LTG - Linux Testers Group (PL) (http://www.stardust.webpages.pl/ltg/) LTG - Linux Testers Group (EN) (http://www.stardust.webpages.pl/linux_testers_group_en/) - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: cpufreq default governor
On Tue, 24 Apr 2007, Michal Piotrowski wrote: Hi William, On 24/04/07, William Heimbigner [EMAIL PROTECTED] wrote: Question: is there some reason that kconfig does not allow for default governors of conservative/ondemand/powersave? Performance? I'm not aware of any reason why one of those governors could not be used as default. My hardware doesn't work properly with ondemand governor. I hear strange noises when frequency is changed. That doesn't mean it isn't working, though. I here weird noises if the cpu is clocked anywhere from 333MHz to 1GHz (sounds like an RD-D2 beeping noises in ultra high pitch?) William Heimbigner [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: cpufreq default governor
On 24/04/07, William Heimbigner [EMAIL PROTECTED] wrote: On Tue, 24 Apr 2007, Michal Piotrowski wrote: Hi William, On 24/04/07, William Heimbigner [EMAIL PROTECTED] wrote: Question: is there some reason that kconfig does not allow for default governors of conservative/ondemand/powersave? Performance? I'm not aware of any reason why one of those governors could not be used as default. My hardware doesn't work properly with ondemand governor. I hear strange noises when frequency is changed. That doesn't mean it isn't working, though. I didn't say that cpufreq ondemand is broken. It's a hardware problem. I here weird noises if the cpu is clocked anywhere from 333MHz to 1GHz (sounds like an RD-D2 beeping noises in ultra high pitch?) Yes, something like that. William Heimbigner [EMAIL PROTECTED] Regards, Michal -- Michal K. K. Piotrowski LTG - Linux Testers Group (PL) (http://www.stardust.webpages.pl/ltg/) LTG - Linux Testers Group (EN) (http://www.stardust.webpages.pl/linux_testers_group_en/) - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: cpufreq default governor
On Tue, 24 Apr 2007, Michal Piotrowski wrote: On 24/04/07, William Heimbigner [EMAIL PROTECTED] wrote: On Tue, 24 Apr 2007, Michal Piotrowski wrote: Hi William, On 24/04/07, William Heimbigner [EMAIL PROTECTED] wrote: Question: is there some reason that kconfig does not allow for default governors of conservative/ondemand/powersave? Performance? I'm not aware of any reason why one of those governors could not be used as default. My hardware doesn't work properly with ondemand governor. I hear strange noises when frequency is changed. That doesn't mean it isn't working, though. I didn't say that cpufreq ondemand is broken. It's a hardware problem. I here weird noises if the cpu is clocked anywhere from 333MHz to 1GHz (sounds like an RD-D2 beeping noises in ultra high pitch?) Yes, something like that. Is it actually not working though, even at the hardware level? To my knowledge those noises are normal, and aren't even signs of a harware problem. I believe it is the natural result of changing frequencies at any time. If you change frequencies, especially in the low end of available frequencies, you should hear a very brief noise. A governor such as ondemand, which is rapidly switching the frequency from say, 333 MHz to 2.66 GHz, is likely to make this much more noticable. William Heimbigner [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: cpufreq default governor
On 24/04/07, William Heimbigner [EMAIL PROTECTED] wrote: On Tue, 24 Apr 2007, Michal Piotrowski wrote: On 24/04/07, William Heimbigner [EMAIL PROTECTED] wrote: On Tue, 24 Apr 2007, Michal Piotrowski wrote: Hi William, On 24/04/07, William Heimbigner [EMAIL PROTECTED] wrote: Question: is there some reason that kconfig does not allow for default governors of conservative/ondemand/powersave? Performance? I'm not aware of any reason why one of those governors could not be used as default. My hardware doesn't work properly with ondemand governor. I hear strange noises when frequency is changed. That doesn't mean it isn't working, though. I didn't say that cpufreq ondemand is broken. It's a hardware problem. I here weird noises if the cpu is clocked anywhere from 333MHz to 1GHz (sounds like an RD-D2 beeping noises in ultra high pitch?) Yes, something like that. Is it actually not working though, even at the hardware level? It works, but for me this sounds are very weird ;) To my knowledge those noises are normal, and aren't even signs of a harware problem. I believe it is the natural result of changing frequencies at any time. If you change frequencies, especially in the low end of available frequencies, you should hear a very brief noise. A governor such as ondemand, which is rapidly switching the frequency from say, 333 MHz to 2.66 GHz, is likely to make this much more noticable. Ok, it might be normal behavior. I might be wrong, but IMO users prefer speed and no strange sounds as default setting. William Heimbigner [EMAIL PROTECTED] Regards, Michal -- Michal K. K. Piotrowski LTG - Linux Testers Group (PL) (http://www.stardust.webpages.pl/ltg/) LTG - Linux Testers Group (EN) (http://www.stardust.webpages.pl/linux_testers_group_en/) - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: cpufreq default governor
On Tue, 24 Apr 2007, Michal Piotrowski wrote: On 24/04/07, William Heimbigner [EMAIL PROTECTED] wrote: On Tue, 24 Apr 2007, Michal Piotrowski wrote: On 24/04/07, William Heimbigner [EMAIL PROTECTED] wrote: On Tue, 24 Apr 2007, Michal Piotrowski wrote: Hi William, On 24/04/07, William Heimbigner [EMAIL PROTECTED] wrote: Question: is there some reason that kconfig does not allow for default governors of conservative/ondemand/powersave? Performance? I'm not aware of any reason why one of those governors could not be used as default. My hardware doesn't work properly with ondemand governor. I hear strange noises when frequency is changed. That doesn't mean it isn't working, though. I didn't say that cpufreq ondemand is broken. It's a hardware problem. I here weird noises if the cpu is clocked anywhere from 333MHz to 1GHz (sounds like an RD-D2 beeping noises in ultra high pitch?) Yes, something like that. Is it actually not working though, even at the hardware level? It works, but for me this sounds are very weird ;) To my knowledge those noises are normal, and aren't even signs of a harware problem. I believe it is the natural result of changing frequencies at any time. If you change frequencies, especially in the low end of available frequencies, you should hear a very brief noise. A governor such as ondemand, which is rapidly switching the frequency from say, 333 MHz to 2.66 GHz, is likely to make this much more noticable. Ok, it might be normal behavior. I might be wrong, but IMO users prefer speed and no strange sounds as default setting. I agree! My suggestion, however, is that if they do want a different scheduler as the default, they can choose one. There are some cases in which this could be very useful. A couple examples would be the processor with poor cooling that overheats easily, or a laptop with a poor battery. However, on second thought with regards to Kconfig, would it be feasible to have performance always be the default, unless a cpufreqgov=conservative arguement was specified on the command line? This would be less susceptible to users complaining that their cpu is chirping all of a sudden. William Heimbigner [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: cpufreq default governor
On 24/04/07, William Heimbigner [EMAIL PROTECTED] wrote: On Tue, 24 Apr 2007, Michal Piotrowski wrote: On 24/04/07, William Heimbigner [EMAIL PROTECTED] wrote: On Tue, 24 Apr 2007, Michal Piotrowski wrote: On 24/04/07, William Heimbigner [EMAIL PROTECTED] wrote: On Tue, 24 Apr 2007, Michal Piotrowski wrote: Hi William, On 24/04/07, William Heimbigner [EMAIL PROTECTED] wrote: Question: is there some reason that kconfig does not allow for default governors of conservative/ondemand/powersave? Performance? I'm not aware of any reason why one of those governors could not be used as default. My hardware doesn't work properly with ondemand governor. I hear strange noises when frequency is changed. That doesn't mean it isn't working, though. I didn't say that cpufreq ondemand is broken. It's a hardware problem. I here weird noises if the cpu is clocked anywhere from 333MHz to 1GHz (sounds like an RD-D2 beeping noises in ultra high pitch?) Yes, something like that. Is it actually not working though, even at the hardware level? It works, but for me this sounds are very weird ;) To my knowledge those noises are normal, and aren't even signs of a harware problem. I believe it is the natural result of changing frequencies at any time. If you change frequencies, especially in the low end of available frequencies, you should hear a very brief noise. A governor such as ondemand, which is rapidly switching the frequency from say, 333 MHz to 2.66 GHz, is likely to make this much more noticable. Ok, it might be normal behavior. I might be wrong, but IMO users prefer speed and no strange sounds as default setting. I agree! My suggestion, however, is that if they do want a different scheduler as the default, they can choose one. There are some cases in which this could be very useful. A couple examples would be the processor with poor cooling that overheats easily, or a laptop with a poor battery. However, on second thought with regards to Kconfig, would it be feasible to have performance always be the default, unless a cpufreqgov=conservative arguement was specified on the command line? This would be less susceptible to users complaining that their cpu is chirping all of a sudden. I'm all for the ability to set the default to whatever governor the user wants. I _always_ run my laptops with the ondemand governor, my Pentium M-based PVR runs with ondemand too, and only my old P4 box doesn't because it's pointless. If you're running servers that _aren't_ going to be idle most of the time, then by all means set your default to performance, or just don't enable cpufreq at all, but give the rest of us the option. Particularily with laptops, I've always wanted the kernel to boot and immediately slow the CPU down, even if all I do is boot into single user mode, or even bypass init altogether. This will give best battery life and coolest operation out of the box without having to rely on userland whatsoever. I had an old laptop a while back that _would_ overheat and shutdown within a couple of minutes, even though idle, if booted to single user mode because the cpu freq wasn't slowed down. -- Ian Morgan - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
