Re: drivers/parport/parport_cs.c:147 parport_config() warn: inconsistent indenting

2021-04-10 Thread Joe Perches
On Sun, 2021-04-11 at 02:02 +0800, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 
> master
> head:   d4961772226de3b48a395a26c076d450d7044c76
> commit: decf26f6ec25dac868782dc1751623a87d147831 parport: Convert 
> printk(KERN_ to pr_(
> date:   12 months ago
> config: x86_64-randconfig-m001-20210410 (attached as .config)
> compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot 
> 
> smatch warnings:
> drivers/parport/parport_cs.c:147 parport_config() warn: inconsistent indenting

False positive.
The whole thing is inconsistently indented. 




drivers/parport/parport_cs.c:147 parport_config() warn: inconsistent indenting

2021-04-10 Thread kernel test robot
tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 
master
head:   d4961772226de3b48a395a26c076d450d7044c76
commit: decf26f6ec25dac868782dc1751623a87d147831 parport: Convert 
printk(KERN_ to pr_(
date:   12 months ago
config: x86_64-randconfig-m001-20210410 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot 

smatch warnings:
drivers/parport/parport_cs.c:147 parport_config() warn: inconsistent indenting

vim +147 drivers/parport/parport_cs.c

84e2d34004dcd0 Dominik Brodowski 2008-07-29  118  
15b99ac1729503 Dominik Brodowski 2006-03-31  119  static int 
parport_config(struct pcmcia_device *link)
^1da177e4c3f41 Linus Torvalds2005-04-16  120  {
^1da177e4c3f41 Linus Torvalds2005-04-16  121  parport_info_t *info = 
link->priv;
^1da177e4c3f41 Linus Torvalds2005-04-16  122  struct parport *p;
9b44de2015ff4a Dominik Brodowski 2009-10-24  123  int ret;
^1da177e4c3f41 Linus Torvalds2005-04-16  124  
9b44de2015ff4a Dominik Brodowski 2009-10-24  125  dev_dbg(&link->dev, 
"parport_config\n");
^1da177e4c3f41 Linus Torvalds2005-04-16  126  
00990e7ce0b0e5 Dominik Brodowski 2010-07-30  127  if (epp_mode)
00990e7ce0b0e5 Dominik Brodowski 2010-07-30  128link->config_index 
|= FORCE_EPP_MODE;
00990e7ce0b0e5 Dominik Brodowski 2010-07-30  129  
9b44de2015ff4a Dominik Brodowski 2009-10-24  130  ret = 
pcmcia_loop_config(link, parport_config_check, NULL);
9b44de2015ff4a Dominik Brodowski 2009-10-24  131  if (ret)
84e2d34004dcd0 Dominik Brodowski 2008-07-29  132goto failed;
^1da177e4c3f41 Linus Torvalds2005-04-16  133  
eb14120f743d29 Dominik Brodowski 2010-03-07  134  if (!link->irq)
9b44de2015ff4a Dominik Brodowski 2009-10-24  135goto failed;
1ac71e5a35eebe Dominik Brodowski 2010-07-29  136  ret = 
pcmcia_enable_device(link);
9b44de2015ff4a Dominik Brodowski 2009-10-24  137  if (ret)
9b44de2015ff4a Dominik Brodowski 2009-10-24  138goto failed;
^1da177e4c3f41 Linus Torvalds2005-04-16  139  
9a017a910346af Dominik Brodowski 2010-07-24  140  p = 
parport_pc_probe_port(link->resource[0]->start,
9a017a910346af Dominik Brodowski 2010-07-24  141  
link->resource[1]->start,
eb14120f743d29 Dominik Brodowski 2010-03-07  142  
link->irq, PARPORT_DMA_NONE,
51dcdfec6a274a Alan Cox  2009-04-07  143  
&link->dev, IRQF_SHARED);
^1da177e4c3f41 Linus Torvalds2005-04-16  144  if (p == NULL) {
decf26f6ec25da Joe Perches   2020-04-03  145
pr_notice("parport_cs: parport_pc_probe_port() at 0x%3x, irq %u failed\n",
decf26f6ec25da Joe Perches   2020-04-03  146  (unsigned 
int)link->resource[0]->start, link->irq);
^1da177e4c3f41 Linus Torvalds2005-04-16 @147goto failed;
^1da177e4c3f41 Linus Torvalds2005-04-16  148  }
^1da177e4c3f41 Linus Torvalds2005-04-16  149  
^1da177e4c3f41 Linus Torvalds2005-04-16  150  p->modes |= 
PARPORT_MODE_PCSPP;
^1da177e4c3f41 Linus Torvalds2005-04-16  151  if (epp_mode)
^1da177e4c3f41 Linus Torvalds2005-04-16  152p->modes |= 
PARPORT_MODE_TRISTATE | PARPORT_MODE_EPP;
^1da177e4c3f41 Linus Torvalds2005-04-16  153  info->ndev = 1;
^1da177e4c3f41 Linus Torvalds2005-04-16  154  info->port = p;
^1da177e4c3f41 Linus Torvalds2005-04-16  155  
15b99ac1729503 Dominik Brodowski 2006-03-31  156  return 0;
^1da177e4c3f41 Linus Torvalds2005-04-16  157  
^1da177e4c3f41 Linus Torvalds2005-04-16  158  failed:
^1da177e4c3f41 Linus Torvalds2005-04-16  159
parport_cs_release(link);
21c75ad65f8e52 YueHaibing2019-03-21  160kfree(link->priv);
15b99ac1729503 Dominik Brodowski 2006-03-31  161return -ENODEV;
^1da177e4c3f41 Linus Torvalds2005-04-16  162  } /* parport_config */
^1da177e4c3f41 Linus Torvalds2005-04-16  163  

:: The code at line 147 was first introduced by commit
:: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2

:: TO: Linus Torvalds 
:: CC: Linus Torvalds 

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org


.config.gz
Description: application/gzip