Re: general protection fault in rose_send_frame
On Sun, Dec 20, 2020 at 2:27 PM syzbot wrote: > > syzbot suspects this issue was fixed by commit: > > commit 3b3fd068c56e3fbea30090859216a368398e39bf > Author: Anmol Karn > Date: Thu Nov 19 19:10:43 2020 + > > rose: Fix Null pointer dereference in rose_send_frame() > > bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=139e2b9b50 > start commit: 23ee3e4e Merge tag 'pci-v5.8-fixes-2' of git://git.kernel... > git tree: upstream > kernel config: https://syzkaller.appspot.com/x/.config?x=f87a5e4232fdb267 > dashboard link: https://syzkaller.appspot.com/bug?extid=7078ae989d857fe17988 > syz repro: https://syzkaller.appspot.com/x/repro.syz?x=157e896490 > C reproducer: https://syzkaller.appspot.com/x/repro.c?x=10046c5490 > > If the result looks correct, please mark the issue as fixed by replying with: > > #syz fix: rose: Fix Null pointer dereference in rose_send_frame() > > For information about bisection process see: https://goo.gl/tpsmEJ#bisection #syz fix: rose: Fix Null pointer dereference in rose_send_frame()
Re: general protection fault in rose_send_frame
syzbot suspects this issue was fixed by commit: commit 3b3fd068c56e3fbea30090859216a368398e39bf Author: Anmol Karn Date: Thu Nov 19 19:10:43 2020 + rose: Fix Null pointer dereference in rose_send_frame() bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=139e2b9b50 start commit: 23ee3e4e Merge tag 'pci-v5.8-fixes-2' of git://git.kernel... git tree: upstream kernel config: https://syzkaller.appspot.com/x/.config?x=f87a5e4232fdb267 dashboard link: https://syzkaller.appspot.com/bug?extid=7078ae989d857fe17988 syz repro: https://syzkaller.appspot.com/x/repro.syz?x=157e896490 C reproducer: https://syzkaller.appspot.com/x/repro.c?x=10046c5490 If the result looks correct, please mark the issue as fixed by replying with: #syz fix: rose: Fix Null pointer dereference in rose_send_frame() For information about bisection process see: https://goo.gl/tpsmEJ#bisection
Re: general protection fault in rose_send_frame
syzbot has found a reproducer for the following crash on: HEAD commit:7a25c6c0aac8 rocker: Add missing break for PRE_BRIDGE_FLAGS git tree: net-next console output: https://syzkaller.appspot.com/x/log.txt?x=104002d8c0 kernel config: https://syzkaller.appspot.com/x/.config?x=58cb9d752ba5f3e0 dashboard link: https://syzkaller.appspot.com/bug?extid=7078ae989d857fe17988 compiler: gcc (GCC) 9.0.0 20181231 (experimental) syz repro: https://syzkaller.appspot.com/x/repro.syz?x=1224c304c0 C reproducer: https://syzkaller.appspot.com/x/repro.c?x=151824f8c0 IMPORTANT: if you fix the bug, please add the following tag to the commit: Reported-by: syzbot+7078ae989d857fe17...@syzkaller.appspotmail.com IPv6: ADDRCONF(NETDEV_CHANGE): hsr_slave_1: link becomes ready 8021q: adding VLAN 0 to HW filter on device batadv0 IPv6: ADDRCONF(NETDEV_CHANGE): rose0: link becomes ready kasan: CONFIG_KASAN_INLINE enabled kasan: GPF could be caused by NULL-ptr deref or user memory access general protection fault: [#1] PREEMPT SMP KASAN CPU: 0 PID: 0 Comm: swapper/0 Not tainted 5.0.0-rc7+ #76 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 RIP: 0010:rose_send_frame+0x1a8/0x280 net/rose/rose_link.c:104 Code: c1 ea 03 80 3c 02 00 0f 85 8d 00 00 00 48 b8 00 00 00 00 00 fc ff df 4c 8b 63 20 49 8d bc 24 58 03 00 00 48 89 fa 48 c1 ea 03 <80> 3c 02 00 75 7e 49 8b 94 24 58 03 00 00 e9 b8 fe ff ff e8 f0 53 RSP: 0018:8880ae807ae8 EFLAGS: 00010202 RAX: dc00 RBX: 88809aa1fa00 RCX: 86378efb RDX: 006b RSI: 8637902c RDI: 0358 RBP: 8880ae807b18 R08: 8887dec0 R09: ed101263146d R10: ed101263146c R11: 88809318a363 R12: R13: 0078 R14: 0005 R15: 8880a4f6fbc0 FS: () GS:8880ae80() knlGS: CS: 0010 DS: ES: CR0: 80050033 CR2: 7f23b3e4ee78 CR3: 9eef3000 CR4: 001406f0 DR0: DR1: DR2: DR3: DR6: fffe0ff0 DR7: 0400 Call Trace: rose_transmit_clear_request+0x1de/0x2a0 net/rose/rose_link.c:258 rose_rx_call_request+0x4ea/0x1990 net/rose/af_rose.c:1001 rose_loopback_timer+0x26a/0x3f0 net/rose/rose_loopback.c:100 call_timer_fn+0x190/0x720 kernel/time/timer.c:1325 expire_timers kernel/time/timer.c:1362 [inline] __run_timers kernel/time/timer.c:1681 [inline] __run_timers kernel/time/timer.c:1649 [inline] run_timer_softirq+0x652/0x1700 kernel/time/timer.c:1694 __do_softirq+0x266/0x95a kernel/softirq.c:292 invoke_softirq kernel/softirq.c:373 [inline] irq_exit+0x180/0x1d0 kernel/softirq.c:413 exiting_irq arch/x86/include/asm/apic.h:536 [inline] smp_apic_timer_interrupt+0x14a/0x570 arch/x86/kernel/apic/apic.c:1062 apic_timer_interrupt+0xf/0x20 arch/x86/entry/entry_64.S:807 RIP: 0010:native_safe_halt+0x2/0x10 arch/x86/include/asm/irqflags.h:58 Code: ff ff ff 48 89 c7 48 89 45 d8 e8 59 6c a1 fa 48 8b 45 d8 e9 ce fe ff ff 48 89 df e8 48 6c a1 fa eb 82 90 90 90 90 90 90 fb f4 0f 1f 00 66 2e 0f 1f 84 00 00 00 00 00 f4 c3 90 90 90 90 90 90 RSP: 0018:88807d08 EFLAGS: 0286 ORIG_RAX: ff13 RAX: 11125061 RBX: 8887dec0 RCX: RDX: dc00 RSI: 0001 RDI: 8887e73c RBP: 88807d38 R08: 8887dec0 R09: R10: R11: R12: R13: 889282f8 R14: R15: arch_cpu_idle+0x10/0x20 arch/x86/kernel/process.c:555 default_idle_call+0x36/0x90 kernel/sched/idle.c:93 cpuidle_idle_call kernel/sched/idle.c:153 [inline] do_idle+0x386/0x570 kernel/sched/idle.c:262 cpu_startup_entry+0x1b/0x20 kernel/sched/idle.c:353 rest_init+0x245/0x37b init/main.c:442 arch_call_rest_init+0xe/0x1b start_kernel+0x803/0x83c init/main.c:739 x86_64_start_reservations+0x29/0x2b arch/x86/kernel/head64.c:470 x86_64_start_kernel+0x77/0x7b arch/x86/kernel/head64.c:451 secondary_startup_64+0xa4/0xb0 arch/x86/kernel/head_64.S:243 Modules linked in: ---[ end trace 8f29030702ddb052 ]--- RIP: 0010:rose_send_frame+0x1a8/0x280 net/rose/rose_link.c:104 Code: c1 ea 03 80 3c 02 00 0f 85 8d 00 00 00 48 b8 00 00 00 00 00 fc ff df 4c 8b 63 20 49 8d bc 24 58 03 00 00 48 89 fa 48 c1 ea 03 <80> 3c 02 00 75 7e 49 8b 94 24 58 03 00 00 e9 b8 fe ff ff e8 f0 53 RSP: 0018:8880ae807ae8 EFLAGS: 00010202 RAX: dc00 RBX: 88809aa1fa00 RCX: 86378efb RDX: 006b RSI: 8637902c RDI: 0358 RBP: 8880ae807b18 R08: 8887dec0 R09: ed101263146d R10: ed101263146c R11: 88809318a363 R12: R13: 0078 R14: 0005 R15: 8880a4f6fbc0 FS: () GS:8880ae80() knlGS: CS: 0010 DS: ES: CR0:
Re: general protection fault in rose_send_frame
syzbot has found a reproducer for the following crash on:
HEAD commit:9fb20801dab4 net: Fix ip_mc_{dec,inc}_group allocation con..
git tree: net-next
console output: https://syzkaller.appspot.com/x/log.txt?x=17530a0f40
kernel config: https://syzkaller.appspot.com/x/.config?x=33ad02b9305759c3
dashboard link: https://syzkaller.appspot.com/bug?extid=7078ae989d857fe17988
compiler: gcc (GCC) 9.0.0 20181231 (experimental)
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=148b35f8c0
IMPORTANT: if you fix the bug, please add the following tag to the commit:
Reported-by: syzbot+7078ae989d857fe17...@syzkaller.appspotmail.com
8021q: adding VLAN 0 to HW filter on device batadv0
device rose0 entered promiscuous mode
IPv6: ADDRCONF(NETDEV_CHANGE): rose0: link becomes ready
kasan: CONFIG_KASAN_INLINE enabled
kasan: GPF could be caused by NULL-ptr deref or user memory access
general protection fault: [#1] PREEMPT SMP KASAN
CPU: 1 PID: 7801 Comm: udevd Not tainted 5.0.0-rc4+ #44
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS
Google 01/01/2011
RIP: 0010:rose_send_frame+0x1a8/0x280 net/rose/rose_link.c:104
Code: c1 ea 03 80 3c 02 00 0f 85 8d 00 00 00 48 b8 00 00 00 00 00 fc ff df
4c 8b 63 20 49 8d bc 24 58 03 00 00 48 89 fa 48 c1 ea 03 <80> 3c 02 00 75
7e 49 8b 94 24 58 03 00 00 e9 b8 fe ff ff e8 60 cd
RSP: :8880ae907ae8 EFLAGS: 00010202
RAX: dc00 RBX: 88809a954500 RCX: 86360ccb
RDX: 006b RSI: 86360dfc RDI: 0358
RBP: 8880ae907b18 R08: 888094b50080 R09: ed10146ad41d
R10: ed10146ad41c R11: 8880a356a0e3 R12:
R13: 0078 R14: 0005 R15: 8880a886acc0
FS: 7f75710e57a0() GS:8880ae90() knlGS:
CS: 0010 DS: ES: CR0: 80050033
CR2: 7f7570790590 CR3: 9fb95000 CR4: 001406e0
DR0: DR1: DR2:
DR3: DR6: fffe0ff0 DR7: 0400
Call Trace:
rose_transmit_clear_request+0x1de/0x2a0 net/rose/rose_link.c:258
rose_rx_call_request+0x4ea/0x1990 net/rose/af_rose.c:999
rose_loopback_timer+0x26a/0x3f0 net/rose/rose_loopback.c:100
call_timer_fn+0x190/0x720 kernel/time/timer.c:1325
expire_timers kernel/time/timer.c:1362 [inline]
__run_timers kernel/time/timer.c:1681 [inline]
__run_timers kernel/time/timer.c:1649 [inline]
run_timer_softirq+0x652/0x1700 kernel/time/timer.c:1694
__do_softirq+0x266/0x95a kernel/softirq.c:292
invoke_softirq kernel/softirq.c:373 [inline]
irq_exit+0x180/0x1d0 kernel/softirq.c:413
exiting_irq arch/x86/include/asm/apic.h:536 [inline]
smp_apic_timer_interrupt+0x14a/0x570 arch/x86/kernel/apic/apic.c:1062
apic_timer_interrupt+0xf/0x20 arch/x86/entry/entry_64.S:807
RIP: 0010:__sanitizer_cov_trace_const_cmp1+0x1/0x20 kernel/kcov.c:174
Code: c3 0f 1f 84 00 00 00 00 00 55 48 89 f2 48 89 fe bf 06 00 00 00 48 89
e5 48 8b 4d 08 e8 18 ff ff ff 5d c3 66 0f 1f 44 00 00 55 <40> 0f b6 d6 40
0f b6 f7 bf 01 00 00 00 48 89 e5 48 8b 4d 08 e8 f6
RSP: :8880a806fb90 EFLAGS: 0246 ORIG_RAX: ff13
RAX: 888094b50080 RBX: 8880a806fca8 RCX: 818a7cde
RDX: RSI: RDI:
RBP: 8880a806fcd0 R08: 888094b50080 R09: 0004
R10: ed1015d25bc7 R11: 8880ae92de3b R12: ea25f980
R13: 88809b8a87b8 R14: 0001 R15: 0084
do_fault_around mm/memory.c:3391 [inline]
do_read_fault mm/memory.c:3425 [inline]
do_fault mm/memory.c:3556 [inline]
handle_pte_fault mm/memory.c:3787 [inline]
__handle_mm_fault+0x3226/0x3f20 mm/memory.c:3911
handle_mm_fault+0x43f/0xb30 mm/memory.c:3948
do_user_addr_fault arch/x86/mm/fault.c:1475 [inline]
__do_page_fault+0x5da/0xd60 arch/x86/mm/fault.c:1541
do_page_fault+0x71/0x581 arch/x86/mm/fault.c:1572
page_fault+0x1e/0x30 arch/x86/entry/entry_64.S:1143
RIP: 0033:0x7f7570790590
Code: 00 74 0f f0 ff 0d ac 41 31 00 0f 85 d3 6b 00 00 eb 0c ff 0d 9e 41 31
00 0f 85 c5 6b 00 00 f3 c3 66 2e 0f 1f 84 00 00 00 00 00 <8b> 0d 4e 1b 31
00 85 c9 7e 6c 48 8b 15 97 41 31 00 48 8b 05 78 17
RSP: 002b:7ffec2e21978 EFLAGS: 00010206
RAX: 7f7570aa4740 RBX: 7ffec2e219a0 RCX: 7f75705162a0
RDX: 7f7570790590 RSI: 7f7570512240 RDI: 7f7570aa26c0
RBP: 7ffec2e219e0 R08: 1ce4 R09: 1ce4
R10: 7f7570512240 R11: 7f75710e57a0 R12:
R13: R14: 7f75710f0040 R15: 0005
Modules linked in:
---[ end trace 19f243a97b44aa5b ]---
RIP: 0010:rose_send_frame+0x1a8/0x280 net/rose/rose_link.c:104
Code: c1 ea 03 80 3c 02 00 0f 85 8d 00 00 00 48 b8 00 00 00 00 00 fc ff df
4c 8b 63 20 49 8d bc 24 58 03 00 00 48 89 fa 48 c1 ea 03 <80> 3c 02 00 75
7e 49 8b 94 24 58 03 00 00 e9 b8 fe ff ff e8 60 cd
RSP: :8880ae907ae8 EFLAGS: 00010202
RAX:
general protection fault in rose_send_frame
Hello, syzbot found the following crash on: HEAD commit:b71acb0e3721 Merge branch 'linus' of git://git.kernel.org/.. git tree: net-next console output: https://syzkaller.appspot.com/x/log.txt?x=13a9acf740 kernel config: https://syzkaller.appspot.com/x/.config?x=b03c5892bb940c76 dashboard link: https://syzkaller.appspot.com/bug?extid=7078ae989d857fe17988 compiler: gcc (GCC) 9.0.0 20181231 (experimental) Unfortunately, I don't have any reproducer for this crash yet. IMPORTANT: if you fix the bug, please add the following tag to the commit: Reported-by: syzbot+7078ae989d857fe17...@syzkaller.appspotmail.com kasan: CONFIG_KASAN_INLINE enabled kasan: GPF could be caused by NULL-ptr deref or user memory access general protection fault: [#1] PREEMPT SMP KASAN CPU: 1 PID: 10446 Comm: syz-executor4 Not tainted 4.20.0+ #3 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 RIP: 0010:rose_send_frame+0x1a8/0x280 net/rose/rose_link.c:104 Code: c1 ea 03 80 3c 02 00 0f 85 8d 00 00 00 48 b8 00 00 00 00 00 fc ff df 4c 8b 63 20 49 8d bc 24 58 03 00 00 48 89 fa 48 c1 ea 03 <80> 3c 02 00 75 7e 49 8b 94 24 58 03 00 00 e9 b8 fe ff ff e8 d0 e3 RSP: 0018:8880ae707780 EFLAGS: 00010202 RAX: dc00 RBX: 8882167d4540 RCX: 8703c0bb RDX: 006b RSI: 8703c1ec RDI: 0358 kobject: 'loop1' (8f9686c7): kobject_uevent_env RBP: 8880ae7077b0 R08: 888089dc0480 R09: ed1014360d0d kobject: 'loop1' (8f9686c7): fill_kobj_path: path = '/devices/virtual/block/loop1' R10: ed1014360d0c R11: 8880a1b06863 R12: R13: 0078 R14: 0005 R15: 888096c38a40 FS: 7fb08678e700() GS:8880ae70() knlGS: CS: 0010 DS: ES: CR0: 80050033 CR2: 00625208 CR3: 645e CR4: 001406e0 DR0: DR1: DR2: DR3: DR6: fffe0ff0 DR7: 0400 Call Trace: rose_transmit_clear_request+0x1de/0x2a0 net/rose/rose_link.c:258 rose_rx_call_request+0x4f8/0x1c40 net/rose/af_rose.c:999 rose_loopback_timer+0x26a/0x3f0 net/rose/rose_loopback.c:100 call_timer_fn+0x254/0x900 kernel/time/timer.c:1325 expire_timers kernel/time/timer.c:1362 [inline] __run_timers+0x6fc/0xd50 kernel/time/timer.c:1681 run_timer_softirq+0x52/0xb0 kernel/time/timer.c:1694 __do_softirq+0x30b/0xb11 kernel/softirq.c:292 invoke_softirq kernel/softirq.c:373 [inline] irq_exit+0x180/0x1d0 kernel/softirq.c:413 exiting_irq arch/x86/include/asm/apic.h:536 [inline] smp_apic_timer_interrupt+0x1b7/0x760 arch/x86/kernel/apic/apic.c:1062 apic_timer_interrupt+0xf/0x20 arch/x86/entry/entry_64.S:807 RIP: 0010:arch_local_irq_restore arch/x86/include/asm/paravirt.h:766 [inline] RIP: 0010:lock_is_held_type+0x17e/0x210 kernel/locking/lockdep.c:3881 Code: 00 00 00 fc ff df 41 c7 85 7c 08 00 00 00 00 00 00 48 c1 e8 03 80 3c 10 00 75 63 48 83 3d b9 0a 2f 08 00 74 30 48 89 df 57 9d <0f> 1f 44 00 00 48 83 c4 08 44 89 e0 5b 41 5c 41 5d 5d c3 48 83 c4 RSP: 0018:888065f8eea8 EFLAGS: 0282 ORIG_RAX: ff13 RAX: 11324a06 RBX: 0282 RCX: dc00 RDX: dc00 RSI: RDI: 0282 RBP: 888065f8eec8 R08: 888089dc0480 R09: ed100cbf1df3 R10: ed100cbf1df2 R11: 0003 R12: R13: 888089dc0480 R14: dc00 R15: ea0001de25c0 lock_is_held include/linux/lockdep.h:337 [inline] xa_entry include/linux/xarray.h:902 [inline] xas_reload include/linux/xarray.h:1250 [inline] find_get_pages_range_tag+0x1166/0x1540 mm/filemap.c:1848 pagevec_lookup_range_tag+0x40/0x80 mm/swap.c:1005 mpage_prepare_extent_to_map+0x402/0x1950 fs/ext4/inode.c:2661 ext4_writepages+0x1a5e/0x4180 fs/ext4/inode.c:2881 do_writepages+0x99/0x1a0 mm/page-writeback.c:2328 __filemap_fdatawrite_range+0x352/0x470 mm/filemap.c:411 filemap_write_and_wait_range mm/filemap.c:633 [inline] filemap_write_and_wait_range+0x4b/0xd0 mm/filemap.c:627 __generic_file_write_iter+0x4ea/0x630 mm/filemap.c:3251 ext4_file_write_iter+0x37a/0x1410 fs/ext4/file.c:266 call_write_iter include/linux/fs.h:1857 [inline] new_sync_write fs/read_write.c:474 [inline] __vfs_write+0x6e5/0xa80 fs/read_write.c:487 vfs_write+0x20c/0x560 fs/read_write.c:549 ksys_write+0x105/0x260 fs/read_write.c:598 __do_sys_write fs/read_write.c:610 [inline] __se_sys_write fs/read_write.c:607 [inline] __x64_sys_write+0x73/0xb0 fs/read_write.c:607 do_syscall_64+0x1a3/0x800 arch/x86/entry/common.c:290 entry_SYSCALL_64_after_hwframe+0x49/0xbe RIP: 0033:0x457ec9 Code: 6d b7 fb ff c3 66 2e 0f 1f 84 00 00 00 00 00 66 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 0f 83 3b b7 fb ff c3 66 2e 0f 1f 84 00 00 00 00 RSP: 002b:7fb08678dc78 EFLAGS: 0246 ORIG_RAX:
