Re: easy alsa patches for the stable kernel? (was: Re: hda_intel : Patch + Regression in 2.6.18 -> 2.6.22)
At Fri, 07 Sep 2007 14:04:01 +0200,
Thorsten Leemhuis wrote:
>
> On 07.09.2007 12:21, Takashi Iwai wrote:
> > At Fri, 07 Sep 2007 10:22:27 +0200,
> > Romano Giannetti wrote:
> >> Takashi: good news!
> >>
> >> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> >> index 3557865..496d119 100644
> >> --- a/sound/pci/hda/patch_realtek.c
> >> +++ b/sound/pci/hda/patch_realtek.c
> >> @@ -9044,6 +9044,7 @@ static const char *alc268_models[ALC268_MODEL_LAST]
> >> = {
> >> static struct snd_pci_quirk alc268_cfg_tbl[] = {
> >> SND_PCI_QUIRK(0x1043, 0x1205, "ASUS W7J", ALC268_3ST),
> >> SND_PCI_QUIRK(0x1179, 0xff10, "TOSHIBA A205", ALC268_TOSHIBA),
> >> + SND_PCI_QUIRK(0x1179, 0xff50, "TOSHIBA A305", ALC268_TOSHIBA),
> >> SND_PCI_QUIRK(0x103c, 0x30cc, "TOSHIBA", ALC268_TOSHIBA),
> >> SND_PCI_QUIRK(0x1025, 0x0126, "Acer", ALC268_ACER),
> >> SND_PCI_QUIRK(0x1025, 0x0130, "Acer Extensa 5210", ALC268_ACER),
> >
> > Ah good. I added it to ALSA HG tree now.
>
> Just wondering: should easy-and-obvious and less-risky patches like this
> one be send to the stable-kernel-maintainers in parallel to adding them
> to the HG-Tree (or shortly afterwards)? It could safe users lots of
> trouble if such improvements make it quickly into production-ready
> kernel-releases (and from there they might even find their way into some
> distribution kernels quickly). Hardware then would "just work".
Well, this patch is defenitely not for 2.6.23 or stable kernel.
It's for 2.6.24.
> Sure, before the stable-maintainer will take such patches they needs to
> be added to linus git-tree beforehand as well. And sure, patches like
> the one above are not fixing a regression (at least in this case if I
> read the thread correctly; the old subject thus is misleading afaics),
> but it's similar to a new PCI-ID that gets added to a existing driver --
> and that's done now in the stable-series afaics (¹).
>
> The alsa-maintainers seem to be in the best position to do this, but it
> seems they rarely do it. I for example was hit by a regression (sound
> worked in 2.6.20 and broke afterwards; was fixed in 2.6.23-git by the
> following patch in case anybody is wondering:
> http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=a4eed138add1018846d17e813560b0c7c0ae8e01
> ), but the alsa-developers did not submit it for stable afaics. Sure, I
> could do that myself, but as I said: the alsa-maintainers really have
> the best overview over the alsa-patches and should know which patches
> are safe to apply for older kernels.
I occasionally do but sometimes forget. The problem is often that I
want first the merge to Linus tree, and then I forget to submit to
stable tree when the merge takes long time in the end. (Ther merge of
alsa.git is too spotty, and that's another big problem for me. In
short, I do NOT maintain alsa.git tree at all...)
Another problem I see is that we have little chance for testing the
target patches with stable kernels. Even it looks OK and works for
the later kernels, it often doesn't work or break magically with the
older kernels. Usually, I have no affected hardware, and bug
reporters test only with the recent version (partly because developers
ask first to try the latest version -- if it works, why to downgrade
again?)
thanks,
Takashi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
easy alsa patches for the stable kernel? (was: Re: hda_intel : Patch + Regression in 2.6.18 -> 2.6.22)
On 07.09.2007 12:21, Takashi Iwai wrote:
> At Fri, 07 Sep 2007 10:22:27 +0200,
> Romano Giannetti wrote:
>> Takashi: good news!
>>
>> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
>> index 3557865..496d119 100644
>> --- a/sound/pci/hda/patch_realtek.c
>> +++ b/sound/pci/hda/patch_realtek.c
>> @@ -9044,6 +9044,7 @@ static const char *alc268_models[ALC268_MODEL_LAST] = {
>> static struct snd_pci_quirk alc268_cfg_tbl[] = {
>> SND_PCI_QUIRK(0x1043, 0x1205, "ASUS W7J", ALC268_3ST),
>> SND_PCI_QUIRK(0x1179, 0xff10, "TOSHIBA A205", ALC268_TOSHIBA),
>> + SND_PCI_QUIRK(0x1179, 0xff50, "TOSHIBA A305", ALC268_TOSHIBA),
>> SND_PCI_QUIRK(0x103c, 0x30cc, "TOSHIBA", ALC268_TOSHIBA),
>> SND_PCI_QUIRK(0x1025, 0x0126, "Acer", ALC268_ACER),
>> SND_PCI_QUIRK(0x1025, 0x0130, "Acer Extensa 5210", ALC268_ACER),
>
> Ah good. I added it to ALSA HG tree now.
Just wondering: should easy-and-obvious and less-risky patches like this
one be send to the stable-kernel-maintainers in parallel to adding them
to the HG-Tree (or shortly afterwards)? It could safe users lots of
trouble if such improvements make it quickly into production-ready
kernel-releases (and from there they might even find their way into some
distribution kernels quickly). Hardware then would "just work".
Sure, before the stable-maintainer will take such patches they needs to
be added to linus git-tree beforehand as well. And sure, patches like
the one above are not fixing a regression (at least in this case if I
read the thread correctly; the old subject thus is misleading afaics),
but it's similar to a new PCI-ID that gets added to a existing driver --
and that's done now in the stable-series afaics (¹).
The alsa-maintainers seem to be in the best position to do this, but it
seems they rarely do it. I for example was hit by a regression (sound
worked in 2.6.20 and broke afterwards; was fixed in 2.6.23-git by the
following patch in case anybody is wondering:
http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=a4eed138add1018846d17e813560b0c7c0ae8e01
), but the alsa-developers did not submit it for stable afaics. Sure, I
could do that myself, but as I said: the alsa-maintainers really have
the best overview over the alsa-patches and should know which patches
are safe to apply for older kernels.
CU
knurd
(¹) -- see for example
http://git.kernel.org/?p=linux/kernel/git/stable/linux-2.6.22.y.git;a=commit;h=fd2efeae63567dde934bb54772bb1b991275b04a
or
http://git.kernel.org/?p=linux/kernel/git/stable/linux-2.6.22.y.git;a=commit;h=3443d563dc53875b15d919c4bece391f1ffd4776
which made in into
http://kernel.org/pub/linux/kernel/v2.6/ChangeLog-2.6.22.3
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: hda_intel : Patch + Regression in 2.6.18 -> 2.6.22
At Fri, 07 Sep 2007 10:22:27 +0200,
Romano Giannetti wrote:
>
> Takashi: good news!
>
> On Thu, 2007-09-06 at 23:48 +0200, Romano Giannetti wrote:
> > On Thu, 2007-09-06 at 17:25 +0200, Takashi Iwai wrote:
> > > At Thu, 06 Sep 2007 17:09:50 +0200,
> > > Romano Giannetti wrote:
> > > >
> > > >
> > > > Just one hand up: I haven't tested the patch pointed to by Andrew, will
> > > > do asap, but it seems that contains the changes from
> > > >
> > > > https://bugtrack.alsa-project.org/alsa-bug/view.php?id=3104
> > > >
> > > > which are needed to have sound at all on my toshiba (although with some
> > > > remaining problems).
> > >
> > > No, it's a different one. This Toshiba model is still not supported
> > > well. The patch in mm tree is basically equivalent with the latest
> > > ALSA HG tree, so if you tested ALSA HG version (or daily snapshot),
> > > it should be same.
> >
> > Unfortunately you're right. The patch I posted to the alsa bugtrack,
> > extracted from the pshou files, works for me. The alsa-git patch gives
> > me a system without sound.
>
> I stand corrected: by loading snd-hda-intel with model=toshiba sound
> works (output and input) with my toshiba A305. So, I think that the only
> patch needed to make it works out of the box on top of current alsa-git
> is:
>
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 3557865..496d119 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -9044,6 +9044,7 @@ static const char *alc268_models[ALC268_MODEL_LAST] = {
> static struct snd_pci_quirk alc268_cfg_tbl[] = {
> SND_PCI_QUIRK(0x1043, 0x1205, "ASUS W7J", ALC268_3ST),
> SND_PCI_QUIRK(0x1179, 0xff10, "TOSHIBA A205", ALC268_TOSHIBA),
> + SND_PCI_QUIRK(0x1179, 0xff50, "TOSHIBA A305", ALC268_TOSHIBA),
> SND_PCI_QUIRK(0x103c, 0x30cc, "TOSHIBA", ALC268_TOSHIBA),
> SND_PCI_QUIRK(0x1025, 0x0126, "Acer", ALC268_ACER),
> SND_PCI_QUIRK(0x1025, 0x0130, "Acer Extensa 5210", ALC268_ACER),
Ah good. I added it to ALSA HG tree now.
Thanks!
Takashi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: hda_intel : Patch + Regression in 2.6.18 -> 2.6.22
Takashi: good news!
On Thu, 2007-09-06 at 23:48 +0200, Romano Giannetti wrote:
> On Thu, 2007-09-06 at 17:25 +0200, Takashi Iwai wrote:
> > At Thu, 06 Sep 2007 17:09:50 +0200,
> > Romano Giannetti wrote:
> > >
> > >
> > > Just one hand up: I haven't tested the patch pointed to by Andrew, will
> > > do asap, but it seems that contains the changes from
> > >
> > > https://bugtrack.alsa-project.org/alsa-bug/view.php?id=3104
> > >
> > > which are needed to have sound at all on my toshiba (although with some
> > > remaining problems).
> >
> > No, it's a different one. This Toshiba model is still not supported
> > well. The patch in mm tree is basically equivalent with the latest
> > ALSA HG tree, so if you tested ALSA HG version (or daily snapshot),
> > it should be same.
>
> Unfortunately you're right. The patch I posted to the alsa bugtrack,
> extracted from the pshou files, works for me. The alsa-git patch gives
> me a system without sound.
I stand corrected: by loading snd-hda-intel with model=toshiba sound
works (output and input) with my toshiba A305. So, I think that the only
patch needed to make it works out of the box on top of current alsa-git
is:
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 3557865..496d119 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -9044,6 +9044,7 @@ static const char *alc268_models[ALC268_MODEL_LAST] = {
static struct snd_pci_quirk alc268_cfg_tbl[] = {
SND_PCI_QUIRK(0x1043, 0x1205, "ASUS W7J", ALC268_3ST),
SND_PCI_QUIRK(0x1179, 0xff10, "TOSHIBA A205", ALC268_TOSHIBA),
+ SND_PCI_QUIRK(0x1179, 0xff50, "TOSHIBA A305", ALC268_TOSHIBA),
SND_PCI_QUIRK(0x103c, 0x30cc, "TOSHIBA", ALC268_TOSHIBA),
SND_PCI_QUIRK(0x1025, 0x0126, "Acer", ALC268_ACER),
SND_PCI_QUIRK(0x1025, 0x0130, "Acer Extensa 5210", ALC268_ACER),
--
La presente comunicación tiene carácter confidencial y es para el exclusivo uso
del destinatario indicado en la misma. Si Ud. no es el destinatario indicado,
le informamos que cualquier forma de distribución, reproducción o uso de esta
comunicación y/o de la información contenida en la misma están estrictamente
prohibidos por la ley. Si Ud. ha recibido esta comunicación por error, por
favor, notifíquelo inmediatamente al remitente contestando a este mensaje y
proceda a continuación a destruirlo. Gracias por su colaboración.
This communication contains confidential information. It is for the exclusive
use of the intended addressee. If you are not the intended addressee, please
note that any form of distribution, copying or use of this communication or the
information in it is strictly prohibited by law. If you have received this
communication in error, please immediately notify the sender by reply e-mail
and destroy this message. Thank you for your cooperation.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: hda_intel : Patch + Regression in 2.6.18 -> 2.6.22
On Thu, 2007-09-06 at 17:25 +0200, Takashi Iwai wrote: > At Thu, 06 Sep 2007 17:09:50 +0200, > Romano Giannetti wrote: > > > > > > Just one hand up: I haven't tested the patch pointed to by Andrew, will > > do asap, but it seems that contains the changes from > > > > https://bugtrack.alsa-project.org/alsa-bug/view.php?id=3104 > > > > which are needed to have sound at all on my toshiba (although with some > > remaining problems). > > No, it's a different one. This Toshiba model is still not supported > well. The patch in mm tree is basically equivalent with the latest > ALSA HG tree, so if you tested ALSA HG version (or daily snapshot), > it should be same. Unfortunately you're right. The patch I posted to the alsa bugtrack, extracted from the pshou files, works for me. The alsa-git patch gives me a system without sound. > > I'm still waiting for a patch from pshou for the latest version, but > no reply yet. m here. I can try to "merge" pshou patch with the > alsa-git, but I'm not so confident about my understanding of the > thing... Thanks again Romano -- La presente comunicación tiene carácter confidencial y es para el exclusivo uso del destinatario indicado en la misma. Si Ud. no es el destinatario indicado, le informamos que cualquier forma de distribución, reproducción o uso de esta comunicación y/o de la información contenida en la misma están estrictamente prohibidos por la ley. Si Ud. ha recibido esta comunicación por error, por favor, notifíquelo inmediatamente al remitente contestando a este mensaje y proceda a continuación a destruirlo. Gracias por su colaboración. This communication contains confidential information. It is for the exclusive use of the intended addressee. If you are not the intended addressee, please note that any form of distribution, copying or use of this communication or the information in it is strictly prohibited by law. If you have received this communication in error, please immediately notify the sender by reply e-mail and destroy this message. Thank you for your cooperation. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: hda_intel : Patch + Regression in 2.6.18 -> 2.6.22
At Thu, 06 Sep 2007 17:09:50 +0200, Romano Giannetti wrote: > > On Wed, 2007-09-05 at 18:44 +0200, Takashi Iwai wrote: > > At Wed, 5 Sep 2007 09:16:33 -0700, > > Andrew Morton wrote: > > > > > > > On Wed, 05 Sep 2007 18:05:44 +0200 Takashi Iwai <[EMAIL PROTECTED]> > > > > wrote: > > > > Roger, could you try git-alsa patch in the latest mm together with > > > > model=acer-aspiore option? If it works, I can easily add your device > > > > ID to the table. > > > > > > http://userweb.kernel.org/~akpm/git-alsa.patch is a copy of the alsa git > > > tree as of two minutes ago. That applies against current Linus mainline, > > > but should apply OK on 2.6.23-rc5 as well. Please test that, thanks. > > > > > > Takashi, perhaps that is 2.6.23 material? > > > > The changes for Acer Aspire is quite big, surely not for 2.6.23. > > Let's fix in 2.6.24 in a better way than a temporary hack (that > > would work only in a very limited way). > > Just one hand up: I haven't tested the patch pointed to by Andrew, will > do asap, but it seems that contains the changes from > > https://bugtrack.alsa-project.org/alsa-bug/view.php?id=3104 > > which are needed to have sound at all on my toshiba (although with some > remaining problems). No, it's a different one. This Toshiba model is still not supported well. The patch in mm tree is basically equivalent with the latest ALSA HG tree, so if you tested ALSA HG version (or daily snapshot), it should be same. I'm still waiting for a patch from pshou for the latest version, but no reply yet. Takashi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: hda_intel : Patch + Regression in 2.6.18 -> 2.6.22
On Wed, 2007-09-05 at 18:44 +0200, Takashi Iwai wrote: > At Wed, 5 Sep 2007 09:16:33 -0700, > Andrew Morton wrote: > > > > > On Wed, 05 Sep 2007 18:05:44 +0200 Takashi Iwai <[EMAIL PROTECTED]> wrote: > > > Roger, could you try git-alsa patch in the latest mm together with > > > model=acer-aspiore option? If it works, I can easily add your device > > > ID to the table. > > > > http://userweb.kernel.org/~akpm/git-alsa.patch is a copy of the alsa git > > tree as of two minutes ago. That applies against current Linus mainline, > > but should apply OK on 2.6.23-rc5 as well. Please test that, thanks. > > > > Takashi, perhaps that is 2.6.23 material? > > The changes for Acer Aspire is quite big, surely not for 2.6.23. > Let's fix in 2.6.24 in a better way than a temporary hack (that > would work only in a very limited way). Just one hand up: I haven't tested the patch pointed to by Andrew, will do asap, but it seems that contains the changes from https://bugtrack.alsa-project.org/alsa-bug/view.php?id=3104 which are needed to have sound at all on my toshiba (although with some remaining problems). I am not able to say if it's .23 material or not, nor if it's a regression or not, being this a quite new laptop... but maybe it's better to have a release with some sound and then fix it properly after? Thanks for your hard work, Romano -- La presente comunicación tiene carácter confidencial y es para el exclusivo uso del destinatario indicado en la misma. Si Ud. no es el destinatario indicado, le informamos que cualquier forma de distribución, reproducción o uso de esta comunicación y/o de la información contenida en la misma están estrictamente prohibidos por la ley. Si Ud. ha recibido esta comunicación por error, por favor, notifíquelo inmediatamente al remitente contestando a este mensaje y proceda a continuación a destruirlo. Gracias por su colaboración. This communication contains confidential information. It is for the exclusive use of the intended addressee. If you are not the intended addressee, please note that any form of distribution, copying or use of this communication or the information in it is strictly prohibited by law. If you have received this communication in error, please immediately notify the sender by reply e-mail and destroy this message. Thank you for your cooperation. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: hda_intel : Patch + Regression in 2.6.18 -> 2.6.22
At Wed, 5 Sep 2007 18:01:31 +0100, Roger Gammans wrote: > > On Wed, Sep 05, 2007 at 06:46:57PM +0200, Takashi Iwai wrote: > > Great, then I'll add this entry to ALSA tree. > > It's Aspire 9303, right? > > That's what it says on the box. > > But it also says 9300 too, if I see a different 9300 I'll check > it pci devs, but there weren't any other 93xx models even listed at > our distributor the last time I looked. Well, I just want to be a bit more specific in the table entry. The model 9303 must be enough as the information (and it's correct, at least). Now I added the entry to the ALSA tree. Thanks, Takashi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: hda_intel : Patch + Regression in 2.6.18 -> 2.6.22
On Wed, Sep 05, 2007 at 06:46:57PM +0200, Takashi Iwai wrote: > Great, then I'll add this entry to ALSA tree. > It's Aspire 9303, right? That's what it says on the box. But it also says 9300 too, if I see a different 9300 I'll check it pci devs, but there weren't any other 93xx models even listed at our distributor the last time I looked. TTFN -- Roger. Home| http://www.sandman.uklinux.net/ Master of Peng Shui. (Ancient oriental art of Penguin Arranging) Work|Independent Sys Consultant | http://www.computer-surgery.co.uk/ New key Fpr: 72AF 0ACC 9A53 E59F B1B6 DC14 1983 A13E 5C3D 3CEB - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: hda_intel : Patch + Regression in 2.6.18 -> 2.6.22
At Wed, 5 Sep 2007 09:16:33 -0700, Andrew Morton wrote: > > > On Wed, 05 Sep 2007 18:05:44 +0200 Takashi Iwai <[EMAIL PROTECTED]> wrote: > > Roger, could you try git-alsa patch in the latest mm together with > > model=acer-aspiore option? If it works, I can easily add your device > > ID to the table. > > http://userweb.kernel.org/~akpm/git-alsa.patch is a copy of the alsa git > tree as of two minutes ago. That applies against current Linus mainline, > but should apply OK on 2.6.23-rc5 as well. Please test that, thanks. > > Takashi, perhaps that is 2.6.23 material? The changes for Acer Aspire is quite big, surely not for 2.6.23. Let's fix in 2.6.24 in a better way than a temporary hack (that would work only in a very limited way). Takashi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: hda_intel : Patch + Regression in 2.6.18 -> 2.6.22
At Wed, 5 Sep 2007 17:26:50 +0100, Roger Gammans wrote: > > Thanks for picking this up again Andew. > > On Wed, Sep 05, 2007 at 06:05:44PM +0200, Takashi Iwai wrote: > > The patch would definitely break many other machines, so no, it can't > > be applied as is. Note that there is an equivalent workaround by > > adding "model=auto" module option. > > Ah, I hadn't spotted that. > > > The support for Acer Aspire was already improved in mm tree. At > > least, we have the support for Aspire 9810 and co. If it's the > > compatible one, the chance is high. > > Yes, I played a little with that, looking back at what Ive got > here the following patch worked on what I pulled about > 2weeks ago byi:- > git pull git://git.kernel.org/pub/scm/linux/kernel/git/perex/alsa.git/ > > > > Roger, could you try git-alsa patch in the latest mm together with > > model=acer-aspiore option? If it works, I can easily add your device > > ID to the table. > > I assume youe think of somehting like this which I tried earlier - > but would have been wasier if I'd have known about the mode option.. > > SND_PCI_QUIRK(0x1462, 0xa422, "MSI", ALC883_TARGA_2ch_DIG), > SND_PCI_QUIRK(0x1025, 0x006c, "Acer Aspire 9810", ALC883_ACER_ASPIRE), > SND_PCI_QUIRK(0x1025, 0x0110, "Acer Aspire", ALC883_ACER_ASPIRE), > + SND_PCI_QUIRK(0x1025, 0x0112, "Acer Aspire", ALC883_ACER_ASPIRE), > SND_PCI_QUIRK(0x15d9, 0x8780, "Supermicro PDSBA", ALC883_3ST_6ch), > SND_PCI_QUIRK(0x161f, 0x2054, "Medion laptop", ALC883_MEDION), > > (Patch headers removed as patch manually editted I appeat to got onto some > on > branch mode with git and it producing odd patches (ones with '++' at the start > of some lines)) > > This does indeed work. I'm sorry I should have replied with this sooner, > buts since it appeared noone was listening... Great, then I'll add this entry to ALSA tree. It's Aspire 9303, right? thanks, Takashi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: hda_intel : Patch + Regression in 2.6.18 -> 2.6.22
Thanks for picking this up again Andew. On Wed, Sep 05, 2007 at 06:05:44PM +0200, Takashi Iwai wrote: > The patch would definitely break many other machines, so no, it can't > be applied as is. Note that there is an equivalent workaround by > adding "model=auto" module option. Ah, I hadn't spotted that. > The support for Acer Aspire was already improved in mm tree. At > least, we have the support for Aspire 9810 and co. If it's the > compatible one, the chance is high. Yes, I played a little with that, looking back at what Ive got here the following patch worked on what I pulled about 2weeks ago byi:- git pull git://git.kernel.org/pub/scm/linux/kernel/git/perex/alsa.git/ > Roger, could you try git-alsa patch in the latest mm together with > model=acer-aspiore option? If it works, I can easily add your device > ID to the table. I assume youe think of somehting like this which I tried earlier - but would have been wasier if I'd have known about the mode option.. SND_PCI_QUIRK(0x1462, 0xa422, "MSI", ALC883_TARGA_2ch_DIG), SND_PCI_QUIRK(0x1025, 0x006c, "Acer Aspire 9810", ALC883_ACER_ASPIRE), SND_PCI_QUIRK(0x1025, 0x0110, "Acer Aspire", ALC883_ACER_ASPIRE), + SND_PCI_QUIRK(0x1025, 0x0112, "Acer Aspire", ALC883_ACER_ASPIRE), SND_PCI_QUIRK(0x15d9, 0x8780, "Supermicro PDSBA", ALC883_3ST_6ch), SND_PCI_QUIRK(0x161f, 0x2054, "Medion laptop", ALC883_MEDION), (Patch headers removed as patch manually editted I appeat to got onto some on branch mode with git and it producing odd patches (ones with '++' at the start of some lines)) This does indeed work. I'm sorry I should have replied with this sooner, buts since it appeared noone was listening... TTFN -- Roger. Home| http://www.sandman.uklinux.net/ Master of Peng Shui. (Ancient oriental art of Penguin Arranging) Work|Independent Sys Consultant | http://www.computer-surgery.co.uk/ New key Fpr: 72AF 0ACC 9A53 E59F B1B6 DC14 1983 A13E 5C3D 3CEB - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: hda_intel : Patch + Regression in 2.6.18 -> 2.6.22
> On Wed, 05 Sep 2007 18:05:44 +0200 Takashi Iwai <[EMAIL PROTECTED]> wrote: > Roger, could you try git-alsa patch in the latest mm together with > model=acer-aspiore option? If it works, I can easily add your device > ID to the table. http://userweb.kernel.org/~akpm/git-alsa.patch is a copy of the alsa git tree as of two minutes ago. That applies against current Linus mainline, but should apply OK on 2.6.23-rc5 as well. Please test that, thanks. Takashi, perhaps that is 2.6.23 material? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: hda_intel : Patch + Regression in 2.6.18 -> 2.6.22
At Wed, 5 Sep 2007 08:38:44 -0700, Andrew Morton wrote: > > > On Wed, 22 Aug 2007 23:29:02 +0100 Roger Gammans <[EMAIL PROTECTED]> wrote: > > Hi > > A distinct regression, a confirmed fix, yet no reply after more than two > weeks. Sorry, I've overseen this report (as I'm obviously no akpm ;-) > > I'm fighting a problem with my (new) Acer laptop. (Aspire 9303) > > > > In 2.6.18 the audio worked fine, but now I've upgraded to 2.6.22 > > it has stopped working. > > > > I note that there is a acer specific quirk mode in patch_realtek.c > > enabled for all acer devices introduced in the timeframe. Disabling > > the quirk so that the driver uses it auot mode makes playback work > > fine again. > > > > To be clear this pathc seems to work for me:- > > > > --- /usr/src/linux-source-2.6.22/sound/pci/hda/patch_realtek.c 2007-07-09 > > 00:32:17.0 +0100 > > +++ linux-source-2.6.22/sound/pci/hda/patch_realtek.c 2007-08-20 > > 22:21:37.0 +0100 > > @@ -6392,7 +6392,7 @@ > > SND_PCI_QUIRK(0x1462, 0x4319, "MSI", ALC883_TARGA_DIG), > > SND_PCI_QUIRK(0x1462, 0x4324, "MSI", ALC883_TARGA_DIG), > > SND_PCI_QUIRK(0x1462, 0xa422, "MSI", ALC883_TARGA_2ch_DIG), > > - SND_PCI_QUIRK(0x1025, 0, "Acer laptop", ALC883_ACER), > > +/* SND_PCI_QUIRK(0x1025, 0, "Acer laptop", ALC883_ACER) , */ > > SND_PCI_QUIRK(0x15d9, 0x8780, "Supermicro PDSBA", ALC883_3ST_6ch), > > SND_PCI_QUIRK(0x161f, 0x2054, "Medion laptop", ALC883_MEDION), > > SND_PCI_QUIRK(0x1071, 0x8258, "Evesham Voyaeger", > > ALC883_LAPTOP_EAPD), > > > > > > Unfortunately I think it's pretty clear it will break for others. > > > > The lspci reports the following on the appropriate device:- > > 00:10.1 0403: 10de:026c (rev a2) > > Subsystem: 1025:0112 > > Flags: 66MHz, fast devsel, IRQ 19 > > Memory at c000 (32-bit, non-prefetchable) [size=16K] > > Capabilities: > > > > Jaroslav, Takashi: can you please comment on this? The patch would definitely break many other machines, so no, it can't be applied as is. Note that there is an equivalent workaround by adding "model=auto" module option. The support for Acer Aspire was already improved in mm tree. At least, we have the support for Aspire 9810 and co. If it's the compatible one, the chance is high. Roger, could you try git-alsa patch in the latest mm together with model=acer-aspiore option? If it works, I can easily add your device ID to the table. thanks, Takashi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: hda_intel : Patch + Regression in 2.6.18 -> 2.6.22
> On Wed, 22 Aug 2007 23:29:02 +0100 Roger Gammans <[EMAIL PROTECTED]> wrote: > Hi A distinct regression, a confirmed fix, yet no reply after more than two weeks. > I'm fighting a problem with my (new) Acer laptop. (Aspire 9303) > > In 2.6.18 the audio worked fine, but now I've upgraded to 2.6.22 > it has stopped working. > > I note that there is a acer specific quirk mode in patch_realtek.c > enabled for all acer devices introduced in the timeframe. Disabling > the quirk so that the driver uses it auot mode makes playback work > fine again. > > To be clear this pathc seems to work for me:- > > --- /usr/src/linux-source-2.6.22/sound/pci/hda/patch_realtek.c 2007-07-09 > 00:32:17.0 +0100 > +++ linux-source-2.6.22/sound/pci/hda/patch_realtek.c 2007-08-20 > 22:21:37.0 +0100 > @@ -6392,7 +6392,7 @@ > SND_PCI_QUIRK(0x1462, 0x4319, "MSI", ALC883_TARGA_DIG), > SND_PCI_QUIRK(0x1462, 0x4324, "MSI", ALC883_TARGA_DIG), > SND_PCI_QUIRK(0x1462, 0xa422, "MSI", ALC883_TARGA_2ch_DIG), > - SND_PCI_QUIRK(0x1025, 0, "Acer laptop", ALC883_ACER), > +/* SND_PCI_QUIRK(0x1025, 0, "Acer laptop", ALC883_ACER) , */ > SND_PCI_QUIRK(0x15d9, 0x8780, "Supermicro PDSBA", ALC883_3ST_6ch), > SND_PCI_QUIRK(0x161f, 0x2054, "Medion laptop", ALC883_MEDION), > SND_PCI_QUIRK(0x1071, 0x8258, "Evesham Voyaeger", > ALC883_LAPTOP_EAPD), > > > Unfortunately I think it's pretty clear it will break for others. > > The lspci reports the following on the appropriate device:- > 00:10.1 0403: 10de:026c (rev a2) > Subsystem: 1025:0112 > Flags: 66MHz, fast devsel, IRQ 19 > Memory at c000 (32-bit, non-prefetchable) [size=16K] > Capabilities: > Jaroslav, Takashi: can you please comment on this? Thanks. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
hda_intel : Patch + Regression in 2.6.18 -> 2.6.22
Hi I'm fighting a problem with my (new) Acer laptop. (Aspire 9303) In 2.6.18 the audio worked fine, but now I've upgraded to 2.6.22 it has stopped working. I note that there is a acer specific quirk mode in patch_realtek.c enabled for all acer devices introduced in the timeframe. Disabling the quirk so that the driver uses it auot mode makes playback work fine again. To be clear this pathc seems to work for me:- --- /usr/src/linux-source-2.6.22/sound/pci/hda/patch_realtek.c 2007-07-09 00:32:17.0 +0100 +++ linux-source-2.6.22/sound/pci/hda/patch_realtek.c 2007-08-20 22:21:37.0 +0100 @@ -6392,7 +6392,7 @@ SND_PCI_QUIRK(0x1462, 0x4319, "MSI", ALC883_TARGA_DIG), SND_PCI_QUIRK(0x1462, 0x4324, "MSI", ALC883_TARGA_DIG), SND_PCI_QUIRK(0x1462, 0xa422, "MSI", ALC883_TARGA_2ch_DIG), - SND_PCI_QUIRK(0x1025, 0, "Acer laptop", ALC883_ACER), +/* SND_PCI_QUIRK(0x1025, 0, "Acer laptop", ALC883_ACER) , */ SND_PCI_QUIRK(0x15d9, 0x8780, "Supermicro PDSBA", ALC883_3ST_6ch), SND_PCI_QUIRK(0x161f, 0x2054, "Medion laptop", ALC883_MEDION), SND_PCI_QUIRK(0x1071, 0x8258, "Evesham Voyaeger", ALC883_LAPTOP_EAPD), Unfortunately I think it's pretty clear it will break for others. The lspci reports the following on the appropriate device:- 00:10.1 0403: 10de:026c (rev a2) Subsystem: 1025:0112 Flags: 66MHz, fast devsel, IRQ 19 Memory at c000 (32-bit, non-prefetchable) [size=16K] Capabilities: TTFN -- Roger. Home| http://www.sandman.uklinux.net/ Master of Peng Shui. (Ancient oriental art of Penguin Arranging) Work|Independent Sys Consultant | http://www.computer-surgery.co.uk/ New key Fpr: 72AF 0ACC 9A53 E59F B1B6 DC14 1983 A13E 5C3D 3CEB signature.asc Description: Digital signature
