Re: inconsistent lock state in ila_xlat_nl_cmd_add_mapping
On Tue, 29 Dec 2020 17:52:56 -0800 Cong Wang wrote: > On Tue, Dec 29, 2020 at 5:39 PM Jakub Kicinski wrote: > > > > On Mon, 13 Aug 2018 21:40:03 -0700 syzbot wrote: > > > Hello, > > > > > > syzbot found the following crash on: > > > > > > HEAD commit:78cbac647e61 Merge branch > > > 'ip-faster-in-order-IP-fragments' > > > git tree: net-next > > > console output: https://syzkaller.appspot.com/x/log.txt?x=14df482840 > > > kernel config: https://syzkaller.appspot.com/x/.config?x=9100338df26ab75 > > > dashboard link: > > > https://syzkaller.appspot.com/bug?extid=eaaf6c4a6a8cb1869d86 > > > compiler: gcc (GCC) 8.0.1 20180413 (experimental) > > > syzkaller repro:https://syzkaller.appspot.com/x/repro.syz?x=13069ad240 > > > > > > IMPORTANT: if you fix the bug, please add the following tag to the commit: > > > Reported-by: syzbot+eaaf6c4a6a8cb1869...@syzkaller.appspotmail.com > > > > #syz invalid > > > > Hard to track down what fixed this, but the lockdep splat is mixing up > > locks from two different hashtables, so there was never a real issue > > here. > > This one is probably fixed by: > > commit ff93bca769925a2d8fd7f910cdf543d992e17f07 > Author: Cong Wang > Date: Tue Aug 14 15:21:31 2018 -0700 > > ila: make lockdep happy again > > given the time of last reproducing... Ah, yes, matches perfectly! I didn't look for fixes in spinlock.h. Thanks!
Re: inconsistent lock state in ila_xlat_nl_cmd_add_mapping
On Tue, Dec 29, 2020 at 5:39 PM Jakub Kicinski wrote: > > On Mon, 13 Aug 2018 21:40:03 -0700 syzbot wrote: > > Hello, > > > > syzbot found the following crash on: > > > > HEAD commit:78cbac647e61 Merge branch 'ip-faster-in-order-IP-fragments' > > git tree: net-next > > console output: https://syzkaller.appspot.com/x/log.txt?x=14df482840 > > kernel config: https://syzkaller.appspot.com/x/.config?x=9100338df26ab75 > > dashboard link: https://syzkaller.appspot.com/bug?extid=eaaf6c4a6a8cb1869d86 > > compiler: gcc (GCC) 8.0.1 20180413 (experimental) > > syzkaller repro:https://syzkaller.appspot.com/x/repro.syz?x=13069ad240 > > > > IMPORTANT: if you fix the bug, please add the following tag to the commit: > > Reported-by: syzbot+eaaf6c4a6a8cb1869...@syzkaller.appspotmail.com > > #syz invalid > > Hard to track down what fixed this, but the lockdep splat is mixing up > locks from two different hashtables, so there was never a real issue > here. This one is probably fixed by: commit ff93bca769925a2d8fd7f910cdf543d992e17f07 Author: Cong Wang Date: Tue Aug 14 15:21:31 2018 -0700 ila: make lockdep happy again given the time of last reproducing... Thanks.
Re: inconsistent lock state in ila_xlat_nl_cmd_add_mapping
On Mon, 13 Aug 2018 21:40:03 -0700 syzbot wrote: > Hello, > > syzbot found the following crash on: > > HEAD commit:78cbac647e61 Merge branch 'ip-faster-in-order-IP-fragments' > git tree: net-next > console output: https://syzkaller.appspot.com/x/log.txt?x=14df482840 > kernel config: https://syzkaller.appspot.com/x/.config?x=9100338df26ab75 > dashboard link: https://syzkaller.appspot.com/bug?extid=eaaf6c4a6a8cb1869d86 > compiler: gcc (GCC) 8.0.1 20180413 (experimental) > syzkaller repro:https://syzkaller.appspot.com/x/repro.syz?x=13069ad240 > > IMPORTANT: if you fix the bug, please add the following tag to the commit: > Reported-by: syzbot+eaaf6c4a6a8cb1869...@syzkaller.appspotmail.com #syz invalid Hard to track down what fixed this, but the lockdep splat is mixing up locks from two different hashtables, so there was never a real issue here.