Re: kbuild, localversion (Re: [patch 3/3, resend] kbuild: correctly skip tilded backups in localversion files)
> > What i currently have is: > > -- top file 'Linux.version', with first line: > > 3.0.0-rcX > which can be parsed to fill variables, used in build process (how many > `.' and/or `-' in it -- doesn't really matter), second line is the name; > > -- 'MM.version' for MM tree; > > -- '[a-z]*\.version' for anything else. > > usual sort will place files in right order. Too much depend on having version in Makefile so this is a no-go to change. This has been like this since very early days so we shall not change it. Sam - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: kbuild, localversion (Re: [patch 3/3, resend] kbuild: correctly skip tilded backups in localversion files)
What i currently have is: -- top file 'Linux.version', with first line: 3.0.0-rcX which can be parsed to fill variables, used in build process (how many `.' and/or `-' in it -- doesn't really matter), second line is the name; -- 'MM.version' for MM tree; -- '[a-z]*\.version' for anything else. usual sort will place files in right order. Too much depend on having version in Makefile so this is a no-go to change. This has been like this since very early days so we shall not change it. Sam - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
kbuild, localversion (Re: [patch 3/3, resend] kbuild: correctly skip tilded backups in localversion files)
Hallo! On Tue, Feb 13, 2007 at 05:09:47PM +0100, Roman Zippel wrote: > Hi, > > On Tue, 13 Feb 2007, Linus Torvalds wrote: > > > > I know it maybe another my "change it all" proposition, but i can't find > > > nothing against `GNU $(wildcard ..)' and `unnecessarily complex "find"'. > > > > It's the regexp in both cases. $(wildcard ) doesn't do regexp's (only the > > normal path rules), and traditional 'find' doesn't either. The fact that > > GNU find does is another matter. I don't think we require GNU find > > normally. > > > > And I don't even much like the "backup" thing. Some programs will use > > other things than "~" as a backup marker. Patch more often uses ".orig", > > for example. So both methods are fairly complex, but at the same time not > > quite complex enough. > > > > It would probably have been a better idea had we made the rule be that the > > file is called "*localversion" rather than "localversion*", exactly > > because that way it's unambiguous (people normally use _suffixes_ for > > filetypes, not prefixes). That would have avoided the whole complexity in > > wildcarding, but it's too late now.. > > > > $(sort $(wildcard $(srctree)/*localversion $(objtree)/*localversion) > > > > should have worked. As part of my personal preparation for "a new kind of things" i finally went to the same idea with suffixes. What i currently have is: -- top file 'Linux.version', with first line: 3.0.0-rcX which can be parsed to fill variables, used in build process (how many `.' and/or `-' in it -- doesn't really matter), second line is the name; -- 'MM.version' for MM tree; -- '[a-z]*\.version' for anything else. usual sort will place files in right order. > For now I think it's easier to just revert the change to use find, I > posted the patch for this already a few days ago. > I don't know if it really makes sense to change the rules for this now, > apparently people are using this, it may not be perfect, but I think in > the end it's just a matter of taste. At least we have some discussion. Unless Linus use `sed' for patching Makefile for versions, i think, to edit one or two lines in 50kB monster, isn't so much pleasure ;) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
kbuild, localversion (Re: [patch 3/3, resend] kbuild: correctly skip tilded backups in localversion files)
Hallo! On Tue, Feb 13, 2007 at 05:09:47PM +0100, Roman Zippel wrote: Hi, On Tue, 13 Feb 2007, Linus Torvalds wrote: I know it maybe another my change it all proposition, but i can't find nothing against `GNU $(wildcard ..)' and `unnecessarily complex find'. It's the regexp in both cases. $(wildcard ) doesn't do regexp's (only the normal path rules), and traditional 'find' doesn't either. The fact that GNU find does is another matter. I don't think we require GNU find normally. And I don't even much like the backup thing. Some programs will use other things than ~ as a backup marker. Patch more often uses .orig, for example. So both methods are fairly complex, but at the same time not quite complex enough. It would probably have been a better idea had we made the rule be that the file is called *localversion rather than localversion*, exactly because that way it's unambiguous (people normally use _suffixes_ for filetypes, not prefixes). That would have avoided the whole complexity in wildcarding, but it's too late now.. $(sort $(wildcard $(srctree)/*localversion $(objtree)/*localversion) should have worked. As part of my personal preparation for a new kind of things i finally went to the same idea with suffixes. What i currently have is: -- top file 'Linux.version', with first line: 3.0.0-rcX which can be parsed to fill variables, used in build process (how many `.' and/or `-' in it -- doesn't really matter), second line is the name; -- 'MM.version' for MM tree; -- '[a-z]*\.version' for anything else. usual sort will place files in right order. For now I think it's easier to just revert the change to use find, I posted the patch for this already a few days ago. I don't know if it really makes sense to change the rules for this now, apparently people are using this, it may not be perfect, but I think in the end it's just a matter of taste. At least we have some discussion. Unless Linus use `sed' for patching Makefile for versions, i think, to edit one or two lines in 50kB monster, isn't so much pleasure ;) - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
