Re: linux-next: Fixes tag needs some work in the block tree
On 3/5/21 12:46 AM, Christoph Hellwig wrote: > On Thu, Mar 04, 2021 at 05:26:42PM -0700, Jens Axboe wrote: >> Christoph, since there's multiple commits with issues, mind resending >> a fixed branch? Then I'll drop the one I pulled today. > > I've fixed the commit id and dropped the patch without the author > signoff, but your branch still has the current patches. Killed it this morning, please resend it. Plan on shipping to Linus today so we ensure we hit -rc2. -- Jens Axboe
Re: linux-next: Fixes tag needs some work in the block tree
On Thu, Mar 04, 2021 at 05:26:42PM -0700, Jens Axboe wrote: > Christoph, since there's multiple commits with issues, mind resending > a fixed branch? Then I'll drop the one I pulled today. I've fixed the commit id and dropped the patch without the author signoff, but your branch still has the current patches.
Re: linux-next: Fixes tag needs some work in the block tree
On 3/4/21 4:52 PM, Stephen Rothwell wrote:
> Hi all,
>
> In commit
>
> 284e4cdb0c0b ("nvme-hwmon: Return error code when registration fails")
>
> Fixes tag
>
> Fixes: ec420cdcfab4 ("nvme/hwmon: rework to avoid devm allocation")
>
> has these problem(s):
>
> - Target SHA1 does not exist
>
> Maybe you meant
>
> Fixes: ed7770f66286 ("nvme-hwmon: rework to avoid devm allocation")
Christoph, since there's multiple commits with issues, mind resending
a fixed branch? Then I'll drop the one I pulled today.
--
Jens Axboe
linux-next: Fixes tag needs some work in the block tree
Hi all,
In commit
284e4cdb0c0b ("nvme-hwmon: Return error code when registration fails")
Fixes tag
Fixes: ec420cdcfab4 ("nvme/hwmon: rework to avoid devm allocation")
has these problem(s):
- Target SHA1 does not exist
Maybe you meant
Fixes: ed7770f66286 ("nvme-hwmon: rework to avoid devm allocation")
--
Cheers,
Stephen Rothwell
pgpdEP11JEmwp.pgp
Description: OpenPGP digital signature
Re: linux-next: Fixes tag needs some work in the block tree
On 2/22/21 13:01, Stephen Rothwell wrote:
> Hi all,
>
> In commit
>
> 179d16007236 ("block: remove superfluous param in blk_fill_rwbs()")
>
> Fixes tag
>
> Fixes: 1b9a9ab78b0 ("blktrace: use op accessors")
>
> has these problem(s):
>
> - SHA1 should be at least 12 digits long
> Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
> or later) just making sure it is not set (or set to "auto").
>
> -- Cheers, Stephen Rothwell
Yes, it was my fault it should be 1b9a9ab78b0a the last 'a' is missing.
linux-next: Fixes tag needs some work in the block tree
Hi all,
In commit
179d16007236 ("block: remove superfluous param in blk_fill_rwbs()")
Fixes tag
Fixes: 1b9a9ab78b0 ("blktrace: use op accessors")
has these problem(s):
- SHA1 should be at least 12 digits long
Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
or later) just making sure it is not set (or set to "auto").
--
Cheers,
Stephen Rothwell
pgpGtWOQNxr6z.pgp
Description: OpenPGP digital signature
Re: linux-next: Fixes tag needs some work in the block tree
On 2/19/21 9:51 PM, Stephen Rothwell wrote:
> Hi all,
>
> In commit
>
> 76676c992506 ("io_uring: fix io_rsrc_ref_quiesce races")
>
> Fixes tag
>
> Fixes: 0ce4a72632317 ("io_uring: don't hold uring_lock when calling
> io_run_task_work*")
>
> has these problem(s):
>
> - Target SHA1 does not exist
>
> Maybe you meant
>
> Fixes: a4f2225d1cb2 ("io_uring: don't hold uring_lock when calling
> io_run_task_work*")
Fixed it up, thanks Stephen.
--
Jens Axboe
linux-next: Fixes tag needs some work in the block tree
Hi all,
In commit
76676c992506 ("io_uring: fix io_rsrc_ref_quiesce races")
Fixes tag
Fixes: 0ce4a72632317 ("io_uring: don't hold uring_lock when calling
io_run_task_work*")
has these problem(s):
- Target SHA1 does not exist
Maybe you meant
Fixes: a4f2225d1cb2 ("io_uring: don't hold uring_lock when calling
io_run_task_work*")
--
Cheers,
Stephen Rothwell
pgpOB8SLSghjl.pgp
Description: OpenPGP digital signature
linux-next: Fixes tag needs some work in the block tree
Hi all,
In commit
8a0c014cd205 ("floppy: reintroduce O_NDELAY fix")
Fixes tag
Fixes: 09954bad4 ("floppy: refactor open() flags handling")
has these problem(s):
- SHA1 should be at least 12 digits long
Fixes tag
Fixes: f2791e7ead ("Revert "floppy: refactor open() flags handling"")
has these problem(s):
- SHA1 should be at least 12 digits long
These can be fixed for future commits by setting core.abbrev to 12
(or more) or (for git v2.11 or later) just making sure it is not set
(or set to "auto").
--
Cheers,
Stephen Rothwell
pgp1Izv4ouBAj.pgp
Description: OpenPGP digital signature
linux-next: Fixes tag needs some work in the block tree
Hi all,
In commit
d4fc3640ff36 ("block, bfq: set next_rq to waker_bfqq->next_rq in waker
injection")
Fixes tag
Fixes: c5089591c3ba ("block, bfq: detect wakers and unconditionally inject
their I/O")
has these problem(s):
- Target SHA1 does not exist
Maybe you meant
Fixes: 13a857a4c4e8 ("block, bfq: detect wakers and unconditionally inject
their I/O")
--
Cheers,
Stephen Rothwell
pgpiWwH2DILIf.pgp
Description: OpenPGP digital signature
Re: linux-next: Fixes tag needs some work in the block tree
On 1/26/21 9:01 AM, Jan Kara wrote:
> On Tue 26-01-21 08:47:55, Jens Axboe wrote:
>> On 1/26/21 6:29 AM, Jan Kara wrote:
>>> On Mon 25-01-21 11:39:50, Jens Axboe wrote:
On 1/25/21 11:35 AM, Paolo Valente wrote:
>
>
>> Il giorno 25 gen 2021, alle ore 10:40, Stephen Rothwell
>> ha scritto:
>>
>> Hi all,
>>
>> In commit
>>
>> d4fc3640ff36 ("block, bfq: set next_rq to waker_bfqq->next_rq in waker
>> injection")
>>
>> Fixes tag
>>
>> Fixes: c5089591c3ba ("block, bfq: detect wakers and unconditionally
>> inject their I/O")
>>
>> has these problem(s):
>>
>> - Target SHA1 does not exist
>>
>> Maybe you meant
>>
>> Fixes: 13a857a4c4e8 ("block, bfq: detect wakers and unconditionally
>> inject their I/O")
>>
>
> Hi Jens,
> how to proceed in such a case (with patches already applied by you)?
> Shall I send you a v2 with only this change?
We just have to ignore it... But in the future, always double check that
you are using the right shas, not some sha from an internal tree.
>>>
>>> FWIW I have a commit hook in my git tree that just refuses a commit with
>>> unknown Fixes tag SHA. Exactly to catch such mishaps in the patches I
>>> merge...
>>
>> That's not a bad idea, would help catch it upfront. Can you share the
>> hook?
>
> Sure, attached. Note that the hook just gets commit ID from the Fixes tag
> and formats it with 12 commit ID digits and appropriate commit subject.
Thanks, that looks great, and also fixes up short shas.
--
Jens Axboe
Re: linux-next: Fixes tag needs some work in the block tree
On Tue 26-01-21 08:47:55, Jens Axboe wrote:
> On 1/26/21 6:29 AM, Jan Kara wrote:
> > On Mon 25-01-21 11:39:50, Jens Axboe wrote:
> >> On 1/25/21 11:35 AM, Paolo Valente wrote:
> >>>
> >>>
> Il giorno 25 gen 2021, alle ore 10:40, Stephen Rothwell
> ha scritto:
>
> Hi all,
>
> In commit
>
> d4fc3640ff36 ("block, bfq: set next_rq to waker_bfqq->next_rq in waker
> injection")
>
> Fixes tag
>
> Fixes: c5089591c3ba ("block, bfq: detect wakers and unconditionally
> inject their I/O")
>
> has these problem(s):
>
> - Target SHA1 does not exist
>
> Maybe you meant
>
> Fixes: 13a857a4c4e8 ("block, bfq: detect wakers and unconditionally
> inject their I/O")
>
> >>>
> >>> Hi Jens,
> >>> how to proceed in such a case (with patches already applied by you)?
> >>> Shall I send you a v2 with only this change?
> >>
> >> We just have to ignore it... But in the future, always double check that
> >> you are using the right shas, not some sha from an internal tree.
> >
> > FWIW I have a commit hook in my git tree that just refuses a commit with
> > unknown Fixes tag SHA. Exactly to catch such mishaps in the patches I
> > merge...
>
> That's not a bad idea, would help catch it upfront. Can you share the
> hook?
Sure, attached. Note that the hook just gets commit ID from the Fixes tag
and formats it with 12 commit ID digits and appropriate commit subject.
Honza
--
Jan Kara
SUSE Labs, CR
#!/bin/sh
#
# Called by "git commit" with one argument, the name of the file
# that has the commit message. The hook should exit with non-zero
# status after issuing an appropriate message if it wants to stop the
# commit. The hook is allowed to edit the commit message file.
# Process all Fixes tags, check commit IDs and set appropriate commit titles.
for COMMIT in $(sed -n -e 's/^Fixes: \([0-9a-z]*\).*/\1/p' "$1"); do
GOOD=$(git show -s --abbrev-commit --abbrev=12 --pretty=format:"%h
(\"%s\")%n" $COMMIT -- 2>/dev/null)
if [ -z "$GOOD" ]; then
echo "Unknown commit: $COMMIT"
exit 1
fi
echo "Setting fixes tag: $GOOD"
sed -i -e "s/^Fixes: $COMMIT.*/Fixes: $GOOD/" "$1"
done
exit 0
Re: linux-next: Fixes tag needs some work in the block tree
On 1/26/21 6:29 AM, Jan Kara wrote:
> On Mon 25-01-21 11:39:50, Jens Axboe wrote:
>> On 1/25/21 11:35 AM, Paolo Valente wrote:
>>>
>>>
Il giorno 25 gen 2021, alle ore 10:40, Stephen Rothwell
ha scritto:
Hi all,
In commit
d4fc3640ff36 ("block, bfq: set next_rq to waker_bfqq->next_rq in waker
injection")
Fixes tag
Fixes: c5089591c3ba ("block, bfq: detect wakers and unconditionally
inject their I/O")
has these problem(s):
- Target SHA1 does not exist
Maybe you meant
Fixes: 13a857a4c4e8 ("block, bfq: detect wakers and unconditionally inject
their I/O")
>>>
>>> Hi Jens,
>>> how to proceed in such a case (with patches already applied by you)?
>>> Shall I send you a v2 with only this change?
>>
>> We just have to ignore it... But in the future, always double check that
>> you are using the right shas, not some sha from an internal tree.
>
> FWIW I have a commit hook in my git tree that just refuses a commit with
> unknown Fixes tag SHA. Exactly to catch such mishaps in the patches I
> merge...
That's not a bad idea, would help catch it upfront. Can you share the
hook?
--
Jens Axboe
Re: linux-next: Fixes tag needs some work in the block tree
On Mon 25-01-21 11:39:50, Jens Axboe wrote:
> On 1/25/21 11:35 AM, Paolo Valente wrote:
> >
> >
> >> Il giorno 25 gen 2021, alle ore 10:40, Stephen Rothwell
> >> ha scritto:
> >>
> >> Hi all,
> >>
> >> In commit
> >>
> >> d4fc3640ff36 ("block, bfq: set next_rq to waker_bfqq->next_rq in waker
> >> injection")
> >>
> >> Fixes tag
> >>
> >> Fixes: c5089591c3ba ("block, bfq: detect wakers and unconditionally
> >> inject their I/O")
> >>
> >> has these problem(s):
> >>
> >> - Target SHA1 does not exist
> >>
> >> Maybe you meant
> >>
> >> Fixes: 13a857a4c4e8 ("block, bfq: detect wakers and unconditionally inject
> >> their I/O")
> >>
> >
> > Hi Jens,
> > how to proceed in such a case (with patches already applied by you)?
> > Shall I send you a v2 with only this change?
>
> We just have to ignore it... But in the future, always double check that
> you are using the right shas, not some sha from an internal tree.
FWIW I have a commit hook in my git tree that just refuses a commit with
unknown Fixes tag SHA. Exactly to catch such mishaps in the patches I
merge...
Honza
--
Jan Kara
SUSE Labs, CR
Re: linux-next: Fixes tag needs some work in the block tree
On 1/25/21 11:35 AM, Paolo Valente wrote:
>
>
>> Il giorno 25 gen 2021, alle ore 10:40, Stephen Rothwell
>> ha scritto:
>>
>> Hi all,
>>
>> In commit
>>
>> d4fc3640ff36 ("block, bfq: set next_rq to waker_bfqq->next_rq in waker
>> injection")
>>
>> Fixes tag
>>
>> Fixes: c5089591c3ba ("block, bfq: detect wakers and unconditionally inject
>> their I/O")
>>
>> has these problem(s):
>>
>> - Target SHA1 does not exist
>>
>> Maybe you meant
>>
>> Fixes: 13a857a4c4e8 ("block, bfq: detect wakers and unconditionally inject
>> their I/O")
>>
>
> Hi Jens,
> how to proceed in such a case (with patches already applied by you)?
> Shall I send you a v2 with only this change?
We just have to ignore it... But in the future, always double check that
you are using the right shas, not some sha from an internal tree.
--
Jens Axboe
Re: linux-next: Fixes tag needs some work in the block tree
> Il giorno 25 gen 2021, alle ore 10:40, Stephen Rothwell
> ha scritto:
>
> Hi all,
>
> In commit
>
> d4fc3640ff36 ("block, bfq: set next_rq to waker_bfqq->next_rq in waker
> injection")
>
> Fixes tag
>
> Fixes: c5089591c3ba ("block, bfq: detect wakers and unconditionally inject
> their I/O")
>
> has these problem(s):
>
> - Target SHA1 does not exist
>
> Maybe you meant
>
> Fixes: 13a857a4c4e8 ("block, bfq: detect wakers and unconditionally inject
> their I/O")
>
Hi Jens,
how to proceed in such a case (with patches already applied by you)?
Shall I send you a v2 with only this change?
Thanks,
Paolo
> --
> Cheers,
> Stephen Rothwell
Re: linux-next: Fixes tag needs some work in the block tree
On 12/17/20 1:38 PM, Stephen Rothwell wrote:
> Hi all,
>
> In commit
>
> 358e7cbf87b4 ("s390/dasd: fix hanging device offline processing")
>
> Fixes tag
>
> Fixes: 47825e05d93e ("s390/dasd: fix endless loop after read unit address
> configuration")
>
> has these problem(s):
>
> - Target SHA1 does not exist
>
> Maybe you meant
>
> Fixes: 41995342b40c ("s390/dasd: fix endless loop after read unit address
> configuration")
Thanks, I fixed it up.
--
Jens Axboe
linux-next: Fixes tag needs some work in the block tree
Hi all,
In commit
358e7cbf87b4 ("s390/dasd: fix hanging device offline processing")
Fixes tag
Fixes: 47825e05d93e ("s390/dasd: fix endless loop after read unit address
configuration")
has these problem(s):
- Target SHA1 does not exist
Maybe you meant
Fixes: 41995342b40c ("s390/dasd: fix endless loop after read unit address
configuration")
--
Cheers,
Stephen Rothwell
pgpxU29RTFZat.pgp
Description: OpenPGP digital signature
Re: linux-next: Fixes tag needs some work in the block tree
On 12/1/20 2:44 PM, Stephen Rothwell wrote:
> Hi Jens,
>
> On Tue, 1 Dec 2020 14:09:24 -0700 Jens Axboe wrote:
>>
>> On 12/1/20 2:02 PM, Stephen Rothwell wrote:
>>>
>>> In commit
>>>
>>> 573cc9d095bc ("blk-cgroup: fix a hd_struct leak in
>>> blkcg_fill_root_iostats")
>>>
>>> Fixes tag
>>>
>>> Fixes: ef45fe470e1 ("blk-cgroup: show global disk stats in root cgroup
>>> io.stat")
>>>
>>> has these problem(s):
>>>
>>> - SHA1 should be at least 12 digits long
>>>
>>> For the future, this can be fixed by setting core.abbrev to 12 (or more)
>>> or (for git v2.11 or later) just making sure it is not set (or set to
>>> "auto").
>>
>> It's in Linus's tree, not in -next. The ship has sailed...
>
> Ummm, 573cc9d095bc is only in your tree as far as I can see ...
> however, I don't really expect these short SHA1 issues to be fixed up
> (as that would require rebasing your tree), just that people will try
> not to do the same in the future.
Hmm yes, but that's because I botched something up. I'll take a look!
--
Jens Axboe
Re: linux-next: Fixes tag needs some work in the block tree
Hi Jens,
On Tue, 1 Dec 2020 14:09:24 -0700 Jens Axboe wrote:
>
> On 12/1/20 2:02 PM, Stephen Rothwell wrote:
> >
> > In commit
> >
> > 573cc9d095bc ("blk-cgroup: fix a hd_struct leak in
> > blkcg_fill_root_iostats")
> >
> > Fixes tag
> >
> > Fixes: ef45fe470e1 ("blk-cgroup: show global disk stats in root cgroup
> > io.stat")
> >
> > has these problem(s):
> >
> > - SHA1 should be at least 12 digits long
> >
> > For the future, this can be fixed by setting core.abbrev to 12 (or more)
> > or (for git v2.11 or later) just making sure it is not set (or set to
> > "auto").
>
> It's in Linus's tree, not in -next. The ship has sailed...
Ummm, 573cc9d095bc is only in your tree as far as I can see ...
however, I don't really expect these short SHA1 issues to be fixed up
(as that would require rebasing your tree), just that people will try
not to do the same in the future.
--
Cheers,
Stephen Rothwell
pgpCi6ELhDtWx.pgp
Description: OpenPGP digital signature
Re: linux-next: Fixes tag needs some work in the block tree
On 12/1/20 2:02 PM, Stephen Rothwell wrote:
> Hi all,
>
> In commit
>
> 573cc9d095bc ("blk-cgroup: fix a hd_struct leak in blkcg_fill_root_iostats")
>
> Fixes tag
>
> Fixes: ef45fe470e1 ("blk-cgroup: show global disk stats in root cgroup
> io.stat")
>
> has these problem(s):
>
> - SHA1 should be at least 12 digits long
>
> For the future, this can be fixed by setting core.abbrev to 12 (or more)
> or (for git v2.11 or later) just making sure it is not set (or set to
> "auto").
It's in Linus's tree, not in -next. The ship has sailed...
--
Jens Axboe
linux-next: Fixes tag needs some work in the block tree
Hi all,
In commit
573cc9d095bc ("blk-cgroup: fix a hd_struct leak in blkcg_fill_root_iostats")
Fixes tag
Fixes: ef45fe470e1 ("blk-cgroup: show global disk stats in root cgroup
io.stat")
has these problem(s):
- SHA1 should be at least 12 digits long
For the future, this can be fixed by setting core.abbrev to 12 (or more)
or (for git v2.11 or later) just making sure it is not set (or set to
"auto").
--
Cheers,
Stephen Rothwell
pgpi_BuQgVufg.pgp
Description: OpenPGP digital signature
linux-next: Fixes tag needs some work in the block tree
Hi all,
In commit
107673613884 ("blk-cgroup: fix a hd_struct leak in blkcg_fill_root_iostats")
Fixes tag
Fixes: ef45fe470e1 ("blk-cgroup: show global disk stats in root cgroup
io.stat")
has these problem(s):
- SHA1 should be at least 12 digits long
For the future, this can be fixed by setting core.abbrev to 12 (or more)
or (for git v2.11 or later) just making sure it is not set (or set to
"auto").
--
Cheers,
Stephen Rothwell
pgpb3wRdLsTWw.pgp
Description: OpenPGP digital signature
linux-next: Fixes tag needs some work in the block tree
Hi all,
In commit
10988d55ae96 ("md/raid10: Change the return type of raid10_handle_discard to
int")
Fixes tag
fixes: 8f694215ae4c (md/raid10: improve raid10 discard request)
has these problem(s):
- Target SHA1 does not exist
Maybe you meant
Fixes: 828d14fd7a6c ("md/raid10: improve raid10 discard request")
--
Cheers,
Stephen Rothwell
pgpVObKSGpULx.pgp
Description: OpenPGP digital signature
Re: linux-next: Fixes tag needs some work in the block tree
On 7/29/20 4:12 PM, Stephen Rothwell wrote:
> Hi all,
>
> [Just adding cc's]
>
> On Thu, 30 Jul 2020 08:08:49 +1000 Stephen Rothwell
> wrote:
>>
>> In commit
>>
>> 64d452b3560b ("nvme-loop: set ctrl state connecting after init")
>>
>> Fixes tag
>>
>> Fixes: aa63fa6776a7 ("nvme-fabrics: allow to queue requests for live
>> queues")
>>
>> has these problem(s):
>>
>> - Target SHA1 does not exist
>>
>> I can't easily find what commit is meant :-(
Yeah, it's obviously garbage, the commit doesn't even exist, let alone the sha.
Chaitanya, where's this from??
--
Jens Axboe
Re: linux-next: Fixes tag needs some work in the block tree
Hi all,
[Just adding cc's]
On Thu, 30 Jul 2020 08:08:49 +1000 Stephen Rothwell
wrote:
>
> In commit
>
> 64d452b3560b ("nvme-loop: set ctrl state connecting after init")
>
> Fixes tag
>
> Fixes: aa63fa6776a7 ("nvme-fabrics: allow to queue requests for live
> queues")
>
> has these problem(s):
>
> - Target SHA1 does not exist
>
> I can't easily find what commit is meant :-(
--
Cheers,
Stephen Rothwell
pgpmp0DYRHa_I.pgp
Description: OpenPGP digital signature
linux-next: Fixes tag needs some work in the block tree
Hi all,
In commit
64d452b3560b ("nvme-loop: set ctrl state connecting after init")
Fixes tag
Fixes: aa63fa6776a7 ("nvme-fabrics: allow to queue requests for live queues")
has these problem(s):
- Target SHA1 does not exist
I can't easily find what commit is meant :-(
--
Cheers,
Stephen Rothwell
pgpL2jUosDbJF.pgp
Description: OpenPGP digital signature
Re: linux-next: Fixes tag needs some work in the block tree
On 6/29/20 4:36 PM, Stephen Rothwell wrote:
> Hi all,
>
> On Mon, 29 Jun 2020 10:25:01 -0600 Jens Axboe wrote:
>>
>> On 6/29/20 10:21 AM, Pavel Begunkov wrote:
>>> On 29/06/2020 01:05, Stephen Rothwell wrote:
Hi all,
In commit
8c9cb6cd9a46 ("io_uring: fix refs underflow in io_iopoll_queue()")
Fixes tag
Fixes: a1d7c393c47 ("io_uring: enable READ/WRITE to use deferred
completions")
>>>
>>> Jens, could you please fix this up after me?
>>> full hash: a1d7c393c4711a9ce6c239c3ab053a50dc96505a
>>
>> I don't think that's a grave enough concern to rebase, it's just "missing" a
>> single digit of the sha.
>
> Yeah, its more of a "please fix your git config". :-)
Agree! But I'm guessing that Pavel did this manually, which I end up
doing a lot too... And then mistakes happen.
--
Jens Axboe
Re: linux-next: Fixes tag needs some work in the block tree
Hi all,
On Mon, 29 Jun 2020 10:25:01 -0600 Jens Axboe wrote:
>
> On 6/29/20 10:21 AM, Pavel Begunkov wrote:
> > On 29/06/2020 01:05, Stephen Rothwell wrote:
> >> Hi all,
> >>
> >> In commit
> >>
> >> 8c9cb6cd9a46 ("io_uring: fix refs underflow in io_iopoll_queue()")
> >>
> >> Fixes tag
> >>
> >> Fixes: a1d7c393c47 ("io_uring: enable READ/WRITE to use deferred
> >> completions")
> >
> > Jens, could you please fix this up after me?
> > full hash: a1d7c393c4711a9ce6c239c3ab053a50dc96505a
>
> I don't think that's a grave enough concern to rebase, it's just "missing" a
> single digit of the sha.
Yeah, its more of a "please fix your git config". :-)
--
Cheers,
Stephen Rothwell
pgpcDQMqK6Acz.pgp
Description: OpenPGP digital signature
Re: linux-next: Fixes tag needs some work in the block tree
On 29/06/2020 01:05, Stephen Rothwell wrote:
> Hi all,
>
> In commit
>
> 8c9cb6cd9a46 ("io_uring: fix refs underflow in io_iopoll_queue()")
>
> Fixes tag
>
> Fixes: a1d7c393c47 ("io_uring: enable READ/WRITE to use deferred
> completions")
Jens, could you please fix this up after me?
full hash: a1d7c393c4711a9ce6c239c3ab053a50dc96505a
> has these problem(s):
>
> - SHA1 should be at least 12 digits long
> Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
> or later) just making sure it is not set (or set to "auto").
>
--
Pavel Begunkov
Re: linux-next: Fixes tag needs some work in the block tree
On 6/29/20 10:21 AM, Pavel Begunkov wrote:
> On 29/06/2020 01:05, Stephen Rothwell wrote:
>> Hi all,
>>
>> In commit
>>
>> 8c9cb6cd9a46 ("io_uring: fix refs underflow in io_iopoll_queue()")
>>
>> Fixes tag
>>
>> Fixes: a1d7c393c47 ("io_uring: enable READ/WRITE to use deferred
>> completions")
>
> Jens, could you please fix this up after me?
> full hash: a1d7c393c4711a9ce6c239c3ab053a50dc96505a
I don't think that's a grave enough concern to rebase, it's just "missing" a
single digit of the sha.
--
Jens Axboe
linux-next: Fixes tag needs some work in the block tree
Hi all,
In commit
8c9cb6cd9a46 ("io_uring: fix refs underflow in io_iopoll_queue()")
Fixes tag
Fixes: a1d7c393c47 ("io_uring: enable READ/WRITE to use deferred completions")
has these problem(s):
- SHA1 should be at least 12 digits long
Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
or later) just making sure it is not set (or set to "auto").
--
Cheers,
Stephen Rothwell
pgp63DiZ4Us8z.pgp
Description: OpenPGP digital signature
Re: linux-next: Fixes tag needs some work in the block tree
On 6/26/20 11:12 PM, Stephen Rothwell wrote: > Hi Jens, > > On Fri, 26 Jun 2020 20:25:31 -0600 Jens Axboe wrote: >> >> Right, but that's what git format-patch does when the line is long. > > I just tested, and "git format-patch" (for me) does *not* split those lines. Huh, I could have sworn it's done that for me in the past, just like it splits the Subject: line into multiple lines as well (that I just did verify that it still does). -- Jens Axboe
Re: linux-next: Fixes tag needs some work in the block tree
On 27/06/2020 08:01, Stephen Rothwell wrote:
> Hi Konstantin,
>
> On Fri, 26 Jun 2020 21:56:05 -0400 Konstantin Ryabitsev
> wrote:
>>
>> On Fri, Jun 26, 2020 at 07:32:15PM -0600, Jens Axboe wrote:
>>> On 6/26/20 5:07 PM, Stephen Rothwell wrote:
Hi all,
In commit
cd664b0e35cb ("io_uring: fix hanging iopoll in case of -EAGAIN")
Fixes tag
Fixes: bbde017a32b3 ("io_uring: add memory barrier to synchronize
has these problem(s):
- Subject has leading but no trailing parentheses
- Subject has leading but no trailing quotes
Please do not split Fixes tags over more than one line.
>>>
>>> Gah, that's b4 messing it up. I've actually seen this before, but
>>> I caught it. If you look at the actual commit, this is what the b4
>>> output ends up being for the fixes line:
>>>
>>> [snip]
>>> io_kiocb's result and iopoll_completed")
>>>
>>> Fixes: bbde017a32b3 ("io_uring: add memory barrier to synchronize
>>>
>>> even though it's correct in the email. I'm guessing some issue having to
>>> do with the longer line?
>>
>> Yeah, I'll try to see if there's something I can do here, but it's going
>> to be largely guesswork. Here's the original email:
>>
>> https://lore.kernel.org/lkml/22111b29e298f5f606130fcf4307bda99dbec089.1593077359.git.asml.sile...@gmail.com/raw
>>
>> The Fixes: footer really does get split into two. It's not that hard to
>> add logic just for the Fixes tag (since it conveniently follows a set
>> pattern), but finding a universal fix for split footers will be more
>> difficult.
>>
>> I'll see what I can do.
>
> But (what am I missing?) the Fixes: tag has been split over 2 lines in
> the original message ... on lore and my copy. There is nothing for b4
> to do here, the author needs to do this right.
Yes, it was split from the beginning. It's really a shame it can't handle
multi-line tags, but well, I'll keep that in mind.
Though, it's curious how
```
Fixes ("line1
line2")
```
became
```
line2")
Fixes ("line1
```
And that's what the rest of the thread is about.
--
Pavel Begunkov
Re: linux-next: Fixes tag needs some work in the block tree
Hi Jens, On Fri, 26 Jun 2020 20:25:31 -0600 Jens Axboe wrote: > > Right, but that's what git format-patch does when the line is long. I just tested, and "git format-patch" (for me) does *not* split those lines. -- Cheers, Stephen Rothwell pgpMPaX2H1NdF.pgp Description: OpenPGP digital signature
Re: linux-next: Fixes tag needs some work in the block tree
Hi Konstantin,
On Fri, 26 Jun 2020 21:56:05 -0400 Konstantin Ryabitsev
wrote:
>
> On Fri, Jun 26, 2020 at 07:32:15PM -0600, Jens Axboe wrote:
> > On 6/26/20 5:07 PM, Stephen Rothwell wrote:
> > > Hi all,
> > >
> > > In commit
> > >
> > > cd664b0e35cb ("io_uring: fix hanging iopoll in case of -EAGAIN")
> > >
> > > Fixes tag
> > >
> > > Fixes: bbde017a32b3 ("io_uring: add memory barrier to synchronize
> > >
> > > has these problem(s):
> > >
> > > - Subject has leading but no trailing parentheses
> > > - Subject has leading but no trailing quotes
> > >
> > > Please do not split Fixes tags over more than one line.
> >
> > Gah, that's b4 messing it up. I've actually seen this before, but
> > I caught it. If you look at the actual commit, this is what the b4
> > output ends up being for the fixes line:
> >
> > [snip]
> > io_kiocb's result and iopoll_completed")
> >
> > Fixes: bbde017a32b3 ("io_uring: add memory barrier to synchronize
> >
> > even though it's correct in the email. I'm guessing some issue having to
> > do with the longer line?
>
> Yeah, I'll try to see if there's something I can do here, but it's going
> to be largely guesswork. Here's the original email:
>
> https://lore.kernel.org/lkml/22111b29e298f5f606130fcf4307bda99dbec089.1593077359.git.asml.sile...@gmail.com/raw
>
> The Fixes: footer really does get split into two. It's not that hard to
> add logic just for the Fixes tag (since it conveniently follows a set
> pattern), but finding a universal fix for split footers will be more
> difficult.
>
> I'll see what I can do.
But (what am I missing?) the Fixes: tag has been split over 2 lines in
the original message ... on lore and my copy. There is nothing for b4
to do here, the author needs to do this right.
--
Cheers,
Stephen Rothwell
pgptkJwEvBQnn.pgp
Description: OpenPGP digital signature
Re: linux-next: Fixes tag needs some work in the block tree
On 6/26/20 7:56 PM, Konstantin Ryabitsev wrote:
> On Fri, Jun 26, 2020 at 07:32:15PM -0600, Jens Axboe wrote:
>> On 6/26/20 5:07 PM, Stephen Rothwell wrote:
>>> Hi all,
>>>
>>> In commit
>>>
>>> cd664b0e35cb ("io_uring: fix hanging iopoll in case of -EAGAIN")
>>>
>>> Fixes tag
>>>
>>> Fixes: bbde017a32b3 ("io_uring: add memory barrier to synchronize
>>>
>>> has these problem(s):
>>>
>>> - Subject has leading but no trailing parentheses
>>> - Subject has leading but no trailing quotes
>>>
>>> Please do not split Fixes tags over more than one line.
>>
>> Gah, that's b4 messing it up. I've actually seen this before, but
>> I caught it. If you look at the actual commit, this is what the b4
>> output ends up being for the fixes line:
>>
>> [snip]
>> io_kiocb's result and iopoll_completed")
>>
>> Fixes: bbde017a32b3 ("io_uring: add memory barrier to synchronize
>>
>> even though it's correct in the email. I'm guessing some issue having to
>> do with the longer line?
>
> Yeah, I'll try to see if there's something I can do here, but it's going
> to be largely guesswork. Here's the original email:
>
> https://lore.kernel.org/lkml/22111b29e298f5f606130fcf4307bda99dbec089.1593077359.git.asml.sile...@gmail.com/raw
>
> The Fixes: footer really does get split into two. It's not that hard to
> add logic just for the Fixes tag (since it conveniently follows a set
> pattern), but finding a universal fix for split footers will be more
> difficult.
Right, but that's what git format-patch does when the line is long. Do
we have other tags where that's a concern? If not, then the fix should
be solid I think.
> I'll see what I can do.
Thanks!
--
Jens Axboe
Re: linux-next: Fixes tag needs some work in the block tree
On Fri, Jun 26, 2020 at 07:32:15PM -0600, Jens Axboe wrote:
> On 6/26/20 5:07 PM, Stephen Rothwell wrote:
> > Hi all,
> >
> > In commit
> >
> > cd664b0e35cb ("io_uring: fix hanging iopoll in case of -EAGAIN")
> >
> > Fixes tag
> >
> > Fixes: bbde017a32b3 ("io_uring: add memory barrier to synchronize
> >
> > has these problem(s):
> >
> > - Subject has leading but no trailing parentheses
> > - Subject has leading but no trailing quotes
> >
> > Please do not split Fixes tags over more than one line.
>
> Gah, that's b4 messing it up. I've actually seen this before, but
> I caught it. If you look at the actual commit, this is what the b4
> output ends up being for the fixes line:
>
> [snip]
> io_kiocb's result and iopoll_completed")
>
> Fixes: bbde017a32b3 ("io_uring: add memory barrier to synchronize
>
> even though it's correct in the email. I'm guessing some issue having to
> do with the longer line?
Yeah, I'll try to see if there's something I can do here, but it's going
to be largely guesswork. Here's the original email:
https://lore.kernel.org/lkml/22111b29e298f5f606130fcf4307bda99dbec089.1593077359.git.asml.sile...@gmail.com/raw
The Fixes: footer really does get split into two. It's not that hard to
add logic just for the Fixes tag (since it conveniently follows a set
pattern), but finding a universal fix for split footers will be more
difficult.
I'll see what I can do.
-K
Re: linux-next: Fixes tag needs some work in the block tree
On 6/26/20 5:07 PM, Stephen Rothwell wrote:
> Hi all,
>
> In commit
>
> cd664b0e35cb ("io_uring: fix hanging iopoll in case of -EAGAIN")
>
> Fixes tag
>
> Fixes: bbde017a32b3 ("io_uring: add memory barrier to synchronize
>
> has these problem(s):
>
> - Subject has leading but no trailing parentheses
> - Subject has leading but no trailing quotes
>
> Please do not split Fixes tags over more than one line.
Gah, that's b4 messing it up. I've actually seen this before, but
I caught it. If you look at the actual commit, this is what the b4
output ends up being for the fixes line:
[snip]
io_kiocb's result and iopoll_completed")
Fixes: bbde017a32b3 ("io_uring: add memory barrier to synchronize
even though it's correct in the email. I'm guessing some issue having to
do with the longer line?
CC Konstantin.
--
Jens Axboe
linux-next: Fixes tag needs some work in the block tree
Hi all,
In commit
cd664b0e35cb ("io_uring: fix hanging iopoll in case of -EAGAIN")
Fixes tag
Fixes: bbde017a32b3 ("io_uring: add memory barrier to synchronize
has these problem(s):
- Subject has leading but no trailing parentheses
- Subject has leading but no trailing quotes
Please do not split Fixes tags over more than one line.
--
Cheers,
Stephen Rothwell
pgpA2IUxBdAJ6.pgp
Description: OpenPGP digital signature
linux-next: Fixes tag needs some work in the block tree
Hi all,
In commit
dc35ada4251f ("block: fix a warning when blkdev.h is included for
!CONFIG_BLOCK builds")
Fixes tag
Fixes: 956d510ee78 ("block: add disk/bio-based accounting helpers")
has these problem(s):
- SHA1 should be at least 12 digits long
Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
or later) just making sure it is not set (or set to "auto").
--
Cheers,
Stephen Rothwell
pgp6GrxzxtYE0.pgp
Description: OpenPGP digital signature
Re: linux-next: Fixes tag needs some work in the block tree
Hi Bart,
On Thu, 10 Oct 2019 10:36:36 -0700 Bart Van Assche wrote:
>
> On 10/7/19 1:16 PM, Stephen Rothwell wrote:
> >
> >Fixes: e34cbd307477 ("blk-wbt: add general throttling mechanism"; v4.10).
>
> The above fixes tag follows the recommended format except that it is
> followed by a kernel version number. Is there a recommended format for
> embedding the kernel version number in a Fixes: tag? I think that
> information is useful. I haven't found any recommendations for how to do
> that in Documentation/process/submitting-patches.rst.
I have not seen any recommended way to do that, but there is no
necessity to embed the version as it can easily be derived:
$ git describe --contains e34cbd307477
v4.10-rc1~153^2~94
--
Cheers,
Stephen Rothwell
pgpczfFS_JUbd.pgp
Description: OpenPGP digital signature
Re: linux-next: Fixes tag needs some work in the block tree
On 10/7/19 1:16 PM, Stephen Rothwell wrote:
In commit
1d200e9d6f63 ("block: Fix writeback throttling W=1 compiler warnings")
Fixes tag
Fixes: e34cbd307477 ("blk-wbt: add general throttling mechanism"; v4.10).
has these problem(s):
- Subject has leading but no trailing quotes
- Subject does not match target commit subject
Just use
git log -1 --format='Fixes: %h ("%s")'
Hi Stephen,
The above fixes tag follows the recommended format except that it is
followed by a kernel version number. Is there a recommended format for
embedding the kernel version number in a Fixes: tag? I think that
information is useful. I haven't found any recommendations for how to do
that in Documentation/process/submitting-patches.rst.
Thanks,
Bart.
linux-next: Fixes tag needs some work in the block tree
Hi all,
In commit
1d200e9d6f63 ("block: Fix writeback throttling W=1 compiler warnings")
Fixes tag
Fixes: e34cbd307477 ("blk-wbt: add general throttling mechanism"; v4.10).
has these problem(s):
- Subject has leading but no trailing quotes
- Subject does not match target commit subject
Just use
git log -1 --format='Fixes: %h ("%s")'
--
Cheers,
Stephen Rothwell
pgpYE3UoOq0be.pgp
Description: OpenPGP digital signature
linux-next: Fixes tag needs some work in the block tree
Hi all,
In commit
8776f3fa15a5 ("io_uring: fix wrong sequence setting logic")
Fixes tag
Fixes: de0617e4671 ("io_uring: add support for marking commands as draining")
has these problem(s):
- SHA1 should be at least 12 digits long
Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
or later) just making sure it is not set (or set to "auto").
--
Cheers,
Stephen Rothwell
pgpm5PC70IbnW.pgp
Description: OpenPGP digital signature
Re: linux-next: Fixes tag needs some work in the block tree
On 19-07-11 16:03:22, Jens Axboe wrote:
> On 7/11/19 3:35 PM, Stephen Rothwell wrote:
> > Hi all,
> >
> > In commit
> >
> >8f3858763d33 ("nvme: fix NULL deref for fabrics options")
> >
> > Fixes tag
> >
> >Fixes: 958f2a0f8 ("nvme-tcp: set the STABLE_WRITES flag when data digests
> >
> > has these problem(s):
> >
> >- SHA1 should be at least 12 digits long
> > Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
> > or later) just making sure it is not set (or set to "auto").
> >- Subject has leading but no trailing parentheses
> >- Subject has leading but no trailing quotes
> >
> > Please do not split Fixes tags over more than one line. Also do not
> > include blank lines among the tags.
I'm sorry for noises here. I will keep that in mind.
Thanks Stephen,
>
> I should have caught that. Since it's top-of-tree and recent, I'll
> amend it.
Jens, I will do it from the next time. Thanks for ammend.
Re: linux-next: Fixes tag needs some work in the block tree
On 7/11/19 3:35 PM, Stephen Rothwell wrote:
> Hi all,
>
> In commit
>
>8f3858763d33 ("nvme: fix NULL deref for fabrics options")
>
> Fixes tag
>
>Fixes: 958f2a0f8 ("nvme-tcp: set the STABLE_WRITES flag when data digests
>
> has these problem(s):
>
>- SHA1 should be at least 12 digits long
> Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
> or later) just making sure it is not set (or set to "auto").
>- Subject has leading but no trailing parentheses
>- Subject has leading but no trailing quotes
>
> Please do not split Fixes tags over more than one line. Also do not
> include blank lines among the tags.
I should have caught that. Since it's top-of-tree and recent, I'll
amend it.
--
Jens Axboe
linux-next: Fixes tag needs some work in the block tree
Hi all,
In commit
8f3858763d33 ("nvme: fix NULL deref for fabrics options")
Fixes tag
Fixes: 958f2a0f8 ("nvme-tcp: set the STABLE_WRITES flag when data digests
has these problem(s):
- SHA1 should be at least 12 digits long
Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
or later) just making sure it is not set (or set to "auto").
- Subject has leading but no trailing parentheses
- Subject has leading but no trailing quotes
Please do not split Fixes tags over more than one line. Also do not
include blank lines among the tags.
--
Cheers,
Stephen Rothwell
pgpvcz5_dAWD1.pgp
Description: OpenPGP digital signature
linux-next: Fixes tag needs some work in the block tree
Hi Jens,
In commit
8f4e80da764e ("block: bounce: make sure that bvec table is updated")
Fixes tag
Fixes: 6dc4f100c ("block: allow bio_for_each_segment_all() to iterate over
multi-page bvec")
has these problem(s):
- SHA1 should be at least 12 digits long
Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
or later) just making sure it is not set (or set to "auto").
--
Cheers,
Stephen Rothwell
pgpJceDTchM6W.pgp
Description: OpenPGP digital signature
