Re: linux-next: Fixes tag needs some work in the jc_docs tree
On 26/2/21 8:39 am, Jonathan Corbet wrote:
Stephen Rothwell writes:
Hi all,
In commit
36eaf08fc283 ("docs: powerpc: Fix tables in syscall64-abi.rst")
Fixes tag
Fixes: 209b44c804c ("docs: powerpc: syscall64-abi.rst: fix a malformed
table")
has these problem(s):
- SHA1 should be at least 12 digits long
I don't think this is worth rebasing for, but in the future it can be
fixed by setting core.abbrev to 12 (or more) or (for git v2.11 or later)
just making sure it is not set (or set to "auto").
I made that tag by hand while "fixing" the changlog on that commit,
which included the full ID. Obviously, counting to 12 is a challenging
task for a slow guy like me...:)
No, no, my local tree tells me that *I* made that tag by hand and failed
to count properly... sorry for the noise!
--
Andrew Donnellan OzLabs, ADL Canberra
a...@linux.ibm.com IBM Australia Limited
Re: linux-next: Fixes tag needs some work in the jc_docs tree
Hi Jon,
On Thu, 25 Feb 2021 14:39:33 -0700 Jonathan Corbet wrote:
>
> I made that tag by hand while "fixing" the changlog on that commit,
> which included the full ID. Obviously, counting to 12 is a challenging
> task for a slow guy like me...:)
Which is why I have a script called clog:
!/bin/bash
git log -1 --format=' %h ("%s")' "$@"
:-)
--
Cheers,
Stephen Rothwell
pgpN0WUwcfVVa.pgp
Description: OpenPGP digital signature
Re: linux-next: Fixes tag needs some work in the jc_docs tree
Stephen Rothwell writes:
> Hi all,
>
> In commit
>
> 36eaf08fc283 ("docs: powerpc: Fix tables in syscall64-abi.rst")
>
> Fixes tag
>
> Fixes: 209b44c804c ("docs: powerpc: syscall64-abi.rst: fix a malformed
> table")
>
> has these problem(s):
>
> - SHA1 should be at least 12 digits long
>
> I don't think this is worth rebasing for, but in the future it can be
> fixed by setting core.abbrev to 12 (or more) or (for git v2.11 or later)
> just making sure it is not set (or set to "auto").
I made that tag by hand while "fixing" the changlog on that commit,
which included the full ID. Obviously, counting to 12 is a challenging
task for a slow guy like me...:)
Thanks,
jon
linux-next: Fixes tag needs some work in the jc_docs tree
Hi all,
In commit
36eaf08fc283 ("docs: powerpc: Fix tables in syscall64-abi.rst")
Fixes tag
Fixes: 209b44c804c ("docs: powerpc: syscall64-abi.rst: fix a malformed table")
has these problem(s):
- SHA1 should be at least 12 digits long
I don't think this is worth rebasing for, but in the future it can be
fixed by setting core.abbrev to 12 (or more) or (for git v2.11 or later)
just making sure it is not set (or set to "auto").
--
Cheers,
Stephen Rothwell
pgpvAu3VqLCXb.pgp
Description: OpenPGP digital signature
linux-next: Fixes tag needs some work in the jc_docs tree
Hi all,
In commit
cf9cadf16b19 ("docs/admin-guide: cgroup-v2: typos and spaces")
Fixes tag
Fixes: 5f9a4f4a70960
has these problem(s):
- missing subject
Maybe you meant
Fixes: 5f9a4f4a7096 ("mm: memcontrol: add the missing numa_stat interface for
cgroup v2")
--
Cheers,
Stephen Rothwell
pgptNU2oaIpLQ.pgp
Description: OpenPGP digital signature
Re: linux-next: Fixes tag needs some work in the jc_docs tree
On Tuesday, 21 May 2019 21:04:31 CEST Jonathan Corbet wrote: > It was just a sigh because there was a little mess that I needed to clean > up — one that I had failed to clean up correctly on my first attempt. > That's all. Apologies for giving you any other sort of impression, that > was not intended. Things happen, life goes on. Ok. Thanks for cleaning it up. Kind regards, Sven signature.asc Description: This is a digitally signed message part.
Re: linux-next: Fixes tag needs some work in the jc_docs tree
On Tue, 21 May 2019 20:52:46 +0200 Sven Eckelmann wrote: > > I'm hoping that's meant to be a joke...? This is certainly not a big > > problem on any scale... > > Not really. If you are so frustrated that you start your reply with "" > then I think that it was not enough for me to explain what I did wrong and > that I am sorry about copying the wrong git commit + not noticing it when > pasting it to the commit message. What else should I do? Jump back in time? It was just a sigh because there was a little mess that I needed to clean up — one that I had failed to clean up correctly on my first attempt. That's all. Apologies for giving you any other sort of impression, that was not intended. Things happen, life goes on. jon
Re: linux-next: Fixes tag needs some work in the jc_docs tree
On Tuesday, 21 May 2019 20:46:03 CEST Jonathan Corbet wrote: > On Tue, 21 May 2019 20:23:48 +0200 > Sven Eckelmann wrote: > > > > > > > > It is ok, I will never send you any patch again. > > I'm hoping that's meant to be a joke...? This is certainly not a big > problem on any scale... Not really. If you are so frustrated that you start your reply with "" then I think that it was not enough for me to explain what I did wrong and that I am sorry about copying the wrong git commit + not noticing it when pasting it to the commit message. What else should I do? Jump back in time? Kind regards, Sven signature.asc Description: This is a digitally signed message part.
Re: linux-next: Fixes tag needs some work in the jc_docs tree
On Tue, 21 May 2019 20:23:48 +0200 Sven Eckelmann wrote: > > > > It is ok, I will never send you any patch again. I'm hoping that's meant to be a joke...? This is certainly not a big problem on any scale... jon
Re: linux-next: Fixes tag needs some work in the jc_docs tree
On Tuesday, 21 May 2019 17:31:07 CEST Jonathan Corbet wrote: > It is ok, I will never send you any patch again. > We want those tags to be right. I'm going to fix this and force-push, > hopefully nobody will get too made at me... Kind regards, Sven signature.asc Description: This is a digitally signed message part.
Re: linux-next: Fixes tag needs some work in the jc_docs tree
On Tue, 21 May 2019 09:18:21 +0200
Sven Eckelmann wrote:
> On Monday, 20 May 2019 23:54:23 CEST Jonathan Corbet wrote:
> [...]
> > Argh, sorry, I should have caught that. Fixed, thanks.
>
> Thanks for trying. Unfortunately it was changed to the wrong value. The
> actual
> commit I wanted to reference in both places of the commit message was:
>
> 8ea8814fcdcb ("LICENSES: Clearly mark dual license only licenses")
>
> It seems I've copied the wrong commit id for some reason when I send it
> though
> the git-fixes alias and it didn't occur to me that I just referenced my own
> patch. Sorry about the confusion.
We want those tags to be right. I'm going to fix this and force-push,
hopefully nobody will get too made at me...
jon
Re: linux-next: Fixes tag needs some work in the jc_docs tree
On Monday, 20 May 2019 23:54:23 CEST Jonathan Corbet wrote:
[...]
> Argh, sorry, I should have caught that. Fixed, thanks.
Thanks for trying. Unfortunately it was changed to the wrong value. The actual
commit I wanted to reference in both places of the commit message was:
8ea8814fcdcb ("LICENSES: Clearly mark dual license only licenses")
It seems I've copied the wrong commit id for some reason when I send it though
the git-fixes alias and it didn't occur to me that I just referenced my own
patch. Sorry about the confusion.
Kind regards,
Sven
signature.asc
Description: This is a digitally signed message part.
Re: linux-next: Fixes tag needs some work in the jc_docs tree
On Monday, 20 May 2019 23:44:35 CEST Stephen Rothwell wrote:
> Hi all,
>
> In commit
>
> 9eaa65e8aad5 ("scripts/spdxcheck.py: Add dual license subdirectory")
>
> Fixes tag
>
> Fixes: 99871f2f9a4d ("scripts/spdxcheck.py: Fix path to deprecated
> licenses")
[...]
Sorry, my fault. I actually meant 8ea8814fcdcb ("LICENSES: Clearly mark dual
license only licenses") at both places in the commit message.
Anything which can be done from my site?
Kind regards,
Sven
signature.asc
Description: This is a digitally signed message part.
Re: linux-next: Fixes tag needs some work in the jc_docs tree
On Tue, 21 May 2019 07:44:35 +1000
Stephen Rothwell wrote:
> In commit
>
> 9eaa65e8aad5 ("scripts/spdxcheck.py: Add dual license subdirectory")
>
> Fixes tag
>
> Fixes: 99871f2f9a4d ("scripts/spdxcheck.py: Fix path to deprecated
> licenses")
>
> has these problem(s):
>
> - Target SHA1 does not exist
>
> Did you mean
>
> Fixes: e6d319f68d4d ("scripts/spdxcheck.py: Fix path to deprecated licenses")
Argh, sorry, I should have caught that. Fixed, thanks.
jon
linux-next: Fixes tag needs some work in the jc_docs tree
Hi all,
In commit
9eaa65e8aad5 ("scripts/spdxcheck.py: Add dual license subdirectory")
Fixes tag
Fixes: 99871f2f9a4d ("scripts/spdxcheck.py: Fix path to deprecated licenses")
has these problem(s):
- Target SHA1 does not exist
Did you mean
Fixes: e6d319f68d4d ("scripts/spdxcheck.py: Fix path to deprecated licenses")
--
Cheers,
Stephen Rothwell
pgp_e63OqOh1U.pgp
Description: OpenPGP digital signature
