Re: linux-next: Signed-off-by missing for commit in the net-next tree
Hi all, On Thu, 10 Dec 2020 21:37:13 +1100 Stephen Rothwell wrote: > > Commit > > 5137d303659d ("net: flow_offload: Fix memory leak for indirect flow block") > > is missing a Signed-off-by from its committer. Sorry, that is in the net tree (not net-next). -- Cheers, Stephen Rothwell pgpWq1_dBee5o.pgp Description: OpenPGP digital signature
linux-next: Signed-off-by missing for commit in the net-next tree
Hi all, Commit 5137d303659d ("net: flow_offload: Fix memory leak for indirect flow block") is missing a Signed-off-by from its committer. -- Cheers, Stephen Rothwell pgpdWo5aLHtjU.pgp Description: OpenPGP digital signature
Re: linux-next: Signed-off-by missing for commit in the net-next tree
On Thu, 2020-09-17 at 08:31 +1000, Stephen Rothwell wrote: > Hi all, > > Commits > > 0d2ffdc8d400 ("net/mlx5: Don't call timecounter cyc2time directly > from 1PPS flow") > 87f3495cbe8d ("net/mlx5: Release clock lock before scheduling a PPS > work") > aac2df7f022e ("net/mlx5: Rename ptp clock info") > fb609b5112bd ("net/mlx5: Always use container_of to find mdev > pointer from clock struct") > ec529b44abfe ("net/mlx5: remove erroneous fallthrough") > > are missing a Signed-off-by from their committer. > Sorry for the mix-up, i overwrote the old mlnx email address with the new nvidia one but didn't consider the committer email :S.
linux-next: Signed-off-by missing for commit in the net-next tree
Hi all, Commits 0d2ffdc8d400 ("net/mlx5: Don't call timecounter cyc2time directly from 1PPS flow") 87f3495cbe8d ("net/mlx5: Release clock lock before scheduling a PPS work") aac2df7f022e ("net/mlx5: Rename ptp clock info") fb609b5112bd ("net/mlx5: Always use container_of to find mdev pointer from clock struct") ec529b44abfe ("net/mlx5: remove erroneous fallthrough") are missing a Signed-off-by from their committer. -- Cheers, Stephen Rothwell pgpqo3tFRSMaz.pgp Description: OpenPGP digital signature
linux-next: Signed-off-by missing for commit in the net-next tree
Hi all, Commit 0093870aa891 ("batman-adv: Migrate to linux/prandom.h") is missing a Signed-off-by from its committer. -- Cheers, Stephen Rothwell pgpLCAWM2Sq7P.pgp Description: OpenPGP digital signature
linux-next: Signed-off-by missing for commit in the net-next tree
Hi all, Commit 6c4e9bcfb489 ("net/mlx5: Delete extra dump stack that gives nothing") is missing a Signed-off-by from its committer. -- Cheers, Stephen Rothwell pgpbtbU05hg6_.pgp Description: OpenPGP digital signature
linux-next: Signed-off-by missing for commit in the net-next tree
Hi all, Commit 1315971fea66 ("net/mlx5e: Fix missing switch_id for representors") is missing a Signed-off-by from its committer. -- Cheers, Stephen Rothwell pgpjpTuMGtYOK.pgp Description: OpenPGP digital signature
linux-next: Signed-off-by missing for commit in the net-next tree
Hi all, Commit 07bab9502641 ("net/mlx5: E-Switch, Refactor eswitch ingress acl codes") is missing a Signed-off-by from its committer. -- Cheers, Stephen Rothwell pgpTHwbH_eR74.pgp Description: OpenPGP digital signature
linux-next: Signed-off-by missing for commit in the net-next tree
Hi all, Commit be904b855200 ("sfc: make capability checking a nic_type function") is missing a Signed-off-by from its author. -- Cheers, Stephen Rothwell pgp4jUme3tRDf.pgp Description: OpenPGP digital signature
Re: linux-next: Signed-off-by missing for commit in the net-next tree
On 10/2/19 3:06 PM, Stephen Rothwell wrote: > Hi all, > > Commits > > 0f04f8ea62ce ("Minor fixes to the CAIF Transport drivers Kconfig file") > 21d549769e79 ("Isolate CAIF transport drivers into their own menu") > 0903102f5785 ("Clean up the net/caif/Kconfig menu") > > are missing a Signed-off-by from their authors. > > I guess and may be the > same person? Please be consistent. Yes. Yes, will do that. -- ~Randy
linux-next: Signed-off-by missing for commit in the net-next tree
Hi all, Commits 0f04f8ea62ce ("Minor fixes to the CAIF Transport drivers Kconfig file") 21d549769e79 ("Isolate CAIF transport drivers into their own menu") 0903102f5785 ("Clean up the net/caif/Kconfig menu") are missing a Signed-off-by from their authors. I guess and may be the same person? Please be consistent. -- Cheers, Stephen Rothwell pgpk5qlos1KUv.pgp Description: OpenPGP digital signature
Re: linux-next: Signed-off-by missing for commit in the net-next tree
Hi Stephen, On Wed, Sep 11, 2019 at 12:41:03AM +1000, Stephen Rothwell wrote: > Hi all, > > Commit > > 9d71dd0c7009 ("can: add support of SAE J1939 protocol") > > is missing a Signed-off-by from its author. > > [Not sure if I should complain about this one ...] Here is the original pull request message for this patch series: "The final patch is the collective effort of many entities (The j1939 authors: Oliver Hartkopp, Bastian Stender, Elenita Hinds, kbuild test robot, Kurt Van Dijck, Maxime Jayat, Robin van der Gracht, Oleksij Rempel, Marc Kleine-Budde). It adds support of SAE J1939 protocol to the CAN networking stack." https://www.mail-archive.com/netdev@vger.kernel.org/msg313476.html Since the patch can be hardly assigned to one author we deiced to use address of CAN mailing list. Best regards, Oleksij Rempel -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0| Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- |
Re: linux-next: Signed-off-by missing for commit in the net-next tree
On Wed, 2019-09-11 at 00:42 +1000, Stephen Rothwell wrote: > Hi all, > > Commit > > aa43ae121675 ("iwlwifi: LTR updates") > > is missing a Signed-off-by from its committer. Oops, that was my fault. What can we do about it? Is it enough if I give my s-o-b publicly here? I hereby sign off this change: Signed-off-by: Luca Coelho -- Cheers, Luca.
linux-next: Signed-off-by missing for commit in the net-next tree
Hi all, Commit aa43ae121675 ("iwlwifi: LTR updates") is missing a Signed-off-by from its committer. -- Cheers, Stephen Rothwell pgpMPkHMrX50z.pgp Description: OpenPGP digital signature
linux-next: Signed-off-by missing for commit in the net-next tree
Hi all, Commit 9d71dd0c7009 ("can: add support of SAE J1939 protocol") is missing a Signed-off-by from its author. [Not sure if I should complain about this one ...] -- Cheers, Stephen Rothwell pgpu3pVOzLkqZ.pgp Description: OpenPGP digital signature
Re: linux-next: Signed-off-by missing for commit in the net-next tree
Hi Stephen, Sure, thanks! Yifeng On Tue, Aug 6, 2019 at 6:54 PM Stephen Rothwell wrote: > > Hi Yifeng, > > On Tue, 6 Aug 2019 16:37:26 -0700 Yifeng Sun wrote: > > > > My apologies, thanks for the email. Please add the signed-off if you can. > > Dave does not rebase his trees, so that is not possible. Just remember > for next time, thanks :-) > > -- > Cheers, > Stephen Rothwell
Re: linux-next: Signed-off-by missing for commit in the net-next tree
Hi Yifeng, On Tue, 6 Aug 2019 16:37:26 -0700 Yifeng Sun wrote: > > My apologies, thanks for the email. Please add the signed-off if you can. Dave does not rebase his trees, so that is not possible. Just remember for next time, thanks :-) -- Cheers, Stephen Rothwell pgpsJqsY4ng0g.pgp Description: OpenPGP digital signature
Re: linux-next: Signed-off-by missing for commit in the net-next tree
Hi Stephen, My apologies, thanks for the email. Please add the signed-off if you can. Signed-off-by: Yifeng Sun Thanks, Yifeng On Tue, Aug 6, 2019 at 4:30 PM Stephen Rothwell wrote: > > Hi all, > > Commit > > aa733660dbd8 ("openvswitch: Print error when ovs_execute_actions() fails") > > is missing a Signed-off-by from its author. > > -- > Cheers, > Stephen Rothwell
linux-next: Signed-off-by missing for commit in the net-next tree
Hi all, Commit aa733660dbd8 ("openvswitch: Print error when ovs_execute_actions() fails") is missing a Signed-off-by from its author. -- Cheers, Stephen Rothwell pgpfvIM92z2r0.pgp Description: OpenPGP digital signature
linux-next: Signed-off-by missing for commit in the net-next tree
Hi all, Commit 6e52fca36c67 ("tc-tests: Add tc action ct tests") is missing a Signed-off-by from its author. -- Cheers, Stephen Rothwell pgpzirs1HLpWZ.pgp Description: OpenPGP digital signature
Re: linux-next: Signed-off-by missing for commit in the net-next tree
From: lepton Date: Wed, 16 Jan 2019 14:27:45 -0800 > I sent another version with signed off serveral days ago: > > https://www.spinics.net/lists/netdev/msg543829.html > > So for some reason it got missed? I didn't see it before I applied the initial patch because I was heavily backlogged, I saw it afterwards...
Re: linux-next: Signed-off-by missing for commit in the net-next tree
From: Stephen Rothwell Date: Thu, 17 Jan 2019 08:06:19 +1100 > Hi all, > > Commit > > a22d3251423f ("Fix ERROR:do not initialise statics to 0 in af_vsock.c") > > is missing a Signed-off-by from its author. I know, I caught it right after I pushed out, sorry :( I really have to go back to working on that automation so this stops happening. My bad.
linux-next: Signed-off-by missing for commit in the net-next tree
Hi all, Commit a22d3251423f ("Fix ERROR:do not initialise statics to 0 in af_vsock.c") is missing a Signed-off-by from its author. -- Cheers, Stephen Rothwell pgp8AvKEBACNp.pgp Description: OpenPGP digital signature
linux-next: Signed-off-by missing for commit in the net-next tree
Hi all, Commit 9cd00a8aa42e ("net: phy: phylink: Poll link GPIOs") is missing a Signed-off-by from its author. -- Cheers, Stephen Rothwell pgprfBXsa8EOP.pgp Description: OpenPGP digital signature
linux-next: Signed-off-by missing for commit in the net-next tree
Hi all, Commit 9cd00a8aa42e ("net: phy: phylink: Poll link GPIOs") is missing a Signed-off-by from its author. -- Cheers, Stephen Rothwell pgprfBXsa8EOP.pgp Description: OpenPGP digital signature
linux-next: Signed-off-by missing for commit in the net-next tree
Hi all, Commit cbad52e92ad7 ("sfc: don't warn on successful change of MAC") is missing a Signed-off-by from its author. -- Cheers, Stephen Rothwell
linux-next: Signed-off-by missing for commit in the net-next tree
Hi all, Commit cbad52e92ad7 ("sfc: don't warn on successful change of MAC") is missing a Signed-off-by from its author. -- Cheers, Stephen Rothwell
Re: linux-next: Signed-off-by missing for commit in the net-next tree
Francois, On Wed, Nov 01, 2017 at 11:55:24AM +0100, Francois Romieu wrote: > Kirill Smelkov: > [...] > > I was keeping you in To and Cc all the time but got no reply at all since my > > first posting from ~ 1 month ago. > > I thought it was longer than that. Sorry for the frustrating excess delay. > > As Eric already said there is no problem and I am perfectly fine with > the current attribution of this code. Thanks for feedback. > Use of errno.h::ELNRNG is really unusual but it's a different topic. I wanted the error returned due to internal inconsistency to be different from the error returned when there is error in provided parameters from ethtool. Your original patch was returning EINVAL for both cases which made it hard to understand what is going on when the kernel was refusing to accept something from user. That's why I used ELNRNG (link number out of range) for situation when lookup of timings vector by current link speed failed. A bit unusual, yes, but this was the closest to the situation after studying `errno -l` output. Hope this clarifies a bit. Please feel free to suggest a change here, Kirill
Re: linux-next: Signed-off-by missing for commit in the net-next tree
Francois, On Wed, Nov 01, 2017 at 11:55:24AM +0100, Francois Romieu wrote: > Kirill Smelkov : > [...] > > I was keeping you in To and Cc all the time but got no reply at all since my > > first posting from ~ 1 month ago. > > I thought it was longer than that. Sorry for the frustrating excess delay. > > As Eric already said there is no problem and I am perfectly fine with > the current attribution of this code. Thanks for feedback. > Use of errno.h::ELNRNG is really unusual but it's a different topic. I wanted the error returned due to internal inconsistency to be different from the error returned when there is error in provided parameters from ethtool. Your original patch was returning EINVAL for both cases which made it hard to understand what is going on when the kernel was refusing to accept something from user. That's why I used ELNRNG (link number out of range) for situation when lookup of timings vector by current link speed failed. A bit unusual, yes, but this was the closest to the situation after studying `errno -l` output. Hope this clarifies a bit. Please feel free to suggest a change here, Kirill
Re: linux-next: Signed-off-by missing for commit in the net-next tree
Kirill Smelkov: [...] > I was keeping you in To and Cc all the time but got no reply at all since my > first posting from ~ 1 month ago. I thought it was longer than that. Sorry for the frustrating excess delay. As Eric already said there is no problem and I am perfectly fine with the current attribution of this code. Use of errno.h::ELNRNG is really unusual but it's a different topic. -- Ueimor
Re: linux-next: Signed-off-by missing for commit in the net-next tree
Kirill Smelkov : [...] > I was keeping you in To and Cc all the time but got no reply at all since my > first posting from ~ 1 month ago. I thought it was longer than that. Sorry for the frustrating excess delay. As Eric already said there is no problem and I am perfectly fine with the current attribution of this code. Use of errno.h::ELNRNG is really unusual but it's a different topic. -- Ueimor
Re: linux-next: Signed-off-by missing for commit in the net-next tree
Francois, On Tue, Oct 31, 2017 at 04:40:19PM +1100, Stephen Rothwell wrote: > Hi all, > > Commit > > 509708310cf9 ("r8169: Add support for interrupt coalesce tuning (ethtool > -C)") > > is missing a Signed-off-by from its author (or its author is wrong). Could we please get signoff for this your patch from 2012 which I've reworked a bit to be commit 509708310cf9 ? https://www.spinics.net/lists/netdev/msg217984.html https://www.spinics.net/lists/netdev/msg218207.html I was keeping you in To and Cc all the time but got no reply at all since my first posting from ~ 1 month ago. Thanks beforehand, Kirill
Re: linux-next: Signed-off-by missing for commit in the net-next tree
Francois, On Tue, Oct 31, 2017 at 04:40:19PM +1100, Stephen Rothwell wrote: > Hi all, > > Commit > > 509708310cf9 ("r8169: Add support for interrupt coalesce tuning (ethtool > -C)") > > is missing a Signed-off-by from its author (or its author is wrong). Could we please get signoff for this your patch from 2012 which I've reworked a bit to be commit 509708310cf9 ? https://www.spinics.net/lists/netdev/msg217984.html https://www.spinics.net/lists/netdev/msg218207.html I was keeping you in To and Cc all the time but got no reply at all since my first posting from ~ 1 month ago. Thanks beforehand, Kirill
Re: linux-next: Signed-off-by missing for commit in the net-next tree
On Tue, 2017-10-31 at 09:14 +0300, Kirill Smelkov wrote: > Francois, > > On Tue, Oct 31, 2017 at 04:40:19PM +1100, Stephen Rothwell wrote: > > Hi all, > > > > Commit > > > > 509708310cf9 ("r8169: Add support for interrupt coalesce tuning (ethtool > > -C)") > > > > is missing a Signed-off-by from its author (or its author is wrong). > > Could we please get signoff for this your patch from 2012 which I've > reworked a bit to be commit 509708310cf9 ? > > https://www.spinics.net/lists/netdev/msg217984.html > https://www.spinics.net/lists/netdev/msg218207.html > > I was keeping you in To and Cc all the time but got no reply at all since my > first posting from ~ 1 month ago. Nothing we can do, patch is merged, we can not modify it anymore. You provided all the rationale in the changelog, so no worries.
Re: linux-next: Signed-off-by missing for commit in the net-next tree
On Tue, 2017-10-31 at 09:14 +0300, Kirill Smelkov wrote: > Francois, > > On Tue, Oct 31, 2017 at 04:40:19PM +1100, Stephen Rothwell wrote: > > Hi all, > > > > Commit > > > > 509708310cf9 ("r8169: Add support for interrupt coalesce tuning (ethtool > > -C)") > > > > is missing a Signed-off-by from its author (or its author is wrong). > > Could we please get signoff for this your patch from 2012 which I've > reworked a bit to be commit 509708310cf9 ? > > https://www.spinics.net/lists/netdev/msg217984.html > https://www.spinics.net/lists/netdev/msg218207.html > > I was keeping you in To and Cc all the time but got no reply at all since my > first posting from ~ 1 month ago. Nothing we can do, patch is merged, we can not modify it anymore. You provided all the rationale in the changelog, so no worries.
linux-next: Signed-off-by missing for commit in the net-next tree
Hi all, Commit 509708310cf9 ("r8169: Add support for interrupt coalesce tuning (ethtool -C)") is missing a Signed-off-by from its author (or its author is wrong). -- Cheers, Stephen Rothwell
linux-next: Signed-off-by missing for commit in the net-next tree
Hi all, Commit 509708310cf9 ("r8169: Add support for interrupt coalesce tuning (ethtool -C)") is missing a Signed-off-by from its author (or its author is wrong). -- Cheers, Stephen Rothwell
linux-next: Signed-off-by missing for commit in the net-next tree
Hi all, Commit 8f1975e31d8e ("inetpeer: speed up inetpeer_invalidate_tree()") is missing a Signed-off-by from its author. -- Cheers, Stephen Rothwell
linux-next: Signed-off-by missing for commit in the net-next tree
Hi all, Commit 8f1975e31d8e ("inetpeer: speed up inetpeer_invalidate_tree()") is missing a Signed-off-by from its author. -- Cheers, Stephen Rothwell
Re: linux-next: Signed-off-by missing for commit in the net-next tree
From: David AhernDate: Wed, 30 Aug 2017 10:53:48 -0600 > On 8/30/17 10:51 AM, Stephen Rothwell wrote: >> Hi all, >> >> Commit >> >> 1b70d792cf67 ("ipv6: Use rt6i_idev index for echo replies to a local >> address") >> >> is missing a Signed-off-by from its author. >> > > Eric pointed this out last night. The commit message copied output from > a command that contained '---' so git ignored the remainder of the message. Yes, it unfortunately got clipped off by GIT due to how the commit message was written. :(
Re: linux-next: Signed-off-by missing for commit in the net-next tree
From: David Ahern Date: Wed, 30 Aug 2017 10:53:48 -0600 > On 8/30/17 10:51 AM, Stephen Rothwell wrote: >> Hi all, >> >> Commit >> >> 1b70d792cf67 ("ipv6: Use rt6i_idev index for echo replies to a local >> address") >> >> is missing a Signed-off-by from its author. >> > > Eric pointed this out last night. The commit message copied output from > a command that contained '---' so git ignored the remainder of the message. Yes, it unfortunately got clipped off by GIT due to how the commit message was written. :(
Re: linux-next: Signed-off-by missing for commit in the net-next tree
Hi David, On Wed, 30 Aug 2017 10:53:48 -0600 David Ahernwrote: > > On 8/30/17 10:51 AM, Stephen Rothwell wrote: > > Hi all, > > > > Commit > > > > 1b70d792cf67 ("ipv6: Use rt6i_idev index for echo replies to a local > > address") > > > > is missing a Signed-off-by from its author. > > Eric pointed this out last night. The commit message copied output from > a command that contained '---' so git ignored the remainder of the message. Rats! -- Cheers, Stephen Rothwell
Re: linux-next: Signed-off-by missing for commit in the net-next tree
Hi David, On Wed, 30 Aug 2017 10:53:48 -0600 David Ahern wrote: > > On 8/30/17 10:51 AM, Stephen Rothwell wrote: > > Hi all, > > > > Commit > > > > 1b70d792cf67 ("ipv6: Use rt6i_idev index for echo replies to a local > > address") > > > > is missing a Signed-off-by from its author. > > Eric pointed this out last night. The commit message copied output from > a command that contained '---' so git ignored the remainder of the message. Rats! -- Cheers, Stephen Rothwell
Re: linux-next: Signed-off-by missing for commit in the net-next tree
On 8/30/17 10:51 AM, Stephen Rothwell wrote: > Hi all, > > Commit > > 1b70d792cf67 ("ipv6: Use rt6i_idev index for echo replies to a local > address") > > is missing a Signed-off-by from its author. > Eric pointed this out last night. The commit message copied output from a command that contained '---' so git ignored the remainder of the message.
Re: linux-next: Signed-off-by missing for commit in the net-next tree
On 8/30/17 10:51 AM, Stephen Rothwell wrote: > Hi all, > > Commit > > 1b70d792cf67 ("ipv6: Use rt6i_idev index for echo replies to a local > address") > > is missing a Signed-off-by from its author. > Eric pointed this out last night. The commit message copied output from a command that contained '---' so git ignored the remainder of the message.
linux-next: Signed-off-by missing for commit in the net-next tree
Hi all, Commit 1b70d792cf67 ("ipv6: Use rt6i_idev index for echo replies to a local address") is missing a Signed-off-by from its author. -- Cheers, Stephen Rothwell
linux-next: Signed-off-by missing for commit in the net-next tree
Hi all, Commit 1b70d792cf67 ("ipv6: Use rt6i_idev index for echo replies to a local address") is missing a Signed-off-by from its author. -- Cheers, Stephen Rothwell