Re: linux-next: Signed-off-by missing for commit in the rcu tree

[Paul E. McKenney]

On Mon, Mar 08, 2021 at 05:03:27PM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> Commit
> 
>   3e90d423e754 ("EXP net: phy: make mdio_bus_phy_suspend/resume as 
> __maybe_unused")
> 
> is missing a Signed-off-by from its committer.

Fixed, thank you and apologies!

Thanx, Paul

linux-next: Signed-off-by missing for commit in the rcu tree

[Stephen Rothwell]

Hi all,

Commit

  3e90d423e754 ("EXP net: phy: make mdio_bus_phy_suspend/resume as 
__maybe_unused")

is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell


pgpqnFoVCNSEx.pgp
Description: OpenPGP digital signature

Re: linux-next: Signed-off-by missing for commit in the rcu tree

[Paul E. McKenney]

On Sun, Jan 10, 2021 at 01:24:32PM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> Commit
> 
>   cffdc9c7c24c ("EXP sched: Print list of runnable tasks in the current rq")
> 
> is missing a Signed-off-by from its author.
> 
> Paul, remember the rules for -next:
> 
> You will need to ensure that the patches/commits in your tree/series have
> been:
>  * submitted under GPL v2 (or later) and include the Contributor's
> Signed-off-by,
>  * posted to the relevant mailing list,
>  * reviewed by you (or another maintainer of your subsystem tree),
>  * successfully unit tested, and 
>  * destined for the current or next Linux merge window.
> 
> Basically, this should be just what you would send to Linus (or ask him
> to fetch).  It is allowed to be rebased if you deem it necessary.

Please accept my apologies for my messing this up.

Valentin, may I apply your Signed-off-by?  Otherwise, I am liable to
again get it into -next where it is not yet ready to go.  But without it,
rcutorture gets noise from 12e08bc4d ("sched/hotplug: Consolidate task
migration on CPU unplug") that is otherwise difficult to diagnose.  :-/

Thanx, Paul

linux-next: Signed-off-by missing for commit in the rcu tree

[Stephen Rothwell]

Hi all,

Commit

  cffdc9c7c24c ("EXP sched: Print list of runnable tasks in the current rq")

is missing a Signed-off-by from its author.

Paul, remember the rules for -next:

You will need to ensure that the patches/commits in your tree/series have
been:
 * submitted under GPL v2 (or later) and include the Contributor's
Signed-off-by,
 * posted to the relevant mailing list,
 * reviewed by you (or another maintainer of your subsystem tree),
 * successfully unit tested, and 
 * destined for the current or next Linux merge window.

Basically, this should be just what you would send to Linus (or ask him
to fetch).  It is allowed to be rebased if you deem it necessary.

-- 
Cheers,
Stephen Rothwell


pgpXz95bI8xAy.pgp
Description: OpenPGP digital signature

Re: linux-next: Signed-off-by missing for commit in the rcu tree

[Paul E. McKenney]

On Sun, Nov 22, 2020 at 09:09:13PM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> On Sun, 22 Nov 2020 21:08:10 +1100 Stephen Rothwell  
> wrote:
> >
> > Commit
> > 
> >   ca3bd09a3a49 ("rcu: Allow rcu_irq_enter_check_tick() from NMI")
> > 
> > is missing a Signed-off-by from its author.
> 
> Please ignore this bit.
> dd

But good catch on the other one, will fix!

Thanx, Paul

Re: linux-next: Signed-off-by missing for commit in the rcu tree

[Stephen Rothwell]

Hi all,

On Sun, 22 Nov 2020 21:08:10 +1100 Stephen Rothwell  
wrote:
>
> Commit
> 
>   ca3bd09a3a49 ("rcu: Allow rcu_irq_enter_check_tick() from NMI")
> 
> is missing a Signed-off-by from its author.

Please ignore this bit.
dd

-- 
Cheers,
Stephen Rothwell


pgps8l6kVzv4f.pgp
Description: OpenPGP digital signature

linux-next: Signed-off-by missing for commit in the rcu tree

[Stephen Rothwell]

Hi all,

Commit

  ca3bd09a3a49 ("rcu: Allow rcu_irq_enter_check_tick() from NMI")

is missing a Signed-off-by from its author.

Commit

  00dc4fd2297c ("tools/rcutorture: Make identify_qemu_vcpus() independent of 
local language")

is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell


pgpF0suXe37Kv.pgp
Description: OpenPGP digital signature

Re: linux-next: Signed-off-by missing for commit in the rcu tree

[Paul E. McKenney]

On Mon, Sep 28, 2020 at 10:33:13AM -0700, Paul E. McKenney wrote:
> On Mon, Sep 28, 2020 at 09:57:29AM +0200, Peter Zijlstra wrote:
> > On Thu, Sep 17, 2020 at 11:00:05AM -0700, Paul E. McKenney wrote:
> > > On Thu, Sep 17, 2020 at 01:26:52PM +1000, Stephen Rothwell wrote:
> > > > Hi all,
> > > > 
> > > > Commit
> > > > 
> > > >   903c5302fa2d ("sched/core: Allow try_invoke_on_locked_down_task() 
> > > > with irqs disabled")
> > > > 
> > > > is missing a Signed-off-by from its author and committer.
> > > > 
> > > > I didn't complain about this when it was first present because I figured
> > > > it was just a debugging commit that would be removed quickly.  However,
> > > > there are now quite a few follow up commits ...
> > > 
> > > Without Peter's Signed-off-by, I clearly won't be submitting it to the
> > > upcoming merge window.
> > > 
> > > Peter, this is now quite close to your original patch.  May I please
> > > add your Signed-off-by?
> > 
> > Sure!
> 
> Much appreciated!!!
> 
> But I already replaced that commit with one that moves the call to
> try_invoke_on_locked_down_task() an interrupts-enabled region of code.
> Which is probably what I should have done to start with...  :-/

Except that Marco Elver is making that fail, so I am resuscitating your
patch with your Signed-off-by, as shown below.

So once again, much appreciated!!!

Thanx, Paul



commit 444ef3bbd0f243b912fdfd51f326704f8ee872bf
Author: Peter Zijlstra 
Date:   Sat Aug 29 10:22:24 2020 -0700

sched/core: Allow try_invoke_on_locked_down_task() with irqs disabled

The try_invoke_on_locked_down_task() function currently requires
that interrupts be enabled, but it is called with interrupts
disabled from rcu_print_task_stall(), resulting in an "IRQs not
enabled as expected" diagnostic.  This commit therefore updates
try_invoke_on_locked_down_task() to use raw_spin_lock_irqsave() instead
of raw_spin_lock_irq(), thus allowing use from either context.

Link: https://lore.kernel.org/lkml/903d5805ab908...@google.com/
Link: 
https://lore.kernel.org/lkml/20200928075729.gc2...@hirez.programming.kicks-ass.net/
Reported-by: syzbot+cb3b69ae80afd6535...@syzkaller.appspotmail.com
Signed-off-by: Peter Zijlstra 
Signed-off-by: Paul E. McKenney 

diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index e172f2d..09ef5cf 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -2984,7 +2984,7 @@ try_to_wake_up(struct task_struct *p, unsigned int state, 
int wake_flags)
 
 /**
  * try_invoke_on_locked_down_task - Invoke a function on task in fixed state
- * @p: Process for which the function is to be invoked.
+ * @p: Process for which the function is to be invoked, can be @current.
  * @func: Function to invoke.
  * @arg: Argument to function.
  *
@@ -3002,12 +3002,11 @@ try_to_wake_up(struct task_struct *p, unsigned int 
state, int wake_flags)
  */
 bool try_invoke_on_locked_down_task(struct task_struct *p, bool (*func)(struct 
task_struct *t, void *arg), void *arg)
 {
-   bool ret = false;
struct rq_flags rf;
+   bool ret = false;
struct rq *rq;
 
-   lockdep_assert_irqs_enabled();
-   raw_spin_lock_irq(>pi_lock);
+   raw_spin_lock_irqsave(>pi_lock, rf.flags);
if (p->on_rq) {
rq = __task_rq_lock(p, );
if (task_rq(p) == rq)
@@ -3024,7 +3023,7 @@ bool try_invoke_on_locked_down_task(struct task_struct 
*p, bool (*func)(struct t
ret = func(p, arg);
}
}
-   raw_spin_unlock_irq(>pi_lock);
+   raw_spin_unlock_irqrestore(>pi_lock, rf.flags);
return ret;
 }
 

Re: linux-next: Signed-off-by missing for commit in the rcu tree

[Paul E. McKenney]

On Wed, Sep 30, 2020 at 08:37:17AM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> Commit
> 
>   5f5f44ca646f ("EXP Revert "KVM: Check the allocation of pv cpu mask"")
> 
> is missing a Signed-off-by from its committer.

Good catch, fixed in current rcu/next, and apologies for the bother!

Thanx, Paul

linux-next: Signed-off-by missing for commit in the rcu tree

[Stephen Rothwell]

Hi all,

Commit

  5f5f44ca646f ("EXP Revert "KVM: Check the allocation of pv cpu mask"")

is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell


pgpQr7hTQAwsj.pgp
Description: OpenPGP digital signature

Re: linux-next: Signed-off-by missing for commit in the rcu tree

[Paul E. McKenney]

On Mon, Sep 28, 2020 at 09:57:29AM +0200, Peter Zijlstra wrote:
> On Thu, Sep 17, 2020 at 11:00:05AM -0700, Paul E. McKenney wrote:
> > On Thu, Sep 17, 2020 at 01:26:52PM +1000, Stephen Rothwell wrote:
> > > Hi all,
> > > 
> > > Commit
> > > 
> > >   903c5302fa2d ("sched/core: Allow try_invoke_on_locked_down_task() with 
> > > irqs disabled")
> > > 
> > > is missing a Signed-off-by from its author and committer.
> > > 
> > > I didn't complain about this when it was first present because I figured
> > > it was just a debugging commit that would be removed quickly.  However,
> > > there are now quite a few follow up commits ...
> > 
> > Without Peter's Signed-off-by, I clearly won't be submitting it to the
> > upcoming merge window.
> > 
> > Peter, this is now quite close to your original patch.  May I please
> > add your Signed-off-by?
> 
> Sure!

Much appreciated!!!

But I already replaced that commit with one that moves the call to
try_invoke_on_locked_down_task() an interrupts-enabled region of code.
Which is probably what I should have done to start with...  :-/

Thanx, Paul

Re: linux-next: Signed-off-by missing for commit in the rcu tree

[Peter Zijlstra]

On Thu, Sep 17, 2020 at 11:00:05AM -0700, Paul E. McKenney wrote:
> On Thu, Sep 17, 2020 at 01:26:52PM +1000, Stephen Rothwell wrote:
> > Hi all,
> > 
> > Commit
> > 
> >   903c5302fa2d ("sched/core: Allow try_invoke_on_locked_down_task() with 
> > irqs disabled")
> > 
> > is missing a Signed-off-by from its author and committer.
> > 
> > I didn't complain about this when it was first present because I figured
> > it was just a debugging commit that would be removed quickly.  However,
> > there are now quite a few follow up commits ...
> 
> Without Peter's Signed-off-by, I clearly won't be submitting it to the
> upcoming merge window.
> 
> Peter, this is now quite close to your original patch.  May I please
> add your Signed-off-by?

Sure!

Re: linux-next: Signed-off-by missing for commit in the rcu tree

[Stephen Rothwell]

Hi Paul,

On Thu, 17 Sep 2020 11:00:05 -0700 "Paul E. McKenney"  
wrote:
>
> On Thu, Sep 17, 2020 at 01:26:52PM +1000, Stephen Rothwell wrote:
> > 
> > Commit
> > 
> >   903c5302fa2d ("sched/core: Allow try_invoke_on_locked_down_task() with 
> > irqs disabled")
> > 
> > is missing a Signed-off-by from its author and committer.
> > 
> > I didn't complain about this when it was first present because I figured
> > it was just a debugging commit that would be removed quickly.  However,
> > there are now quite a few follow up commits ...  
> 
> Without Peter's Signed-off-by, I clearly won't be submitting it to the
> upcoming merge window.
> 
> Peter, this is now quite close to your original patch.  May I please
> add your Signed-off-by?

Rebased today, but still no SOB lines.

-- 
Cheers,
Stephen Rothwell


pgpIWXXXlJzAo.pgp
Description: OpenPGP digital signature

Re: linux-next: Signed-off-by missing for commit in the rcu tree

[Paul E. McKenney]

On Thu, Sep 17, 2020 at 01:26:52PM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> Commit
> 
>   903c5302fa2d ("sched/core: Allow try_invoke_on_locked_down_task() with irqs 
> disabled")
> 
> is missing a Signed-off-by from its author and committer.
> 
> I didn't complain about this when it was first present because I figured
> it was just a debugging commit that would be removed quickly.  However,
> there are now quite a few follow up commits ...

Without Peter's Signed-off-by, I clearly won't be submitting it to the
upcoming merge window.

Peter, this is now quite close to your original patch.  May I please
add your Signed-off-by?

Thanx, Paul

linux-next: Signed-off-by missing for commit in the rcu tree

[Stephen Rothwell]

Hi all,

Commit

  903c5302fa2d ("sched/core: Allow try_invoke_on_locked_down_task() with irqs 
disabled")

is missing a Signed-off-by from its author and committer.

I didn't complain about this when it was first present because I figured
it was just a debugging commit that would be removed quickly.  However,
there are now quite a few follow up commits ...

-- 
Cheers,
Stephen Rothwell


pgphV45UEgdpW.pgp
Description: OpenPGP digital signature

Re: linux-next: Signed-off-by missing for commit in the rcu tree

[Paul E. McKenney]

On Tue, Apr 24, 2018 at 07:48:44AM +1000, Stephen Rothwell wrote:
> Hi Paul,
> 
> Commit
> 
>   bbf9d3657c39 ("doc: Ensure whatisRCU.txt actually says what RCU is")
> 
> is missing a Signed-off-by from its committer.

Good catch, fixed!

Thanx, Paul

Re: linux-next: Signed-off-by missing for commit in the rcu tree

[Paul E. McKenney]

On Tue, Apr 24, 2018 at 07:48:44AM +1000, Stephen Rothwell wrote:
> Hi Paul,
> 
> Commit
> 
>   bbf9d3657c39 ("doc: Ensure whatisRCU.txt actually says what RCU is")
> 
> is missing a Signed-off-by from its committer.

Good catch, fixed!

Thanx, Paul

linux-next: Signed-off-by missing for commit in the rcu tree

[Stephen Rothwell]

Hi Paul,

Commit

  bbf9d3657c39 ("doc: Ensure whatisRCU.txt actually says what RCU is")

is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell


pgpFla5kDNkdQ.pgp
Description: OpenPGP digital signature

linux-next: Signed-off-by missing for commit in the rcu tree

[Stephen Rothwell]

Hi Paul,

Commit

  bbf9d3657c39 ("doc: Ensure whatisRCU.txt actually says what RCU is")

is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell


pgpFla5kDNkdQ.pgp
Description: OpenPGP digital signature

Re: linux-next: Signed-off-by missing for commit in the rcu tree

[Paul E. McKenney]

On Tue, Feb 27, 2018 at 09:38:16AM +1100, Stephen Rothwell wrote:
> Hi Paul,
> 
> Commit
> 
>   2a84d1aef423 ("rcu: Inline rcu_preempt_do_callback() into its sole caller")
> 
> is missing a Signed-off-by from its committer.

That would be because idiot here left the "-s" off of "git am"...

Apologies for the hassle, rebased to fix.

Thanx, Paul

Re: linux-next: Signed-off-by missing for commit in the rcu tree

[Paul E. McKenney]

On Tue, Feb 27, 2018 at 09:38:16AM +1100, Stephen Rothwell wrote:
> Hi Paul,
> 
> Commit
> 
>   2a84d1aef423 ("rcu: Inline rcu_preempt_do_callback() into its sole caller")
> 
> is missing a Signed-off-by from its committer.

That would be because idiot here left the "-s" off of "git am"...

Apologies for the hassle, rebased to fix.

Thanx, Paul

linux-next: Signed-off-by missing for commit in the rcu tree

[Stephen Rothwell]

Hi Paul,

Commit

  2a84d1aef423 ("rcu: Inline rcu_preempt_do_callback() into its sole caller")

is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell


pgp_wLYOqZZLw.pgp
Description: OpenPGP digital signature

linux-next: Signed-off-by missing for commit in the rcu tree

[Stephen Rothwell]

Hi Paul,

Commit

  2a84d1aef423 ("rcu: Inline rcu_preempt_do_callback() into its sole caller")

is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell


pgp_wLYOqZZLw.pgp
Description: OpenPGP digital signature

Re: linux-next: Signed-off-by missing for commit in the rcu tree

[Paul E. McKenney]

On Wed, Nov 29, 2017 at 11:29:03AM +0800, Lihao Liang wrote:
> 
> 
> On 2017/11/29 11:14, Hanjun Guo wrote:
> > Hi Lihao,
> > 
> > On 2017/11/29 10:48, Lihao Liang wrote:
> >> Hi Paul,
> >>
> >> Signed-off-by: Lihao Liang 
> > 
> > ...
> > 
> >>
> >> Many thanks,
> >> Lihao.
> >>
> >> On 2017/11/29 9:14, Paul E. McKenney wrote:
> >>> On Wed, Nov 29, 2017 at 11:51:51AM +1100, Stephen Rothwell wrote:
>  Hi Paul,
> 
>  Commit
> 
>    d7e182c9c324 ("rcu: Remove unnecessary spinlock in 
>  rcu_boot_init_percpu_data()")
> 
>  is missing a Signed-off-by from its author.
> >>> Good catch, Stephen!
> >>>
> >>> Lihao, would you please get me you Signed-off-by?  The patch is below.
> >>>
> >>>   Thanx, Paul
> >>>
> >>> 
> >>>
> >>> commit d7e182c9c32480c1f579dd888ac50e88bfb39596
> >>> Author: Liang Lihao 
> > 
> > So it's better to keep the author and Signed-off-by the same :)
> > 
> 
> Sure. Paul and Stephen, please use
> 
> Signed-off-by: Lihao Liang 

Updated, thank you both!

Thanx, Paul

> Many thanks,
> Lihao.
> 
> > Thanks
> > Hanjun
> > 
> > 
> > .
> > 
> 

Re: linux-next: Signed-off-by missing for commit in the rcu tree

[Paul E. McKenney]

On Wed, Nov 29, 2017 at 11:29:03AM +0800, Lihao Liang wrote:
> 
> 
> On 2017/11/29 11:14, Hanjun Guo wrote:
> > Hi Lihao,
> > 
> > On 2017/11/29 10:48, Lihao Liang wrote:
> >> Hi Paul,
> >>
> >> Signed-off-by: Lihao Liang 
> > 
> > ...
> > 
> >>
> >> Many thanks,
> >> Lihao.
> >>
> >> On 2017/11/29 9:14, Paul E. McKenney wrote:
> >>> On Wed, Nov 29, 2017 at 11:51:51AM +1100, Stephen Rothwell wrote:
>  Hi Paul,
> 
>  Commit
> 
>    d7e182c9c324 ("rcu: Remove unnecessary spinlock in 
>  rcu_boot_init_percpu_data()")
> 
>  is missing a Signed-off-by from its author.
> >>> Good catch, Stephen!
> >>>
> >>> Lihao, would you please get me you Signed-off-by?  The patch is below.
> >>>
> >>>   Thanx, Paul
> >>>
> >>> 
> >>>
> >>> commit d7e182c9c32480c1f579dd888ac50e88bfb39596
> >>> Author: Liang Lihao 
> > 
> > So it's better to keep the author and Signed-off-by the same :)
> > 
> 
> Sure. Paul and Stephen, please use
> 
> Signed-off-by: Lihao Liang 

Updated, thank you both!

Thanx, Paul

> Many thanks,
> Lihao.
> 
> > Thanks
> > Hanjun
> > 
> > 
> > .
> > 
> 

Re: linux-next: Signed-off-by missing for commit in the rcu tree

[Lihao Liang]

On 2017/11/29 11:14, Hanjun Guo wrote:
> Hi Lihao,
> 
> On 2017/11/29 10:48, Lihao Liang wrote:
>> Hi Paul,
>>
>> Signed-off-by: Lihao Liang 
> 
> ...
> 
>>
>> Many thanks,
>> Lihao.
>>
>> On 2017/11/29 9:14, Paul E. McKenney wrote:
>>> On Wed, Nov 29, 2017 at 11:51:51AM +1100, Stephen Rothwell wrote:
 Hi Paul,

 Commit

   d7e182c9c324 ("rcu: Remove unnecessary spinlock in 
 rcu_boot_init_percpu_data()")

 is missing a Signed-off-by from its author.
>>> Good catch, Stephen!
>>>
>>> Lihao, would you please get me you Signed-off-by?  The patch is below.
>>>
>>> Thanx, Paul
>>>
>>> 
>>>
>>> commit d7e182c9c32480c1f579dd888ac50e88bfb39596
>>> Author: Liang Lihao 
> 
> So it's better to keep the author and Signed-off-by the same :)
> 

Sure. Paul and Stephen, please use

Signed-off-by: Lihao Liang 

Many thanks,
Lihao.

> Thanks
> Hanjun
> 
> 
> .
> 

Re: linux-next: Signed-off-by missing for commit in the rcu tree

[Lihao Liang]

On 2017/11/29 11:14, Hanjun Guo wrote:
> Hi Lihao,
> 
> On 2017/11/29 10:48, Lihao Liang wrote:
>> Hi Paul,
>>
>> Signed-off-by: Lihao Liang 
> 
> ...
> 
>>
>> Many thanks,
>> Lihao.
>>
>> On 2017/11/29 9:14, Paul E. McKenney wrote:
>>> On Wed, Nov 29, 2017 at 11:51:51AM +1100, Stephen Rothwell wrote:
 Hi Paul,

 Commit

   d7e182c9c324 ("rcu: Remove unnecessary spinlock in 
 rcu_boot_init_percpu_data()")

 is missing a Signed-off-by from its author.
>>> Good catch, Stephen!
>>>
>>> Lihao, would you please get me you Signed-off-by?  The patch is below.
>>>
>>> Thanx, Paul
>>>
>>> 
>>>
>>> commit d7e182c9c32480c1f579dd888ac50e88bfb39596
>>> Author: Liang Lihao 
> 
> So it's better to keep the author and Signed-off-by the same :)
> 

Sure. Paul and Stephen, please use

Signed-off-by: Lihao Liang 

Many thanks,
Lihao.

> Thanks
> Hanjun
> 
> 
> .
> 

Re: linux-next: Signed-off-by missing for commit in the rcu tree

[Hanjun Guo]

Hi Lihao,

On 2017/11/29 10:48, Lihao Liang wrote:
> Hi Paul,
>
> Signed-off-by: Lihao Liang 

...

>
> Many thanks,
> Lihao.
>
> On 2017/11/29 9:14, Paul E. McKenney wrote:
>> On Wed, Nov 29, 2017 at 11:51:51AM +1100, Stephen Rothwell wrote:
>>> Hi Paul,
>>>
>>> Commit
>>>
>>>   d7e182c9c324 ("rcu: Remove unnecessary spinlock in 
>>> rcu_boot_init_percpu_data()")
>>>
>>> is missing a Signed-off-by from its author.
>> Good catch, Stephen!
>>
>> Lihao, would you please get me you Signed-off-by?  The patch is below.
>>
>>  Thanx, Paul
>>
>> 
>>
>> commit d7e182c9c32480c1f579dd888ac50e88bfb39596
>> Author: Liang Lihao 

So it's better to keep the author and Signed-off-by the same :)

Thanks
Hanjun

Re: linux-next: Signed-off-by missing for commit in the rcu tree

[Hanjun Guo]

Hi Lihao,

On 2017/11/29 10:48, Lihao Liang wrote:
> Hi Paul,
>
> Signed-off-by: Lihao Liang 

...

>
> Many thanks,
> Lihao.
>
> On 2017/11/29 9:14, Paul E. McKenney wrote:
>> On Wed, Nov 29, 2017 at 11:51:51AM +1100, Stephen Rothwell wrote:
>>> Hi Paul,
>>>
>>> Commit
>>>
>>>   d7e182c9c324 ("rcu: Remove unnecessary spinlock in 
>>> rcu_boot_init_percpu_data()")
>>>
>>> is missing a Signed-off-by from its author.
>> Good catch, Stephen!
>>
>> Lihao, would you please get me you Signed-off-by?  The patch is below.
>>
>>  Thanx, Paul
>>
>> 
>>
>> commit d7e182c9c32480c1f579dd888ac50e88bfb39596
>> Author: Liang Lihao 

So it's better to keep the author and Signed-off-by the same :)

Thanks
Hanjun

Re: linux-next: Signed-off-by missing for commit in the rcu tree

[Lihao Liang]

Hi Paul,

Signed-off-by: Lihao Liang 

Many thanks,
Lihao.

On 2017/11/29 9:14, Paul E. McKenney wrote:
> On Wed, Nov 29, 2017 at 11:51:51AM +1100, Stephen Rothwell wrote:
>> Hi Paul,
>>
>> Commit
>>
>>   d7e182c9c324 ("rcu: Remove unnecessary spinlock in 
>> rcu_boot_init_percpu_data()")
>>
>> is missing a Signed-off-by from its author.
> 
> Good catch, Stephen!
> 
> Lihao, would you please get me you Signed-off-by?  The patch is below.
> 
>   Thanx, Paul
> 
> 
> 
> commit d7e182c9c32480c1f579dd888ac50e88bfb39596
> Author: Liang Lihao 
> Date:   Wed Nov 22 19:00:55 2017 +
> 
> rcu: Remove unnecessary spinlock in rcu_boot_init_percpu_data()
> 
> Since rcu_boot_init_percpu_data() is only called at boot time,
> there is no data race and spinlock is not needed.
> 
> Signed-off-by: Paul E. McKenney 
> 
> diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
> index 69722817d6d6..0abe1db53d70 100644
> --- a/kernel/rcu/tree.c
> +++ b/kernel/rcu/tree.c
> @@ -3636,12 +3636,9 @@ static void rcu_init_new_rnp(struct rcu_node *rnp_leaf)
>  static void __init
>  rcu_boot_init_percpu_data(int cpu, struct rcu_state *rsp)
>  {
> - unsigned long flags;
>   struct rcu_data *rdp = per_cpu_ptr(rsp->rda, cpu);
> - struct rcu_node *rnp = rcu_get_root(rsp);
>  
>   /* Set up local state, ensuring consistent view of global state. */
> - raw_spin_lock_irqsave_rcu_node(rnp, flags);
>   rdp->grpmask = leaf_node_cpu_bit(rdp->mynode, cpu);
>   rdp->dynticks = _cpu(rcu_dynticks, cpu);
>   WARN_ON_ONCE(rdp->dynticks->dynticks_nesting != 1);
> @@ -3649,7 +3646,6 @@ rcu_boot_init_percpu_data(int cpu, struct rcu_state 
> *rsp)
>   rdp->cpu = cpu;
>   rdp->rsp = rsp;
>   rcu_boot_init_nocb_percpu_data(rdp);
> - raw_spin_unlock_irqrestore_rcu_node(rnp, flags);
>  }
>  
>  /*
> 
> 
> 

Re: linux-next: Signed-off-by missing for commit in the rcu tree

[Lihao Liang]

Hi Paul,

Signed-off-by: Lihao Liang 

Many thanks,
Lihao.

On 2017/11/29 9:14, Paul E. McKenney wrote:
> On Wed, Nov 29, 2017 at 11:51:51AM +1100, Stephen Rothwell wrote:
>> Hi Paul,
>>
>> Commit
>>
>>   d7e182c9c324 ("rcu: Remove unnecessary spinlock in 
>> rcu_boot_init_percpu_data()")
>>
>> is missing a Signed-off-by from its author.
> 
> Good catch, Stephen!
> 
> Lihao, would you please get me you Signed-off-by?  The patch is below.
> 
>   Thanx, Paul
> 
> 
> 
> commit d7e182c9c32480c1f579dd888ac50e88bfb39596
> Author: Liang Lihao 
> Date:   Wed Nov 22 19:00:55 2017 +
> 
> rcu: Remove unnecessary spinlock in rcu_boot_init_percpu_data()
> 
> Since rcu_boot_init_percpu_data() is only called at boot time,
> there is no data race and spinlock is not needed.
> 
> Signed-off-by: Paul E. McKenney 
> 
> diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
> index 69722817d6d6..0abe1db53d70 100644
> --- a/kernel/rcu/tree.c
> +++ b/kernel/rcu/tree.c
> @@ -3636,12 +3636,9 @@ static void rcu_init_new_rnp(struct rcu_node *rnp_leaf)
>  static void __init
>  rcu_boot_init_percpu_data(int cpu, struct rcu_state *rsp)
>  {
> - unsigned long flags;
>   struct rcu_data *rdp = per_cpu_ptr(rsp->rda, cpu);
> - struct rcu_node *rnp = rcu_get_root(rsp);
>  
>   /* Set up local state, ensuring consistent view of global state. */
> - raw_spin_lock_irqsave_rcu_node(rnp, flags);
>   rdp->grpmask = leaf_node_cpu_bit(rdp->mynode, cpu);
>   rdp->dynticks = _cpu(rcu_dynticks, cpu);
>   WARN_ON_ONCE(rdp->dynticks->dynticks_nesting != 1);
> @@ -3649,7 +3646,6 @@ rcu_boot_init_percpu_data(int cpu, struct rcu_state 
> *rsp)
>   rdp->cpu = cpu;
>   rdp->rsp = rsp;
>   rcu_boot_init_nocb_percpu_data(rdp);
> - raw_spin_unlock_irqrestore_rcu_node(rnp, flags);
>  }
>  
>  /*
> 
> 
> 

Re: linux-next: Signed-off-by missing for commit in the rcu tree

[Paul E. McKenney]

On Wed, Nov 29, 2017 at 11:51:51AM +1100, Stephen Rothwell wrote:
> Hi Paul,
> 
> Commit
> 
>   d7e182c9c324 ("rcu: Remove unnecessary spinlock in 
> rcu_boot_init_percpu_data()")
> 
> is missing a Signed-off-by from its author.

Good catch, Stephen!

Lihao, would you please get me you Signed-off-by?  The patch is below.

Thanx, Paul



commit d7e182c9c32480c1f579dd888ac50e88bfb39596
Author: Liang Lihao 
Date:   Wed Nov 22 19:00:55 2017 +

rcu: Remove unnecessary spinlock in rcu_boot_init_percpu_data()

Since rcu_boot_init_percpu_data() is only called at boot time,
there is no data race and spinlock is not needed.

Signed-off-by: Paul E. McKenney 

diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
index 69722817d6d6..0abe1db53d70 100644
--- a/kernel/rcu/tree.c
+++ b/kernel/rcu/tree.c
@@ -3636,12 +3636,9 @@ static void rcu_init_new_rnp(struct rcu_node *rnp_leaf)
 static void __init
 rcu_boot_init_percpu_data(int cpu, struct rcu_state *rsp)
 {
-   unsigned long flags;
struct rcu_data *rdp = per_cpu_ptr(rsp->rda, cpu);
-   struct rcu_node *rnp = rcu_get_root(rsp);
 
/* Set up local state, ensuring consistent view of global state. */
-   raw_spin_lock_irqsave_rcu_node(rnp, flags);
rdp->grpmask = leaf_node_cpu_bit(rdp->mynode, cpu);
rdp->dynticks = _cpu(rcu_dynticks, cpu);
WARN_ON_ONCE(rdp->dynticks->dynticks_nesting != 1);
@@ -3649,7 +3646,6 @@ rcu_boot_init_percpu_data(int cpu, struct rcu_state *rsp)
rdp->cpu = cpu;
rdp->rsp = rsp;
rcu_boot_init_nocb_percpu_data(rdp);
-   raw_spin_unlock_irqrestore_rcu_node(rnp, flags);
 }
 
 /*

Re: linux-next: Signed-off-by missing for commit in the rcu tree

[Paul E. McKenney]

On Wed, Nov 29, 2017 at 11:51:51AM +1100, Stephen Rothwell wrote:
> Hi Paul,
> 
> Commit
> 
>   d7e182c9c324 ("rcu: Remove unnecessary spinlock in 
> rcu_boot_init_percpu_data()")
> 
> is missing a Signed-off-by from its author.

Good catch, Stephen!

Lihao, would you please get me you Signed-off-by?  The patch is below.

Thanx, Paul



commit d7e182c9c32480c1f579dd888ac50e88bfb39596
Author: Liang Lihao 
Date:   Wed Nov 22 19:00:55 2017 +

rcu: Remove unnecessary spinlock in rcu_boot_init_percpu_data()

Since rcu_boot_init_percpu_data() is only called at boot time,
there is no data race and spinlock is not needed.

Signed-off-by: Paul E. McKenney 

diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
index 69722817d6d6..0abe1db53d70 100644
--- a/kernel/rcu/tree.c
+++ b/kernel/rcu/tree.c
@@ -3636,12 +3636,9 @@ static void rcu_init_new_rnp(struct rcu_node *rnp_leaf)
 static void __init
 rcu_boot_init_percpu_data(int cpu, struct rcu_state *rsp)
 {
-   unsigned long flags;
struct rcu_data *rdp = per_cpu_ptr(rsp->rda, cpu);
-   struct rcu_node *rnp = rcu_get_root(rsp);
 
/* Set up local state, ensuring consistent view of global state. */
-   raw_spin_lock_irqsave_rcu_node(rnp, flags);
rdp->grpmask = leaf_node_cpu_bit(rdp->mynode, cpu);
rdp->dynticks = _cpu(rcu_dynticks, cpu);
WARN_ON_ONCE(rdp->dynticks->dynticks_nesting != 1);
@@ -3649,7 +3646,6 @@ rcu_boot_init_percpu_data(int cpu, struct rcu_state *rsp)
rdp->cpu = cpu;
rdp->rsp = rsp;
rcu_boot_init_nocb_percpu_data(rdp);
-   raw_spin_unlock_irqrestore_rcu_node(rnp, flags);
 }
 
 /*

linux-next: Signed-off-by missing for commit in the rcu tree

[Stephen Rothwell]

Hi Paul,

Commit

  d7e182c9c324 ("rcu: Remove unnecessary spinlock in 
rcu_boot_init_percpu_data()")

is missing a Signed-off-by from its author.

-- 
Cheers,
Stephen Rothwell

linux-next: Signed-off-by missing for commit in the rcu tree

[Stephen Rothwell]

Hi Paul,

Commit

  d7e182c9c324 ("rcu: Remove unnecessary spinlock in 
rcu_boot_init_percpu_data()")

is missing a Signed-off-by from its author.

-- 
Cheers,
Stephen Rothwell

Re: linux-next: Signed-off-by missing for commit in the rcu tree

[Paul E. McKenney]

On Sun, Jul 30, 2017 at 11:48:57PM +1000, Stephen Rothwell wrote:
> Hi Paul,
> 
> Commit
> 
>   6a48c1c899e8 ("membarrier: Expedited private command")
> 
> is missing a Signed-off-by from its committer.

Good catch, fixed.

Thanx, Paul

Re: linux-next: Signed-off-by missing for commit in the rcu tree

[Paul E. McKenney]

On Sun, Jul 30, 2017 at 11:48:57PM +1000, Stephen Rothwell wrote:
> Hi Paul,
> 
> Commit
> 
>   6a48c1c899e8 ("membarrier: Expedited private command")
> 
> is missing a Signed-off-by from its committer.

Good catch, fixed.

Thanx, Paul

linux-next: Signed-off-by missing for commit in the rcu tree

[Stephen Rothwell]

Hi Paul,

Commit

  6a48c1c899e8 ("membarrier: Expedited private command")

is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell

linux-next: Signed-off-by missing for commit in the rcu tree

[Stephen Rothwell]

Hi Paul,

Commit

  6a48c1c899e8 ("membarrier: Expedited private command")

is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell