Re: linux-next: Tree for Jun 11 (net/dsa/tag_sja1105.c)

2019-06-11 Thread Vladimir Oltean
On Tue, 11 Jun 2019 at 21:30, Randy Dunlap  wrote:
>
> On 6/11/19 2:24 AM, Stephen Rothwell wrote:
> > Hi all,
> >
> > Changes since 20190607:
> >
>
> on i386:
>
> #
> # Library routines
> #
> # CONFIG_PACKING is not set
>
> ld: net/dsa/tag_sja1105.o: in function `sja1105_rcv':
> tag_sja1105.c:(.text+0x40b): undefined reference to `packing'
> ld: tag_sja1105.c:(.text+0x423): undefined reference to `packing'
> ld: tag_sja1105.c:(.text+0x43e): undefined reference to `packing'
> ld: tag_sja1105.c:(.text+0x456): undefined reference to `packing'
> ld: tag_sja1105.c:(.text+0x471): undefined reference to `packing'
>
>
> Should this driver select PACKING?
>
>
> --
> ~Randy

Hi Randy,

Yes it should, thanks for pointing it out.
Are you going to send a patch, or should I?

Thanks!
-Vladimir


Re: linux-next: Tree for Jun 11 (net/dsa/tag_sja1105.c)

2019-06-11 Thread Randy Dunlap
On 6/11/19 2:24 AM, Stephen Rothwell wrote:
> Hi all,
> 
> Changes since 20190607:
> 

on i386:

#
# Library routines
#
# CONFIG_PACKING is not set

ld: net/dsa/tag_sja1105.o: in function `sja1105_rcv':
tag_sja1105.c:(.text+0x40b): undefined reference to `packing'
ld: tag_sja1105.c:(.text+0x423): undefined reference to `packing'
ld: tag_sja1105.c:(.text+0x43e): undefined reference to `packing'
ld: tag_sja1105.c:(.text+0x456): undefined reference to `packing'
ld: tag_sja1105.c:(.text+0x471): undefined reference to `packing'


Should this driver select PACKING?


-- 
~Randy