Re: linux-next: Tree for May 2 [WARNING: at fs/dcache.c]

[Stephen Rothwell]

Hi all,

On Mon, 2 May 2016 22:07:45 +1000 Stephen Rothwell  
wrote:
>
> This comes from a bad automatic merge resolution between commit
> 
>   d101a125954e ("fs: add file_dentry()")
> 
> from Linus' tree (introduced before v4.5-rc3) and commit
  
Clearly I typoed v4.6-rc3

-- 
Cheers,
Stephen Rothwell

Re: linux-next: Tree for May 2 [WARNING: at fs/dcache.c]

[Stephen Rothwell]

Hi all,

On Mon, 2 May 2016 22:07:45 +1000 Stephen Rothwell  
wrote:
>
> This comes from a bad automatic merge resolution between commit
> 
>   d101a125954e ("fs: add file_dentry()")
> 
> from Linus' tree (introduced before v4.5-rc3) and commit
  
Clearly I typoed v4.6-rc3

-- 
Cheers,
Stephen Rothwell

Re: linux-next: Tree for May 2 [WARNING: at fs/dcache.c]

[Sergey Senozhatsky]

On (05/02/16 22:07), Stephen Rothwell wrote:
[..]
> > The issue is that 2 macros have the same value:
> > 
> > #define DCACHE_OP_REAL  0x0800
> > 
> > #define DCACHE_PAR_LOOKUP   0x0800 /* being looked up
> > (with parent locked shared) */
> > 
> > Verified with switching one to 0x1000 and the warning went away.
> 
> This comes from a bad automatic merge resolution between commit
> 
>   d101a125954e ("fs: add file_dentry()")
> 
> from Linus' tree (introduced before v4.5-rc3) and commit
> 
>   340450a54573 ("beginning of transition to parallel lookups - marking 
> in-lookup dentries")
> 
> from the vfs tree.
> 
> I will fix this up in tomorrow's tree (unless Al beats me to it).

good find, Mateusz.
thanks to both of you.

-ss

Re: linux-next: Tree for May 2 [WARNING: at fs/dcache.c]

[Sergey Senozhatsky]

On (05/02/16 22:07), Stephen Rothwell wrote:
[..]
> > The issue is that 2 macros have the same value:
> > 
> > #define DCACHE_OP_REAL  0x0800
> > 
> > #define DCACHE_PAR_LOOKUP   0x0800 /* being looked up
> > (with parent locked shared) */
> > 
> > Verified with switching one to 0x1000 and the warning went away.
> 
> This comes from a bad automatic merge resolution between commit
> 
>   d101a125954e ("fs: add file_dentry()")
> 
> from Linus' tree (introduced before v4.5-rc3) and commit
> 
>   340450a54573 ("beginning of transition to parallel lookups - marking 
> in-lookup dentries")
> 
> from the vfs tree.
> 
> I will fix this up in tomorrow's tree (unless Al beats me to it).

good find, Mateusz.
thanks to both of you.

-ss

Re: linux-next: Tree for May 2 [WARNING: at fs/dcache.c]

[Stephen Rothwell]

Hi Mateusz,

On Mon, 2 May 2016 12:33:54 +0200 Mateusz Guzik  wrote:
>
> On Mon, May 02, 2016 at 07:15:24PM +0900, Sergey Senozhatsky wrote:
> > On (05/02/16 18:40), Stephen Rothwell wrote:  
> > > Hi all,
> > > 
> > > Changes since 20160429  
> > 
> > Hello,
> > 
> > [0.368791] [ cut here ]
> > [0.368850] WARNING: CPU: 0 PID: 1 at fs/dcache.c:1688 
> > d_set_d_op+0x5e/0xcc
> > [0.368911] Modules linked in:
> > [0.369002] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 
> > 4.6.0-rc6-next-20160502-dbg-5-gf58c9da-dirty #404
> > [0.369161]   880133067908 811b8202 
> > 
> > [0.369371]   880133067948 81039365 
> > 0698e5dffe26
> > [0.369580]  880132c090c0 81613680 880132c040a0 
> > 880132c08000
> > [0.369791] Call Trace:
> > [0.369846]  [] dump_stack+0x4d/0x63
> > [0.369904]  [] __warn+0xb8/0xd3
> > [0.369962]  [] warn_slowpath_null+0x18/0x1a
> > [0.370021]  [] d_set_d_op+0x5e/0xcc
> > [0.370079]  [] simple_lookup+0x2e/0x45  
> 
> The issue is that 2 macros have the same value:
> 
> #define DCACHE_OP_REAL  0x0800
> 
> #define DCACHE_PAR_LOOKUP   0x0800 /* being looked up
> (with parent locked shared) */
> 
> Verified with switching one to 0x1000 and the warning went away.

This comes from a bad automatic merge resolution between commit

  d101a125954e ("fs: add file_dentry()")

from Linus' tree (introduced before v4.5-rc3) and commit

  340450a54573 ("beginning of transition to parallel lookups - marking 
in-lookup dentries")

from the vfs tree.

I will fix this up in tomorrow's tree (unless Al beats me to it).

-- 
Cheers,
Stephen Rothwell

Re: linux-next: Tree for May 2 [WARNING: at fs/dcache.c]

[Stephen Rothwell]

Hi Mateusz,

On Mon, 2 May 2016 12:33:54 +0200 Mateusz Guzik  wrote:
>
> On Mon, May 02, 2016 at 07:15:24PM +0900, Sergey Senozhatsky wrote:
> > On (05/02/16 18:40), Stephen Rothwell wrote:  
> > > Hi all,
> > > 
> > > Changes since 20160429  
> > 
> > Hello,
> > 
> > [0.368791] [ cut here ]
> > [0.368850] WARNING: CPU: 0 PID: 1 at fs/dcache.c:1688 
> > d_set_d_op+0x5e/0xcc
> > [0.368911] Modules linked in:
> > [0.369002] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 
> > 4.6.0-rc6-next-20160502-dbg-5-gf58c9da-dirty #404
> > [0.369161]   880133067908 811b8202 
> > 
> > [0.369371]   880133067948 81039365 
> > 0698e5dffe26
> > [0.369580]  880132c090c0 81613680 880132c040a0 
> > 880132c08000
> > [0.369791] Call Trace:
> > [0.369846]  [] dump_stack+0x4d/0x63
> > [0.369904]  [] __warn+0xb8/0xd3
> > [0.369962]  [] warn_slowpath_null+0x18/0x1a
> > [0.370021]  [] d_set_d_op+0x5e/0xcc
> > [0.370079]  [] simple_lookup+0x2e/0x45  
> 
> The issue is that 2 macros have the same value:
> 
> #define DCACHE_OP_REAL  0x0800
> 
> #define DCACHE_PAR_LOOKUP   0x0800 /* being looked up
> (with parent locked shared) */
> 
> Verified with switching one to 0x1000 and the warning went away.

This comes from a bad automatic merge resolution between commit

  d101a125954e ("fs: add file_dentry()")

from Linus' tree (introduced before v4.5-rc3) and commit

  340450a54573 ("beginning of transition to parallel lookups - marking 
in-lookup dentries")

from the vfs tree.

I will fix this up in tomorrow's tree (unless Al beats me to it).

-- 
Cheers,
Stephen Rothwell

Re: linux-next: Tree for May 2 [WARNING: at fs/dcache.c]

[Mateusz Guzik]

On Mon, May 02, 2016 at 07:15:24PM +0900, Sergey Senozhatsky wrote:
> On (05/02/16 18:40), Stephen Rothwell wrote:
> > Hi all,
> > 
> > Changes since 20160429
> 
> Hello,
> 
> [0.368791] [ cut here ]
> [0.368850] WARNING: CPU: 0 PID: 1 at fs/dcache.c:1688 d_set_d_op+0x5e/0xcc
> [0.368911] Modules linked in:
> [0.369002] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 
> 4.6.0-rc6-next-20160502-dbg-5-gf58c9da-dirty #404
> [0.369161]   880133067908 811b8202 
> 
> [0.369371]   880133067948 81039365 
> 0698e5dffe26
> [0.369580]  880132c090c0 81613680 880132c040a0 
> 880132c08000
> [0.369791] Call Trace:
> [0.369846]  [] dump_stack+0x4d/0x63
> [0.369904]  [] __warn+0xb8/0xd3
> [0.369962]  [] warn_slowpath_null+0x18/0x1a
> [0.370021]  [] d_set_d_op+0x5e/0xcc
> [0.370079]  [] simple_lookup+0x2e/0x45

The issue is that 2 macros have the same value:

#define DCACHE_OP_REAL  0x0800

#define DCACHE_PAR_LOOKUP   0x0800 /* being looked up
(with parent locked shared) */

Verified with switching one to 0x1000 and the warning went away.

-- 
Mateusz Guzik

Re: linux-next: Tree for May 2 [WARNING: at fs/dcache.c]

[Mateusz Guzik]

On Mon, May 02, 2016 at 07:15:24PM +0900, Sergey Senozhatsky wrote:
> On (05/02/16 18:40), Stephen Rothwell wrote:
> > Hi all,
> > 
> > Changes since 20160429
> 
> Hello,
> 
> [0.368791] [ cut here ]
> [0.368850] WARNING: CPU: 0 PID: 1 at fs/dcache.c:1688 d_set_d_op+0x5e/0xcc
> [0.368911] Modules linked in:
> [0.369002] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 
> 4.6.0-rc6-next-20160502-dbg-5-gf58c9da-dirty #404
> [0.369161]   880133067908 811b8202 
> 
> [0.369371]   880133067948 81039365 
> 0698e5dffe26
> [0.369580]  880132c090c0 81613680 880132c040a0 
> 880132c08000
> [0.369791] Call Trace:
> [0.369846]  [] dump_stack+0x4d/0x63
> [0.369904]  [] __warn+0xb8/0xd3
> [0.369962]  [] warn_slowpath_null+0x18/0x1a
> [0.370021]  [] d_set_d_op+0x5e/0xcc
> [0.370079]  [] simple_lookup+0x2e/0x45

The issue is that 2 macros have the same value:

#define DCACHE_OP_REAL  0x0800

#define DCACHE_PAR_LOOKUP   0x0800 /* being looked up
(with parent locked shared) */

Verified with switching one to 0x1000 and the warning went away.

-- 
Mateusz Guzik

Re: linux-next: Tree for May 2 [WARNING: at fs/dcache.c]

[Sergey Senozhatsky]

On (05/02/16 18:40), Stephen Rothwell wrote:
> Hi all,
> 
> Changes since 20160429

Hello,

[0.368791] [ cut here ]
[0.368850] WARNING: CPU: 0 PID: 1 at fs/dcache.c:1688 d_set_d_op+0x5e/0xcc
[0.368911] Modules linked in:
[0.369002] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 
4.6.0-rc6-next-20160502-dbg-5-gf58c9da-dirty #404
[0.369161]   880133067908 811b8202 

[0.369371]   880133067948 81039365 
0698e5dffe26
[0.369580]  880132c090c0 81613680 880132c040a0 
880132c08000
[0.369791] Call Trace:
[0.369846]  [] dump_stack+0x4d/0x63
[0.369904]  [] __warn+0xb8/0xd3
[0.369962]  [] warn_slowpath_null+0x18/0x1a
[0.370021]  [] d_set_d_op+0x5e/0xcc
[0.370079]  [] simple_lookup+0x2e/0x45
[0.370137]  [] lookup_slow+0xdb/0x12d
[0.370197]  [] ? initrd_load+0x3f/0x3f
[0.370255]  [] walk_component+0xc2/0x201
[0.370313]  [] ? path_init+0x169/0x2a4
[0.370371]  [] path_lookupat+0x7e/0xff
[0.370429]  [] filename_lookup+0x78/0xd4
[0.370489]  [] ? atomic_notifier_call_chain+0xf/0x11
[0.370551]  [] ? notify_update+0x29/0x2b
[0.370609]  [] ? vt_console_print+0x2f3/0x302
[0.370668]  [] ? getname_flags+0x48/0x15a
[0.370726]  [] user_path_at_empty+0x32/0x38
[0.370785]  [] ? user_path_at_empty+0x32/0x38
[0.370845]  [] vfs_fstatat+0x4c/0x87
[0.370903]  [] ? get_page_from_freelist+0x567/0x6f1
[0.370963]  [] vfs_lstat+0x19/0x1b
[0.371021]  [] SyS_newlstat+0x15/0x2e
[0.371079]  [] ? simple_strtoull+0x2c/0x48
[0.371138]  [] clean_path+0x20/0x5e
[0.371196]  [] ? simple_strtoul+0x9/0xb
[0.371254]  [] ? parse_header+0x2d/0xda
[0.371313]  [] do_name+0x75/0x27a
[0.371370]  [] write_buffer+0x23/0x34
[0.371428]  [] flush_buffer+0x34/0x8c
[0.371487]  [] __gunzip+0x268/0x308
[0.371545]  [] ? decompress_method+0x66/0x66
[0.371604]  [] ? write_buffer+0x34/0x34
[0.371662]  [] ? set_debug_rodata+0x12/0x12
[0.371721]  [] gunzip+0x11/0x13
[0.371778]  [] ? initrd_load+0x3f/0x3f
[0.371837]  [] unpack_to_rootfs+0x13b/0x257
[0.371896]  [] ? initrd_load+0x3f/0x3f
[0.371954]  [] ? maybe_link.part.2+0x104/0x104
[0.372013]  [] populate_rootfs+0x18/0x103
[0.372072]  [] ? maybe_link.part.2+0x104/0x104
[0.372132]  [] do_one_initcall+0x8b/0x10e
[0.372191]  [] ? set_debug_rodata+0x12/0x12
[0.372250]  [] kernel_init_freeable+0x11e/0x1a6
[0.372311]  [] kernel_init+0x9/0xeb
[0.372369]  [] ret_from_fork+0x22/0x40
[0.372428]  [] ? rest_init+0x7d/0x7d
[0.372503] ---[ end trace ce49db5ed97cc037 ]---
[0.372589] Unpacking initramfs...

-ss

Re: linux-next: Tree for May 2 [WARNING: at fs/dcache.c]

[Sergey Senozhatsky]

On (05/02/16 18:40), Stephen Rothwell wrote:
> Hi all,
> 
> Changes since 20160429

Hello,

[0.368791] [ cut here ]
[0.368850] WARNING: CPU: 0 PID: 1 at fs/dcache.c:1688 d_set_d_op+0x5e/0xcc
[0.368911] Modules linked in:
[0.369002] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 
4.6.0-rc6-next-20160502-dbg-5-gf58c9da-dirty #404
[0.369161]   880133067908 811b8202 

[0.369371]   880133067948 81039365 
0698e5dffe26
[0.369580]  880132c090c0 81613680 880132c040a0 
880132c08000
[0.369791] Call Trace:
[0.369846]  [] dump_stack+0x4d/0x63
[0.369904]  [] __warn+0xb8/0xd3
[0.369962]  [] warn_slowpath_null+0x18/0x1a
[0.370021]  [] d_set_d_op+0x5e/0xcc
[0.370079]  [] simple_lookup+0x2e/0x45
[0.370137]  [] lookup_slow+0xdb/0x12d
[0.370197]  [] ? initrd_load+0x3f/0x3f
[0.370255]  [] walk_component+0xc2/0x201
[0.370313]  [] ? path_init+0x169/0x2a4
[0.370371]  [] path_lookupat+0x7e/0xff
[0.370429]  [] filename_lookup+0x78/0xd4
[0.370489]  [] ? atomic_notifier_call_chain+0xf/0x11
[0.370551]  [] ? notify_update+0x29/0x2b
[0.370609]  [] ? vt_console_print+0x2f3/0x302
[0.370668]  [] ? getname_flags+0x48/0x15a
[0.370726]  [] user_path_at_empty+0x32/0x38
[0.370785]  [] ? user_path_at_empty+0x32/0x38
[0.370845]  [] vfs_fstatat+0x4c/0x87
[0.370903]  [] ? get_page_from_freelist+0x567/0x6f1
[0.370963]  [] vfs_lstat+0x19/0x1b
[0.371021]  [] SyS_newlstat+0x15/0x2e
[0.371079]  [] ? simple_strtoull+0x2c/0x48
[0.371138]  [] clean_path+0x20/0x5e
[0.371196]  [] ? simple_strtoul+0x9/0xb
[0.371254]  [] ? parse_header+0x2d/0xda
[0.371313]  [] do_name+0x75/0x27a
[0.371370]  [] write_buffer+0x23/0x34
[0.371428]  [] flush_buffer+0x34/0x8c
[0.371487]  [] __gunzip+0x268/0x308
[0.371545]  [] ? decompress_method+0x66/0x66
[0.371604]  [] ? write_buffer+0x34/0x34
[0.371662]  [] ? set_debug_rodata+0x12/0x12
[0.371721]  [] gunzip+0x11/0x13
[0.371778]  [] ? initrd_load+0x3f/0x3f
[0.371837]  [] unpack_to_rootfs+0x13b/0x257
[0.371896]  [] ? initrd_load+0x3f/0x3f
[0.371954]  [] ? maybe_link.part.2+0x104/0x104
[0.372013]  [] populate_rootfs+0x18/0x103
[0.372072]  [] ? maybe_link.part.2+0x104/0x104
[0.372132]  [] do_one_initcall+0x8b/0x10e
[0.372191]  [] ? set_debug_rodata+0x12/0x12
[0.372250]  [] kernel_init_freeable+0x11e/0x1a6
[0.372311]  [] kernel_init+0x9/0xeb
[0.372369]  [] ret_from_fork+0x22/0x40
[0.372428]  [] ? rest_init+0x7d/0x7d
[0.372503] ---[ end trace ce49db5ed97cc037 ]---
[0.372589] Unpacking initramfs...

-ss