Re: linux-next: boot failure after merge of the iomem-mmap-vs-gup tree

2021-01-18 Thread Daniel Vetter
On Tue, Jan 19, 2021 at 6:26 AM Stephen Rothwell  wrote:
>
> Hi all,
>
> On Wed, 13 Jan 2021 16:29:48 +1100 Stephen Rothwell  
> wrote:
> >
> > After merging the iomem-mmap-vs-gup tree, today's linux-next boot test
> > (powerpc pseries_le_defconfig) failed like this:
> >
> > EEH: pSeries platform initialized
> > PCI: Probing PCI hardware
> > BUG: Kernel NULL pointer dereference on write at 0x0030
> > Faulting instruction address: 0xc013bf4c
> > Oops: Kernel access of bad area, sig: 11 [#1]
> > LE PAGE_SIZE=64K MMU=Hash SMP NR_CPUS=2048 NUMA pSeries
> > Modules linked in:
> > CPU: 0 PID: 1 Comm: swapper/0 Not tainted 5.11.0-rc3 #2
> > NIP:  c013bf4c LR: c07a9ee8 CTR: 
> > REGS: c63a3610 TRAP: 0380   Not tainted  (5.11.0-rc3)
> > MSR:  82009033   CR: 84002440  XER: 
> > 
> > CFAR: c07a9ee4 IRQMASK: 0
> > GPR00: c07a9ee8 c63a38b0 c13d8100 
> > c6061300
> > GPR04:  0b20 c0f11738 
> > 
> > GPR08: c07a7ab0  c07a7a40 
> > 2d6770696f73
> > GPR12:  c15b c0013120 
> > 
> > GPR16:    
> > 
> > GPR20:    
> > 
> > GPR24: c6210de8 c6167120 c6620b20 
> > 
> > GPR28: c6167120 0180 c6061300 
> > c6167000
> > NIP [c013bf4c] iomem_get_mapping+0x1c/0x30
> > LR [c07a9ee8] pci_create_legacy_files+0xa8/0x1c0
> > Call Trace:
> > [c63a38b0] [c07a9e84] 
> > pci_create_legacy_files+0x44/0x1c0 (unreliable)
> > [c63a3930] [c0795198] 
> > pci_register_host_bridge+0x288/0x510
> > [c63a3a60] [c0795514] pci_create_root_bus+0xf4/0x150
> > [c63a3ac0] [c006d424] pcibios_scan_phb+0xe4/0x270
> > [c63a3b70] [c1010b40] pcibios_init+0x8c/0x128
> > [c63a3bf0] [c0012b70] do_one_initcall+0x60/0x2c0
> > [c63a3cc0] [c10046b4] kernel_init_freeable+0x2e8/0x380
> > [c63a3da0] [c0013144] kernel_init+0x2c/0x168
> > [c63a3e10] [c000dff0] ret_from_kernel_thread+0x5c/0x6c
> > Instruction dump:
> > 7c634850 4e800020 6000 6000 6042 3c4c012a 3842c1d0 7c0802a6
> > 6000 3d22000d e929caf8 7c2004ac  4e800020 6000 
> > 6000
> > ---[ end trace 77f55ece72f02708 ]---
> >
> > Kernel panic - not syncing: Attempted to kill init! exitcode=0x000b
> >
> > Caused by commit
> >
> >   85482fbab59e ("PCI: Revoke mappings like devmem")
> >
> > Reverting that commit fixes the boot, so I have done that for today.
>
> I am still reverting this commit.

Thanks for the reminder, I missed your earlier report. I don't have a
machine here with HAVE_PCI_LEGACY, but I think I understand what's
going on here. I'll drop the last two patches from the branch for now
(since both need to be changed to address this somehow).
-Daniel





--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch


Re: linux-next: boot failure after merge of the iomem-mmap-vs-gup tree

2021-01-18 Thread Stephen Rothwell
Hi all,

On Wed, 13 Jan 2021 16:29:48 +1100 Stephen Rothwell  
wrote:
> 
> After merging the iomem-mmap-vs-gup tree, today's linux-next boot test
> (powerpc pseries_le_defconfig) failed like this:
> 
> EEH: pSeries platform initialized
> PCI: Probing PCI hardware
> BUG: Kernel NULL pointer dereference on write at 0x0030
> Faulting instruction address: 0xc013bf4c
> Oops: Kernel access of bad area, sig: 11 [#1]
> LE PAGE_SIZE=64K MMU=Hash SMP NR_CPUS=2048 NUMA pSeries
> Modules linked in:
> CPU: 0 PID: 1 Comm: swapper/0 Not tainted 5.11.0-rc3 #2
> NIP:  c013bf4c LR: c07a9ee8 CTR: 
> REGS: c63a3610 TRAP: 0380   Not tainted  (5.11.0-rc3)
> MSR:  82009033   CR: 84002440  XER: 
> 
> CFAR: c07a9ee4 IRQMASK: 0 
> GPR00: c07a9ee8 c63a38b0 c13d8100 
> c6061300 
> GPR04:  0b20 c0f11738 
>  
> GPR08: c07a7ab0  c07a7a40 
> 2d6770696f73 
> GPR12:  c15b c0013120 
>  
> GPR16:    
>  
> GPR20:    
>  
> GPR24: c6210de8 c6167120 c6620b20 
>  
> GPR28: c6167120 0180 c6061300 
> c6167000 
> NIP [c013bf4c] iomem_get_mapping+0x1c/0x30
> LR [c07a9ee8] pci_create_legacy_files+0xa8/0x1c0
> Call Trace:
> [c63a38b0] [c07a9e84] pci_create_legacy_files+0x44/0x1c0 
> (unreliable)
> [c63a3930] [c0795198] pci_register_host_bridge+0x288/0x510
> [c63a3a60] [c0795514] pci_create_root_bus+0xf4/0x150
> [c63a3ac0] [c006d424] pcibios_scan_phb+0xe4/0x270
> [c63a3b70] [c1010b40] pcibios_init+0x8c/0x128
> [c63a3bf0] [c0012b70] do_one_initcall+0x60/0x2c0
> [c63a3cc0] [c10046b4] kernel_init_freeable+0x2e8/0x380
> [c63a3da0] [c0013144] kernel_init+0x2c/0x168
> [c63a3e10] [c000dff0] ret_from_kernel_thread+0x5c/0x6c
> Instruction dump:
> 7c634850 4e800020 6000 6000 6042 3c4c012a 3842c1d0 7c0802a6 
> 6000 3d22000d e929caf8 7c2004ac  4e800020 6000 6000 
> ---[ end trace 77f55ece72f02708 ]---
> 
> Kernel panic - not syncing: Attempted to kill init! exitcode=0x000b
> 
> Caused by commit
> 
>   85482fbab59e ("PCI: Revoke mappings like devmem")
> 
> Reverting that commit fixes the boot, so I have done that for today.

I am still reverting this commit.

-- 
Cheers,
Stephen Rothwell


pgpQW3shjVh8k.pgp
Description: OpenPGP digital signature


linux-next: boot failure after merge of the iomem-mmap-vs-gup tree

2021-01-12 Thread Stephen Rothwell
Hi all,

After merging the iomem-mmap-vs-gup tree, today's linux-next boot test
(powerpc pseries_le_defconfig) failed like this:

EEH: pSeries platform initialized
PCI: Probing PCI hardware
BUG: Kernel NULL pointer dereference on write at 0x0030
Faulting instruction address: 0xc013bf4c
Oops: Kernel access of bad area, sig: 11 [#1]
LE PAGE_SIZE=64K MMU=Hash SMP NR_CPUS=2048 NUMA pSeries
Modules linked in:
CPU: 0 PID: 1 Comm: swapper/0 Not tainted 5.11.0-rc3 #2
NIP:  c013bf4c LR: c07a9ee8 CTR: 
REGS: c63a3610 TRAP: 0380   Not tainted  (5.11.0-rc3)
MSR:  82009033   CR: 84002440  XER: 

CFAR: c07a9ee4 IRQMASK: 0 
GPR00: c07a9ee8 c63a38b0 c13d8100 c6061300 
GPR04:  0b20 c0f11738  
GPR08: c07a7ab0  c07a7a40 2d6770696f73 
GPR12:  c15b c0013120  
GPR16:     
GPR20:     
GPR24: c6210de8 c6167120 c6620b20  
GPR28: c6167120 0180 c6061300 c6167000 
NIP [c013bf4c] iomem_get_mapping+0x1c/0x30
LR [c07a9ee8] pci_create_legacy_files+0xa8/0x1c0
Call Trace:
[c63a38b0] [c07a9e84] pci_create_legacy_files+0x44/0x1c0 
(unreliable)
[c63a3930] [c0795198] pci_register_host_bridge+0x288/0x510
[c63a3a60] [c0795514] pci_create_root_bus+0xf4/0x150
[c63a3ac0] [c006d424] pcibios_scan_phb+0xe4/0x270
[c63a3b70] [c1010b40] pcibios_init+0x8c/0x128
[c63a3bf0] [c0012b70] do_one_initcall+0x60/0x2c0
[c63a3cc0] [c10046b4] kernel_init_freeable+0x2e8/0x380
[c63a3da0] [c0013144] kernel_init+0x2c/0x168
[c63a3e10] [c000dff0] ret_from_kernel_thread+0x5c/0x6c
Instruction dump:
7c634850 4e800020 6000 6000 6042 3c4c012a 3842c1d0 7c0802a6 
6000 3d22000d e929caf8 7c2004ac  4e800020 6000 6000 
---[ end trace 77f55ece72f02708 ]---

Kernel panic - not syncing: Attempted to kill init! exitcode=0x000b

Caused by commit

  85482fbab59e ("PCI: Revoke mappings like devmem")

Reverting that commit fixes the boot, so I have done that for today.

-- 
Cheers,
Stephen Rothwell


pgpNfa_iufn18.pgp
Description: OpenPGP digital signature