Re: linux-next: build failure after merge of the final tree
On Wed, May 28, 2014 at 10:48:02PM +0200, Paul Bolle wrote: > On Wed, 2014-05-28 at 13:42 -0700, Greg KH wrote: > > Either is fine with me, I can revert it, or apply a fix, which ever you > > want, just let me know. > > Well, a proper fix would make this whole episode worthwhile. But if I > can't come up with anything that actually builds in a day or two it'll > have to be a revert. If that exceeds your patience you're free to hand > me a shorter deadline. How about I revert it now, that way you can provide a proper fix whenever you get the chance. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the final tree
On Wed, 2014-05-28 at 13:42 -0700, Greg KH wrote: > Either is fine with me, I can revert it, or apply a fix, which ever you > want, just let me know. Well, a proper fix would make this whole episode worthwhile. But if I can't come up with anything that actually builds in a day or two it'll have to be a revert. If that exceeds your patience you're free to hand me a shorter deadline. Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the final tree
On Wed, May 28, 2014 at 10:21:28PM +0200, Paul Bolle wrote: > Greg, > > On Wed, 2014-05-28 at 12:14 +0200, Paul Bolle wrote: > > I must have compile tested this with CONFIG_LIB80211_CRYPT_TKIP=m while > > the code checks for CONFIG_LIB80211_CRYPT_TKIP only (ie, builtin only). > > I'll have to have a better look at this. > > > > Greg, can the cleaning up of this mess involve an entirely new patch? An > > incremental patch would leave this build error in a certain range of > > commits. As I already have the patch in my tree, I can't do that, we can live with the build issue. > The pieces of the latest linux-next build were handed to me by Stephen > as my patch managed to break it. > > I'm assuming you'd like to include rtl8192u in linux-next's builds > again. Currently I got nothing to offer to you but a request to either > drop "staging: rtl8192u: rename CONFIG_IEEE80211_CRYPT_TKIP" from > staging-next or, if that's not how staging-next works, a request to > revert it. What do you prefer? Either is fine with me, I can revert it, or apply a fix, which ever you want, just let me know. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the final tree
Greg, On Wed, 2014-05-28 at 12:14 +0200, Paul Bolle wrote: > I must have compile tested this with CONFIG_LIB80211_CRYPT_TKIP=m while > the code checks for CONFIG_LIB80211_CRYPT_TKIP only (ie, builtin only). > I'll have to have a better look at this. > > Greg, can the cleaning up of this mess involve an entirely new patch? An > incremental patch would leave this build error in a certain range of > commits. The pieces of the latest linux-next build were handed to me by Stephen as my patch managed to break it. I'm assuming you'd like to include rtl8192u in linux-next's builds again. Currently I got nothing to offer to you but a request to either drop "staging: rtl8192u: rename CONFIG_IEEE80211_CRYPT_TKIP" from staging-next or, if that's not how staging-next works, a request to revert it. What do you prefer? Either way I'll see whether I can come up with a fix that allows me to take off that brown paper bag. Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the final tree
Hi Paul, On Wed, 28 May 2014 11:57:21 +0200 Paul Bolle wrote: > > That may be related to my "staging: rtl8192u: rename > CONFIG_IEEE80211_CRYPT_TKIP" (see https://lkml.org/lkml/2014/5/26/531 .) > My message states it was compile tested, but that would be on x86_64. > Did it only break on powerpc or did powerpc hit this first? The powerpc allyesconfig build was just where I found it - I don't do that many different builds during the day. -- Cheers, Stephen Rothwells...@canb.auug.org.au signature.asc Description: PGP signature
Re: linux-next: build failure after merge of the final tree
On Wed, 2014-05-28 at 11:57 +0200, Paul Bolle wrote: > On Wed, 2014-05-28 at 19:46 +1000, Stephen Rothwell wrote: > That may be related to my "staging: rtl8192u: rename > CONFIG_IEEE80211_CRYPT_TKIP" (see https://lkml.org/lkml/2014/5/26/531 .) > My message states it was compile tested, but that would be on x86_64. > Did it only break on powerpc or did powerpc hit this first? I must have compile tested this with CONFIG_LIB80211_CRYPT_TKIP=m while the code checks for CONFIG_LIB80211_CRYPT_TKIP only (ie, builtin only). I'll have to have a better look at this. Greg, can the cleaning up of this mess involve an entirely new patch? An incremental patch would leave this build error in a certain range of commits. Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the final tree
On Wed, 2014-05-28 at 19:46 +1000, Stephen Rothwell wrote: > Hi all, > > After merging the final tree, today's linux-next build (powerpc > allyesconfig) failed like this: > > drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c:203:34: error: 'struct > ieee80211_hdr' has no member named 'addr1' >ieee->dev->name, header->addr1); > ^ > > I can't easily see what caused this, so I just disabled the staging > tree driver: That may be related to my "staging: rtl8192u: rename CONFIG_IEEE80211_CRYPT_TKIP" (see https://lkml.org/lkml/2014/5/26/531 .) My message states it was compile tested, but that would be on x86_64. Did it only break on powerpc or did powerpc hit this first? > From: Stephen Rothwell > Date: Wed, 28 May 2014 19:43:17 +1000 > Subject: [PATCH] staging: rtl8192u: diable broken driver > > Signed-off-by: Stephen Rothwell > --- > drivers/staging/rtl8192u/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/staging/rtl8192u/Kconfig > b/drivers/staging/rtl8192u/Kconfig > index 3ee9d0d00fb6..ea5d02d8cca2 100644 > --- a/drivers/staging/rtl8192u/Kconfig > +++ b/drivers/staging/rtl8192u/Kconfig > @@ -2,6 +2,7 @@ config RTL8192U > tristate "RealTek RTL8192U Wireless LAN NIC driver" > depends on PCI && WLAN && USB > depends on m > + depends on BROKEN > select WIRELESS_EXT > select WEXT_PRIV > select CRYPTO > -- > 2.0.0.rc4 Thanks, Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
linux-next: build failure after merge of the final tree
Hi all, After merging the final tree, today's linux-next build (powerpc allyesconfig) failed like this: drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c:203:34: error: 'struct ieee80211_hdr' has no member named 'addr1' ieee->dev->name, header->addr1); ^ I can't easily see what caused this, so I just disabled the staging tree driver: From: Stephen Rothwell Date: Wed, 28 May 2014 19:43:17 +1000 Subject: [PATCH] staging: rtl8192u: diable broken driver Signed-off-by: Stephen Rothwell --- drivers/staging/rtl8192u/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/rtl8192u/Kconfig b/drivers/staging/rtl8192u/Kconfig index 3ee9d0d00fb6..ea5d02d8cca2 100644 --- a/drivers/staging/rtl8192u/Kconfig +++ b/drivers/staging/rtl8192u/Kconfig @@ -2,6 +2,7 @@ config RTL8192U tristate "RealTek RTL8192U Wireless LAN NIC driver" depends on PCI && WLAN && USB depends on m + depends on BROKEN select WIRELESS_EXT select WEXT_PRIV select CRYPTO -- 2.0.0.rc4 -- Cheers, Stephen Rothwells...@canb.auug.org.au signature.asc Description: PGP signature
Re: linux-next: build failure after merge of the final tree
Greg, On Wed, 2014-05-28 at 12:14 +0200, Paul Bolle wrote: I must have compile tested this with CONFIG_LIB80211_CRYPT_TKIP=m while the code checks for CONFIG_LIB80211_CRYPT_TKIP only (ie, builtin only). I'll have to have a better look at this. Greg, can the cleaning up of this mess involve an entirely new patch? An incremental patch would leave this build error in a certain range of commits. The pieces of the latest linux-next build were handed to me by Stephen as my patch managed to break it. I'm assuming you'd like to include rtl8192u in linux-next's builds again. Currently I got nothing to offer to you but a request to either drop staging: rtl8192u: rename CONFIG_IEEE80211_CRYPT_TKIP from staging-next or, if that's not how staging-next works, a request to revert it. What do you prefer? Either way I'll see whether I can come up with a fix that allows me to take off that brown paper bag. Paul Bolle -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the final tree
On Wed, May 28, 2014 at 10:21:28PM +0200, Paul Bolle wrote: Greg, On Wed, 2014-05-28 at 12:14 +0200, Paul Bolle wrote: I must have compile tested this with CONFIG_LIB80211_CRYPT_TKIP=m while the code checks for CONFIG_LIB80211_CRYPT_TKIP only (ie, builtin only). I'll have to have a better look at this. Greg, can the cleaning up of this mess involve an entirely new patch? An incremental patch would leave this build error in a certain range of commits. As I already have the patch in my tree, I can't do that, we can live with the build issue. The pieces of the latest linux-next build were handed to me by Stephen as my patch managed to break it. I'm assuming you'd like to include rtl8192u in linux-next's builds again. Currently I got nothing to offer to you but a request to either drop staging: rtl8192u: rename CONFIG_IEEE80211_CRYPT_TKIP from staging-next or, if that's not how staging-next works, a request to revert it. What do you prefer? Either is fine with me, I can revert it, or apply a fix, which ever you want, just let me know. thanks, greg k-h -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the final tree
On Wed, 2014-05-28 at 13:42 -0700, Greg KH wrote: Either is fine with me, I can revert it, or apply a fix, which ever you want, just let me know. Well, a proper fix would make this whole episode worthwhile. But if I can't come up with anything that actually builds in a day or two it'll have to be a revert. If that exceeds your patience you're free to hand me a shorter deadline. Paul Bolle -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the final tree
On Wed, May 28, 2014 at 10:48:02PM +0200, Paul Bolle wrote: On Wed, 2014-05-28 at 13:42 -0700, Greg KH wrote: Either is fine with me, I can revert it, or apply a fix, which ever you want, just let me know. Well, a proper fix would make this whole episode worthwhile. But if I can't come up with anything that actually builds in a day or two it'll have to be a revert. If that exceeds your patience you're free to hand me a shorter deadline. How about I revert it now, that way you can provide a proper fix whenever you get the chance. thanks, greg k-h -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
linux-next: build failure after merge of the final tree
Hi all, After merging the final tree, today's linux-next build (powerpc allyesconfig) failed like this: drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c:203:34: error: 'struct ieee80211_hdr' has no member named 'addr1' ieee-dev-name, header-addr1); ^ I can't easily see what caused this, so I just disabled the staging tree driver: From: Stephen Rothwell s...@canb.auug.org.au Date: Wed, 28 May 2014 19:43:17 +1000 Subject: [PATCH] staging: rtl8192u: diable broken driver Signed-off-by: Stephen Rothwell s...@canb.auug.org.au --- drivers/staging/rtl8192u/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/rtl8192u/Kconfig b/drivers/staging/rtl8192u/Kconfig index 3ee9d0d00fb6..ea5d02d8cca2 100644 --- a/drivers/staging/rtl8192u/Kconfig +++ b/drivers/staging/rtl8192u/Kconfig @@ -2,6 +2,7 @@ config RTL8192U tristate RealTek RTL8192U Wireless LAN NIC driver depends on PCI WLAN USB depends on m + depends on BROKEN select WIRELESS_EXT select WEXT_PRIV select CRYPTO -- 2.0.0.rc4 -- Cheers, Stephen Rothwells...@canb.auug.org.au signature.asc Description: PGP signature
Re: linux-next: build failure after merge of the final tree
On Wed, 2014-05-28 at 19:46 +1000, Stephen Rothwell wrote: Hi all, After merging the final tree, today's linux-next build (powerpc allyesconfig) failed like this: drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c:203:34: error: 'struct ieee80211_hdr' has no member named 'addr1' ieee-dev-name, header-addr1); ^ I can't easily see what caused this, so I just disabled the staging tree driver: That may be related to my staging: rtl8192u: rename CONFIG_IEEE80211_CRYPT_TKIP (see https://lkml.org/lkml/2014/5/26/531 .) My message states it was compile tested, but that would be on x86_64. Did it only break on powerpc or did powerpc hit this first? From: Stephen Rothwell s...@canb.auug.org.au Date: Wed, 28 May 2014 19:43:17 +1000 Subject: [PATCH] staging: rtl8192u: diable broken driver Signed-off-by: Stephen Rothwell s...@canb.auug.org.au --- drivers/staging/rtl8192u/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/rtl8192u/Kconfig b/drivers/staging/rtl8192u/Kconfig index 3ee9d0d00fb6..ea5d02d8cca2 100644 --- a/drivers/staging/rtl8192u/Kconfig +++ b/drivers/staging/rtl8192u/Kconfig @@ -2,6 +2,7 @@ config RTL8192U tristate RealTek RTL8192U Wireless LAN NIC driver depends on PCI WLAN USB depends on m + depends on BROKEN select WIRELESS_EXT select WEXT_PRIV select CRYPTO -- 2.0.0.rc4 Thanks, Paul Bolle -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the final tree
On Wed, 2014-05-28 at 11:57 +0200, Paul Bolle wrote: On Wed, 2014-05-28 at 19:46 +1000, Stephen Rothwell wrote: That may be related to my staging: rtl8192u: rename CONFIG_IEEE80211_CRYPT_TKIP (see https://lkml.org/lkml/2014/5/26/531 .) My message states it was compile tested, but that would be on x86_64. Did it only break on powerpc or did powerpc hit this first? I must have compile tested this with CONFIG_LIB80211_CRYPT_TKIP=m while the code checks for CONFIG_LIB80211_CRYPT_TKIP only (ie, builtin only). I'll have to have a better look at this. Greg, can the cleaning up of this mess involve an entirely new patch? An incremental patch would leave this build error in a certain range of commits. Paul Bolle -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the final tree
Hi Paul, On Wed, 28 May 2014 11:57:21 +0200 Paul Bolle pebo...@tiscali.nl wrote: That may be related to my staging: rtl8192u: rename CONFIG_IEEE80211_CRYPT_TKIP (see https://lkml.org/lkml/2014/5/26/531 .) My message states it was compile tested, but that would be on x86_64. Did it only break on powerpc or did powerpc hit this first? The powerpc allyesconfig build was just where I found it - I don't do that many different builds during the day. -- Cheers, Stephen Rothwells...@canb.auug.org.au signature.asc Description: PGP signature
Re: linux-next: build failure after merge of the final tree
Hi Andrew, On Mon, 7 Apr 2014 11:26:54 -0700 Andrew Morton wrote: > > On Mon, 7 Apr 2014 14:52:42 +1000 Stephen Rothwell > wrote: > > > After merging the final tree, today's linux-next build (powerpc > > allyesconfig) failed like this: > > > > fs/ocfs2/suballoc.c: In function 'ocfs2_block_group_set_bits': > > fs/ocfs2/suballoc.c:1357:2: error: implicit declaration of function > > 'trace_ocfs2_block_group_set_bits' [-Werror=implicit-function-declaration] > > trace_ocfs2_block_group_set_bits(bit_off, num_bits); > > ^ > > > > I have no idea how to track this down :-( The only patches affecting this > > code are now in Linus' tree. I can only assume that some implicitly > > included header file is no longer included. I have just left it broken > > for now. > > I can't reproduce this with either mainline or linux-next. Pulled half > an hour ago, powerpc allyesconfig. Rats! I think I have been fooled by my own scripts. What was built here was the result of me trying to merge your tree. After abandoning the attempt, my build tree did not get reset to the final linux-next before I did my final build checks which include the powerpc allyesconfig. Sorry about that. -- Cheers, Stephen Rothwells...@canb.auug.org.au pgp1yTQW_D6VE.pgp Description: PGP signature
Re: linux-next: build failure after merge of the final tree
On Mon, 7 Apr 2014 14:52:42 +1000 Stephen Rothwell wrote: > Hi all, > > After merging the final tree, today's linux-next build (powerpc > allyesconfig) failed like this: > > fs/ocfs2/suballoc.c: In function 'ocfs2_block_group_set_bits': > fs/ocfs2/suballoc.c:1357:2: error: implicit declaration of function > 'trace_ocfs2_block_group_set_bits' [-Werror=implicit-function-declaration] > trace_ocfs2_block_group_set_bits(bit_off, num_bits); > ^ > > I have no idea how to track this down :-( The only patches affecting this > code are now in Linus' tree. I can only assume that some implicitly > included header file is no longer included. I have just left it broken > for now. I can't reproduce this with either mainline or linux-next. Pulled half an hour ago, powerpc allyesconfig. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the final tree
On Mon, 7 Apr 2014 14:52:42 +1000 Stephen Rothwell s...@canb.auug.org.au wrote: Hi all, After merging the final tree, today's linux-next build (powerpc allyesconfig) failed like this: fs/ocfs2/suballoc.c: In function 'ocfs2_block_group_set_bits': fs/ocfs2/suballoc.c:1357:2: error: implicit declaration of function 'trace_ocfs2_block_group_set_bits' [-Werror=implicit-function-declaration] trace_ocfs2_block_group_set_bits(bit_off, num_bits); ^ I have no idea how to track this down :-( The only patches affecting this code are now in Linus' tree. I can only assume that some implicitly included header file is no longer included. I have just left it broken for now. I can't reproduce this with either mainline or linux-next. Pulled half an hour ago, powerpc allyesconfig. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the final tree
Hi Andrew, On Mon, 7 Apr 2014 11:26:54 -0700 Andrew Morton a...@linux-foundation.org wrote: On Mon, 7 Apr 2014 14:52:42 +1000 Stephen Rothwell s...@canb.auug.org.au wrote: After merging the final tree, today's linux-next build (powerpc allyesconfig) failed like this: fs/ocfs2/suballoc.c: In function 'ocfs2_block_group_set_bits': fs/ocfs2/suballoc.c:1357:2: error: implicit declaration of function 'trace_ocfs2_block_group_set_bits' [-Werror=implicit-function-declaration] trace_ocfs2_block_group_set_bits(bit_off, num_bits); ^ I have no idea how to track this down :-( The only patches affecting this code are now in Linus' tree. I can only assume that some implicitly included header file is no longer included. I have just left it broken for now. I can't reproduce this with either mainline or linux-next. Pulled half an hour ago, powerpc allyesconfig. Rats! I think I have been fooled by my own scripts. What was built here was the result of me trying to merge your tree. After abandoning the attempt, my build tree did not get reset to the final linux-next before I did my final build checks which include the powerpc allyesconfig. Sorry about that. -- Cheers, Stephen Rothwells...@canb.auug.org.au pgp1yTQW_D6VE.pgp Description: PGP signature
linux-next: build failure after merge of the final tree
Hi all, After merging the final tree, today's linux-next build (powerpc allyesconfig) failed like this: fs/ocfs2/suballoc.c: In function 'ocfs2_block_group_set_bits': fs/ocfs2/suballoc.c:1357:2: error: implicit declaration of function 'trace_ocfs2_block_group_set_bits' [-Werror=implicit-function-declaration] trace_ocfs2_block_group_set_bits(bit_off, num_bits); ^ I have no idea how to track this down :-( The only patches affecting this code are now in Linus' tree. I can only assume that some implicitly included header file is no longer included. I have just left it broken for now. -- Cheers, Stephen Rothwells...@canb.auug.org.au pgppp3OXEhdkl.pgp Description: PGP signature
linux-next: build failure after merge of the final tree
Hi all, After merging the final tree, today's linux-next build (powerpc allyesconfig) failed like this: fs/ocfs2/suballoc.c: In function 'ocfs2_block_group_set_bits': fs/ocfs2/suballoc.c:1357:2: error: implicit declaration of function 'trace_ocfs2_block_group_set_bits' [-Werror=implicit-function-declaration] trace_ocfs2_block_group_set_bits(bit_off, num_bits); ^ I have no idea how to track this down :-( The only patches affecting this code are now in Linus' tree. I can only assume that some implicitly included header file is no longer included. I have just left it broken for now. -- Cheers, Stephen Rothwells...@canb.auug.org.au pgppp3OXEhdkl.pgp Description: PGP signature
Re: linux-next: build failure after merge of the final tree (wireless-next tree related)
On Wed, Mar 19, 2014 at 05:20:35PM +1100, Stephen Rothwell wrote:
> Hi all,
>
> After merging the final tree, today's linux-next build (powerpc allyesconfig)
> failed like this:
>
> drivers/net/wireless/iwlwifi/mvm/debugfs.c: In function
> 'iwl_dbgfs_fw_error_dump_release':
> drivers/net/wireless/iwlwifi/mvm/debugfs.c:161:2: error: implicit declaration
> of function 'vfree' [-Werror=implicit-function-declaration]
> vfree(file->private_data);
> ^
>
> Caused by commit 1bd3cbc1a0e9 ("iwlwifi: mvm: send udev event upon
> firmware error to dump logs") from the wireless-next tree. See Rule 1
> from Documentation/SubmitChecklist.
>
> I have reverted that commit (and commit cdb00563fe2c ("iwlwifi: mvm: BT
> Coex - add debugfs hook to set BT Tx priority") that may depend on it)
> for today.
> --
> Cheers,
> Stephen Rothwells...@canb.auug.org.au
Clearly I need to beg someone for a powerpc box, so that I can find
more of these build failures... :-)
--
John W. LinvilleSomeday the world will need a hero, and you
linvi...@tuxdriver.com might be all we have. Be ready.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
RE: linux-next: build failure after merge of the final tree (wireless-next tree related)
>
> Hi all,
>
> After merging the final tree, today's linux-next build (powerpc allyesconfig)
> failed like this:
>
> drivers/net/wireless/iwlwifi/mvm/debugfs.c: In function
> 'iwl_dbgfs_fw_error_dump_release':
> drivers/net/wireless/iwlwifi/mvm/debugfs.c:161:2: error: implicit declaration
> of function 'vfree' [-Werror=implicit-function-declaration]
> vfree(file->private_data);
> ^
Sorry for that - patch on the way.
>
> Caused by commit 1bd3cbc1a0e9 ("iwlwifi: mvm: send udev event upon
> firmware error to dump logs") from the wireless-next tree. See Rule 1
> from Documentation/SubmitChecklist.
>
> I have reverted that commit (and commit cdb00563fe2c ("iwlwifi: mvm: BT
> Coex - add debugfs hook to set BT Tx priority") that may depend on it)
> for today.
> --
> Cheers,
> Stephen Rothwells...@canb.auug.org.au
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
linux-next: build failure after merge of the final tree (wireless-next tree related)
Hi all,
After merging the final tree, today's linux-next build (powerpc allyesconfig)
failed like this:
drivers/net/wireless/iwlwifi/mvm/debugfs.c: In function
'iwl_dbgfs_fw_error_dump_release':
drivers/net/wireless/iwlwifi/mvm/debugfs.c:161:2: error: implicit declaration
of function 'vfree' [-Werror=implicit-function-declaration]
vfree(file->private_data);
^
Caused by commit 1bd3cbc1a0e9 ("iwlwifi: mvm: send udev event upon
firmware error to dump logs") from the wireless-next tree. See Rule 1
from Documentation/SubmitChecklist.
I have reverted that commit (and commit cdb00563fe2c ("iwlwifi: mvm: BT
Coex - add debugfs hook to set BT Tx priority") that may depend on it)
for today.
--
Cheers,
Stephen Rothwells...@canb.auug.org.au
pgpV6kFZK_K7n.pgp
Description: PGP signature
linux-next: build failure after merge of the final tree (wireless-next tree related)
Hi all, After merging the final tree, today's linux-next build (powerpc allyesconfig) failed like this: drivers/net/wireless/iwlwifi/mvm/debugfs.c: In function 'iwl_dbgfs_fw_error_dump_release': drivers/net/wireless/iwlwifi/mvm/debugfs.c:161:2: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration] vfree(file-private_data); ^ Caused by commit 1bd3cbc1a0e9 (iwlwifi: mvm: send udev event upon firmware error to dump logs) from the wireless-next tree. See Rule 1 from Documentation/SubmitChecklist. I have reverted that commit (and commit cdb00563fe2c (iwlwifi: mvm: BT Coex - add debugfs hook to set BT Tx priority) that may depend on it) for today. -- Cheers, Stephen Rothwells...@canb.auug.org.au pgpV6kFZK_K7n.pgp Description: PGP signature
RE: linux-next: build failure after merge of the final tree (wireless-next tree related)
Hi all, After merging the final tree, today's linux-next build (powerpc allyesconfig) failed like this: drivers/net/wireless/iwlwifi/mvm/debugfs.c: In function 'iwl_dbgfs_fw_error_dump_release': drivers/net/wireless/iwlwifi/mvm/debugfs.c:161:2: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration] vfree(file-private_data); ^ Sorry for that - patch on the way. Caused by commit 1bd3cbc1a0e9 (iwlwifi: mvm: send udev event upon firmware error to dump logs) from the wireless-next tree. See Rule 1 from Documentation/SubmitChecklist. I have reverted that commit (and commit cdb00563fe2c (iwlwifi: mvm: BT Coex - add debugfs hook to set BT Tx priority) that may depend on it) for today. -- Cheers, Stephen Rothwells...@canb.auug.org.au -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the final tree (wireless-next tree related)
On Wed, Mar 19, 2014 at 05:20:35PM +1100, Stephen Rothwell wrote: Hi all, After merging the final tree, today's linux-next build (powerpc allyesconfig) failed like this: drivers/net/wireless/iwlwifi/mvm/debugfs.c: In function 'iwl_dbgfs_fw_error_dump_release': drivers/net/wireless/iwlwifi/mvm/debugfs.c:161:2: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration] vfree(file-private_data); ^ Caused by commit 1bd3cbc1a0e9 (iwlwifi: mvm: send udev event upon firmware error to dump logs) from the wireless-next tree. See Rule 1 from Documentation/SubmitChecklist. I have reverted that commit (and commit cdb00563fe2c (iwlwifi: mvm: BT Coex - add debugfs hook to set BT Tx priority) that may depend on it) for today. -- Cheers, Stephen Rothwells...@canb.auug.org.au Clearly I need to beg someone for a powerpc box, so that I can find more of these build failures... :-) -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the final tree (net-next tree related)
From: Stephen Rothwell
Date: Tue, 18 Mar 2014 18:27:52 +1100
> After merging the final tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
>
> net/netfilter/nft_hash.c: In function 'nft_hash_tbl_free':
> net/netfilter/nft_hash.c:79:3: error: implicit declaration of function
> 'vfree' [-Werror=implicit-function-declaration]
I've applied the patch below to fix this, thanks.
> Caused by commit ce6eb0d7c8ec ("netfilter: nft_hash: bug fixes and
> resizing") from the net-next tree. See Rule 1 in
> Documentation/SubmitChecklist.
This slips through a lot, and would happen less often if core x86
headers didn't bring in vmalloc.h :-)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the final tree (net-next tree related)
From: Stephen Rothwell
Date: Mon, 17 Mar 2014 21:21:00 +1100
> After merging the final tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
>
> drivers/net/ethernet/intel/i40evf/built-in.o:(.data+0x1868): multiple
> definition of `i40e_ptype_lookup'
> drivers/net/ethernet/intel/i40e/built-in.o:(.data+0x3f58): first defined here
>
> Caused by commit 206812b5fccb ("i40e/i40evf: i40e implementation for
> skb_set_hash") from the net-next tree.
>
> I applied this patch for today (there is probably a better way):
>
> From 6964d39f8436eade2cdb0c5236734c579b8b0897 Mon Sep 17 00:00:00 2001
> From: Stephen Rothwell
> Date: Mon, 17 Mar 2014 21:18:48 +1100
> Subject: [PATCH] i40e/i40evf: i40e implementation for skb_set_hash fix
>
> Signed-off-by: Stephen Rothwell
Jeff Kirsher gave me a patch today that fixes this, thanks Stephen.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
linux-next: build failure after merge of the final tree (wireless-next tree related)
Hi all,
After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:
In file included from drivers/net/wireless/rsi/rsi_mgmt.h:22:0,
from drivers/net/wireless/rsi/rsi_91x_core.c:17:
drivers/net/wireless/rsi/rsi_91x_core.c: In function 'rsi_dbg':
drivers/net/wireless/rsi/rsi_main.h:44:20: error: function 'rsi_dbg' can never
be inlined because it uses variable argument lists
static inline void rsi_dbg(u32 zone, const char *fmt, ...)
^
I got quite a few of these. I am using gcc version 4.8.1 if that matters.
Caused by commit dad0d04fa7ba ("rsi: Add RS9113 wireless driver") from
the wireless-next tree.
I have reverted that commit for today.
--
Cheers,
Stephen Rothwells...@canb.auug.org.au
pgpSeN1OPXOEZ.pgp
Description: PGP signature
linux-next: build failure after merge of the final tree (net-next tree related)
Hi all,
After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:
net/netfilter/nft_hash.c: In function 'nft_hash_tbl_free':
net/netfilter/nft_hash.c:79:3: error: implicit declaration of function 'vfree'
[-Werror=implicit-function-declaration]
vfree(tbl);
^
net/netfilter/nft_hash.c: In function 'nft_hash_tbl_alloc':
net/netfilter/nft_hash.c:92:3: error: implicit declaration of function
'vzalloc' [-Werror=implicit-function-declaration]
tbl = vzalloc(size);
^
net/netfilter/nft_hash.c:92:7: warning: assignment makes pointer from integer
without a cast [enabled by default]
tbl = vzalloc(size);
^
Caused by commit ce6eb0d7c8ec ("netfilter: nft_hash: bug fixes and
resizing") from the net-next tree. See Rule 1 in
Documentation/SubmitChecklist.
I have reverted that commit for today.
--
Cheers,
Stephen Rothwells...@canb.auug.org.au
pgp19PnRCP17k.pgp
Description: PGP signature
linux-next: build failure after merge of the final tree (net-next tree related)
Hi all, After merging the final tree, today's linux-next build (powerpc allyesconfig) failed like this: net/netfilter/nft_hash.c: In function 'nft_hash_tbl_free': net/netfilter/nft_hash.c:79:3: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration] vfree(tbl); ^ net/netfilter/nft_hash.c: In function 'nft_hash_tbl_alloc': net/netfilter/nft_hash.c:92:3: error: implicit declaration of function 'vzalloc' [-Werror=implicit-function-declaration] tbl = vzalloc(size); ^ net/netfilter/nft_hash.c:92:7: warning: assignment makes pointer from integer without a cast [enabled by default] tbl = vzalloc(size); ^ Caused by commit ce6eb0d7c8ec (netfilter: nft_hash: bug fixes and resizing) from the net-next tree. See Rule 1 in Documentation/SubmitChecklist. I have reverted that commit for today. -- Cheers, Stephen Rothwells...@canb.auug.org.au pgp19PnRCP17k.pgp Description: PGP signature
linux-next: build failure after merge of the final tree (wireless-next tree related)
Hi all, After merging the final tree, today's linux-next build (powerpc allyesconfig) failed like this: In file included from drivers/net/wireless/rsi/rsi_mgmt.h:22:0, from drivers/net/wireless/rsi/rsi_91x_core.c:17: drivers/net/wireless/rsi/rsi_91x_core.c: In function 'rsi_dbg': drivers/net/wireless/rsi/rsi_main.h:44:20: error: function 'rsi_dbg' can never be inlined because it uses variable argument lists static inline void rsi_dbg(u32 zone, const char *fmt, ...) ^ I got quite a few of these. I am using gcc version 4.8.1 if that matters. Caused by commit dad0d04fa7ba (rsi: Add RS9113 wireless driver) from the wireless-next tree. I have reverted that commit for today. -- Cheers, Stephen Rothwells...@canb.auug.org.au pgpSeN1OPXOEZ.pgp Description: PGP signature
Re: linux-next: build failure after merge of the final tree (net-next tree related)
From: Stephen Rothwell s...@canb.auug.org.au Date: Mon, 17 Mar 2014 21:21:00 +1100 After merging the final tree, today's linux-next build (powerpc allyesconfig) failed like this: drivers/net/ethernet/intel/i40evf/built-in.o:(.data+0x1868): multiple definition of `i40e_ptype_lookup' drivers/net/ethernet/intel/i40e/built-in.o:(.data+0x3f58): first defined here Caused by commit 206812b5fccb (i40e/i40evf: i40e implementation for skb_set_hash) from the net-next tree. I applied this patch for today (there is probably a better way): From 6964d39f8436eade2cdb0c5236734c579b8b0897 Mon Sep 17 00:00:00 2001 From: Stephen Rothwell s...@canb.auug.org.au Date: Mon, 17 Mar 2014 21:18:48 +1100 Subject: [PATCH] i40e/i40evf: i40e implementation for skb_set_hash fix Signed-off-by: Stephen Rothwell s...@canb.auug.org.au Jeff Kirsher gave me a patch today that fixes this, thanks Stephen. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the final tree (net-next tree related)
From: Stephen Rothwell s...@canb.auug.org.au Date: Tue, 18 Mar 2014 18:27:52 +1100 After merging the final tree, today's linux-next build (powerpc allyesconfig) failed like this: net/netfilter/nft_hash.c: In function 'nft_hash_tbl_free': net/netfilter/nft_hash.c:79:3: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration] I've applied the patch below to fix this, thanks. Caused by commit ce6eb0d7c8ec (netfilter: nft_hash: bug fixes and resizing) from the net-next tree. See Rule 1 in Documentation/SubmitChecklist. This slips through a lot, and would happen less often if core x86 headers didn't bring in vmalloc.h :-) -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
linux-next: build failure after merge of the final tree (net-next tree related)
Hi all,
After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:
drivers/net/ethernet/intel/i40evf/built-in.o:(.data+0x1868): multiple
definition of `i40e_ptype_lookup'
drivers/net/ethernet/intel/i40e/built-in.o:(.data+0x3f58): first defined here
Caused by commit 206812b5fccb ("i40e/i40evf: i40e implementation for
skb_set_hash") from the net-next tree.
I applied this patch for today (there is probably a better way):
From 6964d39f8436eade2cdb0c5236734c579b8b0897 Mon Sep 17 00:00:00 2001
From: Stephen Rothwell
Date: Mon, 17 Mar 2014 21:18:48 +1100
Subject: [PATCH] i40e/i40evf: i40e implementation for skb_set_hash fix
Signed-off-by: Stephen Rothwell
---
drivers/net/ethernet/intel/i40evf/i40e_common.c| 8
drivers/net/ethernet/intel/i40evf/i40e_prototype.h | 4 ++--
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/net/ethernet/intel/i40evf/i40e_common.c
b/drivers/net/ethernet/intel/i40evf/i40e_common.c
index 78618af271cf..c688a0fc5c29 100644
--- a/drivers/net/ethernet/intel/i40evf/i40e_common.c
+++ b/drivers/net/ethernet/intel/i40evf/i40e_common.c
@@ -160,7 +160,7 @@ i40e_status i40evf_aq_queue_shutdown(struct i40e_hw *hw,
}
-/* The i40e_ptype_lookup table is used to convert from the 8-bit ptype in the
+/* The i40evf_ptype_lookup table is used to convert from the 8-bit ptype in the
* hardware to a bit-field that can be used by SW to more easily determine the
* packet type.
*
@@ -173,10 +173,10 @@ i40e_status i40evf_aq_queue_shutdown(struct i40e_hw *hw,
*
* Typical work flow:
*
- * IF NOT i40e_ptype_lookup[ptype].known
+ * IF NOT i40evf_ptype_lookup[ptype].known
* THEN
* Packet is unknown
- * ELSE IF i40e_ptype_lookup[ptype].outer_ip == I40E_RX_PTYPE_OUTER_IP
+ * ELSE IF i40evf_ptype_lookup[ptype].outer_ip == I40E_RX_PTYPE_OUTER_IP
* Use the rest of the fields to look at the tunnels, inner protocols, etc
* ELSE
* Use the enum i40e_rx_l2_ptype to decode the packet type
@@ -205,7 +205,7 @@ i40e_status i40evf_aq_queue_shutdown(struct i40e_hw *hw,
#define I40E_RX_PTYPE_INNER_PROT_TSI40E_RX_PTYPE_INNER_PROT_TIMESYNC
/* Lookup table mapping the HW PTYPE to the bit field for decoding */
-struct i40e_rx_ptype_decoded i40e_ptype_lookup[] = {
+struct i40e_rx_ptype_decoded i40evf_ptype_lookup[] = {
/* L2 Packet types */
I40E_PTT_UNUSED_ENTRY(0),
I40E_PTT(1, L2, NONE, NOF, NONE, NONE, NOF, NONE, PAY2),
diff --git a/drivers/net/ethernet/intel/i40evf/i40e_prototype.h
b/drivers/net/ethernet/intel/i40evf/i40e_prototype.h
index 33c99051cc96..862fcdf52675 100644
--- a/drivers/net/ethernet/intel/i40evf/i40e_prototype.h
+++ b/drivers/net/ethernet/intel/i40evf/i40e_prototype.h
@@ -63,11 +63,11 @@ i40e_status i40evf_aq_queue_shutdown(struct i40e_hw *hw,
i40e_status i40e_set_mac_type(struct i40e_hw *hw);
-extern struct i40e_rx_ptype_decoded i40e_ptype_lookup[];
+extern struct i40e_rx_ptype_decoded i40evf_ptype_lookup[];
static inline struct i40e_rx_ptype_decoded decode_rx_desc_ptype(u8 ptype)
{
- return i40e_ptype_lookup[ptype];
+ return i40evf_ptype_lookup[ptype];
}
/* prototype for functions used for SW locks */
--
1.9.0
--
Cheers,
Stephen Rothwells...@canb.auug.org.au
pgp0KWX4EXtxD.pgp
Description: PGP signature
linux-next: build failure after merge of the final tree (net-next tree related)
Hi all,
After merging the final tree, today's linux-next build (sparc64 defconfig)
failed like this:
drivers/net/ethernet/intel/e1000e/netdev.c:7079:13: error: 'e1000e_pm_suspend'
undeclared here (not in a function)
drivers/net/ethernet/intel/e1000e/netdev.c:7080:13: error: 'e1000e_pm_resume'
undeclared here (not in a function)
drivers/net/ethernet/intel/e1000e/netdev.c:7082:11: error: 'e1000e_pm_thaw'
undeclared here (not in a function)
Caused by commit 2800209994f8 ("e1000e: Refactor PM flows") from the
net-next tree.
I reverted that commit for today (and 63eb48f151b5 "e1000e Refactor of
Runtime Power Management" that conflicts with the revert).
--
Cheers,
Stephen Rothwells...@canb.auug.org.au
pgpDehplBUq5q.pgp
Description: PGP signature
linux-next: build failure after merge of the final tree (net-next tree related)
Hi all, After merging the final tree, today's linux-next build (sparc64 defconfig) failed like this: drivers/net/ethernet/intel/e1000e/netdev.c:7079:13: error: 'e1000e_pm_suspend' undeclared here (not in a function) drivers/net/ethernet/intel/e1000e/netdev.c:7080:13: error: 'e1000e_pm_resume' undeclared here (not in a function) drivers/net/ethernet/intel/e1000e/netdev.c:7082:11: error: 'e1000e_pm_thaw' undeclared here (not in a function) Caused by commit 2800209994f8 (e1000e: Refactor PM flows) from the net-next tree. I reverted that commit for today (and 63eb48f151b5 e1000e Refactor of Runtime Power Management that conflicts with the revert). -- Cheers, Stephen Rothwells...@canb.auug.org.au pgpDehplBUq5q.pgp Description: PGP signature
linux-next: build failure after merge of the final tree (net-next tree related)
Hi all,
After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:
drivers/net/ethernet/intel/i40evf/built-in.o:(.data+0x1868): multiple
definition of `i40e_ptype_lookup'
drivers/net/ethernet/intel/i40e/built-in.o:(.data+0x3f58): first defined here
Caused by commit 206812b5fccb (i40e/i40evf: i40e implementation for
skb_set_hash) from the net-next tree.
I applied this patch for today (there is probably a better way):
From 6964d39f8436eade2cdb0c5236734c579b8b0897 Mon Sep 17 00:00:00 2001
From: Stephen Rothwell s...@canb.auug.org.au
Date: Mon, 17 Mar 2014 21:18:48 +1100
Subject: [PATCH] i40e/i40evf: i40e implementation for skb_set_hash fix
Signed-off-by: Stephen Rothwell s...@canb.auug.org.au
---
drivers/net/ethernet/intel/i40evf/i40e_common.c| 8
drivers/net/ethernet/intel/i40evf/i40e_prototype.h | 4 ++--
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/net/ethernet/intel/i40evf/i40e_common.c
b/drivers/net/ethernet/intel/i40evf/i40e_common.c
index 78618af271cf..c688a0fc5c29 100644
--- a/drivers/net/ethernet/intel/i40evf/i40e_common.c
+++ b/drivers/net/ethernet/intel/i40evf/i40e_common.c
@@ -160,7 +160,7 @@ i40e_status i40evf_aq_queue_shutdown(struct i40e_hw *hw,
}
-/* The i40e_ptype_lookup table is used to convert from the 8-bit ptype in the
+/* The i40evf_ptype_lookup table is used to convert from the 8-bit ptype in the
* hardware to a bit-field that can be used by SW to more easily determine the
* packet type.
*
@@ -173,10 +173,10 @@ i40e_status i40evf_aq_queue_shutdown(struct i40e_hw *hw,
*
* Typical work flow:
*
- * IF NOT i40e_ptype_lookup[ptype].known
+ * IF NOT i40evf_ptype_lookup[ptype].known
* THEN
* Packet is unknown
- * ELSE IF i40e_ptype_lookup[ptype].outer_ip == I40E_RX_PTYPE_OUTER_IP
+ * ELSE IF i40evf_ptype_lookup[ptype].outer_ip == I40E_RX_PTYPE_OUTER_IP
* Use the rest of the fields to look at the tunnels, inner protocols, etc
* ELSE
* Use the enum i40e_rx_l2_ptype to decode the packet type
@@ -205,7 +205,7 @@ i40e_status i40evf_aq_queue_shutdown(struct i40e_hw *hw,
#define I40E_RX_PTYPE_INNER_PROT_TSI40E_RX_PTYPE_INNER_PROT_TIMESYNC
/* Lookup table mapping the HW PTYPE to the bit field for decoding */
-struct i40e_rx_ptype_decoded i40e_ptype_lookup[] = {
+struct i40e_rx_ptype_decoded i40evf_ptype_lookup[] = {
/* L2 Packet types */
I40E_PTT_UNUSED_ENTRY(0),
I40E_PTT(1, L2, NONE, NOF, NONE, NONE, NOF, NONE, PAY2),
diff --git a/drivers/net/ethernet/intel/i40evf/i40e_prototype.h
b/drivers/net/ethernet/intel/i40evf/i40e_prototype.h
index 33c99051cc96..862fcdf52675 100644
--- a/drivers/net/ethernet/intel/i40evf/i40e_prototype.h
+++ b/drivers/net/ethernet/intel/i40evf/i40e_prototype.h
@@ -63,11 +63,11 @@ i40e_status i40evf_aq_queue_shutdown(struct i40e_hw *hw,
i40e_status i40e_set_mac_type(struct i40e_hw *hw);
-extern struct i40e_rx_ptype_decoded i40e_ptype_lookup[];
+extern struct i40e_rx_ptype_decoded i40evf_ptype_lookup[];
static inline struct i40e_rx_ptype_decoded decode_rx_desc_ptype(u8 ptype)
{
- return i40e_ptype_lookup[ptype];
+ return i40evf_ptype_lookup[ptype];
}
/* prototype for functions used for SW locks */
--
1.9.0
--
Cheers,
Stephen Rothwells...@canb.auug.org.au
pgp0KWX4EXtxD.pgp
Description: PGP signature
Re: linux-next: build failure after merge of the final tree (gpio tree related)
Hi, On Wed, Mar 5, 2014, 3:16 PM, Linus Walleij wrote: > On Wed, Mar 5, 2014 at 2:35 PM, Stephen Rothwell > wrote: > > > After merging the final tree, today's linux-next build (powerpc > > allyesconfig) failed like this: > > > > drivers/gpio/gpio-zevio.c: In function 'zevio_gpio_port_get': > > drivers/gpio/gpio-zevio.c:70:2: error: implicit declaration of function > > 'IOMEM' [-Werror=implicit-function-declaration] > > return readl(IOMEM(c->chip.regs + section_offset + port_offset)); > > ^ > > drivers/gpio/gpio-zevio.c:70:2: warning: passing argument 1 of 'readl' > > makes pointer from integer without a cast [enabled by default] > > In file included from include/linux/io.h:22:0, > > from drivers/gpio/gpio-zevio.c:15: > > arch/powerpc/include/asm/io-defs.h:6:16: note: expected 'const volatile > > void *' but argument is of type 'int' > > DEF_PCI_AC_RET(readl, u32, (const PCI_IO_ADDR addr), (addr), mem, addr) > > ^ > > Fabian can you suggest a patch adding the proper depends added to > the Kconfig. Check what things bring in the IOMEM etc that is needed > to compile this. It looks like powerpc doesn't have the IOMEM macro (which just casts to "void __iomem*"). Would "depends on ARM && OF_GPIO" be ok? > Yours, > Linus Walleij Bye, Fabian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the final tree (gpio tree related)
Hi, On Wed, Mar 5, 2014, 3:16 PM, Linus Walleij wrote: On Wed, Mar 5, 2014 at 2:35 PM, Stephen Rothwell s...@canb.auug.org.au wrote: After merging the final tree, today's linux-next build (powerpc allyesconfig) failed like this: drivers/gpio/gpio-zevio.c: In function 'zevio_gpio_port_get': drivers/gpio/gpio-zevio.c:70:2: error: implicit declaration of function 'IOMEM' [-Werror=implicit-function-declaration] return readl(IOMEM(c-chip.regs + section_offset + port_offset)); ^ drivers/gpio/gpio-zevio.c:70:2: warning: passing argument 1 of 'readl' makes pointer from integer without a cast [enabled by default] In file included from include/linux/io.h:22:0, from drivers/gpio/gpio-zevio.c:15: arch/powerpc/include/asm/io-defs.h:6:16: note: expected 'const volatile void *' but argument is of type 'int' DEF_PCI_AC_RET(readl, u32, (const PCI_IO_ADDR addr), (addr), mem, addr) ^ Fabian can you suggest a patch adding the proper depends added to the Kconfig. Check what things bring in the IOMEM etc that is needed to compile this. It looks like powerpc doesn't have the IOMEM macro (which just casts to void __iomem*). Would depends on ARM OF_GPIO be ok? Yours, Linus Walleij Bye, Fabian -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the final tree (gpio tree related)
On Wed, Mar 5, 2014 at 2:35 PM, Stephen Rothwell wrote: > After merging the final tree, today's linux-next build (powerpc > allyesconfig) failed like this: > > drivers/gpio/gpio-zevio.c: In function 'zevio_gpio_port_get': > drivers/gpio/gpio-zevio.c:70:2: error: implicit declaration of function > 'IOMEM' [-Werror=implicit-function-declaration] > return readl(IOMEM(c->chip.regs + section_offset + port_offset)); > ^ > drivers/gpio/gpio-zevio.c:70:2: warning: passing argument 1 of 'readl' makes > pointer from integer without a cast [enabled by default] > In file included from include/linux/io.h:22:0, > from drivers/gpio/gpio-zevio.c:15: > arch/powerpc/include/asm/io-defs.h:6:16: note: expected 'const volatile void > *' but argument is of type 'int' > DEF_PCI_AC_RET(readl, u32, (const PCI_IO_ADDR addr), (addr), mem, addr) > ^ Fabian can you suggest a patch adding the proper depends added to the Kconfig. Check what things bring in the IOMEM etc that is needed to compile this. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
linux-next: build failure after merge of the final tree (gpio tree related)
Hi all,
After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:
drivers/gpio/gpio-zevio.c: In function 'zevio_gpio_port_get':
drivers/gpio/gpio-zevio.c:70:2: error: implicit declaration of function 'IOMEM'
[-Werror=implicit-function-declaration]
return readl(IOMEM(c->chip.regs + section_offset + port_offset));
^
drivers/gpio/gpio-zevio.c:70:2: warning: passing argument 1 of 'readl' makes
pointer from integer without a cast [enabled by default]
In file included from include/linux/io.h:22:0,
from drivers/gpio/gpio-zevio.c:15:
arch/powerpc/include/asm/io-defs.h:6:16: note: expected 'const volatile void *'
but argument is of type 'int'
DEF_PCI_AC_RET(readl, u32, (const PCI_IO_ADDR addr), (addr), mem, addr)
^
arch/powerpc/include/asm/io.h:577:19: note: in definition of macro
'DEF_PCI_AC_RET'
static inline ret name at \
^
drivers/gpio/gpio-zevio.c: In function 'zevio_gpio_port_set':
drivers/gpio/gpio-zevio.c:77:2: warning: passing argument 2 of 'writel' makes
pointer from integer without a cast [enabled by default]
writel(val, IOMEM(c->chip.regs + section_offset + port_offset));
^
In file included from include/linux/io.h:22:0,
from drivers/gpio/gpio-zevio.c:15:
arch/powerpc/include/asm/io-defs.h:11:18: note: expected 'volatile void *' but
argument is of type 'int'
DEF_PCI_AC_NORET(writel, (u32 val, PCI_IO_ADDR addr), (val, addr), mem, addr)
^
arch/powerpc/include/asm/io.h:585:20: note: in definition of macro
'DEF_PCI_AC_NORET'
static inline void name at \
^
Caused by commit 9af4d80ba566 ("gpio: New driver for LSI ZEVIO SoCs").
I have reverted that commit for today.
--
Cheers,
Stephen Rothwells...@canb.auug.org.au
pgp79obEc_xOh.pgp
Description: PGP signature
linux-next: build failure after merge of the final tree (gpio tree related)
Hi all, After merging the final tree, today's linux-next build (powerpc allyesconfig) failed like this: drivers/gpio/gpio-zevio.c: In function 'zevio_gpio_port_get': drivers/gpio/gpio-zevio.c:70:2: error: implicit declaration of function 'IOMEM' [-Werror=implicit-function-declaration] return readl(IOMEM(c-chip.regs + section_offset + port_offset)); ^ drivers/gpio/gpio-zevio.c:70:2: warning: passing argument 1 of 'readl' makes pointer from integer without a cast [enabled by default] In file included from include/linux/io.h:22:0, from drivers/gpio/gpio-zevio.c:15: arch/powerpc/include/asm/io-defs.h:6:16: note: expected 'const volatile void *' but argument is of type 'int' DEF_PCI_AC_RET(readl, u32, (const PCI_IO_ADDR addr), (addr), mem, addr) ^ arch/powerpc/include/asm/io.h:577:19: note: in definition of macro 'DEF_PCI_AC_RET' static inline ret name at \ ^ drivers/gpio/gpio-zevio.c: In function 'zevio_gpio_port_set': drivers/gpio/gpio-zevio.c:77:2: warning: passing argument 2 of 'writel' makes pointer from integer without a cast [enabled by default] writel(val, IOMEM(c-chip.regs + section_offset + port_offset)); ^ In file included from include/linux/io.h:22:0, from drivers/gpio/gpio-zevio.c:15: arch/powerpc/include/asm/io-defs.h:11:18: note: expected 'volatile void *' but argument is of type 'int' DEF_PCI_AC_NORET(writel, (u32 val, PCI_IO_ADDR addr), (val, addr), mem, addr) ^ arch/powerpc/include/asm/io.h:585:20: note: in definition of macro 'DEF_PCI_AC_NORET' static inline void name at \ ^ Caused by commit 9af4d80ba566 (gpio: New driver for LSI ZEVIO SoCs). I have reverted that commit for today. -- Cheers, Stephen Rothwells...@canb.auug.org.au pgp79obEc_xOh.pgp Description: PGP signature
Re: linux-next: build failure after merge of the final tree (gpio tree related)
On Wed, Mar 5, 2014 at 2:35 PM, Stephen Rothwell s...@canb.auug.org.au wrote: After merging the final tree, today's linux-next build (powerpc allyesconfig) failed like this: drivers/gpio/gpio-zevio.c: In function 'zevio_gpio_port_get': drivers/gpio/gpio-zevio.c:70:2: error: implicit declaration of function 'IOMEM' [-Werror=implicit-function-declaration] return readl(IOMEM(c-chip.regs + section_offset + port_offset)); ^ drivers/gpio/gpio-zevio.c:70:2: warning: passing argument 1 of 'readl' makes pointer from integer without a cast [enabled by default] In file included from include/linux/io.h:22:0, from drivers/gpio/gpio-zevio.c:15: arch/powerpc/include/asm/io-defs.h:6:16: note: expected 'const volatile void *' but argument is of type 'int' DEF_PCI_AC_RET(readl, u32, (const PCI_IO_ADDR addr), (addr), mem, addr) ^ Fabian can you suggest a patch adding the proper depends added to the Kconfig. Check what things bring in the IOMEM etc that is needed to compile this. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
linux-next: build failure after merge of the final tree (char-misc tree related)
Hi all,
After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:
drivers/iio/adc/men_z188_adc.c: In function 'z188_iio_read_raw':
drivers/iio/adc/men_z188_adc.c:61:3: error: implicit declaration of function
'readw' [-Werror=implicit-function-declaration]
tmp = readw(adc->base + chan->channel * 4);
^
drivers/iio/adc/men_z188_adc.c: In function 'men_z188_config_channels':
drivers/iio/adc/men_z188_adc.c:91:2: error: implicit declaration of function
'readl' [-Werror=implicit-function-declaration]
ctl = readl(addr + Z188_CTRL_REG);
^
drivers/iio/adc/men_z188_adc.c:93:2: error: implicit declaration of function
'writel' [-Werror=implicit-function-declaration]
writel(ctl, addr + Z188_CTRL_REG);
^
drivers/iio/adc/men_z188_adc.c: In function 'men_z188_probe':
drivers/iio/adc/men_z188_adc.c:126:2: error: implicit declaration of function
'ioremap' [-Werror=implicit-function-declaration]
adc->base = ioremap(mem->start, resource_size(mem));
^
drivers/iio/adc/men_z188_adc.c:126:12: warning: assignment makes pointer from
integer without a cast [enabled by default]
adc->base = ioremap(mem->start, resource_size(mem));
^
drivers/iio/adc/men_z188_adc.c: In function 'men_z188_remove':
drivers/iio/adc/men_z188_adc.c:148:2: error: implicit declaration of function
'iounmap' [-Werror=implicit-function-declaration]
iounmap(adc->base);
^
Caused by commit 74aeac4da66f ("iio: adc: Add MEN 16z188 ADC driver")
from the char-misc tree. Need to include linux/io.h, I think.
I have reverted that commit for today.
--
Cheers,
Stephen Rothwells...@canb.auug.org.au
pgpiAuuPDeN7c.pgp
Description: PGP signature
linux-next: build failure after merge of the final tree (char-misc tree related)
Hi all,
After merging the final tree, today's linux-next build (arm defconfig)
failed like this:
drivers/mcb/mcb-pci.c: At top level:
drivers/mcb/mcb-pci.c:110:1: warning: data definition has no type or storage
class [enabled by default]
drivers/mcb/mcb-pci.c:110:1: error: type defaults to 'int' in declaration of
'module_pci_driver' [-Werror=implicit-int]
drivers/mcb/mcb-pci.c:110:1: warning: parameter names (without types) in
function declaration [enabled by default]
drivers/mcb/mcb-pci.c:103:26: warning: 'mcb_pci_driver' defined but not used
[-Wunused-variable]
Caused by commit b71bb8639891 ("mcb: Add PCI carrier for MEN Chameleon
Bus") from the char-misc tree. module_pci_driver is defined in
linux/pci.h only if CONFIG_PCI is defined (which is not true for this
build).
I have reverted that commit for today.
--
Cheers,
Stephen Rothwells...@canb.auug.org.au
pgpNTJY6Ewpqb.pgp
Description: PGP signature
linux-next: build failure after merge of the final tree (char-misc tree related)
Hi all, After merging the final tree, today's linux-next build (arm defconfig) failed like this: drivers/mcb/mcb-pci.c: At top level: drivers/mcb/mcb-pci.c:110:1: warning: data definition has no type or storage class [enabled by default] drivers/mcb/mcb-pci.c:110:1: error: type defaults to 'int' in declaration of 'module_pci_driver' [-Werror=implicit-int] drivers/mcb/mcb-pci.c:110:1: warning: parameter names (without types) in function declaration [enabled by default] drivers/mcb/mcb-pci.c:103:26: warning: 'mcb_pci_driver' defined but not used [-Wunused-variable] Caused by commit b71bb8639891 (mcb: Add PCI carrier for MEN Chameleon Bus) from the char-misc tree. module_pci_driver is defined in linux/pci.h only if CONFIG_PCI is defined (which is not true for this build). I have reverted that commit for today. -- Cheers, Stephen Rothwells...@canb.auug.org.au pgpNTJY6Ewpqb.pgp Description: PGP signature
linux-next: build failure after merge of the final tree (char-misc tree related)
Hi all, After merging the final tree, today's linux-next build (powerpc allyesconfig) failed like this: drivers/iio/adc/men_z188_adc.c: In function 'z188_iio_read_raw': drivers/iio/adc/men_z188_adc.c:61:3: error: implicit declaration of function 'readw' [-Werror=implicit-function-declaration] tmp = readw(adc-base + chan-channel * 4); ^ drivers/iio/adc/men_z188_adc.c: In function 'men_z188_config_channels': drivers/iio/adc/men_z188_adc.c:91:2: error: implicit declaration of function 'readl' [-Werror=implicit-function-declaration] ctl = readl(addr + Z188_CTRL_REG); ^ drivers/iio/adc/men_z188_adc.c:93:2: error: implicit declaration of function 'writel' [-Werror=implicit-function-declaration] writel(ctl, addr + Z188_CTRL_REG); ^ drivers/iio/adc/men_z188_adc.c: In function 'men_z188_probe': drivers/iio/adc/men_z188_adc.c:126:2: error: implicit declaration of function 'ioremap' [-Werror=implicit-function-declaration] adc-base = ioremap(mem-start, resource_size(mem)); ^ drivers/iio/adc/men_z188_adc.c:126:12: warning: assignment makes pointer from integer without a cast [enabled by default] adc-base = ioremap(mem-start, resource_size(mem)); ^ drivers/iio/adc/men_z188_adc.c: In function 'men_z188_remove': drivers/iio/adc/men_z188_adc.c:148:2: error: implicit declaration of function 'iounmap' [-Werror=implicit-function-declaration] iounmap(adc-base); ^ Caused by commit 74aeac4da66f (iio: adc: Add MEN 16z188 ADC driver) from the char-misc tree. Need to include linux/io.h, I think. I have reverted that commit for today. -- Cheers, Stephen Rothwells...@canb.auug.org.au pgpiAuuPDeN7c.pgp Description: PGP signature
Re: linux-next: build failure after merge of the final tree (akpm-current tree related)
On Thu, Feb 27, 2014 at 01:40:57PM +1100, Stephen Rothwell wrote: > Hi Josh, > > On Wed, 26 Feb 2014 18:21:29 -0800 Josh Triplett > wrote: > > > > On Thu, Feb 27, 2014 at 10:00:26AM +1100, Stephen Rothwell wrote: > > > Please check the build results overnight tonight (for next-20140227 at > > > http://kisskb.ellerman.id.au/linux-next) and submit any more fixes for > > > the allnoconfig build errors. > > > > Checking that site, I don't see any other instances of failures caused > > by allnoconfig. If I'm missing some, could you please point me to the > > page on that site I'm missing? > > That is because your patch was reverted in yesterday's (next-20140226) > linux-next. You will need to look tomorrow (next-20140227) sometime. It looks like the next-20140227 builds have shown up, and I only see one additional allnoconfig build failure exposed by my patch (TTY dependency on cris arch-v10). I sent a patch for that one. I *think* that should have it covered; let me know if you see any other failures. - Josh Triplett -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the final tree (akpm-current tree related)
On Thu, Feb 27, 2014 at 01:40:57PM +1100, Stephen Rothwell wrote: Hi Josh, On Wed, 26 Feb 2014 18:21:29 -0800 Josh Triplett j...@joshtriplett.org wrote: On Thu, Feb 27, 2014 at 10:00:26AM +1100, Stephen Rothwell wrote: Please check the build results overnight tonight (for next-20140227 at http://kisskb.ellerman.id.au/linux-next) and submit any more fixes for the allnoconfig build errors. Checking that site, I don't see any other instances of failures caused by allnoconfig. If I'm missing some, could you please point me to the page on that site I'm missing? That is because your patch was reverted in yesterday's (next-20140226) linux-next. You will need to look tomorrow (next-20140227) sometime. It looks like the next-20140227 builds have shown up, and I only see one additional allnoconfig build failure exposed by my patch (TTY dependency on cris arch-v10). I sent a patch for that one. I *think* that should have it covered; let me know if you see any other failures. - Josh Triplett -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the final tree (akpm-current tree related)
Hi Josh, On Wed, 26 Feb 2014 18:21:29 -0800 Josh Triplett wrote: > > On Thu, Feb 27, 2014 at 10:00:26AM +1100, Stephen Rothwell wrote: > > Please check the build results overnight tonight (for next-20140227 at > > http://kisskb.ellerman.id.au/linux-next) and submit any more fixes for > > the allnoconfig build errors. > > Checking that site, I don't see any other instances of failures caused > by allnoconfig. If I'm missing some, could you please point me to the > page on that site I'm missing? That is because your patch was reverted in yesterday's (next-20140226) linux-next. You will need to look tomorrow (next-20140227) sometime. -- Cheers, Stephen Rothwells...@canb.auug.org.au pgp9XrqaUaXyo.pgp Description: PGP signature
Re: linux-next: build failure after merge of the final tree (akpm-current tree related)
On Thu, Feb 27, 2014 at 10:00:26AM +1100, Stephen Rothwell wrote: > Please check the build results overnight tonight (for next-20140227 at > http://kisskb.ellerman.id.au/linux-next) and submit any more fixes for > the allnoconfig build errors. Checking that site, I don't see any other instances of failures caused by allnoconfig. If I'm missing some, could you please point me to the page on that site I'm missing? - Josh Triplett -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the final tree (akpm-current tree related)
Hi Josh, On Wed, 26 Feb 2014 15:19:16 -0800 Josh Triplett wrote: > > Please also fold in my patch "ia64: select CONFIG_TTY for use of > tty_write_message in unaligned". (Just bounced you a copy.) Done. > There's an s390 issue as well which needs the same fix (make the > top-level architecture symbol select TTY). > > I'll look at the other issues tonight. OK, thanks. -- Cheers, Stephen Rothwells...@canb.auug.org.au pgpLl4Mp2ZBkn.pgp Description: PGP signature
Re: linux-next: build failure after merge of the final tree (akpm-current tree related)
On Thu, Feb 27, 2014 at 10:00:26AM +1100, Stephen Rothwell wrote:
> Hi Josh,
>
> On Wed, 26 Feb 2014 02:02:34 -0800 Josh Triplett
> wrote:
> >
> > On Wed, Feb 26, 2014 at 07:16:27PM +1100, Stephen Rothwell wrote:
> > >
> > > After merging the final tree, today's linux-next build (powerpc64
> > > allnoconfig) failed like this:
> > >
> > > arch/powerpc/kernel/built-in.o: In function `.machine_check_queue_event':
> > > (.text+0x11260): undefined reference to `.irq_work_queue'
> > >
> > > Caused (or exposed) (along with a lot of warnings) by commit 3dd6115cd60b
> > > ("kconfig: make allnoconfig disable options behind EMBEDDED and EXPERT")
> > > from the apm-current tree.
> >
> > Pre-existing, just now triggerable with just "make allnoconfig" rather
> > than manually turning off other options (like PRINTK) that select
> > IRQ_WORK. (One of the goals of that commit: get those options more
> > widely used and build-tested.)
> >
> > The following (untested) patch *should* fix this:
> > - 8< -
> > From 36a5b6c87292b6c5eeb390ed6dc6acbb8f0a3767 Mon Sep 17 00:00:00 2001
> > From: Josh Triplett
> > Date: Wed, 26 Feb 2014 01:58:02 -0800
> > Subject: [PATCH] ppc: Make PPC_BOOK3S_64 select IRQ_WORK
>
> OK, I added this as a merge fix patch for Andrew's tree today. Please
> check the build results overnight tonight (for next-20140227 at
> http://kisskb.ellerman.id.au/linux-next) and submit any more fixes for
> the allnoconfig build errors.
Please also fold in my patch "ia64: select CONFIG_TTY for use of
tty_write_message in unaligned". (Just bounced you a copy.)
There's an s390 issue as well which needs the same fix (make the
top-level architecture symbol select TTY).
I'll look at the other issues tonight.
- Josh Triplett
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the final tree (akpm-current tree related)
On Thu, 27 Feb 2014 10:00:26 +1100 Stephen Rothwell
wrote:
> Hi Josh,
>
> On Wed, 26 Feb 2014 02:02:34 -0800 Josh Triplett
> wrote:
> >
> > On Wed, Feb 26, 2014 at 07:16:27PM +1100, Stephen Rothwell wrote:
> > >
> > > After merging the final tree, today's linux-next build (powerpc64
> > > allnoconfig) failed like this:
> > >
> > > arch/powerpc/kernel/built-in.o: In function `.machine_check_queue_event':
> > > (.text+0x11260): undefined reference to `.irq_work_queue'
> > >
> > > Caused (or exposed) (along with a lot of warnings) by commit 3dd6115cd60b
> > > ("kconfig: make allnoconfig disable options behind EMBEDDED and EXPERT")
> > > from the apm-current tree.
> >
> > Pre-existing, just now triggerable with just "make allnoconfig" rather
> > than manually turning off other options (like PRINTK) that select
> > IRQ_WORK. (One of the goals of that commit: get those options more
> > widely used and build-tested.)
> >
> > The following (untested) patch *should* fix this:
> > - 8< -
> > From 36a5b6c87292b6c5eeb390ed6dc6acbb8f0a3767 Mon Sep 17 00:00:00 2001
> > From: Josh Triplett
> > Date: Wed, 26 Feb 2014 01:58:02 -0800
> > Subject: [PATCH] ppc: Make PPC_BOOK3S_64 select IRQ_WORK
>
> OK, I added this as a merge fix patch for Andrew's tree today. Please
> check the build results overnight tonight (for next-20140227 at
> http://kisskb.ellerman.id.au/linux-next) and submit any more fixes for
> the allnoconfig build errors.
yes, let's keep
kconfig-make-allnoconfig-disable-options-behind-embedded-and-expert,
please. We'll just need to slog our way through the breakage which it
exposes.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the final tree (akpm-current tree related)
Hi Josh,
On Wed, 26 Feb 2014 02:02:34 -0800 Josh Triplett wrote:
>
> On Wed, Feb 26, 2014 at 07:16:27PM +1100, Stephen Rothwell wrote:
> >
> > After merging the final tree, today's linux-next build (powerpc64
> > allnoconfig) failed like this:
> >
> > arch/powerpc/kernel/built-in.o: In function `.machine_check_queue_event':
> > (.text+0x11260): undefined reference to `.irq_work_queue'
> >
> > Caused (or exposed) (along with a lot of warnings) by commit 3dd6115cd60b
> > ("kconfig: make allnoconfig disable options behind EMBEDDED and EXPERT")
> > from the apm-current tree.
>
> Pre-existing, just now triggerable with just "make allnoconfig" rather
> than manually turning off other options (like PRINTK) that select
> IRQ_WORK. (One of the goals of that commit: get those options more
> widely used and build-tested.)
>
> The following (untested) patch *should* fix this:
> - 8< -
> From 36a5b6c87292b6c5eeb390ed6dc6acbb8f0a3767 Mon Sep 17 00:00:00 2001
> From: Josh Triplett
> Date: Wed, 26 Feb 2014 01:58:02 -0800
> Subject: [PATCH] ppc: Make PPC_BOOK3S_64 select IRQ_WORK
OK, I added this as a merge fix patch for Andrew's tree today. Please
check the build results overnight tonight (for next-20140227 at
http://kisskb.ellerman.id.au/linux-next) and submit any more fixes for
the allnoconfig build errors.
--
Cheers,
Stephen Rothwells...@canb.auug.org.au
pgpJ3LfRFeHFI.pgp
Description: PGP signature
Re: linux-next: build failure after merge of the final tree (akpm-current tree related)
On Wed, Feb 26, 2014 at 07:16:27PM +1100, Stephen Rothwell wrote:
> Hi all,
>
> After merging the final tree, today's linux-next build (powerpc64
> allnoconfig) failed like this:
>
> arch/powerpc/kernel/built-in.o: In function `.machine_check_queue_event':
> (.text+0x11260): undefined reference to `.irq_work_queue'
>
> Caused (or exposed) (along with a lot of warnings) by commit 3dd6115cd60b
> ("kconfig: make allnoconfig disable options behind EMBEDDED and EXPERT")
> from the apm-current tree.
Pre-existing, just now triggerable with just "make allnoconfig" rather
than manually turning off other options (like PRINTK) that select
IRQ_WORK. (One of the goals of that commit: get those options more
widely used and build-tested.)
The following (untested) patch *should* fix this:
- 8< -
>From 36a5b6c87292b6c5eeb390ed6dc6acbb8f0a3767 Mon Sep 17 00:00:00 2001
From: Josh Triplett
Date: Wed, 26 Feb 2014 01:58:02 -0800
Subject: [PATCH] ppc: Make PPC_BOOK3S_64 select IRQ_WORK
arch/powerpc/kernel/mce.c, compiled in for PPC_BOOK3S_64, calls
functions only built when IRQ_WORK, so select it. Fixes the following
build error:
arch/powerpc/kernel/built-in.o: In function `.machine_check_queue_event':
(.text+0x11260): undefined reference to `.irq_work_queue'
Reported-by: Stephen Rothwell
Signed-off-by: Josh Triplett
---
arch/powerpc/platforms/Kconfig.cputype | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/powerpc/platforms/Kconfig.cputype
b/arch/powerpc/platforms/Kconfig.cputype
index 434fda3..d9e2b19 100644
--- a/arch/powerpc/platforms/Kconfig.cputype
+++ b/arch/powerpc/platforms/Kconfig.cputype
@@ -73,6 +73,7 @@ config PPC_BOOK3S_64
select SYS_SUPPORTS_HUGETLBFS
select HAVE_ARCH_TRANSPARENT_HUGEPAGE if PPC_64K_PAGES
select ARCH_SUPPORTS_NUMA_BALANCING
+ select IRQ_WORK
config PPC_BOOK3E_64
bool "Embedded processors"
--
1.9.0
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
linux-next: build failure after merge of the final tree (akpm-current tree related)
Hi all,
After merging the final tree, today's linux-next build (powerpc64
allnoconfig) failed like this:
arch/powerpc/kernel/built-in.o: In function `.machine_check_queue_event':
(.text+0x11260): undefined reference to `.irq_work_queue'
Caused (or exposed) (along with a lot of warnings) by commit 3dd6115cd60b
("kconfig: make allnoconfig disable options behind EMBEDDED and EXPERT")
from the apm-current tree.
I have reverted that commit for today.
--
Cheers,
Stephen Rothwells...@canb.auug.org.au
pgpUrLJVYrcMb.pgp
Description: PGP signature
linux-next: build failure after merge of the final tree (akpm-current tree related)
Hi all, After merging the final tree, today's linux-next build (powerpc64 allnoconfig) failed like this: arch/powerpc/kernel/built-in.o: In function `.machine_check_queue_event': (.text+0x11260): undefined reference to `.irq_work_queue' Caused (or exposed) (along with a lot of warnings) by commit 3dd6115cd60b (kconfig: make allnoconfig disable options behind EMBEDDED and EXPERT) from the apm-current tree. I have reverted that commit for today. -- Cheers, Stephen Rothwells...@canb.auug.org.au pgpUrLJVYrcMb.pgp Description: PGP signature
Re: linux-next: build failure after merge of the final tree (akpm-current tree related)
On Wed, Feb 26, 2014 at 07:16:27PM +1100, Stephen Rothwell wrote: Hi all, After merging the final tree, today's linux-next build (powerpc64 allnoconfig) failed like this: arch/powerpc/kernel/built-in.o: In function `.machine_check_queue_event': (.text+0x11260): undefined reference to `.irq_work_queue' Caused (or exposed) (along with a lot of warnings) by commit 3dd6115cd60b (kconfig: make allnoconfig disable options behind EMBEDDED and EXPERT) from the apm-current tree. Pre-existing, just now triggerable with just make allnoconfig rather than manually turning off other options (like PRINTK) that select IRQ_WORK. (One of the goals of that commit: get those options more widely used and build-tested.) The following (untested) patch *should* fix this: - 8 - From 36a5b6c87292b6c5eeb390ed6dc6acbb8f0a3767 Mon Sep 17 00:00:00 2001 From: Josh Triplett j...@joshtriplett.org Date: Wed, 26 Feb 2014 01:58:02 -0800 Subject: [PATCH] ppc: Make PPC_BOOK3S_64 select IRQ_WORK arch/powerpc/kernel/mce.c, compiled in for PPC_BOOK3S_64, calls functions only built when IRQ_WORK, so select it. Fixes the following build error: arch/powerpc/kernel/built-in.o: In function `.machine_check_queue_event': (.text+0x11260): undefined reference to `.irq_work_queue' Reported-by: Stephen Rothwell s...@canb.auug.org.au Signed-off-by: Josh Triplett j...@joshtriplett.org --- arch/powerpc/platforms/Kconfig.cputype | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/powerpc/platforms/Kconfig.cputype b/arch/powerpc/platforms/Kconfig.cputype index 434fda3..d9e2b19 100644 --- a/arch/powerpc/platforms/Kconfig.cputype +++ b/arch/powerpc/platforms/Kconfig.cputype @@ -73,6 +73,7 @@ config PPC_BOOK3S_64 select SYS_SUPPORTS_HUGETLBFS select HAVE_ARCH_TRANSPARENT_HUGEPAGE if PPC_64K_PAGES select ARCH_SUPPORTS_NUMA_BALANCING + select IRQ_WORK config PPC_BOOK3E_64 bool Embedded processors -- 1.9.0 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the final tree (akpm-current tree related)
Hi Josh, On Wed, 26 Feb 2014 02:02:34 -0800 Josh Triplett j...@joshtriplett.org wrote: On Wed, Feb 26, 2014 at 07:16:27PM +1100, Stephen Rothwell wrote: After merging the final tree, today's linux-next build (powerpc64 allnoconfig) failed like this: arch/powerpc/kernel/built-in.o: In function `.machine_check_queue_event': (.text+0x11260): undefined reference to `.irq_work_queue' Caused (or exposed) (along with a lot of warnings) by commit 3dd6115cd60b (kconfig: make allnoconfig disable options behind EMBEDDED and EXPERT) from the apm-current tree. Pre-existing, just now triggerable with just make allnoconfig rather than manually turning off other options (like PRINTK) that select IRQ_WORK. (One of the goals of that commit: get those options more widely used and build-tested.) The following (untested) patch *should* fix this: - 8 - From 36a5b6c87292b6c5eeb390ed6dc6acbb8f0a3767 Mon Sep 17 00:00:00 2001 From: Josh Triplett j...@joshtriplett.org Date: Wed, 26 Feb 2014 01:58:02 -0800 Subject: [PATCH] ppc: Make PPC_BOOK3S_64 select IRQ_WORK OK, I added this as a merge fix patch for Andrew's tree today. Please check the build results overnight tonight (for next-20140227 at http://kisskb.ellerman.id.au/linux-next) and submit any more fixes for the allnoconfig build errors. -- Cheers, Stephen Rothwells...@canb.auug.org.au pgpJ3LfRFeHFI.pgp Description: PGP signature
Re: linux-next: build failure after merge of the final tree (akpm-current tree related)
On Thu, 27 Feb 2014 10:00:26 +1100 Stephen Rothwell s...@canb.auug.org.au wrote: Hi Josh, On Wed, 26 Feb 2014 02:02:34 -0800 Josh Triplett j...@joshtriplett.org wrote: On Wed, Feb 26, 2014 at 07:16:27PM +1100, Stephen Rothwell wrote: After merging the final tree, today's linux-next build (powerpc64 allnoconfig) failed like this: arch/powerpc/kernel/built-in.o: In function `.machine_check_queue_event': (.text+0x11260): undefined reference to `.irq_work_queue' Caused (or exposed) (along with a lot of warnings) by commit 3dd6115cd60b (kconfig: make allnoconfig disable options behind EMBEDDED and EXPERT) from the apm-current tree. Pre-existing, just now triggerable with just make allnoconfig rather than manually turning off other options (like PRINTK) that select IRQ_WORK. (One of the goals of that commit: get those options more widely used and build-tested.) The following (untested) patch *should* fix this: - 8 - From 36a5b6c87292b6c5eeb390ed6dc6acbb8f0a3767 Mon Sep 17 00:00:00 2001 From: Josh Triplett j...@joshtriplett.org Date: Wed, 26 Feb 2014 01:58:02 -0800 Subject: [PATCH] ppc: Make PPC_BOOK3S_64 select IRQ_WORK OK, I added this as a merge fix patch for Andrew's tree today. Please check the build results overnight tonight (for next-20140227 at http://kisskb.ellerman.id.au/linux-next) and submit any more fixes for the allnoconfig build errors. yes, let's keep kconfig-make-allnoconfig-disable-options-behind-embedded-and-expert, please. We'll just need to slog our way through the breakage which it exposes. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the final tree (akpm-current tree related)
On Thu, Feb 27, 2014 at 10:00:26AM +1100, Stephen Rothwell wrote: Hi Josh, On Wed, 26 Feb 2014 02:02:34 -0800 Josh Triplett j...@joshtriplett.org wrote: On Wed, Feb 26, 2014 at 07:16:27PM +1100, Stephen Rothwell wrote: After merging the final tree, today's linux-next build (powerpc64 allnoconfig) failed like this: arch/powerpc/kernel/built-in.o: In function `.machine_check_queue_event': (.text+0x11260): undefined reference to `.irq_work_queue' Caused (or exposed) (along with a lot of warnings) by commit 3dd6115cd60b (kconfig: make allnoconfig disable options behind EMBEDDED and EXPERT) from the apm-current tree. Pre-existing, just now triggerable with just make allnoconfig rather than manually turning off other options (like PRINTK) that select IRQ_WORK. (One of the goals of that commit: get those options more widely used and build-tested.) The following (untested) patch *should* fix this: - 8 - From 36a5b6c87292b6c5eeb390ed6dc6acbb8f0a3767 Mon Sep 17 00:00:00 2001 From: Josh Triplett j...@joshtriplett.org Date: Wed, 26 Feb 2014 01:58:02 -0800 Subject: [PATCH] ppc: Make PPC_BOOK3S_64 select IRQ_WORK OK, I added this as a merge fix patch for Andrew's tree today. Please check the build results overnight tonight (for next-20140227 at http://kisskb.ellerman.id.au/linux-next) and submit any more fixes for the allnoconfig build errors. Please also fold in my patch ia64: select CONFIG_TTY for use of tty_write_message in unaligned. (Just bounced you a copy.) There's an s390 issue as well which needs the same fix (make the top-level architecture symbol select TTY). I'll look at the other issues tonight. - Josh Triplett -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the final tree (akpm-current tree related)
Hi Josh, On Wed, 26 Feb 2014 15:19:16 -0800 Josh Triplett j...@joshtriplett.org wrote: Please also fold in my patch ia64: select CONFIG_TTY for use of tty_write_message in unaligned. (Just bounced you a copy.) Done. There's an s390 issue as well which needs the same fix (make the top-level architecture symbol select TTY). I'll look at the other issues tonight. OK, thanks. -- Cheers, Stephen Rothwells...@canb.auug.org.au pgpLl4Mp2ZBkn.pgp Description: PGP signature
Re: linux-next: build failure after merge of the final tree (akpm-current tree related)
On Thu, Feb 27, 2014 at 10:00:26AM +1100, Stephen Rothwell wrote: Please check the build results overnight tonight (for next-20140227 at http://kisskb.ellerman.id.au/linux-next) and submit any more fixes for the allnoconfig build errors. Checking that site, I don't see any other instances of failures caused by allnoconfig. If I'm missing some, could you please point me to the page on that site I'm missing? - Josh Triplett -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the final tree (akpm-current tree related)
Hi Josh, On Wed, 26 Feb 2014 18:21:29 -0800 Josh Triplett j...@joshtriplett.org wrote: On Thu, Feb 27, 2014 at 10:00:26AM +1100, Stephen Rothwell wrote: Please check the build results overnight tonight (for next-20140227 at http://kisskb.ellerman.id.au/linux-next) and submit any more fixes for the allnoconfig build errors. Checking that site, I don't see any other instances of failures caused by allnoconfig. If I'm missing some, could you please point me to the page on that site I'm missing? That is because your patch was reverted in yesterday's (next-20140226) linux-next. You will need to look tomorrow (next-20140227) sometime. -- Cheers, Stephen Rothwells...@canb.auug.org.au pgp9XrqaUaXyo.pgp Description: PGP signature
linux-next: build failure after merge of the final tree (sound-asoc tree related)
Hi all,
After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:
sound/soc/intel/sst-dsp.c: In function 'sst_dsp_outbox_write':
sound/soc/intel/sst-dsp.c:218:2: error: implicit declaration of function
'memcpy_toio' [-Werror=implicit-function-declaration]
memcpy_toio(sst->mailbox.out_base, message, bytes);
^
sound/soc/intel/sst-dsp.c: In function 'sst_dsp_outbox_read':
sound/soc/intel/sst-dsp.c:231:2: error: implicit declaration of function
'memcpy_fromio' [-Werror=implicit-function-declaration]
memcpy_fromio(message, sst->mailbox.out_base, bytes);
^
Caused by commit 790aff62291e ("ASoC: Intel: Add Intel SST audio DSP low
level shim driver") from the sound-asoc tree.
I have disabled this new driver by reverting commit ddfa40b1586f ("ASoC:
Intel: Add build support for Intel SST DSP core") for today.
--
Cheers,
Stephen Rothwells...@canb.auug.org.au
pgpDtRddmmKP7.pgp
Description: PGP signature
linux-next: build failure after merge of the final tree (sound-asoc tree related)
Hi all, After merging the final tree, today's linux-next build (powerpc allyesconfig) failed like this: sound/soc/intel/sst-dsp.c: In function 'sst_dsp_outbox_write': sound/soc/intel/sst-dsp.c:218:2: error: implicit declaration of function 'memcpy_toio' [-Werror=implicit-function-declaration] memcpy_toio(sst-mailbox.out_base, message, bytes); ^ sound/soc/intel/sst-dsp.c: In function 'sst_dsp_outbox_read': sound/soc/intel/sst-dsp.c:231:2: error: implicit declaration of function 'memcpy_fromio' [-Werror=implicit-function-declaration] memcpy_fromio(message, sst-mailbox.out_base, bytes); ^ Caused by commit 790aff62291e (ASoC: Intel: Add Intel SST audio DSP low level shim driver) from the sound-asoc tree. I have disabled this new driver by reverting commit ddfa40b1586f (ASoC: Intel: Add build support for Intel SST DSP core) for today. -- Cheers, Stephen Rothwells...@canb.auug.org.au pgpDtRddmmKP7.pgp Description: PGP signature
Re: linux-next: build failure after merge of the final tree (cgroup tree related)
On Wed, Feb 12, 2014 at 04:25:00PM +1100, Stephen Rothwell wrote:
> Hi all,
>
> After merging the final tree, today's linux-next build (sparc defconfig)
> failed like this:
>
> arch/sparc/kernel/sun4m_irq.c: In function 'sun4m_build_device_irq':
> arch/sparc/kernel/sun4m_irq.c:266:2: error: implicit declaration of function
> 'kzalloc' [-Werror=implicit-function-declaration]
> arch/sparc/kernel/sun4m_irq.c:266:15: error: assignment makes pointer from
> integer without a cast [-Werror]
>
> Presumably caused by commit 2bd59d48ebfb ("cgroup: convert to kernfs")
> (see the comment in commit 1ff6bbfd13ca ("arm, pm, vmpressure: add
> missing slab.h includes")). I wonder how mane more builds are broken by
> this :-(
>
> Indeed, reverting that commit fixes the build.
>
> I have added the following build fix for today (please check the
> overnight builds for more breakage):
>
> From: Stephen Rothwell
> Date: Wed, 12 Feb 2014 16:01:10 +1100
> Subject: [PATCH] sun4M: add include of slab.h for kzalloc
>
> This was being included implicitly via cgroup.h's inclusion of xattr.h
> (which has now been removed).
>
> Signed-off-by: Stephen Rothwell
Applied to cgroup/for-3.15.
Thanks!
--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the final tree (cgroup tree related)
Hi Tejun.
On Wed, Feb 12, 2014 at 09:27:00AM -0500, Tejun Heo wrote:
> On Wed, Feb 12, 2014 at 09:47:43PM +1100, Stephen Rothwell wrote:
> > Hi, Tejun,
> >
> > On Wed, 12 Feb 2014 01:39:33 -0500 Tejun Heo wrote:
> > >
> > > On Wed, Feb 12, 2014 at 04:25:00PM +1100, Stephen Rothwell wrote:
> > > > Presumably caused by commit 2bd59d48ebfb ("cgroup: convert to kernfs")
> > > > (see the comment in commit 1ff6bbfd13ca ("arm, pm, vmpressure: add
> > > > missing slab.h includes")). I wonder how mane more builds are broken by
> > > > this :-(
> > >
> > > Dang, I was feeling pretty safe as kbuild bot was reporting build
> > > successes. We better fix them at any rate. David / Sam, can you
> > > please pick this one up?
> >
> > It really needs to go into the tree with the cgroup commit so it doesn't
> > break there.
>
> Hmmm... I see. I'll route the patch once Dave or Sam acks it.
My sparc setup is broken for many reasons - so I have not been able to try it
out.
But the patch is obvious enough that I do not hesitate to do:
Acked-by: Sam Ravnborg
Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the final tree (cgroup tree related)
On Wed, Feb 12, 2014 at 09:47:43PM +1100, Stephen Rothwell wrote:
> Hi, Tejun,
>
> On Wed, 12 Feb 2014 01:39:33 -0500 Tejun Heo wrote:
> >
> > On Wed, Feb 12, 2014 at 04:25:00PM +1100, Stephen Rothwell wrote:
> > > Presumably caused by commit 2bd59d48ebfb ("cgroup: convert to kernfs")
> > > (see the comment in commit 1ff6bbfd13ca ("arm, pm, vmpressure: add
> > > missing slab.h includes")). I wonder how mane more builds are broken by
> > > this :-(
> >
> > Dang, I was feeling pretty safe as kbuild bot was reporting build
> > successes. We better fix them at any rate. David / Sam, can you
> > please pick this one up?
>
> It really needs to go into the tree with the cgroup commit so it doesn't
> break there.
Hmmm... I see. I'll route the patch once Dave or Sam acks it.
Thanks!
--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the final tree (cgroup tree related)
Hi, Tejun,
On Wed, 12 Feb 2014 01:39:33 -0500 Tejun Heo wrote:
>
> On Wed, Feb 12, 2014 at 04:25:00PM +1100, Stephen Rothwell wrote:
> > Presumably caused by commit 2bd59d48ebfb ("cgroup: convert to kernfs")
> > (see the comment in commit 1ff6bbfd13ca ("arm, pm, vmpressure: add
> > missing slab.h includes")). I wonder how mane more builds are broken by
> > this :-(
>
> Dang, I was feeling pretty safe as kbuild bot was reporting build
> successes. We better fix them at any rate. David / Sam, can you
> please pick this one up?
It really needs to go into the tree with the cgroup commit so it doesn't
break there.
--
Cheers,
Stephen Rothwells...@canb.auug.org.au
pgpSndVZYnSGr.pgp
Description: PGP signature
Re: linux-next: build failure after merge of the final tree (cgroup tree related)
Hi, Tejun, On Wed, 12 Feb 2014 01:39:33 -0500 Tejun Heo t...@kernel.org wrote: On Wed, Feb 12, 2014 at 04:25:00PM +1100, Stephen Rothwell wrote: Presumably caused by commit 2bd59d48ebfb (cgroup: convert to kernfs) (see the comment in commit 1ff6bbfd13ca (arm, pm, vmpressure: add missing slab.h includes)). I wonder how mane more builds are broken by this :-( Dang, I was feeling pretty safe as kbuild bot was reporting build successes. We better fix them at any rate. David / Sam, can you please pick this one up? It really needs to go into the tree with the cgroup commit so it doesn't break there. -- Cheers, Stephen Rothwells...@canb.auug.org.au pgpSndVZYnSGr.pgp Description: PGP signature
Re: linux-next: build failure after merge of the final tree (cgroup tree related)
On Wed, Feb 12, 2014 at 09:47:43PM +1100, Stephen Rothwell wrote: Hi, Tejun, On Wed, 12 Feb 2014 01:39:33 -0500 Tejun Heo t...@kernel.org wrote: On Wed, Feb 12, 2014 at 04:25:00PM +1100, Stephen Rothwell wrote: Presumably caused by commit 2bd59d48ebfb (cgroup: convert to kernfs) (see the comment in commit 1ff6bbfd13ca (arm, pm, vmpressure: add missing slab.h includes)). I wonder how mane more builds are broken by this :-( Dang, I was feeling pretty safe as kbuild bot was reporting build successes. We better fix them at any rate. David / Sam, can you please pick this one up? It really needs to go into the tree with the cgroup commit so it doesn't break there. Hmmm... I see. I'll route the patch once Dave or Sam acks it. Thanks! -- tejun -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the final tree (cgroup tree related)
Hi Tejun. On Wed, Feb 12, 2014 at 09:27:00AM -0500, Tejun Heo wrote: On Wed, Feb 12, 2014 at 09:47:43PM +1100, Stephen Rothwell wrote: Hi, Tejun, On Wed, 12 Feb 2014 01:39:33 -0500 Tejun Heo t...@kernel.org wrote: On Wed, Feb 12, 2014 at 04:25:00PM +1100, Stephen Rothwell wrote: Presumably caused by commit 2bd59d48ebfb (cgroup: convert to kernfs) (see the comment in commit 1ff6bbfd13ca (arm, pm, vmpressure: add missing slab.h includes)). I wonder how mane more builds are broken by this :-( Dang, I was feeling pretty safe as kbuild bot was reporting build successes. We better fix them at any rate. David / Sam, can you please pick this one up? It really needs to go into the tree with the cgroup commit so it doesn't break there. Hmmm... I see. I'll route the patch once Dave or Sam acks it. My sparc setup is broken for many reasons - so I have not been able to try it out. But the patch is obvious enough that I do not hesitate to do: Acked-by: Sam Ravnborg s...@ravnborg.org Sam -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the final tree (cgroup tree related)
On Wed, Feb 12, 2014 at 04:25:00PM +1100, Stephen Rothwell wrote: Hi all, After merging the final tree, today's linux-next build (sparc defconfig) failed like this: arch/sparc/kernel/sun4m_irq.c: In function 'sun4m_build_device_irq': arch/sparc/kernel/sun4m_irq.c:266:2: error: implicit declaration of function 'kzalloc' [-Werror=implicit-function-declaration] arch/sparc/kernel/sun4m_irq.c:266:15: error: assignment makes pointer from integer without a cast [-Werror] Presumably caused by commit 2bd59d48ebfb (cgroup: convert to kernfs) (see the comment in commit 1ff6bbfd13ca (arm, pm, vmpressure: add missing slab.h includes)). I wonder how mane more builds are broken by this :-( Indeed, reverting that commit fixes the build. I have added the following build fix for today (please check the overnight builds for more breakage): From: Stephen Rothwell s...@canb.auug.org.au Date: Wed, 12 Feb 2014 16:01:10 +1100 Subject: [PATCH] sun4M: add include of slab.h for kzalloc This was being included implicitly via cgroup.h's inclusion of xattr.h (which has now been removed). Signed-off-by: Stephen Rothwell s...@canb.auug.org.au Applied to cgroup/for-3.15. Thanks! -- tejun -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the final tree (cgroup tree related)
Hello,
On Wed, Feb 12, 2014 at 04:25:00PM +1100, Stephen Rothwell wrote:
> Presumably caused by commit 2bd59d48ebfb ("cgroup: convert to kernfs")
> (see the comment in commit 1ff6bbfd13ca ("arm, pm, vmpressure: add
> missing slab.h includes")). I wonder how mane more builds are broken by
> this :-(
Dang, I was feeling pretty safe as kbuild bot was reporting build
successes. We better fix them at any rate. David / Sam, can you
please pick this one up?
Thanks.
--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
linux-next: build failure after merge of the final tree (cgroup tree related)
Hi all,
After merging the final tree, today's linux-next build (sparc defconfig)
failed like this:
arch/sparc/kernel/sun4m_irq.c: In function 'sun4m_build_device_irq':
arch/sparc/kernel/sun4m_irq.c:266:2: error: implicit declaration of function
'kzalloc' [-Werror=implicit-function-declaration]
arch/sparc/kernel/sun4m_irq.c:266:15: error: assignment makes pointer from
integer without a cast [-Werror]
Presumably caused by commit 2bd59d48ebfb ("cgroup: convert to kernfs")
(see the comment in commit 1ff6bbfd13ca ("arm, pm, vmpressure: add
missing slab.h includes")). I wonder how mane more builds are broken by
this :-(
Indeed, reverting that commit fixes the build.
I have added the following build fix for today (please check the
overnight builds for more breakage):
From: Stephen Rothwell
Date: Wed, 12 Feb 2014 16:01:10 +1100
Subject: [PATCH] sun4M: add include of slab.h for kzalloc
This was being included implicitly via cgroup.h's inclusion of xattr.h
(which has now been removed).
Signed-off-by: Stephen Rothwell
---
arch/sparc/kernel/sun4m_irq.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/sparc/kernel/sun4m_irq.c b/arch/sparc/kernel/sun4m_irq.c
index c5ade9d27a1d..8bb3b3fddea7 100644
--- a/arch/sparc/kernel/sun4m_irq.c
+++ b/arch/sparc/kernel/sun4m_irq.c
@@ -9,6 +9,8 @@
* Copyright (C) 1996 Dave Redman (d...@tadpole.co.uk)
*/
+#include
+
#include
#include
#include
--
1.9.rc1
--
Cheers,
Stephen Rothwells...@canb.auug.org.au
pgp95NMjnbP2W.pgp
Description: PGP signature
linux-next: build failure after merge of the final tree (cgroup tree related)
Hi all, After merging the final tree, today's linux-next build (sparc defconfig) failed like this: arch/sparc/kernel/sun4m_irq.c: In function 'sun4m_build_device_irq': arch/sparc/kernel/sun4m_irq.c:266:2: error: implicit declaration of function 'kzalloc' [-Werror=implicit-function-declaration] arch/sparc/kernel/sun4m_irq.c:266:15: error: assignment makes pointer from integer without a cast [-Werror] Presumably caused by commit 2bd59d48ebfb (cgroup: convert to kernfs) (see the comment in commit 1ff6bbfd13ca (arm, pm, vmpressure: add missing slab.h includes)). I wonder how mane more builds are broken by this :-( Indeed, reverting that commit fixes the build. I have added the following build fix for today (please check the overnight builds for more breakage): From: Stephen Rothwell s...@canb.auug.org.au Date: Wed, 12 Feb 2014 16:01:10 +1100 Subject: [PATCH] sun4M: add include of slab.h for kzalloc This was being included implicitly via cgroup.h's inclusion of xattr.h (which has now been removed). Signed-off-by: Stephen Rothwell s...@canb.auug.org.au --- arch/sparc/kernel/sun4m_irq.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/sparc/kernel/sun4m_irq.c b/arch/sparc/kernel/sun4m_irq.c index c5ade9d27a1d..8bb3b3fddea7 100644 --- a/arch/sparc/kernel/sun4m_irq.c +++ b/arch/sparc/kernel/sun4m_irq.c @@ -9,6 +9,8 @@ * Copyright (C) 1996 Dave Redman (d...@tadpole.co.uk) */ +#include linux/slab.h + #include asm/timer.h #include asm/traps.h #include asm/pgalloc.h -- 1.9.rc1 -- Cheers, Stephen Rothwells...@canb.auug.org.au pgp95NMjnbP2W.pgp Description: PGP signature
Re: linux-next: build failure after merge of the final tree (cgroup tree related)
Hello, On Wed, Feb 12, 2014 at 04:25:00PM +1100, Stephen Rothwell wrote: Presumably caused by commit 2bd59d48ebfb (cgroup: convert to kernfs) (see the comment in commit 1ff6bbfd13ca (arm, pm, vmpressure: add missing slab.h includes)). I wonder how mane more builds are broken by this :-( Dang, I was feeling pretty safe as kbuild bot was reporting build successes. We better fix them at any rate. David / Sam, can you please pick this one up? Thanks. -- tejun -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the final tree (staging tree related)
On Mon, Feb 10, 2014 at 03:54:12PM +1100, Stephen Rothwell wrote: > Hi all, > > After merging the final tree, today's linux-next build (powerpc > allyesconfig) failed like this: > > drivers/staging/rtl8188eu/core/rtw_mlme.c: In function '_rtw_init_mlme_priv': > drivers/staging/rtl8188eu/core/rtw_mlme.c:65:2: error: implicit declaration > of function 'vzalloc' [-Werror=implicit-function-declaration] > pbuf = vzalloc(MAX_BSS_CNT * (sizeof(struct wlan_network))); > ^ Sorry about that. Larry sent me a patch for this Friday evening and I haven't had the chance to add it to my tree just yet. Sorry for the noise. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
linux-next: build failure after merge of the final tree (staging tree related)
Hi all, After merging the final tree, today's linux-next build (powerpc allyesconfig) failed like this: drivers/staging/rtl8188eu/core/rtw_mlme.c: In function '_rtw_init_mlme_priv': drivers/staging/rtl8188eu/core/rtw_mlme.c:65:2: error: implicit declaration of function 'vzalloc' [-Werror=implicit-function-declaration] pbuf = vzalloc(MAX_BSS_CNT * (sizeof(struct wlan_network))); ^ drivers/staging/rtl8188eu/core/rtw_mlme.c:65:7: warning: assignment makes pointer from integer without a cast [enabled by default] pbuf = vzalloc(MAX_BSS_CNT * (sizeof(struct wlan_network))); ^ drivers/staging/rtl8188eu/core/rtw_mlme.c: In function '_rtw_free_mlme_priv': drivers/staging/rtl8188eu/core/rtw_mlme.c:133:4: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration] vfree(pmlmepriv->free_bss_buf); ^ drivers/staging/rtl8188eu/core/rtw_mp.c: In function '_rtw_mp_xmit_priv': drivers/staging/rtl8188eu/core/rtw_mp.c:946:3: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration] vfree(pxmitpriv->pallocated_xmit_extbuf); ^ drivers/staging/rtl8188eu/core/rtw_mp.c:959:2: error: implicit declaration of function 'vzalloc' [-Werror=implicit-function-declaration] pxmitpriv->pallocated_xmit_extbuf = vzalloc(num_xmit_extbuf * sizeof(struct xmit_buf) + 4); ^ drivers/staging/rtl8188eu/core/rtw_mp.c:959:36: warning: assignment makes pointer from integer without a cast [enabled by default] pxmitpriv->pallocated_xmit_extbuf = vzalloc(num_xmit_extbuf * sizeof(struct xmit_buf) + 4); ^ drivers/staging/rtl8188eu/core/rtw_recv.c: In function '_rtw_init_recv_priv': drivers/staging/rtl8188eu/core/rtw_recv.c:80:2: error: implicit declaration of function 'vzalloc' [-Werror=implicit-function-declaration] precvpriv->pallocated_frame_buf = vzalloc(NR_RECVFRAME * sizeof(union recv_frame) + RXFRAME_ALIGN_SZ); ^ drivers/staging/rtl8188eu/core/rtw_recv.c:80:34: warning: assignment makes pointer from integer without a cast [enabled by default] precvpriv->pallocated_frame_buf = vzalloc(NR_RECVFRAME * sizeof(union recv_frame) + RXFRAME_ALIGN_SZ); ^ drivers/staging/rtl8188eu/core/rtw_recv.c: In function '_rtw_free_recv_priv': drivers/staging/rtl8188eu/core/rtw_recv.c:132:3: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration] vfree(precvpriv->pallocated_frame_buf); ^ drivers/staging/rtl8188eu/core/rtw_sta_mgt.c: In function '_rtw_init_sta_priv': drivers/staging/rtl8188eu/core/rtw_sta_mgt.c:82:2: error: implicit declaration of function 'vzalloc' [-Werror=implicit-function-declaration] pstapriv->pallocated_stainfo_buf = vzalloc(sizeof(struct sta_info) * NUM_STA + 4); ^ drivers/staging/rtl8188eu/core/rtw_sta_mgt.c:82:35: warning: assignment makes pointer from integer without a cast [enabled by default] pstapriv->pallocated_stainfo_buf = vzalloc(sizeof(struct sta_info) * NUM_STA + 4); ^ drivers/staging/rtl8188eu/core/rtw_sta_mgt.c: In function '_rtw_free_sta_priv': drivers/staging/rtl8188eu/core/rtw_sta_mgt.c:211:4: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration] vfree(pstapriv->pallocated_stainfo_buf); ^ drivers/staging/rtl8188eu/core/rtw_xmit.c: In function '_rtw_init_xmit_priv': drivers/staging/rtl8188eu/core/rtw_xmit.c:94:2: error: implicit declaration of function 'vzalloc' [-Werror=implicit-function-declaration] pxmitpriv->pallocated_frame_buf = vzalloc(NR_XMITFRAME * sizeof(struct xmit_frame) + 4); ^ drivers/staging/rtl8188eu/core/rtw_xmit.c:94:34: warning: assignment makes pointer from integer without a cast [enabled by default] pxmitpriv->pallocated_frame_buf = vzalloc(NR_XMITFRAME * sizeof(struct xmit_frame) + 4); ^ drivers/staging/rtl8188eu/core/rtw_xmit.c:132:32: warning: assignment makes pointer from integer without a cast [enabled by default] pxmitpriv->pallocated_xmitbuf = vzalloc(NR_XMITBUFF * sizeof(struct xmit_buf) + 4); ^ drivers/staging/rtl8188eu/core/rtw_xmit.c:174:36: warning: assignment makes pointer from integer without a cast [enabled by default] pxmitpriv->pallocated_xmit_extbuf = vzalloc(num_xmit_extbuf * sizeof(struct xmit_buf) + 4); ^ drivers/staging/rtl8188eu/core/rtw_xmit.c: In function '_rtw_free_xmit_priv': drivers/staging/rtl8188eu/core/rtw_xmit.c:262:3: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration] vfree(pxmitpriv->pallocated_frame_buf); ^ drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c: In function 'rtw_IOL_cmd_tx_pkt_buf_dump': drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c:368:2: error: implicit declaration of function 'vzalloc' [-Werror=implicit-function-declaration] u8 *pbuf = vzalloc(data_len+10); ^
linux-next: build failure after merge of the final tree (staging tree related)
Hi all, After merging the final tree, today's linux-next build (powerpc allyesconfig) failed like this: drivers/staging/rtl8188eu/core/rtw_mlme.c: In function '_rtw_init_mlme_priv': drivers/staging/rtl8188eu/core/rtw_mlme.c:65:2: error: implicit declaration of function 'vzalloc' [-Werror=implicit-function-declaration] pbuf = vzalloc(MAX_BSS_CNT * (sizeof(struct wlan_network))); ^ drivers/staging/rtl8188eu/core/rtw_mlme.c:65:7: warning: assignment makes pointer from integer without a cast [enabled by default] pbuf = vzalloc(MAX_BSS_CNT * (sizeof(struct wlan_network))); ^ drivers/staging/rtl8188eu/core/rtw_mlme.c: In function '_rtw_free_mlme_priv': drivers/staging/rtl8188eu/core/rtw_mlme.c:133:4: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration] vfree(pmlmepriv-free_bss_buf); ^ drivers/staging/rtl8188eu/core/rtw_mp.c: In function '_rtw_mp_xmit_priv': drivers/staging/rtl8188eu/core/rtw_mp.c:946:3: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration] vfree(pxmitpriv-pallocated_xmit_extbuf); ^ drivers/staging/rtl8188eu/core/rtw_mp.c:959:2: error: implicit declaration of function 'vzalloc' [-Werror=implicit-function-declaration] pxmitpriv-pallocated_xmit_extbuf = vzalloc(num_xmit_extbuf * sizeof(struct xmit_buf) + 4); ^ drivers/staging/rtl8188eu/core/rtw_mp.c:959:36: warning: assignment makes pointer from integer without a cast [enabled by default] pxmitpriv-pallocated_xmit_extbuf = vzalloc(num_xmit_extbuf * sizeof(struct xmit_buf) + 4); ^ drivers/staging/rtl8188eu/core/rtw_recv.c: In function '_rtw_init_recv_priv': drivers/staging/rtl8188eu/core/rtw_recv.c:80:2: error: implicit declaration of function 'vzalloc' [-Werror=implicit-function-declaration] precvpriv-pallocated_frame_buf = vzalloc(NR_RECVFRAME * sizeof(union recv_frame) + RXFRAME_ALIGN_SZ); ^ drivers/staging/rtl8188eu/core/rtw_recv.c:80:34: warning: assignment makes pointer from integer without a cast [enabled by default] precvpriv-pallocated_frame_buf = vzalloc(NR_RECVFRAME * sizeof(union recv_frame) + RXFRAME_ALIGN_SZ); ^ drivers/staging/rtl8188eu/core/rtw_recv.c: In function '_rtw_free_recv_priv': drivers/staging/rtl8188eu/core/rtw_recv.c:132:3: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration] vfree(precvpriv-pallocated_frame_buf); ^ drivers/staging/rtl8188eu/core/rtw_sta_mgt.c: In function '_rtw_init_sta_priv': drivers/staging/rtl8188eu/core/rtw_sta_mgt.c:82:2: error: implicit declaration of function 'vzalloc' [-Werror=implicit-function-declaration] pstapriv-pallocated_stainfo_buf = vzalloc(sizeof(struct sta_info) * NUM_STA + 4); ^ drivers/staging/rtl8188eu/core/rtw_sta_mgt.c:82:35: warning: assignment makes pointer from integer without a cast [enabled by default] pstapriv-pallocated_stainfo_buf = vzalloc(sizeof(struct sta_info) * NUM_STA + 4); ^ drivers/staging/rtl8188eu/core/rtw_sta_mgt.c: In function '_rtw_free_sta_priv': drivers/staging/rtl8188eu/core/rtw_sta_mgt.c:211:4: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration] vfree(pstapriv-pallocated_stainfo_buf); ^ drivers/staging/rtl8188eu/core/rtw_xmit.c: In function '_rtw_init_xmit_priv': drivers/staging/rtl8188eu/core/rtw_xmit.c:94:2: error: implicit declaration of function 'vzalloc' [-Werror=implicit-function-declaration] pxmitpriv-pallocated_frame_buf = vzalloc(NR_XMITFRAME * sizeof(struct xmit_frame) + 4); ^ drivers/staging/rtl8188eu/core/rtw_xmit.c:94:34: warning: assignment makes pointer from integer without a cast [enabled by default] pxmitpriv-pallocated_frame_buf = vzalloc(NR_XMITFRAME * sizeof(struct xmit_frame) + 4); ^ drivers/staging/rtl8188eu/core/rtw_xmit.c:132:32: warning: assignment makes pointer from integer without a cast [enabled by default] pxmitpriv-pallocated_xmitbuf = vzalloc(NR_XMITBUFF * sizeof(struct xmit_buf) + 4); ^ drivers/staging/rtl8188eu/core/rtw_xmit.c:174:36: warning: assignment makes pointer from integer without a cast [enabled by default] pxmitpriv-pallocated_xmit_extbuf = vzalloc(num_xmit_extbuf * sizeof(struct xmit_buf) + 4); ^ drivers/staging/rtl8188eu/core/rtw_xmit.c: In function '_rtw_free_xmit_priv': drivers/staging/rtl8188eu/core/rtw_xmit.c:262:3: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration] vfree(pxmitpriv-pallocated_frame_buf); ^ drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c: In function 'rtw_IOL_cmd_tx_pkt_buf_dump': drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c:368:2: error: implicit declaration of function 'vzalloc' [-Werror=implicit-function-declaration] u8 *pbuf = vzalloc(data_len+10); ^
Re: linux-next: build failure after merge of the final tree (staging tree related)
On Mon, Feb 10, 2014 at 03:54:12PM +1100, Stephen Rothwell wrote: Hi all, After merging the final tree, today's linux-next build (powerpc allyesconfig) failed like this: drivers/staging/rtl8188eu/core/rtw_mlme.c: In function '_rtw_init_mlme_priv': drivers/staging/rtl8188eu/core/rtw_mlme.c:65:2: error: implicit declaration of function 'vzalloc' [-Werror=implicit-function-declaration] pbuf = vzalloc(MAX_BSS_CNT * (sizeof(struct wlan_network))); ^ snip Sorry about that. Larry sent me a patch for this Friday evening and I haven't had the chance to add it to my tree just yet. Sorry for the noise. greg k-h -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
linux-next: build failure after merge of the final tree
Hi all,
After merging the final tree, today's linux-next build (powerpc
ppc44x_defconfig) failed like this:
arch/powerpc/kvm/44x.c: In function 'kvmppc_44x_exit':
arch/powerpc/kvm/44x.c:231:2: error: implicit declaration of function
'kvmppc_booke_exit' [-Werror=implicit-function-declaration]
Caused by my conflict fixup in the init tree. I just reverted the rest
of commit f9315b9d2680 ("powerpc: kvm e500/44x is not modular, so don't
use module_init") from the init tree.
--
Cheers,
Stephen Rothwells...@canb.auug.org.au
pgp1BWJJXj463.pgp
Description: PGP signature
linux-next: build failure after merge of the final tree
Hi all, After merging the final tree, today's linux-next build (powerpc ppc44x_defconfig) failed like this: arch/powerpc/kvm/44x.c: In function 'kvmppc_44x_exit': arch/powerpc/kvm/44x.c:231:2: error: implicit declaration of function 'kvmppc_booke_exit' [-Werror=implicit-function-declaration] Caused by my conflict fixup in the init tree. I just reverted the rest of commit f9315b9d2680 (powerpc: kvm e500/44x is not modular, so don't use module_init) from the init tree. -- Cheers, Stephen Rothwells...@canb.auug.org.au pgp1BWJJXj463.pgp Description: PGP signature
Re: linux-next: build failure after merge of the final tree
On Mon, 2014-01-06 at 20:28 +1100, Stephen Rothwell wrote: > Hi all, > > After merging the final tree, today's linux-next build (powerpc > allyesconfig) failed like this: > > arch/powerpc/kernel/exceptions-64s.S: Assembler messages: > arch/powerpc/kernel/exceptions-64s.S:1312: Error: attempt to move .org > backwards > > The last time I got this error, I needed to apply patch "powerpc: Fix > "attempt to move .org backwards" error", but that has been included in > the powerpc tree now, so I guess something else has added code in a > critical place. :-( > > I have just left this broken for today. I had to modify that patch when applying it, it's possible that the "new" version isn't making as much room. Without that change it would fail the build on some of my configs due to some of the asm for the maskable exception handling being too far from the conditional branches that calls it. I think it's time we do a bit of re-org of that file to figure out precisely what has to be where and move things out more aggressively. Cheers, Ben. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
linux-next: build failure after merge of the final tree
Hi all, After merging the final tree, today's linux-next build (powerpc allyesconfig) failed like this: arch/powerpc/kernel/exceptions-64s.S: Assembler messages: arch/powerpc/kernel/exceptions-64s.S:1312: Error: attempt to move .org backwards The last time I got this error, I needed to apply patch "powerpc: Fix "attempt to move .org backwards" error", but that has been included in the powerpc tree now, so I guess something else has added code in a critical place. :-( I have just left this broken for today. -- Cheers, Stephen Rothwell pgpV0ZWWNQazI.pgp Description: PGP signature
linux-next: build failure after merge of the final tree
Hi all, After merging the final tree, today's linux-next build (powerpc allyesconfig) failed like this: arch/powerpc/kernel/exceptions-64s.S: Assembler messages: arch/powerpc/kernel/exceptions-64s.S:1312: Error: attempt to move .org backwards The last time I got this error, I needed to apply patch powerpc: Fix attempt to move .org backwards error, but that has been included in the powerpc tree now, so I guess something else has added code in a critical place. :-( I have just left this broken for today. -- Cheers, Stephen Rothwell s...@canb.auug.org.au pgpV0ZWWNQazI.pgp Description: PGP signature
Re: linux-next: build failure after merge of the final tree
On Mon, 2014-01-06 at 20:28 +1100, Stephen Rothwell wrote: Hi all, After merging the final tree, today's linux-next build (powerpc allyesconfig) failed like this: arch/powerpc/kernel/exceptions-64s.S: Assembler messages: arch/powerpc/kernel/exceptions-64s.S:1312: Error: attempt to move .org backwards The last time I got this error, I needed to apply patch powerpc: Fix attempt to move .org backwards error, but that has been included in the powerpc tree now, so I guess something else has added code in a critical place. :-( I have just left this broken for today. I had to modify that patch when applying it, it's possible that the new version isn't making as much room. Without that change it would fail the build on some of my configs due to some of the asm for the maskable exception handling being too far from the conditional branches that calls it. I think it's time we do a bit of re-org of that file to figure out precisely what has to be where and move things out more aggressively. Cheers, Ben. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
linux-next: build failure after merge of the final tree (gpio tree related)
Hi all,
After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:
drivers/gpio/gpio-sch311x.c: In function 'sch311x_sio_enter':
drivers/gpio/gpio-sch311x.c:115:2: error: implicit declaration of function
'outb' [-Werror=implicit-function-declaration]
outb(SIO_CONFIG_KEY_ENTER, sio_config_port);
^
drivers/gpio/gpio-sch311x.c: In function 'sch311x_sio_inb':
drivers/gpio/gpio-sch311x.c:128:2: error: implicit declaration of function
'inb' [-Werror=implicit-function-declaration]
return inb(sio_config_port + 1);
^
Caused by commit 12262bef8f46 ("gpio: add GPIO support for SMSC SCH311x")
from the gpio tree.
I have reverted that commit for today.
--
Cheers,
Stephen Rothwells...@canb.auug.org.au
pgpTgQZWh2wf2.pgp
Description: PGP signature
linux-next: build failure after merge of the final tree (gpio tree related)
Hi all, After merging the final tree, today's linux-next build (powerpc allyesconfig) failed like this: drivers/gpio/gpio-sch311x.c: In function 'sch311x_sio_enter': drivers/gpio/gpio-sch311x.c:115:2: error: implicit declaration of function 'outb' [-Werror=implicit-function-declaration] outb(SIO_CONFIG_KEY_ENTER, sio_config_port); ^ drivers/gpio/gpio-sch311x.c: In function 'sch311x_sio_inb': drivers/gpio/gpio-sch311x.c:128:2: error: implicit declaration of function 'inb' [-Werror=implicit-function-declaration] return inb(sio_config_port + 1); ^ Caused by commit 12262bef8f46 (gpio: add GPIO support for SMSC SCH311x) from the gpio tree. I have reverted that commit for today. -- Cheers, Stephen Rothwells...@canb.auug.org.au pgpTgQZWh2wf2.pgp Description: PGP signature
Re: linux-next: build failure after merge of the final tree
Hi,
Am Dienstag, 17. Dezember 2013, 06:59:56 schrieb Stephen Rothwell:
> Caused by commit 34ef6d7fe467 ("rtc: add hym8563 rtc-driver") from the
> akpm-current tree. Probably some missing include(s).
>
> I just reverted that commit for today.
The includes are fine, I just seem to have forgotten the dependency of
COMMON_CLK, which enables the clk structs in clk-provider.h. Sorry about that.
Follow up patch coming shortly.
Heiko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the final tree
Hi, Am Dienstag, 17. Dezember 2013, 06:59:56 schrieb Stephen Rothwell: Caused by commit 34ef6d7fe467 (rtc: add hym8563 rtc-driver) from the akpm-current tree. Probably some missing include(s). I just reverted that commit for today. The includes are fine, I just seem to have forgotten the dependency of COMMON_CLK, which enables the clk structs in clk-provider.h. Sorry about that. Follow up patch coming shortly. Heiko -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
linux-next: build failure after merge of the final tree
Hi all, After merging the final tree, today's linux-next build (powerpc allyesconfig) failed like this: drivers/rtc/rtc-hym8563.c:90:17: error: field 'clkout_hw' has incomplete type struct clk_hw clkout_hw; ^ In file included from include/asm-generic/bug.h:13:0, from arch/powerpc/include/asm/bug.h:127, from include/linux/bug.h:4, from include/linux/thread_info.h:11, from include/asm-generic/preempt.h:4, from arch/powerpc/include/generated/asm/preempt.h:1, from include/linux/preempt.h:18, from include/linux/spinlock.h:50, from include/linux/seqlock.h:35, from include/linux/time.h:5, from include/linux/stat.h:18, from include/linux/module.h:10, from drivers/rtc/rtc-hym8563.c:20: drivers/rtc/rtc-hym8563.c: In function 'hym8563_clkout_recalc_rate': include/linux/kernel.h:801:48: warning: initialization from incompatible pointer type [enabled by default] const typeof( ((type *)0)->member ) *__mptr = (ptr); \ ^ drivers/rtc/rtc-hym8563.c:293:35: note: in expansion of macro 'container_of' #define clkout_hw_to_hym8563(_hw) container_of(_hw, struct hym8563, clkout_hw) ^ drivers/rtc/rtc-hym8563.c:305:28: note: in expansion of macro 'clkout_hw_to_hym8563' struct hym8563 *hym8563 = clkout_hw_to_hym8563(hw); ^ include/linux/kernel.h:801:48: warning: (near initialization for 'hym8563') [enabled by default] const typeof( ((type *)0)->member ) *__mptr = (ptr); \ ^ drivers/rtc/rtc-hym8563.c:293:35: note: in expansion of macro 'container_of' #define clkout_hw_to_hym8563(_hw) container_of(_hw, struct hym8563, clkout_hw) ^ drivers/rtc/rtc-hym8563.c:305:28: note: in expansion of macro 'clkout_hw_to_hym8563' struct hym8563 *hym8563 = clkout_hw_to_hym8563(hw); ^ drivers/rtc/rtc-hym8563.c: In function 'hym8563_clkout_set_rate': include/linux/kernel.h:801:48: warning: initialization from incompatible pointer type [enabled by default] const typeof( ((type *)0)->member ) *__mptr = (ptr); \ ^ drivers/rtc/rtc-hym8563.c:293:35: note: in expansion of macro 'container_of' #define clkout_hw_to_hym8563(_hw) container_of(_hw, struct hym8563, clkout_hw) ^ drivers/rtc/rtc-hym8563.c:331:28: note: in expansion of macro 'clkout_hw_to_hym8563' struct hym8563 *hym8563 = clkout_hw_to_hym8563(hw); ^ include/linux/kernel.h:801:48: warning: (near initialization for 'hym8563') [enabled by default] const typeof( ((type *)0)->member ) *__mptr = (ptr); \ ^ drivers/rtc/rtc-hym8563.c:293:35: note: in expansion of macro 'container_of' #define clkout_hw_to_hym8563(_hw) container_of(_hw, struct hym8563, clkout_hw) ^ drivers/rtc/rtc-hym8563.c:331:28: note: in expansion of macro 'clkout_hw_to_hym8563' struct hym8563 *hym8563 = clkout_hw_to_hym8563(hw); ^ drivers/rtc/rtc-hym8563.c: In function 'hym8563_clkout_control': include/linux/kernel.h:801:48: warning: initialization from incompatible pointer type [enabled by default] const typeof( ((type *)0)->member ) *__mptr = (ptr); \ ^ drivers/rtc/rtc-hym8563.c:293:35: note: in expansion of macro 'container_of' #define clkout_hw_to_hym8563(_hw) container_of(_hw, struct hym8563, clkout_hw) ^ drivers/rtc/rtc-hym8563.c:352:28: note: in expansion of macro 'clkout_hw_to_hym8563' struct hym8563 *hym8563 = clkout_hw_to_hym8563(hw); ^ include/linux/kernel.h:801:48: warning: (near initialization for 'hym8563') [enabled by default] const typeof( ((type *)0)->member ) *__mptr = (ptr); \ ^ drivers/rtc/rtc-hym8563.c:293:35: note: in expansion of macro 'container_of' #define clkout_hw_to_hym8563(_hw) container_of(_hw, struct hym8563, clkout_hw) ^ drivers/rtc/rtc-hym8563.c:352:28: note: in expansion of macro 'clkout_hw_to_hym8563' struct hym8563 *hym8563 = clkout_hw_to_hym8563(hw); ^ drivers/rtc/rtc-hym8563.c: In function 'hym8563_clkout_is_prepared': include/linux/kernel.h:801:48: warning: initialization from incompatible pointer type [enabled by default] const typeof( ((type *)0)->member ) *__mptr = (ptr); \ ^ drivers/rtc/rtc-hym8563.c:293:35: note: in expansion of macro 'container_of' #define clkout_hw_to_hym8563(_hw) container_of(_hw, struct hym8563, clkout_hw)
linux-next: build failure after merge of the final tree (akpm-current tree related)
Hi all,
After merging the final tree, today's linux-next build (powerpc
allnoconfig) failed like this:
arch/powerpc/mm/mem.c: In function 'do_init_bootmem':
arch/powerpc/mm/mem.c:212:49: error: 'memblock_memory' undeclared (first use in
this function)
memblock_set_node(0, (phys_addr_t)ULLONG_MAX, _memory, 0);
^
Caused by commit 3a543893d46a ("memblock: make memblock_set_node()
support different memblock_type") from the apm-current tree.
I added the following fix for today:
From: Stephen Rothwell
Date: Tue, 17 Dec 2013 16:38:21 +1100
Subject: [PATCH]
memblock-make-memblock_set_node-support-different-memblock_type-fix
Signed-off-by: Stephen Rothwell
---
arch/powerpc/mm/mem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/mm/mem.c b/arch/powerpc/mm/mem.c
index 231b785b726e..8c1dd23652a1 100644
--- a/arch/powerpc/mm/mem.c
+++ b/arch/powerpc/mm/mem.c
@@ -209,7 +209,7 @@ void __init do_init_bootmem(void)
/* Place all memblock_regions in the same node and merge contiguous
* memblock_regions
*/
- memblock_set_node(0, (phys_addr_t)ULLONG_MAX, _memory, 0);
+ memblock_set_node(0, (phys_addr_t)ULLONG_MAX, , 0);
/* Add all physical memory to the bootmem map, mark each area
* present.
--
1.8.5.1
--
Cheers,
Stephen Rothwells...@canb.auug.org.au
pgpomwSRWmGO9.pgp
Description: PGP signature
Re: linux-next: build failure after merge of the final tree
On Mon, 16 Dec 2013 12:33:01 + Mark Brown wrote: > > On Mon, Dec 16, 2013 at 01:13:41PM +0100, Krzysztof Kozlowski wrote: > > > Thanks for applying the patch. The commit introducing error was picked > > up by Andrew to MM tree and lately got merged to Linus' tree: > > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=8d2763770c34e8ed771f0be86760eb4485febc05 > > Yeah, I saw it went in through -mm - what I was wondering was why it > wasn't causing failures in -next. That patch was never in mmotm (which is what linux-next mostly includes). mmotm hasn't been updated since Nov 22. -- Cheers, Stephen Rothwells...@canb.auug.org.au pgpGc2CChG51K.pgp Description: PGP signature
Re: linux-next: build failure after merge of the final tree
On Mon, Dec 16, 2013 at 01:13:41PM +0100, Krzysztof Kozlowski wrote: > Thanks for applying the patch. The commit introducing error was picked > up by Andrew to MM tree and lately got merged to Linus' tree: > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=8d2763770c34e8ed771f0be86760eb4485febc05 Yeah, I saw it went in through -mm - what I was wondering was why it wasn't causing failures in -next. signature.asc Description: Digital signature
