Re: linux-next: build failure after merge of the hwmon-staging tree
On Thu, Oct 01, 2020 at 12:53:10PM +1000, Stephen Rothwell wrote:
> Hi all,
>
> After merging the hwmon-staging tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/hwmon/pmbus/mp2975.c: In function 'mp2975_probe':
> drivers/hwmon/pmbus/mp2975.c:740:32: error: passing argument 2 of
> 'pmbus_do_probe' from incompatible pointer type
> [-Werror=incompatible-pointer-types]
> 740 | return pmbus_do_probe(client, id, info);
> |^~
> ||
> |const struct i2c_device_id *
> In file included from drivers/hwmon/pmbus/mp2975.c:13:
> drivers/hwmon/pmbus/pmbus.h:492:73: note: expected 'struct pmbus_driver_info
> *' but argument is of type 'const struct i2c_device_id *'
> 492 | int pmbus_do_probe(struct i2c_client *client, struct
> pmbus_driver_info *info);
> |
> ~~^~~~
> drivers/hwmon/pmbus/mp2975.c:740:9: error: too many arguments to function
> 'pmbus_do_probe'
> 740 | return pmbus_do_probe(client, id, info);
> | ^~
> In file included from drivers/hwmon/pmbus/mp2975.c:13:
> drivers/hwmon/pmbus/pmbus.h:492:5: note: declared here
> 492 | int pmbus_do_probe(struct i2c_client *client, struct
> pmbus_driver_info *info);
> | ^~
>
> Caused by commit
>
> dd38ac315b23 ("hwmon: (pmbus) Add support for MPS Multi-phase mp2975
> controller")
>
Oops, sorry, got caught in API changes. Fixed.
Guenter
> I have used the hwmon-staging tree from next-20200930 for today.
>
> --
> Cheers,
> Stephen Rothwell
linux-next: build failure after merge of the hwmon-staging tree
Hi all,
After merging the hwmon-staging tree, today's linux-next build (x86_64
allmodconfig) failed like this:
drivers/hwmon/pmbus/mp2975.c: In function 'mp2975_probe':
drivers/hwmon/pmbus/mp2975.c:740:32: error: passing argument 2 of
'pmbus_do_probe' from incompatible pointer type
[-Werror=incompatible-pointer-types]
740 | return pmbus_do_probe(client, id, info);
|^~
||
|const struct i2c_device_id *
In file included from drivers/hwmon/pmbus/mp2975.c:13:
drivers/hwmon/pmbus/pmbus.h:492:73: note: expected 'struct pmbus_driver_info *'
but argument is of type 'const struct i2c_device_id *'
492 | int pmbus_do_probe(struct i2c_client *client, struct pmbus_driver_info
*info);
|
~~^~~~
drivers/hwmon/pmbus/mp2975.c:740:9: error: too many arguments to function
'pmbus_do_probe'
740 | return pmbus_do_probe(client, id, info);
| ^~
In file included from drivers/hwmon/pmbus/mp2975.c:13:
drivers/hwmon/pmbus/pmbus.h:492:5: note: declared here
492 | int pmbus_do_probe(struct i2c_client *client, struct pmbus_driver_info
*info);
| ^~
Caused by commit
dd38ac315b23 ("hwmon: (pmbus) Add support for MPS Multi-phase mp2975
controller")
I have used the hwmon-staging tree from next-20200930 for today.
--
Cheers,
Stephen Rothwell
pgpJIgwuA93e8.pgp
Description: OpenPGP digital signature
Re: linux-next: build failure after merge of the hwmon-staging tree
On 8/23/20 5:28 PM, Stephen Rothwell wrote:
> Hi all,
>
> After merging the hwmon-staging tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/hwmon/pmbus/adm1266.c: In function 'adm1266_probe':
> drivers/hwmon/pmbus/adm1266.c:478:31: error: passing argument 2 of
> 'pmbus_do_probe' from incompatible pointer type
> [-Werror=incompatible-pointer-types]
> 478 | ret = pmbus_do_probe(client, id, >info);
> | ^~
> | |
> | const struct i2c_device_id *
> In file included from drivers/hwmon/pmbus/adm1266.c:20:
> drivers/hwmon/pmbus/pmbus.h:492:73: note: expected 'struct pmbus_driver_info
> *' but argument is of type 'const struct i2c_device_id *'
> 492 | int pmbus_do_probe(struct i2c_client *client, struct
> pmbus_driver_info *info);
> |
> ~~^~~~
> drivers/hwmon/pmbus/adm1266.c:478:8: error: too many arguments to function
> 'pmbus_do_probe'
> 478 | ret = pmbus_do_probe(client, id, >info);
> |^~
> In file included from drivers/hwmon/pmbus/adm1266.c:20:
> drivers/hwmon/pmbus/pmbus.h:492:5: note: declared here
> 492 | int pmbus_do_probe(struct i2c_client *client, struct
> pmbus_driver_info *info);
> | ^~
> cc1: some warnings being treated as errors
>
> Caused by commit
>
> 9832ecffd8f8 ("hwmon: (pmbus) Add support for ADM1266")
>
> interacting with commit
>
> d46dc459db38 ("hwmon (pmbus) use simple i2c probe function")
>
> I have used the hwmon-staging tree from next-20200821 for today.
>
Fixed. Sorry for the trouble.
Guenter
signature.asc
Description: OpenPGP digital signature
linux-next: build failure after merge of the hwmon-staging tree
Hi all,
After merging the hwmon-staging tree, today's linux-next build (x86_64
allmodconfig) failed like this:
drivers/hwmon/pmbus/adm1266.c: In function 'adm1266_probe':
drivers/hwmon/pmbus/adm1266.c:478:31: error: passing argument 2 of
'pmbus_do_probe' from incompatible pointer type
[-Werror=incompatible-pointer-types]
478 | ret = pmbus_do_probe(client, id, >info);
| ^~
| |
| const struct i2c_device_id *
In file included from drivers/hwmon/pmbus/adm1266.c:20:
drivers/hwmon/pmbus/pmbus.h:492:73: note: expected 'struct pmbus_driver_info *'
but argument is of type 'const struct i2c_device_id *'
492 | int pmbus_do_probe(struct i2c_client *client, struct pmbus_driver_info
*info);
|
~~^~~~
drivers/hwmon/pmbus/adm1266.c:478:8: error: too many arguments to function
'pmbus_do_probe'
478 | ret = pmbus_do_probe(client, id, >info);
|^~
In file included from drivers/hwmon/pmbus/adm1266.c:20:
drivers/hwmon/pmbus/pmbus.h:492:5: note: declared here
492 | int pmbus_do_probe(struct i2c_client *client, struct pmbus_driver_info
*info);
| ^~
cc1: some warnings being treated as errors
Caused by commit
9832ecffd8f8 ("hwmon: (pmbus) Add support for ADM1266")
interacting with commit
d46dc459db38 ("hwmon (pmbus) use simple i2c probe function")
I have used the hwmon-staging tree from next-20200821 for today.
--
Cheers,
Stephen Rothwell
pgpWmje3l3Q1_.pgp
Description: OpenPGP digital signature
Re: linux-next: build failure after merge of the hwmon-staging tree
On 4/27/20 11:36 PM, Stephen Rothwell wrote:
> Hi all,
>
> After merging the hwmon-staging tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
>
> drivers/hwmon/lm70.c: In function 'lm70_probe':
> drivers/hwmon/lm70.c:186:34: error: 'lm70_acpi_ids' undeclared (first use in
> this function); did you mean 'lm70_of_ids'?
> 186 | acpi_match = acpi_match_device(lm70_acpi_ids, >dev);
> | ^
> | lm70_of_ids
>
> Caused by commit
>
> 02b925a9104d ("hwmon: (lm70) Add support for ACPI")
>
> CONFIG_ACPI is not set.
>
> I have reverted that commit for today.
>
I fixed it up. And I'll have to add test builds with CONFIG_ACPI=n.
Guenter
signature.asc
Description: OpenPGP digital signature
Re: linux-next: build failure after merge of the hwmon-staging tree
On Tue, Feb 26, 2019 at 10:55:47AM +1100, Stephen Rothwell wrote: > Hi Guenter, > > After merging the hwmon-staging tree, today's linux-next build (x86_64 > allmodconfig) failed like this: > Ah, sorry for that. I had fixed this up, but forgot to push. Guenter
linux-next: build failure after merge of the hwmon-staging tree
Hi Guenter,
After merging the hwmon-staging tree, today's linux-next build (x86_64
allmodconfig) failed like this:
drivers/hwmon/ad7418: struct of_device_id is 200 bytes. The last of 3 is:
0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00
0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00
0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00
0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00
0x61 0x64 0x69 0x2c 0x61 0x64 0x37 0x34 0x31 0x38 0x00 0x00 0x00 0x00 0x00 0x00
0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00
0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00
0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00
0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00
0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00
0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00
0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00
0x02 0x00 0x00 0x00 0x00 0x00 0x00 0x00
FATAL: drivers/hwmon/ad7418: struct of_device_id is not terminated with a NULL
entry!
Caused by commit
08c95c6f6f95 ("hwmon: (ad7418) Add device tree probing")
--
Cheers,
Stephen Rothwell
pgp5NfOr2oA6M.pgp
Description: OpenPGP digital signature
linux-next: build failure after merge of the hwmon-staging tree
Hi Guenter,
After merging the hwmon-staging tree, today's linux-next build (x86_64
allmodconfig) failed like this:
drivers/hwmon/Kconfig:1298:warning: ignoring unsupported character '/'
drivers/hwmon/Kconfig:1299: syntax error
drivers/hwmon/Kconfig:1298:warning: ignoring unsupported character '/'
drivers/hwmon/Kconfig:1298:warning: ignoring unsupported character '/'
drivers/hwmon/Kconfig:1298: invalid statement
Caused by commit
de75c2156b2f ("hwmon: Add On-Chip Controller (OCC) hwmon driver")
interacting with updates to the kconfig system.
I have applied the following merge fix patch for today.
From: Stephen Rothwell
Date: Mon, 17 Dec 2018 09:50:14 +1100
Subject: [PATCH] hwmon: quote the path in Kconfig source statements
Signed-off-by: Stephen Rothwell
---
drivers/hwmon/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
index 62b68cd280dc..6f929bfa9fcd 100644
--- a/drivers/hwmon/Kconfig
+++ b/drivers/hwmon/Kconfig
@@ -1295,7 +1295,7 @@ config SENSORS_NSA320
This driver can also be built as a module. If so, the module
will be called nsa320-hwmon.
-source drivers/hwmon/occ/Kconfig
+source "drivers/hwmon/occ/Kconfig"
config SENSORS_PCF8591
tristate "Philips PCF8591 ADC/DAC"
--
2.19.1
--
Cheers,
Stephen Rothwell
pgp9qkDAsw5zB.pgp
Description: OpenPGP digital signature
