Re: linux-next: build failure after merge of the infiniband tree
On Tue, Feb 17, 2015 at 6:32 PM, Stephen Rothwell wrote: > After merging the livepatching tree, today's linux-next build (powerpc > allyesconfig) failed like this: > > In file included from drivers/infiniband/hw/qib/qib_cq.c:41:0: > drivers/infiniband/hw/qib/qib.h: In function 'qib_flush_wc': > drivers/infiniband/hw/qib/qib.h:1470:1: error: expected ';' before '}' token > } > ^ > > and it went badly down hill from there :-( Weird, I could have sworn I fixed that before I pushed the tree out. Anyway I'll try adding the missing ';' again and push it out again :( -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
linux-next: build failure after merge of the infiniband tree
Hi all,
After merging the livepatching tree, today's linux-next build (powerpc
allyesconfig) failed like this:
In file included from drivers/infiniband/hw/qib/qib_cq.c:41:0:
drivers/infiniband/hw/qib/qib.h: In function 'qib_flush_wc':
drivers/infiniband/hw/qib/qib.h:1470:1: error: expected ';' before '}' token
}
^
and it went badly down hill from there :-(
Caused by commit f72c1c08efbc ("IB/qib: Fix checkpatch warnings").
I have reverted that commit for today.
--
Cheers,
Stephen Rothwells...@canb.auug.org.au
pgpBl1Jm5xQ7J.pgp
Description: OpenPGP digital signature
Re: linux-next: build failure after merge of the infiniband tree
On 12/16/2014 3:56 AM, Roland Dreier wrote: On Mon, Dec 15, 2014 at 5:47 PM, Stephen Rothwell wrote: Hi all, After merging the infiniband tree, today's linux-next build (x86_64 allmodconfig) failed like this: drivers/infiniband/hw/mlx5/main.c: In function 'mlx5_ib_query_device': drivers/infiniband/hw/mlx5/main.c:248:34: error: 'MLX5_DEV_CAP_FLAG_ON_DMND_PG' undeclared (first use in this function) if (dev->mdev->caps.gen.flags & MLX5_DEV_CAP_FLAG_ON_DMND_PG) ^ [...] Really? Code added half way though the merge window not even build tested? It's not quite as bad as it seems. The infiniband tree itself builds, the problem is the merged tree. The Mellanox guys merged the "cleanup" Hi Roland, So shit happens... Eli is away this week, but it's clear that this portion of the cleanup was terribly wrongand done by mistake, sorry for that and thanks for addressing quickly. Or. commit 0c7aac854f52 Author: Eli Cohen Date: Tue Dec 2 02:26:14 2014 net/mlx5_core: Remove unused dev cap enum fields These enumerations are not used so remove them. Signed-off-by: Eli Cohen Signed-off-by: David S. Miller through davem's tree, and then went ahead and used at least MLX5_DEV_CAP_FLAG_ON_DMND_PG (which that patch removes) in patches they merged through my tree. I'll add a partial revert of that patch to my tree to get back the now-used enum values. - R. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the infiniband tree
On Mon, Dec 15, 2014 at 5:56 PM, Roland Dreier wrote: > I'll add a partial revert of that patch to my tree to get back the > now-used enum values. I rebased my tree on top of the merge-window merge of davem's tree, and added the missing flag on top of the "remove this flag" commit. - R. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the infiniband tree
On Mon, Dec 15, 2014 at 5:47 PM, Stephen Rothwell wrote: > Hi all, > > After merging the infiniband tree, today's linux-next build (x86_64 > allmodconfig) failed like this: > > drivers/infiniband/hw/mlx5/main.c: In function 'mlx5_ib_query_device': > drivers/infiniband/hw/mlx5/main.c:248:34: error: > 'MLX5_DEV_CAP_FLAG_ON_DMND_PG' undeclared (first use in this function) > if (dev->mdev->caps.gen.flags & MLX5_DEV_CAP_FLAG_ON_DMND_PG) > ^ > drivers/net/ethernet/mellanox/mlx5/core/fw.c: In function > 'mlx5_query_odp_caps': > drivers/net/ethernet/mellanox/mlx5/core/fw.c:79:30: error: > 'MLX5_DEV_CAP_FLAG_ON_DMND_PG' undeclared (first use in this function) > if (!(dev->caps.gen.flags & MLX5_DEV_CAP_FLAG_ON_DMND_PG)) > ^ > drivers/net/ethernet/mellanox/mlx5/core/eq.c: In function 'mlx5_start_eqs': > drivers/net/ethernet/mellanox/mlx5/core/eq.c:459:28: error: > 'MLX5_DEV_CAP_FLAG_ON_DMND_PG' undeclared (first use in this function) > if (dev->caps.gen.flags & MLX5_DEV_CAP_FLAG_ON_DMND_PG) > ^ > > Really? Code added half way though the merge window not even build > tested? It's not quite as bad as it seems. The infiniband tree itself builds, the problem is the merged tree. The Mellanox guys merged the "cleanup" commit 0c7aac854f52 Author: Eli Cohen Date: Tue Dec 2 02:26:14 2014 net/mlx5_core: Remove unused dev cap enum fields These enumerations are not used so remove them. Signed-off-by: Eli Cohen Signed-off-by: David S. Miller through davem's tree, and then went ahead and used at least MLX5_DEV_CAP_FLAG_ON_DMND_PG (which that patch removes) in patches they merged through my tree. I'll add a partial revert of that patch to my tree to get back the now-used enum values. - R. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
linux-next: build failure after merge of the infiniband tree
Hi all, After merging the infiniband tree, today's linux-next build (x86_64 allmodconfig) failed like this: drivers/infiniband/hw/mlx5/main.c: In function 'mlx5_ib_query_device': drivers/infiniband/hw/mlx5/main.c:248:34: error: 'MLX5_DEV_CAP_FLAG_ON_DMND_PG' undeclared (first use in this function) if (dev->mdev->caps.gen.flags & MLX5_DEV_CAP_FLAG_ON_DMND_PG) ^ drivers/net/ethernet/mellanox/mlx5/core/fw.c: In function 'mlx5_query_odp_caps': drivers/net/ethernet/mellanox/mlx5/core/fw.c:79:30: error: 'MLX5_DEV_CAP_FLAG_ON_DMND_PG' undeclared (first use in this function) if (!(dev->caps.gen.flags & MLX5_DEV_CAP_FLAG_ON_DMND_PG)) ^ drivers/net/ethernet/mellanox/mlx5/core/eq.c: In function 'mlx5_start_eqs': drivers/net/ethernet/mellanox/mlx5/core/eq.c:459:28: error: 'MLX5_DEV_CAP_FLAG_ON_DMND_PG' undeclared (first use in this function) if (dev->caps.gen.flags & MLX5_DEV_CAP_FLAG_ON_DMND_PG) ^ Really? Code added half way though the merge window not even build tested? I have used the infiniband tree from next-20141215 for today. -- Cheers, Stephen Rothwells...@canb.auug.org.au pgpFQcrfr24oa.pgp Description: OpenPGP digital signature
Re: linux-next: build failure after merge of the infiniband tree
On 20-12-2012 05:52, Roland Dreier wrote:
> On Wed, Dec 19, 2012 at 2:44 PM, Stephen Rothwell
> wrote:
>> Hi all,
>>
>> After merging the infiniband tree, today's linux-next build (x86_64_
>> allmodconfig) failed like this:
>>
>> In file included from drivers/scsi/csiostor/csio_wr.h:42:0,
>> from drivers/scsi/csiostor/csio_scsi.h:49,
>> from drivers/scsi/csiostor/csio_init.h:45,
>> from drivers/scsi/csiostor/csio_attr.c:45:
>> drivers/scsi/csiostor/t4fw_api_stor.h:43:6: error: nested redefinition of
>> 'enum fw_retval'
>> drivers/scsi/csiostor/t4fw_api_stor.h:43:6: error: redeclaration of 'enum
>> fw_retval'
>> drivers/net/ethernet/chelsio/cxgb4/t4fw_api.h:42:6: note: originally defined
>> here
>> drivers/scsi/csiostor/t4fw_api_stor.h:48:2: error: redeclaration of
>> enumerator 'FW_ENOEXEC'
>> drivers/net/ethernet/chelsio/cxgb4/t4fw_api.h:39:2: note: previous
>> definition of 'FW_ENOEXEC' was here
>> drivers/scsi/csiostor/t4fw_api_stor.h:50:2: error: redeclaration of
>> enumerator 'FW_ENOMEM'
>> drivers/net/ethernet/chelsio/cxgb4/t4fw_api.h:43:2: note: previous
>> definition of 'FW_ENOMEM' was here
>> drivers/scsi/csiostor/t4fw_api_stor.h:58:2: error: redeclaration of
>> enumerator 'FW_EADDRINUSE'
>> drivers/net/ethernet/chelsio/cxgb4/t4fw_api.h:44:2: note: previous
>> definition of 'FW_EADDRINUSE' was here
>>
>> And several others similar.
>>
>> Caused by commit f65b56b15931 ("RDMA/cxgb4: Fix LE hash collision bug for
>> active open connection").
>
>
> Vipul, is the right fix to pull the full list of FW return values from
> t4fw_api_stor.h into t4fw_api.h as part of this patch (f65b56b15931)?
>
Yes, this is a correct way to fix this issue. I see that this change is
already done. Thanks for providing the fix.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the infiniband tree
On Wed, Dec 19, 2012 at 2:44 PM, Stephen Rothwell wrote:
> Hi all,
>
> After merging the infiniband tree, today's linux-next build (x86_64_
> allmodconfig) failed like this:
>
> In file included from drivers/scsi/csiostor/csio_wr.h:42:0,
> from drivers/scsi/csiostor/csio_scsi.h:49,
> from drivers/scsi/csiostor/csio_init.h:45,
> from drivers/scsi/csiostor/csio_attr.c:45:
> drivers/scsi/csiostor/t4fw_api_stor.h:43:6: error: nested redefinition of
> 'enum fw_retval'
> drivers/scsi/csiostor/t4fw_api_stor.h:43:6: error: redeclaration of 'enum
> fw_retval'
> drivers/net/ethernet/chelsio/cxgb4/t4fw_api.h:42:6: note: originally defined
> here
> drivers/scsi/csiostor/t4fw_api_stor.h:48:2: error: redeclaration of
> enumerator 'FW_ENOEXEC'
> drivers/net/ethernet/chelsio/cxgb4/t4fw_api.h:39:2: note: previous definition
> of 'FW_ENOEXEC' was here
> drivers/scsi/csiostor/t4fw_api_stor.h:50:2: error: redeclaration of
> enumerator 'FW_ENOMEM'
> drivers/net/ethernet/chelsio/cxgb4/t4fw_api.h:43:2: note: previous definition
> of 'FW_ENOMEM' was here
> drivers/scsi/csiostor/t4fw_api_stor.h:58:2: error: redeclaration of
> enumerator 'FW_EADDRINUSE'
> drivers/net/ethernet/chelsio/cxgb4/t4fw_api.h:44:2: note: previous definition
> of 'FW_EADDRINUSE' was here
>
> And several others similar.
>
> Caused by commit f65b56b15931 ("RDMA/cxgb4: Fix LE hash collision bug for
> active open connection").
Vipul, is the right fix to pull the full list of FW return values from
t4fw_api_stor.h into t4fw_api.h as part of this patch (f65b56b15931)?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
linux-next: build failure after merge of the infiniband tree
Hi all,
After merging the infiniband tree, today's linux-next build (x86_64_
allmodconfig) failed like this:
In file included from drivers/scsi/csiostor/csio_wr.h:42:0,
from drivers/scsi/csiostor/csio_scsi.h:49,
from drivers/scsi/csiostor/csio_init.h:45,
from drivers/scsi/csiostor/csio_attr.c:45:
drivers/scsi/csiostor/t4fw_api_stor.h:43:6: error: nested redefinition of 'enum
fw_retval'
drivers/scsi/csiostor/t4fw_api_stor.h:43:6: error: redeclaration of 'enum
fw_retval'
drivers/net/ethernet/chelsio/cxgb4/t4fw_api.h:42:6: note: originally defined
here
drivers/scsi/csiostor/t4fw_api_stor.h:48:2: error: redeclaration of enumerator
'FW_ENOEXEC'
drivers/net/ethernet/chelsio/cxgb4/t4fw_api.h:39:2: note: previous definition
of 'FW_ENOEXEC' was here
drivers/scsi/csiostor/t4fw_api_stor.h:50:2: error: redeclaration of enumerator
'FW_ENOMEM'
drivers/net/ethernet/chelsio/cxgb4/t4fw_api.h:43:2: note: previous definition
of 'FW_ENOMEM' was here
drivers/scsi/csiostor/t4fw_api_stor.h:58:2: error: redeclaration of enumerator
'FW_EADDRINUSE'
drivers/net/ethernet/chelsio/cxgb4/t4fw_api.h:44:2: note: previous definition
of 'FW_EADDRINUSE' was here
And several others similar.
Caused by commit f65b56b15931 ("RDMA/cxgb4: Fix LE hash collision bug for
active open connection").
I have used the infiniband tree from next-20121219 for today.
--
Cheers,
Stephen Rothwells...@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
pgpX5vb0pjSOL.pgp
Description: PGP signature
Re: linux-next: build failure after merge of the infiniband tree
Hi Roland, Thanks for the fix. On Wed, 15 Aug 2012 21:07:37 -0700 Roland Dreier wrote: > > > See Rule 1 in Documentation/SubmitChecklist. > > Heh, but it compiles fine on x86! Which is why we have Rule 1 :-) -- Cheers, Stephen Rothwells...@canb.auug.org.au pgpf0sJqi9Dnd.pgp Description: PGP signature
Re: linux-next: build failure after merge of the infiniband tree
On Wed, Aug 15, 2012 at 6:44 PM, Stephen Rothwell wrote: > After merging the infiniband tree, today's linux-next build (powerpc > ppc64_defconfig) failed like this: > > drivers/net/ethernet/mellanox/mlx4/mr.c: In function 'mlx4_buddy_init': > drivers/net/ethernet/mellanox/mlx4/mr.c:134:4: error: implicit declaration of > function 'vzalloc' [-Werror=implicit-function-declaration] > drivers/net/ethernet/mellanox/mlx4/mr.c:134:19: warning: assignment makes > pointer from integer without a cast [enabled by default] > drivers/net/ethernet/mellanox/mlx4/mr.c:148:4: error: implicit declaration of > function 'vfree' [-Werror=implicit-function-declaration] > cc1: some warnings being treated as errors Thanks, should be fixed in tomorrow's for-next (added include of ). > See Rule 1 in Documentation/SubmitChecklist. Heh, but it compiles fine on x86! - R. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
linux-next: build failure after merge of the infiniband tree
Hi all,
After merging the infiniband tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:
drivers/net/ethernet/mellanox/mlx4/mr.c: In function 'mlx4_buddy_init':
drivers/net/ethernet/mellanox/mlx4/mr.c:134:4: error: implicit declaration of
function 'vzalloc' [-Werror=implicit-function-declaration]
drivers/net/ethernet/mellanox/mlx4/mr.c:134:19: warning: assignment makes
pointer from integer without a cast [enabled by default]
drivers/net/ethernet/mellanox/mlx4/mr.c:148:4: error: implicit declaration of
function 'vfree' [-Werror=implicit-function-declaration]
cc1: some warnings being treated as errors
Caused by commit 2354c0904331 ("mlx4_core: Allow large mlx4_buddy
bitmaps") which added the vmalloc call (which was changed to vzalloc by
commit 09e22f30018b ("mlx4_core: Clean up buddy bitmap allocation"). The
include of vmalloc.h is missing. See Rule 1 in
Documentation/SubmitChecklist.
I have used the infiniband tree from next-20120814 for today.
--
Cheers,
Stephen Rothwells...@canb.auug.org.au
pgpkjaeEiRGCy.pgp
Description: PGP signature
