Re: linux-next: build failure after merge of the input tree
On Fri, Oct 16, 2015 at 09:37:34AM +0200, Hans de Goede wrote:
> Hio,
>
> On 16-10-15 04:19, Stephen Rothwell wrote:
> >Hi Dmitry,
> >
> >After merging the input tree, today's linux-next build (x86_64
> >allmodconfig) failed like this:
> >
> >In file included from samples/hidraw/hid-example.c:14:0:
> >./usr/include/linux/input.h:17:31: fatal error: input-event-codes.h: No such
> >file or directory
> >
> >Caused by commit
> >
> > d794709c3916 ("Input: Add input-event-codes header file")
> >
> >I have used the input tree from next-20151015 for today.
>
> Sorry, my bad, I assumed anything under include/uapi would
> automatically get installed as a usr header, but it turns out
> any files added need to also be added to the Kbuild file, the
> attached patch should fix this.
>
> Dmitry, feel free to squash this into the original patch.
Thanks Hans, I folded it into the original patch.
>
> Regards,
>
> Hans
> From 0dd5544b6ca0cddfe25976b46ef9ba5c4adbc791 Mon Sep 17 00:00:00 2001
> From: Hans de Goede
> Date: Fri, 16 Oct 2015 09:33:45 +0200
> Subject: [PATCH] input: Add input-event-codes.h to usr headers to install
>
> Add input-event-codes.h to the list of uapi headers to install, this fixes
> build-failures of any userspace tools including linux/input.h .
>
> Signed-off-by: Hans de Goede
> ---
> include/uapi/linux/Kbuild | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/uapi/linux/Kbuild b/include/uapi/linux/Kbuild
> index f7b2db4..0f26309 100644
> --- a/include/uapi/linux/Kbuild
> +++ b/include/uapi/linux/Kbuild
> @@ -191,6 +191,7 @@ header-y += inet_diag.h
> header-y += in.h
> header-y += inotify.h
> header-y += input.h
> +header-y += input-event-codes.h
> header-y += in_route.h
> header-y += ioctl.h
> header-y += ip6_tunnel.h
> --
> 2.5.0
>
--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the input tree
On Fri, Oct 16, 2015 at 09:37:34AM +0200, Hans de Goede wrote:
> Hio,
>
> On 16-10-15 04:19, Stephen Rothwell wrote:
> >Hi Dmitry,
> >
> >After merging the input tree, today's linux-next build (x86_64
> >allmodconfig) failed like this:
> >
> >In file included from samples/hidraw/hid-example.c:14:0:
> >./usr/include/linux/input.h:17:31: fatal error: input-event-codes.h: No such
> >file or directory
> >
> >Caused by commit
> >
> > d794709c3916 ("Input: Add input-event-codes header file")
> >
> >I have used the input tree from next-20151015 for today.
>
> Sorry, my bad, I assumed anything under include/uapi would
> automatically get installed as a usr header, but it turns out
> any files added need to also be added to the Kbuild file, the
> attached patch should fix this.
>
> Dmitry, feel free to squash this into the original patch.
Thanks Hans, I folded it into the original patch.
>
> Regards,
>
> Hans
> From 0dd5544b6ca0cddfe25976b46ef9ba5c4adbc791 Mon Sep 17 00:00:00 2001
> From: Hans de Goede
> Date: Fri, 16 Oct 2015 09:33:45 +0200
> Subject: [PATCH] input: Add input-event-codes.h to usr headers to install
>
> Add input-event-codes.h to the list of uapi headers to install, this fixes
> build-failures of any userspace tools including linux/input.h .
>
> Signed-off-by: Hans de Goede
> ---
> include/uapi/linux/Kbuild | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/uapi/linux/Kbuild b/include/uapi/linux/Kbuild
> index f7b2db4..0f26309 100644
> --- a/include/uapi/linux/Kbuild
> +++ b/include/uapi/linux/Kbuild
> @@ -191,6 +191,7 @@ header-y += inet_diag.h
> header-y += in.h
> header-y += inotify.h
> header-y += input.h
> +header-y += input-event-codes.h
> header-y += in_route.h
> header-y += ioctl.h
> header-y += ip6_tunnel.h
> --
> 2.5.0
>
--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the input tree
Hio,
On 16-10-15 04:19, Stephen Rothwell wrote:
Hi Dmitry,
After merging the input tree, today's linux-next build (x86_64
allmodconfig) failed like this:
In file included from samples/hidraw/hid-example.c:14:0:
./usr/include/linux/input.h:17:31: fatal error: input-event-codes.h: No such
file or directory
Caused by commit
d794709c3916 ("Input: Add input-event-codes header file")
I have used the input tree from next-20151015 for today.
Sorry, my bad, I assumed anything under include/uapi would
automatically get installed as a usr header, but it turns out
any files added need to also be added to the Kbuild file, the
attached patch should fix this.
Dmitry, feel free to squash this into the original patch.
Regards,
Hans
>From 0dd5544b6ca0cddfe25976b46ef9ba5c4adbc791 Mon Sep 17 00:00:00 2001
From: Hans de Goede
Date: Fri, 16 Oct 2015 09:33:45 +0200
Subject: [PATCH] input: Add input-event-codes.h to usr headers to install
Add input-event-codes.h to the list of uapi headers to install, this fixes
build-failures of any userspace tools including linux/input.h .
Signed-off-by: Hans de Goede
---
include/uapi/linux/Kbuild | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/uapi/linux/Kbuild b/include/uapi/linux/Kbuild
index f7b2db4..0f26309 100644
--- a/include/uapi/linux/Kbuild
+++ b/include/uapi/linux/Kbuild
@@ -191,6 +191,7 @@ header-y += inet_diag.h
header-y += in.h
header-y += inotify.h
header-y += input.h
+header-y += input-event-codes.h
header-y += in_route.h
header-y += ioctl.h
header-y += ip6_tunnel.h
--
2.5.0
Re: linux-next: build failure after merge of the input tree
Hio,
On 16-10-15 04:19, Stephen Rothwell wrote:
Hi Dmitry,
After merging the input tree, today's linux-next build (x86_64
allmodconfig) failed like this:
In file included from samples/hidraw/hid-example.c:14:0:
./usr/include/linux/input.h:17:31: fatal error: input-event-codes.h: No such
file or directory
Caused by commit
d794709c3916 ("Input: Add input-event-codes header file")
I have used the input tree from next-20151015 for today.
Sorry, my bad, I assumed anything under include/uapi would
automatically get installed as a usr header, but it turns out
any files added need to also be added to the Kbuild file, the
attached patch should fix this.
Dmitry, feel free to squash this into the original patch.
Regards,
Hans
>From 0dd5544b6ca0cddfe25976b46ef9ba5c4adbc791 Mon Sep 17 00:00:00 2001
From: Hans de Goede
Date: Fri, 16 Oct 2015 09:33:45 +0200
Subject: [PATCH] input: Add input-event-codes.h to usr headers to install
Add input-event-codes.h to the list of uapi headers to install, this fixes
build-failures of any userspace tools including linux/input.h .
Signed-off-by: Hans de Goede
---
include/uapi/linux/Kbuild | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/uapi/linux/Kbuild b/include/uapi/linux/Kbuild
index f7b2db4..0f26309 100644
--- a/include/uapi/linux/Kbuild
+++ b/include/uapi/linux/Kbuild
@@ -191,6 +191,7 @@ header-y += inet_diag.h
header-y += in.h
header-y += inotify.h
header-y += input.h
+header-y += input-event-codes.h
header-y += in_route.h
header-y += ioctl.h
header-y += ip6_tunnel.h
--
2.5.0
linux-next: build failure after merge of the input tree
Hi Dmitry,
After merging the input tree, today's linux-next build (x86_64
allmodconfig) failed like this:
In file included from samples/hidraw/hid-example.c:14:0:
./usr/include/linux/input.h:17:31: fatal error: input-event-codes.h: No such
file or directory
Caused by commit
d794709c3916 ("Input: Add input-event-codes header file")
I have used the input tree from next-20151015 for today.
--
Cheers,
Stephen Rothwells...@canb.auug.org.au
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
linux-next: build failure after merge of the input tree
Hi Dmitry,
After merging the input tree, today's linux-next build (x86_64
allmodconfig) failed like this:
In file included from samples/hidraw/hid-example.c:14:0:
./usr/include/linux/input.h:17:31: fatal error: input-event-codes.h: No such
file or directory
Caused by commit
d794709c3916 ("Input: Add input-event-codes header file")
I have used the input tree from next-20151015 for today.
--
Cheers,
Stephen Rothwells...@canb.auug.org.au
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the input tree
Hi Stephen,
On July 23, 2015 6:49:36 PM PDT, Stephen Rothwell wrote:
>Hi Dmitry,
>
>After merging the input tree, today's linux-next build (arm
>multi_v7_defconfig) failed like this:
>
>drivers/input/keyboard/samsung-keypad.c: In function
>'samsung_keypad_parse_dt':
>drivers/input/keyboard/samsung-keypad.c:302:40: error: 'pp' undeclared
>(first use in this function)
> pdata->wakeup = of_property_read_bool(pp, "wakeup-source") ||
>^
>
>Caused by commit
>
>7e324dd6cc21 ("Input: samsung-keypad - change name of wakeup property")
Sorry about this, you managed to grab the tree in the couple of hours while the
bad commit was there, it should all be corrected now.
Thanks.
--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
linux-next: build failure after merge of the input tree
Hi Dmitry,
After merging the input tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:
drivers/input/keyboard/samsung-keypad.c: In function 'samsung_keypad_parse_dt':
drivers/input/keyboard/samsung-keypad.c:302:40: error: 'pp' undeclared (first
use in this function)
pdata->wakeup = of_property_read_bool(pp, "wakeup-source") ||
^
Caused by commit
7e324dd6cc21 ("Input: samsung-keypad - change name of wakeup property")
Please at least build test these changes :-(
I have used the input tree from next-20150723 for today.
--
Cheers,
Stephen Rothwells...@canb.auug.org.au
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
linux-next: build failure after merge of the input tree
Hi Dmitry, After merging the input tree, today's linux-next build (arm multi_v7_defconfig) failed like this: drivers/input/keyboard/samsung-keypad.c: In function 'samsung_keypad_parse_dt': drivers/input/keyboard/samsung-keypad.c:302:40: error: 'pp' undeclared (first use in this function) pdata-wakeup = of_property_read_bool(pp, wakeup-source) || ^ Caused by commit 7e324dd6cc21 (Input: samsung-keypad - change name of wakeup property) Please at least build test these changes :-( I have used the input tree from next-20150723 for today. -- Cheers, Stephen Rothwells...@canb.auug.org.au -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the input tree
Hi Stephen, On July 23, 2015 6:49:36 PM PDT, Stephen Rothwell s...@canb.auug.org.au wrote: Hi Dmitry, After merging the input tree, today's linux-next build (arm multi_v7_defconfig) failed like this: drivers/input/keyboard/samsung-keypad.c: In function 'samsung_keypad_parse_dt': drivers/input/keyboard/samsung-keypad.c:302:40: error: 'pp' undeclared (first use in this function) pdata-wakeup = of_property_read_bool(pp, wakeup-source) || ^ Caused by commit 7e324dd6cc21 (Input: samsung-keypad - change name of wakeup property) Sorry about this, you managed to grab the tree in the couple of hours while the bad commit was there, it should all be corrected now. Thanks. -- Dmitry -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the input tree
Hi Stephen,
On Fri, Oct 05, 2012 at 11:47:12AM +1000, Stephen Rothwell wrote:
> Hi Dmitry,
>
> After merging the input tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/input/tablet/wacom_sys.c: In function 'wacom_get_sibling':
> drivers/input/tablet/wacom_sys.c:643:23: error: 'struct usb_device' has no
> member named 'children'
>
> Caused by commit 316f18bba311 ("Input: wacom - handle split-sensor
> devices with internal hubs") interacting with commit ff823c79a5c3 ("usb:
> move children to struct usb_port") that is now in Linus' tree.
>
> I have used the input tree from next-20121004 for today.
Sorry about this. I pulled the offending patch and another one depending
on it out of my next branch pending my next pull from mainline.
Thanks.
--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the input tree
Hi Stephen, On Fri, Oct 05, 2012 at 11:47:12AM +1000, Stephen Rothwell wrote: Hi Dmitry, After merging the input tree, today's linux-next build (x86_64 allmodconfig) failed like this: drivers/input/tablet/wacom_sys.c: In function 'wacom_get_sibling': drivers/input/tablet/wacom_sys.c:643:23: error: 'struct usb_device' has no member named 'children' Caused by commit 316f18bba311 (Input: wacom - handle split-sensor devices with internal hubs) interacting with commit ff823c79a5c3 (usb: move children to struct usb_port) that is now in Linus' tree. I have used the input tree from next-20121004 for today. Sorry about this. I pulled the offending patch and another one depending on it out of my next branch pending my next pull from mainline. Thanks. -- Dmitry -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
linux-next: build failure after merge of the input tree
Hi Dmitry,
After merging the input tree, today's linux-next build (x86_64
allmodconfig) failed like this:
drivers/input/tablet/wacom_sys.c: In function 'wacom_get_sibling':
drivers/input/tablet/wacom_sys.c:643:23: error: 'struct usb_device' has no
member named 'children'
Caused by commit 316f18bba311 ("Input: wacom - handle split-sensor
devices with internal hubs") interacting with commit ff823c79a5c3 ("usb:
move children to struct usb_port") that is now in Linus' tree.
I have used the input tree from next-20121004 for today.
--
Cheers,
Stephen Rothwells...@canb.auug.org.au
pgpTRrH0KwyGF.pgp
Description: PGP signature
linux-next: build failure after merge of the input tree
Hi Dmitry, After merging the input tree, today's linux-next build (x86_64 allmodconfig) failed like this: drivers/input/tablet/wacom_sys.c: In function 'wacom_get_sibling': drivers/input/tablet/wacom_sys.c:643:23: error: 'struct usb_device' has no member named 'children' Caused by commit 316f18bba311 (Input: wacom - handle split-sensor devices with internal hubs) interacting with commit ff823c79a5c3 (usb: move children to struct usb_port) that is now in Linus' tree. I have used the input tree from next-20121004 for today. -- Cheers, Stephen Rothwells...@canb.auug.org.au pgpTRrH0KwyGF.pgp Description: PGP signature
