subject:"linux\-next\: build failure after merge of the kbuild tree"

Re: linux-next: build failure after merge of the kbuild tree

2021-02-21 Thread Masahiro Yamada

Hi Stephen,

On Mon, Feb 22, 2021 at 6:33 AM Stephen Rothwell  wrote:
>
> Hi all,
>
> After merging the kbuild tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> cc1: fatal error: FORCE: No such file or directory
> compilation terminated.
>
> Presuably caused by commit
>
>   15bb90419621 ("arch: syscalls: add missing FORCE and fix 'targets' to make 
> if_changed work")

Sorry, this happens only when CONFIG_XEN=y,
and I did not cover all cases.

I will fix it for tomorrow's linux-next.


If it is not too late, you can apply the following locally.



diff --git a/arch/x86/entry/syscalls/Makefile b/arch/x86/entry/syscalls/Makefile
index e1c7ddb7546b..ea6ffb51b9a3 100644
--- a/arch/x86/entry/syscalls/Makefile
+++ b/arch/x86/entry/syscalls/Makefile
@@ -21,7 +21,7 @@ quiet_cmd_systbl = SYSTBL  $@
   cmd_systbl = $(CONFIG_SHELL) '$(systbl)' $< $@

 quiet_cmd_hypercalls = HYPERCALLS $@
-  cmd_hypercalls = $(CONFIG_SHELL) '$<' $@ $(filter-out $<,$^)
+  cmd_hypercalls = $(CONFIG_SHELL) '$<' $@ $(filter-out $<,$(real-prereqs))

 syshdr_abi_unistd_32 := i386
 $(uapi)/unistd_32.h: $(syscall32) $(syshdr) FORCE






> I have used the kbuild tree from next-20210219 for today.
>
> --
> Cheers,
> Stephen Rothwell



-- 
Best Regards
Masahiro Yamada

linux-next: build failure after merge of the kbuild tree

2021-02-21 Thread Stephen Rothwell

Hi all,

After merging the kbuild tree, today's linux-next build (x86_64
allmodconfig) failed like this:

cc1: fatal error: FORCE: No such file or directory
compilation terminated.

Presuably caused by commit

  15bb90419621 ("arch: syscalls: add missing FORCE and fix 'targets' to make 
if_changed work")

I have used the kbuild tree from next-20210219 for today.

-- 
Cheers,
Stephen Rothwell


pgpSx9mm6li_Y.pgp
Description: OpenPGP digital signature

Re: linux-next: build failure after merge of the kbuild tree

2020-07-13 Thread Masahiro Yamada

Hi Stephen,

On Mon, Jul 13, 2020 at 10:56 AM Stephen Rothwell  wrote:
>
> Hi all,
>
> On Tue, 7 Jul 2020 17:07:20 +1000 Stephen Rothwell  
> wrote:
> >
> > Hi all,
> >
> > After merging the kbuild tree, today's linux-next build (powerpc
> > ppc44x_defconfig) failed like this:
> >
> > cc1: fatal error: opening output file 
> > arch/powerpc/boot/dts/.ebony.dtb.dts.tmp: No such file or directory
> >
> > and directory arch/powerpc/boot/dts/ does, indeed, not exist in the
> > separate object directory.
> >
> > Caused by commit
> >
> >   ea4679253288 ("kbuild: always create directories of targets")
> >
> > at least, reverting that commit makes the build work again.
>
> I am still reverting that commit.


Sorry, I missed the previous email.
I will fix it soon.


-- 
Best Regards
Masahiro Yamada

Re: linux-next: build failure after merge of the kbuild tree

2020-07-12 Thread Stephen Rothwell

Hi all,

On Tue, 7 Jul 2020 17:07:20 +1000 Stephen Rothwell  
wrote:
>
> Hi all,
> 
> After merging the kbuild tree, today's linux-next build (powerpc
> ppc44x_defconfig) failed like this:
> 
> cc1: fatal error: opening output file 
> arch/powerpc/boot/dts/.ebony.dtb.dts.tmp: No such file or directory
> 
> and directory arch/powerpc/boot/dts/ does, indeed, not exist in the
> separate object directory.
> 
> Caused by commit
> 
>   ea4679253288 ("kbuild: always create directories of targets")
> 
> at least, reverting that commit makes the build work again.

I am still reverting that commit.

-- 
Cheers,
Stephen Rothwell


pgpeiGTSTShWo.pgp
Description: OpenPGP digital signature

linux-next: build failure after merge of the kbuild tree

2020-07-07 Thread Stephen Rothwell

Hi all,

After merging the kbuild tree, today's linux-next build (powerpc
ppc44x_defconfig) failed like this:

cc1: fatal error: opening output file arch/powerpc/boot/dts/.ebony.dtb.dts.tmp: 
No such file or directory

and directory arch/powerpc/boot/dts/ does, indeed, not exist in the
separate object directory.

Caused by commit

  ea4679253288 ("kbuild: always create directories of targets")

at least, reverting that commit makes the build work again.

-- 
Cheers,
Stephen Rothwell


pgpFVSYKnkniW.pgp
Description: OpenPGP digital signature

Re: linux-next: build failure after merge of the kbuild tree

2019-07-16 Thread Stephen Rothwell

Hi Masahiro,

On Tue, 16 Jul 2019 13:59:51 +0900 Masahiro Yamada 
 wrote:
>
> For the build error, I will fix it as follows for tomorrow's linux-next:

Thanks for the quick response.

-- 
Cheers,
Stephen Rothwell


pgpN0tCgezN6c.pgp
Description: OpenPGP digital signature

Re: linux-next: build failure after merge of the kbuild tree

2019-07-15 Thread Masahiro Yamada

Hi Stephen,

On Tue, Jul 16, 2019 at 1:31 PM Stephen Rothwell  wrote:
>
> Hi all,
>
> After merging the kbuild tree, today's linux-next build (x86_64
> allnoconfig) failed like this:
>
> make[1]: *** No rule to make target 'modules.order', needed by 
> 'autoksyms_recursive'.  Stop.
>
> Starting with commit
>
>   656c0ac3cb4b ("kbuild: modpost: read modules.order instead of 
> $(MODVERDIR)/*.mod")
>
> i.e. after reverting just:
>
> 25a55e249bc0 Revert "kbuild: create *.mod with full directory path and remove 
> MODVERDIR"
> 15657d9eceb6 Revert "kbuild: remove the first line of *.mod files"
> 8c21f4122839 Revert "kbuild: remove 'prepare1' target"
> 35bc41d44d2d Revert "kbuild: split out *.mod out of {single,multi}-used-m 
> rules"
>
> I get
>
> cat: modules.order: No such file or directory
>
> near the end of the allnoconfig build (but it does not fail).
>
> and when I remove 25a55e249bc0 i.e. stop reverting
>
>   0539f970a842 ("kbuild: create *.mod with full directory path and remove 
> MODVERDIR")
>
> the build fails.
>
> So, for today I have reverted these 4 commits:
>
>   56dce8121e97 ("kbuild: split out *.mod out of {single,multi}-used-m rules")
>   fbe0b5eb7890 ("kbuild: remove 'prepare1' target")
>   008fa222d268 ("kbuild: remove the first line of *.mod files")
>   0539f970a842 ("kbuild: create *.mod with full directory path and remove 
> MODVERDIR")
>


Ugh, sorry for the breakage.


For the build error, I will fix it as follows for tomorrow's linux-next:

diff --git a/Makefile b/Makefile
index bfb08cc647f8..5f3daca90862 100644
--- a/Makefile
+++ b/Makefile
@@ -1028,8 +1028,8 @@ vmlinux-deps := $(KBUILD_LDS)
$(KBUILD_VMLINUX_OBJS) $(KBUILD_VMLINUX_LIBS)

 # Recurse until adjust_autoksyms.sh is satisfied
 PHONY += autoksyms_recursive
-autoksyms_recursive: $(vmlinux-deps) modules.order
 ifdef CONFIG_TRIM_UNUSED_KSYMS
+autoksyms_recursive: $(vmlinux-deps) modules.order
$(Q)$(CONFIG_SHELL) $(srctree)/scripts/adjust_autoksyms.sh \
  "$(MAKE) -f $(srctree)/Makefile vmlinux"
 endif



For the warning, I will fix it as follows for tomorrow's linux-next:

diff --git a/scripts/Makefile.modpost b/scripts/Makefile.modpost
index 3e229d4f4d72..6b19c1a4eae5 100644
--- a/scripts/Makefile.modpost
+++ b/scripts/Makefile.modpost
@@ -64,7 +64,9 @@ modulesymfile := $(firstword $(KBUILD_EXTMOD))/Module.symvers
 modorder := $(if $(KBUILD_EXTMOD),$(KBUILD_EXTMOD)/)modules.order

 # Step 1), find all modules listed in modules.order
+ifdef CONFIG_MODULES
 modules := $(sort $(shell cat $(modorder)))
+endif

 # Stop after building .o files if NOFINAL is set. Makes compile tests quicker
 _modpost: $(if $(KBUILD_MODPOST_NOFINAL), $(modules:.ko:.o),$(modules))


Thanks!

-- 
Best Regards
Masahiro Yamada

linux-next: build failure after merge of the kbuild tree

2019-07-15 Thread Stephen Rothwell

Hi all,

After merging the kbuild tree, today's linux-next build (x86_64
allnoconfig) failed like this:

make[1]: *** No rule to make target 'modules.order', needed by 
'autoksyms_recursive'.  Stop.

Starting with commit

  656c0ac3cb4b ("kbuild: modpost: read modules.order instead of 
$(MODVERDIR)/*.mod")

i.e. after reverting just:

25a55e249bc0 Revert "kbuild: create *.mod with full directory path and remove 
MODVERDIR"
15657d9eceb6 Revert "kbuild: remove the first line of *.mod files"
8c21f4122839 Revert "kbuild: remove 'prepare1' target"
35bc41d44d2d Revert "kbuild: split out *.mod out of {single,multi}-used-m rules"

I get

cat: modules.order: No such file or directory

near the end of the allnoconfig build (but it does not fail).

and when I remove 25a55e249bc0 i.e. stop reverting

  0539f970a842 ("kbuild: create *.mod with full directory path and remove 
MODVERDIR")

the build fails.

So, for today I have reverted these 4 commits:

  56dce8121e97 ("kbuild: split out *.mod out of {single,multi}-used-m rules")
  fbe0b5eb7890 ("kbuild: remove 'prepare1' target")
  008fa222d268 ("kbuild: remove the first line of *.mod files")
  0539f970a842 ("kbuild: create *.mod with full directory path and remove 
MODVERDIR")

-- 
Cheers,
Stephen Rothwell


pgpvTWpqsa7Pz.pgp
Description: OpenPGP digital signature

Re: linux-next: build failure after merge of the kbuild tree

2019-07-05 Thread Masahiro Yamada

Hi Michael,

On Sat, Jul 6, 2019 at 9:05 AM Michael Kelley  wrote:
>
> From: Stephen Rothwell   Sent: Friday, July 5, 2019 
> 1:31 AM
> >
> > After merging the kbuild tree, today's linux-next build (powerpc
> > allyesconfig) failed like this:
> >
> > In file included from :
> > include/clocksource/hyperv_timer.h:18:10: fatal error: asm/mshyperv.h: No 
> > such file or
> > directory
> >  #include 
> >   ^~~~
> >
> > Caused by commit
> >
> >   34085aeb5816 ("kbuild: compile-test kernel headers to ensure they are 
> > self-contained")
> >
> > interacting with commit
> >
> >   dd2cb348613b ("clocksource/drivers: Continue making Hyper-V clocksource 
> > ISA agnostic")
> >
> > from the tip tree.
> >
>
> Thomas -- let's remove my two clocksource patches from your 'tip' tree.  I'll 
> need
> a little time to fully understand the self-contained header requirements and 
> restructure
> hyperv_timer.h to avoid this problem.

I do not think you have to drop your patches.

Since  only exists in x86,
guarding it by CONFIG_X86 is OK.
So, I think Stephen's patch is OK as-is.

Perhaps, Kbuild is imposing too much burden,
but I'd like to try it and see how it goes.


-- 
Best Regards
Masahiro Yamada

RE: linux-next: build failure after merge of the kbuild tree

2019-07-05 Thread Michael Kelley

From: Stephen Rothwell   Sent: Friday, July 5, 2019 1:31 
AM
> 
> After merging the kbuild tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
> 
> In file included from :
> include/clocksource/hyperv_timer.h:18:10: fatal error: asm/mshyperv.h: No 
> such file or
> directory
>  #include 
>   ^~~~
> 
> Caused by commit
> 
>   34085aeb5816 ("kbuild: compile-test kernel headers to ensure they are 
> self-contained")
> 
> interacting with commit
> 
>   dd2cb348613b ("clocksource/drivers: Continue making Hyper-V clocksource ISA 
> agnostic")
> 
> from the tip tree.
> 

Thomas -- let's remove my two clocksource patches from your 'tip' tree.  I'll 
need
a little time to fully understand the self-contained header requirements and 
restructure
hyperv_timer.h to avoid this problem.

Michael

linux-next: build failure after merge of the kbuild tree

2019-07-05 Thread Stephen Rothwell

Hi all,

After merging the kbuild tree, today's linux-next build (powerpc
allyesconfig) failed like this:

In file included from :
include/clocksource/hyperv_timer.h:18:10: fatal error: asm/mshyperv.h: No such 
file or directory
 #include 
  ^~~~

Caused by commit

  34085aeb5816 ("kbuild: compile-test kernel headers to ensure they are 
self-contained")

interacting with commit

  dd2cb348613b ("clocksource/drivers: Continue making Hyper-V clocksource ISA 
agnostic")

from the tip tree.

I have added the following patch for today.

From: Stephen Rothwell 
Date: Fri, 5 Jul 2019 18:17:44 +1000
Subject: [PATCH] kbuild: only compile test clocksource/hyperv_timer.h on X86

Signed-off-by: Stephen Rothwell 
---
 include/Kbuild | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/Kbuild b/include/Kbuild
index 4f9524d92a75..a7ab060552c2 100644
--- a/include/Kbuild
+++ b/include/Kbuild
@@ -29,6 +29,7 @@ header-test-  += acpi/platform/acintel.h
 header-test-   += acpi/platform/aclinux.h
 header-test-   += acpi/platform/aclinuxex.h
 header-test-   += acpi/processor.h
+header-test-$(CONFIG_X86)  += clocksource/hyperv_timer.h
 header-test-   += clocksource/timer-sp804.h
 header-test-   += crypto/cast_common.h
 header-test-   += crypto/internal/cryptouser.h
-- 
2.20.1



-- 
Cheers,
Stephen Rothwell


pgpzvGLMbNRML.pgp
Description: OpenPGP digital signature

Re: Fwd: linux-next: build failure after merge of the kbuild tree

2019-05-07 Thread Masahiro Yamada

Hi Paul,


On Mon, May 6, 2019 at 11:23 PM Paul Gortmaker
 wrote:
>
> [Re: Fwd: linux-next: build failure after merge of the kbuild tree] On 
> 06/05/2019 (Mon 21:07) Masahiro Yamada wrote:
>
> > Hi Paul,
> >
> >
> > On Mon, May 6, 2019 at 12:34 PM Paul Gortmaker
> >  wrote:
> > >
> > > [Fwd: linux-next: build failure after merge of the kbuild tree] On 
> > > 06/05/2019 (Mon 11:19) Masahiro Yamada wrote:
> > >
> > > > Hi Paul,
> > > >
> > > > In today's linux-next build testing,
> > > > more "make ... explicitly non-modular"
> > > > candidates showed up.
> > > >
> > >
> > > Hi Masahiro,
> > >
> > > I am not 100% clear on what you are asking me.  There are lots and lots
> > > of these in the kernel many fixed, and many remain unfortunately.
> > >
> > > > arch/arm/plat-omap/dma.c
> > > > drivers/clocksource/timer-ti-dm.c
> > > > drivers/mfd/omap-usb-host.c
> > > > drivers/mfd/omap-usb-tll.c
> > >
> > > None of these are "new".  I just checked, and I have had patches for all
> > > these for a long time, in my personal queue, found by my audits.
> >
> >
> > OK, I saw many patches from you
> > addressing this issue,
> > so I just thought you might be motivated to
> > fix them.
> >
> > Anyway, I have a reason to fix them
> > because a patch in my tree is causing build errors.
>
> I understand now.  I missed the connection between these drivers and the
> Kbuild change when I read this last night.  Sorry about that.
>
> I can send the changes to those four files, but since I can't guarantee
> they will be merged quickly (or at all!) - that will leave the commit in
> the Kbuild tree causing build regressions for days or likely even weeks.
>
> > So, I will do something for them
> > if you do not have a plan to send patches soon.
>
> I will be happy to send them, but we just opened the two week merge
> window, and a lot of maintainers don't like getting sent new patches
> until the two week merge window has closed - so we should avoid that.
>
> I'm not sure how you would like to proceed - one way would be that we
> get the drivers above changed in 5.2 and you delay your kbuild change
> until we start v5.3 - to that end I'd be happy to add the Kbuild change
> to my internal build testing in the meantime, if you would like.
>
> Now that I understand the problem, let me know what you would like to
> do, and I'll do what I can to help out.


I decided to merge minimal changes to my kbuild tree
since I did not want to delay the kbuild patch.

I got some Ack tags, so I applied this patch:
https://patchwork.kernel.org/patch/10931673/

I appreciate if you could fix those files in a complete way,
but there is no more reason to rush.



> Thanks,
> Paul.




--
Best Regards
Masahiro Yamada

Re: Fwd: linux-next: build failure after merge of the kbuild tree

2019-05-06 Thread Paul Gortmaker

[Re: Fwd: linux-next: build failure after merge of the kbuild tree] On 
06/05/2019 (Mon 21:07) Masahiro Yamada wrote:

> Hi Paul,
> 
> 
> On Mon, May 6, 2019 at 12:34 PM Paul Gortmaker
>  wrote:
> >
> > [Fwd: linux-next: build failure after merge of the kbuild tree] On 
> > 06/05/2019 (Mon 11:19) Masahiro Yamada wrote:
> >
> > > Hi Paul,
> > >
> > > In today's linux-next build testing,
> > > more "make ... explicitly non-modular"
> > > candidates showed up.
> > >
> >
> > Hi Masahiro,
> >
> > I am not 100% clear on what you are asking me.  There are lots and lots
> > of these in the kernel many fixed, and many remain unfortunately.
> >
> > > arch/arm/plat-omap/dma.c
> > > drivers/clocksource/timer-ti-dm.c
> > > drivers/mfd/omap-usb-host.c
> > > drivers/mfd/omap-usb-tll.c
> >
> > None of these are "new".  I just checked, and I have had patches for all
> > these for a long time, in my personal queue, found by my audits.
> 
> 
> OK, I saw many patches from you
> addressing this issue,
> so I just thought you might be motivated to
> fix them.
> 
> Anyway, I have a reason to fix them
> because a patch in my tree is causing build errors.

I understand now.  I missed the connection between these drivers and the
Kbuild change when I read this last night.  Sorry about that.

I can send the changes to those four files, but since I can't guarantee
they will be merged quickly (or at all!) - that will leave the commit in
the Kbuild tree causing build regressions for days or likely even weeks.

> So, I will do something for them
> if you do not have a plan to send patches soon.

I will be happy to send them, but we just opened the two week merge
window, and a lot of maintainers don't like getting sent new patches
until the two week merge window has closed - so we should avoid that.

I'm not sure how you would like to proceed - one way would be that we
get the drivers above changed in 5.2 and you delay your kbuild change
until we start v5.3 - to that end I'd be happy to add the Kbuild change
to my internal build testing in the meantime, if you would like.

Now that I understand the problem, let me know what you would like to
do, and I'll do what I can to help out.

Thanks,
Paul.

Re: Fwd: linux-next: build failure after merge of the kbuild tree

2019-05-06 Thread Masahiro Yamada

Hi Paul,


On Mon, May 6, 2019 at 12:34 PM Paul Gortmaker
 wrote:
>
> [Fwd: linux-next: build failure after merge of the kbuild tree] On 06/05/2019 
> (Mon 11:19) Masahiro Yamada wrote:
>
> > Hi Paul,
> >
> > In today's linux-next build testing,
> > more "make ... explicitly non-modular"
> > candidates showed up.
> >
>
> Hi Masahiro,
>
> I am not 100% clear on what you are asking me.  There are lots and lots
> of these in the kernel many fixed, and many remain unfortunately.
>
> > arch/arm/plat-omap/dma.c
> > drivers/clocksource/timer-ti-dm.c
> > drivers/mfd/omap-usb-host.c
> > drivers/mfd/omap-usb-tll.c
>
> None of these are "new".  I just checked, and I have had patches for all
> these for a long time, in my personal queue, found by my audits.


OK, I saw many patches from you
addressing this issue,
so I just thought you might be motivated to
fix them.

Anyway, I have a reason to fix them
because a patch in my tree is causing build errors.

So, I will do something for them
if you do not have a plan to send patches soon.

Thanks.



> > Would you send patches?
>
> It isn't that simple.  I wish it was.  Some subsystem maintainers are
> glad to take the patches, and some think they are a waste of time and
> reject them immediately.  Some I've sent just simply get "crickets".
>
> What that means is, that I need to look at each maintainer's
> requirements, and ensure the patch and commit log are matching
> expectatins - I will not just spam out hundreds of patches across all
> subsystems.  Anyone who has spent considerable time in linux development
> knows that is a recipe for failure.
>
> So I need to work across each subsystem - one at a time, with their
> individual maintainer requirements in mind, and if you look at git
> history, you will see that has been what I've tried to do when I had
> free time to work on fixing these across the whole linux tree.
>
> But fortunately, none of these represent a CVE/security issue, so I've
> never had a reason to try and pretend there was any reason for an
> immediate fix/merge - they just represent a better attention to detail
> in the code we merge and support that I'd like to see happen tree-wide.
>
> I appreciate that you are also interested in seeing all these fixed, and
> I also wish they could all be solved in one version, but unfortunately I
> don't think that is pragmatic.  So in the meantime, I will continue to
> chip away at things when we are early in the dev cycle and not starting
> the two week merge window, as we are just now.
>
> Thanks,
> Paul.
> --
>
> >
> > I think EXPORT_SYMBOL_GPL() in omap-usb-tll.c
> > are also unnecessary.
> >
> > Thanks.
> >
> >
> >
> > -- Forwarded message -
> > From: Stephen Rothwell 
> > Date: Mon, May 6, 2019 at 8:51 AM
> > Subject: linux-next: build failure after merge of the kbuild tree
> > To: Masahiro Yamada 
> > Cc: Linux Next Mailing List , Linux Kernel
> > Mailing List , Alexey Gladkov
> > , Keshava Munegowda ,
> > Samuel Ortiz 
> >
> >
> > Hi Masahiro,
> >
> > After merging the kbuild tree, today's linux-next build (arm
> > multi_v7_defconfig) failed like this:
> >
> > In file included from include/linux/module.h:18,
> >  from drivers/mfd/omap-usb-tll.c:21:
> > drivers/mfd/omap-usb-tll.c:462:26: error: expected ',' or ';' before
> > 'USBHS_DRIVER_NAME'
> >  MODULE_ALIAS("platform:" USBHS_DRIVER_NAME);
> >   ^
> > include/linux/moduleparam.h:26:47: note: in definition of macro 
> > '__MODULE_INFO'
> >= __MODULE_INFO_PREFIX __stringify(tag) "=" info
> >^~~~
> > include/linux/module.h:164:30: note: in expansion of macro 'MODULE_INFO'
> >  #define MODULE_ALIAS(_alias) MODULE_INFO(alias, _alias)
> >   ^~~
> > drivers/mfd/omap-usb-tll.c:462:1: note: in expansion of macro 'MODULE_ALIAS'
> >  MODULE_ALIAS("platform:" USBHS_DRIVER_NAME);
> >  ^~~~
> >
> > Caused by commit
> >
> >   6a26793a7891 ("moduleparam: Save information about built-in modules
> > in separate file")
> >
> > USBHS_DRIVER_NAME is not defined and this kbuild tree change has
> > exposed it. It has been this way since commit
> >
> >   16fa3dc75c22 ("mfd: omap-usb-tll: HOST TLL platform driver")
> >
> > From v3.7-rc1 in 2012.
> >
> > I have applied the following patch for today.
> >
>

Re: Fwd: linux-next: build failure after merge of the kbuild tree

2019-05-05 Thread Paul Gortmaker

[Fwd: linux-next: build failure after merge of the kbuild tree] On 06/05/2019 
(Mon 11:19) Masahiro Yamada wrote:

> Hi Paul,
> 
> In today's linux-next build testing,
> more "make ... explicitly non-modular"
> candidates showed up.
> 

Hi Masahiro,

I am not 100% clear on what you are asking me.  There are lots and lots
of these in the kernel many fixed, and many remain unfortunately.

> arch/arm/plat-omap/dma.c
> drivers/clocksource/timer-ti-dm.c
> drivers/mfd/omap-usb-host.c
> drivers/mfd/omap-usb-tll.c

None of these are "new".  I just checked, and I have had patches for all
these for a long time, in my personal queue, found by my audits.

> Would you send patches?

It isn't that simple.  I wish it was.  Some subsystem maintainers are
glad to take the patches, and some think they are a waste of time and
reject them immediately.  Some I've sent just simply get "crickets".

What that means is, that I need to look at each maintainer's
requirements, and ensure the patch and commit log are matching
expectatins - I will not just spam out hundreds of patches across all
subsystems.  Anyone who has spent considerable time in linux development
knows that is a recipe for failure.

So I need to work across each subsystem - one at a time, with their
individual maintainer requirements in mind, and if you look at git
history, you will see that has been what I've tried to do when I had
free time to work on fixing these across the whole linux tree.

But fortunately, none of these represent a CVE/security issue, so I've
never had a reason to try and pretend there was any reason for an
immediate fix/merge - they just represent a better attention to detail
in the code we merge and support that I'd like to see happen tree-wide.

I appreciate that you are also interested in seeing all these fixed, and
I also wish they could all be solved in one version, but unfortunately I
don't think that is pragmatic.  So in the meantime, I will continue to
chip away at things when we are early in the dev cycle and not starting
the two week merge window, as we are just now.

Thanks,
Paul.
--

> 
> I think EXPORT_SYMBOL_GPL() in omap-usb-tll.c
> are also unnecessary.
> 
> Thanks.
> 
> 
> 
> -- Forwarded message -----
> From: Stephen Rothwell 
> Date: Mon, May 6, 2019 at 8:51 AM
> Subject: linux-next: build failure after merge of the kbuild tree
> To: Masahiro Yamada 
> Cc: Linux Next Mailing List , Linux Kernel
> Mailing List , Alexey Gladkov
> , Keshava Munegowda ,
> Samuel Ortiz 
> 
> 
> Hi Masahiro,
> 
> After merging the kbuild tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
> 
> In file included from include/linux/module.h:18,
>  from drivers/mfd/omap-usb-tll.c:21:
> drivers/mfd/omap-usb-tll.c:462:26: error: expected ',' or ';' before
> 'USBHS_DRIVER_NAME'
>  MODULE_ALIAS("platform:" USBHS_DRIVER_NAME);
>   ^
> include/linux/moduleparam.h:26:47: note: in definition of macro 
> '__MODULE_INFO'
>= __MODULE_INFO_PREFIX __stringify(tag) "=" info
>^~~~
> include/linux/module.h:164:30: note: in expansion of macro 'MODULE_INFO'
>  #define MODULE_ALIAS(_alias) MODULE_INFO(alias, _alias)
>   ^~~
> drivers/mfd/omap-usb-tll.c:462:1: note: in expansion of macro 'MODULE_ALIAS'
>  MODULE_ALIAS("platform:" USBHS_DRIVER_NAME);
>  ^~~~
> 
> Caused by commit
> 
>   6a26793a7891 ("moduleparam: Save information about built-in modules
> in separate file")
> 
> USBHS_DRIVER_NAME is not defined and this kbuild tree change has
> exposed it. It has been this way since commit
> 
>   16fa3dc75c22 ("mfd: omap-usb-tll: HOST TLL platform driver")
> 
> From v3.7-rc1 in 2012.
> 
> I have applied the following patch for today.
> 
> From: Stephen Rothwell 
> Date: Mon, 6 May 2019 09:39:14 +1000
> Subject: [PATCH] mfd: omap: remove unused MODULE_ALIAS from omap-usb-tll.c
> 
> USBHS_DRIVER_NAME has never been defined, so this cannot have ever
> been used.
> 
> Signed-off-by: Stephen Rothwell 
> ---
>  drivers/mfd/omap-usb-tll.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mfd/omap-usb-tll.c b/drivers/mfd/omap-usb-tll.c
> index 446713dbee27..1cc8937e8bec 100644
> --- a/drivers/mfd/omap-usb-tll.c
> +++ b/drivers/mfd/omap-usb-tll.c
> @@ -459,7 +459,7 @@ EXPORT_SYMBOL_GPL(omap_tll_disable);
> 
>  MODULE_AUTHOR("Keshava Munegowda ");
>  MODULE_AUTHOR("Roger Quadros ");
> -MODULE_ALIAS("platform:" USBHS_DRIVER_NAME);
> +// MODULE_ALIAS("platform:" USBHS_DRIVER_NAME);
>  MODULE_LICENSE("GPL v2");
>  MODULE_DESCRIPTION("usb tll driver for TI OMAP EHCI and OHCI controllers");
> 
> --
> 2.20.1
> 
> --
> Cheers,
> Stephen Rothwell
> 
> 
> -- 
> Best Regards
> Masahiro Yamada

Fwd: linux-next: build failure after merge of the kbuild tree

2019-05-05 Thread Masahiro Yamada

Hi Paul,

In today's linux-next build testing,
more "make ... explicitly non-modular"
candidates showed up.


arch/arm/plat-omap/dma.c
drivers/clocksource/timer-ti-dm.c
drivers/mfd/omap-usb-host.c
drivers/mfd/omap-usb-tll.c

Would you send patches?

I think EXPORT_SYMBOL_GPL() in omap-usb-tll.c
are also unnecessary.

Thanks.



-- Forwarded message -
From: Stephen Rothwell 
Date: Mon, May 6, 2019 at 8:51 AM
Subject: linux-next: build failure after merge of the kbuild tree
To: Masahiro Yamada 
Cc: Linux Next Mailing List , Linux Kernel
Mailing List , Alexey Gladkov
, Keshava Munegowda ,
Samuel Ortiz 


Hi Masahiro,

After merging the kbuild tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

In file included from include/linux/module.h:18,
 from drivers/mfd/omap-usb-tll.c:21:
drivers/mfd/omap-usb-tll.c:462:26: error: expected ',' or ';' before
'USBHS_DRIVER_NAME'
 MODULE_ALIAS("platform:" USBHS_DRIVER_NAME);
  ^
include/linux/moduleparam.h:26:47: note: in definition of macro '__MODULE_INFO'
   = __MODULE_INFO_PREFIX __stringify(tag) "=" info
   ^~~~
include/linux/module.h:164:30: note: in expansion of macro 'MODULE_INFO'
 #define MODULE_ALIAS(_alias) MODULE_INFO(alias, _alias)
  ^~~
drivers/mfd/omap-usb-tll.c:462:1: note: in expansion of macro 'MODULE_ALIAS'
 MODULE_ALIAS("platform:" USBHS_DRIVER_NAME);
 ^~~~

Caused by commit

  6a26793a7891 ("moduleparam: Save information about built-in modules
in separate file")

USBHS_DRIVER_NAME is not defined and this kbuild tree change has
exposed it. It has been this way since commit

  16fa3dc75c22 ("mfd: omap-usb-tll: HOST TLL platform driver")

>From v3.7-rc1 in 2012.

I have applied the following patch for today.

From: Stephen Rothwell 
Date: Mon, 6 May 2019 09:39:14 +1000
Subject: [PATCH] mfd: omap: remove unused MODULE_ALIAS from omap-usb-tll.c

USBHS_DRIVER_NAME has never been defined, so this cannot have ever
been used.

Signed-off-by: Stephen Rothwell 
---
 drivers/mfd/omap-usb-tll.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mfd/omap-usb-tll.c b/drivers/mfd/omap-usb-tll.c
index 446713dbee27..1cc8937e8bec 100644
--- a/drivers/mfd/omap-usb-tll.c
+++ b/drivers/mfd/omap-usb-tll.c
@@ -459,7 +459,7 @@ EXPORT_SYMBOL_GPL(omap_tll_disable);

 MODULE_AUTHOR("Keshava Munegowda ");
 MODULE_AUTHOR("Roger Quadros ");
-MODULE_ALIAS("platform:" USBHS_DRIVER_NAME);
+// MODULE_ALIAS("platform:" USBHS_DRIVER_NAME);
 MODULE_LICENSE("GPL v2");
 MODULE_DESCRIPTION("usb tll driver for TI OMAP EHCI and OHCI controllers");

--
2.20.1

--
Cheers,
Stephen Rothwell


-- 
Best Regards
Masahiro Yamada


noname
Description: PGP signature

linux-next: build failure after merge of the kbuild tree

2019-05-05 Thread Stephen Rothwell

Hi Masahiro,

After merging the kbuild tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

In file included from include/linux/module.h:18,
 from drivers/mfd/omap-usb-tll.c:21:
drivers/mfd/omap-usb-tll.c:462:26: error: expected ',' or ';' before 
'USBHS_DRIVER_NAME'
 MODULE_ALIAS("platform:" USBHS_DRIVER_NAME);
  ^
include/linux/moduleparam.h:26:47: note: in definition of macro '__MODULE_INFO'
   = __MODULE_INFO_PREFIX __stringify(tag) "=" info
   ^~~~
include/linux/module.h:164:30: note: in expansion of macro 'MODULE_INFO'
 #define MODULE_ALIAS(_alias) MODULE_INFO(alias, _alias)
  ^~~
drivers/mfd/omap-usb-tll.c:462:1: note: in expansion of macro 'MODULE_ALIAS'
 MODULE_ALIAS("platform:" USBHS_DRIVER_NAME);
 ^~~~

Caused by commit

  6a26793a7891 ("moduleparam: Save information about built-in modules in 
separate file")

USBHS_DRIVER_NAME is not defined and this kbuild tree change has
exposed it. It has been this way since commit

  16fa3dc75c22 ("mfd: omap-usb-tll: HOST TLL platform driver")

From v3.7-rc1 in 2012.

I have applied the following patch for today.

From: Stephen Rothwell 
Date: Mon, 6 May 2019 09:39:14 +1000
Subject: [PATCH] mfd: omap: remove unused MODULE_ALIAS from omap-usb-tll.c

USBHS_DRIVER_NAME has never been defined, so this cannot have ever
been used.

Signed-off-by: Stephen Rothwell 
---
 drivers/mfd/omap-usb-tll.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mfd/omap-usb-tll.c b/drivers/mfd/omap-usb-tll.c
index 446713dbee27..1cc8937e8bec 100644
--- a/drivers/mfd/omap-usb-tll.c
+++ b/drivers/mfd/omap-usb-tll.c
@@ -459,7 +459,7 @@ EXPORT_SYMBOL_GPL(omap_tll_disable);
 
 MODULE_AUTHOR("Keshava Munegowda ");
 MODULE_AUTHOR("Roger Quadros ");
-MODULE_ALIAS("platform:" USBHS_DRIVER_NAME);
+// MODULE_ALIAS("platform:" USBHS_DRIVER_NAME);
 MODULE_LICENSE("GPL v2");
 MODULE_DESCRIPTION("usb tll driver for TI OMAP EHCI and OHCI controllers");
 
-- 
2.20.1

-- 
Cheers,
Stephen Rothwell


pgpQ3I18Zg5LI.pgp
Description: OpenPGP digital signature

linux-next: build failure after merge of the kbuild tree

2019-05-05 Thread Stephen Rothwell

Hi Masahiro,

After merging the kbuild tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

In file included from include/linux/module.h:18,
 from drivers/clocksource/timer-ti-dm.c:40:
drivers/clocksource/timer-ti-dm.c:973:26: error: expected ',' or ';' before 
'DRIVER_NAME'
 MODULE_ALIAS("platform:" DRIVER_NAME);
  ^~~
include/linux/moduleparam.h:26:47: note: in definition of macro '__MODULE_INFO'
   = __MODULE_INFO_PREFIX __stringify(tag) "=" info
   ^~~~
include/linux/module.h:164:30: note: in expansion of macro 'MODULE_INFO'
 #define MODULE_ALIAS(_alias) MODULE_INFO(alias, _alias)
  ^~~
drivers/clocksource/timer-ti-dm.c:973:1: note: in expansion of macro 
'MODULE_ALIAS'
 MODULE_ALIAS("platform:" DRIVER_NAME);
 ^~~~

Caused by commit

  6a26793a7891 ("moduleparam: Save information about built-in modules in 
separate file")

DRIVER_NAME is not defined and this kbuild tree change has exposed it.
It has been this way since commit

  df28472a1b28 ("ARM: OMAP: dmtimer: platform driver")

From v3.2-rc1 in 2011.

I have applied the following patch for today.

From: Stephen Rothwell 
Date: Mon, 6 May 2019 09:26:24 +1000
Subject: [PATCH] arm: omap: remove unused MODULE_ALIAS from timer-ti-dm.c

DRIVER_NAME has never been defined, so this cannot have ever been used.

Signed-off-by: Stephen Rothwell 
---
 drivers/clocksource/timer-ti-dm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clocksource/timer-ti-dm.c 
b/drivers/clocksource/timer-ti-dm.c
index ee8ec5a8cb16..b357bd56ba63 100644
--- a/drivers/clocksource/timer-ti-dm.c
+++ b/drivers/clocksource/timer-ti-dm.c
@@ -970,5 +970,5 @@ module_platform_driver(omap_dm_timer_driver);
 
 MODULE_DESCRIPTION("OMAP Dual-Mode Timer Driver");
 MODULE_LICENSE("GPL");
-MODULE_ALIAS("platform:" DRIVER_NAME);
+// MODULE_ALIAS("platform:" DRIVER_NAME);
 MODULE_AUTHOR("Texas Instruments Inc");
-- 
2.20.1

-- 
Cheers,
Stephen Rothwell


pgpnsnwgkJ6cu.pgp
Description: OpenPGP digital signature

linux-next: build failure after merge of the kbuild tree

2019-05-05 Thread Stephen Rothwell

Hi Masahiro,

After merging the kbuild tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

In file included from include/linux/module.h:18,
 from arch/arm/plat-omap/dma.c:28:
arch/arm/plat-omap/dma.c:1452:26: error: expected ',' or ';' before 
'DRIVER_NAME'
 MODULE_ALIAS("platform:" DRIVER_NAME);
  ^~~
include/linux/moduleparam.h:26:47: note: in definition of macro '__MODULE_INFO'
   = __MODULE_INFO_PREFIX __stringify(tag) "=" info
   ^~~~
include/linux/module.h:164:30: note: in expansion of macro 'MODULE_INFO'
 #define MODULE_ALIAS(_alias) MODULE_INFO(alias, _alias)
  ^~~
arch/arm/plat-omap/dma.c:1452:1: note: in expansion of macro 'MODULE_ALIAS'
 MODULE_ALIAS("platform:" DRIVER_NAME);
 ^~~~

Presumably caused by commit

  6a26793a7891 ("moduleparam: Save information about built-in modules in 
separate file")

(since that is the only change from Friday, I thnk)

DRIVER_NAME is not defined and this kbuild tree change has exposed it.  It has 
been this way since commit

  f31cc9622d75 ("OMAP: DMA: Convert DMA library into platform driver")

From v2.6.38-rc1 in 2012.

I have applied the following patch for today.

From: Stephen Rothwell 
Date: Mon, 6 May 2019 08:35:02 +1000
Subject: [PATCH] arm: omap: remove unused MODULE_ALIAS from dma.c

DRIVER_NAME has nevern been defined, so this cannot have ever been used.

Signed-off-by: Stephen Rothwell 
---
 arch/arm/plat-omap/dma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/plat-omap/dma.c b/arch/arm/plat-omap/dma.c
index d4012d6c0dcb..4c6d9f4b43b7 100644
--- a/arch/arm/plat-omap/dma.c
+++ b/arch/arm/plat-omap/dma.c
@@ -1449,7 +1449,7 @@ static void __exit omap_system_dma_exit(void)
 
 MODULE_DESCRIPTION("OMAP SYSTEM DMA DRIVER");
 MODULE_LICENSE("GPL");
-MODULE_ALIAS("platform:" DRIVER_NAME);
+// MODULE_ALIAS("platform:" DRIVER_NAME);
 MODULE_AUTHOR("Texas Instruments Inc");
 
 /*
-- 
2.20.1

-- 
Cheers,
Stephen Rothwell


pgpbfmyLrZasM.pgp
Description: OpenPGP digital signature

Re: linux-next: build failure after merge of the kbuild tree

2018-08-23 Thread Masahiro Yamada

Hi Stephen,

2018-08-23 7:35 GMT+09:00 Stephen Rothwell :
> Hi Masahiro,
>
> After merging the kbuild tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
>
> ld: failed to merge target specific data of file drivers/input/mouse/alps.o
> ld: drivers/input/mouse/byd.o: compiled for a big endian system and target is 
> little endian
> ld: failed to merge target specific data of file drivers/input/mouse/byd.o
>
> and many, many more like this.
>
> Sorry, I can't easily tell what caused this.
>
> I have used the kbuild tree from next-20180822 for today.



Sorry, will fix.

I missed to change link-vmlinux.sh




diff --git a/scripts/link-vmlinux.sh b/scripts/link-vmlinux.sh
index 4bf811c..c8cf453 100755
--- a/scripts/link-vmlinux.sh
+++ b/scripts/link-vmlinux.sh
@@ -75,7 +75,7 @@ modpost_link()
${KBUILD_VMLINUX_LIBS}  \
--end-group"

-   ${LD} ${LDFLAGS} -r -o ${1} ${objects}
+   ${LD} ${KBUILD_LDFLAGS} -r -o ${1} ${objects}
 }

 # Link of vmlinux
@@ -95,7 +95,7 @@ vmlinux_link()
--end-group \
${1}"

-   ${LD} ${LDFLAGS} ${LDFLAGS_vmlinux} -o ${2} \
+   ${LD} ${KBUILD_LDFLAGS} ${LDFLAGS_vmlinux} -o ${2}  \
-T ${lds} ${objects}
else
objects="-Wl,--whole-archive\



-- 
Best Regards
Masahiro Yamada

Re: linux-next: build failure after merge of the kbuild tree

2018-08-23 Thread Masahiro Yamada

Hi Stephen,

2018-08-23 7:35 GMT+09:00 Stephen Rothwell :
> Hi Masahiro,
>
> After merging the kbuild tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
>
> ld: failed to merge target specific data of file drivers/input/mouse/alps.o
> ld: drivers/input/mouse/byd.o: compiled for a big endian system and target is 
> little endian
> ld: failed to merge target specific data of file drivers/input/mouse/byd.o
>
> and many, many more like this.
>
> Sorry, I can't easily tell what caused this.
>
> I have used the kbuild tree from next-20180822 for today.



Sorry, will fix.

I missed to change link-vmlinux.sh




diff --git a/scripts/link-vmlinux.sh b/scripts/link-vmlinux.sh
index 4bf811c..c8cf453 100755
--- a/scripts/link-vmlinux.sh
+++ b/scripts/link-vmlinux.sh
@@ -75,7 +75,7 @@ modpost_link()
${KBUILD_VMLINUX_LIBS}  \
--end-group"

-   ${LD} ${LDFLAGS} -r -o ${1} ${objects}
+   ${LD} ${KBUILD_LDFLAGS} -r -o ${1} ${objects}
 }

 # Link of vmlinux
@@ -95,7 +95,7 @@ vmlinux_link()
--end-group \
${1}"

-   ${LD} ${LDFLAGS} ${LDFLAGS_vmlinux} -o ${2} \
+   ${LD} ${KBUILD_LDFLAGS} ${LDFLAGS_vmlinux} -o ${2}  \
-T ${lds} ${objects}
else
objects="-Wl,--whole-archive\



-- 
Best Regards
Masahiro Yamada

linux-next: build failure after merge of the kbuild tree

2018-08-22 Thread Stephen Rothwell

Hi Masahiro,

After merging the kbuild tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

ld: failed to merge target specific data of file drivers/input/mouse/alps.o
ld: drivers/input/mouse/byd.o: compiled for a big endian system and target is 
little endian
ld: failed to merge target specific data of file drivers/input/mouse/byd.o

and many, many more like this.

Sorry, I can't easily tell what caused this.

I have used the kbuild tree from next-20180822 for today.

-- 
Cheers,
Stephen Rothwell


pgpsMUCqr0DYj.pgp
Description: OpenPGP digital signature

linux-next: build failure after merge of the kbuild tree

2018-08-22 Thread Stephen Rothwell

Hi Masahiro,

After merging the kbuild tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

ld: failed to merge target specific data of file drivers/input/mouse/alps.o
ld: drivers/input/mouse/byd.o: compiled for a big endian system and target is 
little endian
ld: failed to merge target specific data of file drivers/input/mouse/byd.o

and many, many more like this.

Sorry, I can't easily tell what caused this.

I have used the kbuild tree from next-20180822 for today.

-- 
Cheers,
Stephen Rothwell


pgpsMUCqr0DYj.pgp
Description: OpenPGP digital signature

Re: linux-next: build failure after merge of the kbuild tree

2018-05-29 Thread Masahiro Yamada

2018-05-30 10:29 GMT+09:00 Stephen Rothwell :
> Hi Masahiro,
>
> After merging the kbuild tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
>
> make was continually spawning test compiles.
>
> I used the kbuild tree from next-20180529 for today.
>
> A (partial) strace seemed to show that it was testing for compiler flags
> (some more than once).
>

My bad - I need to insert some patches from Nicholas Piggin.

I will fix it for tomorrows' release.

Thanks for the report!




-- 
Best Regards
Masahiro Yamada

Re: linux-next: build failure after merge of the kbuild tree

2018-05-29 Thread Masahiro Yamada

2018-05-30 10:29 GMT+09:00 Stephen Rothwell :
> Hi Masahiro,
>
> After merging the kbuild tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
>
> make was continually spawning test compiles.
>
> I used the kbuild tree from next-20180529 for today.
>
> A (partial) strace seemed to show that it was testing for compiler flags
> (some more than once).
>

My bad - I need to insert some patches from Nicholas Piggin.

I will fix it for tomorrows' release.

Thanks for the report!




-- 
Best Regards
Masahiro Yamada

linux-next: build failure after merge of the kbuild tree

2018-05-29 Thread Stephen Rothwell

Hi Masahiro,

After merging the kbuild tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

make was continually spawning test compiles.

I used the kbuild tree from next-20180529 for today.

A (partial) strace seemed to show that it was testing for compiler flags
(some more than once).

-- 
Cheers,
Stephen Rothwell


pgpPvPbVmnscs.pgp
Description: OpenPGP digital signature

linux-next: build failure after merge of the kbuild tree

2018-05-29 Thread Stephen Rothwell

Hi Masahiro,

After merging the kbuild tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

make was continually spawning test compiles.

I used the kbuild tree from next-20180529 for today.

A (partial) strace seemed to show that it was testing for compiler flags
(some more than once).

-- 
Cheers,
Stephen Rothwell


pgpPvPbVmnscs.pgp
Description: OpenPGP digital signature

Re: linux-next: build failure after merge of the kbuild tree

2018-05-17 Thread Masahiro Yamada

Stephen,

2018-05-16 16:26 GMT+09:00 Stephen Rothwell :
> Hi Masahiro,
>
> On Wed, 16 May 2018 15:01:38 +0900 Masahiro Yamada 
>  wrote:
>>
>> How should I handle your fix-up?
>>
>> May I squash into the original one if you ack to do it,
>> or is it better to keep it as a separate patch?
>
> Either way is fine by me, but the former reduces the bisection gap.  So
> it depends on whether you want to rebase your tree or not.
>
> Acked-by: Stephen Rothwell 
>

Thanks!  Squashed now.




> --
> Cheers,
> Stephen Rothwell



-- 
Best Regards
Masahiro Yamada

Re: linux-next: build failure after merge of the kbuild tree

2018-05-17 Thread Masahiro Yamada

Stephen,

2018-05-16 16:26 GMT+09:00 Stephen Rothwell :
> Hi Masahiro,
>
> On Wed, 16 May 2018 15:01:38 +0900 Masahiro Yamada 
>  wrote:
>>
>> How should I handle your fix-up?
>>
>> May I squash into the original one if you ack to do it,
>> or is it better to keep it as a separate patch?
>
> Either way is fine by me, but the former reduces the bisection gap.  So
> it depends on whether you want to rebase your tree or not.
>
> Acked-by: Stephen Rothwell 
>

Thanks!  Squashed now.




> --
> Cheers,
> Stephen Rothwell



-- 
Best Regards
Masahiro Yamada

Re: linux-next: build failure after merge of the kbuild tree

2018-05-16 Thread Stephen Rothwell

Hi Masahiro,

On Wed, 16 May 2018 15:01:38 +0900 Masahiro Yamada 
 wrote:
>
> How should I handle your fix-up?
> 
> May I squash into the original one if you ack to do it,
> or is it better to keep it as a separate patch?

Either way is fine by me, but the former reduces the bisection gap.  So
it depends on whether you want to rebase your tree or not.

Acked-by: Stephen Rothwell 

-- 
Cheers,
Stephen Rothwell

pgpRBPHlv4XQw.pgp
Description: OpenPGP digital signature

Re: linux-next: build failure after merge of the kbuild tree

2018-05-16 Thread Stephen Rothwell

Hi Masahiro,

On Wed, 16 May 2018 15:01:38 +0900 Masahiro Yamada 
 wrote:
>
> How should I handle your fix-up?
> 
> May I squash into the original one if you ack to do it,
> or is it better to keep it as a separate patch?

Either way is fine by me, but the former reduces the bisection gap.  So
it depends on whether you want to rebase your tree or not.

Acked-by: Stephen Rothwell 

-- 
Cheers,
Stephen Rothwell

pgpRBPHlv4XQw.pgp
Description: OpenPGP digital signature

Re: linux-next: build failure after merge of the kbuild tree

2018-05-16 Thread Masahiro Yamada

Stephen,


2018-05-15 14:50 GMT+09:00 Stephen Rothwell :
> Hi Masahiro,
>
> After merging the kbuild tree, today's linux-next build (x86_64
> modules_install) failed like this:
>
> Usage: scripts/depmod.sh /sbin/depmod  
> Makefile:1314: recipe for target '_modinst_post' failed
>
> Caused by commit
>
>   ea7ad9856a2c ("depmod.sh: remove symbol prefix support")
>
> I added the following fix for today:
>
> From: Stephen Rothwell 
> Date: Tue, 15 May 2018 15:47:33 +1000
> Subject: [PATCH] depmod.sh: fix syntax check and uage message
>
> fixes: ea7ad9856a2c ("depmod.sh: remove symbol prefix support")
> Signed-off-by: Stephen Rothwell 
> ---


Thanks for catching this.

How should I handle your fix-up?

May I squash into the original one if you ack to do it,
or is it better to keep it as a separate patch?




>  scripts/depmod.sh | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/depmod.sh b/scripts/depmod.sh
> index 421d1aa01304..1a6f85e0e6e1 100755
> --- a/scripts/depmod.sh
> +++ b/scripts/depmod.sh
> @@ -3,8 +3,8 @@
>  #
>  # A depmod wrapper used by the toplevel Makefile
>
> -if test $# -ne 3; then
> -   echo "Usage: $0 /sbin/depmod  " >&2
> +if test $# -ne 2; then
> +   echo "Usage: $0 /sbin/depmod " >&2
> exit 1
>  fi
>  DEPMOD=$1
> --
> 2.17.0
>
> --
> Cheers,
> Stephen Rothwell



-- 
Best Regards
Masahiro Yamada

Re: linux-next: build failure after merge of the kbuild tree

2018-05-16 Thread Masahiro Yamada

Stephen,


2018-05-15 14:50 GMT+09:00 Stephen Rothwell :
> Hi Masahiro,
>
> After merging the kbuild tree, today's linux-next build (x86_64
> modules_install) failed like this:
>
> Usage: scripts/depmod.sh /sbin/depmod  
> Makefile:1314: recipe for target '_modinst_post' failed
>
> Caused by commit
>
>   ea7ad9856a2c ("depmod.sh: remove symbol prefix support")
>
> I added the following fix for today:
>
> From: Stephen Rothwell 
> Date: Tue, 15 May 2018 15:47:33 +1000
> Subject: [PATCH] depmod.sh: fix syntax check and uage message
>
> fixes: ea7ad9856a2c ("depmod.sh: remove symbol prefix support")
> Signed-off-by: Stephen Rothwell 
> ---


Thanks for catching this.

How should I handle your fix-up?

May I squash into the original one if you ack to do it,
or is it better to keep it as a separate patch?




>  scripts/depmod.sh | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/depmod.sh b/scripts/depmod.sh
> index 421d1aa01304..1a6f85e0e6e1 100755
> --- a/scripts/depmod.sh
> +++ b/scripts/depmod.sh
> @@ -3,8 +3,8 @@
>  #
>  # A depmod wrapper used by the toplevel Makefile
>
> -if test $# -ne 3; then
> -   echo "Usage: $0 /sbin/depmod  " >&2
> +if test $# -ne 2; then
> +   echo "Usage: $0 /sbin/depmod " >&2
> exit 1
>  fi
>  DEPMOD=$1
> --
> 2.17.0
>
> --
> Cheers,
> Stephen Rothwell



-- 
Best Regards
Masahiro Yamada

linux-next: build failure after merge of the kbuild tree

2018-05-14 Thread Stephen Rothwell

Hi Masahiro,

After merging the kbuild tree, today's linux-next build (x86_64
modules_install) failed like this:

Usage: scripts/depmod.sh /sbin/depmod  
Makefile:1314: recipe for target '_modinst_post' failed

Caused by commit

  ea7ad9856a2c ("depmod.sh: remove symbol prefix support")

I added the following fix for today:

From: Stephen Rothwell 
Date: Tue, 15 May 2018 15:47:33 +1000
Subject: [PATCH] depmod.sh: fix syntax check and uage message

fixes: ea7ad9856a2c ("depmod.sh: remove symbol prefix support")
Signed-off-by: Stephen Rothwell 
---
 scripts/depmod.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/scripts/depmod.sh b/scripts/depmod.sh
index 421d1aa01304..1a6f85e0e6e1 100755
--- a/scripts/depmod.sh
+++ b/scripts/depmod.sh
@@ -3,8 +3,8 @@
 #
 # A depmod wrapper used by the toplevel Makefile
 
-if test $# -ne 3; then
-   echo "Usage: $0 /sbin/depmod  " >&2
+if test $# -ne 2; then
+   echo "Usage: $0 /sbin/depmod " >&2
exit 1
 fi
 DEPMOD=$1
-- 
2.17.0

-- 
Cheers,
Stephen Rothwell


pgpcyekDFttro.pgp
Description: OpenPGP digital signature

linux-next: build failure after merge of the kbuild tree

2018-05-14 Thread Stephen Rothwell

Hi Masahiro,

After merging the kbuild tree, today's linux-next build (x86_64
modules_install) failed like this:

Usage: scripts/depmod.sh /sbin/depmod  
Makefile:1314: recipe for target '_modinst_post' failed

Caused by commit

  ea7ad9856a2c ("depmod.sh: remove symbol prefix support")

I added the following fix for today:

From: Stephen Rothwell 
Date: Tue, 15 May 2018 15:47:33 +1000
Subject: [PATCH] depmod.sh: fix syntax check and uage message

fixes: ea7ad9856a2c ("depmod.sh: remove symbol prefix support")
Signed-off-by: Stephen Rothwell 
---
 scripts/depmod.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/scripts/depmod.sh b/scripts/depmod.sh
index 421d1aa01304..1a6f85e0e6e1 100755
--- a/scripts/depmod.sh
+++ b/scripts/depmod.sh
@@ -3,8 +3,8 @@
 #
 # A depmod wrapper used by the toplevel Makefile
 
-if test $# -ne 3; then
-   echo "Usage: $0 /sbin/depmod  " >&2
+if test $# -ne 2; then
+   echo "Usage: $0 /sbin/depmod " >&2
exit 1
 fi
 DEPMOD=$1
-- 
2.17.0

-- 
Cheers,
Stephen Rothwell


pgpcyekDFttro.pgp
Description: OpenPGP digital signature

Re: linux-next: build failure after merge of the kbuild tree

2018-03-28 Thread Masahiro Yamada

Hi Stephen,

2018-03-29 6:58 GMT+09:00 Stephen Rothwell :
> Hi Masahiro,
>
> After merging the kbuild tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> net/ipv4/netfilter/nf_nat_snmp_basic_main.c:57:10: fatal err
> or: nf_nat_snmp_basic.asn1.h: No such file or directory
>  #include "nf_nat_snmp_basic.asn1.h"
>   ^~
>
> Presuambly caused by commit
>
>   9ee1b1bb8743 ("kbuild: rename *-asn1.[ch] to *.asn1.[ch]")
>
> though I am not sure why it didn't fail yesterday.
>
> I reverted that commit (and the following one because of a conflict)
> for today.
>
> --
> Cheers,
> Stephen Rothwell


Thanks for the report.

I think my patch is just a coincidence.

The netfilter Makefile seems weird.

I queued up the following fix-up to my kbuild tree.
Hopefully linux-next will be OK tomorrow.






commit 28913ee8191adf4bbc01cbfb9ee18cca782ab141
Author: Masahiro Yamada 
Date:   Thu Mar 29 09:24:28 2018 +0900

netfilter: nf_nat_snmp_basic: add correct dependency to Makefile

nf_nat_snmp_basic_main.c includes a generated header, but the
necessary dependency is missing in Makefile. This could cause
build error in parallel building.

Remove a weird line, and add a correct one.

Fixes: cc2d58634e0f ("netfilter: nf_nat_snmp_basic: use asn1
decoder library")
Reported-by: Stephen Rothwell 
Signed-off-by: Masahiro Yamada 

diff --git a/net/ipv4/netfilter/Makefile b/net/ipv4/netfilter/Makefile
index 2dad20e..9bd19cd 100644
--- a/net/ipv4/netfilter/Makefile
+++ b/net/ipv4/netfilter/Makefile
@@ -29,7 +29,7 @@ obj-$(CONFIG_NF_NAT_H323) += nf_nat_h323.o
 obj-$(CONFIG_NF_NAT_PPTP) += nf_nat_pptp.o

 nf_nat_snmp_basic-y := nf_nat_snmp_basic-asn1.o nf_nat_snmp_basic_main.o
-nf_nat_snmp_basic-y : nf_nat_snmp_basic-asn1.h nf_nat_snmp_basic-asn1.c
+$(obj)/nf_nat_snmp_basic_main.o: $(obj)/nf_nat_snmp_basic-asn1.h
 obj-$(CONFIG_NF_NAT_SNMP_BASIC) += nf_nat_snmp_basic.o
 clean-files := nf_nat_snmp_basic-asn1.c nf_nat_snmp_basic-asn1.h



-- 
Best Regards
Masahiro Yamada

Re: linux-next: build failure after merge of the kbuild tree

2018-03-28 Thread Masahiro Yamada

Hi Stephen,

2018-03-29 6:58 GMT+09:00 Stephen Rothwell :
> Hi Masahiro,
>
> After merging the kbuild tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> net/ipv4/netfilter/nf_nat_snmp_basic_main.c:57:10: fatal err
> or: nf_nat_snmp_basic.asn1.h: No such file or directory
>  #include "nf_nat_snmp_basic.asn1.h"
>   ^~
>
> Presuambly caused by commit
>
>   9ee1b1bb8743 ("kbuild: rename *-asn1.[ch] to *.asn1.[ch]")
>
> though I am not sure why it didn't fail yesterday.
>
> I reverted that commit (and the following one because of a conflict)
> for today.
>
> --
> Cheers,
> Stephen Rothwell


Thanks for the report.

I think my patch is just a coincidence.

The netfilter Makefile seems weird.

I queued up the following fix-up to my kbuild tree.
Hopefully linux-next will be OK tomorrow.






commit 28913ee8191adf4bbc01cbfb9ee18cca782ab141
Author: Masahiro Yamada 
Date:   Thu Mar 29 09:24:28 2018 +0900

netfilter: nf_nat_snmp_basic: add correct dependency to Makefile

nf_nat_snmp_basic_main.c includes a generated header, but the
necessary dependency is missing in Makefile. This could cause
build error in parallel building.

Remove a weird line, and add a correct one.

Fixes: cc2d58634e0f ("netfilter: nf_nat_snmp_basic: use asn1
decoder library")
Reported-by: Stephen Rothwell 
Signed-off-by: Masahiro Yamada 

diff --git a/net/ipv4/netfilter/Makefile b/net/ipv4/netfilter/Makefile
index 2dad20e..9bd19cd 100644
--- a/net/ipv4/netfilter/Makefile
+++ b/net/ipv4/netfilter/Makefile
@@ -29,7 +29,7 @@ obj-$(CONFIG_NF_NAT_H323) += nf_nat_h323.o
 obj-$(CONFIG_NF_NAT_PPTP) += nf_nat_pptp.o

 nf_nat_snmp_basic-y := nf_nat_snmp_basic-asn1.o nf_nat_snmp_basic_main.o
-nf_nat_snmp_basic-y : nf_nat_snmp_basic-asn1.h nf_nat_snmp_basic-asn1.c
+$(obj)/nf_nat_snmp_basic_main.o: $(obj)/nf_nat_snmp_basic-asn1.h
 obj-$(CONFIG_NF_NAT_SNMP_BASIC) += nf_nat_snmp_basic.o
 clean-files := nf_nat_snmp_basic-asn1.c nf_nat_snmp_basic-asn1.h



-- 
Best Regards
Masahiro Yamada

linux-next: build failure after merge of the kbuild tree

2018-03-28 Thread Stephen Rothwell

Hi Masahiro,

After merging the kbuild tree, today's linux-next build (x86_64
allmodconfig) failed like this:

net/ipv4/netfilter/nf_nat_snmp_basic_main.c:57:10: fatal err
or: nf_nat_snmp_basic.asn1.h: No such file or directory
 #include "nf_nat_snmp_basic.asn1.h"
  ^~

Presuambly caused by commit

  9ee1b1bb8743 ("kbuild: rename *-asn1.[ch] to *.asn1.[ch]")

though I am not sure why it didn't fail yesterday.

I reverted that commit (and the following one because of a conflict)
for today.

-- 
Cheers,
Stephen Rothwell


pgpoW95zgqEJm.pgp
Description: OpenPGP digital signature

linux-next: build failure after merge of the kbuild tree

2018-03-28 Thread Stephen Rothwell

Hi Masahiro,

After merging the kbuild tree, today's linux-next build (x86_64
allmodconfig) failed like this:

net/ipv4/netfilter/nf_nat_snmp_basic_main.c:57:10: fatal err
or: nf_nat_snmp_basic.asn1.h: No such file or directory
 #include "nf_nat_snmp_basic.asn1.h"
  ^~

Presuambly caused by commit

  9ee1b1bb8743 ("kbuild: rename *-asn1.[ch] to *.asn1.[ch]")

though I am not sure why it didn't fail yesterday.

I reverted that commit (and the following one because of a conflict)
for today.

-- 
Cheers,
Stephen Rothwell


pgpoW95zgqEJm.pgp
Description: OpenPGP digital signature

Re: linux-next: build failure after merge of the kbuild tree

2016-09-22 Thread Michal Marek

On 2016-09-15 08:08, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the dax-misc tree, today's linux-next build (powerpc
> ppc44x_defconfig) failed like this:
> 
> arch/powerpc/kernel/built-in.o: In function `__ksymtab_clear_pages':
> (___ksymtab+clear_pages+0x0): undefined reference to `clear_pages'
> 
> Caused by commit
> 
>   9445aa1a3062 ("ppc: move exports to definitions")
> 
> I applied the following fix patch:
> 
> From: Stephen Rothwell 
> Date: Thu, 15 Sep 2016 16:04:12 +1000
> Subject: [PATCH] ppc: there is no clear_pages to export
> 
> Fixes: 9445aa1a3062 ("ppc: move exports to definitions")
> Signed-off-by: Stephen Rothwell 

Applied to kbuild.git#kbuild now.

Thanks,
Michal

Re: linux-next: build failure after merge of the kbuild tree

2016-09-22 Thread Michal Marek

On 2016-09-15 08:08, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the dax-misc tree, today's linux-next build (powerpc
> ppc44x_defconfig) failed like this:
> 
> arch/powerpc/kernel/built-in.o: In function `__ksymtab_clear_pages':
> (___ksymtab+clear_pages+0x0): undefined reference to `clear_pages'
> 
> Caused by commit
> 
>   9445aa1a3062 ("ppc: move exports to definitions")
> 
> I applied the following fix patch:
> 
> From: Stephen Rothwell 
> Date: Thu, 15 Sep 2016 16:04:12 +1000
> Subject: [PATCH] ppc: there is no clear_pages to export
> 
> Fixes: 9445aa1a3062 ("ppc: move exports to definitions")
> Signed-off-by: Stephen Rothwell 

Applied to kbuild.git#kbuild now.

Thanks,
Michal

linux-next: build failure after merge of the kbuild tree

2016-09-15 Thread Stephen Rothwell

Hi all,

After merging the dax-misc tree, today's linux-next build (powerpc
ppc44x_defconfig) failed like this:

arch/powerpc/kernel/built-in.o: In function `__ksymtab_clear_pages':
(___ksymtab+clear_pages+0x0): undefined reference to `clear_pages'

Caused by commit

  9445aa1a3062 ("ppc: move exports to definitions")

I applied the following fix patch:

From: Stephen Rothwell 
Date: Thu, 15 Sep 2016 16:04:12 +1000
Subject: [PATCH] ppc: there is no clear_pages to export

Fixes: 9445aa1a3062 ("ppc: move exports to definitions")
Signed-off-by: Stephen Rothwell 
---
 arch/powerpc/kernel/misc_32.S | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/powerpc/kernel/misc_32.S b/arch/powerpc/kernel/misc_32.S
index ea26a9181586..f5156105c5f3 100644
--- a/arch/powerpc/kernel/misc_32.S
+++ b/arch/powerpc/kernel/misc_32.S
@@ -453,7 +453,6 @@ END_FTR_SECTION_IFSET(CPU_FTR_COHERENT_ICACHE)
stw r7,8(r3);   \
stw r8,12(r3);  \
stwur9,16(r3)
-EXPORT_SYMBOL(clear_pages)
 
 _GLOBAL(copy_page)
addir3,r3,-4
-- 
2.8.1

-- 
Cheers,
Stephen Rothwell

linux-next: build failure after merge of the kbuild tree

2016-09-15 Thread Stephen Rothwell

Hi all,

After merging the dax-misc tree, today's linux-next build (powerpc
ppc44x_defconfig) failed like this:

arch/powerpc/kernel/built-in.o: In function `__ksymtab_clear_pages':
(___ksymtab+clear_pages+0x0): undefined reference to `clear_pages'

Caused by commit

  9445aa1a3062 ("ppc: move exports to definitions")

I applied the following fix patch:

From: Stephen Rothwell 
Date: Thu, 15 Sep 2016 16:04:12 +1000
Subject: [PATCH] ppc: there is no clear_pages to export

Fixes: 9445aa1a3062 ("ppc: move exports to definitions")
Signed-off-by: Stephen Rothwell 
---
 arch/powerpc/kernel/misc_32.S | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/powerpc/kernel/misc_32.S b/arch/powerpc/kernel/misc_32.S
index ea26a9181586..f5156105c5f3 100644
--- a/arch/powerpc/kernel/misc_32.S
+++ b/arch/powerpc/kernel/misc_32.S
@@ -453,7 +453,6 @@ END_FTR_SECTION_IFSET(CPU_FTR_COHERENT_ICACHE)
stw r7,8(r3);   \
stw r8,12(r3);  \
stwur9,16(r3)
-EXPORT_SYMBOL(clear_pages)
 
 _GLOBAL(copy_page)
addir3,r3,-4
-- 
2.8.1

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build failure after merge of the kbuild tree

2016-07-27 Thread Michael Ellerman

Stephen Rothwell  writes:

> Hi Michal,
>
> After merging the kbuild tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
>
...
> arch/powerpc/mm/hash_utils_64.c:929:10: note: in expansion of macro 
> 'IS_ENABLED'
>   else if IS_ENABLED(CONFIG_PPC_NATIVE)
>   ^
> cc1: all warnings being treated as errors
>
> Caused by commit
>
>   7353644fa9df ("powerpc/mm: Fix build break when PPC_NATIVE=n")
>
> from the powerpc tree interacting with commit
>
>   5e8754fd80b0 ("kconfig.h: allow to use IS_{ENABLE,REACHABLE} in macro 
> expansion")
>
> from the kbuild tree.

**expletive deleted**

I was wary of IS_ENABLED(), I should have trusted my instincts.

> I have applied the following fix patch (that should be applied to the
> powerpc tree):

Applied, thanks.

cheers

Re: linux-next: build failure after merge of the kbuild tree

2016-07-27 Thread Michael Ellerman

Stephen Rothwell  writes:

> Hi Michal,
>
> After merging the kbuild tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
>
...
> arch/powerpc/mm/hash_utils_64.c:929:10: note: in expansion of macro 
> 'IS_ENABLED'
>   else if IS_ENABLED(CONFIG_PPC_NATIVE)
>   ^
> cc1: all warnings being treated as errors
>
> Caused by commit
>
>   7353644fa9df ("powerpc/mm: Fix build break when PPC_NATIVE=n")
>
> from the powerpc tree interacting with commit
>
>   5e8754fd80b0 ("kconfig.h: allow to use IS_{ENABLE,REACHABLE} in macro 
> expansion")
>
> from the kbuild tree.

**expletive deleted**

I was wary of IS_ENABLED(), I should have trusted my instincts.

> I have applied the following fix patch (that should be applied to the
> powerpc tree):

Applied, thanks.

cheers

linux-next: build failure after merge of the kbuild tree

2016-07-27 Thread Stephen Rothwell

Hi Michal,

After merging the kbuild tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

In file included from :0:0:
arch/powerpc/mm/hash_utils_64.c: In function 'hash__early_init_mmu':
include/linux/kconfig.h:19:65: error: expected '(' before numeric constant
 #define or(arg1_or_junk, y)  __take_second_arg(arg1_or_junk 1, y)
 ^
include/linux/kconfig.h:7:48: note: in definition of macro '__take_second_arg'
 #define __take_second_arg(__ignored, val, ...) val
^
include/linux/kconfig.h:18:23: note: in expansion of macro 'or'
 #define ___or(x, y)   or(__ARG_PLACEHOLDER_##x, y)
   ^
include/linux/kconfig.h:17:22: note: in expansion of macro '___or'
 #define __or(x, y)   ___or(x, y)   
  ^
include/linux/kconfig.h:65:28: note: in expansion of macro '__or'
 #define IS_ENABLED(option) __or(IS_BUILTIN(option), IS_MODULE(option))
^
arch/powerpc/mm/hash_utils_64.c:929:10: note: in expansion of macro 'IS_ENABLED'
  else if IS_ENABLED(CONFIG_PPC_NATIVE)
  ^
include/linux/kconfig.h:19:65: error: statement with no effect 
[-Werror=unused-value]
 #define or(arg1_or_junk, y)  __take_second_arg(arg1_or_junk 1, y)
 ^
include/linux/kconfig.h:7:48: note: in definition of macro '__take_second_arg'
 #define __take_second_arg(__ignored, val, ...) val
^
include/linux/kconfig.h:18:23: note: in expansion of macro 'or'
 #define ___or(x, y)   or(__ARG_PLACEHOLDER_##x, y)
   ^
include/linux/kconfig.h:17:22: note: in expansion of macro '___or'
 #define __or(x, y)   ___or(x, y)   
  ^
include/linux/kconfig.h:65:28: note: in expansion of macro '__or'
 #define IS_ENABLED(option) __or(IS_BUILTIN(option), IS_MODULE(option))
^
arch/powerpc/mm/hash_utils_64.c:929:10: note: in expansion of macro 'IS_ENABLED'
  else if IS_ENABLED(CONFIG_PPC_NATIVE)
  ^
cc1: all warnings being treated as errors

Caused by commit

  7353644fa9df ("powerpc/mm: Fix build break when PPC_NATIVE=n")

from the powerpc tree interacting with commit

  5e8754fd80b0 ("kconfig.h: allow to use IS_{ENABLE,REACHABLE} in macro 
expansion")

from the kbuild tree.

I have applied the following fix patch (that should be applied to the
powerpc tree):

From: Stephen Rothwell 
Date: Thu, 28 Jul 2016 12:03:25 +1000
Subject: [PATCH] powerpc/mm: parenthesise the if condition

The breakage here used to be hidden by the macro expansion.

Fixes: 7353644fa9df ("powerpc/mm: Fix build break when PPC_NATIVE=n")
Signed-off-by: Stephen Rothwell 
---
 arch/powerpc/mm/hash_utils_64.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/mm/hash_utils_64.c b/arch/powerpc/mm/hash_utils_64.c
index 1ff11c1bb182..b78b5d211278 100644
--- a/arch/powerpc/mm/hash_utils_64.c
+++ b/arch/powerpc/mm/hash_utils_64.c
@@ -926,7 +926,7 @@ void __init hash__early_init_mmu(void)
ps3_early_mm_init();
else if (firmware_has_feature(FW_FEATURE_LPAR))
hpte_init_pseries();
-   else if IS_ENABLED(CONFIG_PPC_NATIVE)
+   else if (IS_ENABLED(CONFIG_PPC_NATIVE))
hpte_init_native();
 
if (!mmu_hash_ops.hpte_insert)
-- 
2.8.1

-- 
Cheers,
Stephen Rothwell

linux-next: build failure after merge of the kbuild tree

2016-07-27 Thread Stephen Rothwell

Hi Michal,

After merging the kbuild tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

In file included from :0:0:
arch/powerpc/mm/hash_utils_64.c: In function 'hash__early_init_mmu':
include/linux/kconfig.h:19:65: error: expected '(' before numeric constant
 #define or(arg1_or_junk, y)  __take_second_arg(arg1_or_junk 1, y)
 ^
include/linux/kconfig.h:7:48: note: in definition of macro '__take_second_arg'
 #define __take_second_arg(__ignored, val, ...) val
^
include/linux/kconfig.h:18:23: note: in expansion of macro 'or'
 #define ___or(x, y)   or(__ARG_PLACEHOLDER_##x, y)
   ^
include/linux/kconfig.h:17:22: note: in expansion of macro '___or'
 #define __or(x, y)   ___or(x, y)   
  ^
include/linux/kconfig.h:65:28: note: in expansion of macro '__or'
 #define IS_ENABLED(option) __or(IS_BUILTIN(option), IS_MODULE(option))
^
arch/powerpc/mm/hash_utils_64.c:929:10: note: in expansion of macro 'IS_ENABLED'
  else if IS_ENABLED(CONFIG_PPC_NATIVE)
  ^
include/linux/kconfig.h:19:65: error: statement with no effect 
[-Werror=unused-value]
 #define or(arg1_or_junk, y)  __take_second_arg(arg1_or_junk 1, y)
 ^
include/linux/kconfig.h:7:48: note: in definition of macro '__take_second_arg'
 #define __take_second_arg(__ignored, val, ...) val
^
include/linux/kconfig.h:18:23: note: in expansion of macro 'or'
 #define ___or(x, y)   or(__ARG_PLACEHOLDER_##x, y)
   ^
include/linux/kconfig.h:17:22: note: in expansion of macro '___or'
 #define __or(x, y)   ___or(x, y)   
  ^
include/linux/kconfig.h:65:28: note: in expansion of macro '__or'
 #define IS_ENABLED(option) __or(IS_BUILTIN(option), IS_MODULE(option))
^
arch/powerpc/mm/hash_utils_64.c:929:10: note: in expansion of macro 'IS_ENABLED'
  else if IS_ENABLED(CONFIG_PPC_NATIVE)
  ^
cc1: all warnings being treated as errors

Caused by commit

  7353644fa9df ("powerpc/mm: Fix build break when PPC_NATIVE=n")

from the powerpc tree interacting with commit

  5e8754fd80b0 ("kconfig.h: allow to use IS_{ENABLE,REACHABLE} in macro 
expansion")

from the kbuild tree.

I have applied the following fix patch (that should be applied to the
powerpc tree):

From: Stephen Rothwell 
Date: Thu, 28 Jul 2016 12:03:25 +1000
Subject: [PATCH] powerpc/mm: parenthesise the if condition

The breakage here used to be hidden by the macro expansion.

Fixes: 7353644fa9df ("powerpc/mm: Fix build break when PPC_NATIVE=n")
Signed-off-by: Stephen Rothwell 
---
 arch/powerpc/mm/hash_utils_64.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/mm/hash_utils_64.c b/arch/powerpc/mm/hash_utils_64.c
index 1ff11c1bb182..b78b5d211278 100644
--- a/arch/powerpc/mm/hash_utils_64.c
+++ b/arch/powerpc/mm/hash_utils_64.c
@@ -926,7 +926,7 @@ void __init hash__early_init_mmu(void)
ps3_early_mm_init();
else if (firmware_has_feature(FW_FEATURE_LPAR))
hpte_init_pseries();
-   else if IS_ENABLED(CONFIG_PPC_NATIVE)
+   else if (IS_ENABLED(CONFIG_PPC_NATIVE))
hpte_init_native();
 
if (!mmu_hash_ops.hpte_insert)
-- 
2.8.1

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build failure after merge of the kbuild tree

2016-03-19 Thread Michal Marek

On 2016-03-16 12:29, Stephen Rothwell wrote:
> Hi Michal,
> 
> On Wed, 16 Mar 2016 08:56:50 +0100 Michal Marek  wrote:
>>
>> Right. Stephen, could you perhaps move the kbuild tree down in your list
>> a bit, so that the fixes are present?
> 
> Done.
> 
> Now you just need to make sure Linus gets them in the right order :-)

That's the plan :).

Michal

Re: linux-next: build failure after merge of the kbuild tree

2016-03-19 Thread Michal Marek

On 2016-03-16 12:29, Stephen Rothwell wrote:
> Hi Michal,
> 
> On Wed, 16 Mar 2016 08:56:50 +0100 Michal Marek  wrote:
>>
>> Right. Stephen, could you perhaps move the kbuild tree down in your list
>> a bit, so that the fixes are present?
> 
> Done.
> 
> Now you just need to make sure Linus gets them in the right order :-)

That's the plan :).

Michal

Re: linux-next: build failure after merge of the kbuild tree

2016-03-19 Thread Stephen Rothwell

Hi Michal,

On Wed, 16 Mar 2016 08:56:50 +0100 Michal Marek  wrote:
>
> Right. Stephen, could you perhaps move the kbuild tree down in your list
> a bit, so that the fixes are present?

Done.

Now you just need to make sure Linus gets them in the right order :-)
-- 
Cheers,
Stephen Rothwell

Re: linux-next: build failure after merge of the kbuild tree

2016-03-19 Thread Stephen Rothwell

Hi Michal,

On Wed, 16 Mar 2016 08:56:50 +0100 Michal Marek  wrote:
>
> Right. Stephen, could you perhaps move the kbuild tree down in your list
> a bit, so that the fixes are present?

Done.

Now you just need to make sure Linus gets them in the right order :-)
-- 
Cheers,
Stephen Rothwell

Re: linux-next: build failure after merge of the kbuild tree

2016-03-16 Thread Michal Marek

On 2016-03-16 08:53, Daniel Wagner wrote:
> Hi,
> 
> On 03/16/2016 12:58 AM, Stephen Rothwell wrote:
>> After merging the kbuild tree, today's linux-next build (x86_64
>> allmodconfig) failed like this:
>>
>> drivers/gpu/drm/gma500/mdfld_dsi_output.c:407:39: error: initialization from 
>> incompatible pointer type [-Werror=incompatible-pointer-types]
>>   .dpms = /*drm_helper_connector_dpms*/mdfld_dsi_connector_dpms,
>>^
>>
>> Caused by commit
>>
>>   ea8daa7b9784 ("kbuild: Add option to turn incompatible pointer check into 
>> error")
> 
> 
> A fix should be on the way via drm-misc:

Right. Stephen, could you perhaps move the kbuild tree down in your list
a bit, so that the fixes are present?

Thanks,
Michal

Re: linux-next: build failure after merge of the kbuild tree

2016-03-16 Thread Michal Marek

On 2016-03-16 08:53, Daniel Wagner wrote:
> Hi,
> 
> On 03/16/2016 12:58 AM, Stephen Rothwell wrote:
>> After merging the kbuild tree, today's linux-next build (x86_64
>> allmodconfig) failed like this:
>>
>> drivers/gpu/drm/gma500/mdfld_dsi_output.c:407:39: error: initialization from 
>> incompatible pointer type [-Werror=incompatible-pointer-types]
>>   .dpms = /*drm_helper_connector_dpms*/mdfld_dsi_connector_dpms,
>>^
>>
>> Caused by commit
>>
>>   ea8daa7b9784 ("kbuild: Add option to turn incompatible pointer check into 
>> error")
> 
> 
> A fix should be on the way via drm-misc:

Right. Stephen, could you perhaps move the kbuild tree down in your list
a bit, so that the fixes are present?

Thanks,
Michal

Re: linux-next: build failure after merge of the kbuild tree

2016-03-16 Thread Daniel Wagner

Hi,

On 03/16/2016 12:58 AM, Stephen Rothwell wrote:
> After merging the kbuild tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> drivers/gpu/drm/gma500/mdfld_dsi_output.c:407:39: error: initialization from 
> incompatible pointer type [-Werror=incompatible-pointer-types]
>   .dpms = /*drm_helper_connector_dpms*/mdfld_dsi_connector_dpms,
>^
> 
> Caused by commit
> 
>   ea8daa7b9784 ("kbuild: Add option to turn incompatible pointer check into 
> error")


A fix should be on the way via drm-misc:

https://lkml.org/lkml/2016/2/25/397

Though I don't know what the exact status is (and I haven't really
understood the flow of the patches as far)

cheers,
daniel

Re: linux-next: build failure after merge of the kbuild tree

2016-03-16 Thread Daniel Wagner

Hi,

On 03/16/2016 12:58 AM, Stephen Rothwell wrote:
> After merging the kbuild tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> drivers/gpu/drm/gma500/mdfld_dsi_output.c:407:39: error: initialization from 
> incompatible pointer type [-Werror=incompatible-pointer-types]
>   .dpms = /*drm_helper_connector_dpms*/mdfld_dsi_connector_dpms,
>^
> 
> Caused by commit
> 
>   ea8daa7b9784 ("kbuild: Add option to turn incompatible pointer check into 
> error")


A fix should be on the way via drm-misc:

https://lkml.org/lkml/2016/2/25/397

Though I don't know what the exact status is (and I haven't really
understood the flow of the patches as far)

cheers,
daniel

linux-next: build failure after merge of the kbuild tree

2016-03-15 Thread Stephen Rothwell

Hi Michal,

After merging the kbuild tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/gpu/drm/gma500/mdfld_dsi_output.c:407:39: error: initialization from 
incompatible pointer type [-Werror=incompatible-pointer-types]
  .dpms = /*drm_helper_connector_dpms*/mdfld_dsi_connector_dpms,
   ^

Caused by commit

  ea8daa7b9784 ("kbuild: Add option to turn incompatible pointer check into 
error")

Maybe this needs to be optional?

I have reverted that commit for today.

-- 
Cheers,
Stephen Rothwell

linux-next: build failure after merge of the kbuild tree

2016-03-15 Thread Stephen Rothwell

Hi Michal,

After merging the kbuild tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/gpu/drm/gma500/mdfld_dsi_output.c:407:39: error: initialization from 
incompatible pointer type [-Werror=incompatible-pointer-types]
  .dpms = /*drm_helper_connector_dpms*/mdfld_dsi_connector_dpms,
   ^

Caused by commit

  ea8daa7b9784 ("kbuild: Add option to turn incompatible pointer check into 
error")

Maybe this needs to be optional?

I have reverted that commit for today.

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build failure after merge of the kbuild tree

2013-02-25 Thread Michal Marek

On 25.2.2013 11:58, Stephen Rothwell wrote:
> --
> $ ls -l /bin/sh
> lrwxrwxrwx 1 root root 4 Jul  7  2010 /bin/sh -> bash
> $ bash --version
> GNU bash, version 4.2.20(1)-release (x86_64-pc-linux-gnu)
[...]
> But bash in sh mode does not work:
> 
> $ cat xtst.sh
> #!/bin/sh
> 
> cd /scratch/sfr/powerpc_ppc64_defconfig
> 
> . .config
> 
> exit 0
> $ ./xtst.sh
> ./xtst.sh: line 5: .: .config: file not found

Ah, so it's a too new bash that causes this. I can also reproduce it now.

Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the kbuild tree

2013-02-25 Thread Stephen Rothwell

On Mon, 25 Feb 2013 21:58:45 +1100 Stephen Rothwell  
wrote:
>
> But bash in sh mode does not work:

The bash manual says:

   .  filename [arguments]
   source filename [arguments]
  Read and execute commands from filename  in  the  current  shell
  environment  and return the exit status of the last command exe‐
  cuted from filename.  If filename does not contain a slash, file
  names  in  PATH  are used to find the directory containing file‐
  name.  The file searched for in PATH  need  not  be  executable.
  When  bash  is  not  in  posix  mode,  the  current directory is
  searched if no file is found in PATH.  If the sourcepath  option
  to  the  shopt  builtin  command  is turned off, the PATH is not
  searched.

-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au

pgplbRecsKhL2.pgp
Description: PGP signature

Re: linux-next: build failure after merge of the kbuild tree

2013-02-25 Thread Stephen Rothwell

Hi Michal,

On Mon, 25 Feb 2013 11:28:40 +0100 Michal Marek  wrote:
>
> On 25.2.2013 00:56, Stephen Rothwell wrote:
> > 
> > After merging the kbuild tree, today's linux-next build (powerpc
> > ppc64_defconfig) failed like this:
> > 
> > scripts/link-vmlinux.sh: line 135: .: .config: file not found
> > 
> > Presumably caused by commit 03b25b47e0f4 ("scripts/link-vmlinux.sh:
> > source variables from KCONFIG_CONFIG").
> 
> Strange, I did a couple of testbuilds before pushing the new branch.
> Wild guess: what version of what shell are you using on the
> buildmachine? It is probably the missing ./ that makes the difference.

I am using a Debian Testing machine (its not quite up to date):

--
$ ls -l /bin/sh
lrwxrwxrwx 1 root root 4 Jul  7  2010 /bin/sh -> bash
$ bash --version
GNU bash, version 4.2.20(1)-release (x86_64-pc-linux-gnu)
Copyright (C) 2011 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later 

This is free software; you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.
--

I am also using a cross compiler and O= on the command line if that
matters.  '.' is not in my path and .config is not executable.  If I cd
to the object directory, then ". .config" works fine.

But bash in sh mode does not work:

$ cat xtst.sh
#!/bin/sh

cd /scratch/sfr/powerpc_ppc64_defconfig

. .config

exit 0
$ ./xtst.sh
./xtst.sh: line 5: .: .config: file not found
$ ls -l /scratch/sfr/powerpc_ppc64_defconfig/.config
-rw-r--r-- 1 sfr users 79005 Feb 25 15:45 
/scratch/sfr/powerpc_ppc64_defconfig/.config

Changing the ". .config" to ". ./.config" makes it work.

Anything else?

-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


pgpvijQNo1Wjd.pgp
Description: PGP signature

Re: linux-next: build failure after merge of the kbuild tree

2013-02-25 Thread Michal Marek

On 25.2.2013 00:56, Stephen Rothwell wrote:
> Hi Michal,
> 
> After merging the kbuild tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
> 
> scripts/link-vmlinux.sh: line 135: .: .config: file not found
> 
> Presumably caused by commit 03b25b47e0f4 ("scripts/link-vmlinux.sh:
> source variables from KCONFIG_CONFIG").

Strange, I did a couple of testbuilds before pushing the new branch.
Wild guess: what version of what shell are you using on the
buildmachine? It is probably the missing ./ that makes the difference.

Thanks,
Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the kbuild tree

2013-02-25 Thread Michal Marek

On 25.2.2013 00:56, Stephen Rothwell wrote:
 Hi Michal,
 
 After merging the kbuild tree, today's linux-next build (powerpc
 ppc64_defconfig) failed like this:
 
 scripts/link-vmlinux.sh: line 135: .: .config: file not found
 
 Presumably caused by commit 03b25b47e0f4 (scripts/link-vmlinux.sh:
 source variables from KCONFIG_CONFIG).

Strange, I did a couple of testbuilds before pushing the new branch.
Wild guess: what version of what shell are you using on the
buildmachine? It is probably the missing ./ that makes the difference.

Thanks,
Michal
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the kbuild tree

2013-02-25 Thread Stephen Rothwell

Hi Michal,

On Mon, 25 Feb 2013 11:28:40 +0100 Michal Marek mma...@suse.cz wrote:

 On 25.2.2013 00:56, Stephen Rothwell wrote:
  
  After merging the kbuild tree, today's linux-next build (powerpc
  ppc64_defconfig) failed like this:
  
  scripts/link-vmlinux.sh: line 135: .: .config: file not found
  
  Presumably caused by commit 03b25b47e0f4 (scripts/link-vmlinux.sh:
  source variables from KCONFIG_CONFIG).
 
 Strange, I did a couple of testbuilds before pushing the new branch.
 Wild guess: what version of what shell are you using on the
 buildmachine? It is probably the missing ./ that makes the difference.

I am using a Debian Testing machine (its not quite up to date):

--
$ ls -l /bin/sh
lrwxrwxrwx 1 root root 4 Jul  7  2010 /bin/sh - bash
$ bash --version
GNU bash, version 4.2.20(1)-release (x86_64-pc-linux-gnu)
Copyright (C) 2011 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later http://gnu.org/licenses/gpl.html

This is free software; you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.
--

I am also using a cross compiler and O= on the command line if that
matters.  '.' is not in my path and .config is not executable.  If I cd
to the object directory, then . .config works fine.

But bash in sh mode does not work:

$ cat xtst.sh
#!/bin/sh

cd /scratch/sfr/powerpc_ppc64_defconfig

. .config

exit 0
$ ./xtst.sh
./xtst.sh: line 5: .: .config: file not found
$ ls -l /scratch/sfr/powerpc_ppc64_defconfig/.config
-rw-r--r-- 1 sfr users 79005 Feb 25 15:45 
/scratch/sfr/powerpc_ppc64_defconfig/.config

Changing the . .config to . ./.config makes it work.

Anything else?

-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


pgpvijQNo1Wjd.pgp
Description: PGP signature

Re: linux-next: build failure after merge of the kbuild tree

2013-02-25 Thread Stephen Rothwell

On Mon, 25 Feb 2013 21:58:45 +1100 Stephen Rothwell s...@canb.auug.org.au 
wrote:

 But bash in sh mode does not work:

The bash manual says:

   .  filename [arguments]
   source filename [arguments]
  Read and execute commands from filename  in  the  current  shell
  environment  and return the exit status of the last command exe‐
  cuted from filename.  If filename does not contain a slash, file
  names  in  PATH  are used to find the directory containing file‐
  name.  The file searched for in PATH  need  not  be  executable.
  When  bash  is  not  in  posix  mode,  the  current directory is
  searched if no file is found in PATH.  If the sourcepath  option
  to  the  shopt  builtin  command  is turned off, the PATH is not
  searched.

-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


pgplbRecsKhL2.pgp
Description: PGP signature

Re: linux-next: build failure after merge of the kbuild tree

2013-02-25 Thread Michal Marek

On 25.2.2013 11:58, Stephen Rothwell wrote:
 --
 $ ls -l /bin/sh
 lrwxrwxrwx 1 root root 4 Jul  7  2010 /bin/sh - bash
 $ bash --version
 GNU bash, version 4.2.20(1)-release (x86_64-pc-linux-gnu)
[...]
 But bash in sh mode does not work:
 
 $ cat xtst.sh
 #!/bin/sh
 
 cd /scratch/sfr/powerpc_ppc64_defconfig
 
 . .config
 
 exit 0
 $ ./xtst.sh
 ./xtst.sh: line 5: .: .config: file not found

Ah, so it's a too new bash that causes this. I can also reproduce it now.

Michal
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

linux-next: build failure after merge of the kbuild tree

2013-02-24 Thread Stephen Rothwell

Hi Michal,

After merging the kbuild tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

scripts/link-vmlinux.sh: line 135: .: .config: file not found

Presumably caused by commit 03b25b47e0f4 ("scripts/link-vmlinux.sh:
source variables from KCONFIG_CONFIG").

I have used the kbuild tree from next-20130222 for today.
-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


pgpK4s2ijDqeA.pgp
Description: PGP signature

linux-next: build failure after merge of the kbuild tree

2013-02-24 Thread Stephen Rothwell

Hi Michal,

After merging the kbuild tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

scripts/link-vmlinux.sh: line 135: .: .config: file not found

Presumably caused by commit 03b25b47e0f4 (scripts/link-vmlinux.sh:
source variables from KCONFIG_CONFIG).

I have used the kbuild tree from next-20130222 for today.
-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


pgpK4s2ijDqeA.pgp
Description: PGP signature

67 matches

Mail list logo