Re: linux-next: build failure after merge of the kvm-arm tree
On 23/09/16 04:31, Stephen Rothwell wrote:
> Hi all,
>
> After merging the kvm-arm tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
>
> tmp/cc9rCfjd.s: Assembler messages:
> tmp/cc9rCfjd.s:310: Error: bad or missing co-processor number -- `mcr
> "mrc","mcr","p15, 0, r2, c12, c12, 3",u32'
> scripts/Makefile.build:290: recipe for target 'drivers/irqchip/irq-gic-v3.o'
> failed
>
> Maybe caused by commit
>
> 4f2546384150 ("ARM: Move system register accessors to asm/cp15.h")
>
> I have used the kvm-arm tree from next-20160922 for today.
Ouch. This comes from 91ef844 ("irqchip/gic-v3: Reset BPR during
initialization") which has introduced a new accessor that doesn't get
converted by Vladimir's patch. My own fault.
This can be fixed-up by adding this to Vladimir's patch:
diff --git a/arch/arm/include/asm/arch_gicv3.h
b/arch/arm/include/asm/arch_gicv3.h
index 996848e..809f3be 100644
--- a/arch/arm/include/asm/arch_gicv3.h
+++ b/arch/arm/include/asm/arch_gicv3.h
@@ -216,6 +216,15 @@ static inline void gic_write_sre(u32 val)
isb();
}
+static inline void gic_write_bpr1(u32 val)
+{
+#ifndef __write_sysreg
+ asm volatile("mcr " __stringify(ICC_BPR1) : : "r" (val));
+#else
+ write_sysreg(val, ICC_BPR1);
+#endif
+}
+
/*
* Even in 32bit systems that use LPAE, there is no guarantee that the I/O
* interface provides true 64bit atomic accesses, so using strd/ldrd doesn't
but that'll create a minor conflict.
Another possibility is to put Vladimir's series on the backburner until
tip/irq/core gets in, and bring it back at this time. I'd prefer the
first solution, as it gives a bit more exposure to the code...
Thanks,
M.
--
Jazz is not dead. It just smells funny...
Re: linux-next: build failure after merge of the kvm-arm tree
On 23/09/16 04:31, Stephen Rothwell wrote:
> Hi all,
>
> After merging the kvm-arm tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
>
> tmp/cc9rCfjd.s: Assembler messages:
> tmp/cc9rCfjd.s:310: Error: bad or missing co-processor number -- `mcr
> "mrc","mcr","p15, 0, r2, c12, c12, 3",u32'
> scripts/Makefile.build:290: recipe for target 'drivers/irqchip/irq-gic-v3.o'
> failed
>
> Maybe caused by commit
>
> 4f2546384150 ("ARM: Move system register accessors to asm/cp15.h")
>
> I have used the kvm-arm tree from next-20160922 for today.
Ouch. This comes from 91ef844 ("irqchip/gic-v3: Reset BPR during
initialization") which has introduced a new accessor that doesn't get
converted by Vladimir's patch. My own fault.
This can be fixed-up by adding this to Vladimir's patch:
diff --git a/arch/arm/include/asm/arch_gicv3.h
b/arch/arm/include/asm/arch_gicv3.h
index 996848e..809f3be 100644
--- a/arch/arm/include/asm/arch_gicv3.h
+++ b/arch/arm/include/asm/arch_gicv3.h
@@ -216,6 +216,15 @@ static inline void gic_write_sre(u32 val)
isb();
}
+static inline void gic_write_bpr1(u32 val)
+{
+#ifndef __write_sysreg
+ asm volatile("mcr " __stringify(ICC_BPR1) : : "r" (val));
+#else
+ write_sysreg(val, ICC_BPR1);
+#endif
+}
+
/*
* Even in 32bit systems that use LPAE, there is no guarantee that the I/O
* interface provides true 64bit atomic accesses, so using strd/ldrd doesn't
but that'll create a minor conflict.
Another possibility is to put Vladimir's series on the backburner until
tip/irq/core gets in, and bring it back at this time. I'd prefer the
first solution, as it gives a bit more exposure to the code...
Thanks,
M.
--
Jazz is not dead. It just smells funny...
linux-next: build failure after merge of the kvm-arm tree
Hi all,
After merging the kvm-arm tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:
tmp/cc9rCfjd.s: Assembler messages:
tmp/cc9rCfjd.s:310: Error: bad or missing co-processor number -- `mcr
"mrc","mcr","p15, 0, r2, c12, c12, 3",u32'
scripts/Makefile.build:290: recipe for target 'drivers/irqchip/irq-gic-v3.o'
failed
Maybe caused by commit
4f2546384150 ("ARM: Move system register accessors to asm/cp15.h")
I have used the kvm-arm tree from next-20160922 for today.
--
Cheers,
Stephen Rothwell
linux-next: build failure after merge of the kvm-arm tree
Hi all,
After merging the kvm-arm tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:
tmp/cc9rCfjd.s: Assembler messages:
tmp/cc9rCfjd.s:310: Error: bad or missing co-processor number -- `mcr
"mrc","mcr","p15, 0, r2, c12, c12, 3",u32'
scripts/Makefile.build:290: recipe for target 'drivers/irqchip/irq-gic-v3.o'
failed
Maybe caused by commit
4f2546384150 ("ARM: Move system register accessors to asm/cp15.h")
I have used the kvm-arm tree from next-20160922 for today.
--
Cheers,
Stephen Rothwell
Re: linux-next: build failure after merge of the kvm-arm tree
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Il 24/09/2014 09:06, Christoffer Dall ha scritto: >>> Still getting this failure. >>> > Commit e9142e3b69c2ae8a699463e219e5b029ff0d652b in kvm/queue fixes > this, but it hasn't gone to next yet. > > Paolo, I know there's a scary commit in queue but there's a bunch > of scary stuff in the kvmarm/next too that I'd like to see in next, > any chance you can put a subset of queue into next? Yes, I will put the commit in next and rebase queue on top of it. Paolo -BEGIN PGP SIGNATURE- Version: GnuPG v2 iQIcBAEBAgAGBQJUIpdYAAoJEBvWZb6bTYbyAkwP/jwno7pOt/sHUaa+p45Uouse oFS2aej8ZVLz3LMy6KjFuIME1bJjQytIZrFaGn+UksGd6cfhECydVO8hlJxWUDbc PrWpnwzX/u4sorewmX+hq9EoFBfIEzC86NyrUaujiL6ojLjoJ4mkoRc9LRCm/K7j dPJFGEQqifs0HelWSQPxH4ei/YyHk/TcaKgepQGlG4Aw/crLHmEajbrnGLge7isW H/EtBW5iJToG8mxB+ipSwFCADUkXC+FUrEblX5Nxma/949roXg8LPuZUBxCxWwyr Voi5/lU1sZMRYixoCHhhKaWPDfoSspjPU4JNEUMj4qtrZrBD9W27+bjyQBTdLjU7 erI1pQCmZsU52RdAtZiUBuSbRxb8is+WlRHJy7dhlb+SBcgXNWw/k9sxV2U6PZ+T Z4A0ngZM12ZTd6XWgiE+3mMR0XGBsjh7TYq+ybQReCgKeNy/Q3FL6fS4E9me7MWF CWIfqV327GYfH/eU8Bd1/VHGEZfDefDXZrdANa+A5FhaGTLIZbPHfEo2BCc85LhS RRlKjIg1LeByCHDRaQ8parl0xgZRLuENfHn5gso4ZsAKgLyUp8IIGanxH8GD2sRO F2AtAFfLSlXUo/FsxaW0bQOxnBB9L/UX5QmMT/YwG7QoP97Wa4fDBV1ruHTiJ9SO s/nkZE3pcbAFSv/0rXlG =ln4T -END PGP SIGNATURE- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the kvm-arm tree
On Wed, Sep 24, 2014 at 04:50:30PM +1000, Stephen Rothwell wrote:
> Hi all,
>
> On Mon, 22 Sep 2014 14:06:45 +1000 Stephen Rothwell
> wrote:
> >
> > Hi all,
> >
> > After merging the kvm-arm tree, today's linux-next build (x86_64
> > allmodconfig)
> > failed like this:
> >
> > arch/x86/kvm/../../../virt/kvm/eventfd.c: In function
> > 'kvm_register_irq_ack_notifier':
> > arch/x86/kvm/../../../virt/kvm/eventfd.c:493:2: error: implicit declaration
> > of function 'kvm_vcpu_request_scan_ioapic'
> > [-Werror=implicit-function-declaration]
> > kvm_vcpu_request_scan_ioapic(kvm);
> > ^
> >
> > Probably caused by commit 0ba09511ddc3 ("KVM: EVENTFD: remove inclusion
> > of irq.h").
> >
> > I have used the kvm-arm tree from next-20140919 for today.
>
> Still getting this failure.
>
Commit e9142e3b69c2ae8a699463e219e5b029ff0d652b in kvm/queue fixes this,
but it hasn't gone to next yet.
Paolo, I know there's a scary commit in queue but there's a bunch of
scary stuff in the kvmarm/next too that I'd like to see in next, any
chance you can put a subset of queue into next?
Thanks,
-Christoffer
signature.asc
Description: Digital signature
Re: linux-next: build failure after merge of the kvm-arm tree
Hi all,
On Mon, 22 Sep 2014 14:06:45 +1000 Stephen Rothwell
wrote:
>
> Hi all,
>
> After merging the kvm-arm tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
>
> arch/x86/kvm/../../../virt/kvm/eventfd.c: In function
> 'kvm_register_irq_ack_notifier':
> arch/x86/kvm/../../../virt/kvm/eventfd.c:493:2: error: implicit declaration
> of function 'kvm_vcpu_request_scan_ioapic'
> [-Werror=implicit-function-declaration]
> kvm_vcpu_request_scan_ioapic(kvm);
> ^
>
> Probably caused by commit 0ba09511ddc3 ("KVM: EVENTFD: remove inclusion
> of irq.h").
>
> I have used the kvm-arm tree from next-20140919 for today.
Still getting this failure.
--
Cheers,
Stephen Rothwells...@canb.auug.org.au
signature.asc
Description: PGP signature
Re: linux-next: build failure after merge of the kvm-arm tree
Hi all, On Mon, 22 Sep 2014 14:06:45 +1000 Stephen Rothwell s...@canb.auug.org.au wrote: Hi all, After merging the kvm-arm tree, today's linux-next build (x86_64 allmodconfig) failed like this: arch/x86/kvm/../../../virt/kvm/eventfd.c: In function 'kvm_register_irq_ack_notifier': arch/x86/kvm/../../../virt/kvm/eventfd.c:493:2: error: implicit declaration of function 'kvm_vcpu_request_scan_ioapic' [-Werror=implicit-function-declaration] kvm_vcpu_request_scan_ioapic(kvm); ^ Probably caused by commit 0ba09511ddc3 (KVM: EVENTFD: remove inclusion of irq.h). I have used the kvm-arm tree from next-20140919 for today. Still getting this failure. -- Cheers, Stephen Rothwells...@canb.auug.org.au signature.asc Description: PGP signature
Re: linux-next: build failure after merge of the kvm-arm tree
On Wed, Sep 24, 2014 at 04:50:30PM +1000, Stephen Rothwell wrote: Hi all, On Mon, 22 Sep 2014 14:06:45 +1000 Stephen Rothwell s...@canb.auug.org.au wrote: Hi all, After merging the kvm-arm tree, today's linux-next build (x86_64 allmodconfig) failed like this: arch/x86/kvm/../../../virt/kvm/eventfd.c: In function 'kvm_register_irq_ack_notifier': arch/x86/kvm/../../../virt/kvm/eventfd.c:493:2: error: implicit declaration of function 'kvm_vcpu_request_scan_ioapic' [-Werror=implicit-function-declaration] kvm_vcpu_request_scan_ioapic(kvm); ^ Probably caused by commit 0ba09511ddc3 (KVM: EVENTFD: remove inclusion of irq.h). I have used the kvm-arm tree from next-20140919 for today. Still getting this failure. Commit e9142e3b69c2ae8a699463e219e5b029ff0d652b in kvm/queue fixes this, but it hasn't gone to next yet. Paolo, I know there's a scary commit in queue but there's a bunch of scary stuff in the kvmarm/next too that I'd like to see in next, any chance you can put a subset of queue into next? Thanks, -Christoffer signature.asc Description: Digital signature
Re: linux-next: build failure after merge of the kvm-arm tree
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Il 24/09/2014 09:06, Christoffer Dall ha scritto: Still getting this failure. Commit e9142e3b69c2ae8a699463e219e5b029ff0d652b in kvm/queue fixes this, but it hasn't gone to next yet. Paolo, I know there's a scary commit in queue but there's a bunch of scary stuff in the kvmarm/next too that I'd like to see in next, any chance you can put a subset of queue into next? Yes, I will put the commit in next and rebase queue on top of it. Paolo -BEGIN PGP SIGNATURE- Version: GnuPG v2 iQIcBAEBAgAGBQJUIpdYAAoJEBvWZb6bTYbyAkwP/jwno7pOt/sHUaa+p45Uouse oFS2aej8ZVLz3LMy6KjFuIME1bJjQytIZrFaGn+UksGd6cfhECydVO8hlJxWUDbc PrWpnwzX/u4sorewmX+hq9EoFBfIEzC86NyrUaujiL6ojLjoJ4mkoRc9LRCm/K7j dPJFGEQqifs0HelWSQPxH4ei/YyHk/TcaKgepQGlG4Aw/crLHmEajbrnGLge7isW H/EtBW5iJToG8mxB+ipSwFCADUkXC+FUrEblX5Nxma/949roXg8LPuZUBxCxWwyr Voi5/lU1sZMRYixoCHhhKaWPDfoSspjPU4JNEUMj4qtrZrBD9W27+bjyQBTdLjU7 erI1pQCmZsU52RdAtZiUBuSbRxb8is+WlRHJy7dhlb+SBcgXNWw/k9sxV2U6PZ+T Z4A0ngZM12ZTd6XWgiE+3mMR0XGBsjh7TYq+ybQReCgKeNy/Q3FL6fS4E9me7MWF CWIfqV327GYfH/eU8Bd1/VHGEZfDefDXZrdANa+A5FhaGTLIZbPHfEo2BCc85LhS RRlKjIg1LeByCHDRaQ8parl0xgZRLuENfHn5gso4ZsAKgLyUp8IIGanxH8GD2sRO F2AtAFfLSlXUo/FsxaW0bQOxnBB9L/UX5QmMT/YwG7QoP97Wa4fDBV1ruHTiJ9SO s/nkZE3pcbAFSv/0rXlG =ln4T -END PGP SIGNATURE- -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the kvm-arm tree
Il 22/09/2014 21:46, Christoffer Dall ha scritto: > > I've taken a stab at fixing this properly, can you have a quick look and > let me know if you prefer this or if I should just revert the commit? > > https://git.linaro.org/people/christoffer.dall/linux-kvm-arm.git/commit/3d2603609f2adaae85dd1ef9884270331ec120e3 I think you should include ioapic.h (under #ifdef __KVM_HAVE_IOAPIC as in your patch), not irq.h. However, I haven't compiled it. Please send the patch for inclusion in my tree, and I'll fix the conflict when I pull from you. Paolo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the kvm-arm tree
Il 22/09/2014 21:46, Christoffer Dall ha scritto: I've taken a stab at fixing this properly, can you have a quick look and let me know if you prefer this or if I should just revert the commit? https://git.linaro.org/people/christoffer.dall/linux-kvm-arm.git/commit/3d2603609f2adaae85dd1ef9884270331ec120e3 I think you should include ioapic.h (under #ifdef __KVM_HAVE_IOAPIC as in your patch), not irq.h. However, I haven't compiled it. Please send the patch for inclusion in my tree, and I'll fix the conflict when I pull from you. Paolo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the kvm-arm tree
On 09/22/2014 07:07 AM, Eric Auger wrote:
> Dear all,
>
> Thanks Stephen for reporting the problem. Indeed removing irq.h header
> file is no more possible since commit
> c77dcacb397519b6ade8f08201a4a90a7f4f751e, "KVM: Move more code under
> CONFIG_HAVE_KVM_IRQFD" which moves among other things
> kvm_register_irq_ack_notifier and kvm_unregister_irq_ack_notifier in
> eventfd.c.
Hi,
kvm_register_irq_ack_notifier and kvm_unregister_irq_ack_notifier were
already included in Paul's patch,
commit e4d57e1ee1ab59f0cef0272800ac6c52e0ec814a, KVM: Move irq notifier
implementation into eventfd.c and just moved in above patch.
So I completely missed this ioapic function.
You can remove my commit. No commit does depend on it yet.
Thanks
Eric
>
> including virt/kvm/ioapic.h might fix the problem but I am OoO next week
> and cannot investigate further right now.
>
> Please can you remove that commit. Sorry for the inconvenience.
>
> Best Regards
>
> Eric
>
>
> On 09/22/2014 06:06 AM, Stephen Rothwell wrote:
>> Hi all,
>>
>> After merging the kvm-arm tree, today's linux-next build (x86_64
>> allmodconfig)
>> failed like this:
>>
>> arch/x86/kvm/../../../virt/kvm/eventfd.c: In function
>> 'kvm_register_irq_ack_notifier':
>> arch/x86/kvm/../../../virt/kvm/eventfd.c:493:2: error: implicit declaration
>> of function 'kvm_vcpu_request_scan_ioapic'
>> [-Werror=implicit-function-declaration]
>> kvm_vcpu_request_scan_ioapic(kvm);
>> ^
>>
>> Probably caused by commit 0ba09511ddc3 ("KVM: EVENTFD: remove inclusion
>> of irq.h").
>>
>> I have used the kvm-arm tree from next-20140919 for today.
>>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the kvm-arm tree
Dear all,
Thanks Stephen for reporting the problem. Indeed removing irq.h header
file is no more possible since commit
c77dcacb397519b6ade8f08201a4a90a7f4f751e, "KVM: Move more code under
CONFIG_HAVE_KVM_IRQFD" which moves among other things
kvm_register_irq_ack_notifier and kvm_unregister_irq_ack_notifier in
eventfd.c.
including virt/kvm/ioapic.h might fix the problem but I am OoO next week
and cannot investigate further right now.
Please can you remove that commit. Sorry for the inconvenience.
Best Regards
Eric
On 09/22/2014 06:06 AM, Stephen Rothwell wrote:
> Hi all,
>
> After merging the kvm-arm tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
>
> arch/x86/kvm/../../../virt/kvm/eventfd.c: In function
> 'kvm_register_irq_ack_notifier':
> arch/x86/kvm/../../../virt/kvm/eventfd.c:493:2: error: implicit declaration
> of function 'kvm_vcpu_request_scan_ioapic'
> [-Werror=implicit-function-declaration]
> kvm_vcpu_request_scan_ioapic(kvm);
> ^
>
> Probably caused by commit 0ba09511ddc3 ("KVM: EVENTFD: remove inclusion
> of irq.h").
>
> I have used the kvm-arm tree from next-20140919 for today.
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
linux-next: build failure after merge of the kvm-arm tree
Hi all,
After merging the kvm-arm tree, today's linux-next build (x86_64 allmodconfig)
failed like this:
arch/x86/kvm/../../../virt/kvm/eventfd.c: In function
'kvm_register_irq_ack_notifier':
arch/x86/kvm/../../../virt/kvm/eventfd.c:493:2: error: implicit declaration of
function 'kvm_vcpu_request_scan_ioapic' [-Werror=implicit-function-declaration]
kvm_vcpu_request_scan_ioapic(kvm);
^
Probably caused by commit 0ba09511ddc3 ("KVM: EVENTFD: remove inclusion
of irq.h").
I have used the kvm-arm tree from next-20140919 for today.
--
Cheers,
Stephen Rothwells...@canb.auug.org.au
signature.asc
Description: PGP signature
linux-next: build failure after merge of the kvm-arm tree
Hi all, After merging the kvm-arm tree, today's linux-next build (x86_64 allmodconfig) failed like this: arch/x86/kvm/../../../virt/kvm/eventfd.c: In function 'kvm_register_irq_ack_notifier': arch/x86/kvm/../../../virt/kvm/eventfd.c:493:2: error: implicit declaration of function 'kvm_vcpu_request_scan_ioapic' [-Werror=implicit-function-declaration] kvm_vcpu_request_scan_ioapic(kvm); ^ Probably caused by commit 0ba09511ddc3 (KVM: EVENTFD: remove inclusion of irq.h). I have used the kvm-arm tree from next-20140919 for today. -- Cheers, Stephen Rothwells...@canb.auug.org.au signature.asc Description: PGP signature
Re: linux-next: build failure after merge of the kvm-arm tree
Dear all, Thanks Stephen for reporting the problem. Indeed removing irq.h header file is no more possible since commit c77dcacb397519b6ade8f08201a4a90a7f4f751e, KVM: Move more code under CONFIG_HAVE_KVM_IRQFD which moves among other things kvm_register_irq_ack_notifier and kvm_unregister_irq_ack_notifier in eventfd.c. including virt/kvm/ioapic.h might fix the problem but I am OoO next week and cannot investigate further right now. Please can you remove that commit. Sorry for the inconvenience. Best Regards Eric On 09/22/2014 06:06 AM, Stephen Rothwell wrote: Hi all, After merging the kvm-arm tree, today's linux-next build (x86_64 allmodconfig) failed like this: arch/x86/kvm/../../../virt/kvm/eventfd.c: In function 'kvm_register_irq_ack_notifier': arch/x86/kvm/../../../virt/kvm/eventfd.c:493:2: error: implicit declaration of function 'kvm_vcpu_request_scan_ioapic' [-Werror=implicit-function-declaration] kvm_vcpu_request_scan_ioapic(kvm); ^ Probably caused by commit 0ba09511ddc3 (KVM: EVENTFD: remove inclusion of irq.h). I have used the kvm-arm tree from next-20140919 for today. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the kvm-arm tree
On 09/22/2014 07:07 AM, Eric Auger wrote: Dear all, Thanks Stephen for reporting the problem. Indeed removing irq.h header file is no more possible since commit c77dcacb397519b6ade8f08201a4a90a7f4f751e, KVM: Move more code under CONFIG_HAVE_KVM_IRQFD which moves among other things kvm_register_irq_ack_notifier and kvm_unregister_irq_ack_notifier in eventfd.c. Hi, kvm_register_irq_ack_notifier and kvm_unregister_irq_ack_notifier were already included in Paul's patch, commit e4d57e1ee1ab59f0cef0272800ac6c52e0ec814a, KVM: Move irq notifier implementation into eventfd.c and just moved in above patch. So I completely missed this ioapic function. You can remove my commit. No commit does depend on it yet. Thanks Eric including virt/kvm/ioapic.h might fix the problem but I am OoO next week and cannot investigate further right now. Please can you remove that commit. Sorry for the inconvenience. Best Regards Eric On 09/22/2014 06:06 AM, Stephen Rothwell wrote: Hi all, After merging the kvm-arm tree, today's linux-next build (x86_64 allmodconfig) failed like this: arch/x86/kvm/../../../virt/kvm/eventfd.c: In function 'kvm_register_irq_ack_notifier': arch/x86/kvm/../../../virt/kvm/eventfd.c:493:2: error: implicit declaration of function 'kvm_vcpu_request_scan_ioapic' [-Werror=implicit-function-declaration] kvm_vcpu_request_scan_ioapic(kvm); ^ Probably caused by commit 0ba09511ddc3 (KVM: EVENTFD: remove inclusion of irq.h). I have used the kvm-arm tree from next-20140919 for today. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
