Re: linux-next: build failure after merge of the l2-mtd tree

2017-08-28 Thread Brian Norris
On Mon, Aug 28, 2017 at 12:19:05PM +1000, Stephen Rothwell wrote:
> Hi Brian,

Hi Stephen,

> After merging the l2-mtd tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> drivers/mtd/nand/nandsim.c: In function 'ns_init_module':
> drivers/mtd/nand/nandsim.c:2353:2: error: implicit declaration of function 
> 'nandsim_debugfs_remove' [-Werror=implicit-function-declaration]
>   nandsim_debugfs_remove(nand);
>   ^
> 
> Caused by commit
> 
>   e8e3edb95ce6 ("mtd: create per-device and module-scope debugfs entries")
> 
> interacting with commit
> 
>   b974696da1cf ("mtd: nandsim: remove debugfs entries in error path")
> 
> from Linus' tree.

Yes, this was expected in the divergence between a bugfix merge for 4.13
vs. a feature change in 4.14. I think Boris has fixed the conflict in
his merges and is uploading that to l2-mtd/master (he's handling MTD for
4.14).

Good to know you catch this too :)

> I applied the following merge fix patch ... please check.
> 
> From: Stephen Rothwell 
> Date: Mon, 28 Aug 2017 12:13:42 +1000
> Subject: [PATCH] fix merge of l2-mtd tree
> 
> Signed-off-by: Stephen Rothwell 
> ---
>  drivers/mtd/nand/nandsim.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/mtd/nand/nandsim.c b/drivers/mtd/nand/nandsim.c
> index 00635fd738f6..1ddf0b73c246 100644
> --- a/drivers/mtd/nand/nandsim.c
> +++ b/drivers/mtd/nand/nandsim.c
> @@ -2350,7 +2350,6 @@ static int __init ns_init_module(void)
>  return 0;
>  
>  err_exit:
> - nandsim_debugfs_remove(nand);
>   free_nandsim(nand);
>   nand_release(nsmtd);
>   for (i = 0;i < ARRAY_SIZE(nand->partitions); ++i)

I think this is right, and it matches what Boris is pushing.

Regards,
Brian


Re: linux-next: build failure after merge of the l2-mtd tree

2017-08-28 Thread Brian Norris
On Mon, Aug 28, 2017 at 12:19:05PM +1000, Stephen Rothwell wrote:
> Hi Brian,

Hi Stephen,

> After merging the l2-mtd tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> drivers/mtd/nand/nandsim.c: In function 'ns_init_module':
> drivers/mtd/nand/nandsim.c:2353:2: error: implicit declaration of function 
> 'nandsim_debugfs_remove' [-Werror=implicit-function-declaration]
>   nandsim_debugfs_remove(nand);
>   ^
> 
> Caused by commit
> 
>   e8e3edb95ce6 ("mtd: create per-device and module-scope debugfs entries")
> 
> interacting with commit
> 
>   b974696da1cf ("mtd: nandsim: remove debugfs entries in error path")
> 
> from Linus' tree.

Yes, this was expected in the divergence between a bugfix merge for 4.13
vs. a feature change in 4.14. I think Boris has fixed the conflict in
his merges and is uploading that to l2-mtd/master (he's handling MTD for
4.14).

Good to know you catch this too :)

> I applied the following merge fix patch ... please check.
> 
> From: Stephen Rothwell 
> Date: Mon, 28 Aug 2017 12:13:42 +1000
> Subject: [PATCH] fix merge of l2-mtd tree
> 
> Signed-off-by: Stephen Rothwell 
> ---
>  drivers/mtd/nand/nandsim.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/mtd/nand/nandsim.c b/drivers/mtd/nand/nandsim.c
> index 00635fd738f6..1ddf0b73c246 100644
> --- a/drivers/mtd/nand/nandsim.c
> +++ b/drivers/mtd/nand/nandsim.c
> @@ -2350,7 +2350,6 @@ static int __init ns_init_module(void)
>  return 0;
>  
>  err_exit:
> - nandsim_debugfs_remove(nand);
>   free_nandsim(nand);
>   nand_release(nsmtd);
>   for (i = 0;i < ARRAY_SIZE(nand->partitions); ++i)

I think this is right, and it matches what Boris is pushing.

Regards,
Brian


linux-next: build failure after merge of the l2-mtd tree

2017-08-27 Thread Stephen Rothwell
Hi Brian,

After merging the l2-mtd tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/mtd/nand/nandsim.c: In function 'ns_init_module':
drivers/mtd/nand/nandsim.c:2353:2: error: implicit declaration of function 
'nandsim_debugfs_remove' [-Werror=implicit-function-declaration]
  nandsim_debugfs_remove(nand);
  ^

Caused by commit

  e8e3edb95ce6 ("mtd: create per-device and module-scope debugfs entries")

interacting with commit

  b974696da1cf ("mtd: nandsim: remove debugfs entries in error path")

from Linus' tree.

I applied the following merge fix patch ... please check.

From: Stephen Rothwell 
Date: Mon, 28 Aug 2017 12:13:42 +1000
Subject: [PATCH] fix merge of l2-mtd tree

Signed-off-by: Stephen Rothwell 
---
 drivers/mtd/nand/nandsim.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/mtd/nand/nandsim.c b/drivers/mtd/nand/nandsim.c
index 00635fd738f6..1ddf0b73c246 100644
--- a/drivers/mtd/nand/nandsim.c
+++ b/drivers/mtd/nand/nandsim.c
@@ -2350,7 +2350,6 @@ static int __init ns_init_module(void)
 return 0;
 
 err_exit:
-   nandsim_debugfs_remove(nand);
free_nandsim(nand);
nand_release(nsmtd);
for (i = 0;i < ARRAY_SIZE(nand->partitions); ++i)
-- 
2.13.2




-- 
Cheers,
Stephen Rothwell


linux-next: build failure after merge of the l2-mtd tree

2017-08-27 Thread Stephen Rothwell
Hi Brian,

After merging the l2-mtd tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/mtd/nand/nandsim.c: In function 'ns_init_module':
drivers/mtd/nand/nandsim.c:2353:2: error: implicit declaration of function 
'nandsim_debugfs_remove' [-Werror=implicit-function-declaration]
  nandsim_debugfs_remove(nand);
  ^

Caused by commit

  e8e3edb95ce6 ("mtd: create per-device and module-scope debugfs entries")

interacting with commit

  b974696da1cf ("mtd: nandsim: remove debugfs entries in error path")

from Linus' tree.

I applied the following merge fix patch ... please check.

From: Stephen Rothwell 
Date: Mon, 28 Aug 2017 12:13:42 +1000
Subject: [PATCH] fix merge of l2-mtd tree

Signed-off-by: Stephen Rothwell 
---
 drivers/mtd/nand/nandsim.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/mtd/nand/nandsim.c b/drivers/mtd/nand/nandsim.c
index 00635fd738f6..1ddf0b73c246 100644
--- a/drivers/mtd/nand/nandsim.c
+++ b/drivers/mtd/nand/nandsim.c
@@ -2350,7 +2350,6 @@ static int __init ns_init_module(void)
 return 0;
 
 err_exit:
-   nandsim_debugfs_remove(nand);
free_nandsim(nand);
nand_release(nsmtd);
for (i = 0;i < ARRAY_SIZE(nand->partitions); ++i)
-- 
2.13.2




-- 
Cheers,
Stephen Rothwell


Re: linux-next: build failure after merge of the l2-mtd tree

2017-02-08 Thread Brian Norris
Hi,

On Thu, Feb 09, 2017 at 12:08:39PM +1100, Stephen Rothwell wrote:
> Hi Brian,
> 
> After merging the l2-mtd tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> ERROR: "of_flash_probe_versatile" [drivers/mtd/maps/physmap_of.ko] undefined!
> ERROR: "of_flash_probe_gemini" [drivers/mtd/maps/physmap_of.ko] undefined!
> 
> Probably caused by commit
> 
>   56ff337ea433 ("mtd: physmap_of: add a hook for Gemini flash probing")
> 
> The config has:
> 
> CONFIG_MTD_PHYSMAP=m
> CONFIG_MTD_PHYSMAP_COMPAT=y
> CONFIG_MTD_PHYSMAP_OF=m
> CONFIG_MTD_PHYSMAP_OF_VERSATILE=y
> CONFIG_MTD_PHYSMAP_OF_GEMINI=y
> 
> I am not sure why this is a problem, but previously physmap_of_versatile.o
> would have been in obj-m and it is now in obj-y.

I think this part of that change does it:

--- a/drivers/mtd/maps/Makefile
+++ b/drivers/mtd/maps/Makefile
@@ -18,9 +18,8 @@ obj-$(CONFIG_MTD_TSUNAMI) += tsunami_flash.o
 obj-$(CONFIG_MTD_PXA2XX)   += pxa2xx-flash.o
 obj-$(CONFIG_MTD_PHYSMAP)  += physmap.o
 obj-$(CONFIG_MTD_PHYSMAP_OF)   += physmap_of.o
-ifdef CONFIG_MTD_PHYSMAP_OF_VERSATILE
-obj-$(CONFIG_MTD_PHYSMAP_OF)   += physmap_of_versatile.o
-endif
+obj-$(CONFIG_MTD_PHYSMAP_OF_VERSATILE) += physmap_of_versatile.o
+obj-$(CONFIG_MTD_PHYSMAP_OF_GEMINI)+= physmap_of_gemini.o
 obj-$(CONFIG_MTD_PISMO)+= pismo.o
 obj-$(CONFIG_MTD_PMC_MSP_EVM)   += pmcmsp-flash.o
 obj-$(CONFIG_MTD_PCMCIA)   += pcmciamtd.o

We were previously just keeping physmap_of_versatile in sync with physmap_of.
So it could be a module, even though CONFIG_MTD_PHYSMAP_OF_VERSATILE was
'bool'.

This is kind of a weird scenario, since physmap_of actually depends on
*_versatile or *_gemini (when enabled). Maybe we should revert to something
like the original logic. We can even actually merge the 3 modules (and then
drop the EXPORT_*s too):

diff --git a/drivers/mtd/maps/Makefile b/drivers/mtd/maps/Makefile
index 2fec1e0c2371..aef1846b4de2 100644
--- a/drivers/mtd/maps/Makefile
+++ b/drivers/mtd/maps/Makefile
@@ -17,9 +17,13 @@ obj-$(CONFIG_MTD_CK804XROM)  += ck804xrom.o
 obj-$(CONFIG_MTD_TSUNAMI)  += tsunami_flash.o
 obj-$(CONFIG_MTD_PXA2XX)   += pxa2xx-flash.o
 obj-$(CONFIG_MTD_PHYSMAP)  += physmap.o
+ifdef CONFIG_MTD_PHYSMAP_OF_VERSATILE
+physmap_of-objs += physmap_of_versatile.o
+endif
+ifdef CONFIG_MTD_PHYSMAP_OF_GEMINI
+physmap_of-objs += physmap_of_gemini.o
+endif
 obj-$(CONFIG_MTD_PHYSMAP_OF)   += physmap_of.o
-obj-$(CONFIG_MTD_PHYSMAP_OF_VERSATILE) += physmap_of_versatile.o
-obj-$(CONFIG_MTD_PHYSMAP_OF_GEMINI)+= physmap_of_gemini.o
 obj-$(CONFIG_MTD_PISMO)+= pismo.o
 obj-$(CONFIG_MTD_PMC_MSP_EVM)   += pmcmsp-flash.o
 obj-$(CONFIG_MTD_PCMCIA)   += pcmciamtd.o

I'll cook that into a proper patch if it seems good.

> I have used the version fo the l2-mtd tree from next-20170208 for today.

Sounds good.

Brian


Re: linux-next: build failure after merge of the l2-mtd tree

2017-02-08 Thread Brian Norris
Hi,

On Thu, Feb 09, 2017 at 12:08:39PM +1100, Stephen Rothwell wrote:
> Hi Brian,
> 
> After merging the l2-mtd tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> ERROR: "of_flash_probe_versatile" [drivers/mtd/maps/physmap_of.ko] undefined!
> ERROR: "of_flash_probe_gemini" [drivers/mtd/maps/physmap_of.ko] undefined!
> 
> Probably caused by commit
> 
>   56ff337ea433 ("mtd: physmap_of: add a hook for Gemini flash probing")
> 
> The config has:
> 
> CONFIG_MTD_PHYSMAP=m
> CONFIG_MTD_PHYSMAP_COMPAT=y
> CONFIG_MTD_PHYSMAP_OF=m
> CONFIG_MTD_PHYSMAP_OF_VERSATILE=y
> CONFIG_MTD_PHYSMAP_OF_GEMINI=y
> 
> I am not sure why this is a problem, but previously physmap_of_versatile.o
> would have been in obj-m and it is now in obj-y.

I think this part of that change does it:

--- a/drivers/mtd/maps/Makefile
+++ b/drivers/mtd/maps/Makefile
@@ -18,9 +18,8 @@ obj-$(CONFIG_MTD_TSUNAMI) += tsunami_flash.o
 obj-$(CONFIG_MTD_PXA2XX)   += pxa2xx-flash.o
 obj-$(CONFIG_MTD_PHYSMAP)  += physmap.o
 obj-$(CONFIG_MTD_PHYSMAP_OF)   += physmap_of.o
-ifdef CONFIG_MTD_PHYSMAP_OF_VERSATILE
-obj-$(CONFIG_MTD_PHYSMAP_OF)   += physmap_of_versatile.o
-endif
+obj-$(CONFIG_MTD_PHYSMAP_OF_VERSATILE) += physmap_of_versatile.o
+obj-$(CONFIG_MTD_PHYSMAP_OF_GEMINI)+= physmap_of_gemini.o
 obj-$(CONFIG_MTD_PISMO)+= pismo.o
 obj-$(CONFIG_MTD_PMC_MSP_EVM)   += pmcmsp-flash.o
 obj-$(CONFIG_MTD_PCMCIA)   += pcmciamtd.o

We were previously just keeping physmap_of_versatile in sync with physmap_of.
So it could be a module, even though CONFIG_MTD_PHYSMAP_OF_VERSATILE was
'bool'.

This is kind of a weird scenario, since physmap_of actually depends on
*_versatile or *_gemini (when enabled). Maybe we should revert to something
like the original logic. We can even actually merge the 3 modules (and then
drop the EXPORT_*s too):

diff --git a/drivers/mtd/maps/Makefile b/drivers/mtd/maps/Makefile
index 2fec1e0c2371..aef1846b4de2 100644
--- a/drivers/mtd/maps/Makefile
+++ b/drivers/mtd/maps/Makefile
@@ -17,9 +17,13 @@ obj-$(CONFIG_MTD_CK804XROM)  += ck804xrom.o
 obj-$(CONFIG_MTD_TSUNAMI)  += tsunami_flash.o
 obj-$(CONFIG_MTD_PXA2XX)   += pxa2xx-flash.o
 obj-$(CONFIG_MTD_PHYSMAP)  += physmap.o
+ifdef CONFIG_MTD_PHYSMAP_OF_VERSATILE
+physmap_of-objs += physmap_of_versatile.o
+endif
+ifdef CONFIG_MTD_PHYSMAP_OF_GEMINI
+physmap_of-objs += physmap_of_gemini.o
+endif
 obj-$(CONFIG_MTD_PHYSMAP_OF)   += physmap_of.o
-obj-$(CONFIG_MTD_PHYSMAP_OF_VERSATILE) += physmap_of_versatile.o
-obj-$(CONFIG_MTD_PHYSMAP_OF_GEMINI)+= physmap_of_gemini.o
 obj-$(CONFIG_MTD_PISMO)+= pismo.o
 obj-$(CONFIG_MTD_PMC_MSP_EVM)   += pmcmsp-flash.o
 obj-$(CONFIG_MTD_PCMCIA)   += pcmciamtd.o

I'll cook that into a proper patch if it seems good.

> I have used the version fo the l2-mtd tree from next-20170208 for today.

Sounds good.

Brian


linux-next: build failure after merge of the l2-mtd tree

2017-02-08 Thread Stephen Rothwell
Hi Brian,

After merging the l2-mtd tree, today's linux-next build (x86_64
allmodconfig) failed like this:

ERROR: "of_flash_probe_versatile" [drivers/mtd/maps/physmap_of.ko] undefined!
ERROR: "of_flash_probe_gemini" [drivers/mtd/maps/physmap_of.ko] undefined!

Probably caused by commit

  56ff337ea433 ("mtd: physmap_of: add a hook for Gemini flash probing")

The config has:

CONFIG_MTD_PHYSMAP=m
CONFIG_MTD_PHYSMAP_COMPAT=y
CONFIG_MTD_PHYSMAP_OF=m
CONFIG_MTD_PHYSMAP_OF_VERSATILE=y
CONFIG_MTD_PHYSMAP_OF_GEMINI=y

I am not sure why this is a problem, but previously physmap_of_versatile.o
would have been in obj-m and it is now in obj-y.

I have used the version fo the l2-mtd tree from next-20170208 for today.

-- 
Cheers,
Stephen Rothwell


linux-next: build failure after merge of the l2-mtd tree

2017-02-08 Thread Stephen Rothwell
Hi Brian,

After merging the l2-mtd tree, today's linux-next build (x86_64
allmodconfig) failed like this:

ERROR: "of_flash_probe_versatile" [drivers/mtd/maps/physmap_of.ko] undefined!
ERROR: "of_flash_probe_gemini" [drivers/mtd/maps/physmap_of.ko] undefined!

Probably caused by commit

  56ff337ea433 ("mtd: physmap_of: add a hook for Gemini flash probing")

The config has:

CONFIG_MTD_PHYSMAP=m
CONFIG_MTD_PHYSMAP_COMPAT=y
CONFIG_MTD_PHYSMAP_OF=m
CONFIG_MTD_PHYSMAP_OF_VERSATILE=y
CONFIG_MTD_PHYSMAP_OF_GEMINI=y

I am not sure why this is a problem, but previously physmap_of_versatile.o
would have been in obj-m and it is now in obj-y.

I have used the version fo the l2-mtd tree from next-20170208 for today.

-- 
Cheers,
Stephen Rothwell


Re: linux-next: build failure after merge of the l2-mtd tree

2016-07-18 Thread Stephen Rothwell
Hi Brian,

On Mon, 18 Jul 2016 18:20:39 -0700 Brian Norris  
wrote:
>
> Known:
> 
> http://lists.infradead.org/pipermail/linux-mtd/2016-July/068569.html
> 
> > Missing include of linux/io.h ...  
> 
> It's not missing linux/io.h; x86 is missing readsl()/writesl(). If x86
> folks don't have a solution, then I guess we'll just make this depend on
> !X86.

or remove COMPILE_TEST if it can't compile for everyone ...

-- 
Cheers,
Stephen Rothwell


Re: linux-next: build failure after merge of the l2-mtd tree

2016-07-18 Thread Stephen Rothwell
Hi Brian,

On Mon, 18 Jul 2016 18:20:39 -0700 Brian Norris  
wrote:
>
> Known:
> 
> http://lists.infradead.org/pipermail/linux-mtd/2016-July/068569.html
> 
> > Missing include of linux/io.h ...  
> 
> It's not missing linux/io.h; x86 is missing readsl()/writesl(). If x86
> folks don't have a solution, then I guess we'll just make this depend on
> !X86.

or remove COMPILE_TEST if it can't compile for everyone ...

-- 
Cheers,
Stephen Rothwell


Re: linux-next: build failure after merge of the l2-mtd tree

2016-07-18 Thread Brian Norris
On Tue, Jul 19, 2016 at 10:59:30AM +1000, Stephen Rothwell wrote:
> Hi Brian,
> 
> After merging the l2-mtd tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> drivers/mtd/spi-nor/cadence-quadspi.c: In function 
> 'cqspi_indirect_read_execute':
> drivers/mtd/spi-nor/cadence-quadspi.c:529:4: error: implicit declaration of 
> function 'readsl' [-Werror=implicit-function-declaration]
> readsl(ahb_base, rxbuf, DIV_ROUND_UP(bytes_to_read, 4));
> ^
> drivers/mtd/spi-nor/cadence-quadspi.c: In function 
> 'cqspi_indirect_write_execute':
> drivers/mtd/spi-nor/cadence-quadspi.c:613:3: error: implicit declaration of 
> function 'writesl' [-Werror=implicit-function-declaration]
>writesl(cqspi->ahb_base, txbuf, DIV_ROUND_UP(write_bytes, 4));
>^
> 
> Caused by commit
> 
>   140623410536 ("mtd: spi-nor: Add driver for Cadence Quad SPI Flash 
> Controller")

Known:

http://lists.infradead.org/pipermail/linux-mtd/2016-July/068569.html

> Missing include of linux/io.h ...

It's not missing linux/io.h; x86 is missing readsl()/writesl(). If x86
folks don't have a solution, then I guess we'll just make this depend on
!X86.

> I have used the l2-mtd tree from next-20160718 for today.

Regards,
Brian


Re: linux-next: build failure after merge of the l2-mtd tree

2016-07-18 Thread Brian Norris
On Tue, Jul 19, 2016 at 10:59:30AM +1000, Stephen Rothwell wrote:
> Hi Brian,
> 
> After merging the l2-mtd tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> drivers/mtd/spi-nor/cadence-quadspi.c: In function 
> 'cqspi_indirect_read_execute':
> drivers/mtd/spi-nor/cadence-quadspi.c:529:4: error: implicit declaration of 
> function 'readsl' [-Werror=implicit-function-declaration]
> readsl(ahb_base, rxbuf, DIV_ROUND_UP(bytes_to_read, 4));
> ^
> drivers/mtd/spi-nor/cadence-quadspi.c: In function 
> 'cqspi_indirect_write_execute':
> drivers/mtd/spi-nor/cadence-quadspi.c:613:3: error: implicit declaration of 
> function 'writesl' [-Werror=implicit-function-declaration]
>writesl(cqspi->ahb_base, txbuf, DIV_ROUND_UP(write_bytes, 4));
>^
> 
> Caused by commit
> 
>   140623410536 ("mtd: spi-nor: Add driver for Cadence Quad SPI Flash 
> Controller")

Known:

http://lists.infradead.org/pipermail/linux-mtd/2016-July/068569.html

> Missing include of linux/io.h ...

It's not missing linux/io.h; x86 is missing readsl()/writesl(). If x86
folks don't have a solution, then I guess we'll just make this depend on
!X86.

> I have used the l2-mtd tree from next-20160718 for today.

Regards,
Brian


linux-next: build failure after merge of the l2-mtd tree

2016-07-18 Thread Stephen Rothwell
Hi Brian,

After merging the l2-mtd tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/mtd/spi-nor/cadence-quadspi.c: In function 
'cqspi_indirect_read_execute':
drivers/mtd/spi-nor/cadence-quadspi.c:529:4: error: implicit declaration of 
function 'readsl' [-Werror=implicit-function-declaration]
readsl(ahb_base, rxbuf, DIV_ROUND_UP(bytes_to_read, 4));
^
drivers/mtd/spi-nor/cadence-quadspi.c: In function 
'cqspi_indirect_write_execute':
drivers/mtd/spi-nor/cadence-quadspi.c:613:3: error: implicit declaration of 
function 'writesl' [-Werror=implicit-function-declaration]
   writesl(cqspi->ahb_base, txbuf, DIV_ROUND_UP(write_bytes, 4));
   ^

Caused by commit

  140623410536 ("mtd: spi-nor: Add driver for Cadence Quad SPI Flash 
Controller")

Missing include of linux/io.h ...

I have used the l2-mtd tree from next-20160718 for today.

-- 
Cheers,
Stephen Rothwell


linux-next: build failure after merge of the l2-mtd tree

2016-07-18 Thread Stephen Rothwell
Hi Brian,

After merging the l2-mtd tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/mtd/spi-nor/cadence-quadspi.c: In function 
'cqspi_indirect_read_execute':
drivers/mtd/spi-nor/cadence-quadspi.c:529:4: error: implicit declaration of 
function 'readsl' [-Werror=implicit-function-declaration]
readsl(ahb_base, rxbuf, DIV_ROUND_UP(bytes_to_read, 4));
^
drivers/mtd/spi-nor/cadence-quadspi.c: In function 
'cqspi_indirect_write_execute':
drivers/mtd/spi-nor/cadence-quadspi.c:613:3: error: implicit declaration of 
function 'writesl' [-Werror=implicit-function-declaration]
   writesl(cqspi->ahb_base, txbuf, DIV_ROUND_UP(write_bytes, 4));
   ^

Caused by commit

  140623410536 ("mtd: spi-nor: Add driver for Cadence Quad SPI Flash 
Controller")

Missing include of linux/io.h ...

I have used the l2-mtd tree from next-20160718 for today.

-- 
Cheers,
Stephen Rothwell


linux-next: build failure after merge of the l2-mtd tree

2015-12-20 Thread Stephen Rothwell
Hi Brian,

After merging the l2-mtd tree, today's linux-next build (powerpc
ppc44x_defconfig) failed like this:

drivers/mtd/nand/ndfc.c: In function 'ndfc_chip_init':
drivers/mtd/nand/ndfc.c:177:2: error: 'ppdata' undeclared (first use in this 
function)
  ppdata.of_node = flash_np;
  ^

Caused by commit

  a61ae81a1907 ("mtd: nand: drop unnecessary partition parser data")

I applied this fix patch for today:

From: Stephen Rothwell 
Date: Mon, 21 Dec 2015 16:44:57 +1100
Subject: [PATCH] mtd: nand: fix for drop unnecessary partition parser data

Signed-off-by: Stephen Rothwell 
---
 drivers/mtd/nand/ndfc.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/mtd/nand/ndfc.c b/drivers/mtd/nand/ndfc.c
index 0709ea9dd8ed..7d72f4fe06a1 100644
--- a/drivers/mtd/nand/ndfc.c
+++ b/drivers/mtd/nand/ndfc.c
@@ -174,7 +174,6 @@ static int ndfc_chip_init(struct ndfc_controller *ndfc,
return -ENODEV;
nand_set_flash_node(chip, flash_np);
 
-   ppdata.of_node = flash_np;
mtd->name = kasprintf(GFP_KERNEL, "%s.%s", dev_name(>ofdev->dev),
  flash_np->name);
if (!mtd->name) {
-- 
2.6.2

-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


linux-next: build failure after merge of the l2-mtd tree

2015-12-20 Thread Stephen Rothwell
Hi Brian,

After merging the l2-mtd tree, today's linux-next build (powerpc
ppc44x_defconfig) failed like this:

drivers/mtd/nand/ndfc.c: In function 'ndfc_chip_init':
drivers/mtd/nand/ndfc.c:177:2: error: 'ppdata' undeclared (first use in this 
function)
  ppdata.of_node = flash_np;
  ^

Caused by commit

  a61ae81a1907 ("mtd: nand: drop unnecessary partition parser data")

I applied this fix patch for today:

From: Stephen Rothwell 
Date: Mon, 21 Dec 2015 16:44:57 +1100
Subject: [PATCH] mtd: nand: fix for drop unnecessary partition parser data

Signed-off-by: Stephen Rothwell 
---
 drivers/mtd/nand/ndfc.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/mtd/nand/ndfc.c b/drivers/mtd/nand/ndfc.c
index 0709ea9dd8ed..7d72f4fe06a1 100644
--- a/drivers/mtd/nand/ndfc.c
+++ b/drivers/mtd/nand/ndfc.c
@@ -174,7 +174,6 @@ static int ndfc_chip_init(struct ndfc_controller *ndfc,
return -ENODEV;
nand_set_flash_node(chip, flash_np);
 
-   ppdata.of_node = flash_np;
mtd->name = kasprintf(GFP_KERNEL, "%s.%s", dev_name(>ofdev->dev),
  flash_np->name);
if (!mtd->name) {
-- 
2.6.2

-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


linux-next: build failure after merge of the l2-mtd tree

2015-09-29 Thread Stephen Rothwell
Hi Brian,

After merging the l2-mtd tree, today's linux-next build (powerpc
allyesconfig) failed like this:

drivers/mtd/nand/vf610_nfc.c: In function 'vf610_nfc_resume':
drivers/mtd/nand/vf610_nfc.c:859:2: error: implicit declaration of function 
'pinctrl_pm_select_default_state' [-Werror=implicit-function-declaration]
  pinctrl_pm_select_default_state(dev);
  ^

Caused by commit

  456930d80a2d ("mtd: nand: vf610_nfc: Freescale NFC for VF610, MPC5125 and 
others")

I have reverted that commit (and the following one) for today.

-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


linux-next: build failure after merge of the l2-mtd tree

2015-09-29 Thread Stephen Rothwell
Hi Brian,

After merging the l2-mtd tree, today's linux-next build (powerpc
allyesconfig) failed like this:

drivers/mtd/nand/vf610_nfc.c: In function 'vf610_nfc_resume':
drivers/mtd/nand/vf610_nfc.c:859:2: error: implicit declaration of function 
'pinctrl_pm_select_default_state' [-Werror=implicit-function-declaration]
  pinctrl_pm_select_default_state(dev);
  ^

Caused by commit

  456930d80a2d ("mtd: nand: vf610_nfc: Freescale NFC for VF610, MPC5125 and 
others")

I have reverted that commit (and the following one) for today.

-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: linux-next: build failure after merge of the l2-mtd tree

2014-05-27 Thread Stephen Rothwell
Hi Artem,

On Tue, 27 May 2014 13:40:03 +0300 Artem Bityutskiy  wrote:
>
> apologies for not informing you about the onwership changes in time. But
> yes, Brian takes care of this tree now.

OK, thanks.

> The URL you have is technically correct, but it is better to use this
> instead:
> 
> git://git.infradead.org/l2-mtd.git#master

I have changed to use that.

-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


signature.asc
Description: PGP signature


Re: linux-next: build failure after merge of the l2-mtd tree

2014-05-27 Thread Artem Bityutskiy
On Tue, 2014-05-27 at 09:59 +1000, Stephen Rothwell wrote:
> Hi Brian,
> 
> On Mon, 26 May 2014 10:42:25 -0700 Brian Norris  
> wrote:
> >
> > On Thu, May 22, 2014 at 03:30:47PM +1000, Stephen Rothwell wrote:
> > > Hi Artem,
> > 
> > FYI, I'm managing this tree now, not Artem.
> 
> OK, noted.  Is there a different URL for the tree as well?  Currently
> it is git://git.infradead.org/users/dedekind/l2-mtd-2.6.git#master .

Hi Stephen,

apologies for not informing you about the onwership changes in time. But
yes, Brian takes care of this tree now.

The URL you have is technically correct, but it is better to use this
instead:

git://git.infradead.org/l2-mtd.git#master

The old URL is just a symlink to the above one nowadays. Thanks!

-- 
Best Regards,
Artem Bityutskiy

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: linux-next: build failure after merge of the l2-mtd tree

2014-05-27 Thread Artem Bityutskiy
On Tue, 2014-05-27 at 09:59 +1000, Stephen Rothwell wrote:
 Hi Brian,
 
 On Mon, 26 May 2014 10:42:25 -0700 Brian Norris computersforpe...@gmail.com 
 wrote:
 
  On Thu, May 22, 2014 at 03:30:47PM +1000, Stephen Rothwell wrote:
   Hi Artem,
  
  FYI, I'm managing this tree now, not Artem.
 
 OK, noted.  Is there a different URL for the tree as well?  Currently
 it is git://git.infradead.org/users/dedekind/l2-mtd-2.6.git#master .

Hi Stephen,

apologies for not informing you about the onwership changes in time. But
yes, Brian takes care of this tree now.

The URL you have is technically correct, but it is better to use this
instead:

git://git.infradead.org/l2-mtd.git#master

The old URL is just a symlink to the above one nowadays. Thanks!

-- 
Best Regards,
Artem Bityutskiy

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: linux-next: build failure after merge of the l2-mtd tree

2014-05-27 Thread Stephen Rothwell
Hi Artem,

On Tue, 27 May 2014 13:40:03 +0300 Artem Bityutskiy dedeki...@gmail.com wrote:

 apologies for not informing you about the onwership changes in time. But
 yes, Brian takes care of this tree now.

OK, thanks.

 The URL you have is technically correct, but it is better to use this
 instead:
 
 git://git.infradead.org/l2-mtd.git#master

I have changed to use that.

-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


signature.asc
Description: PGP signature


Re: linux-next: build failure after merge of the l2-mtd tree

2014-05-26 Thread Stephen Rothwell
Hi Brian,

On Mon, 26 May 2014 10:42:25 -0700 Brian Norris  
wrote:
>
> On Thu, May 22, 2014 at 03:30:47PM +1000, Stephen Rothwell wrote:
> > Hi Artem,
> 
> FYI, I'm managing this tree now, not Artem.

OK, noted.  Is there a different URL for the tree as well?  Currently
it is git://git.infradead.org/users/dedekind/l2-mtd-2.6.git#master .

Here is the legalese:

Thanks for adding your subsystem tree as a participant of linux-next.  As
you may know, this is not a judgment of your code.  The purpose of
linux-next is for integration testing and to lower the impact of
conflicts between subsystems in the next merge window. 

You will need to ensure that the patches/commits in your tree/series have
been:
 * submitted under GPL v2 (or later) and include the Contributor's
Signed-off-by,
 * posted to the relevant mailing list,
 * reviewed by you (or another maintainer of your subsystem tree),
 * successfully unit tested, and 
 * destined for the current or next Linux merge window.

Basically, this should be just what you would send to Linus (or ask him
to fetch).  It is allowed to be rebased if you deem it necessary.

-- 
Cheers,
Stephen Rothwell 
s...@canb.auug.org.au


signature.asc
Description: PGP signature


Re: linux-next: build failure after merge of the l2-mtd tree

2014-05-26 Thread Brian Norris
Hi Stephen,

On Thu, May 22, 2014 at 03:30:47PM +1000, Stephen Rothwell wrote:
> Hi Artem,

FYI, I'm managing this tree now, not Artem.

> After merging the l2-mtd tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> drivers/mtd/lpddr/lpddr2_nvm.c: In function 'ow_enable':
> drivers/mtd/lpddr/lpddr2_nvm.c:149:2: error: implicit declaration of function 
> 'writel_relaxed' [-Werror=implicit-function-declaration]
>   writel_relaxed(build_mr_cfgmask(pcm_data->bus_width) | 0x18,
>   ^
> 
> Caused by commit 96ba9dd65788 ("mtd: lpddr: add driver for LPDDR2-NVM
> PCM memories").

Vincenzo and I have already identified the build failure. It's because
the I/O accessors are not implemented uniformly across architectures.
I just pushed a patch to restrict this driver to ARM for now, but I hope
this inconsistency will be improved soon. (I believe there's a patch
series out there right now.)

> I have used the l2-mtd tree from next-20140521 for today.

Thanks, and thanks for the report.

Regards,
Brian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: linux-next: build failure after merge of the l2-mtd tree

2014-05-26 Thread Brian Norris
Hi Stephen,

On Thu, May 22, 2014 at 03:30:47PM +1000, Stephen Rothwell wrote:
 Hi Artem,

FYI, I'm managing this tree now, not Artem.

 After merging the l2-mtd tree, today's linux-next build (x86_64
 allmodconfig) failed like this:
 
 drivers/mtd/lpddr/lpddr2_nvm.c: In function 'ow_enable':
 drivers/mtd/lpddr/lpddr2_nvm.c:149:2: error: implicit declaration of function 
 'writel_relaxed' [-Werror=implicit-function-declaration]
   writel_relaxed(build_mr_cfgmask(pcm_data-bus_width) | 0x18,
   ^
 
 Caused by commit 96ba9dd65788 (mtd: lpddr: add driver for LPDDR2-NVM
 PCM memories).

Vincenzo and I have already identified the build failure. It's because
the I/O accessors are not implemented uniformly across architectures.
I just pushed a patch to restrict this driver to ARM for now, but I hope
this inconsistency will be improved soon. (I believe there's a patch
series out there right now.)

 I have used the l2-mtd tree from next-20140521 for today.

Thanks, and thanks for the report.

Regards,
Brian
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: linux-next: build failure after merge of the l2-mtd tree

2014-05-26 Thread Stephen Rothwell
Hi Brian,

On Mon, 26 May 2014 10:42:25 -0700 Brian Norris computersforpe...@gmail.com 
wrote:

 On Thu, May 22, 2014 at 03:30:47PM +1000, Stephen Rothwell wrote:
  Hi Artem,
 
 FYI, I'm managing this tree now, not Artem.

OK, noted.  Is there a different URL for the tree as well?  Currently
it is git://git.infradead.org/users/dedekind/l2-mtd-2.6.git#master .

Here is the legalese:

Thanks for adding your subsystem tree as a participant of linux-next.  As
you may know, this is not a judgment of your code.  The purpose of
linux-next is for integration testing and to lower the impact of
conflicts between subsystems in the next merge window. 

You will need to ensure that the patches/commits in your tree/series have
been:
 * submitted under GPL v2 (or later) and include the Contributor's
Signed-off-by,
 * posted to the relevant mailing list,
 * reviewed by you (or another maintainer of your subsystem tree),
 * successfully unit tested, and 
 * destined for the current or next Linux merge window.

Basically, this should be just what you would send to Linus (or ask him
to fetch).  It is allowed to be rebased if you deem it necessary.

-- 
Cheers,
Stephen Rothwell 
s...@canb.auug.org.au


signature.asc
Description: PGP signature


linux-next: build failure after merge of the l2-mtd tree

2014-05-21 Thread Stephen Rothwell
Hi Artem,

After merging the l2-mtd tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/mtd/lpddr/lpddr2_nvm.c: In function 'ow_enable':
drivers/mtd/lpddr/lpddr2_nvm.c:149:2: error: implicit declaration of function 
'writel_relaxed' [-Werror=implicit-function-declaration]
  writel_relaxed(build_mr_cfgmask(pcm_data->bus_width) | 0x18,
  ^

Caused by commit 96ba9dd65788 ("mtd: lpddr: add driver for LPDDR2-NVM
PCM memories").

I have used the l2-mtd tree from next-20140521 for today.
-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


signature.asc
Description: PGP signature


linux-next: build failure after merge of the l2-mtd tree

2014-05-21 Thread Stephen Rothwell
Hi Artem,

After merging the l2-mtd tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/mtd/lpddr/lpddr2_nvm.c: In function 'ow_enable':
drivers/mtd/lpddr/lpddr2_nvm.c:149:2: error: implicit declaration of function 
'writel_relaxed' [-Werror=implicit-function-declaration]
  writel_relaxed(build_mr_cfgmask(pcm_data-bus_width) | 0x18,
  ^

Caused by commit 96ba9dd65788 (mtd: lpddr: add driver for LPDDR2-NVM
PCM memories).

I have used the l2-mtd tree from next-20140521 for today.
-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


signature.asc
Description: PGP signature


Re: linux-next: build failure after merge of the l2-mtd tree

2012-10-18 Thread Artem Bityutskiy
On Thu, 2012-10-18 at 11:28 +1100, Stephen Rothwell wrote:
> Hi Artem,
> 
> On Fri, 12 Oct 2012 11:14:51 +1100 Stephen Rothwell  
> wrote:
> >
> > After merging the l2-mtd tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> > 
> > ERROR: "denali_init" [drivers/mtd/nand/denali_pci.ko] undefined!
> > ERROR: "denali_remove" [drivers/mtd/nand/denali_pci.ko] undefined!
> > 
> > Probably caused by commit 305b1ee29c8e ("mtd: denali: split the generic
> > driver and PCI layer").
> > 
> > I have used the l2-mtd tree from next-20121011 for today.
> 
> This is still broken today.

Sorry for slowness, now it should be fixed.

-- 
Best Regards,
Artem Bityutskiy


signature.asc
Description: This is a digitally signed message part


Re: linux-next: build failure after merge of the l2-mtd tree

2012-10-18 Thread Artem Bityutskiy
On Thu, 2012-10-18 at 11:28 +1100, Stephen Rothwell wrote:
 Hi Artem,
 
 On Fri, 12 Oct 2012 11:14:51 +1100 Stephen Rothwell s...@canb.auug.org.au 
 wrote:
 
  After merging the l2-mtd tree, today's linux-next build (x86_64
  allmodconfig) failed like this:
  
  ERROR: denali_init [drivers/mtd/nand/denali_pci.ko] undefined!
  ERROR: denali_remove [drivers/mtd/nand/denali_pci.ko] undefined!
  
  Probably caused by commit 305b1ee29c8e (mtd: denali: split the generic
  driver and PCI layer).
  
  I have used the l2-mtd tree from next-20121011 for today.
 
 This is still broken today.

Sorry for slowness, now it should be fixed.

-- 
Best Regards,
Artem Bityutskiy


signature.asc
Description: This is a digitally signed message part


Re: linux-next: build failure after merge of the l2-mtd tree

2012-10-17 Thread Stephen Rothwell
Hi Artem,

On Fri, 12 Oct 2012 11:14:51 +1100 Stephen Rothwell  
wrote:
>
> After merging the l2-mtd tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> ERROR: "denali_init" [drivers/mtd/nand/denali_pci.ko] undefined!
> ERROR: "denali_remove" [drivers/mtd/nand/denali_pci.ko] undefined!
> 
> Probably caused by commit 305b1ee29c8e ("mtd: denali: split the generic
> driver and PCI layer").
> 
> I have used the l2-mtd tree from next-20121011 for today.

This is still broken today.
-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


pgp8e3vjV3HM7.pgp
Description: PGP signature


Re: linux-next: build failure after merge of the l2-mtd tree

2012-10-17 Thread Stephen Rothwell
Hi Artem,

On Fri, 12 Oct 2012 11:14:51 +1100 Stephen Rothwell s...@canb.auug.org.au 
wrote:

 After merging the l2-mtd tree, today's linux-next build (x86_64
 allmodconfig) failed like this:
 
 ERROR: denali_init [drivers/mtd/nand/denali_pci.ko] undefined!
 ERROR: denali_remove [drivers/mtd/nand/denali_pci.ko] undefined!
 
 Probably caused by commit 305b1ee29c8e (mtd: denali: split the generic
 driver and PCI layer).
 
 I have used the l2-mtd tree from next-20121011 for today.

This is still broken today.
-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


pgp8e3vjV3HM7.pgp
Description: PGP signature


Re: linux-next: build failure after merge of the l2-mtd tree

2012-10-11 Thread Dinh Nguyen
Hi Stephen,

On Fri, 2012-10-12 at 11:14 +1100, Stephen Rothwell wrote:
> Hi Artem,
> 
> After merging the l2-mtd tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> ERROR: "denali_init" [drivers/mtd/nand/denali_pci.ko] undefined!
> ERROR: "denali_remove" [drivers/mtd/nand/denali_pci.ko] undefined!
> 
> Probably caused by commit 305b1ee29c8e ("mtd: denali: split the generic
> driver and PCI layer").
> 
> I have used the l2-mtd tree from next-20121011 for today.

Sorry about that. I just sent a patch to fix this. Please disregard the
first email, I forgot to include Artem in the email.

Thanks,
Dinh



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


linux-next: build failure after merge of the l2-mtd tree

2012-10-11 Thread Stephen Rothwell
Hi Artem,

After merging the l2-mtd tree, today's linux-next build (x86_64
allmodconfig) failed like this:

ERROR: "denali_init" [drivers/mtd/nand/denali_pci.ko] undefined!
ERROR: "denali_remove" [drivers/mtd/nand/denali_pci.ko] undefined!

Probably caused by commit 305b1ee29c8e ("mtd: denali: split the generic
driver and PCI layer").

I have used the l2-mtd tree from next-20121011 for today.
-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


pgpy1SbpHtmy4.pgp
Description: PGP signature


linux-next: build failure after merge of the l2-mtd tree

2012-10-11 Thread Stephen Rothwell
Hi Artem,

After merging the l2-mtd tree, today's linux-next build (x86_64
allmodconfig) failed like this:

ERROR: denali_init [drivers/mtd/nand/denali_pci.ko] undefined!
ERROR: denali_remove [drivers/mtd/nand/denali_pci.ko] undefined!

Probably caused by commit 305b1ee29c8e (mtd: denali: split the generic
driver and PCI layer).

I have used the l2-mtd tree from next-20121011 for today.
-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


pgpy1SbpHtmy4.pgp
Description: PGP signature


Re: linux-next: build failure after merge of the l2-mtd tree

2012-10-11 Thread Dinh Nguyen
Hi Stephen,

On Fri, 2012-10-12 at 11:14 +1100, Stephen Rothwell wrote:
 Hi Artem,
 
 After merging the l2-mtd tree, today's linux-next build (x86_64
 allmodconfig) failed like this:
 
 ERROR: denali_init [drivers/mtd/nand/denali_pci.ko] undefined!
 ERROR: denali_remove [drivers/mtd/nand/denali_pci.ko] undefined!
 
 Probably caused by commit 305b1ee29c8e (mtd: denali: split the generic
 driver and PCI layer).
 
 I have used the l2-mtd tree from next-20121011 for today.

Sorry about that. I just sent a patch to fix this. Please disregard the
first email, I forgot to include Artem in the email.

Thanks,
Dinh



--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/